Re: [4.4-stable PATCH 0/2] libnvdimm: stable fixes for 4.4

2017-04-25 Thread Greg KH
On Wed, Apr 19, 2017 at 10:05:41AM -0700, Dan Williams wrote: > Hi -stable team, > > Here is a backport for commit 11e63f6d920d "x86, pmem: fix broken > __copy_user_nocache cache-bypass assumptions", and another block layer > fix that allows the libnvdimm unit tests to run. > > I have copied

Re: [4.9-stable PATCH] device-dax: fix sysfs duplicate warnings

2017-08-04 Thread Greg KH
On Thu, Aug 03, 2017 at 05:25:02PM -0700, Dan Williams wrote: > commit bbb3be170ac2891526ad07b18af7db226879a8e7 upstream. > > Fix warnings of the form... > > WARNING: CPU: 10 PID: 4983 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x62/0x80 > sysfs: cannot create duplicate filename

Re: [RFC] UAPI: Check headers by compiling all together as C++

2018-09-05 Thread Greg KH
On Wed, Sep 05, 2018 at 04:54:27PM +0100, David Howells wrote: > > Here's a set of patches that inserts a step into the build process to make > sure that the UAPI headers can all be built together with C++ (if the > compiler being used supports C++). All but the final patch perform fixups, >

Re: [PATCH] uio: fix is_source param for check_copy_size() in copy_to_iter_mcsafe()

2018-09-12 Thread Greg KH
On Wed, Sep 05, 2018 at 01:31:40PM -0700, Dave Jiang wrote: > copy_to_iter_mcsafe() is passing in the is_source parameter as "false" > to check_copy_size(). This is different than what copy_to_iter() does. > Also, the addr parameter passed to check_copy_size() is the source so > therefore we

Re: [4.18-stable PATCH] acpi, nfit: Fix Address Range Scrub completion tracking

2018-11-10 Thread Greg KH
On Sat, Nov 10, 2018 at 09:47:12AM -0800, Dan Williams wrote: > commit d3abaf43bab8d5b0a3c6b982100d9e2be96de4ad upstream. > > The Address Range Scrub implementation tried to skip running scrubs > against ranges that were already scrubbed by the BIOS. Unfortunately > that support also resulted in

Re: [driver-core PATCH v6 2/9] async: Add support for queueing on specific NUMA node

2018-11-11 Thread Greg KH
On Sun, Nov 11, 2018 at 08:59:03PM +0100, Pavel Machek wrote: > On Sun 2018-11-11 11:32:08, Greg KH wrote: > > On Thu, Nov 08, 2018 at 10:06:50AM -0800, Alexander Duyck wrote: > > > Introduce four new variants of the async_schedule_ functions that allow > > > schedul

Re: [driver-core PATCH v6 2/9] async: Add support for queueing on specific NUMA node

2018-11-11 Thread Greg KH
On Sun, Nov 11, 2018 at 11:53:20AM -0800, Dan Williams wrote: > On Sun, Nov 11, 2018 at 11:32 AM Greg KH wrote: > > > > On Thu, Nov 08, 2018 at 10:06:50AM -0800, Alexander Duyck wrote: > > > Introduce four new variants of the async_schedule_ functions that allow > &

Re: [driver-core PATCH v6 2/9] async: Add support for queueing on specific NUMA node

2018-11-11 Thread Greg KH
On Thu, Nov 08, 2018 at 10:06:50AM -0800, Alexander Duyck wrote: > Introduce four new variants of the async_schedule_ functions that allow > scheduling on a specific NUMA node. > > The first two functions are async_schedule_near and > async_schedule_near_domain end up mapping to async_schedule

Re: [driver-core PATCH v9 1/9] driver core: Establish order of operations for device_add and device_del via bitflag

2019-01-18 Thread Greg KH
On Wed, Dec 12, 2018 at 04:44:58PM -0800, Alexander Duyck wrote: > Add an additional bit flag to the device struct named "dead". > > This additional flag provides a guarantee that when a device_del is > executed on a given interface an async worker will not attempt to attach > the driver

Re: FAILED: patch "[PATCH] dax: Don't access a freed inode" failed to apply to 4.19-stable tree

2018-12-13 Thread Greg KH
On Tue, Dec 11, 2018 at 07:23:49AM -0800, Matthew Wilcox wrote: > On Tue, Dec 11, 2018 at 03:00:09PM +0100, gre...@linuxfoundation.org wrote: > > > > The patch below does not apply to the 4.19-stable tree. > > If someone wants it applied there, or to any other stable or longterm > > tree, then

Re: [4.19-stable PATCH] dax: Avoid losing wakeup in dax_lock_mapping_entry

2018-11-29 Thread Greg KH
On Wed, Nov 28, 2018 at 10:53:44AM -0800, Dan Williams wrote: > From: Matthew Wilcox > > commit 25bbe21bf427a81b8e3ccd480ea0e1d940256156 upstream. > > After calling get_unlocked_entry(), you have to call > put_unlocked_entry() to avoid subsequent waiters losing wakeups. > > Fixes: c2a7d2a11552

Re: [PATCH] uio: fix is_source param for check_copy_size() in copy_to_iter_mcsafe()

2018-09-12 Thread Greg KH
On Wed, Sep 12, 2018 at 02:51:53PM -0700, Dan Williams wrote: > On Wed, Sep 12, 2018 at 12:48 AM, Greg KH wrote: > > On Wed, Sep 05, 2018 at 01:31:40PM -0700, Dave Jiang wrote: > >> copy_to_iter_mcsafe() is passing in the is_source parameter as "false" > >> to

Re: [PATCH] nfit: Collect shutdown status for NVDIMM_FAMILY_HYPERV

2019-01-30 Thread Greg KH
On Wed, Jan 30, 2019 at 06:48:40PM +, Dexuan Cui wrote: > > See http://www.uefi.org/RFIC_LIST ("Virtual NVDIMM 0x1901"): > "Get Unsafe Shutdown Count (Function Index 2)". > > Let's expose the info to the userspace (e.g. ntctl) via sysfs. If you add a new sysfs file, you need to add a new

Re: [driver-core PATCH v10 0/9] Add NUMA aware async_schedule calls

2019-01-31 Thread Greg KH
On Tue, Jan 22, 2019 at 10:39:05AM -0800, Alexander Duyck wrote: > This patch set provides functionality that will help to improve the > locality of the async_schedule calls used to provide deferred > initialization. > > This patch set originally started out focused on just the one call to >

Re: [for-4.14.y PATCH] libnvdimm/namespace: Fix label tracking error

2019-05-27 Thread Greg KH
On Sat, May 25, 2019 at 04:03:49PM -0700, Dan Williams wrote: > commit c4703ce11c23423d4b46e3d59aef7979814fd608 upstream. > Thanks for both of these, now queued up. greg k-h ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org

Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-05-07 Thread Greg KH
On Mon, May 06, 2019 at 08:14:12PM -0700, Frank Rowand wrote: > On 5/1/19 4:01 PM, Brendan Higgins wrote: > > ## TLDR > > > > I rebased the last patchset on 5.1-rc7 in hopes that we can get this in > > 5.2. > > > > Shuah, I think you, Greg KH, and myself

Re: [PATCH v2 07/17] kunit: test: add initial tests

2019-05-02 Thread Greg KH
On Wed, May 01, 2019 at 04:01:16PM -0700, Brendan Higgins wrote: > Add a test for string stream along with a simpler example. > > Signed-off-by: Brendan Higgins > --- > kunit/Kconfig | 12 ++ > kunit/Makefile | 4 ++ > kunit/example-test.c | 88

Re: [PATCH v2 04/17] kunit: test: add kunit_stream a std::stream like logger

2019-05-02 Thread Greg KH
On Wed, May 01, 2019 at 04:01:13PM -0700, Brendan Higgins wrote: > A lot of the expectation and assertion infrastructure prints out fairly > complicated test failure messages, so add a C++ style log library for > for logging test results. Ideally we would always use a standard logging format,

Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-05-02 Thread Greg KH
On Thu, May 02, 2019 at 12:50:53PM +0200, Greg KH wrote: > On Wed, May 01, 2019 at 04:01:09PM -0700, Brendan Higgins wrote: > > ## TLDR > > > > I rebased the last patchset on 5.1-rc7 in hopes that we can get this in > > 5.2. > > That might be rushing it, norm

Re: [PATCH v2 16/17] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()

2019-05-02 Thread Greg KH
On Wed, May 01, 2019 at 04:01:25PM -0700, Brendan Higgins wrote: > From: Iurii Zaikin > > KUnit tests for initialized data behavior of proc_dointvec that is > explicitly checked in the code. Includes basic parsing tests including > int min/max overflow. > > Signed-off-by: Iurii Zaikin >

Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-05-02 Thread Greg KH
ah, I think you, Greg KH, and myself talked off thread, and we agreed > we would merge through your tree when the time came? Am I remembering > correctly? No objection from me. Let me go review the latest round of patches now. thanks, greg k-h ___

Re: [PATCH v2 12/17] kunit: tool: add Python wrappers for running KUnit tests

2019-05-02 Thread Greg KH
On Wed, May 01, 2019 at 04:01:21PM -0700, Brendan Higgins wrote: > From: Felix Guo > > The ultimate goal is to create minimal isolated test binaries; in the > meantime we are using UML to provide the infrastructure to run tests, so > define an abstract way to configure and run tests that allow

Re: [PATCH v2 12/17] kunit: tool: add Python wrappers for running KUnit tests

2019-05-04 Thread Greg KH
On Fri, May 03, 2019 at 04:14:49PM -0700, Brendan Higgins wrote: > In any case, it sounds like you and Greg are in agreement on the core > libraries generating the output in TAP13, so I won't argue that point > further. Great! > ## Analysis of using TAP13 > > One of my earlier concerns was that

Re: [PATCH v2 16/17] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()

2019-05-04 Thread Greg KH
On Fri, May 03, 2019 at 04:41:10PM -0700, Brendan Higgins wrote: > > On Thu, May 02, 2019 at 11:45:43AM -0700, Brendan Higgins wrote: > > > On Thu, May 2, 2019 at 11:15 AM wrote: > > > > > > > > > > > > > > > > > -Original Me

Re: [PATCH v2 16/17] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()

2019-05-03 Thread Greg KH
On Thu, May 02, 2019 at 11:45:43AM -0700, Brendan Higgins wrote: > On Thu, May 2, 2019 at 11:15 AM wrote: > > > > > > > > > -Original Message- > > > From: Greg KH > > > > > > On Wed, May 01, 2019 at 04:01:25PM -0700, Brendan Higgins

Re: [PATCH v2 12/17] kunit: tool: add Python wrappers for running KUnit tests

2019-05-03 Thread Greg KH
On Thu, May 02, 2019 at 04:45:29PM -0700, Brendan Higgins wrote: > On Thu, May 2, 2019 at 2:16 PM Frank Rowand wrote: > > > > On 5/2/19 11:07 AM, Brendan Higgins wrote: > > > On Thu, May 2, 2019 at 4:02 AM Greg KH wrote: > > >> > > >> On Wed, M

Re: [Ksummit-discuss] [PATCH v2 3/3] libnvdimm, MAINTAINERS: Maintainer Entry Profile

2019-09-12 Thread Greg KH
On Fri, Sep 13, 2019 at 07:41:55AM +0530, Aneesh Kumar K.V wrote: > On 9/12/19 12:13 AM, Dan Carpenter wrote: > > On Wed, Sep 11, 2019 at 08:48:59AM -0700, Dan Williams wrote: > > > +Coding Style Addendum > > > +- > > > +libnvdimm expects multi-line statements to be double

Re: [5.4-stable PATCH 0/7] libnvdimm: Cross-arch compatible namespace alignment

2020-05-22 Thread Greg KH
On Fri, May 22, 2020 at 01:58:00PM +0200, Greg KH wrote: > On Thu, May 21, 2020 at 04:37:43PM -0700, Dan Williams wrote: > > Hello stable team, > > > > These patches have been shipping in mainline since v5.7-rc1 with no > > reported issues. They address long stand

Re: [5.4-stable PATCH 0/7] libnvdimm: Cross-arch compatible namespace alignment

2020-05-22 Thread Greg KH
On Thu, May 21, 2020 at 04:37:43PM -0700, Dan Williams wrote: > Hello stable team, > > These patches have been shipping in mainline since v5.7-rc1 with no > reported issues. They address long standing problems in libnvdimm's > handling of namespace provisioning relative to alignment constraints >

Re: [RFC] treewide: cleanup unreachable breaks

2020-10-17 Thread Greg KH
On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote: > From: Tom Rix > > This is a upcoming change to clean up a new warning treewide. > I am wondering if the change could be one mega patch (see below) or > normal patch per file about 100 patches or somewhere half way by collecting >

Re: [5.4-stable PATCH 0/7] libnvdimm: Cross-arch compatible namespace alignment

2020-06-01 Thread Greg KH
On Tue, May 26, 2020 at 01:52:21PM -0700, Dan Williams wrote: > On Tue, May 26, 2020 at 1:49 PM Jeff Moyer wrote: > > > > Dan Williams writes: > > > > >> What problems with 5.4.y and 5.6.y is this series fixing > > >> that used to work before? > > > > > > The "used to work" bug fixed by this set

Re: PROBLEM: 5.9.0-rc6 fails to compile due to 'redefinition of ‘dax_supported’'

2020-09-21 Thread Greg KH
On Mon, Sep 21, 2020 at 11:34:17AM +0530, Naresh Kamboju wrote: > On Mon, 21 Sep 2020 at 06:34, Stuart Little wrote: > > > > I am trying to compile for an x86_64 machine (Intel(R) Core(TM) i7-7500U > > CPU @ 2.70GHz). The config file I am currently using is at > > > > https://termbin.com/xin7 >

Re: [PATCH V2 05/10] x86/pks: Add PKS kernel API

2020-11-02 Thread Greg KH
On Mon, Nov 02, 2020 at 12:53:15PM -0800, ira.we...@intel.com wrote: > From: Fenghua Yu > > PKS allows kernel users to define domains of page mappings which have > additional protections beyond the paging protections. > > Add an API to allocate, use, and free a protection key which identifies >

Re: [PATCH V2 05/10] x86/pks: Add PKS kernel API

2020-11-03 Thread Greg KH
On Tue, Nov 03, 2020 at 09:53:36AM -0800, Ira Weiny wrote: > On Tue, Nov 03, 2020 at 07:50:24AM +0100, Greg KH wrote: > > On Mon, Nov 02, 2020 at 12:53:15PM -0800, ira.we...@intel.com wrote: > > > From: Fenghua Yu > > > > > [snip] > > > > diff

Re: [PATCH 1/3] cdev: Finish the cdev api with queued mode support

2021-01-21 Thread Greg KH
On Wed, Jan 20, 2021 at 11:38:57AM -0800, Dan Williams wrote: > -void cdev_del(struct cdev *p) > +void cdev_del(struct cdev *cdev) > { > - cdev_unmap(p->dev, p->count); > - kobject_put(>kobj); > + cdev_unmap(cdev->dev, cdev->count); > + kobject_put(>kobj); After Christoph's patch

Re: [PATCH 3/3] libnvdimm/ioctl: Switch to cdev_register_queued()

2021-01-21 Thread Greg KH
On Wed, Jan 20, 2021 at 11:39:08AM -0800, Dan Williams wrote: > The ioctl implementation in libnvdimm is a case study in what can be > cleaned up when the cdev core handles synchronizing in-flight ioctls > with device removal. Switch to cdev_register_queued() which allows for > the ugly context

Re: [PATCH v3 6/6] libnvdimm/namespace: Fix visibility of namespace resource attribute

2021-01-13 Thread Greg KH
On Tue, Jan 12, 2021 at 11:35:50PM -0800, Dan Williams wrote: > Legacy pmem namespaces lost support for the "resource" attribute when > the code was cleaned up to put the permission visibility in the > declaration. Restore this by listing 'resource' in the default > attributes. > > A new ndctl