Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests

2018-08-30 Thread Jens Axboe
eue it's > submitted to supports it, and enforce REQ_NOMERGE. I think this belongs in the caller - both the validity check, and passing in NOMERGE for this type of request. I don't want to impose this overhead on everything, for a p

Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests

2018-08-30 Thread Jens Axboe
On 8/30/18 1:17 PM, Logan Gunthorpe wrote: > > > On 30/08/18 01:11 PM, Jens Axboe wrote: >> On 8/30/18 12:53 PM, Logan Gunthorpe wrote: >>> QUEUE_FLAG_PCI_P2P is introduced meaning a driver's request queue >>> supports targeting P2P memory. >>>

Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests

2018-09-05 Thread Jens Axboe
On 9/3/18 4:26 PM, Logan Gunthorpe wrote: > > > On 01/09/18 02:28 AM, Christoph Hellwig wrote: >> On Thu, Aug 30, 2018 at 01:11:18PM -0600, Jens Axboe wrote: >>> I think this belongs in the caller - both the validity check, and >>> passing in NOMERGE for this

Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests

2018-09-05 Thread Jens Axboe
On 9/5/18 1:33 PM, Logan Gunthorpe wrote: > > > On 05/09/18 01:26 PM, Jens Axboe wrote: >> On 9/3/18 4:26 PM, Logan Gunthorpe wrote: >>> I personally agree with Christoph. But if there's consensus in the other >>> direction or this is a real blocker moving

Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests

2018-09-05 Thread Jens Axboe
On 9/5/18 1:56 PM, Christoph Hellwig wrote: > On Wed, Sep 05, 2018 at 01:45:04PM -0600, Jens Axboe wrote: >> The point is that the caller doesn't necessarily know where the bio >> will end up, hence the caller can't fully check if the whole stack >> supports P2P. &

Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests

2018-09-05 Thread Jens Axboe
On 9/5/18 2:09 PM, Logan Gunthorpe wrote: > > > On 05/09/18 02:11 PM, Christoph Hellwig wrote: >> On Wed, Sep 05, 2018 at 01:54:31PM -0600, Jens Axboe wrote: >>> On 9/5/18 1:56 PM, Christoph Hellwig wrote: >>>> On Wed, Sep 05, 2018 at 01:45:04PM -0600, Jens

Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests

2018-09-05 Thread Jens Axboe
On 9/5/18 2:18 PM, Logan Gunthorpe wrote: > > > On 05/09/18 02:14 PM, Jens Axboe wrote: >> But if the caller must absolutely know where the bio will end up, then >> it seems super redundant. So I'd vote for killing this check, it buys >> us absolutely nothing

Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests

2018-09-05 Thread Jens Axboe
On 9/5/18 2:32 PM, Logan Gunthorpe wrote: > > > On 05/09/18 02:19 PM, Jens Axboe wrote: >> On 9/5/18 2:18 PM, Logan Gunthorpe wrote: >>> >>> >>> On 05/09/18 02:14 PM, Jens Axboe wrote: >>>> But if the caller must absolutely know where the b

Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests

2018-09-05 Thread Jens Axboe
On 9/5/18 3:03 PM, Logan Gunthorpe wrote: > > > On 05/09/18 02:36 PM, Jens Axboe wrote: >> On 9/5/18 2:32 PM, Logan Gunthorpe wrote: >>> >>> >>> On 05/09/18 02:19 PM, Jens Axboe wrote: >>>> On 9/5/18 2:18 PM, Logan Gunthorpe wrote: &g

Re: [PATCH v6 07/13] block: Add PCI P2P flag for request queue and check support for requests

2018-09-12 Thread Jens Axboe
eue it's > submitted to supports it, and enforce REQ_NOMERGE. This changelog is no longer accurate. -- Jens Axboe ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [PATCH v9 07/13] block: Add PCI P2P flag for request queue and check support for requests

2018-10-05 Thread Jens Axboe
re submitting P2P backed pages to submit_bio(). Nit pick, but the subject line still says that it checks support for requests. This patch just adds the ability to flag support in the queue. -- Jens Axboe ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.

Re: [PATCH v9 07/13] block: Add PCI P2P flag for request queue and check support for requests

2018-10-10 Thread Jens Axboe
On 10/10/18 1:59 PM, Bjorn Helgaas wrote: > On Fri, Oct 05, 2018 at 07:16:04PM -0600, Jens Axboe wrote: >> On 10/4/18 3:27 PM, Logan Gunthorpe wrote: >>> QUEUE_FLAG_PCI_P2P is introduced meaning a driver's request queue >>> supports targeting P2P memory. This w

Re: [fio PATCH] engines/devdax: Make detection of device-dax instances more robust

2019-01-08 Thread Jens Axboe
utility [2] will ship a command to install the > modprobe policy and include a man page that lists the potential > regression risk to older FIO and other userspace tools that are hard > coded to "/sys/class/dax". > > [1]: https://lwn.net/Articles/770128/ > [2]: https://git

Re: [PATCH v3] block: refactor duplicated macros

2020-03-11 Thread Jens Axboe
with "PAGE_SECTORS_SHIFT" too > and rename SECTOR_MASK to PAGE_SECTORS_MASK. Applied, thanks. -- Jens Axboe ___ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org

Re: block I/O accounting improvements v2

2020-05-27 Thread Jens Axboe
us > performanc improvements. Most of this comes from a series Konstantin > sent a few weeks ago, rebased on changes that landed in your tree since > and my change to always use the percpu version of the disk stats. Applied, thanks. -- Jens Axboe

Re: [PATCH 11/20] fs: remove a weird comment in submit_bh_wbc

2020-06-30 Thread Jens Axboe
e on down the IO was purely bio based, not buffer_heads. Anyway, totally agree that it should just die, it's not that interesting or useful anymore. -- Jens Axboe ___ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an ema

Re: rename ->make_request_fn and move it to the block_device_operations

2020-06-30 Thread Jens Axboe
> path to issue to blk-mq, removing the need for the direct_make_request > bypass. Looks good to me, and it's a nice cleanup as well. Applied. -- Jens Axboe ___ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe sen

Re: rename ->make_request_fn and move it to the block_device_operations

2020-06-30 Thread Jens Axboe
On 6/30/20 7:57 AM, Jens Axboe wrote: > On 6/29/20 1:39 PM, Christoph Hellwig wrote: >> Hi Jens, >> >> this series moves the make_request_fn method into block_device_operations >> with the much more descriptive ->submit_bio name. It then also gives >> generic_

Re: rename ->make_request_fn and move it to the block_device_operations

2020-06-30 Thread Jens Axboe
On 6/30/20 12:19 PM, Christoph Hellwig wrote: > On Tue, Jun 30, 2020 at 09:43:31AM -0600, Jens Axboe wrote: >> On 6/30/20 7:57 AM, Jens Axboe wrote: >>> On 6/29/20 1:39 PM, Christoph Hellwig wrote: >>>> Hi Jens, >>>> >>>> this series moves t

Re: rename ->make_request_fn and move it to the block_device_operations

2020-06-30 Thread Jens Axboe
On 6/30/20 12:21 PM, Jens Axboe wrote: > On 6/30/20 12:19 PM, Christoph Hellwig wrote: >> On Tue, Jun 30, 2020 at 09:43:31AM -0600, Jens Axboe wrote: >>> On 6/30/20 7:57 AM, Jens Axboe wrote: >>>> On 6/29/20 1:39 PM, Christoph Hellwig wrote: >>>>&g

Re: rename ->make_request_fn and move it to the block_device_operations v2

2020-07-01 Thread Jens Axboe
> path to issue to blk-mq, removing the need for the direct_make_request > bypass. Thanks, I'll try this again. -- Jens Axboe ___ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org

Re: remove revalidate_disk()

2020-09-02 Thread Jens Axboe
f ->revalidate_disk entirely, but ther are a lot > more patches needed for that. Applied, thanks. -- Jens Axboe ___ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org

Re: [PATCH] loop: Fix lost writes caused by missing flag

2018-03-09 Thread Jens Axboe
this got merged, and to see whether it was targeting > v4.16 or v4.17. I'm the right guy, but I don't see patches if I'm not cc'ed on them... I have queued this up for 4.16, thanks. -- Jens Axboe ___ Linux-nvdimm mailing list

Re: [PATCH] loop: Fix lost writes caused by missing flag

2018-03-09 Thread Jens Axboe
On 3/9/18 8:38 AM, Jens Axboe wrote: > On 3/8/18 5:20 PM, Ross Zwisler wrote: >> This has gotten Reviewed-by tags from Christoph and Ming Lei. >> >> Al, are you the right person to merge this? Or is the correct person Jens, >> whom I accidentally didn't include

Re: [PATCH] loop: Fix lost writes caused by missing flag

2018-03-09 Thread Jens Axboe
On 3/9/18 9:35 AM, Ross Zwisler wrote: > On Fri, Mar 09, 2018 at 08:38:57AM -0700, Jens Axboe wrote: >> On 3/9/18 8:38 AM, Jens Axboe wrote: >>> On 3/8/18 5:20 PM, Ross Zwisler wrote: >>>> This has gotten Reviewed-by tags from Christoph and Ming Lei. >>>>

Re: [PATCH v2] include: Remove pagemap.h from blkdev.h

2021-03-09 Thread Jens Axboe
ependency is harder and this solves my problem. > x86 allmodconfig builds, but there may be implicit include problems > on other architectures. For the block bits: Acked-by: Jens Axboe -- Jens Axboe ___ Linux-nvdimm mailing list -- linux-nvdi

Re: [PATCH] block_dev: remove DAX leftovers

2016-09-14 Thread Jens Axboe
_flags manipulations introduced in commit bbab37 ("block: Add support for DAX reads/writes to block devices"). Applied for 4.9, thanks. -- Jens Axboe ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [PATCH 0/3] remove rw_page() from brd, pmem and btt

2017-08-03 Thread Jens Axboe
w_page | > + > | PMEM | 3.3 us| 3.27 us | 2.9 us | > + > | BTT | 3.7 us| 3.44 us | 3.4 us | > +--++-+-+ > > I've added another digit in precision in so

Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has BDI_CAP_SYNC capability

2017-08-11 Thread Jens Axboe
two ago, I'll see if I can find and resurrect it. -- Jens Axboe ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has BDI_CAP_SYNC capability

2017-08-14 Thread Jens Axboe
On 08/14/2017 02:50 AM, Minchan Kim wrote: > Hi Jens, > > On Fri, Aug 11, 2017 at 08:26:59AM -0600, Jens Axboe wrote: >> On 08/11/2017 04:46 AM, Christoph Hellwig wrote: >>> On Wed, Aug 09, 2017 at 08:06:24PM -0700, Dan Williams wrote: >>>> I like it, but do

Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has BDI_CAP_SYNC capability

2017-08-14 Thread Jens Axboe
On 08/14/2017 09:06 AM, Minchan Kim wrote: > On Mon, Aug 14, 2017 at 08:36:00AM -0600, Jens Axboe wrote: >> On 08/14/2017 02:50 AM, Minchan Kim wrote: >>> Hi Jens, >>> >>> On Fri, Aug 11, 2017 at 08:26:59AM -0600, Jens Axboe wrote: >>>> On 08/11/2017

Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has BDI_CAP_SYNC capability

2017-08-14 Thread Jens Axboe
uct has a really poor slow nand compared to > lz4/lzo [de]comression. I guess that's true for some cases. But as I said earlier, the recycling really doesn't care about this at all. They can happily coexist, and not step on each others toes. -- Jens Axboe _

Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has BDI_CAP_SYNC capability

2017-08-14 Thread Jens Axboe
On 08/14/2017 09:38 AM, Jens Axboe wrote: > On 08/14/2017 09:31 AM, Minchan Kim wrote: >>> Secondly, generally you don't have slow devices and fast devices >>> intermingled when running workloads. That's the rare case. >> >> Not true. zRam is really pop

Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has BDI_CAP_SYNC capability

2017-08-16 Thread Jens Axboe
On 08/15/2017 10:48 PM, Minchan Kim wrote: > Hi Jens, > > On Mon, Aug 14, 2017 at 10:17:09AM -0600, Jens Axboe wrote: >> On 08/14/2017 09:38 AM, Jens Axboe wrote: >>> On 08/14/2017 09:31 AM, Minchan Kim wrote: >>>>> Secondly, generally you d

Re: [PATCH 04/15] brd: remove dax support

2017-11-04 Thread Jens Axboe
move DAX support. Reviewed-by: Jens Axboe -- Jens Axboe ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [GIT PULL] ->driverfs_dev removal for 4.8

2016-07-08 Thread Jens Axboe
.8/drivers and has received a positive build success notification from the kbuild robot across several configs. [1]: "gendisk: Generate uevent after attribute available" http://marc.info/?l=linux-virtualization&m=146725201522201&w=2

Re: dm stripe: add DAX support

2016-07-20 Thread Jens Axboe
/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=51d1a5abcd0e88cb4528f35643245ea59cf234f1 Feel free to pick them up from patchwork or cherry-pick from linux-dm.git Added for 4.8, thanks! -- Jens Axboe ___ Linux-nvdimm maili

Re: [PATCH] block: remove BLK_DEV_DAX config option

2016-07-29 Thread Jens Axboe
cause it depended on CONFIG_BROKEN. This config option was introduced in this commit: commit 03cdadb04077 ("block: disable block device DAX by default") This change reverts that commit, removing the dead config option. This doesn't apply to master, nor for-linus

Re: [PATCH] block: fix bdi vs gendisk lifetime mismatch

2016-08-01 Thread Jens Axboe
[] device_add+0x125/0x610 [] device_create_groups_vargs+0xd8/0x100 [] device_create_vargs+0x1c/0x20 [] bdi_register+0x8c/0x180 [] bdi_register_dev+0x27/0x30 [] add_disk+0x175/0x4a0 Cc: Reported-by: Yi Zhang Tested-by: Yi Zhang Signed-off-by: Dan Williams Added for 4.8, t

Re: [Ksummit-discuss] [PATCH v2 3/3] libnvdimm, MAINTAINERS: Maintainer Entry Profile

2019-09-11 Thread Jens Axboe
ld seem saner to standardize rules around when code is expected to hit the maintainers hands for kernel releases. Both yours and Martins deals with that, there really shouldn't be the need to have this specified in detail per sub-system. -- Jens Axboe ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm