Hi, Dave,
Dave Jiang <dave.ji...@intel.com> writes:
> Adding firmware output of firmware information when ndctl list -D -F is used.
> Components displayed are current firmware version, updated firmware version,
> and if a coldboot is required (firmware updated).
>
> Signed-off-by: Dave Jiang <dave.ji...@intel.com>
> ---
> Documentation/ndctl/ndctl-list.txt | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> @@ -420,6 +422,25 @@ int cmd_list(int argc, const char **argv, void *ctx)
> }
> }
>
> + if (list.firmware) {
> + struct json_object *jfirmware;
> +
> + jfirmware = util_dimm_firmware_to_json(dimm);
> + if (jfirmware)
> + json_object_object_add(jdimm,
> + "firmware",
> + jfirmware);
> + else if (ndctl_dimm_is_cmd_supported(dimm,
> + ND_CMD_CALL)) {
> + /*
> + * Failed to retrieve firmware
> + * version.
> + */
> + fail("\n");
I'm hitting this failure. Also, you might consider adding some text,
there. :)
-Jeff
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
