Re: [PATCH 01/19] dax: remove block device dependencies

2020-02-11 Thread Vivek Goyal
On Thu, Jan 16, 2020 at 10:09:46AM -0800, Dan Williams wrote: > On Wed, Jan 15, 2020 at 1:08 PM Jeff Moyer wrote: > > > > Hi, Dan, > > > > Dan Williams writes: > > > > > I'm going to take a look at how hard it would be to develop a kpartx > > > fallback in udev. If that can live across the driver

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-16 Thread Vivek Goyal
On Thu, Jan 16, 2020 at 11:09:00AM -0800, Dan Williams wrote: [..] > > > True, but if kpartx + udev can make this transparent then I don't > > > think users lose any functionality. They just gain a device-mapper > > > dependency. > > > > So udev rules will trigger when a /dev/pmemX device shows up

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-16 Thread Dan Williams
On Thu, Jan 16, 2020 at 10:39 AM Vivek Goyal wrote: > > On Thu, Jan 16, 2020 at 10:09:46AM -0800, Dan Williams wrote: > > On Wed, Jan 15, 2020 at 1:08 PM Jeff Moyer wrote: > > > > > > Hi, Dan, > > > > > > Dan Williams writes: > > > > > > > I'm going to take a look at how hard it would be to deve

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-16 Thread Vivek Goyal
On Thu, Jan 16, 2020 at 10:09:46AM -0800, Dan Williams wrote: > On Wed, Jan 15, 2020 at 1:08 PM Jeff Moyer wrote: > > > > Hi, Dan, > > > > Dan Williams writes: > > > > > I'm going to take a look at how hard it would be to develop a kpartx > > > fallback in udev. If that can live across the driver

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-16 Thread Dan Williams
On Wed, Jan 15, 2020 at 1:08 PM Jeff Moyer wrote: > > Hi, Dan, > > Dan Williams writes: > > > I'm going to take a look at how hard it would be to develop a kpartx > > fallback in udev. If that can live across the driver transition then > > maybe this can be a non-event for end users that already

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-15 Thread Jeff Moyer
Hi, Dan, Dan Williams writes: > I'm going to take a look at how hard it would be to develop a kpartx > fallback in udev. If that can live across the driver transition then > maybe this can be a non-event for end users that already have that > udev update deployed. I just wanted to remind you th

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-15 Thread Dan Williams
On Wed, Jan 15, 2020 at 11:56 AM Vivek Goyal wrote: [..] > > Even the Red Hat > > installation guide example shows mounting on pmem0 directly. [1] > > Below that example it also says. > > "When creating partitions on a pmem device to be used for direct access, > partitions must be aligned on page

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-15 Thread Vivek Goyal
On Tue, Jan 14, 2020 at 02:23:04PM -0800, Dan Williams wrote: > On Tue, Jan 14, 2020 at 1:28 PM Vivek Goyal wrote: > > > > On Tue, Jan 14, 2020 at 12:39:00PM -0800, Dan Williams wrote: > > > On Tue, Jan 14, 2020 at 12:31 PM Vivek Goyal wrote: > > > > > > > > On Thu, Jan 09, 2020 at 12:03:01PM -08

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-15 Thread Jan Kara
On Tue 14-01-20 16:28:05, Vivek Goyal wrote: > On Tue, Jan 14, 2020 at 12:39:00PM -0800, Dan Williams wrote: > > I think we should at least try to delete the partition support and see > > if anyone screams. Have a module option to revert the behavior so > > people are not stuck waiting for the reve

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-14 Thread Dan Williams
On Tue, Jan 14, 2020 at 1:28 PM Vivek Goyal wrote: > > On Tue, Jan 14, 2020 at 12:39:00PM -0800, Dan Williams wrote: > > On Tue, Jan 14, 2020 at 12:31 PM Vivek Goyal wrote: > > > > > > On Thu, Jan 09, 2020 at 12:03:01PM -0800, Dan Williams wrote: > > > > On Thu, Jan 9, 2020 at 3:27 AM Jan Kara w

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-14 Thread Vivek Goyal
On Tue, Jan 14, 2020 at 12:39:00PM -0800, Dan Williams wrote: > On Tue, Jan 14, 2020 at 12:31 PM Vivek Goyal wrote: > > > > On Thu, Jan 09, 2020 at 12:03:01PM -0800, Dan Williams wrote: > > > On Thu, Jan 9, 2020 at 3:27 AM Jan Kara wrote: > > > > > > > > On Tue 07-01-20 10:49:55, Dan Williams wro

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-14 Thread Dan Williams
On Tue, Jan 14, 2020 at 12:31 PM Vivek Goyal wrote: > > On Thu, Jan 09, 2020 at 12:03:01PM -0800, Dan Williams wrote: > > On Thu, Jan 9, 2020 at 3:27 AM Jan Kara wrote: > > > > > > On Tue 07-01-20 10:49:55, Dan Williams wrote: > > > > On Tue, Jan 7, 2020 at 10:33 AM Vivek Goyal wrote: > > > > >

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-14 Thread Vivek Goyal
On Thu, Jan 09, 2020 at 12:03:01PM -0800, Dan Williams wrote: > On Thu, Jan 9, 2020 at 3:27 AM Jan Kara wrote: > > > > On Tue 07-01-20 10:49:55, Dan Williams wrote: > > > On Tue, Jan 7, 2020 at 10:33 AM Vivek Goyal wrote: > > > > W.r.t partitioning, bdev_dax_pgoff() seems to be the pain point whe

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-10 Thread Christoph Hellwig
On Thu, Jan 09, 2020 at 12:03:01PM -0800, Dan Williams wrote: > > So I'd find two options reasonably consistent: > > 1) Keep status quo where partitions are created and support DAX. > > 2) Stop partition creation altogether, if anyones wants to split pmem > > device further, he can use dm-linear fo

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-09 Thread Dan Williams
On Thu, Jan 9, 2020 at 3:27 AM Jan Kara wrote: > > On Tue 07-01-20 10:49:55, Dan Williams wrote: > > On Tue, Jan 7, 2020 at 10:33 AM Vivek Goyal wrote: > > > W.r.t partitioning, bdev_dax_pgoff() seems to be the pain point where > > > dax code refers back to block device to figure out partition of

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-09 Thread Jan Kara
On Tue 07-01-20 10:49:55, Dan Williams wrote: > On Tue, Jan 7, 2020 at 10:33 AM Vivek Goyal wrote: > > W.r.t partitioning, bdev_dax_pgoff() seems to be the pain point where > > dax code refers back to block device to figure out partition offset in > > dax device. If we create a dax object correspo

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-07 Thread Dan Williams
On Tue, Jan 7, 2020 at 11:46 AM Dan Williams wrote: [..] > > I'd say deprecate the > > kernel automounting partitions, but I guess it already does that, and > > Ok, now I don't know why automounting is leaking into this discussion? > > > removing it would break /something/. > > Yes, the breakage r

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-07 Thread Dan Williams
On Tue, Jan 7, 2020 at 11:03 AM Darrick J. Wong wrote: [..] > > That can already happen today. If you do not properly align the > > partition then dax operations will be disabled. > > Er... is this conversation getting confused? I was talking about > kpartx's /dev/mapper/pmem0p1 being a straight

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-07 Thread Darrick J. Wong
On Tue, Jan 07, 2020 at 10:49:55AM -0800, Dan Williams wrote: > On Tue, Jan 7, 2020 at 10:33 AM Vivek Goyal wrote: > > > > On Tue, Jan 07, 2020 at 10:07:18AM -0800, Dan Williams wrote: > > > On Tue, Jan 7, 2020 at 10:02 AM Vivek Goyal wrote: > > > > > > > > On Tue, Jan 07, 2020 at 09:29:17AM -080

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-07 Thread Dan Williams
On Tue, Jan 7, 2020 at 10:33 AM Vivek Goyal wrote: > > On Tue, Jan 07, 2020 at 10:07:18AM -0800, Dan Williams wrote: > > On Tue, Jan 7, 2020 at 10:02 AM Vivek Goyal wrote: > > > > > > On Tue, Jan 07, 2020 at 09:29:17AM -0800, Dan Williams wrote: > > > > On Tue, Jan 7, 2020 at 9:08 AM Darrick J. W

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-07 Thread Vivek Goyal
On Tue, Jan 07, 2020 at 10:07:18AM -0800, Dan Williams wrote: > On Tue, Jan 7, 2020 at 10:02 AM Vivek Goyal wrote: > > > > On Tue, Jan 07, 2020 at 09:29:17AM -0800, Dan Williams wrote: > > > On Tue, Jan 7, 2020 at 9:08 AM Darrick J. Wong > > > wrote: > > > > > > > > On Tue, Jan 07, 2020 at 06:22

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-07 Thread Dan Williams
On Tue, Jan 7, 2020 at 10:02 AM Vivek Goyal wrote: > > On Tue, Jan 07, 2020 at 09:29:17AM -0800, Dan Williams wrote: > > On Tue, Jan 7, 2020 at 9:08 AM Darrick J. Wong > > wrote: > > > > > > On Tue, Jan 07, 2020 at 06:22:54AM -0800, Dan Williams wrote: > > > > On Tue, Jan 7, 2020 at 4:52 AM Chri

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-07 Thread Vivek Goyal
On Tue, Jan 07, 2020 at 09:29:17AM -0800, Dan Williams wrote: > On Tue, Jan 7, 2020 at 9:08 AM Darrick J. Wong > wrote: > > > > On Tue, Jan 07, 2020 at 06:22:54AM -0800, Dan Williams wrote: > > > On Tue, Jan 7, 2020 at 4:52 AM Christoph Hellwig > > > wrote: > > > > > > > > On Mon, Dec 16, 2019

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-07 Thread Dan Williams
On Tue, Jan 7, 2020 at 9:08 AM Darrick J. Wong wrote: > > On Tue, Jan 07, 2020 at 06:22:54AM -0800, Dan Williams wrote: > > On Tue, Jan 7, 2020 at 4:52 AM Christoph Hellwig wrote: > > > > > > On Mon, Dec 16, 2019 at 01:10:14PM -0500, Vivek Goyal wrote: > > > > > Agree. In retrospect it was my laz

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-07 Thread Darrick J. Wong
On Tue, Jan 07, 2020 at 06:22:54AM -0800, Dan Williams wrote: > On Tue, Jan 7, 2020 at 4:52 AM Christoph Hellwig wrote: > > > > On Mon, Dec 16, 2019 at 01:10:14PM -0500, Vivek Goyal wrote: > > > > Agree. In retrospect it was my laziness in the dax-device > > > > implementation to expect the block-

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-07 Thread Dan Williams
On Tue, Jan 7, 2020 at 4:52 AM Christoph Hellwig wrote: > > On Mon, Dec 16, 2019 at 01:10:14PM -0500, Vivek Goyal wrote: > > > Agree. In retrospect it was my laziness in the dax-device > > > implementation to expect the block-device to be available. > > > > > > It looks like fs_dax_get_by_bdev() i

Re: [PATCH 01/19] dax: remove block device dependencies

2020-01-07 Thread Christoph Hellwig
On Mon, Dec 16, 2019 at 01:10:14PM -0500, Vivek Goyal wrote: > > Agree. In retrospect it was my laziness in the dax-device > > implementation to expect the block-device to be available. > > > > It looks like fs_dax_get_by_bdev() is an intercept point where a > > dax_device could be dynamically cre

Re: [PATCH 01/19] dax: remove block device dependencies

2019-12-16 Thread Vivek Goyal
On Wed, Aug 28, 2019 at 05:04:11PM -0700, Dan Williams wrote: > On Wed, Aug 28, 2019 at 3:53 PM Dave Chinner wrote: > > > > On Wed, Aug 28, 2019 at 01:58:43PM -0400, Vivek Goyal wrote: > > > On Tue, Aug 27, 2019 at 11:58:09PM -0700, Christoph Hellwig wrote: > > > > On Tue, Aug 27, 2019 at 12:38:28

Re: [PATCH 01/19] dax: remove block device dependencies

2019-08-29 Thread Christoph Hellwig
On Wed, Aug 28, 2019 at 05:04:11PM -0700, Dan Williams wrote: > Agree. In retrospect it was my laziness in the dax-device > implementation to expect the block-device to be available. > > It looks like fs_dax_get_by_bdev() is an intercept point where a > dax_device could be dynamically created to r

Re: [PATCH 01/19] dax: remove block device dependencies

2019-08-28 Thread Dan Williams
On Wed, Aug 28, 2019 at 3:53 PM Dave Chinner wrote: > > On Wed, Aug 28, 2019 at 01:58:43PM -0400, Vivek Goyal wrote: > > On Tue, Aug 27, 2019 at 11:58:09PM -0700, Christoph Hellwig wrote: > > > On Tue, Aug 27, 2019 at 12:38:28PM -0400, Vivek Goyal wrote: > > > > > For bdev_dax_pgoff > > > > > I'd

Re: [PATCH 01/19] dax: remove block device dependencies

2019-08-28 Thread Dave Chinner
On Wed, Aug 28, 2019 at 01:58:43PM -0400, Vivek Goyal wrote: > On Tue, Aug 27, 2019 at 11:58:09PM -0700, Christoph Hellwig wrote: > > On Tue, Aug 27, 2019 at 12:38:28PM -0400, Vivek Goyal wrote: > > > > For bdev_dax_pgoff > > > > I'd much rather have the partition offset if there is on in the daxde

Re: [PATCH 01/19] dax: remove block device dependencies

2019-08-28 Thread Vivek Goyal
On Tue, Aug 27, 2019 at 11:58:09PM -0700, Christoph Hellwig wrote: > On Tue, Aug 27, 2019 at 12:38:28PM -0400, Vivek Goyal wrote: > > > For bdev_dax_pgoff > > > I'd much rather have the partition offset if there is on in the daxdev > > > somehow so that we can get rid of the block device entirely.

Re: [PATCH 01/19] dax: remove block device dependencies

2019-08-27 Thread Christoph Hellwig
On Tue, Aug 27, 2019 at 12:38:28PM -0400, Vivek Goyal wrote: > > For bdev_dax_pgoff > > I'd much rather have the partition offset if there is on in the daxdev > > somehow so that we can get rid of the block device entirely. > > IIUC, there is one block_device per partition while there is only one

Re: [PATCH 01/19] dax: remove block device dependencies

2019-08-27 Thread Vivek Goyal
On Mon, Aug 26, 2019 at 04:51:52AM -0700, Christoph Hellwig wrote: > On Wed, Aug 21, 2019 at 01:57:02PM -0400, Vivek Goyal wrote: > > From: Stefan Hajnoczi > > > > Although struct dax_device itself is not tied to a block device, some > > DAX code assumes there is a block device. Make block devic

Re: [PATCH 01/19] dax: remove block device dependencies

2019-08-26 Thread Christoph Hellwig
On Wed, Aug 21, 2019 at 01:57:02PM -0400, Vivek Goyal wrote: > From: Stefan Hajnoczi > > Although struct dax_device itself is not tied to a block device, some > DAX code assumes there is a block device. Make block devices optional > by allowing bdev to be NULL in commonly used DAX APIs. > > Whe