Re: [dm-devel] [PATCH] dm-writecache

2018-03-12 Thread Mikulas Patocka
On Mon, 12 Mar 2018, Christoph Hellwig wrote: > On Thu, Mar 08, 2018 at 09:08:32AM -0800, Dan Williams wrote: > > I had the same feedback, and Mikulas sent this useful enhancement to > > the memcpy_flushcache API: > > > > https://patchwork.kernel.org/patch/10217655/ > > > > ...it's in my q

Re: [dm-devel] [PATCH] dm-writecache

2018-03-12 Thread Mikulas Patocka
On Mon, 12 Mar 2018, Christoph Hellwig wrote: > On Thu, Mar 08, 2018 at 10:26:17PM -0500, Mikulas Patocka wrote: > > > no business having this around. > > > > It's the default setting of the flag wc->writeback_fua (it can be changed > > with target parameters). The flag selects whether the tar

Re: [dm-devel] [PATCH] dm-writecache

2018-03-12 Thread Christoph Hellwig
On Thu, Mar 08, 2018 at 10:26:17PM -0500, Mikulas Patocka wrote: > > no business having this around. > > It's the default setting of the flag wc->writeback_fua (it can be changed > with target parameters). The flag selects whether the target uses FUA > requests when doing writeback or whether it

Re: [dm-devel] [PATCH] dm-writecache

2018-03-12 Thread Christoph Hellwig
On Thu, Mar 08, 2018 at 09:08:32AM -0800, Dan Williams wrote: > I had the same feedback, and Mikulas sent this useful enhancement to > the memcpy_flushcache API: > > https://patchwork.kernel.org/patch/10217655/ > > ...it's in my queue to either push through -tip or add it to the next > libnvd

Re: [dm-devel] [PATCH] dm-writecache

2018-03-08 Thread Mikulas Patocka
On Thu, 8 Mar 2018, Christoph Hellwig wrote: > > --- /dev/null 1970-01-01 00:00:00.0 + > > +++ linux-2.6/drivers/md/dm-writecache.c2018-03-08 14:23:31.05000 > > +0100 > > @@ -0,0 +1,2417 @@ > > +#include > > missing copyright statement, or for those new-fashioned SPD

Re: [dm-devel] [PATCH] dm-writecache

2018-03-08 Thread Dan Williams
On Thu, Mar 8, 2018 at 6:51 AM, Christoph Hellwig wrote: >> --- /dev/null 1970-01-01 00:00:00.0 + >> +++ linux-2.6/drivers/md/dm-writecache.c 2018-03-08 14:23:31.05000 >> +0100 >> @@ -0,0 +1,2417 @@ >> +#include > > missing copyright statement, or for those new-fashioned SPD

Re: [dm-devel] [PATCH] dm-writecache

2018-03-08 Thread Christoph Hellwig
> --- /dev/null 1970-01-01 00:00:00.0 + > +++ linux-2.6/drivers/md/dm-writecache.c 2018-03-08 14:23:31.05000 > +0100 > @@ -0,0 +1,2417 @@ > +#include missing copyright statement, or for those new-fashioned SPDX statement. > +#define WRITEBACK_FUAtrue