Re: [RFC] OMAP: I2C: Use correct bit for CLOCKACTIVITY

2009-03-05 Thread Paul Walmsley
Hello Eero, On Thu, 5 Mar 2009, ext-eero.nurkk...@nokia.com wrote: From: Eero Nurkkala ext-eero.nurkk...@nokia.com It is the bit 8 that is for FCLK. All other blocks in OMAPs use the bit 8 for denying FCLK idling. Hmm. Looking at the 34xx Rev O TRM register tables, it looks like most

Re: [RFC] OMAP: I2C: Use correct bit for CLOCKACTIVITY

2009-03-05 Thread Eero Nurkkala
On Thu, 2009-03-05 at 09:42 +0100, ext Paul Walmsley wrote: Hello Eero, Hmm. Looking at the 34xx Rev O TRM register tables, it looks like most modules use bit 9 to indicate that FCLK should be kept on and bit 8 to indicate that the ICLK should be kept on? DSI, DISPC, SR, DMA4 are some

Re: [RFC] OMAP: I2C: Use correct bit for CLOCKACTIVITY

2009-03-05 Thread Eero Nurkkala
On Thu, 2009-03-05 at 10:46 +0200, Eero Nurkkala wrote: How about McBSP? Same TRM.. I2C, Table 18-5 tells exactly the opposite for I2C than what's said in Table 18-44: I2C_SYSC!! Please, Richard? - Eero To answer to myself, I am 100% certain the McBSP FCLK is the bit 8. I should have

Re: [PATCH A 09/10] OMAP2/3: Remove OMAP_PRM_REGADDR, OMAP_CM_REGADDR

2009-03-05 Thread Paul Walmsley
Hello Richard On Tue, 3 Mar 2009, Russell King - ARM Linux wrote: On Tue, Mar 03, 2009 at 07:09:35AM -0800, Kevin Hilman wrote: Russell King - ARM Linux li...@arm.linux.org.uk writes: On Mon, Mar 02, 2009 at 07:48:07PM -0700, Paul Walmsley wrote: Hi Kevin, On Mon, 2 Mar 2009,

Re: [PATCH A 09/10] OMAP2/3: Remove OMAP_PRM_REGADDR, OMAP_CM_REGADDR

2009-03-05 Thread Paul Walmsley
On Thu, 5 Mar 2009, Paul Walmsley wrote: Hello Richard (my apologies, of course this should have been, Hello Russell) - Paul -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] DSPBRIDGE: Remove variables not used in cfgdefs.h

2009-03-05 Thread Ameya Palande
On Wed, Mar 4, 2009 at 8:11 PM, Fernando Guzman Lugo x0095...@ti.com wrote: This patch removes some variable that are not used. Signed-off-by: Guzman Lugo Fernando x0095...@ti.com ---  arch/arm/plat-omap/include/dspbridge/cfgdefs.h |   10 --  drivers/dsp/bridge/rmgr/drv.c              

Re: [PATCH] DSPBRIDGE: Change address resources to void __iomem *

2009-03-05 Thread Ameya Palande
On Wed, Mar 4, 2009 at 8:11 PM, Fernando Guzman Lugo x0095...@ti.com wrote: This patch changes address resources to void __iomem * Signed-off-by: Guzman Lugo Fernando x0095...@ti.com ---  arch/arm/plat-omap/include/dspbridge/cfgdefs.h |   16  drivers/dsp/bridge/hw/hw_dspssC64P.c      

Re: [PATCH 0/5] DSPBRIDGE: patches.

2009-03-05 Thread Ameya Palande
On Tue, Mar 3, 2009 at 2:00 AM, Guzman Lugo, Fernando x0095...@ti.com wrote: Hi,        I am sending my patches again, now they are base on this commit: commit bacaa3dc169e11488faf17519a42c4e8641fc17e Author: Hiroshi DOYU hiroshi.d...@nokia.com Date:   Mon Feb 16 10:43:15 2009 +0200    

Re: [PATCH 1/9] omap3isp: Add ISP main driver and register definitions

2009-03-05 Thread Sakari Ailus
Thanks for the comments, Alexey! Alexey Klimov wrote: +static int isp_probe(struct platform_device *pdev) +{ + struct isp_device *isp; + int ret_err = 0; + int i; + + isp = kzalloc(sizeof(*isp), GFP_KERNEL); + if (!isp) { + dev_err(pdev-dev, could not

RE: Problems while designing TPS65023 regulator driver

2009-03-05 Thread Aggarwal, Anuj
Mark, Thanks for the patch, it worked fine for me. I am facing one more problem now. I am setting boot_on flag in the constraints structure for all my regulators as they are enabled when the system is powered on. But still when I call regulator_disable() after doing a _get() on it, the call

RE: [RFC] OMAP: I2C: Use correct bit for CLOCKACTIVITY

2009-03-05 Thread Menon, Nishanth
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Eero Nurkkala Sent: Thursday, March 05, 2009 10:46 AM To: ext Paul Walmsley Cc: linux-omap@vger.kernel.org; Woodruff, Richard Subject: Re: [RFC] OMAP: I2C: Use correct

RE: [RFC] OMAP: I2C: Use correct bit for CLOCKACTIVITY

2009-03-05 Thread Eero Nurkkala
On Thu, 2009-03-05 at 13:29 +0100, ext Menon, Nishanth wrote: Yep, that does look nuts :(.. Have pinged internally.. Regards, Nishanth Menon Thank you! Could you please consider taking a loot at every single block (SPI, I2C, DMA... etc). If I were you, I'd copy-paste the CLOCKACTIVITY

RE: [RFC] OMAP: I2C: Use correct bit for CLOCKACTIVITY

2009-03-05 Thread Menon, Nishanth
-Original Message- From: Eero Nurkkala [mailto:ext-eero.nurkk...@nokia.com] Sent: Thursday, March 05, 2009 2:33 PM To: Menon, Nishanth Cc: ext Paul Walmsley; linux-omap@vger.kernel.org; Woodruff, Richard Subject: RE: [RFC] OMAP: I2C: Use correct bit for CLOCKACTIVITY Thank you!

RE: [PATCH 0/5] DSPBRIDGE: patches.

2009-03-05 Thread Kanigeri, Hari
Hi Ameya, Hi Fernando, Are you using tidspbridge-pm branch from http://gitorious.org/projects/lk/repos/mainline ? Cheers, Ameya. -- The Bridge patches will be based on omapzoom tree. Thank you, Best regards, Hari -Original Message- From: linux-omap-ow...@vger.kernel.org

Re: [PATCH 0/5] DSPBRIDGE: patches.

2009-03-05 Thread Felipe Contreras
On Thu, Mar 5, 2009 at 3:18 PM, Kanigeri, Hari h-kanige...@ti.com wrote: Hi Ameya, Hi Fernando, Are you using tidspbridge-pm branch from http://gitorious.org/projects/lk/repos/mainline ? Cheers, Ameya. -- The Bridge patches will be based on omapzoom tree. We are in linux-omap, not

Re: [pacth] I2C bug fixes for L-O and L-Z

2009-03-05 Thread Aaro Koskinen
Hello, Woodruff, Richard wrote: Recently one custom board was having some I2C issues. In looking at it a couple things stood out. I've attached a patches for l-o and l-z for anyone to comment on which cares. I hope these fixes are not ignored. Maybe they should be resent as they are missing

RE: [PATCH 0/5] DSPBRIDGE: patches.

2009-03-05 Thread Kanigeri, Hari
Hi Felipe, We are in linux-omap, not omapzoom, and this is the tidspbridge branch in linux-omap: http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2. 6.git;a=shortlog;h=tidspbridge I'm sure you don't want to increase the discrepancy between linux-omap and omapzoom, so the

RE: [PATCH 0/5] DSPBRIDGE: patches.

2009-03-05 Thread Menon, Nishanth
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Felipe Contreras Sent: Thursday, March 05, 2009 3:42 PM To: Kanigeri, Hari Cc: Ameya Palande; Guzman Lugo, Fernando; Hiroshi DOYU; linux- o...@vger.kernel.org Subject:

[PATCH] I2C: Call request_irq with IRQF_DISABLED

2009-03-05 Thread Ari Kauppi
I have observed some Spurious IRQ's for I2C1 when all kernel hacking options (and thus LOCKDEP) are disabled. Applying Richard Woodruff's 'I2C bug fixes for L-O and L-Z' seems to help but IRQF_DISABLED is needed for proper behaviour. Signed-off-by: Ari Kauppi ext-ari.kau...@nokia.com ---

RE: [PATCH 0/5] DSPBRIDGE: patches.

2009-03-05 Thread Kanigeri, Hari
Nishant, Yeah it gets real confusing. How about following the same rules for the OMAPZOOM kernel here too: any patch w.r.t OMAPZOOM comes: Subj: RE: [OMAPZOOM PATCH 0/5] DSPBRIDGE: blah blah blah. -- I agree with your suggestion. The subject should have OMAPZOOM to differentiate.

RE: [PATCH 0/5] DSPBRIDGE: patches.

2009-03-05 Thread Menon, Nishanth
Hi Hari, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Kanigeri, Hari Sent: Thursday, March 05, 2009 3:52 PM To: Felipe Contreras Cc: Ameya Palande; Guzman Lugo, Fernando; Hiroshi DOYU; linux- o...@vger.kernel.org

Re: [PATCH 0/5] DSPBRIDGE: patches.

2009-03-05 Thread Felipe Contreras
On Thu, Mar 5, 2009 at 3:56 PM, Kanigeri, Hari h-kanige...@ti.com wrote: Nishant, Yeah it gets real confusing. How about following the same rules for the OMAPZOOM kernel here too: any patch w.r.t OMAPZOOM comes: Subj: RE: [OMAPZOOM PATCH 0/5] DSPBRIDGE: blah blah blah. -- I agree with

Re: [PATCH 9/9] omap34xxcam: Add camera driver

2009-03-05 Thread Sakari Ailus
Alexey Klimov wrote: +static int vidioc_g_fmt_vid_cap(struct file *file, void *fh, + struct v4l2_format *f) +{ + struct omap34xxcam_fh *ofh = fh; + struct omap34xxcam_videodev *vdev = ofh-vdev; + + if (vdev-vdev_sensor == v4l2_int_device_dummy()) +

[PATCH] OMAP3: Fixed crash bug with serial + suspend

2009-03-05 Thread Tero Kristo
It was possible for an unhandled interrupt to occur if there was incoming serial traffic during wakeup from suspend. This was caused by the code in arch-arm/mach-omap2/serial.c keeping interrupt enabled all the time, but not acking its interrupts. Applies on top of PM branch. Signed-off-by: Tero

RE: [PATCH 0/5] DSPBRIDGE: patches.

2009-03-05 Thread Kanigeri, Hari
Hi, Ok, so we have: a) omapzoom bridge b) linux omap bridge Impertinent question: what are our plans b/w these two? A. omapzoom bridge -- As far as I know, this will be the master tree for the DSPBridge code. The Bridge patches will be based on this tree. I think it was already

where is struct constraint_id defined?

2009-03-05 Thread david . hagood
I am trying to build the OMAP3 graphics kernel module against 2.6.29-rc7-omap1 (from GIT), and have been running into problems getting it to build. Two problems were pretty easy: the TI code was including asm/resource.h and asm/semaphore.h rather than linux/resource.h and linux/semaphore.h.

Re: [PATCH 0/5] DSPBRIDGE: patches.

2009-03-05 Thread Tony Lindgren
* Felipe Contreras felipe.contre...@gmail.com [090305 06:06]: On Thu, Mar 5, 2009 at 3:56 PM, Kanigeri, Hari h-kanige...@ti.com wrote: Nishant, Yeah it gets real confusing. How about following the same rules for the OMAPZOOM kernel here too: any patch w.r.t OMAPZOOM comes: Subj: RE:

Re: [PATCH 3/7] ARM: OMAP: Add command line option for I2C bus speed

2009-03-05 Thread Tony Lindgren
* Tony Lindgren t...@atomide.com [090304 13:51]: From: Jarkko Nikula jarkko.nik...@nokia.com This patch adds a new command line option i2c_bus=bus_id,clkrate into I2C bus registration helper. Purpose of the option is to override the default board specific bus speed which is supplied by the

Embedded Linux Conference

2009-03-05 Thread Hans Verkuil
Just FYI: I'll be attending the Embedded Linux Conference in San Francisco, April 6th-8th (http://www.embeddedlinuxconference.com/elc_2009). This might be a good opportunity to discuss omap and davinci V4L2 issues face-to-face. Let me know if you are interested. Regards, Hans --

RE: [PATCH 4/5] OMAP3430SDP: Add support for Camera Kit v3

2009-03-05 Thread Curran, Dominic
Hi Kim -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of DongSoo(Nathaniel) Kim Sent: Wednesday, March 04, 2009 8:58 PM To: Aguirre Rodriguez, Sergio Alberto Cc: linux-me...@vger.kernel.org; linux-omap@vger.kernel.org;

Re: [PATCH] OMAP3: Fixed crash bug with serial + suspend

2009-03-05 Thread Kevin Hilman
Tero Kristo tero.kri...@nokia.com writes: It was possible for an unhandled interrupt to occur if there was incoming serial traffic during wakeup from suspend. This was caused by the code in arch-arm/mach-omap2/serial.c keeping interrupt enabled all the time, but not acking its interrupts.

[PATCH 2/2] ASoC: Add headset jack detection for SDP3430 machine driver

2009-03-05 Thread Lopez Cruz, Misael
Add headset jack detection for SDP3430 boards using SoC jack reporting interface. Headset detection on SDP3430 board is achieved through TWL4030 GPIO_2 pin. Signed-off-by: Misael Lopez Cruz x0052...@ti.com --- sound/soc/omap/sdp3430.c | 43 +-- 1 files

[PATCH] input: twl4030-pwrbutton: avoid merge conflicts

2009-03-05 Thread Felipe Balbi
sync up with the version going upstream. Signed-off-by: Felipe Balbi felipe.ba...@nokia.com --- This patch is syncing with the fixed up version accepted in mainline. Should be applied to avoid merge conflicts on the next merge window. drivers/input/misc/Kconfig |6 ++

Re: [PATCH] I2C: Call request_irq with IRQF_DISABLED

2009-03-05 Thread Felipe Balbi
On Thu, Mar 05, 2009 at 03:54:24PM +0200, Ari Kauppi wrote: I have observed some Spurious IRQ's for I2C1 when all kernel hacking options (and thus LOCKDEP) are disabled. Applying Richard Woodruff's 'I2C bug fixes for L-O and L-Z' seems to help but IRQF_DISABLED is needed for proper

Re: [PATCH 3/7] ARM: OMAP: Add command line option for I2C bus speed

2009-03-05 Thread Felipe Balbi
On Thu, Mar 05, 2009 at 08:20:43AM -0800, Tony Lindgren wrote: Also, maybe it should be called omap_i2c_bus instead of i2c_bus? or maybe not, then other archs would have the opportunity to setup their own function to handle i2c_bus= cmdline without having to add a brand new arch_i2c_bus one ;-)

Re: [PATCH] I2C: Call request_irq with IRQF_DISABLED

2009-03-05 Thread Jean Delvare
On Thu, 5 Mar 2009 21:35:06 +0200, Felipe Balbi wrote: That and this one should be going via linux-i2c mainling list. Could you send Eero's patch and yours to Jean Delvare (i2c maintainer) ? Please keep linux-omap in the loop. Come on, folks, how many times will I have to repeat myself and

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-05 Thread Sakari Ailus
Hans Verkuil wrote: Situation 1 - Instance1: Select sensor 1, and Do queue/dequeue of buffers. - Instance2: If sensor 1 is currently selected, Begin loop requesting internally collected OMAP3ISP statistics (with V4L2 private based IOCTLs) for performing user-side Auto-exposure, Auto White

Re: [PATCH] I2C: Call request_irq with IRQF_DISABLED

2009-03-05 Thread Felipe Balbi
On Thu, Mar 05, 2009 at 09:03:35PM +0100, Jean Delvare wrote: On Thu, 5 Mar 2009 21:35:06 +0200, Felipe Balbi wrote: That and this one should be going via linux-i2c mainling list. Could you send Eero's patch and yours to Jean Delvare (i2c maintainer) ? Please keep linux-omap in the loop.

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-05 Thread Hans Verkuil
On Thursday 05 March 2009 21:11:02 Sakari Ailus wrote: Hans Verkuil wrote: Situation 1 - Instance1: Select sensor 1, and Do queue/dequeue of buffers. - Instance2: If sensor 1 is currently selected, Begin loop requesting internally collected OMAP3ISP statistics (with V4L2 private based

RE: omap3 cpuidle interrupt latency

2009-03-05 Thread Premi, Sanjeev
-Original Message- From: Premi, Sanjeev Sent: Wednesday, March 04, 2009 7:52 PM To: Premi, Sanjeev; Kevin Hilman Cc: linux-omap@vger.kernel.org Subject: RE: omap3 cpuidle interrupt latency -Original Message- From: linux-omap-ow...@vger.kernel.org

Re: [PATCH 4/5] OMAP3430SDP: Add support for Camera Kit v3

2009-03-05 Thread Alexey Klimov
Hello, all On Thu, Mar 5, 2009 at 7:42 PM, Curran, Dominic dcur...@ti.com wrote: Hi Kim -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of DongSoo(Nathaniel) Kim Sent: Wednesday, March 04, 2009 8:58 PM To: Aguirre

RE: [PATCH 4/5] OMAP3430SDP: Add support for Camera Kit v3

2009-03-05 Thread Curran, Dominic
-Original Message- From: Alexey Klimov [mailto:klimov.li...@gmail.com] Sent: Thursday, March 05, 2009 4:05 PM To: Curran, Dominic Cc: DongSoo(Nathaniel) Kim; Aguirre Rodriguez, Sergio Alberto; linux- me...@vger.kernel.org; linux-omap@vger.kernel.org; Sakari Ailus; Tuukka.O

[APPLIED] [PATCH] input: twl4030-pwrbutton: avoid merge conflicts

2009-03-05 Thread Tony Lindgren
This patch has been applied to the linux-omap by youw fwiendly patch wobot. Commit: 1e2ac5195c19b440b0b095262e11b54c093916ee PatchWorks http://patchwork.kernel.org/patch/10147/ Git

Re: [patch/rft 2.6.29-rc3-omap-git] omap3 evm: MMC switch support

2009-03-05 Thread Tony Lindgren
* David Brownell davi...@pacbell.net [090208 12:25]: On Wednesday 04 February 2009, Pillai, Manikandan wrote: I tested the patch on the OMAP 3 EVM. I still find that the hotplug feature does not work on the OMAP3 EVM. The issue is that if I read the gpio_cd, I am getting the correct value

Re: [PATCH 0/1] Group and resource assignments for TWL4030

2009-03-05 Thread Tony Lindgren
* David Brownell davi...@pacbell.net [090303 15:38]: On Friday 27 February 2009, Tony Lindgren wrote: * Peter 'p2' De Schrijver peter.de-schrij...@nokia.com [090215 08:49]: On Fri, Feb 13, 2009 at 09:55:21PM +0100, ext David Brownell wrote: On Tuesday 10 February 2009, Peter 'p2' De

[APPLIED] [PATCH] omap3: Add base address definitions and resources for OMAP

2009-03-05 Thread Tony Lindgren
This patch has been applied to the linux-omap by youw fwiendly patch wobot. Commit: d0afa95d172f66e2239e38e015e8536dc78e98db PatchWorks http://patchwork.kernel.org/patch/9871/ Git

Re: [PATCH] ARM: OMAP2: Fix missing system control module exports

2009-03-05 Thread Tony Lindgren
Hi, * George G. Davis gda...@mvista.com [090302 08:19]: When building ASoC drivers as modules for SND_OMAP_SOC_MCBSP based targets, the build fails because omap_ctrl_{read,write}l lack exports. So add the missing exports for omap_ctrl_{read,write}[bwl] to allow building these ASoC (and other)

Re: [PATCH 4/5] OMAP3430SDP: Add support for Camera Kit v3

2009-03-05 Thread DongSoo(Nathaniel) Kim
Hi Alexey, On Fri, Mar 6, 2009 at 7:05 AM, Alexey Klimov klimov.li...@gmail.com wrote: Hello, all On Thu, Mar 5, 2009 at 7:42 PM, Curran, Dominic dcur...@ti.com wrote: Hi Kim -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On

Re: [PATCH] ARM: OMAP2: Fix missing system control module exports

2009-03-05 Thread George G. Davis
Hi, On Thu, Mar 05, 2009 at 04:43:09PM -0800, Tony Lindgren wrote: Hi, * George G. Davis gda...@mvista.com [090302 08:19]: When building ASoC drivers as modules for SND_OMAP_SOC_MCBSP based targets, the build fails because omap_ctrl_{read,write}l lack exports. So add the missing exports

Re: Embedded Linux Conference

2009-03-05 Thread DongSoo(Nathaniel) Kim
Hello, I'm attending as a speaker for one session which title is Digital camera framework in Linux I'm also looking forward to see many v4l2 engineers and discuss about latest issues. BTW, see you there Hans :) Nate On Fri, Mar 6, 2009 at 1:49 AM, Hans Verkuil hverk...@xs4all.nl wrote: Just

RE: Embedded Linux Conference

2009-03-05 Thread Hadli, Manjunath
That is great! I will let you know our plans soon. -Manju -Original Message- From: DongSoo(Nathaniel) Kim [mailto:dongsoo@gmail.com] Sent: Friday, March 06, 2009 9:33 AM To: Hans Verkuil Cc: linux-me...@vger.kernel.org; linux-omap@vger.kernel.org; Hadli, Manjunath; Aguirre

Re: [PATCH 3/7] ARM: OMAP: Add command line option for I2C bus speed

2009-03-05 Thread Jarkko Nikula
On Thu, 5 Mar 2009 17:20:43 +0100 ext Tony Lindgren t...@atomide.com wrote: Jarkko, this should also be in Documentation/kernel-parameters.txt. Can you please reply with a patch for that, and I'll fold it into this patch? Ah, good, will do it over weekend - early next week. Probably better