Re: [PATCH-V2 1/3] RTC:s35390a: Add Alarm interrupt support

2010-08-23 Thread Felipe Balbi
Hi, please break your lines at 80-characters. Also the [Hiremath, Vaibhav] is unnecessary. On Mon, Aug 23, 2010 at 06:58:42AM +0200, ext Hiremath, Vaibhav wrote: don't you need some locking on the irq handler ? a mutex maybe ? Just wondering... [Hiremath, Vaibhav] Yes definitely we do need

Re: DSS2 broken with 36-rc1

2010-08-23 Thread Mike Rapoport
Hi Ameya, Ameya Palande wrote: Hi Tomi, When I tried to boot 2.6.36-rc1 kernel on Nokia N900, omapfb failed with following error messages: [0.124145] OMAP DSS rev 2.0 [0.124237] OMAP DISPC rev 3.0 [0.303833] acx565akm spi1.2: omapfb: acx565akm rev 8b LCD detected [0.805419]

Re: DSS2 broken with 36-rc1

2010-08-23 Thread Mike Rapoport
Mike Rapoport wrote: Hi Ameya, Ameya Palande wrote: Hi Tomi, When I tried to boot 2.6.36-rc1 kernel on Nokia N900, omapfb failed with following error messages: [0.124145] OMAP DSS rev 2.0 [0.124237] OMAP DISPC rev 3.0 [0.303833] acx565akm spi1.2: omapfb: acx565akm rev 8b LCD

Re: DSS2 broken with 36-rc1

2010-08-23 Thread Tomi Valkeinen
On Mon, 2010-08-23 at 08:46 +0200, ext Mike Rapoport wrote: Hi Ameya, Ameya Palande wrote: Hi Tomi, When I tried to boot 2.6.36-rc1 kernel on Nokia N900, omapfb failed with following error messages: [0.124145] OMAP DSS rev 2.0 [0.124237] OMAP DISPC rev 3.0 [

Re: [linux-pm] [PATCH] PM: runtime PM + idle: allow usage when interrupts are disabled

2010-08-23 Thread Pavel Machek
Hi! When using runtime PM in combination with CPUidle, the runtime PM transtions of some devices may be triggered during the idle path. Late in the idle sequence, interrupts will likely be disabled when runtime PM for these devices is initiated. Currently, the runtime PM core assumes

Re: DSS2 broken with 36-rc1

2010-08-23 Thread Mike Rapoport
Tomi Valkeinen wrote: On Mon, 2010-08-23 at 08:46 +0200, ext Mike Rapoport wrote: Hi Ameya, Ameya Palande wrote: Hi Tomi, When I tried to boot 2.6.36-rc1 kernel on Nokia N900, omapfb failed with following error messages: [0.124145] OMAP DSS rev 2.0 [0.124237] OMAP DISPC rev 3.0 [

Re: DSS2 broken with 36-rc1

2010-08-23 Thread Tomi Valkeinen
On Mon, 2010-08-23 at 09:19 +0200, ext Mike Rapoport wrote: Tomi Valkeinen wrote: I tested 36-rc1 briefly with OMAP 3430SDP board. I wonder why that works, but not N900... May it be that 3430SDP uses SRAM for the framebuffer? Or reserves framebuffer memory from the RAM that is not

Re: [PATCH 05/10] [PM-WIP-MMC] OMAP4 hwmod: Updating hwmod data for MMC controllers

2010-08-23 Thread Cousson, Benoit
Hi Kishore, On 8/20/2010 10:10 PM, Kadiyala, Kishore wrote: Update register offsets and dev attributes for MMC controllers on OMAP4 Cc: Kevin Hilmankhil...@deeprootsystems.com Cc: Benoit Coussonb-cous...@ti.com Signed-off-by: Kishore Kadiyalakishore.kadiy...@ti.com ---

Re: DSS2 broken with 36-rc1

2010-08-23 Thread Mike Rapoport
Tomi Valkeinen wrote: On Mon, 2010-08-23 at 09:19 +0200, ext Mike Rapoport wrote: Tomi Valkeinen wrote: I tested 36-rc1 briefly with OMAP 3430SDP board. I wonder why that works, but not N900... May it be that 3430SDP uses SRAM for the framebuffer? Or reserves framebuffer memory from the RAM

RE: [PATCH-V2 1/3] RTC:s35390a: Add Alarm interrupt support

2010-08-23 Thread Hiremath, Vaibhav
-Original Message- From: Felipe Balbi [mailto:felipe.ba...@nokia.com] Sent: Monday, August 23, 2010 12:00 PM To: Hiremath, Vaibhav Cc: Balbi Felipe (Nokia-MS/Helsinki); linux-ker...@vger.kernel.org; a...@linux-foundation.org; byron.bbrad...@gmail.com; linux- o...@vger.kernel.org

[RFC: PATCH] Fix to support multiple HWMODS for a single device

2010-08-23 Thread Kishon Vijay Abraham I
The current HWMOD code expects multiple HWMODS to be filled in consecutive memory location before passing to omap_device_build_ss(). Ignoring this will result in incorrect HWMOD data being extracted. This means before calling omap_device_build_ss() the user has to create memory chunks, copy all

Re: [RFC: PATCH] Fix to support multiple HWMODS for a single device

2010-08-23 Thread Cousson, Benoit
Hi Vijay, On 8/23/2010 12:46 PM, ABRAHAM, KISHON VIJAY wrote: The current HWMOD code expects multiple HWMODS to be filled in consecutive memory location before passing to omap_device_build_ss(). Just a minor comment: this is not the The current HWMOD code but the omap_device core code.

RE: [RFC: PATCH] Fix to support multiple HWMODS for a single device

2010-08-23 Thread Datta, Shubhrajyoti
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Cousson, Benoit Sent: Monday, August 23, 2010 5:20 PM To: ABRAHAM, KISHON VIJAY Cc: linux-omap@vger.kernel.org; khil...@deeprootsystems.com; p...@pwsan.com Subject:

Re: [PATCH 3/3] OMAP: hwmod: Force a softreset during _setup

2010-08-23 Thread Cousson, Benoit
Hi Partha, Here is a small patch that should fix that issue: The approach is quite basic, I'm just enabling all the optional clocks if the flag is set. Could you give it a try? Thanks, Benoit --- From 37cda332362d58e584cf3df190a9dceb9c9db8ab Mon Sep 17 00:00:00 2001 From: Benoit Cousson

Re: [linux-pm] [PATCH] PM: runtime PM + idle: allow usage when interrupts are disabled

2010-08-23 Thread Kevin Hilman
Alan Stern st...@rowland.harvard.edu writes: On Thu, 19 Aug 2010, Kevin Hilman wrote: In any case, I don't really like this change. It seems that we would be better off preventing the runtime PM calls from occurring in the first place while interrupts are disabled. Why? Because

Re: [linux-pm] [PATCH] PM: runtime PM + idle: allow usage when interrupts are disabled

2010-08-23 Thread Kevin Hilman
Rafael J. Wysocki r...@sisk.pl writes: On Thursday, August 19, 2010, Kevin Hilman wrote: Rafael J. Wysocki r...@sisk.pl writes: On Tuesday, August 10, 2010, Kevin Hilman wrote: When using runtime PM in combination with CPUidle, the runtime PM transtions of some devices may be triggered

RE: [PATCH 10/13 v5] OMAP: GPIO: Implement GPIO as a platform device

2010-08-23 Thread Basak, Partha
-Original Message- From: Basak, Partha Sent: Thursday, August 12, 2010 5:35 PM To: 'Paul Walmsley' Cc: Kevin Hilman; Varadarajan, Charulatha; linux-omap@vger.kernel.org; Cousson, Benoit; Nayak, Rajendra Subject: RE: [PATCH 10/13 v5] OMAP: GPIO: Implement GPIO as a platform device

[PATCH 11/20] Move dispc init to dispc probe

2010-08-23 Thread Guruswamy Senthilvadivu
From: Senthilvadivu Guruswamy svad...@ti.com DISPC init and exit moved to dispc probe and remove. Signed-off-by: Senthilvadivu Guruswamy svad...@ti.com --- drivers/video/omap2/dss/core.c | 21 +++-- 1 files changed, 11 insertions(+), 10 deletions(-) diff --git

[PATCH 04/20] Create platform_driver for each DSS HW IP

2010-08-23 Thread Guruswamy Senthilvadivu
From: Senthilvadivu Guruswamy svad...@ti.com Platform driver of DSS HW IP are to be registered in sequence before the omapdss platform driver is registered. Signed-off-by: Senthilvadivu Guruswamy svad...@ti.com --- drivers/video/omap2/dss/core.c | 121

[PATCH 18/20] Get DSI base addr with platform device

2010-08-23 Thread Guruswamy Senthilvadivu
From: Senthilvadivu Guruswamy svad...@ti.com DSI base addr got from platform device. Hardcoding of base addr removed. Signed-off-by: Senthilvadivu Guruswamy svad...@ti.com --- drivers/video/omap2/dss/dsi.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 10/20] Move rfbi init to rfbi probe

2010-08-23 Thread Guruswamy Senthilvadivu
From: Senthilvadivu Guruswamy svad...@ti.com RFBI init and exit moved to rfbi probe and remove. Signed-off-by: Senthilvadivu Guruswamy svad...@ti.com --- drivers/video/omap2/dss/core.c | 21 +++-- 1 files changed, 11 insertions(+), 10 deletions(-) diff --git

[PATCH 17/20] Get VENC base addr from platform device

2010-08-23 Thread Guruswamy Senthilvadivu
From: Senthilvadivu Guruswamy svad...@ti.com VENC base addr got from platform device. Hardcoding of base addr removed. Signed-off-by: Senthilvadivu Guruswamy svad...@ti.com --- drivers/video/omap2/dss/venc.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 08/20] Replace clk_enable/disable APIs with HWMOD APIs

2010-08-23 Thread Guruswamy Senthilvadivu
From: Senthilvadivu Guruswamy svad...@ti.com when DSS ICK, FCK are requested, dss HWMOD APIs are used for enable and disable. The remaining clocks (dss opt clks in HWMOD database) continue to use clk APIs, since HWMOD APIs are not fully available for the dss opt clocks without the usage of clk

[PATCH 19/20] Get RFBI baseaddr with platform device

2010-08-23 Thread Guruswamy Senthilvadivu
From: Senthilvadivu Guruswamy svad...@ti.com RFBI base addr got from platform device. Hardcoding of base addr removed. Signed-off-by: Senthilvadivu Guruswamy svad...@ti.com --- drivers/video/omap2/dss/rfbi.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 05/20] Move dss platform driver to dss.c

2010-08-23 Thread Guruswamy Senthilvadivu
From: Senthilvadivu Guruswamy svad...@ti.com dsshw_probe and remove functions are moved to dss.c To maintain the order of init, through the dsshw_probe, omap_dss_init2 is made as device_init_call_sync. Signed-off-by: Senthilvadivu Guruswamy svad...@ti.com --- drivers/video/omap2/dss/core.c |

[PATCH 03/20] Build omap_device for each DSS HW IP

2010-08-23 Thread Guruswamy Senthilvadivu
From: Senthilvadivu Guruswamy svad...@ti.com Looks up the HWMOD database for each of the given DSS HW IP and builds omap_device which inturn does the platform device register for each of DSS HW IP Signed-off-by: Senthilvadivu Guruswamy svad...@ti.com --- arch/arm/mach-omap2/devices.c

[PATCH 16/20] Get DISPC base addr with platform device

2010-08-23 Thread Guruswamy Senthilvadivu
From: Senthilvadivu Guruswamy svad...@ti.com DISPC Base addr got from the platform device. Hadrcoding of base addr removed. Signed-off-by: Senthilvadivu Guruswamy svad...@ti.com --- drivers/video/omap2/dss/dispc.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 01/20] DSS HWMOD database generation for OMAP3

2010-08-23 Thread Guruswamy Senthilvadivu
From: Senthilvadivu Guruswamy svad...@ti.com OMAP3 HWMOD database for DSS is added and is applicable for 34xx and 36xx. Signed-off-by: Senthilvadivu Guruswamy svad...@ti.com --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 346 1 files changed, 346 insertions(+), 0

[PATCH 14/20] Pass platform_device argument to rfbi,dispc

2010-08-23 Thread Guruswamy Senthilvadivu
From: Senthilvadivu Guruswamy svad...@ti.com Add platform_device argument to rfbi_init and dispc_init to pass the pdev to the driver. Signed-off-by: Senthilvadivu Guruswamy svad...@ti.com --- drivers/video/omap2/dss/core.c |4 ++-- drivers/video/omap2/dss/dispc.c |2 +-

[PATCH 15/20] Use platform device to get DSS base addr

2010-08-23 Thread Guruswamy Senthilvadivu
From: Senthilvadivu Guruswamy svad...@ti.com DSS Base addr got form platform device. Hardcoding of base addr could be removed. Signed-off-by: Senthilvadivu Guruswamy svad...@ti.com --- drivers/video/omap2/dss/dss.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git

[PATCH 02/20] Move DSS driver register from board to mach_omap2

2010-08-23 Thread Guruswamy Senthilvadivu
From: Senthilvadivu Guruswamy svad...@ti.com Move the DSS driver register from board file to devices.c. Regulator initialisation done with driver name instead of the device name. Signed-off-by: Senthilvadivu Guruswamy svad...@ti.com --- arch/arm/mach-omap2/board-3430sdp.c | 25

[PATCH 06/20] DSS driver name change in clock database

2010-08-23 Thread Guruswamy Senthilvadivu
From: Senthilvadivu Guruswamy svad...@ti.com Change the dss driver name from omapdss to dss in clock database against the dss related clocks Signed-off-by: Senthilvadivu Guruswamy svad...@ti.com --- arch/arm/mach-omap2/clock3xxx_data.c | 14 +++--- 1 files changed, 7 insertions(+), 7

[PATCH 12/20] Move venc init to venc probe

2010-08-23 Thread Guruswamy Senthilvadivu
From: Senthilvadivu Guruswamy svad...@ti.com VENC init and exit moved to venc probe and remove. regulator used by venc is moved to venc driver alone. Signed-off-by: Senthilvadivu Guruswamy svad...@ti.com --- arch/arm/mach-omap2/board-3430sdp.c |2 +- drivers/video/omap2/dss/core.c |

[PATCH 09/20] Move dss_init to dsshw_probe

2010-08-23 Thread Guruswamy Senthilvadivu
From: Senthilvadivu Guruswamy svad...@ti.com Move dss_init and dss_exit from core driver to dss driver Signed-off-by: Senthilvadivu Guruswamy svad...@ti.com --- drivers/video/omap2/dss/core.c | 15 --- drivers/video/omap2/dss/dss.c | 17 - 2 files changed, 16

[PATCH 20/20] Get DSS IRQ with platform device

2010-08-23 Thread Guruswamy Senthilvadivu
From: Senthilvadivu Guruswamy svad...@ti.com DSS IRQ got from platform device. Hardcoding of baseaddr, IRQ removed. Signed-off-by: Senthilvadivu Guruswamy svad...@ti.com --- drivers/video/omap2/dss/dss.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git

[PATCH 13/20] Move dsi init to dsi probe

2010-08-23 Thread Guruswamy Senthilvadivu
From: Senthilvadivu Guruswamy svad...@ti.com DSI init and exit moved to dsi probe and remove. regulator in dsi could be taken care in board file as REGULATOR_SUPPLY(vdds_dsi, dss_dsi1), but not added as part of this patch. Signed-off-by: Senthilvadivu Guruswamy svad...@ti.com ---

[RFC PATCH 00/20] HWMOD Adaptation for DSS

2010-08-23 Thread Guruswamy Senthilvadivu
From: Senthilvadivu Guruswamy svad...@ti.com Patch Base: === url = git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git branch pm-wip/hwmods-omap4 Commit id: f6f7f1103b80b4dc0ace8a0314d95d1b1ebca726 Description: Merge branch 'pm-wip/hwmods' into

Re: [RFC: PATCH] Fix to support multiple HWMODS for a single device

2010-08-23 Thread kishon
Thanks Benoit for your review comments. On Monday 23 August 2010 05:31 PM, Datta, Shubhrajyoti wrote: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Cousson, Benoit Sent: Monday, August 23, 2010 5:20 PM To:

Re: [RFC PATCH 00/20] HWMOD Adaptation for DSS

2010-08-23 Thread Cousson, Benoit
On 8/23/2010 5:57 PM, Guruswamy, Senthilvadivu wrote: From: Senthilvadivu Guruswamysvad...@ti.com Patch Base: === url = git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git branch pm-wip/hwmods-omap4 Commit id: f6f7f1103b80b4dc0ace8a0314d95d1b1ebca726 Description:

Re: [PATCH 15/20] Use platform device to get DSS base addr

2010-08-23 Thread Cousson, Benoit
On 8/23/2010 5:58 PM, Guruswamy, Senthilvadivu wrote: From: Senthilvadivu Guruswamysvad...@ti.com DSS Base addr got form platform device. Hardcoding of base addr could be removed. Signed-off-by: Senthilvadivu Guruswamysvad...@ti.com --- drivers/video/omap2/dss/dss.c |4 +++- 1 files

Re: [PATCH 1/5] OMAP4: runtime: Enable PM runtime core for OMAP4

2010-08-23 Thread Kevin Hilman
Rajendra Nayak rna...@ti.com writes: The PM runtime core functions are implemented in pm_bus.c which needs to be compiled for CONFIG_ARCH_OMAP4 for runtime api's to work. Signed-off-by: Rajendra Nayak rna...@ti.com Cc: Kevin Hilman khil...@deeprootsystems.com I'll fold this one into the

Re: [PATCH 2/5] OMAP2xxx: hwmod: add I2C hwmods for OMAP2420, 2430

2010-08-23 Thread Kevin Hilman
Rajendra Nayak rna...@ti.com writes: From: Paul Walmsley p...@pwsan.com Add hwmod structures for I2C controllers on OMAP2420/2430. Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Rajendra Nayak rna...@ti.com Cc: Kevin Hilman khil...@deeprootsystems.com ---

Re: [PATCH 5/5] OMAP: I2C: Convert i2c driver to use PM runtime api's

2010-08-23 Thread Kevin Hilman
Rajendra Nayak rna...@ti.com writes: This patch converts the i2c driver to use PM runtime apis for OMAP2+ and omap_device api's for OMAP1 Signed-off-by: Rajendra Nayak rna...@ti.com Cc: Kevin Hilman khil...@deeprootsystems.com Cc: Paul Walmsley p...@pwsan.com Some minor comments below, but

Re: [PATCH] dmtimer: hwmod: OMAP1: device registration

2010-08-23 Thread Kevin Hilman
Tarun Kanti DebBarma tarun.ka...@ti.com writes: This patch converts OMAP1 dual mode timers into platform devices, adds support for registering them through generic linux platform device layer. ...and changes the init sequence ordering from a sys_timer to an arch_initcall (more on this

Re: [PATCH 4/13] dmtimer: hwmod: OMAP: api to read omap_hwmod _clk

2010-08-23 Thread Kevin Hilman
Tarun Kanti DebBarma tarun.ka...@ti.com writes: This patch adds the omap_hwmod_get_clk() to access the _clk field needed while setting clock sources of the timers. Signed-off-by: Partha Basak p-bas...@ti.com Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com Signed-off-by: Thara

Re: [PATCHv2 5/13] dmtimer: hwmod: OMAP: conversion to platform driver

2010-08-23 Thread Kevin Hilman
Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Thara Gopinath th...@ti.com This essentially involves moving out interrupt and base address related info from plat-omap/dmtimer.c and making certain clock related functions platform data. This patch also initializes dmtimer driver as a

Re: [PATCH-V2 3/3] RTC:s35390a: Add update_irq (per Min interrupt) support

2010-08-23 Thread Andrew Morton
On Sat, 21 Aug 2010 18:00:29 +0530 hvaib...@ti.com wrote: +static int s35390a_update_irq_enable(struct i2c_client *client, + unsigned enabled) +{ + struct s35390a *s35390a = i2c_get_clientdata(client); + char buf[1]; + + if

Re: [PATCHv2 6/13] dmtimer: hwmod: OMAP2PLUS: device registration

2010-08-23 Thread Kevin Hilman
Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Thara Gopinath th...@ti.com This patch converts dmtimers into platform devices using omap hwmod, omap device and runtime pm frameworks. It also allows GPTIMER1 and GPTIMER2 and GPTIMER10 to be registered as early devices. This allows any

Re: [PATCHv2 6/13] dmtimer: hwmod: OMAP2PLUS: device registration

2010-08-23 Thread Kevin Hilman
Tarun Kanti DebBarma tarun.ka...@ti.com writes: +/** +* omap2_dm_timer_early_init - top level early timer initialization +* called in the last part of omap2_init_common_hw +* +* uses dedicated hwmod api to parse through hwmod database for +* given class name and then build and register the

Re: [PATCHv2 8/13] dmtimer: OMAP: multi-platform register access support

2010-08-23 Thread Kevin Hilman
Tarun Kanti DebBarma tarun.ka...@ti.com writes: This patch uses the new register structures and mappings in functions in order to access register offsets thereby supporting multi-platform environment. Signed-off-by: Partha Basak p-bas...@ti.com Signed-off-by: Santosh Shilimkar

[PATCH v2] omap: 4430sdp board support for the the GPIO keys

2010-08-23 Thread Shubhrajyoti D
omap 4430sdp board support for the GPIO keys. The proximity sensor is connected to GPIO and is registered as a GPIO key. - Making the default state of the sensor off at bootup Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- arch/arm/mach-omap2/board-4430sdp.c | 61