Re: [PATCH 0/5] OMAP4: DSS2: HDMI: Add support for audio

2011-05-18 Thread Tomi Valkeinen
Hi, On Tue, 2011-05-17 at 13:00 -0500, Ricardo Neri wrote: Hi, I would like to solicit comments on this set of patches. Now that ASoC part of the implementation has been Ack'ed by ASoC maintainers, these patches are needed. I think the patches look ok. However, they don't apply to the

[PM-WIP_CPUFREQ][PATCH 0/6 v2] Cleanups for cpufreq

2011-05-18 Thread Nishanth Menon
Rev 2 of cleanups for cpufreq to include a couple of bugfixes we found as part of additional dvfs testing and code review. Testing done: OMAP4SDP4430 +.39-rc7- I think the only other major platform would be omap2 - but I doubt it was functional previously - if someone has a chance to give it a

[PM-WIP_CPUFREQ][PATCH 1/6 v2] OMAP2+: cpufreq: free up table on exit

2011-05-18 Thread Nishanth Menon
freq_table allocated by opp_init_cpufreq_table in omap_cpu_init needs to be freed in omap_cpu_exit. Signed-off-by: Nishanth Menon n...@ti.com --- arch/arm/mach-omap2/omap2plus-cpufreq.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

[PM-WIP_CPUFREQ][PATCH 2/6 v2] OMAP2+: cpufreq: handle invalid cpufreq table

2011-05-18 Thread Nishanth Menon
Handle the case when cpufreq_frequency_table_cpuinfo fails. freq_table that we passed failed the internal test of cpufreq generic driver, so we should'nt be using the freq_table as such. Instead, warn and fallback to clock functions for validation and operation. Signed-off-by: Nishanth Menon

[PM-WIP_CPUFREQ][PATCH 3/6 v2] OMAP2+: cpufreq: minor comment cleanup

2011-05-18 Thread Nishanth Menon
this should probably get squashed in.. Signed-off-by: Nishanth Menon n...@ti.com --- arch/arm/mach-omap2/omap2plus-cpufreq.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/omap2plus-cpufreq.c b/arch/arm/mach-omap2/omap2plus-cpufreq.c index

[PM-WIP_CPUFREQ][PATCH 4/6 v2] OMAP2: cpufreq: use clk_init_cpufreq_table if OPPs not available

2011-05-18 Thread Nishanth Menon
OMAP2 does not use OPP tables at the moment for DVFS. Currently, we depend on opp table initialization to give us the freq_table, which makes sense for OMAP3+. for OMAP2, we should be using clk_init_cpufreq_table - so if the opp based frequency table initilization fails, fall back to

[PM-WIP_CPUFREQ][PATCH 5/6 v2] OMAP2+: cpufreq: use cpufreq_frequency_table_target

2011-05-18 Thread Nishanth Menon
Use cpufreq_frequency_table_target for finding the proper target instead of seeing if the frequency requested is divisible alone. if we have a frequency table, we should restrict ourselves to selecting the approved frequencies alone and only in the case where the frequency table is not available

[PM-WIP_CPUFREQ][PATCH 6/6 v2] OMAP2+: cpufreq: fix freq_table leak

2011-05-18 Thread Nishanth Menon
Since we have two cpus the cpuinit call for cpu1 causes freq_table of cpu0 to be overwritten. instead, we maintain a counter to keep track of cpus who use the cpufreq table allocate it once(one freq table for all CPUs) and free them once the last user is done with it. Signed-off-by: Nishanth

context_loss_count error value

2011-05-18 Thread Tomi Valkeinen
Hi Kevin, I was fixing DSS context loss handling which is a bit broken, and while testing on OMAP3 Overo, with -rc7 and omap2plus_defconfig, I noticed that get_context_loss_count() seems to always return 0. 0 should be returned when an error happens, and as far as I see in

Re: [PATCH 04/19] ARM: omap1: convert to using readl/writel instead of volatile struct

2011-05-18 Thread Russell King - ARM Linux
On Tue, May 17, 2011 at 10:59:28PM +0100, Catalin Marinas wrote: On 16 May 2011 18:26, Russell King - ARM Linux li...@arm.linux.org.uk wrote: --- a/arch/arm/mach-omap1/time.c +++ b/arch/arm/mach-omap1/time.c ...  static inline unsigned long notrace omap_mpu_timer_read(int nr)  { -      

Re: [PATCH] OMAP4: McBSP: Clear rx_irq at probe time

2011-05-18 Thread Jarkko Nikula
On Wed, 18 May 2011 08:52:07 +0300 Peter Ujfalusi peter.ujfal...@ti.com wrote: On Tuesday 17 May 2011 15:57:00 Tony Lindgren wrote: This file should be under drivers/ somewhere, can you guys please take care of that? Yeah, this has been discussed several times, and we have not reached

Re: [PM-WIP/voltdm_c][PATCH 02/11] OMAP3+: PM: voltage: add required debugfs interfaces

2011-05-18 Thread Tony Lindgren
* Nishanth Menon n...@ti.com [110518 08:13]: Kevin's patch: OMAP3+: voltage: remove unneeded debugfs interface removed ability to check the voltages in the domains. This puts a crunch on validation we can do, hence we re-introduce them back in Signed-off-by: Nishanth Menon n...@ti.com

Re: [PM-WIP/voltdm_c][PATCH 02/11] OMAP3+: PM: voltage: add required debugfs interfaces

2011-05-18 Thread Menon, Nishanth
On Wed, May 18, 2011 at 02:59, Tony Lindgren t...@atomide.com wrote: * Nishanth Menon n...@ti.com [110518 08:13]: Kevin's patch: OMAP3+: voltage: remove unneeded debugfs interface removed ability to check the voltages in the domains. This puts a crunch on validation we can do, hence we

Re: [PATCH] omap:pm: Fix boot-time errors with debugfs disabled

2011-05-18 Thread Menon, Nishanth
On Thu, May 12, 2011 at 14:16, Premi, Sanjeev pr...@ti.com wrote: [...] This patch fixes these errors by enclosing code related to debugfs in #ifdef CONFIG_DEBUG_FS..#endif. generic - couple of comments - I think the #defs should be isolated off to headers - maybe the right approach may be

Re: [PM-WIP/voltdm_c][PATCH 02/11] OMAP3+: PM: voltage: add required debugfs interfaces

2011-05-18 Thread Tony Lindgren
* Menon, Nishanth n...@ti.com [110518 11:03]: On Wed, May 18, 2011 at 02:59, Tony Lindgren t...@atomide.com wrote: * Nishanth Menon n...@ti.com [110518 08:13]: Kevin's patch: OMAP3+: voltage: remove unneeded debugfs interface removed ability to check the voltages in the domains. This

Re: [PM-WIP/voltdm_c][PATCH 02/11] OMAP3+: PM: voltage: add required debugfs interfaces

2011-05-18 Thread Menon, Nishanth
On Wed, May 18, 2011 at 03:34, Tony Lindgren t...@atomide.com wrote: * Menon, Nishanth n...@ti.com [110518 11:03]: On Wed, May 18, 2011 at 02:59, Tony Lindgren t...@atomide.com wrote: * Nishanth Menon n...@ti.com [110518 08:13]: Kevin's patch: OMAP3+: voltage: remove unneeded debugfs

Re: [PM-WIP/voltdm_c][PATCH 02/11] OMAP3+: PM: voltage: add required debugfs interfaces

2011-05-18 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: Kevin's patch: OMAP3+: voltage: remove unneeded debugfs interface removed ability to check the voltages in the domains. This puts a crunch on validation we can do, hence we re-introduce them back in Signed-off-by: Nishanth Menon n...@ti.com NAK. I

Re: [PM-WIP/voltdm_c][PATCH 02/11] OMAP3+: PM: voltage: add required debugfs interfaces

2011-05-18 Thread Menon, Nishanth
On Wed, May 18, 2011 at 03:44, Kevin Hilman khil...@ti.com wrote: Nishanth Menon n...@ti.com writes: Kevin's patch: OMAP3+: voltage: remove unneeded debugfs interface removed ability to check the voltages in the domains. This puts a crunch on validation we can do, hence we re-introduce

Re: [PM-WIP/voltdm_c][PATCH 04/11] OMAP4: PM: VC: support configuration of i2c clks

2011-05-18 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: Patch OMAP2+: voltage: split voltage controller (VC) code into dedicated layer splits out the hardcoded value in the code to vc's channel init. This patch further isolates the configuration to remove out PMIC specific configuration as high and low times

Re: [PM-WIP/voltdm_c][PATCH 01/11] OMAP3+: PM: SR: fix debugfs

2011-05-18 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: Kevin's patch: OMAP3+: voltage: remove unneeded debugfs interface broke SR autocomp enablement - autocomps for all domains are created now in debugfs/smartreflex instead of debugfs/smartreflex/domain causing SR not to work. Signed-off-by: Nishanth Menon

Re: [PATCH] omap3: boot message is not an error

2011-05-18 Thread Kevin Hilman
Jarkko Nikula jhnik...@gmail.com writes: On Tue, 17 May 2011 19:33:41 +0200 Kevin Hilman khil...@ti.com wrote: Hi Sanjeev, On Tue, 2011-05-17 at 20:32 +0530, Sanjeev Premi wrote: With current level, it shows up on the console despite using 'silent' in bootargs. Signed-off-by:

Re: [PM-WIP/voltdm_c][PATCH 04/11] OMAP4: PM: VC: support configuration of i2c clks

2011-05-18 Thread Menon, Nishanth
On Wed, May 18, 2011 at 03:53, Kevin Hilman khil...@ti.com wrote: Nishanth Menon n...@ti.com writes: Patch OMAP2+: voltage: split voltage controller (VC) code into dedicated layer splits out the hardcoded value in the code to vc's channel init. This patch further isolates the configuration

Re: [PM-WIP/voltdm_c][PATCH 03/11] OMAP3+: PM: VP: fix vstepmax

2011-05-18 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: Kevin's OMAP3+: VP: remove omap_vp_runtime_data has a typo to fix which causes waittime to be populated for stepmax. this is flawed. Signed-off-by: Nishanth Menon n...@ti.com Adding to voltdm queue, will fold into original patch. Thanks for

RE: [PATCH] omap3: boot message is not an error

2011-05-18 Thread Premi, Sanjeev
-Original Message- From: Hilman, Kevin Sent: Wednesday, May 18, 2011 2:27 PM To: Jarkko Nikula Cc: Premi, Sanjeev; linux-omap@vger.kernel.org Subject: Re: [PATCH] omap3: boot message is not an error Jarkko Nikula jhnik...@gmail.com writes: On Tue, 17 May 2011 19:33:41 +0200

Re: [PM-WIP/voltdm_c][PATCH 05/11] OMAP4: PM: VC: fix highspeed i2c for SR

2011-05-18 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: Patch OMAP3+: VC: make I2C config programmable with PMIC-specific settings wrongly uses shift register causing mcode to be set instead of HS mode bit to be set for I2C_SR. Oops, thanks for testing/finding/fixing. Fix the same for OMAP4 and rename the shift

RE: [PATCH] omap:pm: Fix boot-time errors with debugfs disabled

2011-05-18 Thread Premi, Sanjeev
-Original Message- From: Menon, Nishanth Sent: Wednesday, May 18, 2011 1:55 PM To: Premi, Sanjeev Cc: linux-omap@vger.kernel.org Subject: Re: [PATCH] omap:pm: Fix boot-time errors with debugfs disabled On Thu, May 12, 2011 at 14:16, Premi, Sanjeev pr...@ti.com wrote: [...]

Re: [RESEND PATCH 1/4] omap: igep0020: name refactoring for future merge with IGEP3

2011-05-18 Thread Igor Grinberg
On 05/17/11 13:33, Tony Lindgren wrote: * Enric Balletbò i Serra eballe...@gmail.com [110517 00:53]: Hi, 2011/5/17 Tony Lindgren t...@atomide.com: * Enric Balletbò i Serra eballe...@gmail.com [110516 10:11]: Hi Mike, The only comment I wanted to do is maybe I prefer rename the

Re: [PATCH] omap:pm: Fix boot-time errors with debugfs disabled

2011-05-18 Thread Menon, Nishanth
On Wed, May 18, 2011 at 04:00, Premi, Sanjeev pr...@ti.com wrote: While cleaning up voltdm_c set earlier this week, I think your changes apply better there. btw, I could incorporate a bit of your code into my patch, esp the one Tony commented on

[PATCH] OMAP3: pm: Boot message is not an error, remove it

2011-05-18 Thread Sanjeev Premi
It shows up on the console despite using silent in the bootargs. Signed-off-by: Sanjeev Premi pr...@ti.com Cc: jhnik...@gmail.com --- v2: Changed the subject. Removed the print altogether v1: Convert printk to pr_info arch/arm/mach-omap2/pm34xx.c |2 -- 1 files changed, 0

RE: [PATCH] omap:pm: Fix boot-time errors with debugfs disabled

2011-05-18 Thread Premi, Sanjeev
-Original Message- From: Menon, Nishanth Sent: Wednesday, May 18, 2011 2:36 PM To: Premi, Sanjeev Cc: linux-omap@vger.kernel.org Subject: Re: [PATCH] omap:pm: Fix boot-time errors with debugfs disabled On Wed, May 18, 2011 at 04:00, Premi, Sanjeev pr...@ti.com wrote: While

Re: [PATCH] ARM: fix mistaken dependency for CPU_HAS_PMU

2011-05-18 Thread Ming Lei
Hi, 2011/5/18 Will Deacon will.dea...@arm.com: Hi, From: Ming Lei tom.leim...@gmail.com Obviously it is mistake for CPU_HAS_PMU to depend on (!ARCH_OMAP3 || OMAP3_EMU). It's not that obvious! No, on ubuntu 11.04, default config options enables ARCH_OMAP3 and ARCH_OMAP4, and disable

Re: [PM-WIP/voltdm_c][PATCH 06/11] OMAP4: PM: VC: fix channel bit offset for MPU

2011-05-18 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: Patch OMAP3+: VC: abstract out channel configuration abstracts out VC channel configuration. However, TRM has it's little surprises such as the following for channel_cfg: CFG_CHANNEL_SABIT(0) CFG_CHANNEL_RAV BIT(1) CFG_CHANNEL_RAC BIT(2)

Re: [PM-WIP/voltdm_c][PATCH 07/11] OMAP4: PM: TWL6030: fix voltage conversion formula

2011-05-18 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: From: Patrick Titiano p-titi...@ti.com omap_twl_vsel_to_uv() and omap_twl_uv_to_vsel() functions used to convert voltages to TWL6030 SMPS commands (a.k.a vsel) implement incorrect conversion formula. It uses legacy OMAP3 formula, but OMAP4 Power IC has

Re: [PM-WIP/voltdm_c][PATCH 08/11] OMAP4: PM: TWL6030: fix uv to voltage for 0x39

2011-05-18 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: using 1.35V as a check is not correct, we know that beyond 0x39, voltages are non linear - hence use the conversion iff uV greater than that for 0x39. For example, with 709mV as the smps offset, the max linear is actually 1.41V(0x39vsel)! Signed-off-by:

Re: [PM-WIP/voltdm_c][PATCH 06/11] OMAP4: PM: VC: fix channel bit offset for MPU

2011-05-18 Thread Menon, Nishanth
On Wed, May 18, 2011 at 04:34, Kevin Hilman khil...@ti.com wrote: Nishanth Menon n...@ti.com writes: Patch OMAP3+: VC: abstract out channel configuration abstracts out VC channel configuration. However, TRM has it's little surprises such as the following for channel_cfg: CFG_CHANNEL_SA    

[GIT PULL] USB Patches

2011-05-18 Thread Felipe Balbi
Hi Tony, These are all supposed to go into -rc cycle but I guess we're already too late for that (?). If so, let me know and I can add Cc: sta...@kernel.org to all of those patches so they go to stable releases too. The following changes since commit 693d92a1bbc9e42681c42ed190bd42b636ca876f:

Re: [PM-WIP/voltdm_c][PATCH 10/11] OMAP4: PM: TWL6030: fix ON/RET/OFF voltages

2011-05-18 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: From: Patrick Titiano p-titi...@ti.com According to latest OMAP4430 Data Manual v0.4 dated March 2011: - Retention voltage shall be set to 0.83V. See tables 2.2, 2.4 and 2.6 in DM. This allows saving a little more power in retention states. - OPP100

Re: [RESEND][PATCH 4/5] arm: omap: usb: Runtime PM support

2011-05-18 Thread Felipe Balbi
On Mon, May 16, 2011 at 03:08:52PM +0530, Keshava Munegowda wrote: From: Keshava Munegowda keshava_mgo...@ti.com The usbhs core driver does not enable/disable the intefrace and fucntional clocks; These clocks are handled by hwmod and runtime pm, hence insted of the clock enable/disable, the

Re: [RESEND][PATCH 5/5] arm: omap: usb: global Suspend and resume support of ehci and ohci

2011-05-18 Thread Felipe Balbi
Hi, On Mon, May 16, 2011 at 03:09:15PM +0530, Keshava Munegowda wrote: From: Keshava Munegowda keshava_mgo...@ti.com The global suspend and resume functions for usbhs core driver are implemented.These routine are called when the global suspend and resume occurs. Before calling these

Re: [RESEND][PATCH 1/5] arm: omap: usb: ehci and ohci hwmod structures for omap3 and omap4

2011-05-18 Thread Felipe Balbi
On Mon, May 16, 2011 at 03:06:10PM +0530, Keshava Munegowda wrote: Following 2 hwmod strcuture are added: UHH hwmod of usbhs with uhh base address and EHCI , OHCI irq and base addresses. TLL hwmod of usbhs with the TLL base address and irq. Signed-off-by: Keshava Munegowda

Re: [RESEND][PATCH 2/5] arm: omap: usb: register hwmods of usbhs

2011-05-18 Thread Felipe Balbi
On Mon, May 16, 2011 at 03:06:59PM +0530, Keshava Munegowda wrote: The hwmod structure of uhh and tll are retrived and registered with omap device Signed-off-by: Keshava Munegowda keshava_mgo...@ti.com applied, thanks -- balbi signature.asc Description: Digital signature

Re: [RESEND][PATCH 3/5] arm: omap: usb: device name change for the clk names of usbhs

2011-05-18 Thread Felipe Balbi
On Mon, May 16, 2011 at 03:08:01PM +0530, Keshava Munegowda wrote: device name usbhs clocks are changed from usbhs-omap.0 to usbhs_omap; this is because in the hwmod registration the device name is set as usbhs_omap Signed-off-by: Keshava Munegowda keshava_mgo...@ti.com applied, thanks --

Re: context_loss_count error value

2011-05-18 Thread Kevin Hilman
Tomi Valkeinen tomi.valkei...@ti.com writes: Hi Kevin, I was fixing DSS context loss handling which is a bit broken, and while testing on OMAP3 Overo, with -rc7 and omap2plus_defconfig, I noticed that get_context_loss_count() seems to always return 0. 0 should be returned when an error

Re: [PATCH v1] omap: usbhs: Fixed the crash during rmmod of ehci and ohci

2011-05-18 Thread Felipe Balbi
On Mon, May 16, 2011 at 02:24:58PM +0530, Keshava Munegowda wrote: From: Keshava Munegowda keshava_mgo...@ti.com The disabling of clocks and freeing GPIO are changed to fix the occurrence of the crash of rmmod of ehci and ohci drivers. The GPIOs should be freed after the spin locks are

Re: [RFC PATCH 09/10] OMAP: GPIO: cleanup omap_gpio_free and triggering functions

2011-05-18 Thread Varadarajan, Charulatha
Tarun, On Mon, May 16, 2011 at 17:11, Tarun Kanti DebBarma tarun.ka...@ti.com wrote: We can get rid of ifdef / if checks of OMAP revision in set_24xx_gpio_triggering() and omap_gpio_free(). Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com Cc: Charulatha V ch...@ti.com Cc: Santosh

Re: [PM-WIP/voltdm_c][PATCH 06/11] OMAP4: PM: VC: fix channel bit offset for MPU

2011-05-18 Thread Kevin Hilman
Menon, Nishanth n...@ti.com writes: [...] to handle this on the fly, add a structure to describe this and use the structure for vc44xx mpu definition. use the default for rest of the domains. IMO, while it makes us generate a few more struct in the data, I think it's cleaner to not treat

Re: [PM-WIP/voltdm_c][PATCH 06/11] OMAP4: PM: VC: fix channel bit offset for MPU

2011-05-18 Thread Menon, Nishanth
On Wed, May 18, 2011 at 06:06, Kevin Hilman khil...@ti.com wrote: Menon, Nishanth n...@ti.com writes: [...] to handle this on the fly, add a structure to describe this and use the structure for vc44xx mpu definition. use the default for rest of the domains. IMO, while it makes us

Re: context_loss_count error value

2011-05-18 Thread Tomi Valkeinen
On Wed, 2011-05-18 at 12:50 +0200, Kevin Hilman wrote: Tomi Valkeinen tomi.valkei...@ti.com writes: Hi Kevin, I was fixing DSS context loss handling which is a bit broken, and while testing on OMAP3 Overo, with -rc7 and omap2plus_defconfig, I noticed that get_context_loss_count()

Re: [GIT PULL] USB patches for next merge window

2011-05-18 Thread Felipe Balbi
Hi, forgot to Cc linux-omap. Sorry On Wed, May 18, 2011 at 02:03:53PM +0300, Felipe Balbi wrote: Hi Tony, these patches are for 2.6.40 merge window. The following changes since commit 693d92a1bbc9e42681c42ed190bd42b636ca876f: Linux 2.6.39-rc7 (2011-05-09 19:33:54 -0700) are

Re: [PATCH] OMAP4: McBSP: Clear rx_irq at probe time

2011-05-18 Thread Peter Ujfalusi
Hi Tony, On Tuesday 17 May 2011 15:57:00 Tony Lindgren wrote: This file should be under drivers/ somewhere, can you guys please take care of that? Do you have a place in mind? We have several things under arch/arm/plat-omap, like i2c, dma, fb, gpio, mcbsp, usb... Should we create a directory

Re: [PATCH v3] ARM: omap4: i2c reset regs postidle

2011-05-18 Thread Jan Weitzel
Am Dienstag, den 17.05.2011, 16:12 +0200 schrieb Kevin Hilman: Jan Weitzel j.weit...@phytec.de writes: omap4430 get i2c timeouts at each access after an NACK message. OMAP_I2C_FLAG_RESET_REGS_POSTIDLE fix it. We need a little better changelog here. Specifically, *why* does this flag

Re: [PATCH v3] ARM: omap4: i2c reset regs postidle

2011-05-18 Thread Kevin Hilman
Jan Weitzel j.weit...@phytec.de writes: Am Dienstag, den 17.05.2011, 16:12 +0200 schrieb Kevin Hilman: Jan Weitzel j.weit...@phytec.de writes: omap4430 get i2c timeouts at each access after an NACK message. OMAP_I2C_FLAG_RESET_REGS_POSTIDLE fix it. We need a little better changelog

Re: [PATCH v2 3/4] REGULATOR: TWL6025: add support to twl-regulator

2011-05-18 Thread Graeme Gregory
On 16/05/2011 10:08, T Krishnamoorthy, Balaji wrote: On Thu, May 12, 2011 at 6:57 PM, Graeme Gregory g...@slimlogic.co.uk wrote: Adding support for the twl6025. Major difference in the twl6025 is the group functionality has been removed from the chip so this affects how regulators are enabled

Re: context_loss_count error value

2011-05-18 Thread Kevin Hilman
Tomi Valkeinen tomi.valkei...@ti.com writes: On Wed, 2011-05-18 at 12:50 +0200, Kevin Hilman wrote: Tomi Valkeinen tomi.valkei...@ti.com writes: Hi Kevin, I was fixing DSS context loss handling which is a bit broken, and while testing on OMAP3 Overo, with -rc7 and omap2plus_defconfig,

Re: [PATCH v2 3/4] REGULATOR: TWL6025: add support to twl-regulator

2011-05-18 Thread Liam Girdwood
On Wed, 2011-05-18 at 15:17 +0100, Graeme Gregory wrote: On 16/05/2011 10:08, T Krishnamoorthy, Balaji wrote: On Thu, May 12, 2011 at 6:57 PM, Graeme Gregory g...@slimlogic.co.uk wrote: Adding support for the twl6025. Major difference in the twl6025 is the group functionality has been

Re: [PATCH v3 0/4] OMAP: cpuidle code clean-up

2011-05-18 Thread Kevin Hilman
jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com Rework of the OMAP2+ cpuidle code Excellent work! Thanks. Queuing for 2.6.40 (branch: for_2.6.40/pm-cleanup) Kevin v3: rework after comments on linux-omap ML: - renamed the C-state driver data variables as 'cx', - retain

Re: [PATCH] OMAP3: pm: Boot message is not an error, remove it

2011-05-18 Thread Kevin Hilman
Hi Sanjeev, Sanjeev Premi pr...@ti.com writes: It shows up on the console despite using silent in the bootargs. Signed-off-by: Sanjeev Premi pr...@ti.com Cc: jhnik...@gmail.com Thanks! Adding to queue for 2.6.40 (branch: for_2.6.40/pm-cleanup) Kevin --- v2: Changed the subject.

Re: context_loss_count error value

2011-05-18 Thread Tomi Valkeinen
On Wed, 2011-05-18 at 16:24 +0200, Kevin Hilman wrote: Looking closer at the code, a zero return happens only when 1) no hwmod associated to omap_device 2) no power domain associated to hwmod 3) power domain has not (yet) lost context None of these are actually error conditions per-se,

Re: [PATCH] OMAP4: fix return value of omap4_l3_init

2011-05-18 Thread Rabin Vincent
On Sat, May 7, 2011 at 22:28, Rabin Vincent ra...@rab.in wrote: Don't PTR_ERR() a non-error pointer:  initcall omap4_l3_init+0x0/0xdc returned -544980480 after 0 usecs  initcall omap4_l3_init+0x0/0xdc returned with error code -544980480 Signed-off-by: Rabin Vincent ra...@rab.in Ping? (with

Re: [PATCH v3] OMAP2/3: hwmod: fix the i2c-reset timeout during bootup

2011-05-18 Thread Paul Walmsley
On Mon, 9 May 2011, Avinash.H.M. wrote: On Thu, May 05, 2011 at 03:58:56PM -0600, Paul Walmsley wrote: The patch is based on * git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git * master branch. * 9be20f0 commit. ( Linux-omap rebuilt: Updated to -rc5 )

Re: [PATCH v3] OMAP2/3: hwmod: fix the i2c-reset timeout during bootup

2011-05-18 Thread Avinash.H.M.
On Wed, May 18, 2011 at 10:22:28AM -0600, Paul Walmsley wrote: On Mon, 9 May 2011, Avinash.H.M. wrote: On Thu, May 05, 2011 at 03:58:56PM -0600, Paul Walmsley wrote: The patch is based on * git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git *

Re: [PATCH] omap:pm: Fix boot-time errors with debugfs disabled

2011-05-18 Thread Kevin Hilman
Hi Sanjeev, Sanjeev Premi pr...@ti.com writes: There is an implicit assumption in current implementation that debugfs is always enabled. When debugfs is disabled, these errors are noticed during boot: omap_voltage_late_init: Unable to create voltage debugfs main dir vdd_debugfs_init:

Re: [PATCH 1/2] OMAP4: HDMI: Add OMAP device for HDMI audio CPU DAI

2011-05-18 Thread Steve Calfee
On 05/17/11 22:41, Peter Ujfalusi wrote: On Tuesday 17 May 2011 22:35:09 Steve Calfee wrote: I think the generally accepted method of doing stuff like this is to have the ifdeffery in a header file where a inline code segment is defined if it applies to the processor being built. If the code

[RFC/PATCH 00/13] OMAP2+: PM: isolate PM code in modules

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com First attempt at isolation of the OMAP2+ PM code RFC quality code but successfully tested on board as a proof of concept 1) provide PM functionality as modules To allow for the PM functionality to be built and used as modules a clean-up and isolation task first

[PATCH 01/13] perf: export power_start and power_end tracepoints

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com If used in a module both tracepoints need to be exported by the kernel. Fixed a typo in CONFIG_EVENT_POWER_TRACING_DEPRECATED to really export the tracepoints. Signed-off-by: Jean Pihet j-pi...@ti.com Acked-by: Ingo Molnar mi...@elte.hu Cc: Thomas Renninger

[PATCH 02/13] OMAP2+: PM: isolate PM code

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Isolate the PM code under CONFIG_PM. This includes the following: - core PM, - powerdomain, - clockdomain, - smartreflex, - voltagedomain, - OPP. This cleans up the PM code in order to allow it to be built as a module. Signed-off-by: Jean Pihet j-pi...@ti.com ---

[PATCH 03/13] OMAP2+: PM: clean up usage of SRAM functions

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Clean-up SRAM functions usage to better isolate PM code, in order to allow it to be used as a module. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/pm34xx.c |1 + arch/arm/plat-omap/sram.c|2 -- 2 files changed, 1 insertions(+), 2

[PATCH 04/13] OMAP2+: cpuidle: register the board specific C-states table

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Register the board specific cpuidle C-states table for the cpuidle driver to use it later at cpuidle init time. This also cleans up the cpuidle code, in order to allow it to be used as a module. Signed-off-by: Jean Pihet j-pi...@ti.com ---

[PATCH 06/13] OMAP2+: PM: isolate the scratchpad save function from the PM code

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com This patch provides the omap3_save_scratchpad_contents function as a service from the common control code. The PM code calls the service to store the appropriate data in the scratchpad area, including the restore pointer from OFF/OSWR modes and the secure RAM

[PATCH 07/13] OMAP2+: PM: move the powerdomains time stats to powerdomain code

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Move the powerdomains time accounting code from in pm-debug to the powerdomain code. The pm-debug code only displays the information on request. This also cleans up the core PM code, in order to allow it to be used as a module. Signed-off-by: Jean Pihet

[PATCH 05/13] OMAP2+: PM: move common code from pm-debug.c to pm.c

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Move variables and functions that are by the arch code to the common pm.c code. Moved: . PM knobs variables: - enable_off_mode - omap2_pm_debug - sleep_while_idle - wakeup_timer_seconds - wakeup_timer_milliseconds . omap2_pm_wakeup_on_timer function.

[PATCH 08/13] OMAP2+: PM: provide the next timer event API to PM modules

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Provide omap_pm_tick_nohz_get_sleep_length_us so that the code from the OMAP PM modules can use it. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/pm-debug.c |7 --- arch/arm/mach-omap2/pm.c | 15 +++

[PATCH 09/13] OMAP2+: PM: export suspend_set_ops to PM modules

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Export the suspend_set_ops API as omap_pm_suspend_set_ops in the pm generic code, under CONFIG_SUSPEND. Note -hack warning-: since the 'suspend_valid_only_mem' function is not exported to modules, fill the 'valid' field value of 'struct platform_suspend_ops' in

[PATCH 10/13] OMAP3: PM: export the v7_flush_dcache_all API to modules

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Provide the the assembly function v7_flush_dcache_all to the OMAP3 PM module, under CONFIG_CPU_V7. v7_flush_dcache_all is used by the low level sleep code. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/pm.c |4 arch/arm/mach-omap2/pm.h

[PATCH 12/13] OMAP2+: PM: export functions and variables to PM modules

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Addition of EXPORT_SYMBOL for functions and variables used by the code in PM modules. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/kernel/setup.c|1 + arch/arm/kernel/smp_tlb.c |2 ++ arch/arm/mach-omap2/clockdomain.c |7

[PATCH 11/13] OMAP2+: PM: implement modules insertion and removal code

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Clean-up of used resources to allow clean insertion and removal of the PM modules. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c | 14 +- arch/arm/mach-omap2/pm-debug.c| 22 +-

[PATCH 13/13] OMAP2+: PM: build PM functionality as modules

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com A new config option CONFIG_OMAP_PM is defined. This option allows for the whole OMAP2+ PM to completely enabled, disabled or be built as modules. The PM functionality is split into the following modules: - omap_pm_debug - omap2_pm - omap3_pm - omap4_pm The

[PATCH v3 0/2] Add support for twl6025 PMIC

2011-05-18 Thread Graeme Gregory
This patch series starts to add support for the twl6025 chip to the twl driver. This series contains patches for the MFD device and the regulator device to support the twl6025. Since V2 MFD patches have been accepted. Review comments have been addressed in the regulator driver. twl6025 doesnt

[PATCH v3 2/2] USB: TWL6025 allow different regulator name

2011-05-18 Thread Graeme Gregory
The twl6025 uses a different regulator for USB than the 6030 so select the correct regulator name depending on the subclass of device. Since V1 Use features passed via platform data instead of global variable. Signed-off-by: Graeme Gregory g...@slimlogic.co.uk --- drivers/usb/otg/twl6030-usb.c

[PATCH v3 1/2] REGULATOR: TWL6025: add support to twl-regulator

2011-05-18 Thread Graeme Gregory
Adding support for the twl6025. Major difference in the twl6025 is the group functionality has been removed from the chip so this affects how regulators are enabled and disabled. The names of the regulators also changed. The DCDCs of the 6025 are software controllable as well. Since V1 Use the

Re: [PATCH] omap:pm: Fix boot-time errors with debugfs disabled

2011-05-18 Thread Menon, Nishanth
On Wed, May 18, 2011 at 11:34, Kevin Hilman khil...@ti.com wrote: Basically, I'm in the process of a pretty major cleanup of the VC/VP and SR layers.  For example, in my pm-wip/voltdm_* branches, the debugfs interface to the voltage layer has been completely removed.  I'm also thinking of

Re: [PATCH] rtc-twl: Switch to using threaded irq

2011-05-18 Thread Ilkka Koskinen
Hi, Tony, would you mind taking the patch in your tree? Btw, the nokia address doesn't work anymore, but should probably still remain in s-o-b... Cheers, Ilkka 13.5.2011 2:24, John Stultz kirjoitti: On Thu, 2011-05-05 at 07:51 +, ilkka.koski...@nokia.com wrote: Hi, Tony and John: What

Re: [PM-WIP_CPUFREQ][PATCH 3/6 v2] OMAP2+: cpufreq: minor comment cleanup

2011-05-18 Thread Todd Poynor
On Wed, May 18, 2011 at 02:37:43AM -0500, Nishanth Menon wrote: this should probably get squashed in.. Signed-off-by: Nishanth Menon n...@ti.com --- arch/arm/mach-omap2/omap2plus-cpufreq.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [PM-WIP_CPUFREQ][PATCH 3/6 v2] OMAP2+: cpufreq: minor comment cleanup

2011-05-18 Thread Menon, Nishanth
On Wed, May 18, 2011 at 15:08, Todd Poynor toddpoy...@google.com wrote: On Wed, May 18, 2011 at 02:37:43AM -0500, Nishanth Menon wrote: this should probably get squashed in.. Signed-off-by: Nishanth Menon n...@ti.com ---  arch/arm/mach-omap2/omap2plus-cpufreq.c |    6 --  1 files

Re: [PATCH 04/19] ARM: omap1: convert to using readl/writel instead of volatile struct

2011-05-18 Thread Linus Walleij
2011/5/17 Catalin Marinas catalin.mari...@arm.com: On 16 May 2011 18:26, Russell King - ARM Linux li...@arm.linux.org.uk wrote: --- a/arch/arm/mach-omap1/time.c +++ b/arch/arm/mach-omap1/time.c ...  static inline unsigned long notrace omap_mpu_timer_read(int nr)  { -       volatile

[PATCH] mmc: fix handling NULL returned from regulator_get()

2011-05-18 Thread Antonio Ospite
When regulator_get() is stubbed down it returns NULL, handle this case when deciding whether the driver can use the regulator or not. Remember: IS_ERR(NULL) is false, see also this discussion for more insight: http://comments.gmane.org/gmane.linux.kernel.mmc/7934 Now that regulator_get() is

Re: [PATCH] mmc: fix handling NULL returned from regulator_get()

2011-05-18 Thread Chris Ball
Hi Antonio, thanks for doing this, On Wed, May 18 2011, Antonio Ospite wrote: When regulator_get() is stubbed down it returns NULL, handle this case when deciding whether the driver can use the regulator or not. Remember: IS_ERR(NULL) is false, see also this discussion for more insight:

Re: beagleboardxm 2.6.39rc4 mcbsp problems.

2011-05-18 Thread Steve Calfee
On 05/17/11 03:42, Peter Ujfalusi wrote: Hi, On Monday 16 May 2011 21:07:40 Steve Calfee wrote: No, they get called. I just don't get the clock on the bclk pin. OK. Could you try to disconnect the CLKX, and FSX lines from OMAP, and see that you have the clocks on the codec side? If in

Re: beagleboardxm 2.6.39rc4 mcbsp problems.

2011-05-18 Thread Steve Calfee
On 05/16/11 23:37, Jarkko Nikula wrote: Hi On Mon, 16 May 2011 11:07:40 -0700 Steve Calfee stevecal...@gmail.com wrote: On 05/16/11 01:54, Peter Ujfalusi wrote: On Saturday 14 May 2011 05:47:33 Steve Calfee wrote: I put in a few debug statements. It appears that my DMA never gets

Re: [PATCH 01/19] Make clocksource name const

2011-05-18 Thread Hans J. Koch
On Mon, May 16, 2011 at 06:25:54PM +0100, Russell King - ARM Linux wrote: As nothing should be writing to the clocksource name string, make the clocksource name pointer const. Build-tested on ARM Versatile Express. Cc: Alessandro Rubini rub...@unipv.it Cc: Colin Cross ccr...@android.com

Re: [PATCH] mmc: fix handling NULL returned from regulator_get()

2011-05-18 Thread Lars-Peter Clausen
On 05/18/2011 02:47 PM, Chris Ball wrote: Hi Antonio, thanks for doing this, On Wed, May 18 2011, Antonio Ospite wrote: When regulator_get() is stubbed down it returns NULL, handle this case when deciding whether the driver can use the regulator or not. Remember: IS_ERR(NULL) is false, see

Re: [PATCH 0/5] OMAP4: DSS2: HDMI: Add support for audio

2011-05-18 Thread Ricardo Neri
Hi Tomi, Le mercredi 18 mai 2011 à 01:13 -0500, Valkeinen, Tomi a écrit : Hi, On Tue, 2011-05-17 at 13:00 -0500, Ricardo Neri wrote: Hi, I would like to solicit comments on this set of patches. Now that ASoC part of the implementation has been Ack'ed by ASoC maintainers, these

Re: [PATCH 0/5] OMAP4: DSS2: HDMI: Add support for audio

2011-05-18 Thread Tomi Valkeinen
On Wed, 2011-05-18 at 23:36 -0500, Ricardo Neri wrote: Hi Tomi, Le mercredi 18 mai 2011 à 01:13 -0500, Valkeinen, Tomi a écrit : Hi, On Tue, 2011-05-17 at 13:00 -0500, Ricardo Neri wrote: Hi, I would like to solicit comments on this set of patches. Now that ASoC part of the

Re: [PATCH] mmc: fix handling NULL returned from regulator_get()

2011-05-18 Thread Jaehoon Chung
Lars-Peter Clausen wrote: On 05/18/2011 02:47 PM, Chris Ball wrote: Hi Antonio, thanks for doing this, On Wed, May 18 2011, Antonio Ospite wrote: When regulator_get() is stubbed down it returns NULL, handle this case when deciding whether the driver can use the regulator or not. Remember:

[PATCH 0/5] OMAP: DSS2: Add suppport for new color format

2011-05-18 Thread Amber Jain
This patch-set adds support for NV12 color format: - Adds support for various new color formats supported by OMAP4. - Corrects the fir_hinc and fir_vinc to have a non-zero value as per TRM. - Adds the support for NV12 along with the extra registers that needs to be configured for the same. -

[PATCH 1/5] OMAP: DSS2: Add new color formats

2011-05-18 Thread Amber Jain
Adds new color formats supported by OMAP4. Signed-off-by: Amber Jain am...@ti.com --- drivers/video/omap2/dss/dispc.c| 109 ++- drivers/video/omap2/dss/dss_features.c | 33 +- drivers/video/omap2/dss/manager.c |7 ++ include/video/omapdss.h

[PATCH 2/5] OMAP: DSS2: configuring non-zero values for fir_hinc/fir_vinc

2011-05-18 Thread Amber Jain
fir_hinc and fir_vinc can only have a non-zero value as per TRM. Hence removed the if...else condition and also made the necesary changes caused as the result of the condition removal. Signed-off-by: Amber Jain am...@ti.com --- drivers/video/omap2/dss/dispc.c | 15 --- 1 files

[PATCH 3/5] OMAP: DSS2: Use for loop where ever possible in SR(), RR(), DUMPREG()

2011-05-18 Thread Amber Jain
Use for loop instead of individual entries for OVL_FIR_COEF_H, OVL_FIR_COEF_HV, OVL_FIR_COEF_V and OVL_CONV_COEF in SR(), RR() and DUMPREG() functions. Signed-off-by: Amber Jain am...@ti.com --- drivers/video/omap2/dss/dispc.c | 257 +++ 1 files changed, 70

[PATCH 4/5] OMAP: DSS2: Adds new registers for NV12 support

2011-05-18 Thread Amber Jain
Adds new register definitions and simple helper functions to configure them. Added these new registers to save/restore and DUMPREG fumction. Also adds two new features FEAT_HANDLE_UV_SEPARATE and FEAT_ATTR2. Signed-off-by: Amber Jain am...@ti.com --- drivers/video/omap2/dss/dispc.c| 160

[PATCH 5/5] OMAP: DSS2: Add support for NV12 format

2011-05-18 Thread Amber Jain
Adds the support for NV12 color format. Added basic scaling support for the UV-plane in case of NV12 format. Contains chroma scaling (_dispc_set_scaling_uv) design and implemented by Lajos Molnar mol...@ti.com Signed-off-by: Amber Jain am...@ti.com --- drivers/video/omap2/dss/dispc.c | 201

  1   2   >