Re: [PATCH 5/5 v4] mfd: omap: usb: Runtime PM support

2011-08-12 Thread Munegowda, Keshava
On Wed, Aug 10, 2011 at 10:01 PM, Todd Poynor toddpoy...@google.com wrote: On Tue, Aug 09, 2011 at 07:45:09PM +0530, Keshava Munegowda wrote: From: Keshava Munegowda keshava_mgo...@ti.com The usbhs core driver does not enable/disable the intefrace and typo: interface fucntional clocks;

Re: [PATCH 2/5 v4] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-08-12 Thread Ming Lei
On Fri, Aug 12, 2011 at 1:46 PM, Munegowda, Keshava keshava_mgo...@ti.com wrote: On Thu, Aug 11, 2011 at 8:53 PM, Ming Lei tom.leim...@gmail.com wrote: +static struct omap_hwmod_class_sysconfig omap34xx_usb_host_hs_sysc = { +       .rev_offs       = 0x, +       .sysc_offs      = 0x0010,

RE: [PATCH v2] OMAP3: powerdomains: Match silicon revision to select the correct core_pwrdm definition

2011-08-12 Thread Koyamangalath, Abhilash
Hi On Friday, July 15, 2011 5:14 PM +0530, Koyamangalath, Abhilash wrote: From: Koyamangalath, Abhilash Sent: Friday, July 15, 2011 5:14 PM To: linux-omap@vger.kernel.org Cc: t...@atomide.com; li...@arm.linux.org.uk;

Re: [PATCH] OMAP: DSS2: DSI: fix warning unused variable 'dsidev'

2011-08-12 Thread Michael Jones
Hi all, On 08/05/2011 05:02 PM, Michael Jones wrote: CC drivers/video/omap2/dss/dsi.o drivers/video/omap2/dss/dsi.c: In function ‘omap_dsi_prepare_update’: drivers/video/omap2/dss/dsi.c:3936: warning: unused variable ‘dsidev’ Signed-off-by: Michael Jones

Re: [PATCH v4 00/15] PM QoS: add a per-device latency constraints class

2011-08-12 Thread Rafael J. Wysocki
On Thursday, August 11, 2011, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com This patch set is in an RFC state, for review and comments. High level implementation: 1. Preparation of the PM QoS for the addition of a device PM QoS constraints framework: . rename

[GIT PULL] omap fixes for v3.1-rc1

2011-08-12 Thread Tony Lindgren
Hi Arnd, Please pull omap fixes for -rc1 from: git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git fixes Note that this also includes a trivial patch that adds the missing UART4 defines used on some boards that would be good to get merged. If you rather have that in a

Re: [PATCH 2/5 v4] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-08-12 Thread Munegowda, Keshava
On Fri, Aug 12, 2011 at 12:55 PM, Ming Lei tom.leim...@gmail.com wrote: On Fri, Aug 12, 2011 at 1:46 PM, Munegowda, Keshava keshava_mgo...@ti.com wrote: On Thu, Aug 11, 2011 at 8:53 PM, Ming Lei tom.leim...@gmail.com wrote: +static struct omap_hwmod_class_sysconfig omap34xx_usb_host_hs_sysc =

Re: How to handle named resources with DT?

2011-08-12 Thread Cousson, Benoit
On 8/12/2011 5:02 AM, David Gibson wrote: On Thu, Aug 11, 2011 at 02:28:55PM +0200, Cousson, Benoit wrote: On 8/10/2011 9:22 PM, Grant Likely wrote: On Tue, Aug 9, 2011 at 7:52 PM, David Gibson da...@gibson.dropbear.id.au wrote: On Tue, Aug 09, 2011 at 11:53:32PM +0200, Cousson, Benoit

Re: How to handle named resources with DT?

2011-08-12 Thread Felipe Balbi
Hi, On Fri, Aug 12, 2011 at 01:02:18PM +1000, David Gibson wrote: That seems to be pretty straightforward to implement, and as soon as it is useful even for a couple of drivers, it worth adding it. It is anyway better than having to add a custom property to get the information we will

Re: [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver

2011-08-12 Thread Felipe Balbi
Hi, On Fri, Aug 12, 2011 at 08:56:29AM +0530, Rajendra Nayak wrote: On 8/12/2011 3:07 AM, Roger Quadros wrote: On 08/11/2011 01:55 PM, Felipe Balbi wrote: Hi, On Thu, Aug 11, 2011 at 09:54:09PM +0300, Felipe Balbi wrote: you need some other way to handle this. Why do you need to manually

Re: How to handle named resources with DT?

2011-08-12 Thread Cousson, Benoit
On 8/12/2011 6:10 AM, Shawn Guo wrote: On Tue, Aug 09, 2011 at 11:37:10PM +0200, Cousson, Benoit wrote: On 8/9/2011 11:16 PM, Grant Likely wrote: On Tue, Aug 09, 2011 at 11:06:30PM +0200, Cousson, Benoit wrote: On 8/9/2011 10:55 PM, Grant Likely wrote: On Tue, Aug 09, 2011 at 07:47:20PM

Re: [PATCH] usb: musb: use put_sync_suspend instead of put_sync

2011-08-12 Thread Felipe Balbi
Hi, (sorry for top-posting) Moiz, are we going to have another set of this ? On Thu, Aug 04, 2011 at 05:18:37PM -0700, Kevin Hilman wrote: Moiz Sonasath m-sonas...@ti.com writes: From: Axel Haslam axelhas...@ti.com As Documented in runtime documentation, drivers can call put_sync in

Re: [PATCH 3/4] usb: musb: OMAP4430: Remove incorrect call to omap4430_phy_init()

2011-08-12 Thread Felipe Balbi
Hi, On Thu, Aug 04, 2011 at 08:02:18PM +0200, Bjarne Steinsbo wrote: Don't call omap4430_phy_init(dev) before dev is initialized. The real omap4430_phy_init(dev) call is done at the end of this function. you're missing your's Signed-off-by line. -- balbi signature.asc Description: Digital

Re: [PATCH 4/4] usb: musb: OMAP: Delete unused function

2011-08-12 Thread Felipe Balbi
On Thu, Aug 04, 2011 at 08:02:23PM +0200, Bjarne Steinsbo wrote: Not in use anymore. missed Signed-off-by line. -- balbi signature.asc Description: Digital signature

Re: musb crash on suspend

2011-08-12 Thread Felipe Balbi
Hi, On Thu, Jul 28, 2011 at 05:05:13PM -0400, Cliff Brake wrote: Hello, I'm running 2.6.39 on omap3530 with a number of patches and am seeing the below crash on suspend. Questions: 1) does anyone have musb suspending with 2.6.39? 2) are there any fixes or suggestions? Thanks, Cliff

[PATCH] DMAEngine: Define generic transfer request api

2011-08-12 Thread Jassi Brar
Define a new api that could be used for doing fancy data transfers like interleaved to contiguous copy and vice-versa. Traditional SG_list based transfers tend to be very inefficient in such cases as where the interleave and chunk are only a few bytes, which call for a very condensed api to convey

Re: How to handle named resources with DT?

2011-08-12 Thread Shawn Guo
On Fri, Aug 12, 2011 at 10:56:13AM +0200, Cousson, Benoit wrote: [...] The devil is in the details, but the way the DMA lines are connected in OMAP is similar to IRQ lines, and maybe a little bit simpler. So starting with a copy/paste of the of_irq file should be a good start. And then the

Re: [PATCH v4 00/15] PM QoS: add a per-device latency constraints class

2011-08-12 Thread Jean Pihet
Hi Rafael, 2011/8/12 Rafael J. Wysocki r...@sisk.pl: On Thursday, August 11, 2011, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com This patch set is in an RFC state, for review and comments. ... Questions: 1. the user space API is still under discussions on linux-omap

Re: [PATCH] usb: musb: use put_sync_suspend instead of put_sync

2011-08-12 Thread Pandita, Vikram
On Fri, Aug 12, 2011 at 2:01 AM, Felipe Balbi ba...@ti.com wrote: Hi, (sorry for top-posting) Moiz, are we going to have another set of this ? The problem was with pm_runtime() functions getting called from atomic context and we did a work around by calling the runtime functions from a work

Re: [PATCH] OMAP: clockdomain: Wait for powerdomain to be ON when using clockdomain force wakeup

2011-08-12 Thread Paul Walmsley
(cc Tero) Hi Santosh, On Thu, 11 Aug 2011, Santosh wrote: On Saturday 16 July 2011 01:18 PM, Santosh Shilimkar wrote: On 7/15/2011 1:03 AM, Paul Walmsley wrote: On Wed, 13 Jul 2011, Santosh Shilimkar wrote: - return arch_clkdm-clkdm_wakeup(clkdm); + ret =

Re: How to handle named resources with DT?

2011-08-12 Thread Arnd Bergmann
On Friday 12 August 2011, Felipe Balbi wrote: On Fri, Aug 12, 2011 at 01:02:18PM +1000, David Gibson wrote: the whole point of using *byname() is for the driver to not care about the order of the resources. So if driver has to provided an ordered list of names, what's the benefit ? Sounds

[PATCH] usb: musb: fix pm_runtime calls while atomic

2011-08-12 Thread Vikram Pandita
From: Vikram Pandita vikram.pand...@ti.com musb pm_runtime_get_sync call happens in intrrupt context on cable attach case That can result in re-enabling the interrupts and cause side affects. So move the code to a work queue. Following is the error path hit on cable attach: BUG: sleeping

Re: How to handle named resources with DT?

2011-08-12 Thread Arnd Bergmann
On Friday 12 August 2011, Cousson, Benoit wrote: Arnd Bergmann: But I really don't think there is value in using IORESOURCE_DMA for this. We don't have the code to manage DMA resources for more than one DMA controller AFAICT, and I think we should not add it. Globally unique interrupt

Re: [PATCH] usb: musb: use put_sync_suspend instead of put_sync

2011-08-12 Thread Pandita, Vikram
On Fri, Aug 12, 2011 at 6:55 AM, Pandita, Vikram vikram.pand...@ti.com wrote: On Fri, Aug 12, 2011 at 2:01 AM, Felipe Balbi ba...@ti.com wrote: Hi, (sorry for top-posting) Moiz, are we going to have another set of this ? The problem was with pm_runtime() functions getting called from

Re: How to handle named resources with DT?

2011-08-12 Thread Cousson, Benoit
On 8/12/2011 4:35 PM, Arnd Bergmann wrote: On Friday 12 August 2011, Felipe Balbi wrote: On Fri, Aug 12, 2011 at 01:02:18PM +1000, David Gibson wrote: the whole point of using *byname() is for the driver to not care about the order of the resources. So if driver has to provided an ordered list

Re: [PATCH] OMAP4: MMC: fix power and audio issue, decouple USBC1 from MMC1

2011-08-12 Thread Buckley, Bryan
On Fri, Jul 22, 2011 at 7:30 AM, Kishore Kadiyala kishorek.kadiy...@gmail.com wrote: On Fri, Jul 22, 2011 at 12:59 AM, Bryan Buckley bryan.buck...@ti.com wrote: Remove OMAP4_USBC1_ICUSB_PWRDNZ_MASK during enable/disable PWRDNZ mode for MMC1_PBIAS and associated extended-drain MMC1 I/O cell.

[PATCHv2 0/4] Omap-related warnings compiling current mainline 3.1-rc tree

2011-08-12 Thread Bjarne Steinsbo
V2: - Add missing sob. - Warnings verified to be present in 3.1-rc1 also. --- Compiling the current mainline tree (commit 288d5abec8314ae50fe6692f324b0444acae8486) produces some omap-related warnings. Most of them are harmless, and they are simple enough to fix that even I can do it. I hope..

[PATCHv2 1/4] OMAP4: clockdata: Make compiler shut up about possible uninitialized variable

2011-08-12 Thread Bjarne Steinsbo
Stop `warning: 'cpu_clkflg' may be used uninitialized in this function' from compiler. Signed-off-by: Bjarne Steinsbo bstein...@gmail.com --- V2: Oops.. Add missing sob. arch/arm/mach-omap2/clock44xx_data.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCHv2 2/4] OMAP4: Keyboard: Fix section mismatch in the board file

2011-08-12 Thread Bjarne Steinsbo
`keypad_pads' is referred to by `keypad_data' which is not __initdata, so `keypad_pads' should not be __initdata either. Signed-off-by: Bjarne Steinsbo bstein...@gmail.com --- V2: Oops.. Add missing sob. arch/arm/mach-omap2/board-4430sdp.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCHv2 3/4] usb: musb: OMAP4430: Remove incorrect call to omap4430_phy_init()

2011-08-12 Thread Bjarne Steinsbo
Don't call omap4430_phy_init(dev) before dev is initialized. The real omap4430_phy_init(dev) call is done at the end of this function. Signed-off-by: Bjarne Steinsbo bstein...@gmail.com --- V2: Oops.. Add missing sob. arch/arm/mach-omap2/usb-musb.c |3 --- 1 files changed, 0 insertions(+),

Re: [PATCH 4/4] usb: musb: OMAP: Delete unused function

2011-08-12 Thread Bjarne Steinsbo
Not in use anymore. Signed-off-by: Bjarne Steinsbo bstein...@gmail.com --- V2: Oops.. Add missing sob. arch/arm/mach-omap2/usb-musb.c | 38 -- 1 files changed, 0 insertions(+), 38 deletions(-) diff --git a/arch/arm/mach-omap2/usb-musb.c

Re: [PATCH] usb: musb: fix pm_runtime calls while atomic

2011-08-12 Thread Alan Stern
On Fri, 12 Aug 2011, Vikram Pandita wrote: From: Vikram Pandita vikram.pand...@ti.com musb pm_runtime_get_sync call happens in intrrupt context on cable attach case That can result in re-enabling the interrupts and cause side affects. So move the code to a work queue. Instead of creating

Re: [PATCH] OMAP: iommu flush page table entries from L1 and L2 cache

2011-08-12 Thread Gupta, Ramesh
On Thu, Aug 11, 2011 at 5:29 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Aug 11, 2011 at 02:28:39PM -0500, Gupta, Ramesh wrote: Hi Russel, grr. Sorry, typo. On Thu, Apr 28, 2011 at 11:48 AM, Gupta, Ramesh grgu...@ti.com wrote: Hi Russel, On Thu, Apr 28, 2011 at

Re: [PATCH] usb: musb: fix pm_runtime calls while atomic

2011-08-12 Thread Pandita, Vikram
On Fri, Aug 12, 2011 at 8:50 AM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 12 Aug 2011, Vikram Pandita wrote: From: Vikram Pandita vikram.pand...@ti.com musb pm_runtime_get_sync call happens in intrrupt context on cable attach case That can result in re-enabling the interrupts

Re: [PATCH] usb: musb: use put_sync_suspend instead of put_sync

2011-08-12 Thread Sonasath, Moiz
Felipe, On Fri, Aug 12, 2011 at 9:40 AM, Pandita, Vikram vikram.pand...@ti.com wrote: On Fri, Aug 12, 2011 at 6:55 AM, Pandita, Vikram vikram.pand...@ti.com wrote: On Fri, Aug 12, 2011 at 2:01 AM, Felipe Balbi ba...@ti.com wrote: Hi, (sorry for top-posting) Moiz, are we going to

Re: [PATCH] usb: musb: fix pm_runtime calls while atomic

2011-08-12 Thread Alan Stern
On Fri, 12 Aug 2011, Pandita, Vikram wrote: On Fri, Aug 12, 2011 at 8:50 AM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 12 Aug 2011, Vikram Pandita wrote: From: Vikram Pandita vikram.pand...@ti.com musb pm_runtime_get_sync call happens in intrrupt context on cable attach

Re: How to handle named resources with DT?

2011-08-12 Thread Grant Likely
On Fri, Aug 12, 2011 at 9:09 AM, Cousson, Benoit b-cous...@ti.com wrote: On 8/12/2011 4:35 PM, Arnd Bergmann wrote: It only make sense for drivers that support both device tree probing and legacy probing of static platform devices. Note how almost all drivers use only platform_get_resource

Re: [PATCH] usb: musb: fix pm_runtime calls while atomic

2011-08-12 Thread Pandita, Vikram
On Fri, Aug 12, 2011 at 10:04 AM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 12 Aug 2011, Pandita, Vikram wrote: On Fri, Aug 12, 2011 at 8:50 AM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 12 Aug 2011, Vikram Pandita wrote: From: Vikram Pandita

Re: [PATCH 5/5 v4] mfd: omap: usb: Runtime PM support

2011-08-12 Thread Todd Poynor
On Fri, Aug 12, 2011 at 12:20:21PM +0530, Munegowda, Keshava wrote: On Wed, Aug 10, 2011 at 10:01 PM, Todd Poynor toddpoy...@google.com wrote: @@ -913,12 +598,15 @@ static int usbhs_enable(struct device *dev)                               (pdata-ehci_data-reset_gpio_port[1], 1);       }

Re: [PATCH v4 00/15] PM QoS: add a per-device latency constraints class

2011-08-12 Thread Rafael J. Wysocki
Hi, On Friday, August 12, 2011, Jean Pihet wrote: Hi Rafael, 2011/8/12 Rafael J. Wysocki r...@sisk.pl: On Thursday, August 11, 2011, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com This patch set is in an RFC state, for review and comments. ... Questions:

Re: [PATCH 5/5 v4] mfd: omap: usb: Runtime PM support

2011-08-12 Thread Menon, Nishanth
On Fri, Aug 12, 2011 at 16:30, Todd Poynor toddpoy...@google.com wrote: On Fri, Aug 12, 2011 at 12:20:21PM +0530, Munegowda, Keshava wrote: On Wed, Aug 10, 2011 at 10:01 PM, Todd Poynor toddpoy...@google.com wrote: @@ -913,12 +598,15 @@ static int usbhs_enable(struct device *dev)            

Re: [PATCH] rtc: twl: Fix registration vs. init order

2011-08-12 Thread John Stultz
On Wed, 2011-08-10 at 20:20 -0700, Todd Poynor wrote: Only register as an RTC device after the hardware has been successfully initialized. The RTC class driver will call back to this driver to read a pending alarm, and other drivers watching for new devices on the RTC class may read the RTC

Re: [PATCH 01/15] PM QoS: move and rename the implementation files

2011-08-12 Thread mark gross
On Thu, Aug 11, 2011 at 05:06:38PM +0200, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com The PM QoS implementation files are better named kernel/power/qos.c and include/linux/pm_qos.h. The PM QoS support is compiled under the CONFIG_PM option. Signed-off-by: Jean Pihet

Re: [PATCH 02/15] PM QoS: minor clean-ups

2011-08-12 Thread mark gross
On Thu, Aug 11, 2011 at 05:06:39PM +0200, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com - Misc fixes to improve code readability: . rename struct pm_qos_request_list to struct pm_qos_request, . rename pm_qos_req parameter to req in internal code, consistenly use req

Re: [PATCH 03/15] PM QoS: code re-organization

2011-08-12 Thread mark gross
On Thu, Aug 11, 2011 at 05:06:40PM +0200, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com Move around the PM QoS misc devices management code for better readability. Signed-off-by: Jean Pihet j-pi...@ti.com --- kernel/power/qos.c | 45

Re: [PATCH 04/15] PM QoS: re-organize data structs

2011-08-12 Thread mark gross
On Thu, Aug 11, 2011 at 05:06:41PM +0200, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com In preparation for the per-device constratins support, re-organize the data strctures: - add a struct pm_qos_constraints which contains the constraints related data - update struct

Re: [PATCH 05/15] PM QoS: generalize and export the constraints management code

2011-08-12 Thread mark gross
On Thu, Aug 11, 2011 at 05:06:42PM +0200, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com In preparation for the per-device constratins support: - rename update_target to pm_qos_update_target - generalize and export pm_qos_update_target for usage by the upcoming per-device

Re: [PATCH 06/15] PM QoS: implement the per-device PM QoS constraints

2011-08-12 Thread mark gross
On Thu, Aug 11, 2011 at 05:06:43PM +0200, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com Implement the per-device PM QoS constraints by creating a device PM QoS API, which calls the PM QoS constraints management core code. The per-device latency constraints data strctures