Re: [PATCH 0/3] OMAP2+: UART: Enable tx wakeup + remove cpu checks

2012-03-22 Thread Raja, Govindraj
On Wed, Mar 21, 2012 at 7:58 PM, Kevin Hilman khil...@ti.com wrote: Govindraj.R govindraj.r...@ti.com writes: From: Govindraj.R govindraj.r...@ti.com Based on Linux-OMAP tree uart branch. (git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git remotes/origin/uart) * Removes

Re: [PATCH 08/13] Add dummy smsc911x regulators to ldp.

2012-03-22 Thread Koen Kooi
Op 22 mrt. 2012, om 06:19 heeft Russ Dill het volgende geschreven: Signed-off-by: Russ Dill russ.d...@ti.com --- arch/arm/mach-omap2/board-ldp.c |7 +++ arch/arm/mach-omap2/board-omap3evm.c |9 + Is that evm hunk intentional? regards, Koen 2 files changed, 16

Re: [PATCH 09/13] Add dummy smsc911x regulators to omap3evm.

2012-03-22 Thread Koen Kooi
Op 22 mrt. 2012, om 06:19 heeft Russ Dill het volgende geschreven: Signed-off-by: Russ Dill russ.d...@ti.com --- arch/arm/mach-omap2/board-omap3evm.c | 15 ++- 1 files changed, 6 insertions(+), 9 deletions(-) diff --git a/arch/arm/mach-omap2/board-omap3evm.c

Re: [PATCH 09/13] Add dummy smsc911x regulators to omap3evm.

2012-03-22 Thread Russ Dill
On Thu, Mar 22, 2012 at 12:07 AM, Koen Kooi k...@dominion.thruhere.net wrote: Op 22 mrt. 2012, om 06:19 heeft Russ Dill het volgende geschreven: Signed-off-by: Russ Dill russ.d...@ti.com --- arch/arm/mach-omap2/board-omap3evm.c |   15 ++- 1 files changed, 6 insertions(+), 9

[PATCH RFC] usb: musb: omap: fix the error check for pm_runtime_get_sync

2012-03-22 Thread Shubhrajyoti D
pm_runtime_get_sync returns a signed integer.In case of errors it returns a negative value.This patch fixes the error check by making it signed instead of unsigned thus preventing register access if get_sync_fails. Also passes the error cause to the debug message. Cc: Kishon Vijay Abraham I

Re: [PATCH v4 RESEND 0/7] gpio/omap: Some more driver fixes

2012-03-22 Thread Grant Likely
On Tue, 20 Mar 2012 10:46:57 -0700, Kevin Hilman khil...@ti.com wrote: Hi Grant, Grant Likely grant.lik...@secretlab.ca writes: On Tue, 20 Mar 2012 16:23:12 +0530, Tarun Kanti DebBarma tarun.ka...@ti.com wrote: This series excludes the cleanup patches as suggested by Kevin from the

[PATCH RESEND] usb: musb: omap: fix crash when musb glue (omap) gets initialized

2012-03-22 Thread Kishon Vijay Abraham I
Upstream Commit: 7acc6197b76edd0b932a7cbcc6cfad0a8a87f026 Upstream Kernel Tag: v2.6.38-rc5-94-g7acc619 pm_runtime_enable is being called after omap2430_musb_init. Hence pm_runtime_get_sync in omap2430_musb_init does not have any effect (does not enable clocks) resulting in a crash during register

Re: [PATCH 04/13] Remove non-existent parameter from fixed-helper.c kernel doc.

2012-03-22 Thread Mark Brown
On Wed, Mar 21, 2012 at 10:19:45PM -0700, Russ Dill wrote: Signed-off-by: Russ Dill russ.d...@ti.com I'll apply this once -rc1 comes out, it's totally orthogonal to the rest of the series. signature.asc Description: Digital signature

Re: [PATCH 13/13] Add dummy smsc911x regulators to zoom-debugboard.

2012-03-22 Thread Mark Brown
On Wed, Mar 21, 2012 at 10:19:54PM -0700, Russ Dill wrote: +static struct regulator_consumer_supply dummy_supplies[] = { + REGULATOR_SUPPLY(vddvario, smsc911x.0), + REGULATOR_SUPPLY(vdd33a, smsc911x.0), Why do none of these boards use -1 as the ID for the device? signature.asc

Suspend broken on 3.3?

2012-03-22 Thread Joe Woodward
Is system suspend broken on stock 3.3? I have a working stock 3.2 (with patches to fix runtime_pm for DSS2), and system suspend works just fine! This is running on a variety of GUMSTIX boards (both OMAP3530 and AM3703-based). I've just updated to stock 3.3 and suspend returns immediately when

Re: [PATCH RFC] usb: musb: omap: fix the error check for pm_runtime_get_sync

2012-03-22 Thread Sergei Shtylyov
Hello. On 22-03-2012 11:18, Shubhrajyoti D wrote: pm_runtime_get_sync returns a signed integer.In case of errors it returns a negative value.This patch fixes the error check by making it signed instead of unsigned thus preventing register access if get_sync_fails. Also passes the error cause

Re: [PATCH RFC] usb: musb: omap: fix the error check for pm_runtime_get_sync

2012-03-22 Thread Felipe Balbi
On Thu, Mar 22, 2012 at 04:42:21PM +0400, Sergei Shtylyov wrote: Hello. On 22-03-2012 11:18, Shubhrajyoti D wrote: pm_runtime_get_sync returns a signed integer.In case of errors it returns a negative value.This patch fixes the error check by making it signed instead of unsigned thus

RE: Occasional crashes in suspend-resume with MMC transactions

2012-03-22 Thread Bedia, Vaibhav
On Thu, Mar 22, 2012 at 09:53:23, Bedia, Vaibhav wrote: Hi, I am trying to do suspend-resume test with a file copy on MMC/SD going on in the background. The test involves simply copying a 450MB file on an ext3 partition to the same partition under a different name. This is on an AM335x

[PATCH RFC v2] usb: musb: omap: fix the error check for pm_runtime_get_sync

2012-03-22 Thread Shubhrajyoti D
pm_runtime_get_sync returns a signed integer.In case of errors it returns a negative value.This patch fixes the error check by making it signed instead of unsigned thus preventing register access if get_sync_fails. Also passes the error cause to the debug message. Cc : Kishon Vijay Abraham I

Re: [PATCH RFC] usb: musb: omap: fix the error check for pm_runtime_get_sync

2012-03-22 Thread Shubhrajyoti
You haven't run it thru scripts/checkpatch.pl either, I guess? Actually modified the patch a little afterwards. drivers/usb/musb/omap2430.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index

Re: Occasional crashes in suspend-resume with MMC transactions

2012-03-22 Thread S, Venkatraman
On Thu, Mar 22, 2012 at 6:50 PM, Bedia, Vaibhav vaibhav.be...@ti.com wrote: On Thu, Mar 22, 2012 at 09:53:23, Bedia, Vaibhav wrote: Hi, I am trying to do suspend-resume test with a file copy on MMC/SD going on in the background. The test involves simply copying a 450MB file on an ext3

Re: [PATCH RESEND] usb: musb: omap: fix crash when musb glue (omap) gets initialized

2012-03-22 Thread Greg KH
On Thu, Mar 22, 2012 at 04:05:45PM +0530, Kishon Vijay Abraham I wrote: Upstream Commit: 7acc6197b76edd0b932a7cbcc6cfad0a8a87f026 Upstream Kernel Tag: v2.6.38-rc5-94-g7acc619 snip formletter This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read

RE: Occasional crashes in suspend-resume with MMC transactions

2012-03-22 Thread Bedia, Vaibhav
On Thu, Mar 22, 2012 at 19:57:16, S, Venkatraman wrote: [...] I see (in 3.3) that the host controller driver does a return ret and that means the errors is propagated. Where is the return code lost /overridden ? The return code gets overridden due to the call to host-pdata-resume() which

Re: [GIT PULL] OMAP DSS for v3.4

2012-03-22 Thread Florian Tobias Schandinat
Arnd, On 03/19/2012 04:24 PM, Arnd Bergmann wrote: I've looked at the specific conflicts again, and it seems that the only conflicting commit in arm-soc is 2e3ee9f45b ARM: OMAP1: Move most of plat/io.h into local iomap.h. I'm planning to send that one very early, as soon as Russell has his

Re: [GIT PULL] OMAP DSS for v3.4

2012-03-22 Thread Arnd Bergmann
On Thursday 22 March 2012, Florian Tobias Schandinat wrote: On 03/19/2012 04:24 PM, Arnd Bergmann wrote: I've looked at the specific conflicts again, and it seems that the only conflicting commit in arm-soc is 2e3ee9f45b ARM: OMAP1: Move most of plat/io.h into local iomap.h. I'm planning to

Re: Occasional crashes in suspend-resume with MMC transactions

2012-03-22 Thread S, Venkatraman
On Thu, Mar 22, 2012 at 8:13 PM, Bedia, Vaibhav vaibhav.be...@ti.com wrote: On Thu, Mar 22, 2012 at 19:57:16, S, Venkatraman wrote: [...] I see (in 3.3) that the host controller driver does a return ret and that means the errors is propagated. Where is the return code lost /overridden ?

Re: [PATCH] ARM: OMAP: Add support for AM35xx UART4/ttyO3

2012-03-22 Thread Stefano Babic
On 18/10/2011 20:47, Kyle Manna wrote: Add hwmod support to enable access to UART4 of the AM35xx series of chips. The UART4 device referenced from the TRM will show up as ttyO3. This was tested on an AM3505. Signed-off-by: Kyle Manna kyle.ma...@fuel7.com --- Hi Kyle,

Re: [PATCH v4 RESEND 0/7] gpio/omap: Some more driver fixes

2012-03-22 Thread Kevin Hilman
Grant Likely grant.lik...@secretlab.ca writes: On Tue, 20 Mar 2012 10:46:57 -0700, Kevin Hilman khil...@ti.com wrote: Hi Grant, Grant Likely grant.lik...@secretlab.ca writes: On Tue, 20 Mar 2012 16:23:12 +0530, Tarun Kanti DebBarma tarun.ka...@ti.com wrote: This series excludes the

Re: [PATCH] ARM: OMAP: Add support for AM35xx UART4/ttyO3

2012-03-22 Thread Stefano Babic
On 22/03/2012 18:00, Kyle Manna wrote: My pin mux is configured in u-boot and is as follows: /* CCDC_FIELD: gpio_95, uP-TXD4 */ \ MUX_VAL(CP(CCDC_FIELD), (IDIS | PTD | DIS | M2)) \ /* CCDC_HD: gpio_96, uP-RTS4# */ \ MUX_VAL(CP(CCDC_HD),(IDIS | PTD | DIS | M2))

Re: [PATCH] ARM: OMAP: Add support for AM35xx UART4/ttyO3

2012-03-22 Thread Kyle Manna
On 03/22/2012 11:03 AM, Stefano Babic wrote: On 18/10/2011 20:47, Kyle Manna wrote: Add hwmod support to enable access to UART4 of the AM35xx series of chips. The UART4 device referenced from the TRM will show up as ttyO3. This was tested on an AM3505. Signed-off-by: Kyle

Re: Suspend broken on 3.3?

2012-03-22 Thread Kevin Hilman
Joe Woodward j...@terrafix.co.uk writes: Is system suspend broken on stock 3.3? I hope not. :) It *should* work, I'm using it regularily here, and it works for me (I'm sure that's just what you want to hear.) :) I have a working stock 3.2 (with patches to fix runtime_pm for DSS2), and

Re: [PATCH RFC v2] usb: musb: omap: fix the error check for pm_runtime_get_sync

2012-03-22 Thread Kevin Hilman
Shubhrajyoti D shubhrajy...@ti.com writes: pm_runtime_get_sync returns a signed integer.In case of errors it returns a negative value.This patch fixes the error check by making it signed instead of unsigned thus preventing register access if get_sync_fails. Also passes the error cause to the

Re: [PATCH 13/13] Add dummy smsc911x regulators to zoom-debugboard.

2012-03-22 Thread Russ Dill
On Thu, Mar 22, 2012 at 4:37 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Mar 21, 2012 at 10:19:54PM -0700, Russ Dill wrote: +static struct regulator_consumer_supply dummy_supplies[] = { +     REGULATOR_SUPPLY(vddvario, smsc911x.0), +     REGULATOR_SUPPLY(vdd33a,

Re: [PATCH 04/13] Remove non-existent parameter from fixed-helper.c kernel doc.

2012-03-22 Thread Russ Dill
On Thu, Mar 22, 2012 at 4:36 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Mar 21, 2012 at 10:19:45PM -0700, Russ Dill wrote: Signed-off-by: Russ Dill russ.d...@ti.com I'll apply this once -rc1 comes out, it's totally orthogonal to the rest of the series. I'll drop it

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

2012-03-22 Thread Kevin Hilman
Daniel Lezcano daniel.lezc...@linaro.org writes: On 03/21/2012 10:54 PM, Kevin Hilman wrote: Daniel Lezcanodaniel.lezc...@linaro.org writes: On 03/21/2012 02:43 PM, Jean Pihet wrote: On Wed, Mar 21, 2012 at 11:07 AM, Santosh Shilimkar santosh.shilim...@ti.com wrote: Daniel, On

[GIT PULL] gpio/omap: more fixes for v3.4

2012-03-22 Thread Kevin Hilman
Hi Grant, Please pull these OMAP GPIO fixes for v3.4. These fix some rather serious regressions introduced by the cleanup and runtime PM conversion series which is also queued for v3.4. This branch is based on your gpio/next branch. This version is functionally the same as the version you

Re: [PATCH RESEND] usb: musb: omap: fix crash when musb glue (omap) gets initialized

2012-03-22 Thread ABRAHAM, KISHON VIJAY
Hi Greg, On Thu, Mar 22, 2012 at 8:03 PM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Mar 22, 2012 at 04:05:45PM +0530, Kishon Vijay Abraham I wrote: Upstream Commit: 7acc6197b76edd0b932a7cbcc6cfad0a8a87f026 Upstream Kernel Tag: v2.6.38-rc5-94-g7acc619 snip formletter This is not

Re: [PATCH RESEND] usb: musb: omap: fix crash when musb glue (omap) gets initialized

2012-03-22 Thread Greg KH
On Fri, Mar 23, 2012 at 03:04:04AM +0530, ABRAHAM, KISHON VIJAY wrote: Hi Greg, On Thu, Mar 22, 2012 at 8:03 PM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Mar 22, 2012 at 04:05:45PM +0530, Kishon Vijay Abraham I wrote: Upstream Commit: 7acc6197b76edd0b932a7cbcc6cfad0a8a87f026

Re: [PATCH RESEND] usb: musb: omap: fix crash when musb glue (omap) gets initialized

2012-03-22 Thread Greg KH
On Fri, Mar 23, 2012 at 03:59:32AM +0530, ABRAHAM, KISHON VIJAY wrote: Hi Greg, On Fri, Mar 23, 2012 at 3:09 AM, Greg KH gre...@linuxfoundation.org wrote: On Fri, Mar 23, 2012 at 03:04:04AM +0530, ABRAHAM, KISHON VIJAY wrote: Hi Greg, On Thu, Mar 22, 2012 at 8:03 PM, Greg KH

Re: [PATCH RESEND] usb: musb: omap: fix crash when musb glue (omap) gets initialized

2012-03-22 Thread ABRAHAM, KISHON VIJAY
Hi Greg, On Fri, Mar 23, 2012 at 3:09 AM, Greg KH gre...@linuxfoundation.org wrote: On Fri, Mar 23, 2012 at 03:04:04AM +0530, ABRAHAM, KISHON VIJAY wrote: Hi Greg, On Thu, Mar 22, 2012 at 8:03 PM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Mar 22, 2012 at 04:05:45PM +0530, Kishon

Re: [PATCH v4 RESEND 6/7] gpio/omap: fix incorrect update to context.irqenable1

2012-03-22 Thread Kevin Hilman
Tarun Kanti DebBarma tarun.ka...@ti.com writes: In _enable_gpio_irqbank() when bank-regs-set_irqenable is TRUE, gpio_mask can be directly set by writing to set_irqenable register without overwriting current value. In order to ensure the same is stored in context.irqenable1, we must avoid

Re: [PATCH] ARM: OMAP3+: fix oops triggered in omap_prcm_register_chain_handler(v1)

2012-03-22 Thread Kevin Hilman
Ming Lei tom.leim...@gmail.com writes: This patch fixes the oops below[1]. Obviously, the count of struct irq_chip_generic instances to be allocated and setup should be irq_setup-nr_regs instead of irq_setup-nr_regs plus one, so just fix the iterator to avoid the oops. [...] --- v1:

Re: [PATCH 0/3] OMAP2+: UART: Enable tx wakeup + remove cpu checks

2012-03-22 Thread Paul Walmsley
Hi On Thu, 22 Mar 2012, Raja, Govindraj wrote: Sorry I for got to add that, here are details on what was tested. 1.) OMAP2430 SDP : Boot tested with uart1 as console. 2.) OMAP3430 SDP: Boot test, suspend/resume tests, retention off mode (checking retention