Re: [RFC PATCH 0/6] ARM: OMAP4+: hwmod: fixing omap4+ DSS hwmods

2014-11-14 Thread Tomi Valkeinen
Hi Paul, On 09/10/14 17:03, Tomi Valkeinen wrote: This is an RFC to fix the issues with boot time DSS hwmod setup. There was an earlier series sent by Archit here: http://www.spinics.net/lists/linux-omap/msg107700.html This series takes different approach, and just tries to fix the

Re: [RFC PATCH 2/3] mmc: omap_hsmmc: add tuning support

2014-11-14 Thread Andreas Fenkart
2014-11-13 13:56 GMT+01:00 Kishon Vijay Abraham I kis...@ti.com: From: Balaji T K balaj...@ti.com MMC tuning procedure is required to support SD card UHS1-SDR104 mode and EMMC HS200 mode. The tuning function omap_execute_tuning() will only be called by the MMC/SD core if the corresponding

[PATCH 1/2] mach-omap2: remove deprecated VIDEO_OMAP2 support

2014-11-14 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com The omap2 camera driver has been deprecated for a year and is now going to be removed. It is unmaintained and it uses an internal API that has long since been superseded by a much better API. Worse, that internal API has been abused by out-of-kernel trees

Re: [PATCH v4 8/8] net: can: c_can: Add support for TI am3352 DCAN

2014-11-14 Thread Marc Kleine-Budde
On 11/13/2014 05:06 PM, Wolfram Sang wrote: On Fri, Nov 07, 2014 at 04:49:22PM +0200, Roger Quadros wrote: AM3352 SoC has 2 DCAN modules. Add compatible id and raminit driver data for am3352 DCAN. Signed-off-by: Roger Quadros rog...@ti.com Acked-by: Wolfram Sang w...@the-dreams.de For the

Re: [PATCH 1/2] mach-omap2: remove deprecated VIDEO_OMAP2 support

2014-11-14 Thread Sakari Ailus
On Fri, Nov 14, 2014 at 10:23:13AM +0100, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com The omap2 camera driver has been deprecated for a year and is now going to be removed. It is unmaintained and it uses an internal API that has long since been superseded by a much better

Re: [alsa-devel] [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-14 Thread Jean-Francois Moine
On Thu, 13 Nov 2014 17:44:38 +0200 Tomi Valkeinen tomi.valkei...@ti.com wrote: [snip] a) Always keep the audio device operational, no matter what is the status of the video side. How should this work if the HDMI videomode or the HDMI monitor does not support audio? Is it desirable

Re: [PATCH v4 8/8] net: can: c_can: Add support for TI am3352 DCAN

2014-11-14 Thread Wolfram Sang
On Fri, Nov 14, 2014 at 10:25:55AM +0100, Marc Kleine-Budde wrote: On 11/13/2014 05:06 PM, Wolfram Sang wrote: On Fri, Nov 07, 2014 at 04:49:22PM +0200, Roger Quadros wrote: AM3352 SoC has 2 DCAN modules. Add compatible id and raminit driver data for am3352 DCAN. Signed-off-by: Roger

Re: [PATCH v5 6/8] net: can: c_can: Disable pins when CAN interface is down

2014-11-14 Thread Roger Quadros
On 11/13/2014 06:03 PM, Marc Kleine-Budde wrote: On 11/13/2014 04:23 PM, Roger Quadros wrote: DRA7 CAN IP suffers from a problem which causes it to be prevented from fully turning OFF (i.e. stuck in transition) if the module was disabled while there was traffic on the CAN_RX line. To work

Re: [PATCH v8 0/7] Enable L2 cache support on Exynos4210/4x12 SoCs

2014-11-14 Thread Marek Szyprowski
Hello, On 2014-11-13 14:18, Marek Szyprowski wrote: This is an updated patchset, which intends to add support for L2 cache on Exynos4 SoCs on boards running under secure firmware, which requires certain initialization steps to be done with help of firmware, as selected registers are writable

Re: [PATCH v7.1 11/19] OMAPDSS: hdmi: Make hdmi_mode_has_audio() more user friedly

2014-11-14 Thread Vladimir Zapolskiy
Hi Jyri, On 12.11.2014 16:41, Jyri Sarha wrote: Signed-off-by: Jyri Sarha jsa...@ti.com --- drivers/video/fbdev/omap2/dss/hdmi.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/omap2/dss/hdmi.h b/drivers/video/fbdev/omap2/dss/hdmi.h index

Re: [PATCH 4/4] arm: dts: omap3-gta04: Add static configuration for devconf1 register

2014-11-14 Thread Grazvydas Ignotas
On Fri, Nov 14, 2014 at 1:58 AM, Tony Lindgren t...@atomide.com wrote: * Paul Walmsley p...@pwsan.com [141113 15:01]: Hi On Thu, 13 Nov 2014, Tony Lindgren wrote: * Tomi Valkeinen tomi.valkei...@ti.com [141113 03:33]: On 12/11/14 17:02, Tony Lindgren wrote: And, with a quick grep,

Re: [PATCH v8 0/7] Enable L2 cache support on Exynos4210/4x12 SoCs

2014-11-14 Thread Arnd Bergmann
On Friday 14 November 2014 15:11:58 Marek Szyprowski wrote: I assume that after all comments from previous versions, no more changes are needed to this patchset and I would really like to have it queued to v3.19. Arnd, Olof: could you take this patchset thought arm-soc tree? It already

Re: [PATCH v7.1 11/19] OMAPDSS: hdmi: Make hdmi_mode_has_audio() more user friedly

2014-11-14 Thread Jyri Sarha
On 11/14/2014 04:37 PM, Vladimir Zapolskiy wrote: Hi Jyri, On 12.11.2014 16:41, Jyri Sarha wrote: Signed-off-by: Jyri Sarha jsa...@ti.com --- drivers/video/fbdev/omap2/dss/hdmi.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/omap2/dss/hdmi.h

[PATCH v5 4/8] net: can: c_can: Add syscon/regmap RAMINIT mechanism

2014-11-14 Thread Roger Quadros
Some TI SoCs like DRA7 have a RAMINIT register specification different from the other AMxx SoCs and as expected by the existing driver. To add more insanity, this register is shared with other IPs like DSS, PCIe and PWM. Provides a more generic mechanism to specify the RAMINIT register location

[PATCH v7 6/8] net: can: c_can: Disable pins when CAN interface is down

2014-11-14 Thread Roger Quadros
DRA7 CAN IP suffers from a problem which causes it to be prevented from fully turning OFF (i.e. stuck in transition) if the module was disabled while there was traffic on the CAN_RX line. To work around this issue we select the SLEEP pin state by default on probe and use the DEFAULT pin state on

Re: [PATCH v7 6/8] net: can: c_can: Disable pins when CAN interface is down

2014-11-14 Thread Marc Kleine-Budde
On 11/14/2014 04:40 PM, Roger Quadros wrote: DRA7 CAN IP suffers from a problem which causes it to be prevented from fully turning OFF (i.e. stuck in transition) if the module was disabled while there was traffic on the CAN_RX line. To work around this issue we select the SLEEP pin state by

Re: [PATCH v4 7/8] net: can: c_can: Add support for TI DRA7 DCAN

2014-11-14 Thread Marc Kleine-Budde
On 11/07/2014 03:49 PM, Roger Quadros wrote: DRA7 SoC has 2 CAN IPs. Provide compatible IDs and RAMINIT register data for both. Signed-off-by: Roger Quadros rog...@ti.com --- Documentation/devicetree/bindings/net/can/c_can.txt | 1 + drivers/net/can/c_can/c_can_platform.c |

Re: [PATCH 4/4] arm: dts: omap3-gta04: Add static configuration for devconf1 register

2014-11-14 Thread Tony Lindgren
* Grazvydas Ignotas nota...@gmail.com [141114 06:38]: On Fri, Nov 14, 2014 at 1:58 AM, Tony Lindgren t...@atomide.com wrote: * Paul Walmsley p...@pwsan.com [141113 15:01]: Hi On Thu, 13 Nov 2014, Tony Lindgren wrote: * Tomi Valkeinen tomi.valkei...@ti.com [141113 03:33]: On

Re: [PATCH v7 6/8] net: can: c_can: Disable pins when CAN interface is down

2014-11-14 Thread Roger Quadros
On 11/14/2014 05:49 PM, Marc Kleine-Budde wrote: On 11/14/2014 04:40 PM, Roger Quadros wrote: DRA7 CAN IP suffers from a problem which causes it to be prevented from fully turning OFF (i.e. stuck in transition) if the module was disabled while there was traffic on the CAN_RX line. To work

Re: [PATCH V3 3/3] mfd: palmas: Add support for optional wakeup

2014-11-14 Thread Felipe Balbi
Hi, On Thu, Nov 13, 2014 at 09:40:31AM -0800, Tony Lindgren wrote: [snip] From: Tony Lindgren t...@atomide.com Date: Tue, 11 Nov 2014 07:53:55 -0800 Subject: [PATCH] genirq: Add support for wake-up interrupts to fix irq reentry issues in drivers As pointed out by Thomas Gleixner, at

Re: [PATCH v4 06/10] ARM: dts: am4372: Add DCAN nodes

2014-11-14 Thread Roger Quadros
On 11/13/2014 07:40 PM, Tony Lindgren wrote: * Marc Kleine-Budde m...@pengutronix.de [141113 06:55]: On 11/13/2014 03:49 PM, Roger Quadros wrote: On 11/13/2014 04:44 PM, Marc Kleine-Budde wrote: On 11/13/2014 03:40 PM, Roger Quadros wrote: On 11/13/2014 04:07 PM, Marc Kleine-Budde wrote: On

Re: [PATCH v5 4/8] net: can: c_can: Add syscon/regmap RAMINIT mechanism

2014-11-14 Thread Marc Kleine-Budde
On 11/14/2014 04:37 PM, Roger Quadros wrote: Some TI SoCs like DRA7 have a RAMINIT register specification different from the other AMxx SoCs and as expected by the existing driver. To add more insanity, this register is shared with other IPs like DSS, PCIe and PWM. Provides a more

Re: [PATCH v5 4/8] net: can: c_can: Add syscon/regmap RAMINIT mechanism

2014-11-14 Thread Roger Quadros
On 11/14/2014 06:32 PM, Marc Kleine-Budde wrote: On 11/14/2014 04:37 PM, Roger Quadros wrote: Some TI SoCs like DRA7 have a RAMINIT register specification different from the other AMxx SoCs and as expected by the existing driver. To add more insanity, this register is shared with other IPs

Re: N900 modem support in 3.18-rc1

2014-11-14 Thread Sebastian Reichel
On Fri, Nov 14, 2014 at 08:37:56AM +0100, Pavel Machek wrote: I'm using nfsroot (no modules), .config is attached. Debian v7.7, ofono installed. To launch ofono, I'm using: rmdir /dev/cmt ln -s /sys/bus/hsi/devices/n900-modem/ /dev/cmt At least with Debian as base you can add this to

Re: [PATCH v9] ARM: omap: edma: add suspend resume hook

2014-11-14 Thread Sekhar Nori
On Tuesday 26 August 2014 02:22 PM, Daniel Mack wrote: This patch makes the edma driver resume correctly after suspend. Tested on an AM33xx platform with cyclic audio streams and omap_hsmmc. All information can be reconstructed by already known runtime information. As we now use some

Re: [PATCH v9] ARM: omap: edma: add suspend resume hook

2014-11-14 Thread Daniel Mack
Hi Sekhar, On 11/14/2014 06:03 PM, Sekhar Nori wrote: I think I have asked this before, and I am still not sure why this call to pm_runtime_get_sync() is needed here. From my testing today, this does seem to be a a no-op and this call returns from rpm_resume() because of this check:

Re: [PATCH V3 3/3] mfd: palmas: Add support for optional wakeup

2014-11-14 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [141114 08:20]: On Thu, Nov 13, 2014 at 09:40:31AM -0800, Tony Lindgren wrote: +/** + * handle_wakeirq_thread - call device runtime pm calls on wake-up interrupt + * @wakeirq: device specific wake-up interrupt + * @dev_id: struct device entry + */

Re: [PATCHv6 4/5] hwspinlock/core: add common OF helpers

2014-11-14 Thread Suman Anna
Hi Ohad, On 11/14/2014 01:11 AM, Ohad Ben-Cohen wrote: Hi Suman, On Thu, Nov 13, 2014 at 11:02 PM, Suman Anna s-a...@ti.com wrote: OK, lets take an example. I have say 2 device instances, say hwlock1: hwlock@0 { hwlock-num-locks = 32 hwlock-base-id

Re: N900 modem support in 3.18-rc1

2014-11-14 Thread Sebastian Reichel
Hi, On Fri, Nov 14, 2014 at 09:04:23AM +0200, Ivaylo Dimitrov wrote: [...] https://gitorious.org/linux-n900/freemangordons-linux-n900/commits/30e9a5c498a89cea4c29523f69e436bf0af3c631 commits 89ce13b, b81d80d, ec4d0dc, 91256e2 and 8022a6d - e29f558 (no idea why gitorious shows those mixed

Re: [PATCH V3 3/3] mfd: palmas: Add support for optional wakeup

2014-11-14 Thread Felipe Balbi
On Fri, Nov 14, 2014 at 09:08:17AM -0800, Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [141114 08:20]: On Thu, Nov 13, 2014 at 09:40:31AM -0800, Tony Lindgren wrote: +/** + * handle_wakeirq_thread - call device runtime pm calls on wake-up interrupt + * @wakeirq:

Re: N900 modem support in 3.18-rc1

2014-11-14 Thread Pali Rohár
On Friday 14 November 2014 18:20:09 Sebastian Reichel wrote: Hi, On Fri, Nov 14, 2014 at 09:04:23AM +0200, Ivaylo Dimitrov wrote: [...] https://gitorious.org/linux-n900/freemangordons-linux-n900/c ommits/30e9a5c498a89cea4c29523f69e436bf0af3c631 commits 89ce13b, b81d80d, ec4d0dc,

Re: [RFC PATCH 2/3] mmc: omap_hsmmc: add tuning support

2014-11-14 Thread Felipe Balbi
Hi, On Thu, Nov 13, 2014 at 06:26:18PM +0530, Kishon Vijay Abraham I wrote: @@ -233,6 +263,48 @@ struct omap_mmc_of_data { u8 controller_flags; }; +static const u32 ref_tuning_4bits[] = { + 0x00FF0FFF, 0xCCC3CCFF, 0xFFCC3CC3, 0xEFFEFFFE, + 0xDDFFDFFF, 0xFBFFFBFF,

Re: [PATCH v4 3/8] net: can: c_can: Add RAMINIT register information to driver data

2014-11-14 Thread Marc Kleine-Budde
On 11/07/2014 03:49 PM, Roger Quadros wrote: Some platforms (e.g. TI) need special RAMINIT register handling. Provide a way to store RAMINIT register description in driver data. Signed-off-by: Roger Quadros rog...@ti.com --- drivers/net/can/c_can/c_can.h | 6 ++

Re: [PATCH 4/4] arm: dts: omap3-gta04: Add static configuration for devconf1 register

2014-11-14 Thread Tony Lindgren
* Tero Kristo t-kri...@ti.com [141113 23:33]: On 11/14/2014 01:58 AM, Tony Lindgren wrote: The PRCM/clock cleanups that I have under work basically splits the clock inits under their respective IP blocks; currently everything is registered under generic PRCM. System control module will be

Re: [RFC PATCH 2/3] mmc: omap_hsmmc: add tuning support

2014-11-14 Thread Russell King - ARM Linux
On Fri, Nov 14, 2014 at 11:41:52AM -0600, Felipe Balbi wrote: Hi, On Thu, Nov 13, 2014 at 06:26:18PM +0530, Kishon Vijay Abraham I wrote: @@ -233,6 +263,48 @@ struct omap_mmc_of_data { u8 controller_flags; }; +static const u32 ref_tuning_4bits[] = { + 0x00FF0FFF,

Re: [PATCH v4 06/10] ARM: dts: am4372: Add DCAN nodes

2014-11-14 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [141114 08:24]: On 11/13/2014 07:40 PM, Tony Lindgren wrote: * Marc Kleine-Budde m...@pengutronix.de [141113 06:55]: On 11/13/2014 03:49 PM, Roger Quadros wrote: On 11/13/2014 04:44 PM, Marc Kleine-Budde wrote: On 11/13/2014 03:40 PM, Roger Quadros wrote:

[PATCH v8 0/8] can: c_can: Use syscon regmap for TI specific RAMINIT register

2014-11-14 Thread Marc Kleine-Budde
Picking up Roger's work: Changes since v7: - combined raminit start and done bit into a struct (3/8, 7/8, 8/8) - constified struct c_can_driver_data (2/8, 7/8, 8/8) - silenced compiler warning in c_can_hw_raminit_{wait,}_syscon (4/8) - use platform_get_device_id in probe() instead of open coding

[PATCH v8 1/8] can: c_can: Add timeout to c_can_hw_raminit_ti()

2014-11-14 Thread Marc Kleine-Budde
From: Roger Quadros rog...@ti.com TI's RAMINIT DONE mechanism is buggy on AM43xx SoC and may not always be set after the START bit is set. Although it seems to work fine even in that case. So add a timeout mechanism to c_can_hw_raminit_wait_ti(). Don't bail out in that failure case but just print

[PATCH v8 5/8] can: c_can: Add support for START pulse in RAMINIT sequence

2014-11-14 Thread Marc Kleine-Budde
From: Roger Quadros rog...@ti.com Some SoCs e.g. (TI DRA7xx) need a START pulse to start the RAMINIT sequence i.e. START bit must be set and cleared before checking for the DONE bit status. Signed-off-by: Roger Quadros rog...@ti.com Signed-off-by: Marc Kleine-Budde m...@pengutronix.de ---

[PATCH v8 8/8] can: c_can: Add support for TI am3352 DCAN

2014-11-14 Thread Marc Kleine-Budde
From: Roger Quadros rog...@ti.com AM3352 SoC has 2 DCAN modules. Add compatible id and raminit driver data for am3352 DCAN. Signed-off-by: Roger Quadros rog...@ti.com Acked-by: Wolfram Sang w...@the-dreams.de Signed-off-by: Marc Kleine-Budde m...@pengutronix.de ---

[PATCH v8 2/8] can: c_can: Introduce c_can_driver_data structure

2014-11-14 Thread Marc Kleine-Budde
From: Roger Quadros rog...@ti.com We want to have more data than just can_dev_id to be present in the driver data e.g. TI platforms need RAMINIT register description. Introduce the c_can_driver_data structure and move the can_dev_id into it. Tidy up the way it is used on probe(). Signed-off-by:

[PATCH v8 4/8] can: c_can: Add syscon/regmap RAMINIT mechanism

2014-11-14 Thread Marc Kleine-Budde
From: Roger Quadros rog...@ti.com Some TI SoCs like DRA7 have a RAMINIT register specification different from the other AMxx SoCs and as expected by the existing driver. To add more insanity, this register is shared with other IPs like DSS, PCIe and PWM. Provides a more generic mechanism to

[PATCH v8 6/8] can: c_can: Disable pins when CAN interface is down

2014-11-14 Thread Marc Kleine-Budde
From: Roger Quadros rog...@ti.com DRA7 CAN IP suffers from a problem which causes it to be prevented from fully turning OFF (i.e. stuck in transition) if the module was disabled while there was traffic on the CAN_RX line. To work around this issue we select the SLEEP pin state by default on

[PATCH v8 3/8] can: c_can: Add RAMINIT register information to driver data

2014-11-14 Thread Marc Kleine-Budde
From: Roger Quadros rog...@ti.com Some platforms (e.g. TI) need special RAMINIT register handling. Provide a way to store RAMINIT register description in driver data. Signed-off-by: Roger Quadros rog...@ti.com Signed-off-by: Marc Kleine-Budde m...@pengutronix.de ---

[PATCH v8 7/8] can: c_can: Add support for TI DRA7 DCAN

2014-11-14 Thread Marc Kleine-Budde
From: Roger Quadros rog...@ti.com DRA7 SoC has 2 CAN IPs. Provide compatible IDs and RAMINIT register data for both. Signed-off-by: Roger Quadros rog...@ti.com Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- Documentation/devicetree/bindings/net/can/c_can.txt | 1 +

Re: [PATCH v4 4/6] ARM: dts: AM335x: Make charge delay a DT parameter for TSC

2014-11-14 Thread Tony Lindgren
* Vignesh R vigne...@ti.com [141113 21:42]: The charge delay value is by default 0x400. But it can be set to lower values on some boards, as long as false pen-ups are avoided. Lowering the value increases the sampling rate (though current sampling rate is sufficient for TSC operation). In some

Re: [PATCH] ARM: dts: dra7: fix DSS PLL clock mux registers

2014-11-14 Thread Tony Lindgren
* Tero Kristo t-kri...@ti.com [141112 22:11]: On 11/12/2014 05:25 PM, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [141112 07:26]: * Tomi Valkeinen tomi.valkei...@ti.com [141013 01:52]: The clock nodes for DSS VIDEO1/2 and HDMI have wrong register addresses. This patch fixes the

Re: [PATCH 1/2] mach-omap2: remove deprecated VIDEO_OMAP2 support

2014-11-14 Thread Tony Lindgren
* Hans Verkuil hverk...@xs4all.nl [141114 01:25]: From: Hans Verkuil hans.verk...@cisco.com The omap2 camera driver has been deprecated for a year and is now going to be removed. It is unmaintained and it uses an internal API that has long since been superseded by a much better API. Worse,

Re: [GIT PULL] ARM: OMAP2+: some clock/hwmod patches for v3.19

2014-11-14 Thread Tony Lindgren
* Paul Walmsley p...@pwsan.com [141113 14:52]: The following changes since commit f114040e3ea6e07372334ade75d1ee0775c355e1: Linux 3.18-rc1 (2014-10-19 18:08:38 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/pjw/omap-pending.git

Re: [PATCH v2 0/3] Add support for ADC on am437x-gp and am43x-epos-evm

2014-11-14 Thread Tony Lindgren
* Vignesh R vigne...@ti.com [141113 20:09]: On Tuesday 04 November 2014 04:45 PM, Vignesh R wrote: This series of patches enable ADC on am437x-gp-evm and am43x-epos-evm. The ADC clock hwmod data of am33xx has been moved to commom place so that both am43xx and am33xx can reuse them.

Re: N900 modem support in 3.18-rc1

2014-11-14 Thread Ivaylo Dimitrov
On 14.11.2014 19:20, Sebastian Reichel wrote: The patch looks ok. It does not cleanup the cmt-speech driver for mainline usage, but it should work. Before adding this driver to the mainline kernel there should be open source userspace support anyway. I am aware of that(patch not ready),

Re: [PATCHv6 4/5] hwspinlock/core: add common OF helpers

2014-11-14 Thread Ohad Ben-Cohen
On Fri, Nov 14, 2014 at 7:09 PM, Suman Anna s-a...@ti.com wrote: It seems to me that hwspin_lock_request_specific failures should be used by clients to defer their probing. Why wouldn't such a simple solution work? Because the API always returns NULL on failures and there is no way for the

[GIT PULL 2/2] omap driver changes for v3.19

2014-11-14 Thread Tony Lindgren
The following changes since commit cac7f2429872d3733dc3f9915857b1691da2eb2f: Linux 3.18-rc2 (2014-10-26 16:48:41 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap tags/omap-for-v3.19/w1-and-l3-noc for you to fetch changes up to

[GIT PULL 1/2] omap soc changes for v3.19

2014-11-14 Thread Tony Lindgren
The following changes since commit cac7f2429872d3733dc3f9915857b1691da2eb2f: Linux 3.18-rc2 (2014-10-26 16:48:41 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap tags/omap-for-v3.19/clocks-and-pm for you to fetch changes up to

Re: N900 modem support in 3.18-rc1

2014-11-14 Thread Pavel Machek
Hi! On Fri 2014-11-14 21:54:42, Ivaylo Dimitrov wrote: On 14.11.2014 19:20, Sebastian Reichel wrote: The patch looks ok. It does not cleanup the cmt-speech driver for mainline usage, but it should work. Before adding this driver to the mainline kernel there should be open source userspace

Re: N900 modem support in 3.18-rc1

2014-11-14 Thread Sebastian Reichel
Hi, On Fri, Nov 14, 2014 at 09:54:42PM +0200, Ivaylo Dimitrov wrote: On 14.11.2014 19:20, Sebastian Reichel wrote: The patch looks ok. It does not cleanup the cmt-speech driver for mainline usage, but it should work. Before adding this driver to the mainline kernel there should be open source

Re: N900 modem support in 3.18-rc1

2014-11-14 Thread Sebastian Reichel
Hi, On Fri, Nov 14, 2014 at 06:34:18PM +0100, Pali Rohár wrote: Anyway what is /dev/cmt_speech doing? If it exports gsm voice call data, [...] Right. [...] should not it have alsa snd interface? Sounds also like a promising standardized kernel interface. I wonder why a custom interface has

Re: [PATCH 2/2] ARM: dts: Add devicetree for NovaTech OrionLXm

2014-11-14 Thread George McCollister
Felipe, Thank you for your reply. + vbat: fixedregulator@0 { + compatible = regulator-fixed; + regulator-name = vbat; + regulator-min-microvolt = 500; + regulator-max-microvolt = 500; + regulator-boot-on; + }; I

i2c: omap: fix NACK and Arbitration Lost irq handling

2014-11-14 Thread Alexander Kochetkov
commit 1d7afc95946487945cc7f5019b41255b72224b70 (i2c: omap: ack IRQ in parts) changed the interrupt handler to complete transfers without clearing XRDY (AL case) and ARDY (NACK case) flags. XRDY or ARDY interrupt will be fired again (in parallel with omap_i2c_xfer_msg). Interrupt handler will

i2c: omap: fix Too much work in one IRQ irq handling

2014-11-14 Thread Alexander Kochetkov
commit 66b9298878742f08cb6e79b7c7d5632d782fd1e1 (i2c: omap: switch over to do {} while loop) changed the interrupt handler to abort transfers in case interrupt serviced 100 times but commit's comment states that No functional changes otherwise.. Also, original commit could report status 0 (no

[PATCH 1/2] i2c: omap: fix NACK and Arbitration Lost irq handling

2014-11-14 Thread Alexander Kochetkov
commit 1d7afc95946487945cc7f5019b41255b72224b70 (i2c: omap: ack IRQ in parts) changed the interrupt handler to complete transfers without clearing XRDY (AL case) and ARDY (NACK case) flags. XRDY or ARDY interrupt will be fired again (in parallel with omap_i2c_xfer_msg). Interrupt handler will

[PATCH 2/2] i2c: omap: fix Too much work in one IRQ irq handling

2014-11-14 Thread Alexander Kochetkov
commit 66b9298878742f08cb6e79b7c7d5632d782fd1e1 (i2c: omap: switch over to do {} while loop) changed the interrupt handler to abort transfers in case interrupt serviced 100 times but commit's comment states that No functional changes otherwise.. Also, original commit could report status 0 (no

Re: [PATCH 2/2] ARM: dts: Add devicetree for NovaTech OrionLXm

2014-11-14 Thread Felipe Balbi
Hi, On Fri, Nov 14, 2014 at 04:47:02PM -0600, George McCollister wrote: Felipe, Thank you for your reply. no problem + vbat: fixedregulator@0 { + compatible = regulator-fixed; + regulator-name = vbat; + regulator-min-microvolt = 500; +

Re: [PATCH 1/2] i2c: omap: fix NACK and Arbitration Lost irq handling

2014-11-14 Thread Felipe Balbi
On Sat, Nov 15, 2014 at 05:20:51AM +0400, Alexander Kochetkov wrote: commit 1d7afc95946487945cc7f5019b41255b72224b70 (i2c: omap: ack IRQ in parts) changed the interrupt handler to complete transfers without clearing XRDY (AL case) and ARDY (NACK case) flags. XRDY or ARDY interrupt will be

[PATCH] ARM: DTS: OMAP3-N900: add si4713 support

2014-11-14 Thread Sebastian Reichel
Add si4713 node to the N900 device tree file. Signed-off-by: Sebastian Reichel s...@kernel.org --- arch/arm/boot/dts/omap3-n900.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts index 9b0494a..81c99f3 100644

Re: [PATCH 2/2] i2c: omap: fix Too much work in one IRQ irq handling

2014-11-14 Thread Felipe Balbi
Hi, On Sat, Nov 15, 2014 at 05:20:52AM +0400, Alexander Kochetkov wrote: commit 66b9298878742f08cb6e79b7c7d5632d782fd1e1 (i2c: omap: switch over to do {} while loop) changed the interrupt handler to abort transfers in case interrupt serviced 100 times but commit's comment states that No

[PATCH] DTS: ARM: OMAP3-N900: Add n900-battery support

2014-11-14 Thread Sebastian Reichel
This adds support for the N900's battery to the Nokia N900 DTS file. Signed-off-by: Sebastian Reichel s...@kernel.org --- arch/arm/boot/dts/omap3-n900.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts index

Re: [PATCH 2/2] i2c: omap: fix Too much work in one IRQ irq handling

2014-11-14 Thread Alexander Kochetkov
Hi Felipe, Initially you made the change (66b9298878742f08cb6e79b7c7d5632d782fd1e1): https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/i2c/busses/i2c-omap.c?id=66b9298878742f08cb6e79b7c7d5632d782fd1e1 dev_dbg(dev-dev, IRQ (ISR = 0x%04x)\n, stat);

Re: [PATCH 1/2] i2c: omap: fix NACK and Arbitration Lost irq handling

2014-11-14 Thread Alexander Kochetkov
Assuming this is really correct (I haven't tested), you need to add: To help understanding logic, I'd like to provide event traces (with the patch applied): See i2c-omap.c dc418f6e6a8f5021ccf9e9c0957eefae3737168d as a reference.

Re: [PATCH 2/2] i2c: omap: fix Too much work in one IRQ irq handling

2014-11-14 Thread Felipe Balbi
Hi, (please, never top-post) On Sat, Nov 15, 2014 at 05:37:41AM +0300, Alexander Kochetkov wrote: Hi Felipe, Initially you made the change (66b9298878742f08cb6e79b7c7d5632d782fd1e1):

Re: [PATCH 2/2] i2c: omap: fix Too much work in one IRQ irq handling

2014-11-14 Thread Felipe Balbi
Hi again, On Fri, Nov 14, 2014 at 09:47:56PM -0600, Felipe Balbi wrote: how ? This is an interesting bug which deserves further explanation. Look at the loops above, and at the omap_i2c_complete_cmd: static inline void omap_i2c_complete_cmd(struct omap_i2c_dev *dev, u16 err) {

Re: [PATCH 2/2] i2c: omap: fix Too much work in one IRQ irq handling

2014-11-14 Thread Alexander Kochetkov
Hello again. (please, never top-post) Sorry. Sorry for the inaccurate presentation of ideas. I am not a native English speaker. First about patches: [PATCH 1/2] and [PATCH 2/2] - intended to solve two independent problems. They were sent as series, In the future, try not to do so, In order