On Wed, Aug 26, 2015 at 05:36:24PM -0300, Ezequiel Garcia wrote:
On 26 August 2015 at 17:24, Felipe Balbi ba...@ti.com wrote:
[..]
static irqreturn_t tw68_irq(int irq, void *dev_id)
{
struct tw68_dev *dev = dev_id;
u32 status, orig;
int loop;
On 27 August 2015 at 14:47, Kishon Vijay Abraham I kis...@ti.com wrote:
Hi Uffe,
On Thursday 27 August 2015 06:12 PM, Ulf Hansson wrote:
On 27 August 2015 at 14:41, Ulf Hansson ulf.hans...@linaro.org wrote:
On 27 August 2015 at 11:14, Kishon Vijay Abraham I kis...@ti.com wrote:
Use
On 27 August 2015 at 14:41, Ulf Hansson ulf.hans...@linaro.org wrote:
On 27 August 2015 at 11:14, Kishon Vijay Abraham I kis...@ti.com wrote:
Use regulator_is_enabled of pbias regulator to find pbias regulator
status instead of maintaining a custom bookkeeping
pbias_enabled variable.
Doesn't
Hi Tony,
On 08/26/2015 09:10 PM, Tony Lindgren wrote:
* Grygorii Strashko grygorii.stras...@ti.com [150826 11:01]:
Now Kernel fails to boot 50% of times (form build to build) with
RT-patchset applied due to the following race - on late boot
stages deferred_probe_work_func races with
On 27 August 2015 at 11:13, Kishon Vijay Abraham I kis...@ti.com wrote:
This patch series does the following
*) Uses devm_regulator_get_optional() for vmmc and then removes the
CONFIG_REGULATOR check altogether.
*) return on -EPROBE_DEFER and any other fatal errors
*) enable/disable
Hi,
On 26/08/15 16:11, Jyri Sarha wrote:
I few comments, for the parts I had time to review:
diff --git a/drivers/video/fbdev/omap2/dss/hdmi5.c
b/drivers/video/fbdev/omap2/dss/hdmi5.c
index 7f87578..f352c4b 100644
--- a/drivers/video/fbdev/omap2/dss/hdmi5.c
+++
On 27 August 2015 at 11:14, Kishon Vijay Abraham I kis...@ti.com wrote:
Use regulator_is_enabled of pbias regulator to find pbias regulator
status instead of maintaining a custom bookkeeping
pbias_enabled variable.
Doesn't this cause a problem for the scenario when the initial state
of the
Hi Uffe,
On Thursday 27 August 2015 06:12 PM, Ulf Hansson wrote:
On 27 August 2015 at 14:41, Ulf Hansson ulf.hans...@linaro.org wrote:
On 27 August 2015 at 11:14, Kishon Vijay Abraham I kis...@ti.com wrote:
Use regulator_is_enabled of pbias regulator to find pbias regulator
status instead of
On Thursday 27 August 2015 06:39 PM, Ulf Hansson wrote:
On 27 August 2015 at 11:13, Kishon Vijay Abraham I kis...@ti.com wrote:
This patch series does the following
*) Uses devm_regulator_get_optional() for vmmc and then removes the
CONFIG_REGULATOR check altogether.
*) return on
Hi,
* Hannes Schmelzer hannes.schmel...@br-automation.com [150826 22:55]:
Hi Tony,
Did anyone test this changeset on some AM335x board?
Apparently not if it does not work or else you somehow have a different
configuration for GPMC.
Today I ran into trouble with that because:
The GPMC
This patch adds DT definition for CF8575 GPIO pcf_lcd: gpio@20
expander which is connected to i2c bus 1 and has slave address 0x20.
It allows to control:
- tc_lcd gpios, pins p0-p3
- user leds, pins p4-p7
- control LCD panel power, p15
PCF8575 GPIO pcf_lcd: gpio@20 expander supports interrupt
This series enables support for leds and gpio-keys which
is available on dra7-evm. It also adds pcf8575 gpio expander (i2c1 addr 20)
Grygorii Strashko (3):
ARM: dts: dra7-evm: add pcf8575 gpio expander (i2c1 addr 20)
ARM: dts: dra7-evm: add gpio leds support
ARM: dts: dra7-evm: add gpio key
dra7-evm has 2 gpio keys wired through TS_LCD_GPIO3, TS_LCD_GPIO4
which in turn connected to PCF8575 GPIO pcf_lcd: gpio@20 expander
pins 2 and 3.
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
arch/arm/boot/dts/dra7-evm.dts | 20
1 file changed, 20
dra7-evm has 4 user gpio leds connected to PCF8575 GPIO pcf_lcd:
gpio@20 expander pins [4,5,6,7], so add corresponding DT nodes.
Do not enable any triggers by default as not all of them are proved
to work on -RT.
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
* Grygorii Strashko grygorii.stras...@ti.com [150827 06:42]:
Hi Tony,
On 08/26/2015 09:10 PM, Tony Lindgren wrote:
* Grygorii Strashko grygorii.stras...@ti.com [150826 11:01]:
Now Kernel fails to boot 50% of times (form build to build) with
RT-patchset applied due to the following race -
) {
dev_warn(dev, %s: enabled but no driver.
Idling\n,
__func__);
Seems better to me if it really fixes the issue.
My dra7-evm failed to boot on 2b186e5 Add linux-next specific files for
20150827
and this change restores boot.
Will wait for confirmation from
(twl4030_charger: correctly handle -EPROBE_DEFER from
devm_usb_get_phy_by_node) and kernelci.org found a regression on
omap3-beagle-xm[1]. Bisecting[2] this boot failure pointed at this
commit, and I verified that reverting it on top of next-20150827 gets
the board booting again. I haven't debugged
Hi,
Hi,
* Hannes Schmelzer hannes.schmel...@br-automation.com [150826 22:55]:
Hi Tony,
Did anyone test this changeset on some AM335x board?
Apparently not if it does not work or else you somehow have a different
configuration for GPMC.
Today I ran into trouble with that
Hi Tony,
Did anyone test this changeset on some AM335x board?
Today I ran into trouble with that because:
The GPMC controller gets reseted on kernel boot due to the missing/removed
HWMOD_INIT_NO_RESET flag.
Primary this should not be a big problem, but on my board (maybe on all
AM335x) the
Fix omap_hsmmc_set_power so that pbias regulator is not enabled
during power off.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
Tested-by: Tony Lindgren t...@atomide.com
---
drivers/mmc/host/omap_hsmmc.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
If the regulator is enabled on boot (checked using regulator_is_enabled),
invoke regulator_enable() so that the usecount reflects the correct
state of the regulator and then disable the regulator so that the
initial state of the regulator is disabled. Avoid using -set_power,
since set_power also
No functional change. Cleanup omap_hsmmc_set_power by adding separate
functions to set pbias and invoke it from omap_hsmmc_set_power.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
Tested-by: Tony Lindgren t...@atomide.com
---
drivers/mmc/host/omap_hsmmc.c | 78
Use regulator_is_enabled of pbias regulator to find pbias regulator
status instead of maintaining a custom bookkeeping
pbias_enabled variable.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
Tested-by: Tony Lindgren t...@atomide.com
---
drivers/mmc/host/omap_hsmmc.c |8 ++--
1 file
vdd voltage is set in mmc core to ios-vdd and vmmc should actually
be set to this voltage. Modify omap_hsmmc_enable_supply
to not take vdd as argument since now it's directly set to
the voltage in ios-vdd.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
Tested-by: Tony Lindgren
Now that support for platforms which have optional regulator is added,
remove CONFIG_REGULATOR check in omap_hsmmc.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
Tested-by: Tony Lindgren t...@atomide.com
---
drivers/mmc/host/omap_hsmmc.c | 34 +++---
1 file
enable vmmc_aux regulator only if it is in disabled state and disable
vmmc_aux regulator only if it is in enabled state.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
Tested-by: Tony Lindgren t...@atomide.com
---
drivers/mmc/host/omap_hsmmc.c | 10 --
1 file changed, 8
No functional change. Cleanup omap_hsmmc_set_power by adding separate
functions for enable/disable supply and invoke it from
omap_hsmmc_set_power.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
Tested-by: Tony Lindgren t...@atomide.com
---
drivers/mmc/host/omap_hsmmc.c | 101
No functional change. Instead of using omap_hsmmc_host's vcc and vcc_aux
members, use vmmc and vqmmc present in mmc_host which is present
for the same purpose.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
Reviewed-by: Roger Quadros rog...@ti.com
Tested-by: Tony Lindgren t...@atomide.com
Remove the unnecessary pbias regulator_set_voltage done after
pbias regulator_disable in omap_hsmmc_set_power.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
Reviewed-by: Roger Quadros rog...@ti.com
Tested-by: Tony Lindgren t...@atomide.com
---
drivers/mmc/host/omap_hsmmc.c |1 -
1 file
Return error if any of the regulator APIs (regulator_enable,
regulator_disable, regulator_set_voltage) fails in
omap_hsmmc_set_power to avoid undefined behavior.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
Tested-by: Tony Lindgren t...@atomide.com
---
drivers/mmc/host/omap_hsmmc.c | 52
If the vmmc regulator provides a valid ocrmask, use it. By this even if
the pdata has a valid ocrmask, it will be overwritten with the ocrmask
of the vmmc regulator.
Also remove the unnecessary compatibility check between the ocrmask in
the pdata and the ocrmask from the vmmc regulator.
Now return error only if the return value of
devm_regulator_get_optional() is not the same as -ENODEV, since with
-EPROBE_DEFER, the regulator can be obtained later and all other
errors are fatal.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
Tested-by: Tony Lindgren t...@atomide.com
---
Since vmmc can be optional for some platforms, use
devm_regulator_get_optional() for vmmc. Now return error only
if the return value of devm_regulator_get_optional() is not the
same as -ENODEV, since with -EPROBE_DEFER, the regulator can be
obtained later and all other errors are fatal.
No functional change. Instead of using a local regulator variable
in omap_hsmmc_reg_get() for holding the return value of
devm_regulator_get_optional() and then assigning to omap_hsmmc_host
regulator members: vcc, vcc_aux and pbias, directly use the
omap_hsmmc_host regulator members.
This patch series does the following
*) Uses devm_regulator_get_optional() for vmmc and then removes the
CONFIG_REGULATOR check altogether.
*) return on -EPROBE_DEFER and any other fatal errors
*) enable/disable vmmc_aux regulator based on prior state
Changes from v2:
*) rebased to mmc -next
35 matches
Mail list logo
