Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs

2013-09-12 Thread Alexander Holler
Am 11.09.2013 19:42, schrieb Alexander Holler: Am 11.09.2013 18:14, schrieb Javier Martinez Canillas: So for example in an OMAP board DT you can define something like this: ethernet@5,0 { compatible = smsc,lan9221, smsc,lan9115; interrupt-parent = gpio6

Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs

2013-09-12 Thread Alexander Holler
Am 12.09.2013 12:11, schrieb Javier Martinez Canillas: On 09/12/2013 10:55 AM, Alexander Holler wrote: ... By the way, how do you define two GPIOs/IRQs from different gpio-banks/irq-controllers wuth that scheme? That is indeed a very good question and I don't have a definite answer

Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs

2013-09-12 Thread Alexander Holler
Am 12.09.2013 12:28, schrieb Alexander Holler: Am 12.09.2013 12:11, schrieb Javier Martinez Canillas: On 09/12/2013 10:55 AM, Alexander Holler wrote: ... By the way, how do you define two GPIOs/IRQs from different gpio-banks/irq-controllers wuth that scheme? That is indeed a very good

Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs

2013-09-12 Thread Alexander Holler
Am 12.09.2013 13:09, schrieb Alexander Holler: Am 12.09.2013 12:28, schrieb Alexander Holler: Am 12.09.2013 12:11, schrieb Javier Martinez Canillas: On 09/12/2013 10:55 AM, Alexander Holler wrote: ... By the way, how do you define two GPIOs/IRQs from different gpio-banks/irq-controllers

Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs

2013-09-12 Thread Alexander Holler
Am 12.09.2013 13:26, schrieb Alexander Holler: Am 12.09.2013 13:09, schrieb Alexander Holler: Am 12.09.2013 12:28, schrieb Alexander Holler: Am 12.09.2013 12:11, schrieb Javier Martinez Canillas: On 09/12/2013 10:55 AM, Alexander Holler wrote: ... So, if I understood the code correctly

Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs

2013-09-12 Thread Alexander Holler
linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ What a mess. I assume that is the price that bindings don't have to change. Thanks for clarifying that, Alexander

Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs

2013-09-11 Thread Alexander Holler
. Regards, Alexander Holler -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs

2013-09-11 Thread Alexander Holler
Am 11.09.2013 09:05, schrieb Alexander Holler: Am 10.09.2013 17:00, schrieb Joel Fernandes: I think your initial patch is much better than fixing up DT but then I may be missing other problems with your patch that Linus's patch addresses. The initial patch had the problem that it not only

Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs

2013-09-11 Thread Alexander Holler
And another small update. ;) Am 11.09.2013 09:16, schrieb Alexander Holler: To summarize what happens if a driver uses a gpio as irq: gpio_request() // This works only if the gpio was not requested before gpio_direction_input() gpio_to_irq() // This needs an irq-mapping request_threaded_irq

Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs

2013-09-11 Thread Alexander Holler
Am 11.09.2013 09:30, schrieb Alexander Holler: And another small update. ;) Am 11.09.2013 09:16, schrieb Alexander Holler: To summarize what happens if a driver uses a gpio as irq: gpio_request() // This works only if the gpio was not requested before gpio_direction_input() gpio_to_irq

Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs

2013-09-11 Thread Alexander Holler
very confusing because it needed an IRQ number. That IRQ number depends on the mapping and isn't hw specific (and currently just human doable because of the simple mapping). Regards, Alexander Holler -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs

2013-09-11 Thread Alexander Holler
Am 11.09.2013 18:14, schrieb Javier Martinez Canillas: On 09/11/2013 05:30 PM, Alexander Holler wrote: Am 22.08.2013 00:02, schrieb Linus Walleij: On Tue, Aug 20, 2013 at 12:04 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: On Wednesday 31 July 2013 01:44:53 Linus Walleij wrote

Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-07 Thread Alexander Holler
Am 07.08.2013 07:52, schrieb Greg Kroah-Hartman: On Tue, Aug 06, 2013 at 03:37:13PM +0200, Alexander Holler wrote: Am 06.08.2013 12:14, schrieb Greg Kroah-Hartman: What exactly is a platform device anyway? Originally it was a something that wasn't connected to a bus, but just had memory

Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-06 Thread Alexander Holler
. MFD uses platform devices too. Regards, Alexander Holler -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs

2013-08-03 Thread Alexander Holler
Am 02.08.2013 17:35, schrieb Alexander Holler: Am 02.08.2013 11:57, schrieb Alexander Holler: There must have been a bug in the patch too. I've also added that iinterrupt-parent stuff (with the same flags as used by the driver) and just have let the driver call request_threaded_irq

Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs

2013-08-02 Thread Alexander Holler
the syntax too, and it wasn't obvious how the syntax is and how to conclude from a gpio number to an irq-number and the patch didn't really include some documentation or useful example. Regards, Alexander Holler -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs

2013-08-02 Thread Alexander Holler
Am 02.08.2013 11:57, schrieb Alexander Holler: There must have been a bug in the patch too. I've also added that iinterrupt-parent stuff (with the same flags as used by the driver) and just have let the driver call request_threaded_irq(gpio_to_irq(gpio), flags); without the gpio_request

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-29 Thread Alexander Holler
, Alexander Holler -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-29 Thread Alexander Holler
or not. That won't help with the current problem because the DTS doesn't know that some code want's to use a gpio as irq, so that can't be verified. Regards, Alexander Holler -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-29 Thread Alexander Holler
Am 29.07.2013 10:17, schrieb Javier Martinez Canillas: Hi Alexander, On Mon, Jul 29, 2013 at 8:41 AM, Alexander Holler hol...@ahsoftware.de wrote: Am 28.07.2013 21:06, schrieb Javier Martinez Canillas: On Sun, Jul 28, 2013 at 8:22 PM, Linus Walleij linus.wall...@linaro.org wrote

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-29 Thread Alexander Holler
Am 29.07.2013 11:05, schrieb Linus Walleij: On Mon, Jul 29, 2013 at 7:24 AM, Alexander Holler hol...@ahsoftware.de wrote: Maybe it might be worth to suggest using/returning NO_IRQ in (new) patches instead of zero. That would make it very clear that the value 0 isn't to be used later. Using

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-29 Thread Alexander Holler
Am 29.07.2013 13:11, schrieb Javier Martinez Canillas: On 29/07/2013, at 12:27, Alexander Holler hol...@ahsoftware.de wrote: Am 29.07.2013 10:17, schrieb Javier Martinez Canillas: Hi Alexander, On Mon, Jul 29, 2013 at 8:41 AM, Alexander Holler hol...@ahsoftware.de wrote: Am 28.07.2013 21:06

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-29 Thread Alexander Holler
Am 29.07.2013 13:30, schrieb Alexander Holler: So I think the driver has to be changed independently of the approach for auto request GPIO used. Maybe, but that isn't much effort. I had done that in 3 minutes (ok, without the would be necessary #ifdef CONFIG_OF_GPIO). But you have a chicken

Re: OMAP5912 boot broken by gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-29 Thread Alexander Holler
the same problems as with omap_hsmmc would have been occured when someone had tried to use that driver with 3.11-rc2. Regards, Alexander Holler -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info

Re: OMAP5912 boot broken by gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-29 Thread Alexander Holler
Am 29.07.2013 17:06, schrieb Santosh Shilimkar: On Monday 29 July 2013 10:52 AM, Alexander Holler wrote: Am 29.07.2013 14:57, schrieb Santosh Shilimkar: With some helps from MMC and other guys, we validated the Linus's tip which includes your patches. It actually doesn't break anything

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Alexander Holler
Am 28.06.2013 17:27, schrieb Javier Martinez Canillas: When a GPIO is defined as an interrupt line using Device Tree, a call to irq_create_of_mapping() is made that calls irq_create_mapping(). So, is not necessary to do the mapping for all OMAP GPIO lines and explicitly call irq_create_mapping()

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Alexander Holler
Am 28.07.2013 13:14, schrieb Linus Walleij: On Sun, Jul 28, 2013 at 12:58 PM, Alexander Holler hol...@ahsoftware.de wrote: Am 28.06.2013 17:27, schrieb Javier Martinez Canillas: When a GPIO is defined as an interrupt line using Device Tree, a call to irq_create_of_mapping() is made

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Alexander Holler
Am 28.07.2013 12:58, schrieb Alexander Holler: This patch basically broke every usage of irq = gpio_to_irq(gpio); request[_threaded]_irq(irq, ...); because request[_threaded]_irq(irq, ...) now fails because of a missing irq_domain (no mapping = no domain). A prominent victim

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Alexander Holler
Am 28.07.2013 18:25, schrieb Linus Walleij: On Sun, Jul 28, 2013 at 4:25 PM, Alexander Holler hol...@ahsoftware.de wrote: By the way, if someone decides to touch omap_hsmmc, the driver wrongly assumes that 0 is not a valid IRQ number and it doesn't check if gpio_to_irq() returns a negative

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Alexander Holler
(now) isn't used anymore. Besides that, I feel free to ignore me. I don't know what the new patches do fix and I don't really have a need for a solution. Regards, Alexander Holler -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Alexander Holler
Am 28.07.2013 20:50, schrieb Javier Martinez Canillas: On Sun, Jul 28, 2013 at 8:06 PM, Linus Walleij linus.wall...@linaro.org wrote: On Sun, Jul 28, 2013 at 6:45 PM, Alexander Holler hol...@ahsoftware.de wrote: Am 28.07.2013 18:25, schrieb Linus Walleij: On Sun, Jul 28, 2013 at 4:25 PM

Re: [PATCH] USB: ehci-omap: Select USB_PHY

2013-04-11 Thread Alexander Holler
Am 11.04.2013 14:42, schrieb Roger Quadros: On 04/11/2013 01:55 PM, Felipe Balbi wrote: I would avoid 'select' completely and just update omap2plus_defconfig adding those two as modules. OK, makes sense. I will update the patch to remove select NOP_USB_XCEIV. Sorry, but this just will end

Re: [PATCH] USB: ehci-omap: Select USB_PHY

2013-04-11 Thread Alexander Holler
Am 11.04.2013 16:44, schrieb Roger Quadros: Sorry, but this just will end up with many users having broken configs because of disabled stuff they don't know why they have to enable them. And thus with a never ending stream of questions and thus with a needed FAQ entry. Alexander, I agree

Re: [PATCH] USB: ehci-omap: Select USB_PHY

2013-04-11 Thread Alexander Holler
Am 11.04.2013 20:29, schrieb Felipe Balbi: and who said OMAP USB depends on CONFIG_USB_PHY ? Some platforms need to control a PHY and some don't. I've read that so. Go check out kernel 2.6.39 (maybe even 3.1 and 3.2) and you'll see that we're much better off today where we can actually have

Re: [PATCH] arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC

2011-06-09 Thread Alexander Holler
Hello, Am 09.06.2011 09:40, schrieb Igor Grinberg: On 06/09/11 03:21, Alexander Holler wrote: I see. Is the new patch version somehow provides better functionality? You configure the gpio for output, this means that the pin is actually driven and not just relies on internal pullup (which can

Re: [PATCH] arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC

2011-06-08 Thread Alexander Holler
On 08.06.2011 23:57, Igor Grinberg wrote: On 06/07/11 14:15, Alexander Holler wrote: Am 07.06.2011 11:50, schrieb Igor Grinberg: On 06/07/11 11:01, Alexander Holler wrote: Am 31.05.2011 12:29, schrieb Tony Lindgren: * Alexander Hollerhol...@ahsoftware.de [110405 06:38]: Without msecure

Re: [PATCH] arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC

2011-06-07 Thread Alexander Holler
, msecure); + gpio_direction_output(22, true); + gpio_export(22, false); + /* Ensure SDRC pins are mux'd for self-refresh */ omap_mux_init_signal(sdrc_cke0, OMAP_PIN_OUTPUT); omap_mux_init_signal(sdrc_cke1, OMAP_PIN_OUTPUT); -- 1.7.3.4 Regards, Alexander Holler

Re: [PATCH] arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC

2011-06-07 Thread Alexander Holler
Am 07.06.2011 11:50, schrieb Igor Grinberg: On 06/07/11 11:01, Alexander Holler wrote: Am 31.05.2011 12:29, schrieb Tony Lindgren: * Alexander Hollerhol...@ahsoftware.de [110405 06:38]: Without msecure beeing high it isn't possible to set (or start) the RTC. Tested with a BeagleBoard C4

Re: rtc-twl: catch22 in 2.6.37 and 2.6.38 when clock was never set

2011-04-05 Thread Alexander Holler
Hello, Am 04.04.2011 16:29, schrieb Alexander Holler: it just happened here that the rechargeable backup battery for the RTC on a TPS65950 run out off power, because of some days while the device wasn't powered. Afterwards I couldn't read or set the clock with hwclock using a kernel 2.6.37.n

[PATCH] arm: omap3: beagle: Ensure msecure is mux'd to be able to set the RTC

2011-04-05 Thread Alexander Holler
Without msecure beeing high it isn't possible to set (or start) the RTC. Tested with a BeagleBoard C4. Signed-off-by: Alexander Holler hol...@ahsoftware.de --- arch/arm/mach-omap2/board-omap3beagle.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2

rtc-twl: catch22 in 2.6.37 and 2.6.38 when clock was never set

2011-04-04 Thread Alexander Holler
are working. So it looks like there is a catch22 in kernels =2.6.37 (I haven't tested .33-.36): When the clock was never set, the alarm(-irq) doesn't work, so hwclock doesn't work, so one can't set the clock. Regards, Alexander Holler -- To unsubscribe from this list: send the line unsubscribe linux

Re: [GIT PULL] omap changes for v2.6.39 merge window

2011-03-31 Thread Alexander Holler
Hello, Am 31.03.2011 10:09, schrieb Russell King - ARM Linux: We also need the various SoC designers and ARM architecture people to realise that what the hardware situation is rediculous; I have commented about this lack of standardisation to ARM in past years. ARM have had a standard set of

Re: [024/115] USB: prevent buggy hubs from crashing the USB stack

2011-02-24 Thread Alexander Holler
. It should be easy enough to add. Sure Alan, it's attached to this mail. Compile tested only though. Michael, would you care to give your tested-by ? I can do, I'm using exactly the same patch since yesterday. ;) Tested-by: Alexander Holler hol...@ahsoftware.de Regards, Alexander

Re: [024/115] USB: prevent buggy hubs from crashing the USB stack

2011-02-24 Thread Alexander Holler
Hello, Am 24.02.2011 18:57, schrieb Alan Stern: It's important that this patch appear in .37-stable at the same time as the $SUBJECT patch. If that means delaying $SUBJECT for one release, so be it -- it was not a very important change. Too late, 2.6.37.1 is already broken. But the patch

musb (omap3) as host fails with reconnecting devices

2010-12-13 Thread Alexander Holler
Hello, I've tried to use a BT-dongle attached via a Mini-A-Std A cable to the OTG-port of a BeagleBoard Rev C4 (OMAP3530). That devices needs a firmware and disconnects/reconnects with a new pid after it has received the firmware (ath3k). I'm currently trying it with a kernel v2.6.37-rc5.