t;
> Cc: Tony Lindgren
> Cc: Nishanth Menon
> Signed-off-by: Felipe Balbi
> ---
> arch/arm/boot/dts/am57xx-beagle-x15.dts | 1 +
> drivers/rtc/rtc-ds1307.c| 36
> +++------
> 2 files changed, 4 insertions(+), 33 deletions(-)
s")
>
> Signed-off-by: Tero Kristo
> ---
> drivers/rtc/rtc-ds1307.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubsc
On 26/08/2015 at 11:01:27 -0700, Tony Lindgren wrote :
> * Keerthy [150826 09:54]:
> > Tony,
> >
> > On Saturday 22 August 2015 02:48 AM, Alexandre Belloni wrote:
> > >Tony,
> > >
> > >On 18/08/2015 at 15:11:13 +0530, Keerthy wrote :
> &g
tc->clk);
> +
> rtc->type->unlock(rtc);
> /* leave rtc running, but disable irqs */
Is it actually still running once the clock is disabled?
> rtc_write(rtc, OMAP_RTC_INTERRUPTS_REG, 0);
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and
; rtc: omap: Add internal clock enabling support
> rtc: omap: Add external clock enabling support
>
I'm wondering how you want to get those patches merged. I can let you
take 2 and 3 through arm-soc but you will miss 4.3. Or I can take 2 and
3 for 4.3 but the documentation will be mis
/* leave rtc running, but disable irqs */
> rtc_write(rtc, OMAP_RTC_INTERRUPTS_REG, 0);
>
> + if (rtc->has_ext_clk) {
Then you could also avoid has_ext_clk and simply test rtc->ext_clk.
> + reg = rtc_read(rtc, OMAP_RTC_OSC_REG);
> + reg &am
rom a hardware point of view. But since we agreed on
the DT bindings, I'd say that we can still adjust the driver later.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubsc
x27;d say that I don't really care. I'd say the best would be to make a
decision based on clock-accuracy but maybe that is an information you
don't have yet. Anyway, this could be added at a later date.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android
suspend
> + */
> + if (rtc->has_ext_clk) {
> + reg = rtc_read(rtc, OMAP_RTC_OSC_REG);
> + rtc_write(rtc, OMAP_RTC_OSC_REG, reg |
> + OMAP_RTC_OSC_SEL_32KCLK_SRC);
> + }
> +
You should probably prepare/enable the clock before switching to
;int-clk", "ext-clk";
> };
>
> Driver:
> 1) clk0 is mandatory, internal clock source
> 2) clk1 is optional, external clock source, so
> if present - RTC driver can switch to use ext clock source
>
Absolutely!
--
Alexandre Belloni, Free Electrons
Embedded Linu
On 06/08/2015 at 07:39:52 +0530, Keerthy wrote :
> On Wednesday 05 August 2015 06:05 PM, Alexandre Belloni wrote:
> >On 05/08/2015 at 17:31:22 +0530, Keerthy wrote :
> >>This is a special one where in the enable bit is present in the rtc register
> >>space and not in the
his external clock is coming internally from the SoC?
Do you have a link to the datasheet?
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body
On 05/08/2015 at 13:41:19 +0200, Alexandre Belloni wrote :
> Hi,
>
> On 05/08/2015 at 04:13:17 -0700, Tony Lindgren wrote :
> > * Keerthy [150805 03:53]:
> > > Based on the board property switch the source from internal
> > > to external clock. Switching
. If
it is present you can even get its rate if this is needed at some point
in the future. You could also disable it when going to suspend.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line &q
07.
>
> V1: https://patchwork.kernel.org/patch/4759171/
>
> NOTE: Patch 5/5 of the series is meant to indicate the usage, and will
> be reposted along with other wakeup sources to be enabled once the
> driver changes are accepted.
>
I've left that one out so you can send it to the omap mai
dev_err(&client->dev, "unable to setup wakeIRQ %d!\n",
> + err);
> + goto exit;
> }
> }
>
> +no_irq:
> if (chip->nvram_size) {
>
> ds1307->nvram = devm_kza
eIRQ
> %d\n",
> + err);
> + free_irq(client->irq, client);
> + goto exit;
> + }
> +
> + /* We enable the interrupt only during suspend pa
On 22/04/2015 at 19:04:52 -0500, Nishanth Menon wrote :
> > I fully agree that your patch doesn't change the behaviour for the other
> > cases you presented and further clean up is to be done in a separate set
> > of patches.
> >
>
Sure,
Acked-by: Alexandre
your patch doesn't change the behaviour for the other
cases you presented and further clean up is to be done in a separate set
of patches.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send
nting to try to not introduce another race condition.
What about setting ALM0MTH to 0x1F before reading the control registers?
You could also read only the first 3 registers as all the others are
overwritten. And finally, you only need to write 9 bytes instead of 10
(register 0x10 is reserved).
TROL, 10, regs);
> if (ret < 0)
> return ret;
>
> - return 0;
> + if (!t->enabled)
> + return 0;
> + regs[0] |= MCP794XX_BIT_ALM0_EN;
> + return i2c_smbus_write_byte_data(client, MCP794XX_REG_CONTROL, regs[0]);
> }
>
> static
internal 32k to keep DT ABI backward compatibility.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
Hi,
On 02/04/2015 at 18:14:11 +0530, Lokesh Vutla wrote :
> Here is the updated patch.
>
You should probably send it properly using git send-email, have a look
at the --in-reply-to parameter, else, I'm not sure Andrew will be able
to pick it up.
Thanks!
--
Alexandre Belloni, Fre
rtc_suspend(struct device *dev)
> enable_irq_wake(rtc->irq_alarm);
> else
> rtc_write(rtc, OMAP_RTC_INTERRUPTS_REG, 0);
> + rtc->type->lock(rtc);
>
> /* Disable the clock/module */
> pm_runtime_put_sync(dev);
> @@ -
On 01/04/2015 at 11:24:58 +0530, Lokesh Vutla wrote :
> module_platform_driver_probe() prevents driver from requesting probe deferral.
> So using module_platform_drive() to support probe deferral.
>
> Signed-off-by: Lokesh Vutla
Acked-by: Alexandre Belloni
> ---
> drivers/
>type->has_kicker) {
Instead of testing for has_kicker each time, I would add .lock and
.unlock to omap_rtc_device_type and directly use rtc->type->lock and
rtc->type->unlock.
> + rtc_writel(rtc, OMAP_RTC_KICK0_REG, KICK0_VALUE);
> + rtc_writel(rtc, OM
On 01/04/2015 at 11:24:57 +0530, Lokesh Vutla wrote :
> RTC is present in AM43xx and DRA7xx also. Updating the Kconfig
> to depend on ARCH_OMAP or ARCH_DAVINCI
>
> Signed-off-by: Lokesh Vutla
Acked-by: Alexandre Belloni
> ---
> drivers/rtc/Kconfig | 6 +++---
> 1 file
Hi,
On 14/01/2015 at 16:21:50 +, Russell King - ARM Linux wrote :
> On Wed, Jan 14, 2015 at 04:46:03PM +0100, Alexandre Belloni wrote:
> > Hi,
> >
> > This patch set hasn't moved since while. We actually need patch 4 to
> > properly configure prefetch on sama5
| 3 +-
> arch/arm/mach-exynos/firmware.c| 50 +
> arch/arm/mach-exynos/sleep.S | 46 +
> arch/arm/mm/cache-l2x0.c | 255
> -
> 8 files changed, 294 insertions(+), 96 d
On 19/09/2014 at 17:39:32 +0100, Russell King - ARM Linux wrote :
> On Fri, Sep 19, 2014 at 11:50:01AM +0200, Alexandre Belloni wrote:
> > On 26/08/2014 at 16:17:57 +0200, Tomasz Figa wrote :
> > > Firmware on certain boards (e.g. ODROID-U3) can leave incorrect L2C
> > &
ttings to be specified from DT and necessary support in the
> driver.
>
> Signed-off-by: Tomasz Figa
Tested-by: Alexandre Belloni
It is working and useful on Atmel's sama5d4 were the bootloader is not
configuring the L2C prefetch. However, I'm wondering whether we
-pwm and pwm_bl drivers get the period from the PWM
Alexandre Belloni (11):
pwm: add period and polarity to struct pwm_lookup
ARM: shmobile: Armadillo 800 EVA: initialize all struct pwm_lookup
members
pwm: renesas-tpu: remove useless struct tpu_pwm_platform_data
ARM: OMAP3: Beagle: ini
Adds a period and a polarity member to struct pwm_lookup so that when performing
a lookup using the lookup table instead of device tree, we are able to set the
period and the polarity accordingly like what is done in
of_pwm_xlate_with_flags.
Signed-off-by: Alexandre Belloni
---
drivers/pwm
The PWM core is now able to initialize the PWM period from platform_data. Use it
and if it is not configured, use the supplied pwm_period_ns.
Signed-off-by: Alexandre Belloni
---
drivers/video/backlight/pwm_bl.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers
This will allow to get rid of the .pwm_period_ns member of struct led_pwm as the
period will be set by the PWM core.
Signed-off-by: Alexandre Belloni
---
arch/arm/mach-omap2/board-omap3beagle.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/board
Signed-off-by: Alexandre Belloni
Acked-by: Simon Horman
---
arch/arm/mach-shmobile/board-armadillo800eva.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c
b/arch/arm/mach-shmobile/board-armadillo800eva.c
index
The PWM core is now able to initialize the PWM period. Use it and if it is not
configured, use the supplied pwm_period_ns.
Signed-off-by: Alexandre Belloni
---
drivers/leds/leds-pwm.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/leds-pwm.c b/drivers/leds
Signed-off-by: Alexandre Belloni
---
arch/arm/mach-pxa/hx4700.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mach-pxa/hx4700.c b/arch/arm/mach-pxa/hx4700.c
index 0788a1f171fe..c66ad4edc5e3 100644
--- a/arch/arm/mach-pxa/hx4700.c
+++ b/arch/arm/mach-pxa
Initializing all the struc pwm_lookup members allows to get rid of the struct
tpu_pwm_platform_data as the polarity initialization will be taken care of by
the PWM core.
Signed-off-by: Alexandre Belloni
Acked-by: Simon Horman
---
arch/arm/mach-shmobile/board-armadillo800eva.c | 20
Now that PWM_LOOKUP is not used anymore, modify it to initialize all the
members of struct pwm_lookup.
Signed-off-by: Alexandre Belloni
---
Documentation/pwm.txt | 3 ++-
include/linux/pwm.h | 4 +++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/pwm.txt b
The struct is not used anymore and the polarity initialization will be taken
care of by the PWM core.
Signed-off-by: Alexandre Belloni
---
drivers/pwm/pwm-renesas-tpu.c | 19 +++
include/linux/platform_data/pwm-renesas-tpu.h | 16
2 files changed
This will allow to get rid of the .pwm_period_ns member of struct
platform_pwm_backlight_data as the period will be set by the PWM core.
Signed-off-by: Alexandre Belloni
---
arch/arm/mach-pxa/hx4700.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-pxa
Signed-off-by: Alexandre Belloni
---
arch/arm/mach-omap2/board-omap3beagle.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mach-omap2/board-omap3beagle.c
b/arch/arm/mach-omap2/board-omap3beagle.c
index f27e1ec90b5e..54c135a5b4f7 100644
--- a/arch/arm
Hello Thierry,
Do you know when you will have some time to review that patch series ?
On 14/04/2014 at 23:59:42 +0200, Alexandre Belloni wrote :
> Hi,
>
> A patch set as suggested by Thierry to make lookup with the lookup table
> instead of device tree behave more like when using
Initializing all the struct pwm_lookup members allows to get rid of the struct
tpu_pwm_platform_data as the polarity initialization will be taken care of by
the PWM core.
Signed-off-by: Alexandre Belloni
---
arch/arm/mach-shmobile/board-armadillo800eva.c | 20 +---
1 file
This will allow to get rid of the .pwm_period_ns member of struct led_pwm as the
period will be set by the PWM core.
Signed-off-by: Alexandre Belloni
---
arch/arm/mach-omap2/board-omap3beagle.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/board
returning.
- don't change PWM_LOOKUP atomically
- remove tpu_pwm_platform_data and the associated header file
- make the leds-pwm and pwm_bl drivers get the period from the PWM
Alexandre Belloni (11):
pwm: add period and polarity to struct pwm_lookup
ARM: shmobile: Armadillo 800 EVA:
The struct tpu_pwm_platform_data is not used anymore and the polarity
initialization will be taken care of by the PWM core.
Signed-off-by: Alexandre Belloni
---
drivers/pwm/pwm-renesas-tpu.c | 19 +++
include/linux/platform_data/pwm-renesas-tpu.h | 16
the default is 0 anyway.
Signed-off-by: Alexandre Belloni
---
drivers/pwm/core.c | 8 +++-
include/linux/pwm.h | 2 ++
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index a80471399c20..4b66bf09ee55 100644
--- a/drivers/pwm/core.c
+++ b
The PWM core is now able to initialize the PWM period. Use it and if it is not
configured, use the supplied pwm_period_ns.
Signed-off-by: Alexandre Belloni
---
drivers/leds/leds-pwm.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/leds-pwm.c b/drivers/leds
Now that PWM_LOOKUP is not used anymore, modify it to initialize all the
members of struct pwm_lookup.
Signed-off-by: Alexandre Belloni
---
Documentation/pwm.txt | 3 ++-
include/linux/pwm.h | 4 +++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/pwm.txt b
Signed-off-by: Alexandre Belloni
---
arch/arm/mach-shmobile/board-armadillo800eva.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c
b/arch/arm/mach-shmobile/board-armadillo800eva.c
index 1bf61dad9a35..ca82b1e2ebab
Signed-off-by: Alexandre Belloni
---
arch/arm/mach-pxa/hx4700.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mach-pxa/hx4700.c b/arch/arm/mach-pxa/hx4700.c
index 0788a1f171fe..c66ad4edc5e3 100644
--- a/arch/arm/mach-pxa/hx4700.c
+++ b/arch/arm/mach-pxa
Signed-off-by: Alexandre Belloni
---
arch/arm/mach-omap2/board-omap3beagle.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mach-omap2/board-omap3beagle.c
b/arch/arm/mach-omap2/board-omap3beagle.c
index f27e1ec90b5e..54c135a5b4f7 100644
--- a/arch/arm
This will allow to get rid of the .pwm_period_ns member of struct
platform_pwm_backlight_data as the period will be set by the PWM core.
Signed-off-by: Alexandre Belloni
---
arch/arm/mach-pxa/hx4700.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-pxa
The PWM core is now able to initialize the PWM period from platform_data. Use it
and if it is not configured, use the supplied pwm_period_ns.
Signed-off-by: Alexandre Belloni
---
drivers/video/backlight/pwm_bl.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers
On 10/04/2014 at 08:15:49 +0900, Simon Horman wrote :
> On Wed, Apr 09, 2014 at 08:04:09PM +0200, Alexandre Belloni wrote:
> > Now that the PWM core is able to set the period and polarity based on
> > the lookup table, add those to PWM_LOOKUP to ease their usage.
>
> I would
On 09/04/2014 at 20:37:06 +0100, Russell King - ARM Linux wrote :
> On Wed, Apr 09, 2014 at 08:04:08PM +0200, Alexandre Belloni wrote:
> > Adds a period and a polarity member to struct pwm_lookup so that when
> > performing
> > a lookup using the lookup table instead of dev
PWM_LOOKUP to set period an polarity. I was wondering
about adding a new macro to d that but the number of boards using it is limited
(only 3) so I guess it is ok to do that now.
The final goal would be to get rid of .pwm_period_ns in leds-pwm and pwm_bl.
Alexandre Belloni (2):
pwm: add period and
Now that the PWM core is able to set the period and polarity based on
the lookup table, add those to PWM_LOOKUP to ease their usage.
Signed-off-by: Alexandre Belloni
---
Documentation/pwm.txt | 3 ++-
arch/arm/mach-omap2/board-omap3beagle.c| 3 ++-
arch/arm/mach
Adds a period and a polarity member to struct pwm_lookup so that when performing
a lookup using the lookup table instead of device tree, we are able to set the
period and the polarity accordingly like what is done in
of_pwm_xlate_with_flags.
Signed-off-by: Alexandre Belloni
---
drivers/pwm
il/linux-arm-kernel/2014-February/232185.html
I've hit the issue, precisely using those bindings.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap"
ARM Performance Monitor Units are available on the sama5d3, add the support in
the dtsi.
Tested with perf and oprofile on the sama5d31ek.
Signed-off-by: Alexandre Belloni
---
arch/arm/boot/dts/sama5d3.dtsi | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/sama5d3.dtsi
ARM Performance Monitor Units are available on the am33xx, add the support in
the dtsi.
Tested with perf and oprofile on a regular beaglebone.
Signed-off-by: Alexandre Belloni
---
arch/arm/boot/dts/am33xx.dtsi | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts
64 matches
Mail list logo