[PATCH] gpio: omap: Fix missing raw locks conversion

2015-08-05 Thread Axel Lin
: expected 'struct spinlock_t *' but argument is of type 'struct raw_spinlock_t *' Fixes: commit 4dbada2be460 (gpio: omap: use raw locks for locking) Signed-off-by: Axel Lin axel@ingics.com --- drivers/gpio/gpio-omap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] mfd: twl6040: Remove wrong and unneeded platform:twl6040 modalias

2015-03-30 Thread Axel Lin
This is a I2C driver, so it's wrong to use platform prefix for the modalias. We have all needed i2c aliases coming form MODULE_DEVICE_TABLE, so let's remove the wrong and unneeded platform:twl6040 modalias. Signed-off-by: Axel Lin axel@ingics.com --- drivers/mfd/twl6040.c | 1 - 1 file

[PATCH v2] mmc: omap: Use DIV_ROUND_UP instead of open coded

2014-05-02 Thread Axel Lin
Also uses NSEC_PER_SEC and USEC_PER_SEC instead of hard-coded value. This makes the intention more clear. Signed-off-by: Axel Lin axel@ingics.com --- drivers/mmc/host/omap.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc

[PATCH] mmc: omap: Use DIV_ROUND_UP instead of open coded

2014-04-27 Thread Axel Lin
This also makes the intention more clear. Signed-off-by: Axel Lin axel@ingics.com --- drivers/mmc/host/omap.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 5c2e58b..711981e 100644 --- a/drivers/mmc/host

[PATCH] mmc: omap: Use DIV_ROUND_UP instead of open coded

2013-09-01 Thread Axel Lin
This patch makes the intention of the code more clear. Signed-off-by: Axel Lin axel@ingics.com --- drivers/mmc/host/omap.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index b94f38e..3187af0 100644

[PATCH] ARM: OMAP2: reboot: Include common.h to fix build error

2013-06-19 Thread Axel Lin
[-Wstrict-prototypes] make[1]: *** [arch/arm/mach-omap2/omap4-restart.o] Error 1 make: *** [arch/arm/mach-omap2] Error 2 Signed-off-by: Axel Lin axel@ingics.com --- Seems this build error is introduced by commit 7507d035f3cf40c reboot: arm: change reboot_mode to use enum reboot_mode This patch

[PATCH] mmc: omap_hsmmc: Prevent potential NULL dereference

2013-03-18 Thread Axel Lin
of_get_hsmmc_pdata() may return NULL, thus ensure pdata is not NULL before dereference it. Signed-off-by: Axel Lin axel@ingics.com --- drivers/mmc/host/omap_hsmmc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host

[PATCH] OMAPDSS: Add terminating entry for picodlp_i2c_id table

2012-11-29 Thread Axel Lin
The i2c_device_id table is supposed to be zero-terminated. Signed-off-by: Axel Lin axel@gmail.com --- drivers/video/omap2/displays/panel-picodlp.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/omap2/displays/panel-picodlp.c b/drivers/video/omap2/displays/panel

[PATCH] ARM: OMAP: Fix dependency for OMAP_DEBUG_LEDS

2012-10-07 Thread Axel Lin
-leds.c:113: more undefined references to `led_classdev_register' follow make: *** [vmlinux] Error 1 Signed-off-by: Axel Lin axel@ingics.com --- Hi Bryan, I think this issue is introduced by commit dafbead ARM: mach-omap1: retire custom LED code. Regards, Axel arch/arm/plat-omap/Kconfig |2

[PATCH v2] ARM: OMAP: Fix dependency for OMAP_DEBUG_LEDS

2012-10-07 Thread Axel Lin
-in.o:arch/arm/plat-omap/debug-leds.c:113: more undefined references to `led_classdev_register' follow make: *** [vmlinux] Error 1 Signed-off-by: Axel Lin axel@ingics.com --- arch/arm/plat-omap/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm

Re: [PATCH] ARM: OMAP: OMAP_DEBUG_LEDS needs to select LEDS_CLASS

2012-09-18 Thread Axel Lin
2012/9/18 Bryan Wu bryan...@canonical.com: On Tue, Sep 18, 2012 at 11:30 AM, Axel Lin axel@gmail.com wrote: This fixes below build error when CONFIG_LEDS_CLASS is not set. LD init/built-in.o arch/arm/plat-omap/built-in.o: In function `fpga_probe': arch/arm/plat-omap/debug-leds.c

[PATCH] cpufreq: OMAP: Check IS_ERR() instead of NULL for omap_device_get_by_hwmod_name

2012-09-17 Thread Axel Lin
omap_device_get_by_hwmod_name() returns ERR_PTR on error. Signed-off-by: Axel Lin axel@gmail.com --- drivers/cpufreq/omap-cpufreq.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/omap-cpufreq.c b/drivers/cpufreq/omap-cpufreq.c index 6e22f44

[PATCH] ARM: OMAP: OMAP_DEBUG_LEDS needs to select LEDS_CLASS

2012-09-17 Thread Axel Lin
This fixes below build error when CONFIG_LEDS_CLASS is not set. LD init/built-in.o arch/arm/plat-omap/built-in.o: In function `fpga_probe': arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register' make: *** [vmlinux] Error 1 Signed-off-by: Axel Lin axel

[PATCH 5/6] regulator: twl: Remove get_voltage implementation for single voltage regulators

2012-08-09 Thread Axel Lin
This is not required after commit f7df20ec regulator: core: Use list_voltage() to read single voltage regulators Signed-off-by: Axel Lin axel@gmail.com --- drivers/regulator/twl-regulator.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/regulator/twl-regulator.c b

Re: [PATCH RFT 1/2] regulator: twl: Fix the formula to calculate vsel and voltage for twl6030ldo

2012-07-16 Thread Axel Lin
On Monday 09 July 2012 04:31 PM, Axel Lin wrote: 於 一,2012-07-09 於 11:22 +0800,Axel Lin 提到: In twl6030ldo_set_voltage, current code use below formula to calculate vsel: vsel = (min_uV/1000 - 1000)/100 + 1; This is worng because when min_uV is 100 uV, vsel is 1. It should

[PATCH RFT] regulator: twl: Fix list_voltate for twl6030ldo_ops

2012-07-16 Thread Axel Lin
This patch implements the list_voltage callback based on above table. Signed-off-by: Axel Lin axel@gmail.com --- drivers/regulator/twl-regulator.c | 31 --- 1 file changed, 24 insertions(+), 7 deletions(-) diff --git a/drivers/regulator/twl-regulator.c b/drivers

[PATCH] ASoC: Fix build error in sound/soc/omap/n810.c

2012-02-09 Thread Axel Lin
/soc] Error 2 make: *** [sound] Error 2 Signed-off-by: Axel Lin axel@gmail.com --- sound/soc/omap/n810.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/soc/omap/n810.c b/sound/soc/omap/n810.c index 1490227..c292bf0 100644 --- a/sound/soc/omap/n810.c +++ b/sound

[PATCH] video: convert drivers/video/* to use module_spi_driver()

2012-01-27 Thread Axel Lin
This patch converts the drivers in drivers/video/* to use the module_spi_driver() macro which makes the code smaller and a bit simpler. Signed-off-by: Axel Lin axel@gmail.com Cc: Imre Deak imre.d...@nokia.com Cc: Roger Quadros roger.quad...@nokia.com Cc: Steve Sakoman st...@sakoman.com Cc

[PATCH 1/2] video: omap: Staticise non-exported symbols

2011-12-08 Thread Axel Lin
These symbols are not used outside it's driver so no need to make the symbol global. Signed-off-by: Axel Lin axel@gmail.com --- drivers/video/omap/lcd_ams_delta.c |2 +- drivers/video/omap/lcd_h3.c|2 +- drivers/video/omap/lcd_htcherald.c |2 +- drivers/video/omap

[PATCH 2/3] video: omap: convert drivers/video/omap/* to use module_platform_driver()

2011-12-08 Thread Axel Lin
...@gmail.com Signed-off-by: Axel Lin axel@gmail.com --- drivers/video/omap/lcd_ams_delta.c | 13 + drivers/video/omap/lcd_h3.c| 14 +- drivers/video/omap/lcd_htcherald.c | 14 +- drivers/video/omap/lcd_inn1510.c | 14 +- drivers

[PATCH] OMAP2, 3: DSS2: Include linux/delay.h and common.h to fix build errors

2011-11-30 Thread Axel Lin
/display.c: In function 'omap_dss_reset': arch/arm/mach-omap2/display.c:318: error: implicit declaration of function 'omap_test_timeout' make[1]: *** [arch/arm/mach-omap2/display.o] Error 1 make: *** [arch/arm/mach-omap2] Error 2 Signed-off-by: Axel Lin axel@gmail.com --- I got the build error

[PATCH RESEND] ARM: OMAP: omap_device: Include linux/export.h

2011-11-03 Thread Axel Lin
' arch/arm/plat-omap/omap_device.c:1055: warning: parameter names (without types) in function declaration Signed-off-by: Axel Lin axel@gmail.com --- This resend also CC linux-omap@vger.kernel.org and linux-arm-ker...@lists.infradead.org. This patch is against linux-next 2003. arch/arm/plat

[PATCH] ARM: OMAP2+: l3-noc: Include linux/module.h

2011-11-01 Thread Axel Lin
]: *** [arch/arm/mach-omap2/omap_l3_noc.o] Error 1 make: *** [arch/arm/mach-omap2] Error 2 Signed-off-by: Axel Lin axel@gmail.com --- I got the build error by make omap2plus_defconfig on linux-next 2001. arch/arm/mach-omap2/omap_l3_noc.c |1 + 1 files changed, 1 insertions(+), 0 deletions

[PATCH] ARM: OMAP: dmtimer: Include linux/module.h

2011-11-01 Thread Axel Lin
/plat-omap/dmtimer.o] Error 1 make: *** [arch/arm/plat-omap] Error 2 Signed-off-by: Axel Lin axel@gmail.com --- I got the build error by make omap2plus_defconfig on linux-next 2001. arch/arm/plat-omap/dmtimer.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm

[PATCH] usb: musb: OMAP4430: Remove a redundant omap4430_phy_init call in usb_musb_init

2011-09-20 Thread Axel Lin
: In function 'usb_musb_init': arch/arm/mach-omap2/usb-musb.c:141: warning: 'dev' may be used uninitialized in this function Signed-off-by: Axel Lin axel@gmail.com --- arch/arm/mach-omap2/usb-musb.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-omap2/usb-musb.c

[PATCH RESEND] omap1: select GENERIC_IRQ_CHIP for TI OMAP1

2011-08-03 Thread Axel Lin
Signed-off-by: Axel Lin axel@gmail.com --- Kevin already sent a similar patch. http://marc.info/?l=linux-omapm=130749135312468w=2 But I still have the build error with make omap1_defconfig in today's linux-next tree. So here is a resend. Regards, Axel arch/arm/plat-omap/Kconfig |1 + 1

Re: [PATCH] omap1: select GENERIC_IRQ_CHIP for TI OMAP1

2011-07-17 Thread Axel Lin
2011/6/28 Kevin Hilman khil...@ti.com: Axel Lin axel@gmail.com writes: The gpio-omap driver has been converted to use generic IRQ chip. Thus select GENERIC_IRQ_CHIP for TI OMAP1 to fix below build error.   LD      vmlinux drivers/built-in.o: In function `omap_mpuio_alloc_gc': drivers

[PATCH] omap1: select GENERIC_IRQ_CHIP for TI OMAP1

2011-06-28 Thread Axel Lin
Signed-off-by: Axel Lin axel@gmail.com --- arch/arm/plat-omap/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig index 49a4c75..9a4a6bf 100644 --- a/arch/arm/plat-omap/Kconfig +++ b/arch/arm/plat-omap/Kconfig

[PATCH] ARM: OMAP2: Add missing include of linux/gpio.h

2011-05-31 Thread Axel Lin
fixes the build error. Signed-off-by: Axel Lin axel@gmail.com Cc: Syed Mohammed Khasim x0kha...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Grazvydas Ignotas nota...@gmail.com Cc: Steve Sakoman st...@sakoman.com --- arch/arm/mach-omap2/board-2430sdp.c |1 + arch/arm/mach-omap2/board

[PATCH v2] ARM: OMAP2: Add missing include of linux/gpio.h

2011-05-31 Thread Axel Lin
in this function) arch/arm/mach-omap2/board-2430sdp.c:247: error: (Each undeclared identifier is reported only once arch/arm/mach-omap2/board-2430sdp.c:247: error: for each function it appears in.) This patch fixes the build error by include linux/gpio.h instead of mach/gpio.h. Signed-off-by: Axel Lin axel

Re: [PATCH v2] ARM: OMAP2: Add missing include of linux/gpio.h

2011-05-31 Thread Axel Lin
2011/5/31 Tony Lindgren t...@atomide.com: * Axel Lin axel@gmail.com [110531 05:51]: I got some build error like below while executing make omap2plus_defconfig.   CC      arch/arm/mach-omap2/board-2430sdp.o arch/arm/mach-omap2/board-2430sdp.c: In function 'omap_2430sdp_init': arch/arm

[PATCH 2/2 RESEND] ASoC: Fix resource reclaim for osk5912

2010-11-24 Thread Axel Lin
In current implementation, there are resources leak in the error path. This patch properly reclaims the allocated resources in the error path. Also adds a missing clk_put in osk_soc_exit. Signed-off-by: Axel Lin axel@gmail.com Acked-by: Jarkko Nikula jhnik...@gmail.com --- sound/soc/omap

[PATCH 1/2] ASoC: Return proper error for omap3pandora_soc_init

2010-11-23 Thread Axel Lin
Return PTR_ERR(omap3pandora_dac_reg) instead of 0 if regulator_get failed. Signed-off-by: Axel Lin axel@gmail.com --- sound/soc/omap/omap3pandora.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/sound/soc/omap/omap3pandora.c b/sound/soc/omap/omap3pandora.c index

[PATCH 2/2] ASoC: Fix resource reclaim for osk5912

2010-11-23 Thread Axel Lin
Signed-off-by: Axel Lin axel@gmail.com --- sound/soc/omap/osk5912.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/sound/soc/omap/osk5912.c b/sound/soc/omap/osk5912.c index 18d053d..7e75e77 100644 --- a/sound/soc/omap/osk5912.c +++ b/sound/soc/omap/osk5912