Re: [PATCH 01/51] DMA-API: provide a helper to set both DMA and coherent DMA masks

2013-09-19 Thread Ben Hutchings
to the same or a smaller mask than the streaming mask. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 1/1] drivers: net: cpsw: add support to show hw stats via ethtool

2013-07-22 Thread Ben Hutchings
. + cpsw_gstrings_stats[i].stat_offset); + data[i] = val; + break; [...] -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare

Re: [net-next PATCH 1/3] drivers: of: add phy fixup support in DT

2013-04-25 Thread Ben Hutchings
in general; a PHY may well require link tuning for a specific board. But the set of register addresses to program is likely to be known in advance and then only the values would belong in DT. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing

Re: [PATCH 1/3] driver: net: ethernet: cpsw: implement ethtool get/set phy setting

2013-03-08 Thread Ben Hutchings
On Fri, 2013-03-08 at 12:53 +0530, Mugunthan V N wrote: On 3/8/2013 1:29 AM, Ben Hutchings wrote: On Thu, 2013-03-07 at 14:24 +0100, Peter Korsgaard wrote: M == Mugunthan V N mugunthan...@ti.com writes: M This patch implements get/set of the phy settings via ethtool apis M Signed-off

Re: [PATCH 1/3] driver: net: ethernet: cpsw: implement ethtool get/set phy setting

2013-03-07 Thread Ben Hutchings
with the phy_id? Ben. It would be good if all these special things (dual emac mode, vlan handling, switching) could be handled using the existing kernel (bridging/vlan) infrastructure, and the driver always just exposing 2 network interfaces instead of these configuration properties. -- Ben

Build failure with DMA_OMAP=m and a caller built-in

2013-01-05 Thread Ben Hutchings
symbols to promote it to built-in if necessary. This sort of works but kconfig complains about the circular dependency and it becomes impossible to disable DMA_OMAP in the 'make nconfig' menu. So that's not the right thing to do. Any ideas? Ben. -- Ben Hutchings Sturgeon's Law: Ninety percent

Re: [PATCH 3/3] net: cpsw: implement ioctl for MII

2012-12-03 Thread Ben Hutchings
, + .ndo_do_ioctl = cpsw_ndo_do_ioctl, .ndo_change_mtu = eth_change_mtu, .ndo_tx_timeout = cpsw_ndo_tx_timeout, .ndo_get_stats = cpsw_ndo_get_stats, -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's

Re: [PATCH 4 2/4] NET ethernet introduce mac_platform helper

2012-07-06 Thread Ben Hutchings
; + } + + p -= len; [...] There are so many blank lines here, it's hard to see much code at once. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare

RE: [PATCH] net: davinci_emac: Add pre_open, post_stop platform callbacks

2012-05-03 Thread Ben Hutchings
necessary and then let the PM code take care of skipping the wfi execution. Thoughts/brickbats welcome :) You can maybe (ab)use the pm_qos mechanism for this. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us