Re: [RFC PATCH] gpio/omap: Fix IRQ handling for SPARSE_IRQ

2012-02-24 Thread Cousson, Benoit
On 2/24/2012 3:14 PM, Rob Herring wrote: On 02/23/2012 04:46 PM, Cousson, Benoit wrote: ... diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index bc2bd69..afef0f7 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c @@ -93,6 +93,11 @@ struct gpio_bank

Re: [PATCH 2/3] tty: serial: OMAP: block idle while the UART is transferring data in PIO mode

2012-02-24 Thread Cousson, Benoit
Salut Paul, On 2/21/2012 11:02 PM, Paul Walmsley wrote: Salut Benoît, On Mon, 20 Feb 2012, Cousson, Benoit wrote: 3.3-rc4 is broken in the DT case because of the serial driver. And it looks like it is due to this fix. We cannot rely on pdata anymore in DT, and in that case it leads to an

Re: [RFC PATCH] gpio/omap: Fix IRQ handling for SPARSE_IRQ

2012-02-24 Thread Cousson, Benoit
On 2/24/2012 2:53 PM, DebBarma, Tarun Kanti wrote: On Fri, Feb 24, 2012 at 7:02 PM, Cousson, Benoit wrote: On 2/24/2012 2:24 PM, DebBarma, Tarun Kanti wrote: Hi Benoit, On Fri, Feb 24, 2012 at 4:07 PM, DebBarma, Tarun Kanti wrote: On Fri, Feb 24, 2012 at 3:41 PM, Cousson, Benoit

Re: [RFC PATCH] gpio/omap: Fix IRQ handling for SPARSE_IRQ

2012-02-24 Thread Cousson, Benoit
On 2/24/2012 2:24 PM, DebBarma, Tarun Kanti wrote: Hi Benoit, On Fri, Feb 24, 2012 at 4:07 PM, DebBarma, Tarun Kanti wrote: On Fri, Feb 24, 2012 at 3:41 PM, Cousson, Benoit wrote: + Tarun On 2/24/2012 12:08 AM, Tony Lindgren wrote: * Cousson, Benoit[120223 14:14]: The GPIO driver

Re: [PATCH v2 1/4] mmc: omap_hsmmc: Convert hsmmc driver to use device tree

2012-02-24 Thread Cousson, Benoit
On 2/24/2012 1:58 PM, Rajendra Nayak wrote: On Friday 24 February 2012 06:21 PM, Cousson, Benoit wrote: On 2/24/2012 12:35 PM, Rajendra Nayak wrote: On Friday 24 February 2012 05:02 PM, T Krishnamoorthy, Balaji wrote: On Thu, Feb 23, 2012 at 5:31 PM, Rajendra Nayak wrote: ... +Required

Re: [PATCH v2 1/4] mmc: omap_hsmmc: Convert hsmmc driver to use device tree

2012-02-24 Thread Cousson, Benoit
On 2/24/2012 12:35 PM, Rajendra Nayak wrote: On Friday 24 February 2012 05:02 PM, T Krishnamoorthy, Balaji wrote: On Thu, Feb 23, 2012 at 5:31 PM, Rajendra Nayak wrote: Define dt bindings for the ti-omap-hsmmc, and adapt the driver to extract data (which was earlier passed as platform_data) fro

Re: [PATCH v2 4/4] arm/dts: OMAP3: Add mmc controller nodes and board data

2012-02-24 Thread Cousson, Benoit
On 2/24/2012 5:00 AM, Rajendra Nayak wrote: On Friday 24 February 2012 12:27 AM, Tony Lindgren wrote: --- a/arch/arm/boot/dts/omap3.dtsi +++ b/arch/arm/boot/dts/omap3.dtsi @@ -113,5 +113,31 @@ #size-cells =<0>; ti,hwmods = "i2c3"; }; + + mmc1: mmc@1 { + compatible = "ti,omap2-hsmmc"; + ti,hwmods

Re: [RFC PATCH 4/8] misc: emif: add basic infrastructure for EMIF driver

2012-02-24 Thread Cousson, Benoit
On 2/24/2012 12:10 PM, Aneesh V wrote: On Thursday 16 February 2012 10:00 PM, Cousson, Benoit wrote: Hi Aneesh, [...] +struct emif_data { + u8 duplicate; + u8 temperature_level; + u32 irq; + spinlock_t lock; /* lock to prevent races */ Nit: That comment is useless, since you already have

Re: [RFC PATCH] gpio/omap: Fix IRQ handling for SPARSE_IRQ

2012-02-24 Thread Cousson, Benoit
+ Tarun On 2/24/2012 12:08 AM, Tony Lindgren wrote: * Cousson, Benoit [120223 14:14]: The GPIO driver is still relying on internal OMAP IRQ defines that are not relevant anymore if OMAP is built with SPARSE_IRQ. Great :) Please note that this patch is still RFC, because I do not know how

[RFC PATCH] gpio/omap: Fix IRQ handling for SPARSE_IRQ

2012-02-23 Thread Cousson, Benoit
The GPIO driver is still relying on internal OMAP IRQ defines that are not relevant anymore if OMAP is built with SPARSE_IRQ. Replace the defines with the proper IRQ base number. Clean some comment style issue. Remove some hidden and ugly cpu_class_is_omap1() inside the gpio header. XXX: That fix

Re: [PATCH 5/6] ARM: OMAP4: suspend: Do not get dsp/tesla out of reset

2012-02-23 Thread Cousson, Benoit
On 2/23/2012 2:56 PM, Shilimkar, Santosh wrote: $Subject s/dsp/DSP s/tesla/TESLA Even better... remove tesla :-) This is an internal codename that at some point should be removed from the clkdm name. I just did not have the time to do that for OMAP4, but it will not exist anymore on OMAP5.

Re: [RFC PATCH 1/2] of: Add generic device tree DMA helpers

2012-02-23 Thread Cousson, Benoit
On 2/23/2012 4:51 PM, Nicolas Ferre wrote: On 02/23/2012 11:03 AM, Cousson, Benoit : Salut Nico, Coucou Benoit ;-) On 2/22/2012 11:59 AM, Nicolas Ferre wrote: On 01/27/2012 06:29 PM, Cousson, Benoit : Add some basic helpers to retrieve a DMA controller device_node and the DMA request line

Re: Questions about DSS device tree adaptation

2012-02-23 Thread Cousson, Benoit
Hi Tomi, On 2/22/2012 1:07 PM, Tomi Valkeinen wrote: Hi, I'd like to get some feedback for the DSS DT work. I have currently this in omap4.dtsi, under ocp. It's still a hack, for example there's sdi for testing even though omap4 doesn't have SDI output. dss { compatible = "ti,omap4-ds

Re: [RFC PATCH 1/2] of: Add generic device tree DMA helpers

2012-02-23 Thread Cousson, Benoit
Salut Nico, On 2/22/2012 11:59 AM, Nicolas Ferre wrote: On 01/27/2012 06:29 PM, Cousson, Benoit : Add some basic helpers to retrieve a DMA controller device_node and the DMA request line number. For legacy reason another API will export the DMA request number into a Linux resource of type

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2012-02-22 Thread Cousson, Benoit
On 2/22/2012 3:23 PM, Rob Herring wrote: On 02/15/2012 10:04 AM, Benoit Cousson wrote: Adapt the GPIO driver to retrieve information from a DT file. Allocate the irq_base dynamically and rename bank->virtual_irq_start to bank->irq_base. Change irq_base type to int instead of u16 to match irq_al

Re: [PATCH 2/3] tty: serial: OMAP: block idle while the UART is transferring data in PIO mode

2012-02-20 Thread Cousson, Benoit
+ Rajendra Hi Paul, 3.3-rc4 is broken in the DT case because of the serial driver. And it looks like it is due to this fix. We cannot rely on pdata anymore in DT, and in that case it leads to an Oops due to NULL pdata. [2.120605] Unable to handle kernel NULL pointer dereference at virtual

Re: [PATCH] ARM: OMAP: hsmmc: add max_freq field

2012-02-17 Thread Cousson, Benoit
On 2/17/2012 2:44 PM, Daniel Mack wrote: > ping? Could anyone care for queueing this please? There is no OMAP HSMMC dedicated maintainer anymore so I guess you should ping Chris Ball . Regards, Benoit -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a messa

Re: [PATCHv9 3/5] arm: omap3: add common twl configurations for vdd1 and vdd2

2012-02-17 Thread Cousson, Benoit
Hi Tero, On 2/17/2012 4:22 PM, Menon, Nishanth wrote: On Fri, Feb 17, 2012 at 05:06, Tero Kristo wrote: On Thu, 2012-02-16 at 12:23 -0600, Menon, Nishanth wrote: On Thu, Feb 16, 2012 at 04:27, Tero Kristo wrote: VDD1 and VDD2 are the core voltage regulators on OMAP3. VDD1 is used to control

Re: [RFC PATCH 4/8] misc: emif: add basic infrastructure for EMIF driver

2012-02-17 Thread Cousson, Benoit
Hi Aneesh, On 2/17/2012 2:26 PM, Aneesh V wrote: On Thursday 16 February 2012 10:00 PM, Cousson, Benoit wrote: On 2/4/2012 1:16 PM, Aneesh V wrote: [...] +/** + * struct emif_data - Per device static data for driver's use + * @duplicate: Whether the DDR devices attached to this

Re: [PATCH] ARM: OMAP2+: hwmod: Add new sysc_type3 into omap_hwmod required for am33xx

2012-02-17 Thread Cousson, Benoit
Hi Vaibhav, On 2/17/2012 1:24 PM, Vaibhav Hiremath wrote: In case of AM33xx family of devices (like cpsw) have different sysc bit field offsets defined, It is really used by several IPs, or it is just an unique exception? For an exception, you can just define the omap_hwmod_sysc_fields for t

[GIT PULL] ARM: OMAP: Miscellaneous DT cleanup for 3.4

2012-02-16 Thread Cousson, Benoit
Hi Tony, Here is a small cleanup series to prepare for further DT series for 3.4. Thanks, Benoit The following changes since commit d65b4e98d7ea3038b767b70fe8be959b2913f16d: Linus Torvalds (1): Linux 3.3-rc3 are available in the git repository at: git://git.kernel.org/pub/scm/linu

Re: [PATCH 2/3] ARM: OMAP2+: Split omap2_hsmmc_init() to properly support I2C GPIO pins

2012-02-16 Thread Cousson, Benoit
On 2/16/2012 5:35 PM, Tony Lindgren wrote: * Rajendra Nayak [120216 01:42]: On Thursday 16 February 2012 03:33 PM, Rajendra Nayak wrote: better still, I think we should just populate them statically in omap2_hsmmc_info struct above, so omap_hsmmc_init() takes care of it already. I just tried

Re: [RFC PATCH 4/8] misc: emif: add basic infrastructure for EMIF driver

2012-02-16 Thread Cousson, Benoit
Hi Aneesh, On 2/4/2012 1:16 PM, Aneesh V wrote: > EMIF is an SDRAM controller used in various Texas Instruments > SoCs. EMIF supports, based on its revision, one or more of > LPDDR2/DDR2/DDR3 protocols. > > Add the basic infrastructure for EMIF driver that includes > driver registration, probe, p

Re: [PATCH 1/4] ARM: OMAP2+: board-generic: Remove un-needed .atag_offset for DT_MACHINE

2012-02-16 Thread Cousson, Benoit
On 2/15/2012 7:13 PM, Tony Lindgren wrote: > * Cousson, Benoit [120215 04:43]: >> On 2/14/2012 8:52 PM, Tony Lindgren wrote: >>> * Benoit Cousson [120213 07:59]: >>>> Some .atag_offset entries were wrongly added during a merge conflict >>>> resolution i

Re: [PATCH v2] OMAPDSS: HACK: Ensure DSS clock domain gets out of idle when HDMI is enabled

2012-02-16 Thread Cousson, Benoit
On 2/16/2012 9:22 AM, Tomi Valkeinen wrote: On Wed, 2012-02-15 at 11:59 -0800, Kevin Hilman wrote: "Cousson, Benoit" writes: Kevin, Do we still need to set the dev.parent to omap_device_parent? Nope. I guess the default&platform_bus parent is good enough and poten

Re: [PATCH 1/5] gpio/omap: Remove bank->id information and misc cleanup

2012-02-16 Thread Cousson, Benoit
On 2/16/2012 6:53 AM, DebBarma, Tarun Kanti wrote: On Wed, Feb 15, 2012 at 9:34 PM, Benoit Cousson wrote: The driver does not need anymore any id to identify the GPIO instance. Remove every occurence of the bank->id inside the driver. Remove two trailing spaces. Add a dev variable for better r

Re: [PATCH 2/5] gpio/omap: Use devm_ API and add request_mem_region

2012-02-16 Thread Cousson, Benoit
On 2/16/2012 7:37 AM, Shubhrajyoti wrote: On Thursday 16 February 2012 11:11 AM, DebBarma, Tarun Kanti wrote: Hi Benoit, On Wed, Feb 15, 2012 at 9:34 PM, Benoit Cousson wrote: Replace the regular kzalloc and ioremap with the devm_ equivalent to simplify error handling. Add the missing devm_r

Re: [PATCH 1/4] spi/omap: Add DT support to McSPI driver

2012-02-15 Thread Cousson, Benoit
On 2/15/2012 8:34 PM, Rob Herring wrote: On 02/15/2012 11:37 AM, Benoit Cousson wrote: Add device tree support to the OMAP2+ McSPI driver. Add the bindings documentation. Based on original code from Rajendra. Signed-off-by: Benoit Cousson Cc: Grant Likely Cc: Rajendra Nayak --- Documentation

Re: [PATCH 2/4] arm/dts: OMAP4: Add SPI controller nodes

2012-02-15 Thread Cousson, Benoit
On 2/15/2012 9:02 PM, Grant Likely wrote: On Wed, Feb 15, 2012 at 06:37:35PM +0100, Benoit Cousson wrote: Add the 4 McSPI controller nodes present in an OMAP4 device. Remove SPI static device initialisation if DT is populated. Signed-off-by: Benoit Cousson Cc: Grant Likely --- arch/arm/boot/

Re: [PATCH v3 2/4] ARM: OMAP2/3: intc: Add DT support for TI interrupt controller

2012-02-15 Thread Cousson, Benoit
On 2/14/2012 9:52 PM, Grant Likely wrote: On Tue, Feb 14, 2012 at 06:56:10PM +0100, Benoit Cousson wrote: Add a function to initialize the OMAP2/3 interrupt controller (INTC) using a device tree node. This version take advantage of the new irq_domain_add_legacy API. Replace some printk() with

Re: [PATCH 1/4] ARM: OMAP2+: board-generic: Remove un-needed .atag_offset for DT_MACHINE

2012-02-15 Thread Cousson, Benoit
On 2/14/2012 8:52 PM, Tony Lindgren wrote: * Benoit Cousson [120213 07:59]: Some .atag_offset entries were wrongly added during a merge conflict resolution in 3.3. Remove them all, since DT boot does not use that attribute anymore. Replace as well the #if... by #ifdef for consistency. How ab

Re: [PATCH v3 2/4] ARM: OMAP2/3: intc: Add DT support for TI interrupt controller

2012-02-15 Thread Cousson, Benoit
On 2/14/2012 8:48 PM, Rob Herring wrote: On 02/14/2012 11:56 AM, Benoit Cousson wrote: Add a function to initialize the OMAP2/3 interrupt controller (INTC) using a device tree node. This version take advantage of the new irq_domain_add_legacy API. Replace some printk() with the proper pr_ macr

Re: [PATCH v2] OMAPDSS: HACK: Ensure DSS clock domain gets out of idle when HDMI is enabled

2012-02-15 Thread Cousson, Benoit
+ Kevin On 2/15/2012 1:51 PM, Tomi Valkeinen wrote: On Wed, 2012-02-15 at 13:35 +0100, Cousson, Benoit wrote: I think that changing the device creation to change the dev->parent should be pretty straightforward. That's not possible with the current kernel, right? We are n

Re: [PATCH v2] OMAPDSS: HACK: Ensure DSS clock domain gets out of idle when HDMI is enabled

2012-02-15 Thread Cousson, Benoit
On 2/15/2012 1:01 PM, Archit Taneja wrote: On Tuesday 14 February 2012 09:11 PM, Cousson, Benoit wrote: On 2/14/2012 2:30 PM, Archit Taneja wrote: Hi, On Tuesday 14 February 2012 06:45 PM, Tomi Valkeinen wrote: On Tue, 2012-02-14 at 13:58 +0100, Cousson, Benoit wrote: Hi Tomi, Benoit, do

Re: [PATCH v2] OMAPDSS: HACK: Ensure DSS clock domain gets out of idle when HDMI is enabled

2012-02-14 Thread Cousson, Benoit
On 2/14/2012 2:45 PM, Archit Taneja wrote: On Tuesday 14 February 2012 07:03 PM, Tomi Valkeinen wrote: On Tue, 2012-02-14 at 19:00 +0530, Archit Taneja wrote: Hi, On Tuesday 14 February 2012 06:45 PM, Tomi Valkeinen wrote: On Tue, 2012-02-14 at 13:58 +0100, Cousson, Benoit wrote: Hi Tomi

Re: [PATCH v2] OMAPDSS: HACK: Ensure DSS clock domain gets out of idle when HDMI is enabled

2012-02-14 Thread Cousson, Benoit
On 2/14/2012 2:30 PM, Archit Taneja wrote: Hi, On Tuesday 14 February 2012 06:45 PM, Tomi Valkeinen wrote: On Tue, 2012-02-14 at 13:58 +0100, Cousson, Benoit wrote: Hi Tomi, Benoit, do you think we'll get the MODULEMODE mess cleaned up in the hwmod/clk framework at some point, an

Re: [PATCH v2] OMAPDSS: HACK: Ensure DSS clock domain gets out of idle when HDMI is enabled

2012-02-14 Thread Cousson, Benoit
Hi Tomi, On 2/14/2012 12:57 PM, Tomi Valkeinen wrote: Hi, On Fri, 2012-02-10 at 11:45 +0530, Archit Taneja wrote: For DSS clock domain to transition from idle to active state. It's necessary to enable the optional clock DSS_FCLK before we enable the module using the MODULEMODE bits in the cloc

Re: OMAP DSS warning in apply.c

2012-02-14 Thread Cousson, Benoit
+ Tomi On 2/14/2012 1:06 PM, Russell King - ARM Linux wrote: kautobuildv2 discovered this in its omap4430sdp oldconfig build: drivers/video/omap2/dss/apply.c:350: warning: 'wait_pending_extra_info_updates' defined but not used This looks like a valid warning, because wait_pending_extra_info_u

Re: GPMC in HWMOD (and a related AM335X issue)

2012-02-09 Thread Cousson, Benoit
Hi Mohammed, On 2/9/2012 1:29 PM, Afzal Mohammed wrote: Hi, OMAP HWMOD currently does not have GPMC adapted to it. We are facing a problem indirectly related to it in the case of AM335X SoC. It can reuse GPMC code of OMAP except that base address & IRQ# is different. But we get a kernel crash

Re: [PATCH] ARM: OMAP2+: Fix prm2xxx_3xxx.c INT_34XX_PRCM_MPU_IRQ build error

2012-02-09 Thread Cousson, Benoit
On 2/9/2012 8:15 PM, Russell King - ARM Linux wrote: On Thu, Feb 09, 2012 at 08:01:09PM +0100, Cousson, Benoit wrote: If CONFIG_OF is not defined, the following error will happen. arch/arm/mach-omap2/prm2xxx_3xxx.c:41:11: error: ‘INT_34XX_PRCM_MPU_IRQ’ undeclared here (not in a function

[PATCH] ARM: OMAP2+: Fix prm2xxx_3xxx.c INT_34XX_PRCM_MPU_IRQ build error

2012-02-09 Thread Cousson, Benoit
If CONFIG_OF is not defined, the following error will happen. arch/arm/mach-omap2/prm2xxx_3xxx.c:41:11: error: ‘INT_34XX_PRCM_MPU_IRQ’ undeclared here (not in a function) This is due to some hidden headers path from linux/of.h to plat/irqs.h already reported by Russell for prm4xxx.c. Add the #i

Re: [PATCH 04/16] ARM: omap: fix prm44xx.c OMAP44XX_IRQ_PRCM build error

2012-02-09 Thread Cousson, Benoit
Hi Tony, On 2/8/2012 7:39 PM, Tony Lindgren wrote: > * Russell King - ARM Linux [120208 08:06]: >> arch/arm/mach-omap2/prm44xx.c:41: error: 'OMAP44XX_IRQ_PRCM' undeclared here >> (not in a function) > > Can you please add something like "This happens when CONFIG_OF is > not selected". > >> Sig

Re: OMAP34xx

2012-02-08 Thread Cousson, Benoit
On 2/7/2012 9:41 AM, Russell King - ARM Linux wrote: On Tue, Feb 07, 2012 at 01:54:57AM +0100, Cousson, Benoit wrote: Hi Russell, On 2/7/2012 1:24 AM, Russell King - ARM Linux wrote: On Tue, Feb 07, 2012 at 12:19:50AM +0100, Cousson, Benoit wrote: In theory that patch should not be even

Re: OMAP34xx

2012-02-08 Thread Cousson, Benoit
Hi Mark, On 2/7/2012 6:28 PM, Mark Brown wrote: On Tue, Feb 07, 2012 at 12:19:50AM +0100, Cousson, Benoit wrote: The twl changes were done like that because it was assuming that USE_OF and thus IRQ_DOMAIN will be enabled by default for all OMAP2+ platforms at 3.3 time. The whole point of

Re: [PATCH] I2C: OMAP: fix build breakage when CONFIG_OF is not set

2012-02-08 Thread Cousson, Benoit
Hi Luca, On 2/8/2012 12:25 PM, Luciano Coelho wrote: On Wed, 2012-02-08 at 16:42 +0530, Shubhrajyoti Datta wrote: On Wed, Feb 8, 2012 at 4:34 PM, Luciano Coelho wrote: On Wed, 2012-02-08 at 12:59 +0200, Felipe Balbi wrote: On Wed, Feb 08, 2012 at 12:56:52PM +0200, Luciano Coelho wrote: Sinc

Re: OMAP34xx

2012-02-06 Thread Cousson, Benoit
On 2/7/2012 5:35 AM, Grant Likely wrote: On Mon, Feb 6, 2012 at 5:24 PM, Russell King - ARM Linux wrote: On Tue, Feb 07, 2012 at 12:19:50AM +0100, Cousson, Benoit wrote: In theory that patch should not be even needed. In theory that change is needed to fix the obviously broken code which

Re: OMAP34xx

2012-02-06 Thread Cousson, Benoit
Hi Russell, On 2/7/2012 1:24 AM, Russell King - ARM Linux wrote: On Tue, Feb 07, 2012 at 12:19:50AM +0100, Cousson, Benoit wrote: In theory that patch should not be even needed. In theory that change is needed to fix the obviously broken code which is there at the moment. Well, both

Re: OMAP34xx

2012-02-06 Thread Cousson, Benoit
+ Grant and Rob Hi Tony, On 2/5/2012 6:29 PM, Tony Lindgren wrote: [...] >> --- a/drivers/mfd/Kconfig >> +++ b/drivers/mfd/Kconfig >> @@ -200,7 +200,7 @@ config MENELAUS >> >> config TWL4030_CORE >> bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0 Support" >> -depends on I2C=

Re: [PATCH v9 01/25] gpio/omap: remove dependency on gpio_bank_count

2012-02-02 Thread Cousson, Benoit
On 2/2/2012 10:53 PM, Felipe Balbi wrote: Hi again, On Thu, Feb 02, 2012 at 11:49:08PM +0200, Felipe Balbi wrote: In fact the driver already handled the 6 GPIOS banks as individual devices: [0.185638] gpiochip_add: registered GPIOs 0 to 31 on device: gpio [0.185882] OMAP GPIO hardware

Re: [PATCH v9 01/25] gpio/omap: remove dependency on gpio_bank_count

2012-02-02 Thread Cousson, Benoit
On 2/2/2012 8:45 PM, Felipe Balbi wrote: On Thu, Feb 02, 2012 at 12:16:30PM -0700, Grant Likely wrote: On Thu, Feb 02, 2012 at 08:41:07PM +0200, Felipe Balbi wrote: Hi, On Thu, Feb 02, 2012 at 11:00:27PM +0530, Tarun Kanti DebBarma wrote: diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/g

Re: [PATCH] arm/dts: OMAP3: Add omap3evm and am335xevm support

2012-02-02 Thread Cousson, Benoit
Hi Vaibhav, On 2/2/2012 10:34 AM, Hiremath, Vaibhav wrote: On Thu, Feb 02, 2012 at 10:26:29, Grant Likely wrote: On Wed, Feb 01, 2012 at 11:57:00AM +0530, Vaibhav Hiremath wrote: TI's OMAP3EVM and AM335xEVM are software development boards available for OMAP35x(AM/DM37x) and AM335x devices resp

Re: [RFC PATCH 1/2] of: Add generic device tree DMA helpers

2012-02-02 Thread Cousson, Benoit
On 2/2/2012 9:45 AM, Russell King - ARM Linux wrote: > On Wed, Feb 01, 2012 at 11:50:30AM +0100, Cousson, Benoit wrote: >> Hi Russell, >> >> On 2/1/2012 12:09 AM, Russell King - ARM Linux wrote: >>> On Sat, Jan 28, 2012 at 11:06:02AM -0700, Grant Likely wrote: >&

Re: [RFC PATCH 1/2] of: Add generic device tree DMA helpers

2012-02-01 Thread Cousson, Benoit
Hi Russell, On 2/1/2012 12:09 AM, Russell King - ARM Linux wrote: On Sat, Jan 28, 2012 at 11:06:02AM -0700, Grant Likely wrote: This makes the assumption that dma specifiers will only ever be 1 cell. I think to be generally useful, the full dma specifier needs to be either handed to the dma co

Re: [RFC PATCH 1/2] of: Add generic device tree DMA helpers

2012-01-31 Thread Cousson, Benoit
Hi Grant, On 1/28/2012 7:06 PM, Grant Likely wrote: On Fri, Jan 27, 2012 at 06:29:22PM +0100, Cousson, Benoit wrote: Add some basic helpers to retrieve a DMA controller device_node and the DMA request line number. For legacy reason another API will export the DMA request number into a Linux

Re: [PATCH 0/7] ARM: OMAP2+: hwmod/timer: first set of cleanups for 3.4

2012-01-31 Thread Cousson, Benoit
On 1/31/2012 9:14 AM, Paul Walmsley wrote: Hi On Tue, 31 Jan 2012, Cousson, Benoit wrote: Thanks to the L3 log error: [0.838439] L3 custom error: MASTER:DucatiM3 TARGET:GPMC I guess that I understand why I was not releasing the hardreset at boot time before:-) DSP and CortexM3 cannot be

Re: [PATCH 0/7] ARM: OMAP2+: hwmod/timer: first set of cleanups for 3.4

2012-01-31 Thread Cousson, Benoit
Hi Kevin and Paul, On 1/31/2012 12:14 AM, Kevin Hilman wrote: Hi Paul, Paul Walmsley writes: This series does some cleanup and documentation on the OMAP hwmod code (and a bit of the OMAP4 data) and timer code. It is the first prerequisite series to removing a big chunk of hwmod data -- that

Re: [RFC PATCH 1/2] of: Add generic device tree DMA helpers

2012-01-27 Thread Cousson, Benoit
On 1/27/2012 7:13 PM, Stephen Warren wrote: Cousson, Benoit wrote at Friday, January 27, 2012 10:29 AM: Add some basic helpers to retrieve a DMA controller device_node and the DMA request line number. For legacy reason another API will export the DMA request number into a Linux resource of

[RFC PATCH 2/2] arm/dts: OMAP4: Add dma-controller and dma-request for I2C

2012-01-27 Thread Cousson, Benoit
Add the DMA controller node. Add the dma-request attributes for the OMAP4 I2C controllers. Signed-off-by: Benoit Cousson Cc: Grant Likely Cc: Rob Herring --- arch/arm/boot/dts/omap4.dtsi | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/

[RFC PATCH 1/2] of: Add generic device tree DMA helpers

2012-01-27 Thread Cousson, Benoit
Add some basic helpers to retrieve a DMA controller device_node and the DMA request line number. For legacy reason another API will export the DMA request number into a Linux resource of type IORESOURCE_DMA. This API is usable only on system with an unique DMA controller. Signed-off-by: Benoit Co

[RFC PATCH 0/2] Generic DMA bindings helpers for Device Tree

2012-01-27 Thread Cousson, Benoit
Hi All, Here is a first RFC to introduce a generic binding for DMA controller and DMA request along with a couple of basic helpers functions. The support is very limited since the a lot of DMA controllers in ARM SoCs are far for being adapted to dmaengine. At least this is the case for OMAP. It

Re: [PATCH] OMAP4: Clock: Force a DPLL clkdm/pwrdm ON before a relock

2012-01-25 Thread Cousson, Benoit
Hi Paul, On 1/25/2012 8:05 PM, Paul Walmsley wrote: Hi On Tue, 24 Jan 2012, Palande, Ameya wrote: Any update on this? Looks good to me, but have the scripts been updated? Nope. The clkdm was never populated for DPLL in OMAP4 so far. We will have to add that extra parameters to every DPLL

Re: [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL

2012-01-25 Thread Cousson, Benoit
Hi Paul, On 1/25/2012 8:05 PM, Paul Walmsley wrote: Hi one important question first: On Tue, 24 Jan 2012, Ameya Palande wrote: According to OMAP4 TRM Table 3-1183, CM_CLKSEL_DPLL_USB register defines following fields for multiplication and division factors: DPLL_MULT (bits 19:8) DPLL multip

Re: [PATCH 05/21] Revert "OMAP3+: PM: SR: add suspend/resume handlers"

2012-01-25 Thread Cousson, Benoit
On 1/25/2012 7:13 PM, Jean Pihet wrote: Hi Benoit, On Wed, Jan 25, 2012 at 6:53 PM, Cousson, Benoit wrote: Salut Jean, On 1/25/2012 4:16 PM, Jean Pihet wrote: From: Nishanth Menon This reverts commit b6be18f0bab68ed304ebbb2d787d1c36237eda62. That weird, because you revert a patch you

Re: [PATCH 05/21] Revert "OMAP3+: PM: SR: add suspend/resume handlers"

2012-01-25 Thread Cousson, Benoit
Salut Jean, On 1/25/2012 4:16 PM, Jean Pihet wrote: From: Nishanth Menon This reverts commit b6be18f0bab68ed304ebbb2d787d1c36237eda62. That weird, because you revert a patch you introduced just before: [PATCH 03/21] OMAP3+: PM: SR: add suspend/resume handlers Moreover this commit id is not r

Re: [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL

2012-01-24 Thread Cousson, Benoit
+ Mike On 1/19/2012 12:39 AM, Ameya Palande wrote: Signed-off-by: Ameya Palande Assuming that you will re-send with Kevin's comment taken into account, the fix is indeed very valid. Acked-by: Benoit Cousson --- arch/arm/mach-omap2/clock44xx_data.c |4 ++-- 1 files changed, 2 inser

Re: [PATCH 1/2] omap2+: add drm device

2012-01-23 Thread Cousson, Benoit
Hi Rob, On 1/13/2012 9:41 PM, Rob Clark wrote: From: Rob Clark [...] +static int __init omap_init_gpu(void) Why is the function to init drm device is named gpu? +{ + struct omap_hwmod *oh = NULL; + + /* lookup and populate the DMM information, if present - OMAP4+ */ + o

Re: [PATCH] arm/dts: omap3-evm: Add i2c and twl4030 support

2012-01-23 Thread Cousson, Benoit
Hi Vaibhav, On 1/23/2012 9:49 AM, Hiremath, Vaibhav wrote: On Wed, Jan 18, 2012 at 12:25:39, Hiremath, Vaibhav wrote: Add support for TWL4030, which is interfaced on i2c1 bus. Also add clock frequencies for other i2c instances(2& 3) required for client-device exist on OMAP3EVM board. Signed-o

Re: [PATCH 3/3] ARM: OMAP: I2C: fix compilation when !CONFIG_OF

2012-01-22 Thread Cousson, Benoit
On 1/22/2012 5:06 PM, Rob Herring wrote: On 01/22/2012 09:45 AM, Grant Likely wrote: On Sun, Jan 22, 2012 at 04:02:33AM -0700, Paul Walmsley wrote: Commit 6145197be6cc0583fa1a2f4ec1079d366137061e ("i2c: OMAP: Add DT support for i2c controller") breaks compilation when CONFIG_OF is not defined:

[PATCH] i2c: OMAP: Fix OMAP1 build error

2012-01-20 Thread Cousson, Benoit
CONFIG_OF is not defined for OMAP1 yet and thus the omap1_defconfig build generate an error for 3.3-rc1. drivers/i2c/busses/i2c-omap.c: In function 'omap_i2c_probe': drivers/i2c/busses/i2c-omap.c:1021:26: error: 'omap_i2c_of_match' undeclared (first use in this function) drivers/i2c/busses/i2c-om

Re: omap clocksource timer selection: dmtimer OR 32K-Sync timer

2012-01-13 Thread Cousson, Benoit
On 1/13/2012 4:52 PM, Hiremath, Vaibhav wrote: On Fri, Jan 13, 2012 at 20:49:35, Cousson, Benoit wrote: [...] A series was sent to do that by Felipe last year, but we somehow forgot to rebase it on newer kernel and thus never reposted it. If you are ok, I can help you here. Thanks it

Re: omap clocksource timer selection: dmtimer OR 32K-Sync timer

2012-01-13 Thread Cousson, Benoit
On 1/13/2012 1:21 PM, Hiremath, Vaibhav wrote: Hi, In case of AM33xx family of devices, we do not have 32K Sync timer (32K Counter) available; and the current implementation is based on compile-time option, where clock-source is chosen by something like, File - arch/arm/mach-omap2/timer.c #ifd

Re: [PATCH v2 4/5] arm/dts: OMAP3: Add interrupt-controller bindings for INTC

2012-01-13 Thread Cousson, Benoit
On 1/13/2012 1:31 PM, Hiremath, Vaibhav wrote: On Fri, Jan 13, 2012 at 16:33:07, Cousson, Benoit wrote: Hi Vaibhav, On 1/13/2012 7:14 AM, Hiremath, Vaibhav wrote: On Tue, Dec 20, 2011 at 19:09:57, Cousson, Benoit wrote: [...] +++ b/arch/arm/boot/dts/omap3.dtsi @@ -54,10 +54,12

Re: [PATCH v2 4/5] arm/dts: OMAP3: Add interrupt-controller bindings for INTC

2012-01-13 Thread Cousson, Benoit
Hi Vaibhav, On 1/13/2012 7:14 AM, Hiremath, Vaibhav wrote: On Tue, Dec 20, 2011 at 19:09:57, Cousson, Benoit wrote: [...] +++ b/arch/arm/boot/dts/omap3.dtsi @@ -54,10 +54,12 @@ ranges; ti,hwmods = "l3_main"; - intc: interrupt-co

Re: [PATCHv8 4/5] OMAP: I2C: Remove the reset in the init path

2012-01-12 Thread Cousson, Benoit
On 1/11/2012 4:22 PM, Paul Walmsley wrote: On Wed, 11 Jan 2012, Cousson, Benoit wrote: Something that puzzle me on that point is most architecture does not use plateform_device and thus does not have any pdata to hack some custom function pointers here an there. It means that there is probably

Re: [PATCHv8 4/5] OMAP: I2C: Remove the reset in the init path

2012-01-11 Thread Cousson, Benoit
On 1/11/2012 2:29 PM, Paul Walmsley wrote: On Wed, 11 Jan 2012, Shubhrajyoti wrote: On Tuesday 10 January 2012 08:56 PM, Kevin Hilman wrote: "Datta, Shubhrajyoti" writes: On Tue, Jan 10, 2012 at 11:53 AM, Datta, Shubhrajyoti wrote: On Fri, Dec 16, 2011 at 2:29 PM, Shubhrajyoti wrote:

Re: [PATCH v2 09/10] arm/dts: omap3-beagle: Add twl4030 and i2c EEPROM

2012-01-10 Thread Cousson, Benoit
On 1/10/2012 12:24 AM, Tabi Timur-B04825 wrote: On Fri, Dec 9, 2011 at 8:02 AM, Benoit Cousson wrote: + eeprom@50 { + compatible = "ti,eeprom"; + reg =<0x50>; + }; Why is this "ti,"? For EDID, isn't the I2C device actually on the monitor itself, and D

[GIT PULL] ARM: OMAP3+: Add DT support for i2c, twl6030 and EVM

2012-01-09 Thread Cousson, Benoit
Hi Tony, If this is not too late, could you please pull the various OMAP device tree patches? This series assume that all the drivers adaptation to DT are already merged and is based on my previous interrupt controller series. It means it has a strong dependency with i2c tree, mfd tree and rtc

[GIT PULL] ARM: OMAP2+: Interrupt controllers adaptation to DT

2012-01-09 Thread Cousson, Benoit
Hi Tony, If this is not too late, could you please pull the OMAP interrupt controllers adaptation to device tree? This series is based on your lo/dt branch to get the DTS and board cleanup. Thanks, Benoit The following changes since commit 40c0591f0a349ec074357e05c6ab1a3bc951807c: Benoit Co

Re: [PATCH v2 1/5] arm/dts: OMAP4: Update DTS file with new GIC bindings

2012-01-09 Thread Cousson, Benoit
On 1/6/2012 10:30 PM, Rob Herring wrote: > On 01/06/2012 03:15 PM, Grant Likely wrote: >> On Tue, Dec 20, 2011 at 02:39:54PM +0100, Benoit Cousson wrote: >>> The GIC binding was updated in 3.2 and expect 3 interrupt-cells. >>> - Update the #interrupt-cells >>> - interrupt-parent seems to be needed

Re: [PATCH v2 2/5] ARM: OMAP2/3: intc: Add irqdomain support

2012-01-09 Thread Cousson, Benoit
Hi Grant, On 1/6/2012 10:22 PM, Grant Likely wrote: On Tue, Dec 20, 2011 at 02:39:55PM +0100, Benoit Cousson wrote: [...] + /* +* XXX: Use a 0 irq_base for the moment since the legacy devices +* created statically are expected a hwirq = irq mapping. +* A proper

Re: [PATCH] irqdomain: Initialize number of IRQs for simple domains

2012-01-06 Thread Cousson, Benoit
Hi Thierry, On 1/6/2012 3:28 PM, Thierry Reding wrote: The irq_domain_add() function needs the number of interrupts in the domain to properly initialize them. In addition the allocated domain is now returned by the irq_domain_{add,generate}_simple() helpers. [...] diff --git a/arch/arm/mach-

Re: [PATCH v2 0/5] ARM: OMAP2+: Interrupt controllers adaptation to DT

2012-01-06 Thread Cousson, Benoit
Hi Rob/Grant, Gentle ping on that series too. This should the last one:-) Thanks, Benoit On 12/23/2011 10:46 AM, Cousson, Benoit wrote: Hi Rob, Are you OK with that update? Thanks, Benoit On 12/20/2011 2:39 PM, Benoit Cousson wrote: Hi Tony and Rob, Here is the series to take advantage

Re: [PATCH 1/3] ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems

2012-01-06 Thread Cousson, Benoit
On 1/4/2012 9:11 PM, Grant Likely wrote: On Tue, Dec 6, 2011 at 9:49 AM, Benoit Cousson wrote: devicetree will become the mandatory boot method for OMAP2+. In order to avoid cluttering the OMAP code with #ifdef CONFIG_OF, select USE_OF by default for every OMAP2+ systems. Select as well the APP

Re: [PATCH-V1] arm/dts: Add support for TI OMAP3 EVM board

2012-01-05 Thread Cousson, Benoit
Hi Vaibhav, On 1/5/2012 12:18 PM, Hiremath, Vaibhav wrote: From: Hiremath, Vaibhav Sent: Friday, December 16, 2011 12:36 PM To: linux-omap@vger.kernel.org Cc: t...@atomide.com; linux-arm-ker...@lists.infradead.org; devicetree- disc...@lists.ozlabs.org; grant.lik...@secretlab.ca; Cousson, Benoit

Re: [PATCH v2 03/10] mfd: twl-core: Add initial DT support for twl4030/twl6030

2012-01-05 Thread Cousson, Benoit
Hi Grant, On 1/4/2012 7:12 PM, Grant Likely wrote: On Fri, Dec 09, 2011 at 03:02:34PM +0100, Benoit Cousson wrote: [...] @@ -1183,22 +1187,53 @@ twl_probe(struct i2c_client *client, const struct i2c_device_id *id) int status; unsigned

Re: [PATCH 3/3] of/irq: Add interrupts-names property to name an irq resource

2012-01-04 Thread Cousson, Benoit
Hi Grant, On 1/4/2012 8:17 AM, Grant Likely wrote: On Mon, Dec 05, 2011 at 03:23:56PM +0100, Benoit Cousson wrote: In a HW system, resources in general have name to identify them. The is the case as well for IORESOURCE_IRQ resources filled by DT "interrupts" entries. The current DT mechanism is

Re: [PATCH v2 02/10] i2c: OMAP: Add DT support for i2c controller

2012-01-04 Thread Cousson, Benoit
Hi Kevin, On 12/14/2011 2:06 AM, Kevin Hilman wrote: Benoit Cousson writes: Add initial DT support to retrieve the frequency using a DT attribute instead of the pdata pointer if of_node exist. Add documentation for omap i2c controller binding. Based on original patches from Manju and Grant.

Re: [PATCH 1/3] of/base: Take NULL string into account for property with multiple strings

2012-01-03 Thread Cousson, Benoit
Hi Grant, On 12/19/2011 3:02 PM, Rob Herring wrote: On 12/05/2011 08:23 AM, Benoit Cousson wrote: The current implementation just ignore any NULL string inserted in a multiple strings property. In some cases we can have a property with a fix number of strings but not necessarily used, like for

Re: [PATCH v4 03/12] mfd: twl-core: Add initial DT support for twl4030/twl6030

2012-01-03 Thread Cousson, Benoit
On 1/2/2012 10:04 AM, Grant Likely wrote: > On Thu, Dec 22, 2011 at 03:56:37PM +0100, Benoit Cousson wrote: >> Add initial device-tree support for twl familly chips. >> The current version is missing the regulator entries due >> to the lack of DT regulator bindings for the moment. >> Only the simpl

Re: [PATCH v2 0/5] ARM: OMAP2+: Interrupt controllers adaptation to DT

2011-12-23 Thread Cousson, Benoit
Hi Rob, Are you OK with that update? Thanks, Benoit On 12/20/2011 2:39 PM, Benoit Cousson wrote: Hi Tony and Rob, Here is the series to take advantage of the new DT interrupt init mechanism. Thanks to Marc's CONFIG_MULTI_IRQ_HANDLER series, OMAP4 just has to use the default GIC binding and do

Re: [PATCH v3 00/11] OMAP4: Add DT support for i2c and twl6030

2011-12-23 Thread Cousson, Benoit
On 12/22/2011 4:07 PM, Rob Herring wrote: For the series: Acked-by: Rob Herring Thanks Rob. Regards, Benoit -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-

Re: [QUESTION] How to set static/dynamic dependency between clock domains

2011-12-23 Thread Cousson, Benoit
Hi Santosh, On 12/23/2011 9:45 AM, Shilimkar, Santosh wrote: On Fri, Dec 23, 2011 at 2:00 PM, Ming Lei wrote: [...] The only change on iss(CAM) clock domain setting in your commit[1] is to configure CLKTRCTRL as HW_AUTO, instead of previous SW_WKUP. Once I change flags of iss to CLKDM_CAN_

Re: [PATCH v3 02/11] i2c: OMAP: Add DT support for i2c controller

2011-12-22 Thread Cousson, Benoit
Hi Olof, On 12/20/2011 10:24 PM, Olof Johansson wrote: Hi, On Tue, Dec 20, 2011 at 8:27 AM, Benoit Cousson wrote: diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index a43d002..dcbc1ec 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @

Re: [PATCH v3 02/11] i2c: OMAP: Add DT support for i2c controller

2011-12-22 Thread Cousson, Benoit
Hi Rob, On 12/20/2011 5:42 PM, Rob Herring wrote: On 12/20/2011 10:27 AM, Benoit Cousson wrote: Add initial DT support to retrieve the frequency using a DT attribute instead of the pdata pointer if of_node exist. Add documentation for omap i2c controller binding. Based on original patches fro

Re: [PATCH v2 04/10] rtc: rtc-twl: Add DT support for RTC inside twl4030/twl6030

2011-12-20 Thread Cousson, Benoit
Hi Andrew, I've never got any feedback on this patch from Alessandro and it seems that you took care of some rtc stuff recently. Thanks in advance, Benoit On 12/9/2011 3:02 PM, Benoit Cousson wrote: Add the DT support for the TI rtc-twl present in the twl4030 and twl6030 devices. Signed-off-b

Re: [PATCH 3/3] ARM: OMAP2+: board-generic: Replace #if defined by #ifdef for consistency

2011-12-20 Thread Cousson, Benoit
Hi Tony, What about that patch? This is the only one that is missing in lo. I know it is not a big deal, but it will make things a little bit cleaner. Thanks, Benoit On 12/6/2011 5:49 PM, Benoit Cousson wrote: The file contains a mix of #ifdef and #if defined(). Replace the #if... by #ifdef.

Re: [RFC v2 PATCH 0/3] dt: device tree bindings and data for EMIF and DDR

2011-12-20 Thread Cousson, Benoit
Hi Aneesh, On 12/20/2011 11:44 AM, Aneesh V wrote: On Tuesday 20 December 2011 05:05 AM, Tony Lindgren wrote: * Rob Herring [111219 14:29]: On 12/19/2011 08:05 AM, Aneesh V wrote: This is an RFC to add new device tree bindings for DDR memories and EMIF - TI's DDR SDRAM controller. The first

Re: [PATCH v2 04/10] rtc: rtc-twl: Add DT support for RTC inside twl4030/twl6030

2011-12-19 Thread Cousson, Benoit
Hi Alessandro, Gentle ping on this patch. Thanks, Benoit On 12/9/2011 3:02 PM, Benoit Cousson wrote: Add the DT support for the TI rtc-twl present in the twl4030 and twl6030 devices. Signed-off-by: Benoit Cousson Cc: Alessandro Zummo --- Documentation/devicetree/bindings/rtc/twl-rtc.txt |

Re: [GIT PULL] ARM: OMAP: I2C: prepare to use hwmod reset in driver

2011-12-19 Thread Cousson, Benoit
Hi Shubhro, On 12/18/2011 9:01 AM, Shubhrajyoti wrote: [...] The driver does a reset in the error path. Since we are not supposed to access the sysc reg the function is needed. I'm just wondering what will happen to the driver if this callback is not provided during the device creation? Thi

Re: [PATCH v2 03/10] mfd: twl-core: Add initial DT support for twl4030/twl6030

2011-12-19 Thread Cousson, Benoit
Salut Samuel, On 12/19/2011 1:03 PM, Samuel Ortiz wrote: Hi Benoit, On Fri, Dec 09, 2011 at 03:02:34PM +0100, Benoit Cousson wrote: Add initial device-tree support for twl familly chips. The current version is missing the regulator entries due to the lack of DT regulator bindings for the momen

<    1   2   3   4   5   6   7   8   9   10   >