Re: [PATCH v3 5/5] OMAP: mailbox: add omap_device latency information

2010-12-13 Thread Cousson, Benoit
On 12/11/2010 4:25 PM, Ramirez Luna, Omar wrote: On Fri, Dec 10, 2010 at 7:51 PM, Omar Ramirez Luna wrote: From: Felipe Contreras So that we can enable the main clock. This should be: Subject: OMAP: mailbox: use runtime pm for clk and sysc handling Use runtime pm APIs to enable/disable mai

Re: [PATCH] OMAP: omap_device: use pdev as parameter to get rt_va

2010-12-13 Thread Cousson, Benoit
Hi Omar, On 12/11/2010 12:45 AM, Ramirez Luna, Omar wrote: Make the parameter received by omap_device_get_mpu_rt_va consistent with the functions meant to be called by drivers. Also move its header declaration to appear in the set of functions to be used by drivers, as per the comment there.

Re: [PATCH 0/5] OMAP4: hwmod data fixes and update

2010-12-10 Thread Cousson, Benoit
On 12/10/2010 1:36 AM, Kevin Hilman wrote: Benoit Cousson writes: [...] As with the other series, I tried to pull this into my pm-core for testing with all the other PM stuff we have baking for 2.6.38. Unfortunately, this series has conflicts with Paul's pwrdm_prcm_[ab]_2.6.38 branches. Co

Re: [PATCH v2 1/2] I2C: i2c-omap: Change device name: i2c_omap -> omap_i2c

2010-12-10 Thread Cousson, Benoit
On 12/9/2010 11:18 PM, aaro.koski...@nokia.com wrote: Hi, Kevin Hilman [khil...@deeprootsystems.com]: Ben Dooks writes: Renaming stuff like this is going to have an impact on the userspace as anyone looking through /sys's driver heirarchy is going to miss the old name... It all depends if yo

Re: [PATCH 0/5] OMAP4: hwmod data fixes and update

2010-12-09 Thread Cousson, Benoit
On 12/10/2010 1:36 AM, Kevin Hilman wrote: Benoit Cousson writes: Hi Paul, Here is a small set of OMAP4 hwmod data updates. Re-order properly the data that were a little bit shuffled during the previous merge window. Add the new reset flags introduced in 2.6.37 and that were not used in the

Re: [PATCH 11/14] OMAP4: PRCM: reorganize existing OMAP4 PRCM header files

2010-12-09 Thread Cousson, Benoit
Salut Paul, On 12/8/2010 7:47 AM, Paul Walmsley wrote: Salut Benoît, On Tue, 7 Dec 2010, Cousson, Benoit wrote: Salut Paul, On 12/7/2010 2:25 AM, Paul Walmsley wrote: Split the existing cm44xx.h file into cm1_44xx.h and cm2_44xx.h files so they match their underlying OMAP hardware modules

Re: [PATCH v8 01/11] OMAP: GPIO: prepare for platform driver

2010-12-09 Thread Cousson, Benoit
On 12/9/2010 11:19 PM, Kevin Hilman wrote: "Cousson, Benoit" writes: Salut Kevin, On 12/9/2010 8:18 PM, Kevin Hilman wrote: Hi Charu, "Varadarajan, Charulatha" writes: Prepare for implementing GPIO as a platform driver. Modifies omap_gpio_init() to make use of

Re: [PATCH v8 01/11] OMAP: GPIO: prepare for platform driver

2010-12-09 Thread Cousson, Benoit
Salut Kevin, On 12/9/2010 8:18 PM, Kevin Hilman wrote: Hi Charu, "Varadarajan, Charulatha" writes: Prepare for implementing GPIO as a platform driver. Modifies omap_gpio_init() to make use of omap_gpio_chip_init() and omap_gpio_mod_init(). omap_gpio_mod_init() does the module init by cleari

Re: [PATCH 11/14] OMAP4: PRCM: reorganize existing OMAP4 PRCM header files

2010-12-07 Thread Cousson, Benoit
On 12/7/2010 2:25 AM, Paul Walmsley wrote: [...] + * + * XXX This file needs to be updated to align on one of "OMAP4", "OMAP44XX", + * or "OMAP4430". Yep, I was thinking to change that as well. My first thought was OMAP4 to get a shorter name, but when we will introduce OMAP4440, we migh

Re: [PATCH] Correct definition of register of OMAP4_RM_RSTST and OMAP4_RM_RSTTIME

2010-12-07 Thread Cousson, Benoit
Hi Paul, On 12/7/2010 5:04 PM, Paul Walmsley wrote: Hello, On Tue, 7 Dec 2010, MING ZHOU wrote: Since we need to reconfigure Reset time for OMAP4, we found the OMAP4 register definition for reset time is wrong according to spec of OMAP4. And we verified this by reading default value of regist

Re: [PATCH v7] OMAP2+: PM: omap device: API's for handling mstandby mode

2010-12-03 Thread Cousson, Benoit
On 12/3/2010 10:47 AM, G, Manjunath Kondaiah wrote: * Cousson, Benoit [2010-12-03 09:38:35 +0100]: [...] v7: replaced mutex lock with spin lock. Added use count for controlling access to sysconfig registers in case if overlapping request/release API's are used. I'm not sure it

Re: [PATCH v7] OMAP2+: PM: omap device: API's for handling mstandby mode

2010-12-03 Thread Cousson, Benoit
On 12/2/2010 2:59 PM, G, Manjunath Kondaiah wrote: Certain errata in OMAP2+ processors will require forcing master standby to "no standby" mode before completing on going operation. Without this, the results will be unpredictable. Since current implementation of PM run time framework does not su

Re: [PATCH v6] OMAP2+: PM: omap device: API's for handling mstandby mode

2010-12-02 Thread Cousson, Benoit
Hi Adrian and Manju, On 12/2/2010 8:58 AM, Adrian Hunter wrote: On 02/12/10 08:12, ext G, Manjunath Kondaiah wrote: * Adrian Hunter [2010-12-01 22:16:44 +0200]: On 01/12/10 20:47, ext G, Manjunath Kondaiah wrote: [...] Also, there is a mutex but don't these functions get called sometimes

Re: [PATCH 6/7] [RFC] OMAP: hwmod: SYSCONFIG register modification for MCBSP

2010-12-01 Thread Cousson, Benoit
+ Govindraj Hi Partha, On 12/1/2010 8:14 AM, Basak, Partha wrote: From: Cousson, Benoit Sent: Tuesday, November 30, 2010 9:33 PM Hi Kishon, Sorry, for the delay. On 11/22/2010 4:59 PM, ABRAHAM, KISHON VIJAY wrote: Resending the mail in plain text format.. On Mon, Nov 22, 2010 at 9:20 PM

Re: [PATCH 6/7] [RFC] OMAP: hwmod: SYSCONFIG register modification for MCBSP

2010-11-30 Thread Cousson, Benoit
, Cousson, Benoit wrote: Hi Kishon, On 10/5/2010 6:37 PM, ABRAHAM, KISHON VIJAY wrote: MCBSP 2 and 3 in OMAP3 has sidetone feature which requires autoidle to be disabled before starting the sidetone. Also SYSCONFIG register has to be set with smart idle or no idle depending on the dma op mode

Re: [PATCH v7 05/11] OMAP2420: hwmod data: Add GPIO

2010-11-25 Thread Cousson, Benoit
On 11/25/2010 5:36 AM, Varadarajan, Charulatha wrote: Benoit, On Thu, Nov 25, 2010 at 03:43, Cousson, Benoit wrote: On 11/23/2010 3:56 PM, Varadarajan, Charulatha wrote: Add GPIO hwmod data for OMAP2420 Signed-off-by: Charulatha V --- arch/arm/mach-omap2/omap_hwmod_2420_data.c | 229

Re: [PATCH v7 05/11] OMAP2420: hwmod data: Add GPIO

2010-11-24 Thread Cousson, Benoit
On 11/25/2010 5:36 AM, Varadarajan, Charulatha wrote: Benoit, On Thu, Nov 25, 2010 at 03:43, Cousson, Benoit wrote: On 11/23/2010 3:56 PM, Varadarajan, Charulatha wrote: Add GPIO hwmod data for OMAP2420 Signed-off-by: Charulatha V [...] diff --git a/arch/arm/plat-omap/include/plat

Re: [PATCH v7 09/11] OMAP2+: GPIO: device registration

2010-11-24 Thread Cousson, Benoit
On 11/23/2010 3:56 PM, Varadarajan, Charulatha wrote: Use omap_device_build() API to do platform_device_register of GPIO devices. For OMAP2+ chips, the device specific data defined in the centralized hwmod database will be used. gpio_init needs to be done before machine_init functions access gpi

Re: [PATCH v7 07/11] OMAP3: hwmod data: Add GPIO

2010-11-24 Thread Cousson, Benoit
On 11/23/2010 3:56 PM, Varadarajan, Charulatha wrote: Add GPIO hwmod data for OMAP3 Signed-off-by: Charulatha V Signed-off-by: Rajendra Nayak Acked-by: Benoit Cousson --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 360 1 files changed, 360 insertions(+), 0

Re: [PATCH v7 06/11] OMAP2430: hwmod data: Add GPIO

2010-11-24 Thread Cousson, Benoit
On 11/23/2010 3:56 PM, Varadarajan, Charulatha wrote: Add GPIO hwmod data for OMAP2430 Signed-off-by: Charulatha V Acked-by: Benoit Cousson --- arch/arm/mach-omap2/omap_hwmod_2430_data.c | 279 1 files changed, 279 insertions(+), 0 deletions(-) diff --git a

Re: [PATCH v7 05/11] OMAP2420: hwmod data: Add GPIO

2010-11-24 Thread Cousson, Benoit
On 11/23/2010 3:56 PM, Varadarajan, Charulatha wrote: Add GPIO hwmod data for OMAP2420 Signed-off-by: Charulatha V --- arch/arm/mach-omap2/omap_hwmod_2420_data.c | 229 arch/arm/plat-omap/include/plat/gpio.h |5 + 2 files changed, 234 insertions(+), 0 de

Re: [PATCH v7 00/11] OMAP: GPIO: Implement GPIO as a platform device

2010-11-24 Thread Cousson, Benoit
Hi Charu, On 11/23/2010 3:56 PM, Varadarajan, Charulatha wrote: Implement OMAP GPIO module in platform device model. OMAP2+ specific GPIO module uses hwmod FW. Tested on OMAP2430, OMAP44430, OMAP3430 SDP boards, OMAP4430 Blaze board How did you get some top secret samples of the ultra new *44

Re: [PATCH v4 2/3] omap4: opp: add OPP table data

2010-11-23 Thread Cousson, Benoit
On 11/23/2010 11:56 PM, Menon, Nishanth wrote: Cousson, Benoit had written, on 11/23/2010 04:33 PM, the following: Hi Nishanth, On 11/23/2010 4:19 PM, Menon, Nishanth wrote: Kevin Hilman had written, on 11/22/2010 06:09 PM, the following: Nishanth Menon writes: Kevin Hilman wrote, on 11

Re: [PATCH v4 2/3] omap4: opp: add OPP table data

2010-11-23 Thread Cousson, Benoit
Hi Nishanth, On 11/23/2010 4:19 PM, Menon, Nishanth wrote: Kevin Hilman had written, on 11/22/2010 06:09 PM, the following: Nishanth Menon writes: Kevin Hilman wrote, on 11/22/2010 05:19 PM: Nishanth Menon writes: This patch adds OPP tables for OMAP4. New file has been added to keep the

Re: [PATCHv4 11/14] OMAP2+: dmtimer: convert to platform devices

2010-11-23 Thread Cousson, Benoit
On 11/20/2010 3:39 AM, Tarun Kanti DebBarma wrote: From: Thara Gopinath Add routines to converts dmtimers to platform devices. The device data is obtained from hwmod database of respective platform and is registered to device model after successful binding to driver. It also provides provision t

Re: [PATCHv4 7/14] OMAP: dmtimer: use list instead of static array

2010-11-23 Thread Cousson, Benoit
On 11/20/2010 3:39 AM, Tarun Kanti DebBarma wrote: Convert dmtimers static array in functions into list structure. Please note that the static arrays will be completely removed in subsequent patches when dmtimer is converted to platform driver. Why do you still need to keep your own list of tim

Re: [PATCHv4 2/14] OMAP: dmtimer: infrastructure to support hwmod

2010-11-23 Thread Cousson, Benoit
On 11/20/2010 3:39 AM, DebBarma, Tarun Kanti wrote: (1) Add new fields and data structures to support dmtimer conversion to platform driver. (2) Constants to identify IP revision so that Highlander IP in OMAP 4 can be distinguished. (3) field to identify OMAP4 abe timers. (4) Interface function t

Re: [PATCHv4 1/14] OMAP2+: dmtimer: add device names to flck nodes

2010-11-23 Thread Cousson, Benoit
On 11/23/2010 9:36 AM, DebBarma, Tarun Kanti wrote: Benoit, -Original Message- From: Cousson, Benoit Sent: Monday, November 22, 2010 11:03 PM To: DebBarma, Tarun Kanti Cc: linux-omap@vger.kernel.org; Gopinath, Thara Subject: Re: [PATCHv4 1/14] OMAP2+: dmtimer: add device names to flck

Re: [PATCHv4 1/14] OMAP2+: dmtimer: add device names to flck nodes

2010-11-22 Thread Cousson, Benoit
Hi Tarun, On 11/20/2010 3:39 AM, Tarun Kanti DebBarma wrote: From: Thara Gopinath Add device name to OMAP2 dmtimer fclk nodes so that the fclk nodes can be retrieved by doing a clk_get with the corresponding device pointers or device names. Signed-off-by: Thara Gopinath Signed-off-by: Tarun Ka

Re: [PATCH v3 2/5] OMAP: mailbox: fix rx interrupt disable in omap4

2010-11-22 Thread Cousson, Benoit
On 11/22/2010 12:51 PM, Felipe Balbi wrote: Hi, On Mon, Nov 22, 2010 at 05:46:53AM -0600, Kanigeri, Hari wrote: > From the dmtimer stuff, it looks like the driver defines the version types, which hwmod uses to define the rev field. /* timer ip constants */ #define OMAP_TIMER_IP_LEGACY

Re: [PATCH v3 2/5] OMAP: mailbox: fix rx interrupt disable in omap4

2010-11-22 Thread Cousson, Benoit
On 11/22/2010 11:08 AM, Balbi, Felipe wrote: On Fri, Nov 19, 2010 at 03:50:02PM +0100, Cousson, Benoit wrote: Most of the time, we do not want to use the IP revision because it is un-accurate and does not reflect the change we'd like to track. For example some time a minor change in th

Re: [PATCH v3 2/5] OMAP: mailbox: fix rx interrupt disable in omap4

2010-11-19 Thread Cousson, Benoit
On 11/19/2010 3:22 PM, Kanigeri, Hari wrote: Felipe, On Fri, Nov 19, 2010 at 2:32 AM, Felipe Balbi wrote: On Thu, Nov 18, 2010 at 06:07:40PM -0600, Kanigeri, Hari wrote: Benoit, On Thu, Nov 18, 2010 at 5:28 PM, Cousson, Benoit wrote: On 11/18/2010 8:15 PM, Hari Kanigeri wrote

Re: [PATCH v3 2/5] OMAP: mailbox: fix rx interrupt disable in omap4

2010-11-18 Thread Cousson, Benoit
On 11/18/2010 8:15 PM, Hari Kanigeri wrote: disabling rx interrupt on omap4 is different than its pre-decessors. The bit in OMAP4_MAILBOX_IRQENABLE_CLR should be set to disable the interrupts instead of clearing the bit. Signed-off-by: Hari Kanigeri --- arch/arm/mach-omap2/mailbox.c |5 +++

Re: [PATCH v3 1/5] OMAP: mailbox: change full flag per mailbox queue instead of global

2010-11-18 Thread Cousson, Benoit
On 11/18/2010 8:15 PM, Kanigeri, Hari wrote: From: Fernando Guzman Lugo As pointed by Ohad Ben-Cohen, the variable rq_full flag is a global variable, so if there are multiple mailbox users there will be conflics. Now there is a full flag per mailbox queue. Version 2: - Rebase to the latest. Ver

Re: [PATCH] OMAP4: clocks: add dummy clock for mailbox

2010-11-18 Thread Cousson, Benoit
Hi Hari, On 11/18/2010 8:20 PM, Kanigeri, Hari wrote: In omap4, there is no explicit configuration register to enable mailbox clocks. Defining dummy clock for mailbox clock module to keep the mailbox driver backward compatible with previous omaps. Signed-off-by: Hari Kanigeri --- arch/arm/mac

Re: [PATCH 0/5] OMAP4: mux: Initialise OMAP4 mux pins.

2010-11-18 Thread Cousson, Benoit
On 11/18/2010 8:06 PM, Tony Lindgren wrote: * sricharan [101114 23:26]: This series updates the core device drivers to use mux framework for OMAP4 SDP and PANDA board. It's generated against the linux-omap master branch. It has a dependency on the Benoit's omap4 mux data series. 2. Do PAD

Re: [PATCH] OMAP MUX framework changes

2010-11-18 Thread Cousson, Benoit
Hi Tony, On 11/18/2010 6:57 PM, Tony Lindgren wrote: Hi Dan, [...] Can you please make this into a separate patch. And instead of indenting the code more, just do something like: if (!partition) return -EINVAL; Do you want me to merge that in my current OMAP4 serie

Re: [PATCH] omap: prcm: switch to a chained IRQ handler mechanism

2010-11-17 Thread Cousson, Benoit
On 11/17/2010 5:16 PM, Kevin Hilman wrote: "Cousson, Benoit" writes: [...] +#define OMAP_MPUIO_IRQ_END (IH_MPUIO_BASE + 16) + +/* 32 IRQs for the PRCM */ +#define OMAP_PRCM_IRQ_BASE (OMAP_MPUIO_IRQ_END) +#define INT_34XX_PRCM_WKUP_EN (OMAP_PRCM_IRQ

Re: [PATCH] omap: prcm: switch to a chained IRQ handler mechanism

2010-11-17 Thread Cousson, Benoit
Hi Thomas, On 11/17/2010 1:16 PM, Thomas Petazzoni wrote: From: Thomas Petazzoni [...] static int __init omap3_pm_init(void) That code is purely OMAP3 specific, do you think it might scale well on OMAP4? BTW, you should maybe change the subject with "OMAP3: prcm: ..." to reflect that.

Re: [PATCH 2/7] OMAP: mux: Add support for control module split in several partitions

2010-11-16 Thread Cousson, Benoit
On 11/16/2010 6:37 PM, Tony Lindgren wrote: * Cousson, Benoit [101116 08:53]: Hi Tony, On 11/16/2010 5:41 PM, Tony Lindgren wrote: * Cousson, Benoit [101115 13:36]: Hi Tony, On 11/15/2010 9:03 PM, Tony Lindgren wrote: * Benoit Cousson[10 13:26]: Starting on OMAP4, the pin mux

Re: [PATCH 5/8] OMAP2+: hwmod: rename omap_hwmod_mutex to _hwmod_list_mutex

2010-11-16 Thread Cousson, Benoit
Hi Paul, Funny, I was about to send you a RFC to get rid of that mutex :-) Today that mutex is preventing us to be re-entrant during hwmod lookup and for_each_by_class iteration, and we'd like to in order to manage link between 2 hwmods. The context is the link between mcbsp and sidetone on

Re: [PATCH 2/7] OMAP: mux: Add support for control module split in several partitions

2010-11-16 Thread Cousson, Benoit
Hi Tony, On 11/16/2010 5:41 PM, Tony Lindgren wrote: * Cousson, Benoit [101115 13:36]: Hi Tony, On 11/15/2010 9:03 PM, Tony Lindgren wrote: * Benoit Cousson [10 13:26]: Starting on OMAP4, the pin mux configuration is located in two different partitions of the control module (CODE_PAD

Re: [PATCH 0/5] OMAP4: mux: Initialise OMAP4 mux pins.

2010-11-15 Thread Cousson, Benoit
Hi Sricharan, On 11/15/2010 8:38 AM, R, Sricharan wrote: This series updates the core device drivers to use mux framework for OMAP4 SDP and PANDA board. It's generated against the linux-omap master branch. It has a dependency on the Benoit's omap4 mux data series. http://www.spi

Re: [PATCH 2/7] OMAP: mux: Add support for control module split in several partitions

2010-11-15 Thread Cousson, Benoit
Hi Tony, On 11/15/2010 9:03 PM, Tony Lindgren wrote: * Benoit Cousson [10 13:26]: Starting on OMAP4, the pin mux configuration is located in two different partitions of the control module (CODE_PAD and WKUP_PAD). The first one is inside the core power domain whereas the second one is insid

Re: [RFC v2 0/7] OMAP4: mux: Add the OMAP4430 ES1 & ES2 support

2010-11-11 Thread Cousson, Benoit
On 11/11/2010 5:53 PM, Tony Lindgren wrote: * Cousson, Benoit [101020 13:43]: On 10/20/2010 1:06 AM, Tony Lindgren wrote: * Benoit Cousson [101019 15:14]: It takes into account your proposal to store partition information in a partition structure instead of inside every pad entries. The

Re: [RFC v2 4/7] OMAP4: mux: Add CBL package data for OMAP4430 ES1

2010-11-11 Thread Cousson, Benoit
On 11/11/2010 5:38 PM, Tony Lindgren wrote: * Cousson, Benoit [10 04:24]: Hi Tony, On 11/11/2010 2:56 AM, Tony Lindgren wrote: * Benoit Cousson [101019 15:14]: Add data for OMAP4430 generated from HW pinout& register database. The data set is split in two partitions for both

Re: [RFC v2 3/7] OMAP: mux: Add support for control module split in several partitions

2010-11-11 Thread Cousson, Benoit
On 11/11/2010 5:35 PM, Tony Lindgren wrote: * Benoit Cousson [101019 15:14]: --- a/arch/arm/mach-omap2/mux.h +++ b/arch/arm/mach-omap2/mux.h + +/** + * struct mux_partition - contain partition related information + * @name: name of the current partition + * @flags: flags specific to this partit

Re: [RFC v2 4/7] OMAP4: mux: Add CBL package data for OMAP4430 ES1

2010-11-11 Thread Cousson, Benoit
Hi Tony, On 11/11/2010 2:56 AM, Tony Lindgren wrote: * Benoit Cousson [101019 15:14]: Add data for OMAP4430 generated from HW pinout& register database. The data set is split in two partitions for both core and wkup. We should drop patch 3/7 and merge the following patch to your 4/7 patch.

Re: [PATCH 0/6] [v2] OMAP: mailbox: enhancements and fixes

2010-11-10 Thread Cousson, Benoit
On 11/10/2010 9:16 PM, Hari Kanigeri wrote: Benoit, Resending correcting the subject format based on Benoit's comment and fixing the over-indentation pointed out by Sergei. Pure nitpicking: That's a pretty fast update... but then it should be a v3 :-) Have to do it fast to keep your attenti

Re: [PATCH 0/6] [v2] OMAP: mailbox: enhancements and fixes

2010-11-10 Thread Cousson, Benoit
On 11/10/2010 7:00 PM, Hari Kanigeri wrote: Resending correcting the subject format based on Benoit's comment and fixing the over-indentation pointed out by Sergei. Pure nitpicking: That's a pretty fast update... but then it should be a v3 :-) Why does the cover letter not use the same format?

Re: [PATCH 0/6] [v2] omap:mailbox-enhancements and fixes

2010-11-10 Thread Cousson, Benoit
On 11/10/2010 5:56 PM, Hari Kanigeri wrote: [...] Good point, thanks for pointing about consistency. I wasn't aware about the rule to use OMAP in caps. Well, I'm not sure there is any rule like that, it is just what was mostly used so far. My point was more about the text after the omap. B

Re: [PATCH 0/6] [v2] omap:mailbox-enhancements and fixes

2010-11-10 Thread Cousson, Benoit
On 11/10/2010 5:56 PM, Hari Kanigeri wrote: Benoit, Thanks for your comments. On Wed, Nov 10, 2010 at 10:40 AM, Cousson, Benoit wrote: Hi Hari, On 11/10/2010 1:45 PM, Hari Kanigeri wrote: Thanks to Rene Sapiens and Omar Ramirez for their inputs on initial patch set. http://www.mail

Re: [PATCH 0/6] [v2] omap:mailbox-enhancements and fixes

2010-11-10 Thread Cousson, Benoit
Hari, I forgot one comment. Since this series is a v2, every patches subject should contain the [PATCH v2 x/6]. FYI, patchwork will not track the cover letter, so we will miss that version information in the real patches. I forgot as well this subject: mailbox: change full flag per mail

Re: [PATCH 0/6] [v2] omap:mailbox-enhancements and fixes

2010-11-10 Thread Cousson, Benoit
Hi Hari, On 11/10/2010 1:45 PM, Hari Kanigeri wrote: Thanks to Rene Sapiens and Omar Ramirez for their inputs on initial patch set. http://www.mail-archive.com/linux-omap@vger.kernel.org/msg37278.html The patch set addresses the following review comments from Rene and Omar. http://www.mail-arch

Re: [PATCH 3/6] OMAP4: hwmod data: add mmu hwmod for ducati and tesla

2010-11-08 Thread Cousson, Benoit
On 11/9/2010 12:48 AM, Ramirez Luna, Omar wrote: On Mon, Nov 8, 2010 at 5:21 PM, Cousson, Benoit wrote: I wrote this one from scratch, I didn't see that there were pieces to handle some stuff since the code is buried in a private tree. Not true at all... It was sent to l-o: http://www

Re: [PATCH 3/6] OMAP4: hwmod data: add mmu hwmod for ducati and tesla

2010-11-08 Thread Cousson, Benoit
On 11/7/2010 11:18 AM, Ramirez Luna, Omar wrote: On Sat, Nov 6, 2010 at 3:47 PM, Cousson, Benoit wrote: On 11/5/2010 9:19 PM, Ramirez Luna, Omar wrote: Add mmu hwmod data for ducati and tesla. s/ducati/ipu/ s/tesla/dsp/ Please do not use internal codename. Tried to avoid confusion with

Re: [PATCH 2/6] OMAP3: hwmod data: Add mmu for iva2 and isp

2010-11-08 Thread Cousson, Benoit
On 11/7/2010 11:00 AM, Ramirez Luna, Omar wrote: On Sat, Nov 6, 2010 at 2:15 PM, Cousson, Benoit wrote: On 11/5/2010 9:19 PM, Ramirez Luna, Omar wrote: Add mmu hwmod data for iva2 and isp. s/iva2/iva/ Where this terminology can be found? I'm basing this naming on what was there o

Re: [PATCH 0/6] omap: iommu: hwmod support and code reorganization

2010-11-08 Thread Cousson, Benoit
On 11/7/2010 10:43 AM, Ramirez Luna, Omar wrote: On Sat, Nov 6, 2010 at 1:31 PM, Cousson, Benoit wrote: s/ducati/ipu/ s/tesla/dsp/ Please do not use internal codename for the changelog or even for the code. I picked this terminology from the driver, I didn't want to cause confusion,

Re: [PATCH v2 6/7] omap: mailbox: fix detection for previously supported chips

2010-11-08 Thread Cousson, Benoit
On 11/7/2010 10:15 AM, Ramirez Luna, Omar wrote: On Sat, Nov 6, 2010 at 1:11 PM, Cousson, Benoit wrote: -#if defined(CONFIG_ARCH_OMAP3430) +#if defined(CONFIG_ARCH_OMAP3) Ideally you should get rid of all the CONFIG_ARCH_OMAPXXX or cpu_is_omap in that code. This is a driver, it should be

Re: [PATCH v2 3/7] OMAP4: hwmod data: add mailbox data

2010-11-08 Thread Cousson, Benoit
Hi Omar, On 11/7/2010 10:07 AM, Ramirez Luna, Omar wrote: On Sat, Nov 6, 2010 at 12:18 PM, Cousson, Benoit wrote: I don't know why, but this patch has nothing to do with my original one. Can you stick to the original code? no, apart from the ordering of structure members, that I will c

Re: [PATCH 6/6] omap: iommu: code reorganization and cleanup

2010-11-06 Thread Cousson, Benoit
On 11/5/2010 9:19 PM, Ramirez Luna, Omar wrote: Since omap-iommu is now using hwmod, there are structures and arrays that can be cleaned up to increase the readability of the code. This patch should be merged with the previous one as well. I do not see the need to split in 3 patches these chan

Re: [PATCH 5/6] omap: iommu: hwmod device enable/disable routines

2010-11-06 Thread Cousson, Benoit
You should use runtime PM directly. That omap_device step is useless. Moreover, this patch should be merged with the previous one. Benoit On 11/5/2010 9:19 PM, Ramirez Luna, Omar wrote: Use omap device enable/disable routines. Signed-off-by: Omar Ramirez Luna --- arch/arm/mach-omap2/omap-io

Re: [PATCH 4/6] omap: iommu: intial hwmod support

2010-11-06 Thread Cousson, Benoit
On 11/5/2010 9:19 PM, Ramirez Luna, Omar wrote: Use the defined hwmod data according to the devices present on omap3 and omap4. Signed-off-by: Omar Ramirez Luna --- arch/arm/mach-omap2/omap-iommu.c| 77 --- arch/arm/plat-omap/include/plat/iommu.h |2 +

Re: [PATCH 3/6] OMAP4: hwmod data: add mmu hwmod for ducati and tesla

2010-11-06 Thread Cousson, Benoit
On 11/5/2010 9:19 PM, Ramirez Luna, Omar wrote: Add mmu hwmod data for ducati and tesla. s/ducati/ipu/ s/tesla/dsp/ Please do not use internal codename. Here again, you completely changed the omap4 existing data for (almost) nothing. I agree, the original code was not considering the mmu a

Re: [PATCH 2/6] OMAP3: hwmod data: Add mmu for iva2 and isp

2010-11-06 Thread Cousson, Benoit
On 11/5/2010 9:19 PM, Ramirez Luna, Omar wrote: Add mmu hwmod data for iva2 and isp. s/iva2/iva/ If you do need the version information, you should use the rev field in the hwmod class. All the comments about the structure fields order I did on your mailbox series will apply here as well.

Re: [PATCH 1/6] omap: iommu: remove redundant clock usage

2010-11-06 Thread Cousson, Benoit
On 11/5/2010 9:19 PM, Ramirez Luna, Omar wrote: iommu driver is meant to provide control of mmu hardware blocks A dot is missing here, and a capital letter should follow. its current users (MMUs) are part of larger subsystems and do not have a dedicated clock as the one they use is shared wit

Re: [PATCH 0/6] omap: iommu: hwmod support and code reorganization

2010-11-06 Thread Cousson, Benoit
On 11/5/2010 9:19 PM, Ramirez Luna, Omar wrote: Boot tested on omap 3430 and 3630, functionality on iva2 only. Introduced hwmod data and support for omap3 (iva2 mmu& isp mmu) and omap4 (ducati mmu& tesla mmu). Minor cleanup due to this changes. There is an issue (present without patches too)

Re: [PATCH v2 0/7] omap: mailbox: hwmod support and dependent cleanup patches

2010-11-06 Thread Cousson, Benoit
On 11/5/2010 9:17 PM, Ramirez Luna, Omar wrote: hwmod support for omap2 and omap3 chips, plus cleanups. Tested on 3430 and 3630 ** v2 ** - Added omap4 hwmod support. - Moved "mailbox_ick" from hwmod to hwmod_if (omap 2/3) - Declared sysc classes for omap 2/3 ** v1 ** 1. omap: mailbox: initial

Re: [PATCH 0/6] omap: iommu: hwmod support and code reorganization

2010-11-06 Thread Cousson, Benoit
s/ducati/ipu/ s/tesla/dsp/ Please do not use internal codename for the changelog or even for the code. On 11/5/2010 9:19 PM, Ramirez Luna, Omar wrote: Boot tested on omap 3430 and 3630, functionality on iva2 only. Introduced hwmod data and support for omap3 (iva2 mmu& isp mmu) and omap4 (duca

Re: [PATCH v2 7/7] omap: mailbox: remove unreachable return

2010-11-06 Thread Cousson, Benoit
On 11/5/2010 9:17 PM, Ramirez Luna, Omar wrote: Remove unreachable return statement. Signed-off-by: Omar Ramirez Luna --- arch/arm/mach-omap2/mailbox.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c index

Re: [PATCH v2 6/7] omap: mailbox: fix detection for previously supported chips

2010-11-06 Thread Cousson, Benoit
On 11/5/2010 9:17 PM, Ramirez Luna, Omar wrote: Fix the mailbox detection for OMAP3630 and 2430, also minor cleanup on conditional ifdef's that could affect it. Given that 2430 has an iva too include it, as the same steps for omap3 apply. Signed-off-by: Omar Ramirez Luna --- arch/arm/mach-oma

Re: [PATCH v2 5/7] omap: mailbox: add omap_device latency information

2010-11-06 Thread Cousson, Benoit
On 11/5/2010 9:17 PM, Ramirez Luna, Omar wrote: From: Felipe Contreras So that we can enable the main clock. Why not going directly to the runtime PM interface? It will save you some effort, because most of this code is useless with runtime PM. Moreover, even without runtime PM, you should

Re: [PATCH v2 4/7] omap: mailbox: initial hwmod support

2010-11-06 Thread Cousson, Benoit
Hi Felipe, On 11/5/2010 9:17 PM, Ramirez Luna, Omar wrote: From: Felipe Contreras hwmod support for omap mailbox module. Signed-off-by: Felipe Contreras Signed-off-by: Omar Ramirez Luna --- arch/arm/mach-omap2/devices.c | 100 ++-- 1 files changed, 15 in

Re: [PATCH v2 3/7] OMAP4: hwmod data: add mailbox data

2010-11-06 Thread Cousson, Benoit
I don't know why, but this patch has nothing to do with my original one. Can you stick to the original code? Of course, if you have valid comments or need to add extra data, you can, but in this case, I do not see any needed change. On 11/5/2010 9:17 PM, Ramirez Luna, Omar wrote: From: Benoit

Re: [PATCH v2 1/7] OMAP2: hwmod data: add mailbox data

2010-11-06 Thread Cousson, Benoit
Hi Omar, On 11/5/2010 9:17 PM, Ramirez Luna, Omar wrote: hwmod data for omap2430 and 2420. Signed-off-by: Omar Ramirez Luna --- arch/arm/mach-omap2/omap_hwmod_2420_data.c | 67 arch/arm/mach-omap2/omap_hwmod_2430_data.c | 66 +++ 2 fi

Re: [PATCH v3 06/13] OMAP3: DMA: hwmod: add system DMA

2010-11-04 Thread Cousson, Benoit
On 11/4/2010 3:01 AM, G, Manjunath Kondaiah wrote: Hi Benoit, From: Cousson, Benoit Sent: Thursday, November 04, 2010 9:59 AM Hi Manjunath, On 11/3/2010 8:59 AM, G, Manjunath Kondaiah wrote: Kevin/Benoit, [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of G, Manjunath Kondaiah Sent

Re: [PATCH v3 06/13] OMAP3: DMA: hwmod: add system DMA

2010-11-03 Thread Cousson, Benoit
Hi Manjunath, On 11/3/2010 8:59 AM, G, Manjunath Kondaiah wrote: Kevin/Benoit, [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of G, Manjunath Kondaiah Sent: Tuesday, October 26, 2010 6:55 PM Add OMAP3 DMA hwmod structures. Signed-off-by: G, Manjunath Kondaiah Cc: Benoit Cousson Cc: Kevi

Re: [PATCH v2 08/11] OMAP4: Adding dev atrributes to OMAP4 smartreflex hwmod data

2010-11-02 Thread Cousson, Benoit
Hi Kevin, On 11/2/2010 10:10 AM, Kevin Hilman wrote: "Cousson, Benoit" writes: On 9/25/2010 2:51 PM, Gopinath, Thara wrote: This patch adds dev attributes for smartreflex modules in the OMAP4 hwmod database. This patch also updates the smartreflex rev in the smartreflex class data

Re: [PATCH v4 2/9] OMAP3: PM: Adding smartreflex driver support.

2010-11-02 Thread Cousson, Benoit
On 10/28/2010 5:27 PM, Gopinath, Thara wrote: -Original Message- From: Varadarajan, Charulatha Sent: Thursday, October 28, 2010 11:09 AM To: Gopinath, Thara; linux-omap@vger.kernel.org Cc: p...@pwsan.com; khil...@deeprootsystems.com; Cousson, Benoit; Sripathy, Vishwanath; Sawant

Re: [PATCH v2 08/11] OMAP4: Adding dev atrributes to OMAP4 smartreflex hwmod data

2010-10-26 Thread Cousson, Benoit
On 9/25/2010 2:51 PM, Gopinath, Thara wrote: This patch adds dev attributes for smartreflex modules in the OMAP4 hwmod database. This patch also updates the smartreflex rev in the smartreflex class data structure in the OMAP4 hwmod database. Signed-off-by: Thara Gopinath --- arch/arm/mach-omap

Re: [PATCH v2 08/11] OMAP4: Adding dev atrributes to OMAP4 smartreflex hwmod data

2010-10-26 Thread Cousson, Benoit
Hi Kevin, Sorry for that late reply, I missed that email a little bit. On 10/14/2010 8:56 PM, Kevin Hilman wrote: On Sat, 2010-09-25 at 18:21 +0530, Thara Gopinath wrote: diff --git a/arch/arm/plat-omap/include/plat/control.h b/arch/arm/plat-omap/include/plat/control.h index 042eb6e..1e8f6ec 1

Re: [PATCH v3 01/11] OMAP: PM: Export the main pm debugfs directory

2010-10-25 Thread Cousson, Benoit
On 9/22/2010 4:45 PM, Gopinath, Thara wrote: This patch makes generic pm_debug directory global so that other drivers can include it and use it to create sub-entries. That should not be needed, if we expose voltage debugfs entry in the top level directly. Benoit Signed-off-by: Thara Gopi

Re: [PATCH v3 08/11] OMAP3: PM: Adding debug support to Voltage and Smartreflex drivers

2010-10-25 Thread Cousson, Benoit
Hi Thara, On 9/22/2010 4:45 PM, Gopinath, Thara wrote: This patch adds debug support to the voltage and smartreflex drivers. This means a whole bunch of voltage processor and smartreflex parameters are now visible through the pm debugfs. By default only a read of these parameters are permitted.

Re: [PATCH] OMAP: hmwod: Update the sysc_cache in case module context is lost

2010-10-21 Thread Cousson, Benoit
On 10/21/2010 12:13 PM, Nayak, Rajendra wrote: Hi Kevin, What the patch does is reprogram's the sysc value (from the cache) whenever its lost. So its infact saved in the cache and restored when needed. Otherwise, all this patch does is refresh the _sysc_cache with completely unknown conten

Re: [PATCH 4/5] arm: omap: introduce 32k timer hwmod for omap2/3/4

2010-10-20 Thread Cousson, Benoit
On 10/19/2010 11:22 AM, Balbi, Felipe wrote: Add 32k timer hwmod to the database. Signed-off-by: Felipe Balbi Could you add my sign-off as well on this one for the OMAP4 part? Thanks, Benoit --- arch/arm/mach-omap2/omap_hwmod_2420_data.c | 52 +++ arch/arm/mach-omap2

Re: [PATCH 0/5] 32k sync timer meets hwmod

2010-10-20 Thread Cousson, Benoit
Hi Felipe, Just one minor comment about the subjects. On 10/19/2010 11:22 AM, Felipe Balbi wrote: Hi all, Converted 32k-sync timer to platform_driver and now using pm_runtime and hwmod. Tested on 3430 by me and 4430 by Tarun If someone could test on 2430 and 2420, I would be really glad. Fe

Re: [RFC v2 0/7] OMAP4: mux: Add the OMAP4430 ES1 & ES2 support

2010-10-20 Thread Cousson, Benoit
Hi Tony, On 10/20/2010 1:06 AM, Tony Lindgren wrote: * Benoit Cousson [101019 15:14]: Hi Tony, Upon Nishanth request, here is the updated version... It takes into account your proposal to store partition information in a partition structure instead of inside every pad entries. The mechanism

Re: [RFC 0/5] OMAP4: mux: Add the OMAP4430 ES1 support

2010-10-18 Thread Cousson, Benoit
Hi Tony, On 10/19/2010 1:00 AM, Tony Lindgren wrote: * Cousson, Benoit [101018 13:42]: Hi Nishanth, On 10/18/2010 8:09 PM, Menon, Nishanth wrote: From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Benoit Cousson Ping? Is there a possibility for

Re: [RFC 0/5] OMAP4: mux: Add the OMAP4430 ES1 support

2010-10-18 Thread Cousson, Benoit
On 10/18/2010 10:53 PM, Menon, Nishanth wrote: From: Cousson, Benoit Sent: Monday, October 18, 2010 3:52 PM On 10/18/2010 8:09 PM, Menon, Nishanth wrote: From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Benoit Cousson Ping? Is there a

Re: [RFC 0/5] OMAP4: mux: Add the OMAP4430 ES1 support

2010-10-18 Thread Cousson, Benoit
Hi Nishanth, On 10/18/2010 8:09 PM, Menon, Nishanth wrote: From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Benoit Cousson Ping? Is there a possibility for a v2 non-rfc ES2 support? And what about a RFC v2? With ES2 support of course :-) The cha

Re: [RFC][PATCH 2/2] OMAP4: PRCM: Fix usage of prm/cm accessor api's for OMAP4

2010-10-15 Thread Cousson, Benoit
Hi Paul, On 10/14/2010 8:44 PM, Paul Walmsley wrote: Hello Rajendra, On Tue, 10 Aug 2010, Rajendra Nayak wrote: OMAP's have always had PRCM split into PRM for power and reset management and CM for clock management. In OMAP4 the split (physically) is not very straight forward and there are ins

Re: [PATCH v3 02/11] OMAP3: PM: Adding voltage driver support for OMAP3

2010-10-15 Thread Cousson, Benoit
Hi Paul, On 9/30/2010 7:39 PM, Paul Walmsley wrote: Hi Benoît, Thara, On Wed, 29 Sep 2010, Kevin Hilman wrote: Also, I'm still seeing this on boot: omap_hwmod: sr1_fck: missing clockdomain for sr1_fck. omap_hwmod: sr2_fck: missing clockdomain for sr2_fck. We need a final solut

Re: [PATCH] OMAP: hmwod: Update the sysc_cache in case module context is lost

2010-10-15 Thread Cousson, Benoit
Hi Santosh, On 10/15/2010 7:48 AM, Shilimkar, Santosh wrote: From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Friday, October 15, 2010 3:44 AM Rajendra Nayak writes: Do not skip the sysc programming in the hmwod framework based on the cached value alone, since at times the modul

Re: [PATCH] omap2plus: wdt: Fix boot warn when CONFIG_PM_RUNTIME=n

2010-10-12 Thread Cousson, Benoit
Adding more folks to the discussion. On 10/12/2010 9:30 AM, Varadarajan, Charulatha wrote: From: Cousson, Benoit Sent: Tuesday, October 12, 2010 12:45 PM To: Varadarajan, Charulatha Hi Charu, On 10/11/2010 2:02 PM, Varadarajan, Charulatha wrote: Fix the below warning during boot

Re: [PATCHv3 8/17] dmtimer: register mappings moved to hwmod database

2010-10-12 Thread Cousson, Benoit
On 10/12/2010 11:35 AM, Basak, Partha wrote: From: Cousson, Benoit Sent: Tuesday, October 12, 2010 1:32 PM To: Basak, Partha Cc: DebBarma, Tarun Kanti; Kevin Hilman; G, Manjunath Kondaiah; linux-omap@vger.kernel.org; Shilimkar, Santosh; Paul Walmsley; Tony Lindgren Subject: Re: [PATCHv3 8/17

Re: [PATCHv3 8/17] dmtimer: register mappings moved to hwmod database

2010-10-12 Thread Cousson, Benoit
On 10/12/2010 9:22 AM, Basak, Partha wrote: From: DebBarma, Tarun Kanti Sent: Tuesday, October 12, 2010 11:19 AM To: Cousson, Benoit Benoit, From: Cousson, Benoit Sent: Tuesday, October 12, 2010 4:42 AM To: DebBarma, Tarun Kanti Hi Tarun, On 10/9/2010 5:40 PM, DebBarma, Tarun Kanti wrote

Re: [PATCHv3 8/17] dmtimer: register mappings moved to hwmod database

2010-10-11 Thread Cousson, Benoit
Hi Tarun, On 10/9/2010 5:40 PM, DebBarma, Tarun Kanti wrote: Benoit, From: Cousson, Benoit Sent: Thursday, September 23, 2010 10:15 PM To: Basak, Partha Cc: Kevin Hilman; G, Manjunath Kondaiah; DebBarma, Tarun Kanti; linux- o...@vger.kernel.org; Shilimkar, Santosh; Paul Walmsley; Tony

Re: [PATCHv3 3/17] dmtimer: add omap2420 hwmod database

2010-10-11 Thread Cousson, Benoit
Hi Tarun, On 10/11/2010 4:19 PM, Paul Walmsley wrote: On Mon, 11 Oct 2010, DebBarma, Tarun Kanti wrote: In the present implementation there is inconsistency in the clock source names for the different platforms, viz. OMAP2, OMAP3 and OMAP4 as shown below. Therefore, I will have to modify the n

Re: [PATCHv3 17/17] dmtimer: remove OCP config code from plat-omap

2010-10-11 Thread Cousson, Benoit
On 10/11/2010 11:41 AM, DebBarma, Tarun Kanti wrote: <...> In summary, I will make following updates: .clockact = 0x2 SYSC_HAS_CLOCKACTIVITY flag should be included. After going through the code I realized that this flag is already there. I am not sure where you observed this flag missing? Y

Re: [PATCH 6/7] [RFC] OMAP: hwmod: SYSCONFIG register modification for MCBSP

2010-10-08 Thread Cousson, Benoit
Hi Kishon, On 10/5/2010 6:37 PM, ABRAHAM, KISHON VIJAY wrote: MCBSP 2 and 3 in OMAP3 has sidetone feature which requires autoidle to be disabled before starting the sidetone. Also SYSCONFIG register has to be set with smart idle or no idle depending on the dma op mode (threshold or element sync)

<    3   4   5   6   7   8   9   10   >