Re: Nokia N900: Proper C-states

On 01/02/2016 03:26 PM, Pali Rohár wrote: Hello, due to this Daniel Lezcano commit (ARM: OMAP3: cpuidle - remove rx51 cpuidle parameters table) https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=231900afba52d6faddfb480cde4132d4edc089bc we need patch cpuidle34xx.c code

Re: [PATCH 09/11] clocksource: add TI 32.768 Hz counter driver

On 10/06/2015 07:02 PM, Felipe Balbi wrote: Introduce a new clocksource driver for Texas Instruments 32.768 Hz device which is available on most OMAP-like devices. Signed-off-by: Felipe Balbi <ba...@ti.com> Hi Felipe, With the couple of nits below fixed, you can my: Acked-by: Daniel L

Re: [RFC/PATCH 09/11] clocksource: add TI 32.768 Hz counter driver

Hi Felipe, On 09/29/2015 10:44 PM, Felipe Balbi wrote: Introduce a new clocksource driver for Texas Instruments 32.768 Hz device which is available on most OMAP-like devices. Signed-off-by: Felipe Balbi --- [ ... ] +config CLKSRC_TI_32K + bool "Texas Instruments

Re: [PATCH 08/10] ARM: OMAP5/DRA7: PM: cpuidle MPU CSWR support

On 08/22/2014 07:02 AM, Nishanth Menon wrote: From: Santosh Shilimkar santosh.shilim...@ti.com Add OMAP5/DRA74/72 CPUIDLE support. This patch adds MPUSS low power states in cpuidle. C1 - CPU0 WFI + CPU1 WFI + MPU ON C2 - CPU0 RET + CPU1 RET + MPU CSWR Tested on DRA74/72-EVM

Re: [PATCH 08/10] ARM: OMAP5/DRA7: PM: cpuidle MPU CSWR support

On 09/17/2014 04:20 PM, Shilimkar, Santosh wrote: Sorry for the format. Emailing from webmail. [ ... ] +static int omap_enter_idle_smp(struct cpuidle_device *dev, +struct cpuidle_driver *drv, +

Re: [PATCH] ARM: OMAP4: Fix the boot regression with CPU_IDLE enabled

On 05/27/2014 11:03 PM, Santosh Shilimkar wrote: On Tuesday 27 May 2014 04:34 PM, Tony Lindgren wrote: * Daniel Lezcano daniel.lezc...@linaro.org [140523 13:53]: On 23 May 2014 20:32, Tony Lindgren t...@atomide.com wrote: * Tony Lindgren t...@atomide.com [140523 07:45]: * Tobias Jakobi tjak

Re: [PATCH] ARM: OMAP4: Fix the boot regression with CPU_IDLE enabled

On 05/16/2014 11:29 PM, Tony Lindgren wrote: * Santosh Shilimkar santosh.shilim...@ti.com [140516 06:43]: Tony, On Thursday 15 May 2014 02:29 PM, Santosh Shilimkar wrote: On Thursday 15 May 2014 01:54 PM, Santosh Shilimkar wrote: On Thursday 15 May 2014 01:50 PM, Daniel Lezcano wrote: On 05

Re: [PATCH] ARM: OMAP4: Fix the boot regression with CPU_IDLE enabled

On 05/19/2014 07:51 PM, Tony Lindgren wrote: * Santosh Shilimkar santosh.shilim...@ti.com [140519 10:35]: On Monday 19 May 2014 01:23 PM, Tony Lindgren wrote: * Daniel Lezcano daniel.lezc...@linaro.org [140519 09:46]: On 05/16/2014 11:29 PM, Tony Lindgren wrote: And just to recap

Re: [PATCH] ARM: OMAP4: Fix the boot regression with CPU_IDLE enabled

On 05/19/2014 09:36 PM, Tony Lindgren wrote: * Daniel Lezcano daniel.lezc...@linaro.org [140519 11:07]: On 05/19/2014 07:51 PM, Tony Lindgren wrote: * Santosh Shilimkar santosh.shilim...@ti.com [140519 10:35]: On Monday 19 May 2014 01:23 PM, Tony Lindgren wrote: * Daniel Lezcano daniel.lezc

Re: RCU stall on panda

On 05/15/2014 10:44 AM, Alex Shi wrote: On 05/13/2014 11:32 PM, Tony Lindgren wrote: * Alex Shi alex@linaro.org [140512 23:37]: On 05/13/2014 05:21 AM, Tony Lindgren wrote: * Paul E. McKenney paul...@linux.vnet.ibm.com [140505 11:11]: On Mon, May 05, 2014 at 05:39:43PM +0800, Alex Shi

Re: [PATCH] ARM: OMAP4: Fix the boot regression with CPU_IDLE enabled

On 05/15/2014 07:03 PM, Santosh Shilimkar wrote: Daniel, On Wednesday 14 May 2014 05:18 PM, Santosh Shilimkar wrote: On Wednesday 14 May 2014 04:02 PM, Daniel Lezcano wrote: On 05/14/2014 09:50 PM, Santosh Shilimkar wrote: On Wednesday 14 May 2014 03:44 PM, Daniel Lezcano wrote: On 05/13

Re: [PATCH] ARM: OMAP4: Fix the boot regression with CPU_IDLE enabled

...@atomide.com Cc: Daniel Lezcano daniel.lezc...@linaro.org Reported-tested-by: Roger Quadros rog...@ti.com Reported-tested-by: Kevin Hilman khil...@linaro.org Tested-by: Tony Lindgren t...@atomide.com Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/cpuidle44xx.c | 12

Re: [PATCH] ARM: OMAP4: Fix the boot regression with CPU_IDLE enabled

On 05/14/2014 09:50 PM, Santosh Shilimkar wrote: On Wednesday 14 May 2014 03:44 PM, Daniel Lezcano wrote: On 05/13/2014 04:39 PM, Santosh Shilimkar wrote: On OMAP4 panda board, there have been several bug reports about boot hang and lock-ups with CPU_IDLE enabled. The root cause of the issue

[PATCH V3] cpuidle: Improve governor Kconfig options

. The dependency has been fixed in the relevant arch's Kconfig. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- V3: - Fixed Kconfig dependency between CPU_IDLE and ARCH_NEEDS_CPU_IDLE_COUPLED V2: - Set default values to 'yes' for the governors arch/arm/mach-omap2/Kconfig |2 +- arch/arm

Re: [GIT PULL 2/5] omap pm clean-up for v3.10 merge window

On 04/09/2013 07:36 PM, Kevin Hilman wrote: Tony Lindgren t...@atomide.com writes: * Kevin Hilman khil...@linaro.org [130409 09:43]: Arnd Bergmann a...@arndb.de writes: On Tuesday 09 April 2013, Tony Lindgren wrote: The following changes since commit

Re: [GIT PULL 2/5] omap pm clean-up for v3.10 merge window

On 04/09/2013 11:47 PM, Kevin Hilman wrote: Daniel Lezcano daniel.lezc...@linaro.org writes: [...] PM cleanup to prepare for omap5 PM via Kevin Hilman khil...@linaro.org: OMAP3/4 CPUidle cleanups for v3.10 Adding Daniel and Rafael to Cc. Kevin, I just want to point you this patch

Question regarding broadcast timer/cpuidle and /proc/interrupts

Hi All, I have a question regarding the behavior of cpuidle on pandaboard. 1. cpuidle is enabled 2. The deep idle states seem to be reach for i in $(find /sys/devices/system/cpu -name usage); do echo $i : $(cat $i); done /sys/devices/system/cpu/cpu0/cpuidle/state0/usage : 7049

Re: Question regarding broadcast timer/cpuidle and /proc/interrupts

On 01/21/2013 03:38 PM, Santosh Shilimkar wrote: On Monday 21 January 2013 07:47 PM, Daniel Lezcano wrote: Hi All, I have a question regarding the behavior of cpuidle on pandaboard. 1. cpuidle is enabled 2. The deep idle states seem to be reach for i in $(find /sys/devices/system/cpu

Re: [PATCH] ARM: OMAP3/4: consolidate cpuidle Makefile

On 05/30/2012 08:07 PM, Kevin Hilman wrote: Daniel Lezcano daniel.lezc...@linaro.org writes: On 05/14/2012 06:42 AM, Rajendra Nayak wrote: On Thursday 10 May 2012 03:32 PM, Daniel Lezcano wrote: The current Makefile compiles the cpuidle34xx.c and cpuidle44xx.c files even if the cpuidle

Re: [PATCH] ARM: OMAP3/4: consolidate cpuidle Makefile

On 05/14/2012 06:42 AM, Rajendra Nayak wrote: On Thursday 10 May 2012 03:32 PM, Daniel Lezcano wrote: The current Makefile compiles the cpuidle34xx.c and cpuidle44xx.c files even if the cpuidle option is not set in the kernel. This patch fixes this by creating a section in the Makefile where

[PATCH] ARM: OMAP3/4: consolidate cpuidle Makefile

files. This patch fix this also. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/Kconfig |2 ++ arch/arm/mach-omap2/Makefile | 11 +++ arch/arm/mach-omap2/cpuidle34xx.c |8 arch/arm/mach

Re: [PATCH 2/2] ARM: OMAP3/4: consolidate cpuidle Makefile

On 05/04/2012 07:18 PM, Daniel Lezcano wrote: Define a CPU_IDLE section in the makefile, declare the functions in the header files conforming to the kernel coding rules and remove the 'define's in the C files. CONFIG_PM is enabled when CPU_IDLE is enabled because the cpuidle drivers use some

Re: [PATCH 2/2] ARM: OMAP3/4: consolidate cpuidle Makefile

On 05/08/2012 10:44 PM, Kevin Hilman wrote: Daniel Lezcanodaniel.lezc...@linaro.org writes: Define a CPU_IDLE section in the makefile, declare the functions in the header files conforming to the kernel coding rules and remove the 'define's in the C files. CONFIG_PM is enabled when CPU_IDLE

[PATCH 0/2] ARM: OMAP3/4: cpuidle - misc fixes

to select CONFIG_PM when CONFIG_CPU_IDLE is set. I compiled with different options but I was not able to boot my board because the kernel panics for another reason. Daniel Lezcano (2): ARM: OMAP3: cpuidle - check the powerdomain lookup ARM: OMAP3/4: consolidate cpuidle Makefile arch/arm/mach

[PATCH 1/2] ARM: OMAP3: cpuidle - check the powerdomain lookup

At init time, check the powerdomains lookup is successful otherwise exit the cpuidle driver init function with -ENODEV like what is done for the omap3 cpuidle driver. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2

[PATCH 2/2] ARM: OMAP3/4: consolidate cpuidle Makefile

-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/Kconfig |2 ++ arch/arm/mach-omap2/Makefile | 11 +++ arch/arm/mach-omap2/cpuidle34xx.c |8 arch/arm/mach-omap2/cpuidle44xx.c |8 arch/arm/mach

Re: [PATCH 11/18][V3] ARM: OMAP3: cpuidle - remove the 'valid' field

On 05/03/2012 10:19 PM, Kevin Hilman wrote: Daniel Lezcanodaniel.lezc...@linaro.org writes: With the previous changes all the states are valid, except the last state which can be handled by decreasing the number of states. I don't think this changelog is valid anymore as you're not doing

Re: [PATCH 18/18][V3] ARM: OMAP3: cpuidle - set global variables static

On 05/03/2012 10:26 PM, Kevin Hilman wrote: Daniel Lezcanodaniel.lezc...@linaro.org writes: and check the powerdomain lookup is successful. Signed-off-by: Daniel Lezcanodaniel.lezc...@linaro.org Reviewed-by: Jean Pihetj-pi...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c |5 - 1

Re: [PATCH 17/18][V3] ARM: OMAP3/4: consolidate cpuidle Makefile

On 05/03/2012 10:34 PM, Kevin Hilman wrote: Daniel Lezcanodaniel.lezc...@linaro.org writes: Define a CPU_IDLE section in the makefile, declare the functions in the header files conforming to the kernel coding rules and remove the 'define's in the C files. Signed-off-by: Daniel

Re: [PATCH 00/18][V3] ARM: OMAP3/4 : cpuidle34xx and cpuidle44xx cleanups

On 05/01/2012 12:58 AM, Kevin Hilman wrote: Daniel Lezcanodaniel.lezc...@linaro.org writes: On 04/24/2012 04:05 PM, Daniel Lezcano wrote: This patchset makes some cleanup on these cpuidle drivers and consolidate the code across both architecture. Tested on OMAP3 (igepV2). Partially tested

Re: [PATCH 00/18][V3] ARM: OMAP3/4 : cpuidle34xx and cpuidle44xx cleanups

On 05/01/2012 11:55 AM, Shilimkar, Santosh wrote: On May 1, 2012 1:46 PM, Daniel Lezcanodaniel.lezc...@linaro.org wrote: On 05/01/2012 12:58 AM, Kevin Hilman wrote: Daniel Lezcanodaniel.lezc...@linaro.org writes: On 04/24/2012 04:05 PM, Daniel Lezcano wrote: This patchset makes some

Re: [PATCH 00/18][V3] ARM: OMAP3/4 : cpuidle34xx and cpuidle44xx cleanups

On 04/24/2012 04:05 PM, Daniel Lezcano wrote: This patchset makes some cleanup on these cpuidle drivers and consolidate the code across both architecture. Tested on OMAP3 (igepV2). Partially tested on OMAP4 (pandaboard), without offlining the cpu1. Hi, could be this patchset considered

[PATCH 00/18][V3] ARM: OMAP3/4 : cpuidle34xx and cpuidle44xx cleanups

* Fixed OMAP4_NUM_STATES going back and forth in the patchset * Removed erratum check at init time V2 : * Fixed a couple of typos in the patch description V1 : Initial Post Daniel Lezcano (18): ARM: OMAP4: cpuidle - Remove unused valid field ARM: OMAP4: cpuidle - Declare the states

[PATCH 01/18][V3] ARM: OMAP4: cpuidle - Remove unused valid field

The 'valid' field is never used in the code, let's remove it. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/cpuidle44xx.c |9 +++-- 1 files changed, 3

[PATCH 02/18][V3] ARM: OMAP4: cpuidle - Declare the states with the driver declaration

The cpuidle API allows to declare statically the states in the driver structure. Let's use it. We do no longer need the fill_cstate function called at runtime and by the way adding more instructions at boot time. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi

[PATCH 03/18][V3] ARM: OMAP4: cpuidle - Remove the cpuidle_params_table table

We do not longer need this table as we defined the values in the driver states. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/cpuidle44xx.c | 11 +-- 1 files

[PATCH 04/18][V3] ARM: OMAP4: cpuidle - fix static omap4_idle_data declaration

Add the static declaration for the omap4_idle_data variable because its scope is in the file only. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/cpuidle44xx.c |2

[PATCH 05/18][V3] ARM: OMAP4: cpuidle - Initialize omap4_idle_data at compile time

We initialize the omap4_idle_data variable at compile time allowing us to remove in the next patch the initialization done at boot time. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch

[PATCH 06/18][V3] ARM: OMAP4: cpuidle - use the omap4_idle_data variable directly

We are storing the 'omap4_idle_data' in the private data field of the cpuidle device. As we are using this variable only in this file, that does not really make sense. Let's use the global variable directly. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi

[PATCH 07/18][V3] ARM: OMAP4: cpuidle - remove omap4_idle_data initialization at boot time

We initialized it at compile time, no need to do that at boot time. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/cpuidle44xx.c | 24 1

[PATCH 08/18][V3] ARM: OMAP3: cpuidle - remove rx51 cpuidle parameters table

to not lose the values which probably took time to be measured, the table is converted into a comment with an array description. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/board-rx51.c | 38

[PATCH 09/18][V3] ARM: OMAP3: define cpuidle statically

Use the new cpuidle API and define in the driver the states. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c | 86 +--- 1 files changed, 60 insertions(+), 26 deletions(-) diff

[PATCH 10/18][V3] ARM: OMAP3: cpuidle - remove errata check in the init function

The errata check is done in the next_valid_state function, no need to check that in the omap3_idle_init function. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-omap2/cpuidle34xx.c | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/arch

[PATCH 11/18][V3] ARM: OMAP3: cpuidle - remove the 'valid' field

With the previous changes all the states are valid, except the last state which can be handled by decreasing the number of states. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c | 11 ++- 1 files

[PATCH 12/18][V3] ARM: OMAP3: cpuidle - remove cpuidle_params_table

We do not longer need the ''cpuidle_params_table' array as we defined the states in the driver and we checked they are all valid. We also remove the structure definition as it is no longer used. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com

[PATCH 13/18][V3] ARM: OMAP3: define statically the omap3_idle_data

Initialize the omap3_idle_data array at compile time, that will allow to remove the initialization at boot time. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c | 37 - 1

[PATCH 14/18][V3] ARM: OMAP3: cpuidle - use omap3_idle_data directly

. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c | 63 +++- 1 files changed, 6 insertions(+), 57 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b/arch/arm/mach-omap2

[PATCH 15/18][V3] ARM: OMAP3: cpuidle - simplify next_valid_state

Simplify the indentation by removing the useless 'else' statement. Remove the first loop for the 'idx' search as we have it already with the 'index' passed as parameter. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2

[PATCH 16/18][V3] ARM: OMAP3: set omap3_idle_data as static

Reduce the scope of the omap3_idle_data to the file as it is only used in cpuidle34xx.c. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 17/18][V3] ARM: OMAP3/4: consolidate cpuidle Makefile

Define a CPU_IDLE section in the makefile, declare the functions in the header files conforming to the kernel coding rules and remove the 'define's in the C files. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/Makefile

[PATCH 18/18][V3] ARM: OMAP3: cpuidle - set global variables static

and check the powerdomain lookup is successful. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b

Re: [PATCH 02/17][V2] ARM: OMAP4: cpuidle - Declare the states with the driver declaration

On 04/19/2012 03:58 PM, Daniel Lezcano wrote: On 04/10/2012 12:37 AM, Kevin Hilman wrote: Daniel Lezcanodaniel.lezc...@linaro.org writes: The cpuidle API allows to declare statically the states in the driver structure. Let's use it. We do no longer need the fill_cstate function called

Re: [PATCH 02/17][V2] ARM: OMAP4: cpuidle - Declare the states with the driver declaration

On 04/23/2012 07:08 PM, Kevin Hilman wrote: Daniel Lezcanodaniel.lezc...@linaro.org writes: On 04/19/2012 03:58 PM, Daniel Lezcano wrote: On 04/10/2012 12:37 AM, Kevin Hilman wrote: Daniel Lezcanodaniel.lezc...@linaro.org writes: The cpuidle API allows to declare statically the states

Re: [PATCH 02/17][V2] ARM: OMAP4: cpuidle - Declare the states with the driver declaration

On 04/10/2012 12:37 AM, Kevin Hilman wrote: Daniel Lezcanodaniel.lezc...@linaro.org writes: The cpuidle API allows to declare statically the states in the driver structure. Let's use it. We do no longer need the fill_cstate function called at runtime and by the way adding more instructions at

Re: [PATCH 10/17][V2] ARM: OMAP3: cpuidle - remove the 'valid' field

On 04/10/2012 01:13 AM, Kevin Hilman wrote: Daniel Lezcanodaniel.lezc...@linaro.org writes: With the previous changes all the states are valid, except the last state which can be handled by decreasing the number of states. Signed-off-by: Daniel Lezcanodaniel.lezc...@linaro.org Reviewed-by:

Re: [PATCH 00/17][V2] ARM: OMAP3/4 : cpuidle34xx and cpuidle44xx cleanups

On 04/10/2012 01:23 AM, Kevin Hilman wrote: Daniel Lezcanodaniel.lezc...@linaro.org writes: This patchset makes some cleanup on these cpuidle drivers and consolidate the code across both architecture. Thanks for this really nice cleanup. I have some comments on specific patches, but here's

Re: [PATCH 06/17][V2] ARM: OMAP4: cpuidle - use the omap4_idle_data variable directly

On 04/10/2012 12:56 AM, Kevin Hilman wrote: Daniel Lezcanodaniel.lezc...@linaro.org writes: We are storing the 'omap4_idle_data' in the private data field of the cpuidle device. As we are using this variable only in this file, that does not really make sense. Let's use the global variable

[PATCH 00/17][V2] ARM: OMAP3/4 : cpuidle34xx and cpuidle44xx cleanups

This patchset makes some cleanup on these cpuidle drivers and consolidate the code across both architecture. Tested on OMAP3 (igepV2). Partially tested on OMAP4 (pandaboard), without offlining the cpu1. V2 : Fixed a couple of typos in the patch description V1 : Initial Post Daniel Lezcano (17

[PATCH 01/17][V2] ARM: OMAP4: cpuidle - Remove unused valid field

The 'valid' field is never used in the code, let's remove it. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/cpuidle44xx.c |9 +++-- 1 files changed, 3

[PATCH 02/17][V2] ARM: OMAP4: cpuidle - Declare the states with the driver declaration

The cpuidle API allows to declare statically the states in the driver structure. Let's use it. We do no longer need the fill_cstate function called at runtime and by the way adding more instructions at boot time. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi

[PATCH 03/17][V2] ARM: OMAP4: cpuidle - Remove the cpuidle_params_table table

We do not longer need this table as we defined the values in the driver states. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/cpuidle44xx.c | 11 +-- 1 files

[PATCH 05/17][V2] ARM: OMAP4: cpuidle - Initialize omap4_idle_data at compile time

Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/cpuidle44xx.c | 19 ++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach

[PATCH 06/17][V2] ARM: OMAP4: cpuidle - use the omap4_idle_data variable directly

. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/cpuidle44xx.c | 15 --- 1 files changed, 4 insertions(+), 11 deletions(-) diff --git a/arch/arm/mach-omap2

[PATCH 07/17][V2] ARM: OMAP4: cpuidle - remove omap4_idle_data initialization at boot time

We initialized it at compile time, no need to do that at boot time. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/cpuidle44xx.c | 26 +- 1

[PATCH 08/17][V2] ARM: OMAP3: cpuidle - remove rx51 cpuidle parameters table

to not lose the values which probably took time to be measured, the table is converted into a comment with an array description. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/board-rx51.c | 38

[PATCH 09/17][V2] ARM: OMAP3: define cpuidle statically

Use the new cpuidle API and define in the driver the states. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c | 86 +--- 1 files changed, 60 insertions(+), 26 deletions(-) diff

[PATCH 11/17][V2] ARM: OMAP3: cpuidle - remove cpuidle_params_table

We do not longer need the ''cpuidle_params_table' array as we defined the states in the driver and we checked they are all valid. We also remove the structure definition as it is no longer used. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com

[PATCH 10/17][V2] ARM: OMAP3: cpuidle - remove the 'valid' field

With the previous changes all the states are valid, except the last state which can be handled by decreasing the number of states. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c | 12 +++- 1 files

[PATCH 12/17][V2] ARM: OMAP3: define statically the omap3_idle_data

Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c | 31 ++- 1 files changed, 30 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b/arch/arm/mach-omap2

[PATCH 13/17][V2] ARM: OMAP3: cpuidle - use omap3_idle_data directly

statically, let's remove the initialization at startup too. Also, that simplfies the code. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c | 65 1 files changed, 8 insertions

[PATCH 14/17][V2] ARM: OMAP3 : cpuidle - simplify next_valid_state

Simplify the indentation by removing the useless 'else' statement. Remove the first loop for the 'idx' search as we have it already with the 'index' passed as parameter. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2

[PATCH 16/17][V2] ARM: OMAP3/4: consolidate cpuidle Makefile

Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/Makefile | 11 +++ arch/arm/mach-omap2/cpuidle34xx.c |8 arch/arm/mach-omap2/cpuidle44xx.c |8 arch/arm/mach-omap2/pm.h | 17

[PATCH 17/17][V2] ARM: OMAP3: cpuidle - set global variables static

and check the powerdomain lookup is successful. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b

[PATCH 04/17][V2] ARM: OMAP4: cpuidle - fix static omap4_idle_data declaration

Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/cpuidle44xx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle44xx.c

[RFC][PATCH 1/9] ARM: OMAP3: cpuidle - remove rx51 cpuidle parameters table

to not lose the values which probably took time to be measured, the table is converted into a comment with an array description. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-omap2/board-rx51.c | 38 +--- arch/arm/mach-omap2/cpuidle34xx.c

[RFC][PATCH 3/9] ARM: OMAP3: cpuidle - set enable_off_mode as static

This variable is only used in the pm-debug.c file. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-omap2/pm-debug.c |2 +- arch/arm/mach-omap2/pm.h | 30 -- 2 files changed, 13 insertions(+), 19 deletions(-) diff --git a/arch/arm

[RFC][PATCH 4/9] ARM: OMAP3: define cpuidle statically

Use the new cpuidle API and define in the driver the states. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-omap2/cpuidle34xx.c | 85 +--- 1 files changed, 59 insertions(+), 26 deletions(-) diff --git a/arch/arm/mach-omap2

[RFC][PATCH 5/9] ARM: OMAP3: cpuidle - remove the 'valid' field

With the previous changes all the states are valid, except the last state which can be handled by decreasing the number of states. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-omap2/cpuidle34xx.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff

[RFC][PATCH 2/9] ARM: OMAP3: cpuidle - remove next_valid_state function

As we will be able to remove C-states from userspace with the sysfs API, this function is no longer needed. We remove it and that simplifies the code for more consolidation. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-omap2/cpuidle34xx.c | 85

[RFC][PATCH 6/9] ARM: OMAP3: cpuidle - remove cpuidle_params_table

We do not longer need the ''cpuidle_params_table' array as we defined the states in the driver and we checked they are all valid. We also remove the structure definition as it is no longer used. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-omap2/cpuidle34xx.c | 28

[RFC][PATCH 7/9] ARM: OMAP3: define statically the omap3_idle_data

Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-omap2/cpuidle34xx.c | 31 ++- 1 files changed, 30 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b/arch/arm/mach-omap2/cpuidle34xx.c index 877a7e1..34e1e34

[RFC][PATCH 8/9] ARM: OMAP3: cpuidle - use omap3_idle_data directly

statically, let's remove the initialization at startup too. Also, that simplfies the code. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-omap2/cpuidle34xx.c | 60 - 1 files changed, 6 insertions(+), 54 deletions(-) diff --git a/arch

[RFC][PATCH 9/9] ARM: OMAP3/4: consolidate cpuidle Makefile

Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-omap2/Makefile | 11 +++ arch/arm/mach-omap2/cpuidle34xx.c |8 arch/arm/mach-omap2/cpuidle44xx.c |8 arch/arm/mach-omap2/pm.h | 17 +++-- 4 files changed, 22

Re: [RFC][PATCH 4/9] ARM: OMAP3: define cpuidle statically

On 03/23/2012 01:35 PM, Jean Pihet wrote: On Fri, Mar 23, 2012 at 10:26 AM, Daniel Lezcano daniel.lezc...@linaro.org wrote: Use the new cpuidle API and define in the driver the states. Signed-off-by: Daniel Lezcanodaniel.lezc...@linaro.org --- [ ... ] /* * Erratum i583

[RFC][PATCH 0/7] OMAP4 cpuidle cleanup

This patchset is a proposition to improve a bit the code. The changes are code cleanup and does not change the behavior of the driver itself. A couple a things call my intention. Why the cpuidle device is set for cpu0 only and why the WFI is not used ? Daniel Lezcano (7): ARM: OMAP4: cpuidle

[RFC][PATCH 1/7] ARM: OMAP4: cpuidle - Remove unused valid field

The 'valid' field is never used in the code, let's remove it. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-omap2/cpuidle44xx.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b/arch/arm/mach-omap2

[RFC][PATCH 2/7] ARM: OMAP4: cpuidle - Declare the states with the driver declaration

The cpuidle API allows to declare statically the states in the driver structure. Let's use it. We do no longer need the fill_cstate function called at runtime and by the way adding more instructions at boot time. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-omap2

[RFC][PATCH 3/7] ARM: OMAP4: cpuidle - Remove the cpuidle_params_table table

We do not longer need this table as we defined the values in the driver states. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-omap2/cpuidle44xx.c | 11 +-- 1 files changed, 1 insertions(+), 10 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b

[RFC][PATCH 4/7] ARM: OMAP4: cpuidle - fix static omap4_idle_data declaration

Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-omap2/cpuidle44xx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b/arch/arm/mach-omap2/cpuidle44xx.c index 0455858..254f97b 100644 --- a/arch/arm/mach-omap2

[RFC][PATCH 5/7] ARM: OMAP4: cpuidle - Initialize omap4_idle_data at compile time

Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-omap2/cpuidle44xx.c | 19 ++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b/arch/arm/mach-omap2/cpuidle44xx.c index 254f97b..e14cd56 100644 --- a/arch

[RFC][PATCH 6/7] ARM: OMAP4: cpuidle - use the omap4_idle_data variable directly

. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-omap2/cpuidle44xx.c | 17 + 1 files changed, 5 insertions(+), 12 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b/arch/arm/mach-omap2/cpuidle44xx.c index e14cd56..cb91d1f 100644 --- a/arch/arm

[RFC][PATCH 7/7] ARM: OMAP4: cpuidle - remove omap4_idle_data initialization at boot time

We initialized it at compile time, no need to do that at boot time. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-omap2/cpuidle44xx.c | 26 +- 1 files changed, 1 insertions(+), 25 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle44xx.c

Re: [RFC][PATCH 1/7] ARM: OMAP4: cpuidle - Remove unused valid field

On 03/21/2012 10:41 AM, Shilimkar, Santosh wrote: On Wed, Mar 21, 2012 at 2:57 PM, Daniel Lezcano daniel.lezc...@linaro.org wrote: The 'valid' field is never used in the code, let's remove it. Signed-off-by: Daniel Lezcanodaniel.lezc...@linaro.org --- It is used during the registration

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

On 03/21/2012 10:36 AM, Shilimkar, Santosh wrote: On Wed, Mar 21, 2012 at 2:57 PM, Daniel Lezcano daniel.lezc...@linaro.org wrote: This patchset is a proposition to improve a bit the code. The changes are code cleanup and does not change the behavior of the driver itself. Thanks. Will have

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

On 03/21/2012 10:56 AM, Santosh Shilimkar wrote: On Wednesday 21 March 2012 03:21 PM, Daniel Lezcano wrote: On 03/21/2012 10:36 AM, Shilimkar, Santosh wrote: On Wed, Mar 21, 2012 at 2:57 PM, Daniel Lezcano daniel.lezc...@linaro.org wrote: This patchset is a proposition to improve a bit

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

On 03/21/2012 11:07 AM, Santosh Shilimkar wrote: Daniel, On Wednesday 21 March 2012 02:57 PM, Daniel Lezcano wrote: This patchset is a proposition to improve a bit the code. The changes are code cleanup and does not change the behavior of the driver itself. A couple a things call my intention

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

On 03/21/2012 11:49 AM, Shilimkar, Santosh wrote: On Wed, Mar 21, 2012 at 4:13 PM, Daniel Lezcano daniel.lezc...@linaro.org wrote: On 03/21/2012 10:56 AM, Santosh Shilimkar wrote: On Wednesday 21 March 2012 03:21 PM, Daniel Lezcano wrote: On 03/21/2012 10:36 AM, Shilimkar, Santosh wrote

Re: [RFC][PATCH 2/7] ARM: OMAP4: cpuidle - Declare the states with the driver declaration

On 03/21/2012 02:31 PM, Jean Pihet wrote: On Wed, Mar 21, 2012 at 10:27 AM, Daniel Lezcano daniel.lezc...@linaro.org wrote: The cpuidle API allows to declare statically the states in the driver structure. Let's use it. We do no longer need the fill_cstate function called at runtime

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

On 03/21/2012 02:19 PM, Jean Pihet wrote: Hi Santosh, Daniel, On Wed, Mar 21, 2012 at 11:07 AM, Santosh Shilimkar santosh.shilim...@ti.com wrote: Daniel, On Wednesday 21 March 2012 02:57 PM, Daniel Lezcano wrote: This patchset is a proposition to improve a bit the code. The changes are code

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

On 03/21/2012 02:43 PM, Jean Pihet wrote: On Wed, Mar 21, 2012 at 11:07 AM, Santosh Shilimkar santosh.shilim...@ti.com wrote: Daniel, On Wednesday 21 March 2012 02:57 PM, Daniel Lezcano wrote: This patchset is a proposition to improve a bit the code. The changes are code cleanup and does

  1   2   >