On 15/08/13 06:12, Joel Fernandes wrote:
On 08/14/2013 07:47 PM, Joe Perches wrote:
On Wed, 2013-08-14 at 18:40 -0500, Joel Fernandes wrote:
On 08/14/2013 06:29 PM, Joe Perches wrote:
On Wed, 2013-08-14 at 18:12 -0500, Joel Fernandes wrote:
When DEBUG is enabled, these macros can be used to
On 15/08/13 02:30, Joel Fernandes wrote:
On 08/14/2013 06:12 PM, Joel Fernandes wrote:
This patch series is a rewrite of the DMA portion of omap-aes driver
and also adds support for PIO mode. Both these modes, give better
performance than before.
Earlier, only a single SG was used for DMA
Thanks!
On Wed, Jun 8, 2011 at 4:08 PM, Herbert Xu herb...@gondor.apana.org.au wrote:
On Thu, Jun 02, 2011 at 09:10:02PM +0300, Dmitry Kasatkin wrote:
Hi,
Recently we got crashes few times after some other patches to 2.6.32 kernel.
This patch set greatly prevents race condition situations
Hi,
Recently we got crashes few times after some other patches to 2.6.32 kernel.
This patch set greatly prevents race condition situations.
No crashes are noticed any more.
Now the driver should be ok for multi core as well.
Regards,
Dmitry
Dmitry Kasatkin (11):
omap-sham: remove extra
From: Dmitry Kasatkin dmitry.kasat...@nokia.com
Request pointer is already available in the function.
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sham.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/crypto/omap-sham.c b
From: Dmitry Kasatkin dmitry.kasat...@nokia.com
Some flags are changed in interrupt handlers and verified in the tasklet.
There might be a race condition when tasklet is interrupted or another
cpu/core will run IRQ handler and tasklet in parallel.
Atomic bitops functions are now used instead
From: Dmitry Kasatkin dmitry.kasat...@nokia.com
Flags mask cannot be used with atomic bit operations.
This patch changes masks to bit numbers.
Atomic bit operations will be used by following patches.
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sham.c | 102
From: Dmitry Kasatkin dmitry.kasat...@nokia.com
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sham.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index b959dc6..84e5890 100644
From: Dmitry Kasatkin dmitry.kasat...@nokia.com
Calling omap_sham_handle_queue from done tasklet should be done
after irq scheduled tasklet completes.
Having additional tasklet does not solve that issue because it might
be execute before.
So queue handling tasklet has been removed
From: Dmitry Kasatkin dmitry.kasat...@nokia.com
It could be a situation, that tasklet is executed twice because of
certain delay between dma callback and irq handler execution.
In that case, second tasklet execution could actually corrupt the data
of the new started dma transactions.
This patch
From: Dmitry Kasatkin dmitry.kasat...@nokia.com
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sham.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index 7ca7075..804c16b
From: Dmitry Kasatkin dmitry.kasat...@nokia.com
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sham.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index 804c16b..6399a8f
From: Dmitry Kasatkin dmitry.kasat...@nokia.com
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sham.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index a8de7b8..7ca7075 100644
From: Dmitry Kasatkin dmitry.kasat...@nokia.com
Couple of context flags have been moved to device flags.
IRQ and tasklet handlers does not need to access request
context anymore.
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sham.c | 19
From: Dmitry Kasatkin dmitry.kasat...@nokia.com
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sham.c |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index 8a45fb7..ac12a60
Thanks.
On 26/04/11 09:36, ext Herbert Xu wrote:
On Wed, Apr 20, 2011 at 01:34:54PM +0300, Dmitry Kasatkin wrote:
Hi,
Here is few patches with couple of important fixes...
All applied. Thanks!
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message
Hi,
Here is few patches with couple of important fixes...
Regards,
Dmitry
Dmitry Kasatkin (3):
crypto: omap-sham - remove debug print
crypto: omap-sham - enable driver for EMU chips
crypto: omap-sham - hmac calculation bug fix for sha1 base hash
Markku Kylanpaa (1):
crypto: omap-sham
EMU chips also have crypto HW as HS chips.
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sham.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index 50aca41..f5c01dc 100644
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sham.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index e36032b..50aca41 100644
--- a/drivers/crypto/omap-sham.c
+++ b/drivers
From: Markku Kylanpaa ext-markku.kylan...@nokia.com
SHA1 accelerator can also be busy. Add -EBUSY status return option and
return busy status from omap_sham_finup().
Signed-off-by: Markku Kylanpaa ext-markku.kylan...@nokia.com
---
drivers/crypto/omap-sham.c |2 +-
1 files changed, 1
thanks
On 02/12/10 10:37, ext Herbert Xu wrote:
On Tue, Nov 30, 2010 at 10:13:26AM +0200, Dmitry Kasatkin wrote:
Changes to v1:
- omap type specific handling removed
- fixed backlog handling bug in redundunt locking is removed
- aes module initialized once per request instead of dma
Changes to v1:
- omap type specific handling removed
- fixed backlog handling bug in redundunt locking is removed
- aes module initialized once per request instead of dma transaction
more efficient and right way to do it
- checkpatch fixes in separate patch
Dmitry Kasatkin (6):
omap-aes: DMA
DMA parameters for constant data were initialized during driver probe().
It seems that those settings sometimes are lost when devices goes to off mode.
This patch makes DMA initialization just before use.
It solves off mode problems.
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
Previous version had not error handling.
Request could remain uncompleted.
Also in the case of DMA error, FLAGS_INIT is unset
and accelerator will be initialized again.
Buffer size allignment is checked.
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-aes.c
Submitting request involved double locking for enqueuing and
dequeuing. Now it is done under the same lock.
FLAGS_BUSY is now handled under the same lock.
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-aes.c | 70
Key and IV should always be set before AES operation.
So no need to check if it has changed or not.
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-aes.c | 70 +++--
1 files changed, 17 insertions(+), 53 deletions
Thanks.
On 27/11/10 10:39, ext Herbert Xu wrote:
On Fri, Nov 19, 2010 at 04:04:21PM +0200, Dmitry Kasatkin wrote:
Hi,
Here is a set of patches which provides fixes and improvements.
Based on Herbert feedback it also includes fixes so that calling final()
is not mandatory.
All
-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sham.c | 19 ++-
1 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index 370..9dfbc4a 100644
--- a/drivers/crypto/omap-sham.c
+++ b
Hi,
Here is a set of patches which provides fixes and improvements.
Based on Herbert feedback it also includes fixes so that calling final()
is not mandatory.
BR, Dmitry
Dmitry Kasatkin (8):
omap-sham: uses digest buffer in request context
omap-sham: DMA initialization fixes for off mode
possible HW failures.
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sham.c | 67 +---
1 files changed, 44 insertions(+), 23 deletions(-)
diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index 9dfbc4a
Locking for queuing and dequeuing is combined.
test_and_set_bit() is also replaced with checking under dd-lock.
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sham.c | 47 +++
1 files changed, 21 insertions(+), 26
buffer.
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sham.c | 87 +++-
1 files changed, 61 insertions(+), 26 deletions(-)
diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index d88d7eb..eb988e7 100644
,
and clocks will not be disabled.
This patch provides support for atomic crypto_ahash_update() call.
Clocks are now enabled and disabled per update request.
Data buffer is now allocated as a part of request context.
Client is obligated to free it with crypto_free_ahash().
Signed-off-by: Dmitry
bufcnt is 0 if it was no update requests before,
which is exact meaning of FLAGS_FIRST.
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sham.c |8 +---
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/drivers/crypto/omap-sham.c b/drivers
Hash-in-progress is now stored in hw format.
Only on final call, hash is converted to correct format.
Speedup copy procedure and will allow to use OMAP burst mode.
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sham.c | 38
Hi,
This patch was already applied months ago.
It appeared by mistake as git format-patch took it somehow.
Please ignore it...
- Dmitry
On 16/11/10 19:19, ext Tony Lindgren wrote:
* Dmitry Kasatkin dmitry.kasat...@nokia.com [101110 09:20]:
- registration with multi OMAP kernels support
Dmitry Kasatkin (5):
crypto: omap-aes: change in prevention of OCP bus error
omap-aes: DMA initialization fixes for OMAP off mode
omap-aes: redundant locking is removed
omap-aes: error handling implementation improved
omap-aes: unnecessary code removed
drivers/crypto/omap-aes.c | 269
Suggested to use udelay() instead of nop as on the higher
core frequencies it might not be enough time.
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-aes.c | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/omap
DMA parameters for constant data were initialized during driver probe().
It seems that those settings sometimes are lost when devices goes to off mode.
This patch makes DMA initialization just before use.
It solves off mode problems.
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
Key and IV should always be set before AES operation.
So no need to check if it has changed or not.
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-aes.c | 64 +++-
1 files changed, 16 insertions(+), 48 deletions(-)
diff
Dmitry Kasatkin (7):
crypto: updates omap sham device related platform code
crypto: omap-sham - omap sha1 md5 driver
omap-sham: OMAP macros corrected
omap-sham: uses digest buffer in request context
omap-sham: DMA initialization fixes for off mode
omap-sham: error handling improved
- registration with multi OMAP kernels support
- clocks
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
arch/arm/mach-omap2/clock2420_data.c |2 +-
arch/arm/mach-omap2/clock2430_data.c |2 +-
arch/arm/mach-omap2/clock3xxx_data.c |2 +-
arch/arm/mach
-sham.c
@@ -0,0 +1,1259 @@
+/*
+ * Cryptographic API.
+ *
+ * Support for OMAP SHA1/MD5 HW acceleration.
+ *
+ * Copyright (c) 2010 Nokia Corporation
+ * Author: Dmitry Kasatkin dmitry.kasat...@nokia.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
arch/arm/mach-omap2/devices.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index beac46c..79dbf04 100644
--- a/arch/arm/mach-omap2/devices.c
Currently driver storred digest results in req-results
provided by the client. But some clients do not set it
until final() call. It leads to crash.
Changed to use internal buffer to store temporary digest results.
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap
-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sham.c | 19 ++-
1 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index 370..9dfbc4a 100644
--- a/drivers/crypto/omap-sham.c
+++ b
possible HW failures.
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sham.c | 67 +---
1 files changed, 44 insertions(+), 23 deletions(-)
diff --git a/drivers/crypto
Locking for queuing and dequeuing is combined.
test_and_set_bit() is also replaced with checking under dd-lock.
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sham.c | 47 +++
1 files changed, 21 insertions(+), 26
-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sham.c | 19 ++-
1 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index 370..9dfbc4a 100644
--- a/drivers/crypto/omap-sham.c
+++ b
possible HW failures.
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sham.c | 67 +---
1 files changed, 44 insertions(+), 23 deletions(-)
diff --git a/drivers/crypto
Locking for queuing and dequeuing is combined.
test_and_set_bit() is also replaced with checking under dd-lock.
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sham.c | 47 +++
1 files changed, 21 insertions(+), 26
Samu Onkalo (1):
crypto: omap-sham: Adjust DMA parameters
drivers/crypto/omap-sham.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info
Hi,
Does anyone want to comment on this?
Thanks,
Dmitry
On 20/08/10 16:44, Kasatkin Dmitry (Nokia-MS/Helsinki) wrote:
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
arch/arm/mach-omap2/clock2420_data.c |2 +-
arch/arm/mach-omap2/clock2430_data.c |2 +-
arch/arm/mach
To this actually.
Thanks
On 20/08/10 16:44, Kasatkin Dmitry (Nokia-MS/Helsinki) wrote:
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/Kconfig|8 +
drivers/crypto/Makefile |1 +
drivers/crypto/omap-aes.c | 948
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
arch/arm/mach-omap2/clock2420_data.c |2 +-
arch/arm/mach-omap2/clock2430_data.c |2 +-
arch/arm/mach-omap2/clock3xxx_data.c |2 +-
arch/arm/mach-omap2/devices.c| 71 ++
4 files
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/Kconfig|8 +
drivers/crypto/Makefile |1 +
drivers/crypto/omap-aes.c | 948 +
3 files changed, 957 insertions(+), 0 deletions(-)
create mode 100644 drivers
This set of patches provides implementation of the driver for
OMAP2/3 AES hw accelerator.
Dmitry Kasatkin (2):
crypto: updates to enable omap aes
crypto: omap-aes: OMAP2/3 AES hw accelerator driver
arch/arm/mach-omap2/clock2420_data.c |2 +-
arch/arm/mach-omap2/clock2430_data.c |2
Hi,
Hmm.. yes. in my first patch I had OMAP3 and 2
Should I send updated patch above that?
- Dmitry
On 05/05/10 21:38, ext Tony Lindgren wrote:
* Herbert Xu herb...@gondor.apana.org.au [100502 20:07]:
On Wed, Apr 28, 2010 at 05:18:05PM +0300, Dmitry Kasatkin wrote:
Changes to v4
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
arch/arm/mach-omap2/devices.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index beac46c..79dbf04 100644
--- a/arch/arm/mach-omap2/devices.c
On 10/05/10 15:14, ext Herbert Xu wrote:
On Mon, May 10, 2010 at 03:07:55PM +0300, Dmitry Kasatkin wrote:
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
arch/arm/mach-omap2/devices.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach
Changes to v4:
- concurrent requests support via queue
- hmac
- shash support removed
Dmitry Kasatkin (2):
crypto: updates omap sham device related platform code
crypto: omap-sham - omap sha1 md5 driver
arch/arm/mach-omap2/clock2420_data.c |2 +-
arch/arm/mach-omap2
-sham.c
@@ -0,0 +1,1259 @@
+/*
+ * Cryptographic API.
+ *
+ * Support for OMAP SHA1/MD5 HW acceleration.
+ *
+ * Copyright (c) 2010 Nokia Corporation
+ * Author: Dmitry Kasatkin dmitry.kasat...@nokia.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under
On 14/04/10 09:20, ext Herbert Xu wrote:
Dmitry Kasatkindmitry.kasat...@nokia.com wrote:
Earlier kernel contained omap sha1 and md5 driver, which was not maintained,
was not ported to new crypto APIs and removed from the source tree.
- implements async and sync crypto API using dma and
- registration with multi OMAP kernels support
- clocks
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
arch/arm/mach-omap2/clock2420_data.c |2 +-
arch/arm/mach-omap2/clock2430_data.c |2 +-
arch/arm/mach-omap2/clock3xxx_data.c |2 +-
arch/arm/mach
Hi,
BTW..
How will it work if those resource structures anyway conditionally
compiled for OMAP2 or 3 or 4?
only one structure will be compiled at once.
- Dmitry
On 30/03/10 12:41, ext Paul Walmsley wrote:
Hi Dmitry,
a few comments:
On Thu, 25 Mar 2010, Dmitry Kasatkin wrote
On 30/03/10 12:41, ext Paul Walmsley wrote:
Hi Dmitry,
a few comments:
On Thu, 25 Mar 2010, Dmitry Kasatkin wrote:
- registration
- clocks
Signed-off-by: Dmitry Kasatkindmitry.kasat...@nokia.com
---
arch/arm/mach-omap2/clock2420_data.c |2 +-
arch/arm/mach-omap2
- omap-sha1-md5 name changed to omap-sham match omap spec
- standard clock name ick in use
- style fixes
Dmitry Kasatkin (2):
crypto: updates omap sham device related platform code
crypto: omap-sham - omap sha1 md5 driver
arch/arm/mach-omap2/clock2420_data.c |2 +-
arch/arm/mach
- registration
- clocks
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
arch/arm/mach-omap2/clock2420_data.c |2 +-
arch/arm/mach-omap2/clock2430_data.c |2 +-
arch/arm/mach-omap2/clock3xxx_data.c |2 +-
arch/arm/mach-omap2/devices.c | 26
Earlier kernel contained omap sha1 and md5 driver, which was not maintained,
was not ported to new crypto APIs and removed from the source tree.
- implements async and sync crypto API using dma and cpu.
- supports multiple sham instances if available
Signed-off-by: Dmitry Kasatkin dmitry.kasat
On 23/03/10 13:32, ext Herbert Xu wrote:
On Wed, Mar 17, 2010 at 03:12:49PM +0200, Dmitry Kasatkin wrote:
Earlier kernel contained omap sha1 and md5 driver, which was not maintained,
was not ported to new crypto APIs and removed from the source tree.
This driver implements async and sync
Earlier kernel contained omap sha1 and md5 driver, which was not maintained,
was not ported to new crypto APIs and removed from the source tree.
This driver implements async and sync crypto API.
It still contains pr_debug() for debugging purpose.
Will be remove for integration.
Dmitry Kasatkin
Earlier kernel contained omap sha1 and md5 driver, which was not maintained,
was not ported to new crypto APIs and removed from the source tree.
This driver implements async and sync crypto API.
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/omap-sha1-md5.c | 1449
Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com
---
drivers/crypto/Kconfig |9 +
drivers/crypto/Makefile |2 ++
2 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index b08403d..4cca798 100644
--- a/drivers
73 matches
Mail list logo
