Re: [PATCH 00/27] Export I2C and OF module aliases in missing drivers

2015-07-30 Thread Dmitry Torokhov
On Thu, Jul 30, 2015 at 09:35:17AM -0700, Dmitry Torokhov wrote: Hi Javier, On Thu, Jul 30, 2015 at 06:18:25PM +0200, Javier Martinez Canillas wrote: Hello, Short version: This series add the missing MODULE_DEVICE_TABLE() for OF and I2C tables to export that information so

Re: [PATCH 00/27] Export I2C and OF module aliases in missing drivers

2015-07-30 Thread Dmitry Torokhov
Hi Javier, On Thu, Jul 30, 2015 at 06:18:25PM +0200, Javier Martinez Canillas wrote: Hello, Short version: This series add the missing MODULE_DEVICE_TABLE() for OF and I2C tables to export that information so modules have the correct aliases built-in and autoloading works correctly.

Re: [PATCH v3 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt

2015-07-27 Thread Dmitry Torokhov
On Mon, Jul 27, 2015 at 04:49:22PM +0530, Vignesh R wrote: On 07/27/2015 04:19 PM, Roger Quadros wrote: Hi, On 23/07/15 17:54, Vignesh R wrote: On am437x-gp-evm, pixcir touchscreen can wake the system from low power state by generating wake-up interrupt via pinctrl and IO daisy

Re: [PATCH 5/5] Input: tsc2005 - convert to gpiod

2015-07-27 Thread Dmitry Torokhov
On Wed, Jul 22, 2015 at 10:04:45PM +0200, Sebastian Reichel wrote: The GPIOD API can be used from boardcode, so that the DT check can be removed. To avoid breaking existing boardcode, _optional() variant has been chosen. For completly removing the DT check, the regulator has also been made

Re: [PATCH v2 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt

2015-07-20 Thread Dmitry Torokhov
On Mon, Jul 20, 2015 at 10:20:13AM +0530, Vignesh R wrote: On am437x-gp-evm, pixcir touchscreen can wake the system from low power state by generating wake-up interrupt via pinctrl and IO daisy chain. Add support for optional wakeup interrupt source by regsitering to automated wake IRQ

Re: [PATCH v2 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt

2015-07-20 Thread Dmitry Torokhov
On Sun, Jul 19, 2015 at 11:09:30PM -0700, Tony Lindgren wrote: * Vignesh R vigne...@ti.com [150719 21:53]: @@ -445,6 +443,8 @@ static struct pixcir_ts_platform_data *pixcir_parse_dt(struct device *dev) dev_dbg(dev, %s: x %d, y %d, gpio %d\n, __func__, pdata-x_max + 1,

Re: [PATCH 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt

2015-07-20 Thread Dmitry Torokhov
On Sun, Jul 19, 2015 at 11:05:07PM -0700, Tony Lindgren wrote: * Vignesh R vigne...@ti.com [150719 21:51]: On 7/18/2015 3:21 AM, Dmitry Torokhov wrote: I wonder if driver core should be responsible for clearing wake irq and also for clearing wakeup flag. AFAICU, wakeup flag

Re: [PATCH 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt

2015-07-17 Thread Dmitry Torokhov
Hi Vignesh, On Fri, Jul 17, 2015 at 12:10:40PM +0530, Vignesh R wrote: On am437x-gp-evm, pixcir touchscreen can wake the system from low power state by generating wake-up interrupt via pinctrl and IO daisy chain. Add support for optional wakeup interrupt source by regsitering to automated

Re: [PATCH 2/4] Input: tsc2005 - convert to regmap

2015-07-16 Thread Dmitry Torokhov
On Wed, Jul 15, 2015 at 02:13:26PM +0200, Sebastian Reichel wrote: -static int tsc2005_write(struct tsc2005 *ts, u8 reg, u16 value) -{ - u32 tx = ((reg | TSC2005_REG_PND0) 16) | value; - struct spi_transfer xfer = { - .tx_buf = tx, - .len=

Re: [PATCH 4/4] Input: tsc2005 - convert to gpiod

2015-07-15 Thread Dmitry Torokhov
On Thu, Jul 16, 2015 at 12:09:41AM +0200, Sebastian Reichel wrote: Hi, On Wed, Jul 15, 2015 at 02:34:04PM -0700, Dmitry Torokhov wrote: [...] if (np) { - ts-reset_gpio = of_get_named_gpio(np, reset-gpios, 0); - if (ts-reset_gpio == -EPROBE_DEFER

Re: [PATCH 3/4] Input: tsc2005 - simplify drvdata acquisition

2015-07-15 Thread Dmitry Torokhov
On Thu, Jul 16, 2015 at 12:02:21AM +0200, Sebastian Reichel wrote: Hi, On Wed, Jul 15, 2015 at 02:31:07PM -0700, Dmitry Torokhov wrote: On Wed, Jul 15, 2015 at 02:13:27PM +0200, Sebastian Reichel wrote: Do not convert device to spi_device just for getting the driver data, since

Re: [PATCH 3/4] Input: tsc2005 - simplify drvdata acquisition

2015-07-15 Thread Dmitry Torokhov
On Wed, Jul 15, 2015 at 02:13:27PM +0200, Sebastian Reichel wrote: Do not convert device to spi_device just for getting the driver data, since spi_get_drvdata() just calls dev_get_drvdata(). Even though at the moment they all share the same data I consider them logically different and so would

Re: [PATCH 4/4] Input: tsc2005 - convert to gpiod

2015-07-15 Thread Dmitry Torokhov
On Wed, Jul 15, 2015 at 02:13:28PM +0200, Sebastian Reichel wrote: Convert driver to descriptor based GPIO API. Also fix the after-probe reset GPIO state, so that the device is not kept in reset state. Signed-off-by: Sebastian Reichel s...@kernel.org ---

Re: [PATCH 2/4] Input: tsc2005 - convert to regmap

2015-07-15 Thread Dmitry Torokhov
On Wed, Jul 15, 2015 at 02:29:55PM -0700, Dmitry Torokhov wrote: Hi Sebastian, On Wed, Jul 15, 2015 at 02:13:26PM +0200, Sebastian Reichel wrote: /* read the coordinates */ - error = spi_sync(ts-spi, ts-spi_read_msg); + error = regmap_bulk_read(ts-regmap, TSC2005_REG_X, tsdata

Re: [PATCH 2/4] Input: tsc2005 - convert to regmap

2015-07-15 Thread Dmitry Torokhov
: tsc2005 - convert to regmap From: Sebastian Reichel s...@kernel.org Convert driver, so that it uses regmap instead of directly using spi_transfer for all register accesses. Signed-off-by: Sebastian Reichel s...@kernel.org Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com --- drivers/input

Re: Please revert 3eea8b5d68c801fec788b411582b803463834752 as it breaks touchscreen on n900.

2015-06-02 Thread Dmitry Torokhov
On Tue, Jun 02, 2015 at 10:58:45AM -0700, Dmitry Torokhov wrote: On Tue, Jun 02, 2015 at 11:44:47AM +0200, Maxime Ripard wrote: On Mon, Jun 01, 2015 at 02:32:13PM -0700, Dmitry Torokhov wrote: On Mon, Jun 01, 2015 at 11:22:26PM +0200, Maxime Ripard wrote: Hi Dmitry, On Mon, Jun

Re: Please revert 3eea8b5d68c801fec788b411582b803463834752 as it breaks touchscreen on n900.

2015-06-02 Thread Dmitry Torokhov
On Tue, Jun 02, 2015 at 11:44:47AM +0200, Maxime Ripard wrote: On Mon, Jun 01, 2015 at 02:32:13PM -0700, Dmitry Torokhov wrote: On Mon, Jun 01, 2015 at 11:22:26PM +0200, Maxime Ripard wrote: Hi Dmitry, On Mon, Jun 01, 2015 at 10:47:30AM -0700, Dmitry Torokhov wrote: On Mon, Jun 01

Re: Please revert 3eea8b5d68c801fec788b411582b803463834752 as it breaks touchscreen on n900.

2015-06-01 Thread Dmitry Torokhov
-- pinpointed [was Re: linux-n900 ... Maxime, can you suggest a fix? How about we do something like below (it needs a small edt-ft5x06 fixup that I'll send separately). Not tested. Thanks. -- Dmitry Input: improve parsing OF parameters for touchscreens From: Dmitry Torokhov dmitry.torok...@gmail.com

Re: Please revert 3eea8b5d68c801fec788b411582b803463834752 as it breaks touchscreen on n900.

2015-06-01 Thread Dmitry Torokhov
On Mon, Jun 01, 2015 at 10:27:40PM +0200, Pavel Machek wrote: On Mon 2015-06-01 10:47:30, Dmitry Torokhov wrote: On Mon, Jun 01, 2015 at 05:21:11PM +0200, Pavel Machek wrote: The 3eea8b5d68c801fec788b411582b803463834752 is just bad. You were very welcome to review

Re: Please revert 3eea8b5d68c801fec788b411582b803463834752 as it breaks touchscreen on n900.

2015-06-01 Thread Dmitry Torokhov
On Mon, Jun 01, 2015 at 11:22:26PM +0200, Maxime Ripard wrote: Hi Dmitry, On Mon, Jun 01, 2015 at 10:47:30AM -0700, Dmitry Torokhov wrote: On Mon, Jun 01, 2015 at 05:21:11PM +0200, Pavel Machek wrote: The 3eea8b5d68c801fec788b411582b803463834752 is just bad. You

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Dmitry Torokhov
On Fri, May 29, 2015 at 10:34:56PM +0200, Pavel Machek wrote: Hi! single DT, you don't even use that property in your driver, and now that you realise you meant something else, you want the code that not Pali, Sebastian. actually parse the *right* property and does the

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Dmitry Torokhov
On Fri, May 29, 2015 at 09:56:29PM +0200, Pavel Machek wrote: On Fri 2015-05-29 14:49:55, Felipe Balbi wrote: Hi, On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: Fix dts to match what the Linux kernel expects. This works around touchscreen problems in 4.1 linux on Nokia

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Dmitry Torokhov
On Fri, May 29, 2015 at 03:21:23PM -0500, Felipe Balbi wrote: On Fri, May 29, 2015 at 10:17:45PM +0200, Maxime Ripard wrote: On Fri, May 29, 2015 at 09:56:29PM +0200, Pavel Machek wrote: On Fri 2015-05-29 14:49:55, Felipe Balbi wrote: Hi, On Fri, May 29, 2015 at 09:32:11PM

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Dmitry Torokhov
On Fri, May 29, 2015 at 11:02:59PM +0200, Pavel Machek wrote: On Fri 2015-05-29 13:48:47, Dmitry Torokhov wrote: On Fri, May 29, 2015 at 10:34:56PM +0200, Pavel Machek wrote: Hi! single DT, you don't even use that property in your driver, and now that you realise you meant

[PATCH] mfd: menelaus: rmove incorrect __exit markups

2015-03-09 Thread Dmitry Torokhov
-by: Dmitry Torokhov dmitry.torok...@gmail.com --- drivers/mfd/menelaus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c index 9f01aef..5269ff2 100644 --- a/drivers/mfd/menelaus.c +++ b/drivers/mfd/menelaus.c @@ -1259,7 +1259,7

Re: [PATCH v6 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler

2015-02-03 Thread Dmitry Torokhov
On Fri, Jan 30, 2015 at 10:56:28AM +0530, Vignesh R wrote: On Wednesday 07 January 2015 11:19 AM, Vignesh R wrote: From: Brad Griffis bgrif...@ti.com TSC interrupt handler had udelay to avoid reporting of false pen-up interrupt to user space. This patch implements workaround

Re: [PATCH 1/3] input: tsc2007: Add pre-calibration, flipping and rotation

2015-01-15 Thread Dmitry Torokhov
On Thu, Jan 15, 2015 at 05:14:38PM +0100, Dr. H. Nikolaus Schaller wrote: Am 15.01.2015 um 15:38 schrieb Sebastian Reichel s...@kernel.org: Hi, On Thu, Jan 15, 2015 at 08:36:44AM +0100, Dr. H. Nikolaus Schaller wrote: 1. Perform conversion in input core rather than individual

Re: [PATCH 1/3] input: tsc2007: Add pre-calibration, flipping and rotation

2015-01-14 Thread Dmitry Torokhov
On Sat, Jan 10, 2015 at 03:15:39PM +0100, Belisko Marek wrote: Ping for input maintainer. DT changes was acked. Thanks. On Tue, Sep 30, 2014 at 10:17 PM, Marek Belisko ma...@goldelico.com wrote: This patch adds new parameters that allow to address typical hardware design differences: touch

Re: [PATCH v2 3/5] input: misc: add tps65218 power button driver

2014-12-27 Thread Dmitry Torokhov
On Fri, Dec 26, 2014 at 09:36:48PM -0600, Felipe Balbi wrote: With this driver, we can report KEY_POWER on AM437x SK. This patch has been tested with said board. Signed-off-by: Felipe Balbi ba...@ti.com Applied, thank you. --- Changes since v1: - Add device tree documentation

Re: [PATCH 3/5] input: misc: add tps65218 power button driver

2014-12-26 Thread Dmitry Torokhov
Hi Felipe, On Fri, Dec 26, 2014 at 01:28:22PM -0600, Felipe Balbi wrote: With this driver, we can report KEY_POWER on AM437x SK. This patch has been tested with said board. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/input/misc/Kconfig | 10 +++

Re: [PATCH v4 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-18 Thread Dmitry Torokhov
On Tue, Nov 18, 2014 at 02:30:05PM +, Lee Jones wrote: On Fri, 14 Nov 2014, Vignesh R wrote: In one shot mode, sequencer automatically disables all enabled steps at the end of each cycle. (both ADC steps and TSC steps) Hence these steps need not be saved in reg_se_cache for clearing

Re: [PATCH 06/10] input: touchscreen: edt-ft5x06: fix driver autoprobing

2014-11-18 Thread Dmitry Torokhov
Hi Felipe, On Tue, Nov 18, 2014 at 12:07:04PM -0600, Felipe Balbi wrote: i2c devices match against struct i2c_device_id even for CONFIG_OF case, so adding a struct of_device_id doesn't change anything. As a result, currently, edt-ft5x06 will not autoprobe if built as a module. Why doe snot

Re: [PATCH v2] input: touchscreen: edt-ft5x06: fix driver autoprobing

2014-11-18 Thread Dmitry Torokhov
module alias. In order to have this driver autoprobing again, we just need to add missing MODULE_ALIAS() entries to edt-ft5x06 driver. Thanks to Dmitry for noticing that it actually should autoprobe even with of_device_id. Cc: Dmitry Torokhov dmitry.torok...@gmail.com Cc: linux

Re: [PATCH v2] input: touchscreen: edt-ft5x06: fix driver autoprobing

2014-11-18 Thread Dmitry Torokhov
On Tue, Nov 18, 2014 at 02:03:40PM -0600, Felipe Balbi wrote: On Tue, Nov 18, 2014 at 11:59:02AM -0800, Dmitry Torokhov wrote: On Tue, Nov 18, 2014 at 01:27:42PM -0600, Felipe Balbi wrote: Because with OF we can pass more specific compatible flags (such as edt-ft5306) instead

Re: tsc2005 touchscreen: implement disable attribute

2014-11-09 Thread Dmitry Torokhov
On Sun, Nov 09, 2014 at 01:49:19PM +0100, Pali Rohár wrote: On Sunday 09 November 2014 13:40:25 Sebastian Reichel wrote: Hi, On Sun, Nov 09, 2014 at 12:56:37PM +0100, Pavel Machek wrote: Implement disable attribute for tsc2005 touchscreen. It is useful to avoid wakeups when phone is

Re: [PATCH] Input: palmas-pwrbutton: Fix typo in License

2014-09-15 Thread Dmitry Torokhov
On Mon, Sep 15, 2014 at 01:00:44PM -0500, Nishanth Menon wrote: On 09/15/2014 12:58 PM, Nishanth Menon wrote: Follow the license string convention indicated in include/linux/module.h (don't capitalize v). This fixes following randconfig warning: FATAL: modpost: GPL-incompatible module

Re: [PATCH V2 2/2] Input: misc: introduce palmas-pwrbutton

2014-09-12 Thread Dmitry Torokhov
On Thu, Sep 11, 2014 at 07:01:19AM -0500, Nishanth Menon wrote: Hi Dimtry, On 14:13-20140910, Dmitry Torokhov wrote: On Thu, Aug 21, 2014 at 02:01:43PM -0500, Nishanth Menon wrote: On 08/21/2014 01:03 PM, Dmitry Torokhov wrote: I believe I have taken care of other concerns on v2

Re: [PATCH V2 2/2] Input: misc: introduce palmas-pwrbutton

2014-09-10 Thread Dmitry Torokhov
Hi Nishanth, On Thu, Aug 21, 2014 at 02:01:43PM -0500, Nishanth Menon wrote: On 08/21/2014 01:03 PM, Dmitry Torokhov wrote: I believe I have taken care of other concerns on v2, but..Arrgh.. I did not reply to this comment.. BTW, I do not think you need to use of_node_get/put here, it's

Re: [PATCH V2 2/2] Input: misc: introduce palmas-pwrbutton

2014-08-21 Thread Dmitry Torokhov
Hi Nishanth, On Thu, Aug 21, 2014 at 11:02:15AM -0500, Nishanth Menon wrote: + + ret = input_register_device(input_dev); + if (ret) { + free_irq(irq, pwron); You can not use free_irq with devm-managed resources. As I mentioned, since you need manual unwinding, I'd rather

Re: [PATCH V2 2/2] Input: misc: introduce palmas-pwrbutton

2014-08-21 Thread Dmitry Torokhov
On Thu, Aug 21, 2014 at 12:37:15PM -0500, Nishanth Menon wrote: On 12:32-20140821, Murphy, Dan wrote: On 08/21/2014 12:19 PM, Menon, Nishanth wrote: On 08/21/2014 11:59 AM, Murphy, Dan wrote: [...] Ooops.. missed answering one addition statement: + of_property_read_u32(np,

Re: [PATCH 2/2] Input: misc: introduce palmas-pwrbutton

2014-08-18 Thread Dmitry Torokhov
Hi NIshanth, On Mon, Aug 18, 2014 at 03:13:30PM -0500, Nishanth Menon wrote: Many palmas family of PMICs have support for interrupt based power button. This allows the device to notify the processor of external push button events over the shared palmas interrupt. However, this event is

Re: [PATCH 1/2] doc: dt/bindings: input: introduce palmas power button description

2014-08-18 Thread Dmitry Torokhov
On Mon, Aug 18, 2014 at 03:13:29PM -0500, Nishanth Menon wrote: Many palmas family of PMICs have support for interrupt based power button. This allows the device to notify the processor of external push button events over the shared palmas interrupt. Document the hardware support for the

Re: TSC2004 driver

2014-08-06 Thread Dmitry Torokhov
Hi Michael, On Tue, Aug 05, 2014 at 12:06:40PM -0500, Michael Welling wrote: The TSC2004 driver has yet to appear in the mainline kernel. We have been using the driver referenced here as provided by TI: https://www.mail-archive.com/linux-omap@vger.kernel.org/msg22018.html Are there any

Re: TSC2004 driver

2014-08-06 Thread Dmitry Torokhov
On Wed, Aug 06, 2014 at 10:33:18PM +0200, Joachim Eastwood wrote: On 6 August 2014 21:37, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Michael, On Tue, Aug 05, 2014 at 12:06:40PM -0500, Michael Welling wrote: The TSC2004 driver has yet to appear in the mainline kernel. We have

Re: atmel_mxt_ts: defaulting irqflags to IRQF_TRIGGER_FALLING

2014-07-02 Thread Dmitry Torokhov
On Wed, Jul 2, 2014 at 4:54 AM, Nick Dyer nick.d...@itdev.co.uk wrote: On 02/07/14 11:49, Sekhar Nori wrote: On Tuesday 01 July 2014 09:44 PM, Stephen Warren wrote: On the Tegra systems I have, IRQF_TRIGGER_FALLING is the correct (or at least a valid) choice. That's probably because the Atmel

Re: [PATCH] input: touchscreen: ti_am335x_tsc: warn about incorrect spelling

2014-06-15 Thread Dmitry Torokhov
On Fri, Jun 13, 2014 at 07:23:55PM -0500, Felipe Balbi wrote: Hi, Here's another patch which has been pending for months. Sorry, lost track of this one, applied. On Mon, Nov 18, 2013 at 09:29:01AM -0600, Felipe Balbi wrote: In the hopes that people run new kernels on their devices,

Re: [PATCH 1/2] ARM: OMAP2+: remove unused omap4-keypad file and code

2014-05-29 Thread Dmitry Torokhov
On Mon, May 19, 2014 at 09:18:15AM -0700, Tony Lindgren wrote: * Dmitry Torokhov dmitry.torok...@gmail.com [140518 22:38]: On Sat, May 17, 2014 at 11:24:10PM +0200, Joachim Eastwood wrote: This has been unused since omap4 board files went away. Signed-off-by: Joachim Eastwood manab

Re: [PATCHv3 3/5] Input: tsc2005: convert driver to use devm_*

2014-05-18 Thread Dmitry Torokhov
On Sat, Apr 26, 2014 at 01:56:17AM +0200, Sebastian Reichel wrote: Simplify the driver by using managed resources for memory allocation of internal struct, input device allocation and irq request. Signed-off-by: Sebastian Reichel s...@kernel.org Applied, thank you. ---

Re: [PATCHv3 2/5] Input: tsc2005: use dev_err for error messages

2014-05-18 Thread Dmitry Torokhov
On Sat, Apr 26, 2014 at 01:56:16AM +0200, Sebastian Reichel wrote: Change some dev_dbg() invocations to dev_err() ones, because they are supposed to output error messages. Signed-off-by: Sebastian Reichel s...@kernel.org Applied, thank you. --- drivers/input/touchscreen/tsc2005.c | 4

Re: [PATCHv3 1/5] Input: add common DT binding for touchscreens

2014-05-18 Thread Dmitry Torokhov
On Tue, May 06, 2014 at 01:04:12AM +0200, Sebastian Reichel wrote: On Mon, May 05, 2014 at 12:51:39PM -0700, Dmitry Torokhov wrote: On Mon, May 05, 2014 at 12:41:26PM -0700, Tony Lindgren wrote: * Sebastian Reichel s...@kernel.org [140425 16:56]: Add common DT binding documentation

Re: [PATCH 1/2] ARM: OMAP2+: remove unused omap4-keypad file and code

2014-05-18 Thread Dmitry Torokhov
On Sat, May 17, 2014 at 11:24:10PM +0200, Joachim Eastwood wrote: This has been unused since omap4 board files went away. Signed-off-by: Joachim Eastwood manab...@gmail.com Tony, can I merge both through my tree? --- arch/arm/mach-omap2/devices.c | 33

Re: [PATCHv3 1/5] Input: add common DT binding for touchscreens

2014-05-05 Thread Dmitry Torokhov
On Mon, May 05, 2014 at 12:41:26PM -0700, Tony Lindgren wrote: * Sebastian Reichel s...@kernel.org [140425 16:56]: Add common DT binding documentation for touchscreen devices and implement input_parse_touchscreen_of_params, which parses the common properties and configures the input device

Re: [PATCH V2] regulator: fixed: update to devm_* API

2014-01-27 Thread Dmitry Torokhov
Hi Manish, On Tue, Jan 28, 2014 at 08:42:00AM +0530, Manish Badarkhe wrote: Update the code to use devm_* API so that driver core will manage resources. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- Changes since V1: 1. Updated driver to use devm_kzalloc to kstrdup. 2.

Re: [PATCH] regulator: fixed: Use devm_regulator_register

2014-01-26 Thread Dmitry Torokhov
Hi Manish, On Sat, Jan 25, 2014 at 11:35:54PM +0530, Manish Badarkhe wrote: Use devm_regulator_register instead of regulator_register which simplifies the code. ... and also breaks the driver: now you are freeing desc-name and desc-supply_name while regulator structures are still alive and can

Re: [PATCH 0/2] arm: am335x: am335x evm sk: add touchscreen DT node

2013-11-11 Thread Dmitry Torokhov
On Mon, Oct 21, 2013 at 03:13:22PM -0500, Felipe Balbi wrote: Hi, the following patches fix a typo on TSC/ADC DT binding while maintaining backwards compatibility and add support for the touchscreen available on am335x-evm-sk. Patches have been tested with am335x-evm-sk with a couple

Re: [PATCH v3 0/3] Input: omap-keypad: Wakeup capability and w/a for i689 errata.

2013-08-29 Thread Dmitry Torokhov
Hi Illia, On Tue, Aug 27, 2013 at 01:08:05PM +0300, Illia Smyrnov wrote: Hello Dmitry, could you take reviewed patches from this patchset? Reviewed patches: [PATCH v3 1/3] Input: omap-keypad: Enable wakeup capability for keypad. [PATCH v3 3/3] Input: omap-keypad: Setup irq type from DT

Re: [PATCH v3 0/3] Input: omap-keypad: Convert to threaded IRQ and cleanup

2013-08-26 Thread Dmitry Torokhov
On Wed, Jul 24, 2013 at 06:54:50PM +0300, Illia Smyrnov wrote: Replace unclear hardcoded values with bit field, convert to threaded IRQ and clear interrupts when open the keypad. Based on top of v3.11-rc2. Tested on OMAP4 SDP. Illia Smyrnov (3): Input: omap-keypad: Cleanup - use

Re: [PATCH v3 1/3] Input: omap-keypad: Enable wakeup capability for keypad.

2013-07-29 Thread Dmitry Torokhov
On Monday, July 29, 2013 09:04:41 PM Felipe Balbi wrote: Hi, On Mon, Jul 29, 2013 at 07:45:09PM +0300, Illia Smyrnov wrote: Enable/disable IRQ wake in suspend/resume handlers to make the keypad wakeup capable. Signed-off-by: Illia Smyrnov illia.smyr...@ti.com ---

Re: [PATCH v3 1/3] Input: omap-keypad: Enable wakeup capability for keypad.

2013-07-29 Thread Dmitry Torokhov
On Monday, July 29, 2013 10:13:24 PM Felipe Balbi wrote: Hi, On Mon, Jul 29, 2013 at 11:59:45AM -0700, Dmitry Torokhov wrote: @@ -439,12 +444,50 @@ static const struct of_device_id omap_keypad_dt_match[] = { MODULE_DEVICE_TABLE(of, omap_keypad_dt_match); #endif

Re: [PATCH v3 1/3] Input: omap-keypad: Enable wakeup capability for keypad.

2013-07-29 Thread Dmitry Torokhov
On Monday, July 29, 2013 11:36:05 PM Felipe Balbi wrote: Hi, On Mon, Jul 29, 2013 at 12:59:23PM -0700, Dmitry Torokhov wrote: @@ -439,12 +444,50 @@ static const struct of_device_id omap_keypad_dt_match[] = { MODULE_DEVICE_TABLE(of, omap_keypad_dt_match); #endif

Re: am335x: TSC ADC reworking including DT pieces, take 4

2013-06-11 Thread Dmitry Torokhov
Hi Samuel, On Tue, Jun 11, 2013 at 04:23:58PM +0200, Samuel Ortiz wrote: Hi Sebastian, On Tue, Jun 11, 2013 at 01:30:46PM +0200, Sebastian Andrzej Siewior wrote: I believe the whole thing should go via the MFD tree. It touches also input iio subsystem. I collected ACKs where I got some

Re: [PATCH 5/5] kfifo: log based kfifo API

2013-01-08 Thread Dmitry Torokhov
Hi Yuanhan, On Tue, Jan 08, 2013 at 10:57:53PM +0800, Yuanhan Liu wrote: The current kfifo API take the kfifo size as input, while it rounds _down_ the size to power of 2 at __kfifo_alloc. This may introduce potential issue. Take the code at drivers/hid/hid-logitech-dj.c as example:

Re: [GIT PULL] fbdev changes for 3.8

2012-12-16 Thread Dmitry Torokhov
On Sun, Dec 16, 2012 at 12:35:37PM -0800, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [121216 09:49]: * Dave Jones da...@redhat.com [121215 14:27]: On Sat, Dec 15, 2012 at 01:11:04PM -0800, Linus Torvalds wrote: On Fri, Dec 14, 2012 at 2:22 AM, Tomi Valkeinen

Re: [PATCH] Input: omap4-keypad: Remove the OMAP4_KBD_SYSCONFIG and OMAP4_KBD_SYSSTATUS

2012-11-26 Thread Dmitry Torokhov
On Mon, Nov 26, 2012 at 04:21:19PM +0530, Shubhrajyoti D wrote: The macros OMAP4_KBD_SYSSTATUS and OMAP4_KBD_SYSSTATUS are not used so remove them. They document the existing registers and do not add bloat to the generated objects so let's leave them be. Thanks. -- Dmitry -- To unsubscribe

Re: [PATCH] input: twl4030-pwrbutton: Change TWL4030_MODULE_PM_MASTER to TWL_MODULE_PM_MASTER

2012-11-24 Thread Dmitry Torokhov
On Tue, Nov 13, 2012 at 10:38:28AM +0100, Peter Ujfalusi wrote: To facilitate upcoming cleanup in twl stack. No functional changes. Applied, thank you Peter. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/input/misc/twl4030-pwrbutton.c | 3 +-- 1 file changed, 1

Re: [PATCH 0/2] ARM: OMAP: ads7846: fix pendown debounce setting

2012-11-21 Thread Dmitry Torokhov
On Wed, Nov 21, 2012 at 11:09:30AM -0800, Tony Lindgren wrote: * Dmitry Torokhov dmitry.torok...@gmail.com [121120 00:23]: On Mon, Nov 19, 2012 at 06:03:56PM +0200, Igor Grinberg wrote: Commit 97ee9f01 (ARM: OMAP: fix the ads7846 init code) have enabled the pendown GPIO debounce time

Re: [PATCH 0/2] ARM: OMAP: ads7846: fix pendown debounce setting

2012-11-20 Thread Dmitry Torokhov
On Mon, Nov 19, 2012 at 06:03:56PM +0200, Igor Grinberg wrote: Commit 97ee9f01 (ARM: OMAP: fix the ads7846 init code) have enabled the pendown GPIO debounce time setting by the below sequence: gpio_request_one() gpio_set_debounce() gpio_free() It also revealed a bug in the OMAP

[RFC/RFT] OMAP: N770: remove custom implementation of ads7846_get_pendown_state

2012-11-20 Thread Dmitry Torokhov
The default implementation matches exactly our custom one so we can switch to using the default one. As a bonus the driver will take care of setting GPIO line for us. Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com --- No hardware so not tested... Thanks! arch/arm/mach-omap1/board

Re: [PATCH v4 4/4] input: misc: introduce retu-pwrbutton

2012-11-20 Thread Dmitry Torokhov
Hi Aaro, On Sun, Nov 18, 2012 at 06:36:22PM +0200, Aaro Koskinen wrote: Add Retu power button driver. This patch (with minot edits) has been queued to 3.8. Thanks! -- Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to

Re: [PATCH v2 4/4] input: misc: introduce retu-pwrbutton

2012-10-31 Thread Dmitry Torokhov
Hi Aaro, On Wednesday, October 31, 2012 08:03:46 PM Aaro Koskinen wrote: Add Retu power button driver. Cc: linux-in...@vger.kernel.org Acked-by: Felipe Balbi ba...@ti.com Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/input/misc/Kconfig | 10 +++

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-30 Thread Dmitry Torokhov
On Tue, Oct 30, 2012 at 07:25:13PM +0200, Felipe Balbi wrote: On Tue, Oct 30, 2012 at 03:58:21PM +, Mark Brown wrote: But then this comes round to the mindless code that ought to be factored out :) Only the more interesting cases that do something unusual really register here.

Re: [PATCH] ti_tscadc: Match mfd sub devices to regmap interface

2012-10-30 Thread Dmitry Torokhov
On Tue, Oct 30, 2012 at 09:41:00PM -0700, Russ Dill wrote: On Wed, Oct 31, 2012 at 8:55 AM, Pantelis Antoniou pa...@antoniou-consulting.com wrote: The MFD parent device now uses a regmap, instead of direct memory access. Use the same method in the sub devices to avoid nasty surprises.

Re: [PATCHv5] Input: keypad: Add smsc ece1099 keypad driver

2012-10-29 Thread Dmitry Torokhov
On Mon, Oct 29, 2012 at 06:20:45PM +0200, Felipe Balbi wrote: Hi, On Mon, Oct 29, 2012 at 04:08:49PM +0530, Sourav Poddar wrote: +static int __devinit +smsc_probe(struct platform_device *pdev) +{ + struct device *dev = pdev-dev; + struct input_dev *input; + struct smsc_keypad

Re: [PATCHv5] Input: keypad: Add smsc ece1099 keypad driver

2012-10-29 Thread Dmitry Torokhov
On Mon, Oct 29, 2012 at 09:05:53PM +0200, Felipe Balbi wrote: Hi, On Mon, Oct 29, 2012 at 10:06:33AM -0700, Dmitry Torokhov wrote: [ big snip ] +static int __devexit smsc_remove(struct platform_device *pdev) +{ shouldn't you unregister the input device here

Re: [PATCHv4] Input: keypad: Add smsc ece1099 keypad driver

2012-10-24 Thread Dmitry Torokhov
Hi Sourav, On Fri, Oct 05, 2012 at 12:56:26PM +0530, Sourav Poddar wrote: From: G, Manjunath Kondaiah manj...@ti.com SMSC ECE1099 is a keyboard scan or GPIO expansion device.The device supports a keypad scan matrix of 23*8.This driver uses this device as a keypad driver. Tested on

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-24 Thread Dmitry Torokhov
On Wed, Oct 24, 2012 at 11:37:04AM +0300, Felipe Balbi wrote: Hi, On Tue, Oct 23, 2012 at 01:02:49PM -0700, Dmitry Torokhov wrote: On Tue, Oct 23, 2012 at 11:18:12AM +0200, Benoit Cousson wrote: Hi Dimitry, On 10/22/2012 05:50 PM, Dmitry Torokhov wrote: Hi Sourav

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-24 Thread Dmitry Torokhov
On Wed, Oct 24, 2012 at 02:54:23PM +0200, Linus Walleij wrote: On Tue, Oct 23, 2012 at 10:02 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: I have seen just in a few days 3 or 4 drivers having exactly the same change - call to devm_pinctrl_get_select_default(), and I guess I

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-24 Thread Dmitry Torokhov
On Wednesday, October 24, 2012 06:51:47 PM Linus Walleij wrote: On Wed, Oct 24, 2012 at 6:14 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wed, Oct 24, 2012 at 11:37:04AM +0300, Felipe Balbi wrote: - we ask another layer to allocate memory for us - we ask another layer to call

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-24 Thread Dmitry Torokhov
On Wednesday, October 24, 2012 07:52:16 PM Felipe Balbi wrote: Hi, On Wed, Oct 24, 2012 at 09:14:29AM -0700, Dmitry Torokhov wrote: snip No, I guess we ihave different understanding of what directly use means. This particular driver does directly use interrupts: it requests

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-24 Thread Dmitry Torokhov
On Wednesday, October 24, 2012 07:57:49 PM Felipe Balbi wrote: Hi, On Wed, Oct 24, 2012 at 09:18:01AM -0700, Dmitry Torokhov wrote: On Wed, Oct 24, 2012 at 02:54:23PM +0200, Linus Walleij wrote: On Tue, Oct 23, 2012 at 10:02 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-24 Thread Dmitry Torokhov
On Wednesday, October 24, 2012 10:10:42 PM Felipe Balbi wrote: That is a valid concern and we'll need to find a compromise here. As I said, WHAT ?? Silicon erratas are not a valid concern ? Power waste isn't a valid concern ? Tell that to the millions of devices shipped with Linux

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Dmitry Torokhov
On Tue, Oct 23, 2012 at 11:18:12AM +0200, Benoit Cousson wrote: Hi Dimitry, On 10/22/2012 05:50 PM, Dmitry Torokhov wrote: Hi Sourav, On Mon, Oct 22, 2012 at 06:43:00PM +0530, Sourav Poddar wrote: Adapt keypad to use pinctrl framework. Tested on omap4430 sdp with 3.7-rc1 kernel

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-22 Thread Dmitry Torokhov
when instantiating platform device? Thanks. Cc: Felipe Balbi ba...@ti.com Cc: Dmitry Torokhov dmitry.torok...@gmail.com Signed-off-by: Sourav Poddar sourav.pod...@ti.com --- v1-v2 - Added PROBE_DEFER check drivers/input/keyboard/omap4-keypad.c | 11 +++ 1 files changed, 11

Re: [PATCHv3 2/4] Input: keypad: Add smsc ece1099 keypad driver

2012-10-04 Thread Dmitry Torokhov
On Wed, Oct 03, 2012 at 11:26:46AM +0530, Poddar, Sourav wrote: Hi Dmitry, On Tue, Oct 2, 2012 at 11:48 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Sourav, On Mon, Oct 01, 2012 at 04:31:50PM +0530, Sourav Poddar wrote: From: G, Manjunath Kondaiah manj...@ti.com

Re: [PATCHv3 2/4] Input: keypad: Add smsc ece1099 keypad driver

2012-10-02 Thread Dmitry Torokhov
on omap5430 evm with 3.6-rc6 custom kernel. Cc: Dmitry Torokhov dmitry.torok...@gmail.com Cc: Benoit Cousson b-cous...@ti.com Cc: Felipe Balbi ba...@ti.com Cc: Santosh Shilimkar santosh.shilim...@ti.com Signed-off-by: G, Manjunath Kondaiah manj...@ti.com Signed-off-by: Sourav Poddar sourav.pod

Re: [PATCH] drivers: phy: add generic PHY framework

2012-09-26 Thread Dmitry Torokhov
On Wednesday, September 26, 2012 09:57:57 AM Joe Perches wrote: On Wed, 2012-09-26 at 20:31 +0530, Kishon Vijay Abraham I wrote: The PHY framework provides a set of API's for the PHY drivers to create/destroy a PHY and API's Just some trivial notes. diff --git a/drivers/phy/phy-core.c

Re: [PATCH v3 08/14] Input: twl4030-vibra: Support for DT booted kernel

2012-09-06 Thread Dmitry Torokhov
? Otherwise it looks good. Acked-by: Dmitry Torokhov dmitry.torok...@gmail.com Thanks. -- Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RESEND/PATCHv2] Input: omap-keypad: dynamically handle register offsets

2012-05-17 Thread Dmitry Torokhov
Hi Sourav, On Thu, May 17, 2012 at 07:01:49PM +0530, Poddar, Sourav wrote: Hi Dmitry, Gentle Ping on this.. The patch has been committed to my 'next' branch for 3.5 on 05/11/12: http://git.kernel.org/?p=linux/kernel/git/dtor/input.git;a=commit;h=f77621cc640a7c50b3d8c5254ecc5d91eaa99d0d

Re: [RESEND/PATCHv2] Input: omap-keypad: dynamically handle register offsets

2012-05-09 Thread Dmitry Torokhov
Hi Dmitry , On Wed, May 9, 2012 at 10:48 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Ho Sourav, On Thu, Apr 26, 2012 at 11:24:37AM +0530, Sourav Poddar wrote: -config KEYBOARD_OMAP4 -     tristate TI OMAP4 keypad support +config KEYBOARD_OMAP4+ I think this works

Re: [RESEND/PATCHv2] Input: omap-keypad: dynamically handle register offsets

2012-05-08 Thread Dmitry Torokhov
-custom kernel. Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: G, Manjunath Kondaiah manj...@ti.com Signed-off-by: Sourav Poddar sourav.pod...@ti.com Signed-off-by: Dmitry Torokhov d...@mail.ru --- drivers/input/keyboard/Kconfig|4 + drivers/input/keyboard/omap4-keypad.c | 102

Re: [PATCH RESEND] Input: omap-keypad: dynamically handle register offsets

2012-04-10 Thread Dmitry Torokhov
Hi Sourav, On Tue, Apr 03, 2012 at 10:52:26AM +0530, Sourav Poddar wrote: From: G, Manjunath Kondaiah manj...@ti.com Keypad controller register offsets are different for omap4 and omap5. Handle these offsets through static mapping and assign these mappings during run time. In addition to

Re: [PATCH RESEND] Input: omap-keypad: dynamically handle register offsets

2012-04-10 Thread Dmitry Torokhov
On Tue, Apr 10, 2012 at 11:39:43AM -0500, H Hartley Sweeten wrote: On Tuesday, April 10, 2012 9:24 AM, Dmitry Torokhov wrote: On Tue, Apr 03, 2012 at 10:52:26AM +0530, Sourav Poddar wrote: From: G, Manjunath Kondaiah manj...@ti.com Keypad controller register offsets are different

Re: [PATCH v2 3/4] drivers: input: Fix OMAP_GPIO_IRQ with gpio_to_irq() in ams_delta_serio_exit()

2012-03-20 Thread Dmitry Torokhov
macro. Fix this. Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com Care to ack this one? I'd like to apply all four as fixes at the end of the merge window so we can drop the old and now broken OMAP_GPIO_IRQ macro. Sure. Acked-by: Dmitry Torokhov d...@mail.ru Thanks. -- Dmitry

Re: [PATCH 1/2] input: keypad: move platform_data to linux/platform_data

2012-03-16 Thread Dmitry Torokhov
On Friday, March 16, 2012 07:56:28 PM Sourav Poddar wrote: From: Felipe Balbi ba...@ti.com This patch allows us to drop the OMAP depencendy from the OMAP4 keypad driver. Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Sourav Poddar sourav.pod...@ti.com ---

Re: [PATCH 1/2] input: keypad: move platform_data to linux/platform_data

2012-03-16 Thread Dmitry Torokhov
On Fri, Mar 16, 2012 at 11:08:43PM +0200, Felipe Balbi wrote: Hi, On Fri, Mar 16, 2012 at 09:36:19AM -0700, Dmitry Torokhov wrote: On Friday, March 16, 2012 07:56:28 PM Sourav Poddar wrote: From: Felipe Balbi ba...@ti.com This patch allows us to drop the OMAP depencendy from

Re: [PATCH 2/2] Input: omap-keypad: dynamically handle register offsets

2012-03-16 Thread Dmitry Torokhov
Hi Sourav, On Fri, Mar 16, 2012 at 07:56:29PM +0530, Sourav Poddar wrote: From: G, Manjunath Kondaiah manj...@ti.com Keypad controller register offsets are different for omap4 and omap5. Handle these offsets through static mapping and assign these mappings during run time. Signed-off-by:

Re: [PATCH v4 2/2] MFD: twl6040: Convert to i2c driver, and separate it from twl core

2012-03-04 Thread Dmitry Torokhov
(vibra, ASoC components). Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com Reviewed-by: Mark Brown broo...@opensource.wolfsonicro.com Acked-by: Tony Lindgren t...@atomide.com Acked-by: Samuel Ortiz sa...@linux.intel.com For input part: Acked-by: Dmitry Torokhov d...@mail.ru -- Dmitry

Re: [PATCH] input: serio: ams-delta: toggle keyboard power over GPIO

2011-12-22 Thread Dmitry Torokhov
On Wed, Dec 21, 2011 at 08:55:09PM +0100, Janusz Krzysztofik wrote: On Wednesday 21 of December 2011 at 20:09:45, Tony Lindgren wrote: * Janusz Krzysztofik jkrzy...@tis.icnet.pl [111220 13:39]: Don't use Amstrad Delta custom I/O functions once GPIO interface is available for the

Re: [PATCH 09/10] input: serio: ams-delta: Toggle keyboard power over GPIO

2011-12-12 Thread Dmitry Torokhov
jkrzy...@tis.icnet.pl Acked-by: Dmitry Torokhov d...@mail.ru --- arch/arm/mach-omap1/board-ams-delta.c |5 -- arch/arm/plat-omap/include/plat/board-ams-delta.h |2 - drivers/input/serio/ams_delta_serio.c | 45 +++- 3 files changed, 25 insertions

Re: [PATCH] input: ams_delta_serio: include linux/module.h

2011-11-09 Thread Dmitry Torokhov
On Wed, Nov 09, 2011 at 08:06:45PM +0200, Aaro Koskinen wrote: Fix the following compilation failure with v3.2-rc1 by including module.h: CC drivers/input/serio/ams_delta_serio.o drivers/input/serio/ams_delta_serio.c:33:15: error: expected declaration specifiers or '...' before

  1   2   >