Re: [PATCH V4] OMAP3+: SR Layer Cleanup

2011-05-25 Thread Gulati, Shweta
Hi, On Tue, May 24, 2011 at 5:22 PM, Cousson, Benoit b-cous...@ti.com wrote: On 5/23/2011 6:40 AM, Gulati, Shweta wrote: Benoit, On Fri, May 20, 2011 at 7:19 PM, Cousson, Benoitb-cous...@ti.com  wrote: Hi Shweta, On 5/13/2011 8:27 AM, Gulati, Shweta wrote: To set sr ntarget values

Re: [PATCH V4] OMAP3+: SR Layer Cleanup

2011-05-22 Thread Gulati, Shweta
Benoit, On Fri, May 20, 2011 at 7:19 PM, Cousson, Benoit b-cous...@ti.com wrote: Hi Shweta, On 5/13/2011 8:27 AM, Gulati, Shweta wrote: To set sr ntarget values  for all volt_domain, volt_table is retrieved by doing a look_up of 'vdd_name' field from omap_hwmod but voltage domain pointer

Re: [PATCH V4] OMAP3+: SR Layer Cleanup

2011-05-19 Thread Gulati, Shweta
Hi, On Thu, May 19, 2011 at 2:29 PM, Kevin Hilman khil...@ti.com wrote: Shweta Gulati shweta.gul...@ti.com writes: To set sr ntarget values  for all volt_domain, volt_table is retrieved by doing a look_up of 'vdd_name' field from omap_hwmod but voltage domain pointer does not belong to

Re: [PATCH V3] OMAP3+: SR Layer Cleanup

2011-05-12 Thread Gulati, Shweta
Kevin, On Thu, May 12, 2011 at 3:20 PM, Kevin Hilman khil...@ti.com wrote: Menon, Nishanth n...@ti.com writes: On Wed, May 11, 2011 at 04:12, Shweta Gulati shweta.gul...@ti.com wrote: To set sr ntarget values  for all volt_domain, volt_table is retrieved by doing a look_up of 'vdd_name'

Re: [PATCH V3] OMAP3+: SR Layer Cleanup

2011-05-12 Thread Gulati, Shweta
Hi, On Thu, May 12, 2011 at 5:11 PM, Cousson, Benoit b-cous...@ti.com wrote: Hi Shweta, On 5/11/2011 11:12 AM, Gulati, Shweta wrote: To set sr ntarget values  for all volt_domain, volt_table is retrieved by doing a look_up of 'vdd_name' field from omap_hwmod but voltage domain pointer does

Re: [PATCH V3] OMAP3+: SR Layer Cleanup

2011-05-12 Thread Gulati, Shweta
Hi, On Thu, May 12, 2011 at 6:19 PM, Gulati, Shweta shweta.gul...@ti.com wrote: Hi, On Thu, May 12, 2011 at 5:11 PM, Cousson, Benoit b-cous...@ti.com wrote: Hi Shweta, On 5/11/2011 11:12 AM, Gulati, Shweta wrote: To set sr ntarget values  for all volt_domain, volt_table is retrieved

Re: [PATCH] OMAP: Added recalculation of clock rate in 'clk_set_rate'

2011-05-11 Thread Gulati, Shweta
Hi, On Tue, May 10, 2011 at 7:12 PM, Avinash.H.M. avinas...@ti.com wrote: On Tue, May 10, 2011 at 04:25:19PM +0530, Gulati, Shweta wrote: Hi, On Sat, May 7, 2011 at 3:19 AM, Paul Walmsley p...@pwsan.com wrote: On Thu, 21 Apr 2011, Gulati, Shweta wrote: Yes, but in current code

Re: [PATCH V3] OMAP3+: SR Layer Cleanup

2011-05-11 Thread Gulati, Shweta
Hi, On Wed, May 11, 2011 at 10:06 PM, Todd Poynor toddpoy...@google.com wrote: On Wed, May 11, 2011 at 2:12 AM, Shweta Gulati shweta.gul...@ti.com wrote: ... diff --git a/arch/arm/mach-omap2/sr_device.c b/arch/arm/mach-omap2/sr_device.c index 2782d3f..65b2aae 100644 ---

Re: [PATCH] OMAP: Added recalculation of clock rate in 'clk_set_rate'

2011-05-10 Thread Gulati, Shweta
Hi, On Sat, May 7, 2011 at 3:19 AM, Paul Walmsley p...@pwsan.com wrote: On Thu, 21 Apr 2011, Gulati, Shweta wrote: Yes, but in current code clk_set_rate of dpll3_m2 - 'omap3_core_dpll_m2_set_rate' doesn't update clk.rate, I will submit patch fixing that bug and will make sure that set_rate

Re: [PATCH V2] OMAP2+: SR Layer Cleanup.

2011-05-09 Thread Gulati, Shweta
Hi, On Tue, May 10, 2011 at 5:52 AM, Menon, Nishanth n...@ti.com wrote: might be a bit late, but seeing that Kevin has'nt picked this up yet, a couple of cosmetic comments I think it might be great if it could be folded into one of kevin's patches. else, $subject - OMAP3+ and could you drop

Re: [PATCH] OMAP: Added recalculation of clock rate in 'clk_set_rate'

2011-04-21 Thread Gulati, Shweta
Hi, On Wed, Apr 20, 2011 at 7:05 PM, Janorkar, Mayuresh ma...@ti.com wrote: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Gulati, Shweta Sent: Wednesday, April 20, 2011 2:55 PM To: linux-omap@vger.kernel.org Cc

Re: [PATCH] OMAP: Added recalculation of clock rate in 'clk_set_rate'

2011-04-21 Thread Gulati, Shweta
Hi, On Wed, Apr 20, 2011 at 9:12 PM, Sergei Shtylyov sshtyl...@mvista.com wrote: Hello. On 20-04-2011 13:25, Shweta Gulati wrote: From: Gulati, Shwetashweta.gul...@ti.com Core Clk Tree shows incorrect Clk rates at OPP50, as in commit e07f469d284ca3d1f5dcf5438c22982be98bc071   Please

Re: [PATCH] OMAP: Added recalculation of clock rate in 'clk_set_rate'

2011-04-21 Thread Gulati, Shweta
Hi, On Thu, Apr 21, 2011 at 1:25 AM, Paul Walmsley p...@pwsan.com wrote: Hi On Wed, 20 Apr 2011, Shweta Gulati wrote: From: Gulati, Shweta shweta.gul...@ti.com Core Clk Tree shows incorrect Clk rates at OPP50, as in commit e07f469d284ca3d1f5dcf5438c22982be98bc071 calling of 'recalc

Re: [PATCH] OMAP2+: SR Layer Cleanup.

2011-04-07 Thread Gulati, Shweta
Hi, On Wed, Apr 6, 2011 at 9:03 PM, Kevin Hilman khil...@ti.com wrote: Hi Shweta, Shweta Gulati shweta.gul...@ti.com writes: As a part of Voltage Layer Cleanup Patches, submitted by Kevin Hilman, Voltage domain Information is removed from hwmod, So the patch removes 'vdd_name' info from

Re: [PATCH 2/2 v2] OMAP2/3: hwmod: fix gpio-reset timeouts seen during bootup.

2011-04-05 Thread Gulati, Shweta
Hi, On Tue, Apr 5, 2011 at 9:10 PM, Avinash.H.M avinas...@ti.com wrote: GPIO module expects the debounce clocks to be enabled during reset. It doesn't reset properly and timeouts are seen, if this clock isn't enabled during reset. Add the HWMOD_CONTROL_OPT_CLKS_IN_RESET flags to the GPIO

Re: Smartreflex on 'pm-wip/voltdm' Branch

2011-03-30 Thread Gulati, Shweta
Hi, On Mon, Mar 28, 2011 at 9:57 PM, Kevin Hilman khil...@ti.com wrote: Vishwa, Shweta, Vishwanath Sripathy vishwanath...@ti.com writes: [...] I am testing Smartreflex on your Branch 'pm-wip/voltdm'. There seems an issue with reading VP registers. For OMAP3 and OMAP4 reading debugfs

Smartreflex on 'pm-wip/voltdm' Branch

2011-03-28 Thread Gulati, Shweta
Kevin, I am testing Smartreflex on your Branch 'pm-wip/voltdm'. There seems an issue with reading VP registers. For OMAP3 and OMAP4 reading debugfs entries shows constant voltage. Logs are: OMAP3: # cat /debug/voltage/vdd_mpu_iva/curr_nominal_volt 120 # cat

Re: [PATCH 1/7] OMAP2+: hwmod: remove unused voltagedomain pointer

2011-03-24 Thread Gulati, Shweta
Kevin, On Mon, Mar 21, 2011 at 9:02 PM, Kevin Hilman khil...@ti.com wrote: Cousson, Benoit b-cous...@ti.com writes: Hi Kevin, On 3/19/2011 1:18 AM, Hilman, Kevin wrote: The voltage domain pointer currently in struct omap_hwmod is not used and does not belong here.  Instead, voltage domains

Re: [PATCH 1/7] OMAP2+: hwmod: remove unused voltagedomain pointer

2011-03-24 Thread Gulati, Shweta
Hi, On Thu, Mar 24, 2011 at 8:44 PM, Cousson, Benoit b-cous...@ti.com wrote: On 3/24/2011 3:00 PM, Hilman, Kevin wrote: Hi Shweta, Gulati, Shwetashweta.gul...@ti.com  writes: [...] And what about vdd_name? It should probably be removed as well. Yes, but it's currently used by the SR

Re: [PATCH] OMAP4: Add IVA OPP enteries with Updated Voltage Rail Values.

2011-03-04 Thread Gulati, Shweta
Hi, On Thu, Mar 3, 2011 at 8:11 PM, Nishanth Menon n...@ti.com wrote: Gulati, Shweta wrote, on 03/03/2011 07:37 PM: Hi, On Thu, Mar 3, 2011 at 3:53 PM, Menon, Nishanthn...@ti.com  wrote: On Thu, Mar 3, 2011 at 15:39, Gulati, Shwetashweta.gul...@ti.com  wrote: Hi, On Thu, Mar 3, 2011

Re: [PATCH 3/3] OMAP4: Enable Turbo and Nitro OPP for OMAP4

2011-03-03 Thread Gulati, Shweta
Hi, On Wed, Mar 2, 2011 at 9:24 PM, Kevin Hilman khil...@ti.com wrote: Menon, Nishanth n...@ti.com writes: On Wed, Feb 16, 2011 at 11:48, Shweta Gulati shweta.gul...@ti.com wrote: All OMAP4 boards support OPP-Turbo (800M) and OPP-Nitro (1G). s/All OMAP4/Almost all/ - there are a minority of

Re: [PATCH] OMAP4: Add IVA OPP enteries with Updated Voltage Rail Values.

2011-03-03 Thread Gulati, Shweta
Hi, On Thu, Mar 3, 2011 at 3:04 PM, Menon, Nishanth n...@ti.com wrote: On Thu, Mar 3, 2011 at 14:57, Shweta Gulati shweta.gul...@ti.com wrote: This Patch adds OPP enteries for IVA  in OMAP4 OPP Table and updates IVA voltage Rail values obtained from latest OMAP4430 Data Manual Operating

Re: [PATCH 1/3] OMAP4: Revise MPU Voltage rail values.

2011-03-03 Thread Gulati, Shweta
hi, On Wed, Mar 2, 2011 at 1:02 PM, Menon, Nishanth n...@ti.com wrote: On Wed, Feb 16, 2011 at 11:47, Shweta Gulati shweta.gul...@ti.com wrote: MPU voltage rail values are updated according to latest OMAP4430 Data Manual Operating Condition Addendum. looks like the latest is evolving :(. I

Re: [PATCH] OMAP4: Add IVA OPP enteries with Updated Voltage Rail Values.

2011-03-03 Thread Gulati, Shweta
Hi, On Thu, Mar 3, 2011 at 3:53 PM, Menon, Nishanth n...@ti.com wrote: On Thu, Mar 3, 2011 at 15:39, Gulati, Shweta shweta.gul...@ti.com wrote: Hi, On Thu, Mar 3, 2011 at 3:04 PM, Menon, Nishanth n...@ti.com wrote: On Thu, Mar 3, 2011 at 14:57, Shweta Gulati shweta.gul...@ti.com wrote

Re: [PATCH 4/4] OMAP: Voltage: Adaptive Body-Bias handlers

2011-03-03 Thread Gulati, Shweta
Hi, On Tue, Mar 1, 2011 at 11:00 PM, Turquette, Mike mturque...@ti.com wrote: On Mon, Feb 28, 2011 at 3:35 AM, Gulati, Shweta shweta.gul...@ti.com wrote: Hi, On Tue, Feb 22, 2011 at 1:17 AM, Turquette, Mike mturque...@ti.com wrote: On Mon, Feb 21, 2011 at 4:31 AM, Gulati, Shweta shweta.gul

Re: [PATCH 18/19] omap3630+: sr: add support for class 1.5

2011-03-01 Thread Gulati, Shweta
Hi, On Sat, Feb 19, 2011 at 5:31 PM, Nishanth Menon n...@ti.com wrote: Traditional SmartReflex AVS(Automatic Voltage Scaling) classes are: * Class 0 - Product test calibration        Silicon is calibration at production floor and fused with voltages        for each OPP * Class 1 - Boot time

Re: [PATCH 18/19] omap3630+: sr: add support for class 1.5

2011-03-01 Thread Gulati, Shweta
Hi, On Tue, Mar 1, 2011 at 3:47 PM, Menon, Nishanth n...@ti.com wrote: On Tue, Mar 1, 2011 at 15:23, Gulati, Shweta shweta.gul...@ti.com wrote: Hi, On Sat, Feb 19, 2011 at 5:31 PM, Nishanth Menon n...@ti.com wrote: Traditional SmartReflex AVS(Automatic Voltage Scaling) classes

Re: [PATCH 4/4] OMAP: Voltage: Adaptive Body-Bias handlers

2011-02-28 Thread Gulati, Shweta
Hi, On Tue, Feb 22, 2011 at 1:17 AM, Turquette, Mike mturque...@ti.com wrote: On Mon, Feb 21, 2011 at 4:31 AM, Gulati, Shweta shweta.gul...@ti.com wrote: Hi, On Fri, Feb 18, 2011 at 2:50 PM, Mike Turquette mturque...@ti.com wrote: Introduce voltage transition notification handlers

Re: [PATCH 0/3]: Update OPP Table and Voltage Rail Values

2011-02-28 Thread Gulati, Shweta
Hi, On Wed, Feb 16, 2011 at 11:46 AM, Shweta Gulati shweta.gul...@ti.com wrote: The series mainly does below: OMAP4 only       - Update MPU VOltage rail values for all OPPs       - Enable OPP-Nitro and OPP-Turbo for all boards OMAP2PLUS       -Replace hardcoded Voltage values in OPP Table

Re: [PATCH 06/19] omap3+: voltage: use volt_data pointer instead values

2011-02-24 Thread Gulati, Shweta
Hi, On Thu, Feb 24, 2011 at 10:58 AM, Gulati, Shweta shweta.gul...@ti.com wrote: Hi, On Sat, Feb 19, 2011 at 5:31 PM, Nishanth Menon n...@ti.com wrote: Voltage values can get confusing in meaning with various Smartreflex classes being active. Depending on the class used, the actual voltage

Re: [PATCH 06/19] omap3+: voltage: use volt_data pointer instead values

2011-02-23 Thread Gulati, Shweta
Hi, On Sat, Feb 19, 2011 at 5:31 PM, Nishanth Menon n...@ti.com wrote: Voltage values can get confusing in meaning with various Smartreflex classes being active. Depending on the class used, the actual voltage selected might be a variant. Hence pass the volt_data pointers through the

Re: [PATCH 4/4] OMAP: Voltage: Adaptive Body-Bias handlers

2011-02-21 Thread Gulati, Shweta
Hi, On Fri, Feb 18, 2011 at 2:50 PM, Mike Turquette mturque...@ti.com wrote: Introduce voltage transition notification handlers for Adaptive Body-Bias LDOs.  There is an ABB LDO for VDD_MPU on OMAP3630 and an ABB_LDO on VDD_MPU and VDD_IVA on OMAP4430. All of these LDOs are handled similary.

Re: [PATCH 2/3] OMAP: voltage: move plat/voltage.h to mach-omap2/voltage.h

2011-02-20 Thread Gulati, Shweta
Hi, On Mon, Feb 21, 2011 at 7:38 AM, Paul Walmsley p...@pwsan.com wrote: At this point in time, there's no reason for this header file to be in plat-omap/include/plat/voltage.h.  It should not be included by device drivers, and the code that uses it is currently all under mach-omap2/.

Re: [PATCH V4] OMAP3: PM: Set/clear T2 bit for Smartreflex on TWL

2011-02-16 Thread Gulati, Shweta
Jarkko, On Wed, Feb 16, 2011 at 5:15 PM, Jarkko Nikula jhnik...@gmail.com wrote: On Wed, 16 Feb 2011 11:22:09 +0530 Gulati, Shweta shweta.gul...@ti.com wrote: On Tue, Feb 15, 2011 at 8:59 PM, Jarkko Nikula jhnik...@gmail.com wrote: Probably discussed earlier but would it make more sense

Re: [PATCH V4] OMAP3: PM: Set/clear T2 bit for Smartreflex on TWL

2011-02-15 Thread Gulati, Shweta
Hi, On Tue, Feb 15, 2011 at 10:00 PM, Vishwanath Sripathy vishwanath...@ti.com wrote: -Original Message- From: linux-arm-kernel-boun...@lists.infradead.org [mailto:linux-arm- kernel-boun...@lists.infradead.org] On Behalf Of Jarkko Nikula Sent: Tuesday, February 15, 2011 8:47 PM To:

Re: [PATCH V4] OMAP3: PM: Set/clear T2 bit for Smartreflex on TWL

2011-02-15 Thread Gulati, Shweta
On Tue, Feb 15, 2011 at 8:59 PM, Jarkko Nikula jhnik...@gmail.com wrote: On Tue, 15 Feb 2011 17:16:52 +0200 Jarkko Nikula jhnik...@gmail.com wrote: Would it make more sense to set only the flag here and do the register writes when omap3_twl_init is executing? Then it's not so strict when the

Re: [PATCH] OMAP: Fix Memory Leaks in Smartreflex driver.

2011-02-14 Thread Gulati, Shweta
Any comments on this Patch?? On Tue, Feb 8, 2011 at 5:22 PM, Shweta Gulati shweta.gul...@ti.com wrote: This Patch frees all the dynamically allocated memory which couldn't have been released in some error hitting cases. Signed-off-by: Shweta Gulati shweta.gul...@ti.com ---  

Re: [PATCH 2/2] OMAP: PM: implement devices wakeup latency constraints APIs

2011-02-11 Thread Gulati, Shweta
Jean, On Fri, Feb 11, 2011 at 12:53 AM, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com Implement OMAP PM layer omap_pm_set_max_dev_wakeup_lat API by creating similar APIs at the omap_device and omap_hwmod levels. The omap_hwmod level call is the layer with access to the

Re: State of SDP4430 platform

2011-02-07 Thread Gulati, Shweta
Hi, On Sun, Jan 16, 2011 at 6:39 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: It's probably best if I just quote the boot log, and people see about fixing the masses of WARN_ON()s.  Notice that it completely obliterates the early part of the boot log due to the number of

Re: [query] smartreflex: No PMIC hook to init smartreflex

2011-01-31 Thread Gulati, Shweta
Sanjeev, On Mon, Jan 31, 2011 at 9:50 PM, Premi, Sanjeev pr...@ti.com wrote: -Original Message- From: Vishwanath Sripathy [mailto:vishwanath...@ti.com] Sent: Thursday, January 27, 2011 7:56 PM To: Menon, Nishanth; Premi, Sanjeev Cc: linux-omap@vger.kernel.org Subject: RE: [query]

Re: [PATCH V2] OMAP3: PM: Set/reset T2 bit for Smartreflex on TWL.

2011-01-31 Thread Gulati, Shweta
Abhilash, On Mon, Jan 31, 2011 at 7:19 PM, Koyamangalath, Abhilash abhilash...@ti.com wrote: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Gulati, Shweta Sent: Monday, January 24, 2011 11:07 AM To: linux-omap

Re: [PATCH] arm: Fix possible memory leak

2011-01-30 Thread Gulati, Shweta
Acked. Will make sure there is no Memory Leak issue in Smartreflex Driver. On Mon, Jan 31, 2011 at 12:56 AM, Stefan Weil w...@mail.berlios.de wrote: sr_info was allocated and needs a kfree before returning. This error was reported by cppcheck: arch/arm/mach-omap2/smartreflex.c:837: error:

Re: [query] smartreflex: No PMIC hook to init smartreflex

2011-01-27 Thread Gulati, Shweta
Sanjeev, On Thu, Jan 27, 2011 at 3:05 PM, Menon, Nishanth n...@ti.com wrote: Sanjeev, On Tue, Jan 25, 2011 at 20:55, Premi, Sanjeev pr...@ti.com wrote: While building the kernel at 2.6.37, i see this warning for omap3evm - with omap3630: Power Management for TI OMAP3. sr_init: No PMIC

Re: [PATCH] OMAP3: PM: Adding T2 enabling of smartreflex

2011-01-20 Thread Gulati, Shweta
On Wed, Jan 19, 2011 at 5:54 PM, Nishanth Menon n...@ti.com wrote: Gulati, Shweta wrote, on 01/19/2011 02:10 PM:     I cant see how disable_sr is usable, further as discussed in    http://marc.info/?l=linux-omapm=129424774929498w=2    http://marc.info/?l=linux-omapm=129424774929498w=2 we

FW: [PATCH V2] OMAP3:PM:Fix for Silicon bug on Context restore on OMAP3430

2009-10-20 Thread Gulati, Shweta
Any comments would be taken in. Thanks Regards Shweta -Original Message- From: Gulati, Shweta Sent: Tuesday, October 13, 2009 3:56 PM To: linux-omap@vger.kernel.org Cc: Gulati, Shweta; Gopinath, Thara Subject: [PATCH V2] OMAP3:PM:Fix for Silicon bug on Context restore on OMAP3430 From