Re: [PATCH 004/182] gpio: generic: factor into gpio_chip struct

2015-12-10 Thread Lee Jones
. > > Modify all users to handle the change and use a struct > gpio_chip directly. And while we're at it: replace all > container_of() dereferencing by gpiochip_get_data() and > registering the gpio_chip with gpiochip_add_data(). > > Cc: a...@kernel.org > Cc: Lee Jones <le

Re: [PATCH] regulator: tps65218: add support for LS3 current regulator

2015-11-26 Thread Lee Jones
com> > Cc: Liam Girdwood <lgirdw...@gmail.com> > Cc: Mark Brown <broo...@kernel.org> > Cc: Samuel Ortiz <sa...@linux.intel.com> > Cc: Lee Jones <lee.jo...@linaro.org> > --- > drivers/regulator/tps65218-regulator.c | 137 > +----

Re: [PATCH v2 3/3] [media] include/media: move platform_data to linux/platform_data/media

2015-11-16 Thread Lee Jones
t; drivers/media/platform/soc_camera/omap1_camera.c | 2 +- > drivers/media/platform/soc_camera/soc_camera_platform.c | 2 +- > drivers/media/platform/timblogiw.c| 2 +- > drivers/media/radio/radio-timb.c | 2

Re: [PATCH v2 1/3] iio:adc: add iio driver for Palmas (twl6035/7) gpadc

2015-10-13 Thread Lee Jones
gt; drivers/iio/adc/Kconfig| 9 + > > drivers/iio/adc/Makefile | 1 + > > drivers/iio/adc/palmas_gpadc.c | 818 > > + > > include/linux/mfd/palmas.h | 75 ++-- Acked-by: Lee Jones <lee.jo...@linaro.org> > >

Re: [PATCH 3/3] mfd: Add battery charger as subdevice to the tps65217.

2015-09-19 Thread Lee Jones
t;, > .of_compatible = "ti,tps65217-bl", > }, > + { > + .name = "tps65217-charger", > + .of_compatible = "ti,tps65217-charger", > + }, > }; > > /** -- Lee Jones Linaro STMicroelectronics Landing Team Lead L

Re: [PATCH 1/2] mfd: twl6040: Fix deferred probe handling for clk32k

2015-09-19 Thread Lee Jones
> Fixes: 68bab8662f49 ("mfd: twl6040: Optional clk32k clock handling") > Cc: Benoit Cousson <bcous...@baylibre.com> > Cc: Dr. H. Nikolaus Schaller <h...@goldelico.com> > Cc: Grazvydas Ignotas <nota...@gmail.com> > Cc: Lee Jones <lee.jo...@linar

Re: [PATCH 16/27] mfd: Export OF module alias information in missing drivers

2015-08-10 Thread Lee Jones
, }, {} }; +MODULE_DEVICE_TABLE(of, of_tps65218_match_table); static int tps65218_probe(struct i2c_client *client, const struct i2c_device_id *ids) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow

Re: [PATCH v4 1/2] extcon: palmas: Support GPIO based USB ID detection

2015-08-10 Thread Lee Jones
/extcon/extcon-usb-gpio.c | 1 + include/linux/mfd/palmas.h | 7 ++ 4 files changed, 126 insertions(+), 16 deletions(-) Acked-by: Lee Jones lee.jo...@linaro.org diff --git a/Documentation/devicetree/bindings/extcon/extcon-palmas.txt b/Documentation

Re: [PATCH v3] mfd: kill off set_irq_flags usage

2015-07-27 Thread Lee Jones
and this has been maintained although it is not clear that is really needed. There appears to be a great deal of blind copy and paste of this code. Signed-off-by: Rob Herring r...@kernel.org Cc: Samuel Ortiz sa...@linux.intel.com Acked-by: Lee Jones lee.jo...@linaro.org Acked-by: Linus Walleij

Re: [PATCH] mfd: Drop owner assignment from i2c_drivers

2015-07-10 Thread Lee Jones
, .of_match_table = of_match_ptr(wm8994_of_match), }, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH 09/15] mfd: kill off set_irq_flags usage

2015-06-11 Thread Lee Jones
and this has been maintained although it is not clear that is really needed. There appears to be a great deal of blind copy and paste of this code. Signed-off-by: Rob Herring r...@kernel.org Cc: Samuel Ortiz sa...@linux.intel.com Cc: Lee Jones lee.jo...@linaro.org Cc: Linus Walleij linus.wall

Re: [RFC v1 08/25] mfd: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc

2015-05-20 Thread Lee Jones
as this has been properly tested: Acked-by: Lee Jones lee.jo...@linaro.org diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c index 5991faddd3c6..e5f4ffaa5414 100644 --- a/drivers/mfd/ezx-pcap.c +++ b/drivers/mfd/ezx-pcap.c @@ -207,7 +207,7 @@ static void pcap_isr_work(struct

Re: [PATCH] mfd: Constify regmap and irq configuration data

2015-04-28 Thread Lee Jones
*da9055); -extern struct regmap_config da9055_regmap_config; +extern const struct regmap_config da9055_regmap_config; #endif /* __DA9055_CORE_H */ -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter

Re: [PATCH 3/3] mfd: menelaus: use macro for magic number

2015-03-30 Thread Lee Jones
)) + if (err VCORE_CTRL1_HW_NSW) menelaus-vcore_hw_mode = 1; else menelaus-vcore_hw_mode = 0; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from

Re: [PATCH 2/3] mfd: menelaus: drop support for SW controller VCORE

2015-03-30 Thread Lee Jones
int mV); extern int menelaus_set_vcore_hw(unsigned int roof_mV, unsigned int floor_mV); #define EN_VPLL_SLEEP(1 7) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe

Re: [PATCH 1/3] mfd: menelaus: delete omap_has_menelaus

2015-03-30 Thread Lee Jones
) defined(CONFIG_MENELAUS) -#define omap_has_menelaus() 1 -#else -#define omap_has_menelaus() 0 -#endif - #endif -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from

Re: [PATCH] mfd: twl6040: Remove wrong and unneeded platform:twl6040 modalias

2015-03-30 Thread Lee Jones
); MODULE_AUTHOR(Misael Lopez Cruz misael.lo...@ti.com); MODULE_AUTHOR(Jorge Eduardo Candelaria jorge.candela...@ti.com); MODULE_LICENSE(GPL); -MODULE_ALIAS(platform:twl6040); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook

Re: [PATCH 21/35 linux-next] mfd: constify of_device_id array

2015-03-23 Thread Lee Jones
osc_off_idle = { .board_config = osc_off_rconfig, }; -static struct of_device_id twl4030_power_of_match[] = { +static const struct of_device_id twl4030_power_of_match[] = { { .compatible = ti,twl4030-power, }, -- Lee Jones Linaro STMicroelectronics

Re: [PATCH] mfd: menelaus: rmove incorrect __exit markups

2015-03-10 Thread Lee Jones
= menelaus_id, }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v6 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2015-02-24 Thread Lee Jones
/ti_am335x_tscadc.h @@ -128,6 +128,7 @@ /* Sequencer Status */ #define SEQ_STATUS BIT(5) +#define CHARGE_STEP 0x11 #define ADC_CLK 300 #define TOTAL_STEPS 16 -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software

Re: [PATCH 04/15] twl4030_charger: use runtime_pm to keep usb phy active while charging.

2015-02-24 Thread Lee Jones
reference to the USB phy whenever the charger wants to use it as a current source. So this patch reverts the above commit, and adds the necessary runtime_pm calls. Signed-off-by: NeilBrown ne...@suse.de --- drivers/mfd/twl-core.c |9 - Acked-by: Lee Jones lee.jo

Re: [PATCH 13/14] mfd: twl-core: Constify struct regmap_config and reg_default array

2015-01-20 Thread Lee Jones
irq_base = 0; int status; unsignedi, num_slaves; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list

Re: [PATCH 14/14] mfd: twl6040: Constify struct regmap_config and reg_default array

2015-01-20 Thread Lee Jones
regmap_config twl6040_regmap_config = { .reg_bits = 8, .val_bits = 8, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH v6 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2015-01-20 Thread Lee Jones
: Acked-by: Lee Jones lee.jo...@linaro.org Can this patch be applied on its own? diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c index 467c80e1c4ae..e4e4b22eebc9 100644 --- a/drivers/mfd/ti_am335x_tscadc.c +++ b/drivers/mfd/ti_am335x_tscadc.c @@ -68,12 +68,6 @@ static

Re: [PATCH 12/14] mfd: tps65218: Constify struct regmap_config

2015-01-20 Thread Lee Jones
, .cache_type = REGCACHE_RBTREE, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org

Re: [PATCH 11/14] mfd: tps65217: Constify struct regmap_config

2015-01-20 Thread Lee Jones
+145,7 @@ int tps65217_clear_bits(struct tps65217 *tps, unsigned int reg, } EXPORT_SYMBOL_GPL(tps65217_clear_bits); -static struct regmap_config tps65217_regmap_config = { +static const struct regmap_config tps65217_regmap_config = { .reg_bits = 8, .val_bits = 8, -- Lee

Re: [PATCH 6/7] mfd: menelaus: make vcore and regulator controls internal

2015-01-20 Thread Lee Jones
2) +#define EN_DC2_SLEEP (1 1) +#define EN_VC_SLEEP (1 0) Better to use the BIT() macro for this kind of stuff. Please take this opportunity to use it. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs

Re: [PATCH 1/7] mfd: menelaus: delete omap_has_menelaus

2015-01-20 Thread Lee Jones
) defined(CONFIG_MENELAUS) -#define omap_has_menelaus() 1 -#else -#define omap_has_menelaus() 0 -#endif - #endif -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from

Re: [PATCH 2/7] mfd: menelaus: drop support for SW controller VCORE

2015-01-20 Thread Lee Jones
int mV); extern int menelaus_set_vcore_hw(unsigned int roof_mV, unsigned int floor_mV); #define EN_VPLL_SLEEP(1 7) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe

Re: [PATCH 5/7] mfd: menelaus: delete platform data support

2015-01-20 Thread Lee Jones
), void *data); extern void menelaus_unregister_mmc_callback(void); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 6/7] mfd: menelaus: make vcore and regulator controls internal

2015-01-20 Thread Lee Jones
On Tue, 20 Jan 2015, Lee Jones wrote: On Sat, 27 Dec 2014, Aaro Koskinen wrote: Make vcore and regulator control functions internal to the driver. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/mfd/menelaus.c | 13 +++-- include/linux/mfd/menelaus.h

Re: [PATCH 7/7] mfd: menelaus: use macro for magic number

2015-01-20 Thread Lee Jones
)) + if (err VCORE_CTRL1_HW_NSW) menelaus-vcore_hw_mode = 1; else menelaus-vcore_hw_mode = 0; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from

Re: [PATCH 0/7] Menelaus cleanup for DT, phase 1

2015-01-20 Thread Lee Jones
Documentation/devicetree/bindings/mfd/menelaus.txt Scrap that. Looks like I can't apply the other patches without 03/07. Please sort this out with Felipe and re-submit. Don't forget to apply my Ack to the patches I said I applied. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open

Re: [PATCH v6 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2015-01-20 Thread Lee Jones
On Tue, 20 Jan 2015, R, Vignesh wrote: On 1/20/2015 5:23 PM, Lee Jones wrote: On Wed, 07 Jan 2015, Vignesh R wrote: In one shot mode, sequencer automatically disables all enabled steps at the end of each cycle. (both ADC steps and TSC steps) Hence these steps need not be saved

Re: [PATCH 2/5] mfd: tps65218: make INT1 our status_base register

2015-01-18 Thread Lee Jones
j-keer...@ti.com Cc: Lee Jones lee.jo...@linaro.org Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/tps65218.c | 1 + 1 file changed, 1 insertion(+) Sorry for the delay. It's difficult to get a WiFi signal 2000m up in an Austrian mountain. :) Applied now, thanks. diff --git

Re: [PATCH 1/5] mfd: tps65218: make INT[12] and STATUS registers volatile

2015-01-18 Thread Lee Jones
be able to clear the interrupt, which will cause our IRQ line to be disabled due to IRQ throttling. Fixes: 44b4dc6 mfd: tps65218: Add driver for the TPS65218 PMIC Cc: sta...@vger.kernel.org # v3.15+ Cc: Keerthy j-keer...@ti.com Cc: Lee Jones lee.jo...@linaro.org Signed-off-by: Felipe Balbi

Re: [PATCH v4 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-18 Thread Lee Jones
+ 2 files changed, 6 insertions(+), 2 deletions(-) Code looks better now. Acked-by: Lee Jones lee.jo...@linaro.org What's the plan for this series? diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c index d877e777cce6..110038859a8d 100644 --- a/drivers/mfd

Re: [PATCH v3 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-13 Thread Lee Jones
16 -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH v3 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-11 Thread Lee Jones
@@ /* Sequencer Status */ #define SEQ_STATUS BIT(5) +#define CHARGE_STEP 0x11 #define ADC_CLK 300 #define TOTAL_STEPS 16 -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter

Re: [PATCH] mfd: twl4030-power: Fix poweroff with PM configuration enabled

2014-11-11 Thread Lee Jones
On Mon, 10 Nov 2014, Russell King - ARM Linux wrote: On Mon, Nov 10, 2014 at 12:40:19PM +, Lee Jones wrote: On Sun, 02 Nov 2014, Tony Lindgren wrote: Commit e7cd1d1eb16f (mfd: twl4030-power: Add generic reset configuration) enabled configuring the PM features for twl4030

Re: [PATCH 2/5] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler

2014-11-10 Thread Lee Jones
+- Acked-by: Lee Jones lee.jo...@linaro.org 2 files changed, 24 insertions(+), 35 deletions(-) diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c index 1aeac9675fe7..483fd97c0e0c 100644 --- a/drivers/input/touchscreen/ti_am335x_tsc.c +++ b

Re: [PATCH 3/5] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-10 Thread Lee Jones
@@ /* Sequencer Status */ #define SEQ_STATUS BIT(5) +#define CHARGE_STEP 0x11 #define ADC_CLK 300 #define TOTAL_STEPS 16 -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro

Re: [PATCH 3/5] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-10 Thread Lee Jones
On Mon, 10 Nov 2014, Lee Jones wrote: On Fri, 07 Nov 2014, Vignesh R wrote: In one shot mode, sequencer automatically disables all enabled steps at the end of each cycle. (both ADC steps and TSC steps) Hence these steps need not be saved in reg_se_cache for clearing these steps

Re: [PATCH] mfd: twl4030-power: Fix poweroff with PM configuration enabled

2014-11-10 Thread Lee Jones
to configure start-up\n); + err = twl_i2c_write_u8(TWL_MODULE_PM_MASTER, PWR_DEVOFF, TWL4030_PM_MASTER_P1_SW_EVENTS); if (err) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook

Re: [PATCH 2/4] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler

2014-11-03 Thread Lee Jones
300 #define TOTAL_STEPS 16 The header changes should be split between the two Input and MFD patches. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list

Re: [PATCH] mfd: twl4030-power: Fix poweroff with PM configuration enabled

2014-11-03 Thread Lee Jones
[...] -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] mfd: twl4030-power: Fix regression with missing compatible flag

2014-11-03 Thread Lee Jones
, .data = omap3_reset, }, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org

Re: [PATCH] mfd: ti_am335x_tscadc: Update logic in CTRL register for 5-wire TS

2014-09-24 Thread Lee Jones
__iomem *tscadc_base; int irq; int used_cells; /* 1-2 */ + int tsc_wires; int tsc_cell; /* -1 if not used */ int adc_cell; /* -1 if not used */ struct mfd_cell cells[TSCADC_CELLS]; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open

Re: [PATCH V2 3/3] mfd: palmas: Add support for optional wakeup

2014-09-18 Thread Lee Jones
; @@ -377,6 +378,7 @@ struct palmas_clk_platform_data { struct palmas_platform_data { int irq_flags; + int wakeirq; int gpio_base; /* bit value to be loaded to the POWER_CTRL register */ -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open

Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control

2014-09-17 Thread Lee Jones
. With this flag, the chip will + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the + system poweroffs. + +- ti,use_poweroff: Deprecated name for ti,system-power-controller Example: i2c1 { -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source

Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control

2014-09-17 Thread Lee Jones
On Wed, 17 Sep 2014, Sebastian Reichel wrote: On Wed, Sep 17, 2014 at 08:44:00AM -0700, Lee Jones wrote: On Wed, 17 Sep 2014, Nishanth Menon wrote: ti,system-power-controller is more or less the standard way of indicating that the PMIC is the system wide power controller and hence may

Re: [PATCH V2 2/2] mfd: twl4030-power: use 'ti,system-power-controller' as alternative way to support system power off

2014-09-17 Thread Lee Jones
; + if (of_property_read_bool(node, ti,use_poweroff)) return true; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH 2/2] mfd: twl4030-power: use 'ti,system-power-controller' as alternative way to support system power off

2014-09-16 Thread Lee Jones
; + if (of_property_read_bool(node, ti,system-power-controller)) + return true; + if (of_property_read_bool(node, ti,use_poweroff)) return true; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow

Re: [PATCH] mfd: palmas: Add support for optional wakeup

2014-09-02 Thread Lee Jones
On Mon, 01 Sep 2014, Nishanth Menon wrote: On 09/01/2014 04:32 AM, Lee Jones wrote: On Fri, 29 Aug 2014, Nishanth Menon wrote: On 08/29/2014 05:56 AM, Lee Jones wrote: On Tue, 19 Aug 2014, Nishanth Menon wrote: With the recent pinctrl-single changes, omaps can treat wake-up events from

Re: [PATCH] mfd: palmas: Add support for optional wakeup

2014-09-01 Thread Lee Jones
On Fri, 29 Aug 2014, Nishanth Menon wrote: On 08/29/2014 05:56 AM, Lee Jones wrote: On Tue, 19 Aug 2014, Nishanth Menon wrote: With the recent pinctrl-single changes, omaps can treat wake-up events from deeper idle states as interrupts. Let's add support for the optional second

Re: [PATCH] mfd: palmas: Add support for optional wakeup

2014-08-29 Thread Lee Jones
irq_lock; struct regmap_irq_chip_data *irq_data; @@ -377,6 +378,7 @@ struct palmas_clk_platform_data { struct palmas_platform_data { int irq_flags; + int wakeirq; int gpio_base; /* bit value to be loaded to the POWER_CTRL register */ -- Lee Jones

Re: [PATCH] mfd: twl4030-power: Fix PM idle pin configuration to not conflict with regulators

2014-08-20 Thread Lee Jones
--- Lee, can you please pick this one for the v3.17-rc series? Applied with Aaro's Tested-by. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v3 3/3] MAINTAINERS: Add dwc3-st.c file to ARCH/STI architecture

2014-07-23 Thread Lee Jones
On Wed, 23 Jul 2014, Peter Griffin wrote: Signed-off-by: Peter Griffin peter.grif...@linaro.org --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) Acked-by: Lee Jones lee.jo...@linaro.org diff --git a/MAINTAINERS b/MAINTAINERS index 702ca10..269ad3b 100644 --- a/MAINTAINERS +++ b

Re: [PATCH v3 2/3] usb: dwc3: dwc3-st: Add st-dwc3 devicetree bindings documentation

2014-07-23 Thread Lee Jones
be phandle to system configuration node which + encompasses the glue registers This should be st,syscfg. As you have it in the example. Besides this small issue, I don't see anything controversial so once fixed up, you can apply my: Acked-by: Lee Jones lee.jo...@linaro.org -- Lee Jones

Re: [PATCH v3 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-07-23 Thread Lee Jones
minor. Once fixed apply my Ack on the next revision: Acked-by: Lee Jones lee.jo...@linaro.org -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line

Re: [PATCH v2 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-07-22 Thread Lee Jones
are planning on actioning everything and no not disagree with anything there's no need to reply at all. [...] -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send

Re: [PATCH v2 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-07-22 Thread Lee Jones
? Defines do the job in a manner which is a great deal cleaner: #define AUX_CLK_ENBIT(0) #define SW_PIPEW_RESET_N BIT(4) #define EXT_CFG_RESET_N BIT(8) #define XHCI_REVISION BIT(12) reg = AUX_CLK_EN | SW_PIPEW_RESET_N | XHCI_REVISION; reg = ~SW_PIPEW_RESET_N -- Lee Jones Linaro

Re: [PATCH v2 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-07-22 Thread Lee Jones
On Tue, 22 Jul 2014, Felipe Balbi wrote: On Tue, Jul 22, 2014 at 04:45:03PM +0100, Lee Jones wrote: +static void st_dwc3_init(struct st_dwc3 *dwc3_data) +{ + u32 reg = st_dwc3_readl(dwc3_data-glue_base, USB2_CLKRST_CTRL); + + reg |= aux_clk_en(1

Re: [PATCH v2 3/3] MAINTAINERS: Add dwc3-st.c file to ARCH/STI architecture

2014-07-10 Thread Lee Jones
On Thu, 10 Jul 2014, Felipe Balbi wrote: On Tue, Jul 08, 2014 at 08:53:32AM +0100, Lee Jones wrote: On Tue, 08 Jul 2014, Maxime Coquelin wrote: On 07/05/2014 08:25 AM, Peter Griffin wrote: Signed-off-by: Peter Griffin peter.grif...@linaro.org Acked-by: Maxime Coquelin maxime.coque

Re: [PATCH v2 3/3] MAINTAINERS: Add dwc3-st.c file to ARCH/STI architecture

2014-07-08 Thread Lee Jones
: drivers/i2c/busses/i2c-st.c F: drivers/tty/serial/st-asc.c +F: drivers/usb/dwc3/dwc3-st.c ARM/TECHNOLOGIC SYSTEMS TS7250 MACHINE SUPPORT M: Lennert Buytenhek ker...@wantstofly.org -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM

Re: [PATCH v2 3/3] MAINTAINERS: Add dwc3-st.c file to ARCH/STI architecture

2014-07-07 Thread Lee Jones
On Sat, 05 Jul 2014, Peter Griffin wrote: Signed-off-by: Peter Griffin peter.grif...@linaro.org --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) Acked-by: Lee Jones lee.jo...@linaro.org diff --git a/MAINTAINERS b/MAINTAINERS index 702ca10..269ad3b 100644 --- a/MAINTAINERS +++ b

Re: [PATCH v2 2/3] ARM: dts: sti: Add st-dwc3 devicetree bindings documentation

2014-07-07 Thread Lee Jones
= GIC_SPI 155 IRQ_TYPE_NONE; + + usb-phy = usb2_phy, usb3_phy; + }; +}; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v2 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-07-07 Thread Lee Jones
(st_dwc3_match), + .pm = st_dwc3_dev_pm_ops, + }, +}; + +module_platform_driver(st_dwc3_driver); + +MODULE_AUTHOR(Giuseppe Cavallaro peppe.cavall...@st.com); +MODULE_DESCRIPTION(DesignWare USB3 STi Glue Layer); +MODULE_LICENSE(GPL v2); -- Lee Jones Linaro STMicroelectronics Landing

Re: [PATCH V2 2/6] regulator: palmas: Rename reg_info to palmas_reg_info

2014-07-01 Thread Lee Jones
++-- include/linux/mfd/palmas.h |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) Acked-by: Lee Jones lee.jo...@linaro.org diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c index 91f60fa..05f11b9 100644 --- a/drivers/regulator

Re: [PATCH v2 7/9] regulator: palmas: Add palmas_pmic_driver_data structure

2014-06-27 Thread Lee Jones
is only enabled during conversion */ int ch3_current; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH v2 8/9] regulator: palmas: add driver data and modularize the probe

2014-06-27 Thread Lee Jones
. [...] -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 7/9] regulator: palmas: Add palmas_pmic_driver_data structure

2014-06-18 Thread Lee Jones
a 'of_regulator_match', rather than an 'of_match' pointer, which were my initial thoughts. I think it would have been weird to carry the 'of_match', but the reality sounds sane. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro

Re: [PATCH 3/9] mfd: palmas: Add tps65917 specific definitions and enums

2014-06-17 Thread Lee Jones
Add tps65917 specific definitions and enums. Signed-off-by: Keerthy j-keer...@ti.com --- include/linux/mfd/palmas.h | 793 1 file changed, 793 insertions(+) Acked-by: Lee Jones lee.jo...@linaro.org diff --git a/include/linux/mfd/palmas.h b

Re: [PATCH 4/9] mfd: palmas: Add tps65917 support

2014-06-17 Thread Lee Jones
-features = *driver_data-features; Once fixed, re-submit with my: Acked-by: Lee Jones lee.jo...@linaro.org -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line

Re: [PATCH 5/9] regulator: palmas: Shift the reg_info structure definition to the header file

2014-06-17 Thread Lee Jones
deletions(-) Patch looks fine. I guess we'll wait and pull the entire set in once it's ready. Acked-by: Lee Jones lee.jo...@linaro.org diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c index 9602eba..d41f3de 100644 --- a/drivers/regulator/palmas

Re: [PATCH 6/9] mfd: palmas: shift the palmas_sleep_requestor_info structure definition to the header file

2014-06-17 Thread Lee Jones
deletions(-) Acked-by: Lee Jones lee.jo...@linaro.org diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c index 485d755..f1f31d5 100644 --- a/drivers/mfd/palmas.c +++ b/drivers/mfd/palmas.c @@ -25,16 +25,6 @@ #include linux/mfd/palmas.h #include linux/of_device.h -#define

Re: [PATCH 7/9] regulator: palmas: Add palmas_pmic_driver_data structure

2014-06-17 Thread Lee Jones
*/ int ch3_current; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 8/9] regulator: palmas: add driver data and modularize the probe

2014-06-17 Thread Lee Jones
, normally with the struct defines above the ints etc. [...] -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [GIT PULL] mfd: Immutable branch between MFD and OMAP, due for v3.16

2014-06-16 Thread Lee Jones
that also at some point :) Sorry Tony. No problem, good to hear you got it figured out. Pull-request sent. Hopefully it's sorted now. bae14e7a2dcb726476b5020396923a24ccc4c40b -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs

Re: [GIT PULL] mfd: Immutable branch between MFD and OMAP, due for v3.16

2014-06-12 Thread Lee Jones
On Wed, 11 Jun 2014, Tony Lindgren wrote: * Lee Jones lee.jo...@linaro.org [140603 01:08]: On Mon, 02 Jun 2014, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [140528 11:11]: * Lee Jones lee.jo...@linaro.org [140528 00:14]: Thanks Tony, here's the pull-request

Re: [GIT PULL] mfd: Immutable branch between MFD and OMAP, due for v3.16

2014-06-12 Thread Lee Jones
On Thu, 12 Jun 2014, Tony Lindgren wrote: * Lee Jones lee.jo...@linaro.org [140612 00:48]: On Wed, 11 Jun 2014, Tony Lindgren wrote: * Lee Jones lee.jo...@linaro.org [140603 01:08]: On Mon, 02 Jun 2014, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [140528 11:11

Re: [PATCH 0/9] mfd: tps65917: Add support for for TPS65917 PMIC

2014-06-06 Thread Lee Jones
Hi Mark/Lee Jones, On Wednesday 28 May 2014 03:50 PM, Keerthy wrote: The TPS65917 chip is a power management IC for Portable Navigation Systems and Tablet Computing devices. It contains the following components: - Regulators. - GPADC. - Over Temperature warning and Shut down

Re: [GIT PULL] mfd: Immutable branch between MFD and OMAP, due for v3.16

2014-06-03 Thread Lee Jones
On Mon, 02 Jun 2014, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [140528 11:11]: * Lee Jones lee.jo...@linaro.org [140528 00:14]: Thanks Tony, here's the pull-request: The following changes since commit 455c6fdbd219161bd09b1165f11699d6d73de11c: Linux 3.14 (2014

Re: [PATCH v2 0/7] mfd: twl4030-power: Enable off-idle configuration when booted with device tree

2014-05-28 Thread Lee Jones
--scissors. It's not that - the patches would apply just fine individually. However my mailer stores the patches in date order, so when I use `git am mbox-folder` it attempts to apply them OoO. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow

[GIT PULL] mfd: Immutable branch between MFD and OMAP, due for v3.16

2014-05-28 Thread Lee Jones
| 4 + 5 files changed, 296 insertions(+), 86 deletions(-) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 5/5] regulator: tps65917: Add Regulator driver for tps65917 PMIC

2014-05-27 Thread Lee Jones
more to the palmas driver probe function. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH 4/5] mfd: palmas: Add tps65917 support

2014-05-27 Thread Lee Jones
-- Much nicer. You just saved yourself(/the subsystem) 420 lines! I have a single nit. Once it's fixed-up you can apply my: Acked-by: Lee Jones lee.jo...@linaro.org 1 file changed, 172 insertions(+), 5 deletions(-) diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c index

Re: [PATCH 3/5] mfd: palmas: Add tps65917 specific definitions and enums

2014-05-27 Thread Lee Jones
Add tps65917 specific definitions and enums. Signed-off-by: Keerthy j-keer...@ti.com --- include/linux/mfd/palmas.h | 793 1 file changed, 793 insertions(+) Looks okay to me: Acked-by: Lee Jones lee.jo...@linaro.org Do the MFD patches

Re: [PATCH v2 0/7] mfd: twl4030-power: Enable off-idle configuration when booted with device tree

2014-05-27 Thread Lee Jones
| 5 + drivers/mfd/twl4030-power.c| 269 +++-- include/linux/i2c/twl.h| 4 + 6 files changed, 284 insertions(+), 24 deletions(-) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source

Re: [PATCH v3 3/4] mfd: tps65917: Add driver for the TPS65917 PMIC

2014-05-23 Thread Lee Jones
the matter. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v3 3/4] mfd: tps65917: Add driver for the TPS65917 PMIC

2014-05-23 Thread Lee Jones
of an overhaul. This will exacerbate the matter. Okay. I am working on that. Thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: [PATCH v3 3/4] mfd: tps65917: Add driver for the TPS65917 PMIC

2014-05-22 Thread Lee Jones
merge it in with the palmas driver! -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH 5/7] mfd: twl4030-power: Add support for board specific configuration

2014-05-21 Thread Lee Jones
On Tue, 20 May 2014, Tony Lindgren wrote: * Lee Jones lee.jo...@linaro.org [140520 08:18]: Ah, I forgot to Ack this last time, didn't I? Acked-by: Lee Jones lee.jo...@linaro.org Yeah, here's this one updated with your ack. Has the code changed at all, or are you just reposting

Re: [PATCH v2 0/7] mfd: twl4030-power: Enable off-idle configuration when booted with device tree

2014-05-21 Thread Lee Jones
| 269 +++-- include/linux/i2c/twl.h| 4 + 6 files changed, 284 insertions(+), 24 deletions(-) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter

Re: [PATCH 5/7] mfd: twl4030-power: Add support for board specific configuration

2014-05-21 Thread Lee Jones
* Lee Jones lee.jo...@linaro.org [140520 08:18]: Ah, I forgot to Ack this last time, didn't I? Acked-by: Lee Jones lee.jo...@linaro.org Yeah, here's this one updated with your ack. Has the code changed at all, or are you just reposting with my Ack applied

Re: [PATCH v2 3/4] mfd: tps65917: Add driver for the TPS65917 PMIC

2014-05-20 Thread Lee Jones
/* __LINUX_MFD_TPS65917_H */ -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 1/7] mfd: twl4030-power: Fix hang on reboot if sleep configuration was loaded earlier

2014-05-20 Thread Lee Jones
configuration. Cc: Peter Ujfalusi peter.ujfal...@ti.com Signed-off-by: Tony Lindgren t...@atomide.com --- drivers/mfd/twl4030-power.c | 6 ++ 1 file changed, 6 insertions(+) Can't vouch for the semantics of the patch, but the code looks good. Acked-by: Lee Jones lee.jo...@linaro.org Can I just

Re: [PATCH 2/7] mfd: twl4030-power: Fix some defines for SW_EVENTS

2014-05-20 Thread Lee Jones
) +#define PWR_DEVSLP (1 1) #define PWR_DEVOFF (1 0) + #define SEQ_OFFSYNC (1 0) Please use the BIT() macro for these. [...] Once fixed, apply my Acked-by on re-submission. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source

Re: [PATCH 3/7] mfd: twl4030-power: Add generic reset configuration

2014-05-20 Thread Lee Jones
Cc: Samuel Ortiz sa...@linux.intel.com Cc: Lee Jones lee.jo...@linaro.org Signed-off-by: Tony Lindgren t...@atomide.com --- .../devicetree/bindings/mfd/twl4030-power.txt | 7 +- drivers/mfd/twl4030-power.c| 99 +++--- include/linux/i2c/twl.h

Re: [PATCH 4/7] mfd: twl4030-power: Add recommended idle configuration

2014-05-20 Thread Lee Jones
...@linux.intel.com Acked-by: Lee Jones lee.jo...@linaro.org Signed-off-by: Tony Lindgren t...@atomide.com --- .../devicetree/bindings/mfd/twl4030-power.txt | 4 + drivers/mfd/twl4030-power.c| 103 + 2 files changed, 107 insertions(+) Assuming

  1   2   3   >