Re: [PATCH 4/4] tty: Remove external interface for tty_set_termios()

there. > Do not use this interface to workaround UART driver bugs. > > Cc: Marcel Holtmann > Cc: Johan Hedberg > Cc: > Signed-off-by: Peter Hurley > --- > drivers/bluetooth/hci_ath.c | 15 ++- > drivers/tty/tty_ioctl.c | 3 +-- > include/linux/tty.h

Re: [PATCH] bluetooth: Add hci_h4p driver

Hi Pavel, >>> Add HCI driver for H4 with Nokia extensions. This device is used on >>> Nokia N900 cell phone. >>> >>> Older version of this driver lived in staging, before being reverted >>> in a4102f90e87cfaa3fdbed6fdf469b23f0eeb4bfd . >>> >>> Signed-off-by: Pavel Machek >>> Thanks-to: Sebastia

Re: [PATCH] bluetooth: Add hci_h4p driver

Hi Pavel, > Add HCI driver for H4 with Nokia extensions. This device is used on > Nokia N900 cell phone. > > Older version of this driver lived in staging, before being reverted > in a4102f90e87cfaa3fdbed6fdf469b23f0eeb4bfd . > > Signed-off-by: Pavel Machek > Thanks-to: Sebastian Reichel > Tha

Re: bluetooth: Add hci_h4p driver

Hi Pavel, >>> I have trouble understanding... h4p_hci_open() seems to be called as >>> soon as I insmod the driver. Who does that? Is it some kind of udev >>> magic? >> >> As soon as you do hci_register_dev, it will bring up the device and run the >> basic initialization. That is needed to get t

Re: [PATCH] bluetooth: Add hci_h4p driver

Hi Pavel, > Add hci_h4p bluetooth driver. This device is used for example on Nokia N900 > cell phone. the driver is called nokia_h4p. And you could be a little bit more verbose here explaining where the driver came from. > > Signed-off-by: Pavel Machek > Thanks-to: Sebastian Reichel > Thank

Re: bluetooth: Add hci_h4p driver

Hi Pavel, >> And you want to set the QUIRK_INVALID_BADDR. At least you want to do that in >> the final submission. >> > > Ok, I found out that I can do it and result works, provided that I do > hciconfig hci0 up/down first. that should not be the case. Actually hciconfig uses old ioctl. A full

Re: bluetooth: Add hci_h4p driver

Hi Pavel, > diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig > index 4547dc2..0fc7d3a 100644 > --- a/drivers/bluetooth/Kconfig > +++ b/drivers/bluetooth/Kconfig > @@ -243,4 +243,14 @@ config BT_WILINK > Say Y here to compile support for Texas Instrument's WiLink7 driver >

Re: bluetooth: Add hci_h4p driver

Hi Pavel, >>> Hacks surrounding bluetooth address were removed; this results in >>> working driver with address that is probably not unique. >> >> Just set HCI_QUIRK_INVALID_BDADDR and let someone deal with that in >> userspace. You can use the btmgmt public-addr command for testing. >> > > Ok

Re: bluetooth: Add hci_h4p driver

Hi Pavel, >>> My notes say that Marcel wanted different filenames, but I'd need >>> advice exactly what filenames. I guess platform data supprort should >>> be removed altogether, rather than renamed. >> >> Yes, the platform support should go away. This should be purely based on DT. >> >> Can yo

Re: bluetooth: Add hci_h4p driver

Hi Pavel, > Add hci_h4p bluetooth driver to staging tree. This device is used > for example on Nokia N900 cell phone. > > Signed-off-by: Pavel Machek > Thanks-to: Sebastian Reichel > Thanks-to: Joe Perches > > --- > > > I'd prefer to resurect the driver in staging/ in order not to lose > hi

Re: __hci_cmd_sync() not suitable for nokia h4p

Hi Pavel, >> What needs to be done is the bring up of the device including the proper >> UART settings and speed and then just run the firmware downloads. All >> firmware files on the Nokia devices where just HCI commands with vendor >> specific details. Some from CSR, some from

Re: __hci_cmd_sync() not suitable for nokia h4p

Hi Pavel, >>> h4p changes uart speed again after load of the firmware, but I guess >>> that's ok. > >> if you can do it the other way around it would result in a faster >> init. Depending on how many patches are actually required to be >> loaded. > > IIRC driver does two speed changes, so it loo

Re: __hci_cmd_sync() not suitable for nokia h4p

Hi Pavel, >>> The TODO file says: >>> >>> # > + >>> # > + skb_queue_tail(&info->txq, fw_skb); >>> # > + spin_lock_irqsave(&info->lock, flags); >>> # > + hci_h4p_outb(info, UART_IER, hci_h4p_inb(info, UART_IER) | >>> # > + UART_IER_THRI); >>> # > + spin_unlock_i

Re: BCM2048 bluetooth connected over OMAP serial

Hi Rob, >> So, there's bluetooth chip that's connected to the SoC by UART and some >> GPIOs. What would be right representation in the device tree? >> Something like this? >> >>bluetooth { >> compatible = "broadcom,bcm2048"; >> uart = <&uart2>; >>

Re: __hci_cmd_sync() not suitable for nokia h4p

Hi Pavel, >>> Major problem with Nokia H4P driver was, that it uses custom functions >>> instead of __hci_cmd_sync(). > >> the __hci_cmd_sync is for sending HCI commands and not low-level >> protocol transports like H:4 or similar. So you want to separate the >> actual transport of HCI from the f

Re: __hci_cmd_sync() not suitable for nokia h4p

Hi Pavel, > Major problem with Nokia H4P driver was, that it uses custom functions > instead of __hci_cmd_sync(). the __hci_cmd_sync is for sending HCI commands and not low-level protocol transports like H:4 or similar. So you want to separate the actual transport of HCI from the firmware loadi

Re: [PATCH 09/11] bluetooth: hci_ldisc: fix deadlock condition

ts with bluetooth-next / linux-next. If not, then I can let Greg take it through tty-next tree. Acked-by: Marcel Holtmann Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 01/20] sdio: add TI + wl1271 ids

Hi Ohad, > Add SDIO IDs for TI and for TI's wl1271 wlan device. > > Signed-off-by: Ohad Ben-Cohen > --- > include/linux/mmc/sdio_ids.h |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h > index 33b2ea0..0d