RE: [PATCH v2] arm: dts: AM43x: Add usb_otg_hs node

2013-07-09 Thread Mohammed, Afzal
Hi George, On Tue, Jul 09, 2013 at 14:47:26, Cherian, George wrote: + usb_otg_hs1: am4372_dwc3@4838 { Wouldn't usb a better node name ? + compatible = ti,am437x-dwc3; Usage of wild card is discouraged per DT documentation. Regards Afzal -- To

RE: [PATCH] ARM: omap: make am43xx build with SMP enabled

2013-06-24 Thread Mohammed, Afzal
Hi, On Mon, Jun 24, 2013 at 12:47:42, Tony Lindgren wrote: * Arnd Bergmann a...@arndb.de [130621 16:28]: With am43xx enabled, omap4 and omap5 disabled and SMP on, I get these build errors: arch/arm/mach-omap2/built-in.o: In function `scu_gp_set': :(.text+0x7858): undefined reference

RE: [PATCH] ARM: omap: make am43xx build with SMP enabled

2013-06-24 Thread Mohammed, Afzal
Hi Arnd, Tony, On Sat, Jun 22, 2013 at 04:52:47, Arnd Bergmann wrote: With am43xx enabled, omap4 and omap5 disabled and SMP on, I get these build errors: Getting AM43x only build with OMAP4/5 disabled was really difficult with original series itself, I thought finally had got a right Makefile

RE: [PATCH] ARM: OMAP2: reboot: Include common.h to fix build error

2013-06-20 Thread Mohammed, Afzal
Hi, On Wed, Jun 19, 2013 at 23:16:41, Axel Lin wrote: Include common.h which will include linux/reboot.h to fix below build error. CC arch/arm/mach-omap2/omap4-restart.o arch/arm/mach-omap2/omap4-restart.c:21:28: warning: 'enum reboot_mode' declared inside parameter list [enabled

RE: [PATCH v2 0/2] Remove unused voltagedomain data for AM33xx

2013-06-17 Thread Mohammed, Afzal
Hi, On Mon, Jun 17, 2013 at 18:46:21, Nayak, Rajendra wrote: The powerdomain framework currently expects to always have a voltagedomain associated with a given powerdomain. We already have AM33xx which has no Voltage Controller/Voltage Processor as part of PRCM. There are more SoCs' to

RE: [PATCH v2 02/14] ARM: OMAP2+: AM43x: Kconfig

2013-06-13 Thread Mohammed, Afzal
Hi Tony, On Wed, Jun 12, 2013 at 22:42:00, Tony Lindgren wrote: I've updated this patch to remove the default y and depends on ARCH_OMAP2PLUS entries for the usual reasons and applied the first ten patches into omap-for-v3.11/soc. Thanks. Patch 10 ARM: OMAP2+: AM43x: basic dt support is

RE: [PATCH v2 02/14] ARM: OMAP2+: AM43x: Kconfig

2013-06-13 Thread Mohammed, Afzal
Hi Tony, On Thu, Jun 13, 2013 at 15:24:54, Tony Lindgren wrote: * Mohammed, Afzal af...@ti.com [130613 00:04]: Patch 10 ARM: OMAP2+: AM43x: basic dt support is missing in omap-for-v3.11/soc branch and omap soc pull request, can you please help patch 10 also to go upstream. Hmm

RE: [PATCH v2 00/14] ARM: OMAP2+: AM43x initial support

2013-06-04 Thread Mohammed, Afzal
Hi Tony, On Mon, May 27, 2013 at 20:03:27, Mohammed, Afzal wrote: This series adds initial support for AM43x based SoC's. To boot AM43x, in addition to these patches, PRCM support is also needed, which would be posted later as a separate series. DT sources doesn't have ti,hwmod entry

RE: [PATCH v2 11/14] Documentation: dt: binding: omap: am43x timer

2013-06-03 Thread Mohammed, Afzal
Hi Benoit, On Wed, May 29, 2013 at 19:05:35, Cousson, Benoit wrote: And in this case, you do not introduce any new revision. There is no point to update the binding each time we add a new SoC variant that will contain the exact same IP. I think it will mainly confuse the user that will

RE: [PATCH v2 11/14] Documentation: dt: binding: omap: am43x timer

2013-05-29 Thread Mohammed, Afzal
Hi Jon, On Wed, May 29, 2013 at 03:35:10, Stephen Warren wrote: On 05/28/2013 03:25 PM, Jon Hunter wrote: ti,am335x-timer (applicable to AM335x devices) ti,am335x-timer-1ms (applicable to AM335x devices) + ti,am4372-timer-1ms,

RE: [PATCH v2 12/14] Documentation: dt: binding: omap: am43x counter

2013-05-29 Thread Mohammed, Afzal
Hi Jon, On Wed, May 29, 2013 at 02:56:05, Jon Hunter wrote: Changelog should state why this is needed. Please see my reply on 11/14 thread. Regards Afzal

RE: [PATCH v2 11/14] Documentation: dt: binding: omap: am43x timer

2013-05-29 Thread Mohammed, Afzal
Hi Benoit, On Wed, May 29, 2013 at 14:09:18, Cousson, Benoit wrote: On 05/29/2013 10:06 AM, Mohammed, Afzal wrote: On Wed, May 29, 2013 at 03:35:10, Stephen Warren wrote: On 05/28/2013 03:25 PM, Jon Hunter wrote: If you are adding more compatibility strings, then this implies

RE: [RFC 2/8] ARM: twd: register clock event for 1 core SMP

2013-02-19 Thread Mohammed, Afzal
Hi Rob, On Mon, Feb 18, 2013 at 19:17:29, Rob Herring wrote: On 02/18/2013 12:30 AM, Afzal Mohammed wrote: Register percpu local timer for scheduler tick in the case of one core SMP configuration. In other cases - secondary cpu's as well as boot cpu's having more than one core, this is

RE: [PATCH, RFC 7/8] ARM: dts: am4372: initial support

2013-02-19 Thread Mohammed, Afzal
Hi Felipe, On Mon, Feb 18, 2013 at 23:52:40, Balbi, Felipe wrote: On Mon, Feb 18, 2013 at 05:08:16PM +0530, Afzal Mohammed wrote: + uart1: serial@44e09000 { + compatible = ti,am4372-uart,ti,omap2-uart; + clock-frequency = 4800; +

RE: [PATCH, RFC 4/8] ARM: am33xx: ll debug config help

2013-02-19 Thread Mohammed, Afzal
Hi Santosh, On Tue, Feb 19, 2013 at 15:55:59, Shilimkar, Santosh wrote: With DT, IIRC DEBUGLL is broken. So did you hack debug-macro.S to get the earlyprintk working ? No, on linux-next, ll debug works properly. Regards Afzal N�r��yb�X��ǧv�^�)޺{.n�+{��f��{ay�ʇڙ�,j��f���h���z�

RE: [PATCH, RFC 8/8] ARM: dts: am43-pre-silicon support

2013-02-19 Thread Mohammed, Afzal
Hi Santosh, On Tue, Feb 19, 2013 at 16:05:22, Shilimkar, Santosh wrote: On Monday 18 February 2013 05:08 PM, Afzal Mohammed wrote: AM43 SoC is in pre-silicon stage, meanwhile it has been modelled in a pre-silicon platform. To validate and boot Linux in pre-silicon platform that emulates

RE: [PATCH, RFC 8/8] ARM: dts: am43-pre-silicon support

2013-02-19 Thread Mohammed, Afzal
Hi Santosh, On Tue, Feb 19, 2013 at 16:30:13, Shilimkar, Santosh wrote: On Tuesday 19 February 2013 04:22 PM, Mohammed, Afzal wrote: SoC support is already added in patch 7/8. This is board (which doesn't exist now) support, hence a pre-silicon temporary one to validate it. I mean we can

RE: [PATCH, RFC 0/8] ARM: AM43 (OMAP2+) boot support

2013-02-19 Thread Mohammed, Afzal
Hi Santosh, On Tue, Feb 19, 2013 at 15:39:32, Shilimkar, Santosh wrote: After looking at the specs, you don't need the SMP mode since ACP isn't being used. TWD use for AM437x is also limited because these times stops in low power sates and there you will need broad-cast mechanism which

RE: [PATCH v3 00/10] video: da8xx-fb: runtime timing configuration

2013-02-07 Thread Mohammed, Afzal
Hi Tomi, Florian, On Tue, Jan 15, 2013 at 19:00:50, Mohammed, Afzal wrote: This series makes da8xx-fb driver (device found on DaVinci and AM335x) capable of handling runtime timing configuration by adding fb_set_par. The last change adds actual fb_set_par support. Other preceeding changes

RE: DT GPMC SRAM and NOR flash support ?

2013-02-05 Thread Mohammed, Afzal
Hi Jon, On Tue, Feb 05, 2013 at 22:05:20, Hunter, Jon wrote: On 02/05/2013 10:16 AM, Mark Jackson wrote: There's plenty of DT support going in for NAND flash, but is there any work going on to support NOR flash ? If you'd anything in the pipeline, I'm glad to help in any testing. I've

RE: [PATCH v2 1/4] ARM: OMAP2+: dpll: round rate to closest value

2013-01-29 Thread Mohammed, Afzal
Hi Paul, On Fri, Jan 25, 2013 at 17:48:22, Mohammed, Afzal wrote: On Fri, Jan 25, 2013 at 13:48:11, Paul Walmsley wrote: like MPU CPUFreq. I'd suggest reverting 241d3a8dca239610d3d991bf58d4fe38c2d86fd5 or using a similar approach. As you prefer reverting the above commit, I will proceed

RE: RE: RE: [PATCH v4 12/12] video: da8xx-fb: CCF clock divider handling

2013-01-28 Thread Mohammed, Afzal
Hi Mike, On Sat, Jan 26, 2013 at 04:14:53, Mike Turquette wrote: I think Paul W. or someone on the TI side should weigh in on your clkdev entries. My main point is that the actual tree should be modeled and clocks shouldn't be globbed together unnecessarily. As mentioned in the other mail

RE: RE: RE: [PATCH v2 1/2] clk: divider: prepare for minimum divider

2013-01-28 Thread Mohammed, Afzal
Hi Mike, On Sat, Jan 26, 2013 at 04:05:24, Mike Turquette wrote: Thank you for the information. In short, the way you program your clock depend on the configuration of your lcdc device. As such I am not sure the basic divider is the right choice for you. You might be better off creating a

RE: RE: [PATCH v2 1/4] ARM: OMAP2+: dpll: round rate to closest value

2013-01-28 Thread Mohammed, Afzal
Hi Mike, On Sat, Jan 26, 2013 at 03:50:32, Mike Turquette wrote: Is MULT_ROUND_UP doing the right thing for you in the clk_divider code? What is the clock rate requested of the parent PLL? I just want to make sure that we're doing the right thing in the basic divider code. Actually

RE: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-28 Thread Mohammed, Afzal
Hi Rob, On Fri, Jan 25, 2013 at 20:22:55, Rob Clark wrote: On Fri, Jan 25, 2013 at 8:15 AM, Mohammed, Afzal af...@ti.com wrote: It's not about being simple, but not doing the wrong way, here you are relying on a platform specific clock in a driver, think about the case where same IP

RE: [PATCH 1/3] usb: otg: nop: add dt support

2013-01-28 Thread Mohammed, Afzal
Hi Michael, On Mon, Jan 28, 2013 at 03:10:05, Michael Grzeschik wrote: On Thu, Sep 27, 2012 at 11:15:05AM +0530, Afzal Mohammed wrote: From: B, Ravi ravib...@ti.com Added device tree support for nop transceiver driver and updated the Documentation with device tree binding information

RE: OMAP baseline test results for v3.8-rc5

2013-01-28 Thread Mohammed, Afzal
Hi, On Sat, Jan 26, 2013 at 14:16:04, Balbi, Felipe wrote: On Sat, Jan 26, 2013 at 08:40:07AM +, Paul Walmsley wrote: * am335xbone: hangs after Starting kernel - Cause unknown; may be due to CONFIG_EARLY_PRINTK=y? -

RE: OMAP baseline test results for v3.8-rc5

2013-01-28 Thread Mohammed, Afzal
Hi Felipe, On Mon, Jan 28, 2013 at 16:17:52, Balbi, Felipe wrote: will try your patch, but are you using Beagle Bone white or black ? I should've made it clear I'm using beagle bone black. Hmm.., I am using white, have never tried on black. Regards Afzal

RE: OMAP baseline test results for v3.8-rc5

2013-01-28 Thread Mohammed, Afzal
Hi Felipe, On Mon, Jan 28, 2013 at 17:08:19, Balbi, Felipe wrote: seems to be a bug with __unflatten_device_tree()... U-Boot# bootm 0x8020 - 0x80f8 Try loading dtb at a different address, I do, bootm 8100 - 8200 Regards Afzal

RE: OMAP baseline test results for v3.8-rc5

2013-01-28 Thread Mohammed, Afzal
Hi Felipe, On Mon, Jan 28, 2013 at 17:46:35, Balbi, Felipe wrote: didn't help :-s Hands up :( Regards Afzal

RE: RE: [PATCH v4 12/12] video: da8xx-fb: CCF clock divider handling

2013-01-25 Thread Mohammed, Afzal
Hi Mike, On Thu, Jan 24, 2013 at 22:30:44, Mike Turquette wrote: Quoting Mohammed, Afzal (2013-01-24 03:36:02) So there are 3 - LIDD is actually not for present use case, CORE could be clubbed with the divider to have a composite clock. And CORE is in functional clock path and logically

RE: RE: [PATCH v2 1/2] clk: divider: prepare for minimum divider

2013-01-25 Thread Mohammed, Afzal
Hi Mike, On Thu, Jan 24, 2013 at 22:36:30, Mike Turquette wrote: Quoting Mohammed, Afzal (2013-01-24 03:29:15) It is a functional constraint: divider has 8 bits and it can have all possible values (0 to 255) and divider value corresponds to value set in the 8 bits. But depending

RE: [PATCH v2 1/4] ARM: OMAP2+: dpll: round rate to closest value

2013-01-25 Thread Mohammed, Afzal
Hi Paul, On Fri, Jan 25, 2013 at 13:48:11, Paul Walmsley wrote: On Wed, 23 Jan 2013, Afzal Mohammed wrote: Currently round rate function would return proper rate iff requested rate exactly matches the PLL lockable rate. This causes set_rate to fail if exact rate could not be set. Instead

RE: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-25 Thread Mohammed, Afzal
Hi Rob, On Wed, Jan 23, 2013 at 04:06:22, Rob Clark wrote: A simple DRM/KMS driver for the TI LCD Controller found in various smaller TI parts (AM33xx, OMAPL138, etc). This driver uses the +void tilcdc_crtc_update_clk(struct drm_crtc *crtc) + /* in raster mode, minimum divisor is 2:

RE: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-25 Thread Mohammed, Afzal
Hi Rob, On Fri, Jan 25, 2013 at 19:29:40, Rob Clark wrote: On Fri, Jan 25, 2013 at 7:19 AM, Mohammed, Afzal af...@ti.com wrote: On Wed, Jan 23, 2013 at 04:06:22, Rob Clark wrote: A simple DRM/KMS driver for the TI LCD Controller found in various smaller TI parts (AM33xx, OMAPL138, etc

RE: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type

2013-01-25 Thread Mohammed, Afzal
Hi Kishon, On Thu, Jan 24, 2013 at 17:21:45, Mohammed, Afzal wrote: On Wed, Jan 23, 2013 at 19:56:37, ABRAHAM, KISHON VIJAY wrote: On Wednesday 23 January 2013 07:28 PM, Mohammed, Afzal wrote: USB first instance of am335x works in mainline as of now. Can you check if this series indeed

RE: [PATCH v2 1/2] clk: divider: prepare for minimum divider

2013-01-24 Thread Mohammed, Afzal
Hi Mike, On Thu, Jan 24, 2013 at 03:10:53, Mike Turquette wrote: Quoting Afzal Mohammed (2013-01-23 03:38:52) Some of clocks can have a limit on minimum divider value that can be programmed, prepare for such a support. Add a new field min_div for the basic divider clock and a new dynamic

RE: [PATCH v4 12/12] video: da8xx-fb: CCF clock divider handling

2013-01-24 Thread Mohammed, Afzal
Hi Mike, On Thu, Jan 24, 2013 at 01:52:04, Mike Turquette wrote: Quoting Afzal Mohammed (2013-01-23 03:48:56) +static inline void da8xx_fb_clkc_enable(void) +{ if (lcd_revision == LCD_VERSION_2) lcdc_write(LCD_V2_DMA_CLK_EN | LCD_V2_LIDD_CLK_EN |

RE: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type

2013-01-24 Thread Mohammed, Afzal
Hi Kishon, On Wed, Jan 23, 2013 at 19:56:37, ABRAHAM, KISHON VIJAY wrote: On Wednesday 23 January 2013 07:28 PM, Mohammed, Afzal wrote: USB first instance of am335x works in mainline as of now. Can you check if this series indeed breaks am335x? Thanks for your help. Do you have a tree

RE: [PATCH v3 00/12] video: da8xx-fb: am335x DT support

2013-01-23 Thread Mohammed, Afzal
Hi, On Wed, Jan 23, 2013 at 00:15:09, Rob Clark wrote: Wouldn't it be better to delete da8xx-fb.* and switch to Rob Clarks DRM based driver for this IP block? we probably can't delete da8xx-fb, but I think it would be ok to only use it for legacy platforms not yet ported to DT. We can't

RE: [PATCH v2 12/12] video: da8xx-fb: set upstream clock rate (if reqd)

2013-01-23 Thread Mohammed, Afzal
Hi Mike, On Wed, Jan 16, 2013 at 10:32:10, Nori, Sekhar wrote: On 1/15/2013 9:02 PM, Mike Turquette wrote: Quoting Afzal Mohammed (2013-01-15 05:44:36) Note: A better (if allowable) solution may be to represent clock divider in LCDC IP as a basic divider clock - the one defined in

RE: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type

2013-01-23 Thread Mohammed, Afzal
Hi Koen, On Tue, Jan 22, 2013 at 22:32:56, Koen Kooi wrote: Actually it uses nop-phy as a phy, which is missing from arch/arm/boot/dts/am33xx.dtsi, so mainline is already broken. But adding the nop-phy to the DT is easy enough to patch in locally. USB first instance of am335x works in

RE: [PATCH 08/10] video: da8xx-fb: obtain fb_videomode info from dt

2013-01-15 Thread Mohammed, Afzal
Hi Steffen, On Mon, Jan 07, 2013 at 14:51:15, Mohammed, Afzal wrote: On Mon, Jan 07, 2013 at 14:41:31, Steffen Trumtrar wrote: On Mon, Jan 07, 2013 at 10:41:30AM +0530, Afzal Mohammed wrote: +- display-timings: list of different videomodes supported by the lcd + panel, represented

RE: [PATCH 08/10] video: da8xx-fb: obtain fb_videomode info from dt

2013-01-07 Thread Mohammed, Afzal
Hi Steffen, On Mon, Jan 07, 2013 at 14:41:31, Steffen Trumtrar wrote: On Mon, Jan 07, 2013 at 10:41:30AM +0530, Afzal Mohammed wrote: Obtain fb_videomode details for the connected lcd panel using the display timing details present in DT. +- display-timings: list of different videomodes

usb: multi phy support

2013-01-07 Thread Mohammed, Afzal
Hi Felipe, AM335x SoC's used in boards like beagle bone has two instances of USB modules (2.0) at the hardware level, each having a dedicated phy. Currently in mainline, only one instance of USB is supported (including a fix in your latest pull request). To support multi instance, the biggest

RE: [PATCH] da8xx: Allow use by am33xx based devices

2013-01-07 Thread Mohammed, Afzal
Hi, On Wed, Dec 12, 2012 at 13:30:56, Hiremath, Vaibhav wrote: On Wed, Dec 12, 2012 at 12:50:28, Manjunathappa, Prakash wrote: Agreed, should not result in build error. But is it ok to show this option on the platforms which do not have this IP? You can choose to put machine

RE: [PATCH] usb: musb: dsps: header movement build error fix

2012-12-12 Thread Mohammed, Afzal
Hi Felipe, On Tue, Nov 27, 2012 at 20:15:22, Mohammed, Afzal wrote: 54db6ee ARM: OMAP2+: Introduce local usb.h moved control module bit definitions from plat/usb.h (which dsps glue was using) to a local header in mach-omap2. And in parallel, c68bb4c usb: musb: dsps: control module handling

RE: [PATCH 1/3] omap gpmc : add support of setting CYCLE2CYCLEDELAY and BUSTURNAROUND

2012-11-08 Thread Mohammed, Afzal
Hi Tony, On Thu, Nov 08, 2012 at 03:10:14, Tony Lindgren wrote: * Mohammed, Afzal af...@ti.com [121107 01:00]: And Daniel has started working on gpmc dt. Let us take Tony's opinion on how to deal with this, Tony ? Up to you to figure out the ordering. Maybe send pull requests

RE: [PATCH 1/3] omap gpmc : add support of setting CYCLE2CYCLEDELAY and BUSTURNAROUND

2012-11-07 Thread Mohammed, Afzal
+ Tony, Daniel Hi, On Wed, Nov 07, 2012 at 02:04:03, Hunter, Jon wrote: On 11/06/2012 12:00 PM, Matthieu CASTET wrote: I will post another patch, unless this is already done in Afzal patch (Is there a tree where I can get Afzal pending patches ?) Afzal keeps his kernel tree on

RE: [PATCH 0/5] usb: musb: am335x support

2012-11-03 Thread Mohammed, Afzal
Hi Daniel, * Daniel Mack, November 03, 2012 1:06 AM: I'm testing these patches with an AM33xx board that has the first musb port wired to an USB type A plug, but it doesn't yet work for me. So there is no host interface registered. I'm unsure on how to fix this, and I didn't get an answer

RE: OMAP baseline test results for v3.7-rc1

2012-10-21 Thread Mohammed, Afzal
Hi Richard, * Richard Cochran, October 21, 2012 1:05 PM: People keep saying, the beaglebone works fine with v3.7-rc1, but it isn't true. Now v3.7-rc2 is out, and the gpmc issue still has not been fixed, and no one is doing anything about it either. A fix to resolve the gpmc issue has been

RE: [PATCH] arm/dts: am33xx rtc node

2012-10-19 Thread Mohammed, Afzal
+ linux-omap and Daniel On Fri, Oct 19, 2012 at 16:20:21, Mohammed, Afzal wrote: add am33xx rtc node. Signed-off-by: Afzal Mohammed af...@ti.com --- Based on v3.7-rc1, Dependent on series rtc: omap dt support (for am33xx), (https://lkml.org/lkml/2012/10/19/163) Tested on Beagle Bone

RE: [PATCH 2/3] RTC: omap-rtc: enable pm_runtime

2012-10-19 Thread Mohammed, Afzal
Hi Daniel, On Thu, Oct 18, 2012 at 22:03:13, Hiremath, Vaibhav wrote: On Thu, Oct 18, 2012 at 21:49:44, Daniel Mack wrote: On 18.10.2012 18:12, Vaibhav Hiremath wrote: It would be really helpful if you could test these patches and ack them. Ok, will do tomorrow. What's missing there is

RE: [GIT PULL] OMAP-GPMC cleanup for common zImage

2012-10-15 Thread Mohammed, Afzal
Hi, On Mon, Oct 15, 2012 at 17:44:07, Mohammed, Afzal wrote: The following changes since commit ddffeb8c4d0331609ef2581d84de4d763607bd37: Linux 3.7-rc1 (2012-10-14 14:41:04 -0700) are available in the git repository at: g...@gitorious.org:x0148406-public/linux-kernel.git tags/gpmc

RE: [PATCH 0/4] OMAP-GPMC generic timing migration

2012-10-15 Thread Mohammed, Afzal
Hi Tony, On Thu, Oct 11, 2012 at 20:17:56, Tony Lindgren wrote: * Mohammed, Afzal af...@ti.com [121011 05:48]: After -rc1 is out, let's plan on adding the minimal set required for removing plat and mach includes from drivers into a clean-up branch. Afzal, can you maybe do a pull request

RE: Errors at boot time from OMAP4430SDP (and a whinge about serial stuff)

2012-10-14 Thread Mohammed, Afzal
Hi, On Fri, Oct 12, 2012 at 21:54:52, Tony Lindgren wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [121012 08:56]: omap-gpmc omap-gpmc: error: clk_get omap-gpmc: probe of omap-gpmc failed with error -2 I think Afzal posted something about this already? Looks like this too

RE: omap3 gpmc: irq-20 could not claim: err -2

2012-10-11 Thread Mohammed, Afzal
Hi Peter, On Thu, Oct 11, 2012 at 15:05:43, Peter Meerwald wrote: I'm getting the kernel log messages early in the bootup sequence (kernel 3.6.1 mainline) [0.121337] GPMC revision 5.0 [0.121582] gpmc: irq-20 could not claim: err -22 This issue has been present for quite some time,

RE: [PATCH 0/4] OMAP-GPMC generic timing migration

2012-10-11 Thread Mohammed, Afzal
Hi Daniel, On Thu, Oct 11, 2012 at 17:15:42, Daniel Mack wrote: Admittedly, I lost track on the multiple GPMC series here, and they also cause major merge conflicts with Linus' current master branch. Could you tell me which patches I need on top of soon-to-be-3.7-rc1? I Series [1-2] plus

RE: [PATCH v2 00/14] OMAP-GPMC related cleanup for common zImage

2012-10-10 Thread Mohammed, Afzal
On Wed, Oct 10, 2012 at 22:08:41, Ivan Djelic wrote: On Mon, Oct 08, 2012 at 07:08:08AM +0100, Mohammed, Afzal wrote: Please verify that BCH[48] works as earlier with this series. I ran several mtd regression tests on a Beagle Board on your gpmc-czimage-v2 tag. All BCH error correcting

RE: [PATCH v2 00/14] OMAP-GPMC related cleanup for common zImage

2012-10-08 Thread Mohammed, Afzal
Hi Ivan, On Mon, Oct 08, 2012 at 11:05:56, Mohammed, Afzal wrote: This series cleans up omap-gpmc related code so that omap can be a part of common zImage. This series moves gpmc.h from plat-omap/include/plat to mach-omap2 so that header file is local. Patches 7 8 cleans up the already

RE: [PATCH 00/15] OMAP-GPMC related cleanup for common zImage

2012-10-07 Thread Mohammed, Afzal
Hi, On Fri, Oct 05, 2012 at 21:22:50, Mohammed, Afzal wrote: This series cleans up omap-gpmc related code so that omap can be a part of common zImage. Upon selecting BCH CONFIG option, build breaks, updated series - v2 that fixes it has been posted. Regards Afzal

RE: [PATCH v8 0/6] OMAP-GPMC cleanup for generic timing

2012-10-05 Thread Mohammed, Afzal
+ Jon and Paul On Fri, Oct 05, 2012 at 21:04:57, Mohammed, Afzal wrote: Hi, This series prepares gpmc for generic timing. v7 of this series was named OMAP-GPMC: generic time calc, prepare for driver. generic timing routine has been removed from this series. generic timing will be posted

RE: [PATCH v8 1/6] ARM: OMAP2+: nand: unify init functions

2012-10-05 Thread Mohammed, Afzal
+ Jon and Paul On Fri, Oct 05, 2012 at 21:05:54, Mohammed, Afzal wrote: Helper function for updating nand platform data has been added the capability to take timing structure arguement. Usage of omap_nand_flash_init() has been replaced by modifed one, omap_nand_flash_init was doing things

RE: [PATCH v7 08/11] ARM: OMAP2+: gpmc: generic timing calculation

2012-09-27 Thread Mohammed, Afzal
Hi Jon, On Thu, Sep 27, 2012 at 08:54:22, Hunter, Jon wrote: On 09/19/2012 08:23 AM, Afzal Mohammed wrote: +Dependency of peripheral timings on gpmc timings: + +cs_on: t_ceasu Thanks for adding these details. Could be good to clarify that the left-hand side parameters are the gpmc

RE: Help needed with remaining plat headers

2012-09-27 Thread Mohammed, Afzal
Hi Tony, On Fri, Sep 28, 2012 at 01:56:16, Tony Lindgren wrote: Please see below a status update on the remaining problem plat headers. gpmc.h Afzal, can you do a patch for gpmc.h? Yes, I will do it. Regards Afzal

RE: [PATCH v7 08/11] ARM: OMAP2+: gpmc: generic timing calculation

2012-09-27 Thread Mohammed, Afzal
Hi Jon, On Thu, Sep 27, 2012 at 20:46:12, Hunter, Jon wrote: On 09/27/2012 05:07 AM, Mohammed, Afzal wrote: Or maybe should the timings be grouped as ... General Read Async Read Async Address/Data Multiplexed Read Sync Read Sync Address/Data Multiplexed Write Async Write Async

RE: query on [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-25 Thread Mohammed, Afzal
On Tue, Sep 25, 2012 at 16:21:39, ABRAHAM, KISHON VIJAY wrote: On Tue, Sep 25, 2012 at 2:24 PM, Marc Kleine-Budde m...@pengutronix.de wrote: I'm interested in to get these patches into the kernel soon. Kishon any news on this patch? Something like this would be required for USB support

RE: gpmc_cs_request() causes early boot hang

2012-09-24 Thread Mohammed, Afzal
Hi Mark, On Mon, Sep 24, 2012 at 16:21:40, Mark Jackson wrote: On 24/09/12 05:51, Mohammed, Afzal wrote: It seems you are using PSP Kernel. Invoking omap_init_gpmc before gpmc request should help. Okay ... I'm now using earlyprintk and omap_init_gpmc(), but I still get boot hangs

RE: gpmc_cs_request() causes early boot hang

2012-09-23 Thread Mohammed, Afzal
Hi Mark, On Sat, Sep 22, 2012 at 00:57:38, Mark Jackson wrote: I'm developing a beaglebone cape board which requires the use of a GPMC chip select. I've chosen GPMC_CS0, and in board-am335xevm.c, I have added the following:- static void gpmc_test() { unsigned long base =

RE: [PATCH v7 00/11] OMAP-GPMC: generic time calc, prepare for driver

2012-09-20 Thread Mohammed, Afzal
Hi Tony, On Fri, Sep 21, 2012 at 10:21:04, Tony Lindgren wrote: I gave this series a quick test on my n800 after applying the two serial patches needed to get the uart to work, and it seems to be working just fine. Was there still some discussion on the format of the generic timings

RE: [PATCH v6 10/10] ARM: OMAP2+: tusb6010: generic timing calculation

2012-09-19 Thread Mohammed, Afzal
Hi Tony, On Tue, Sep 18, 2012 at 04:40:02, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [120917 15:54]: Can you please try with the attached patch ? Gave it a quick try and it seemed to work.. But when I tried rebasing my patches for the cbus to keep things working with

RE: [PATCH v9 3/3] ARM: OMAP2+: gpmc: minimal driver support

2012-09-17 Thread Mohammed, Afzal
Hi Paul, On Wed, Sep 12, 2012 at 22:04:16, Paul Walmsley wrote: Two checkpatch warnings are added by this patch: I did checkpatch earlier, but without --strict I've fixed them here in the obvious way. But please make sure that all your patches are clean with 'checkpatch.pl --strict';

RE: [PATCH v9 1/3] ARM: OMAP2/3: hwmod data: add gpmc

2012-09-17 Thread Mohammed, Afzal
Hi Paul, On Thu, Sep 13, 2012 at 03:45:27, Paul Walmsley wrote: + HWMOD_INIT_NO_RESET | As I understand it, this is not due to any GPMC-related reset bugs, but just because the kernel is relying on the bootloader GPMC timing data being preserved. Is that

RE: [PATCH v6 10/10] ARM: OMAP2+: tusb6010: generic timing calculation

2012-09-17 Thread Mohammed, Afzal
Hi Tony, On Fri, Sep 14, 2012 at 15:50:02, Mohammed, Afzal wrote: * Mohammed, Afzal: Wednesday, September 12, 2012 3:20 PM But some of the tusb async values is less by one. I need to get it right. Reason has been identified. It was due to rounding error, no changes are required

RE: [PATCH v6 10/10] ARM: OMAP2+: tusb6010: generic timing calculation

2012-09-14 Thread Mohammed, Afzal
* Mohammed, Afzal: Wednesday, September 12, 2012 3:20 PM But some of the tusb async values is less by one. I need to get it right. Reason has been identified. It was due to rounding error, no changes are required in the expressions. Moving completely to picoseconds resolves the issue. Can you

RE: [PATCH v3 10/10] mtd: nand: omap2: use gpmc provided irqs

2012-09-12 Thread Mohammed, Afzal
On Tue, Sep 11, 2012 at 23:51:07, Tony Lindgren wrote: Ah thanks, that's a copy paste UTF-8 issue. I'll just fold in the fixes and push them out to a new devel-gpmc-fixed branch. Thanks Tony Regards Afzal

RE: [PATCH v6 10/10] ARM: OMAP2+: tusb6010: generic timing calculation

2012-09-12 Thread Mohammed, Afzal
Hi Tony, On Wed, Sep 12, 2012 at 00:16:06, Tony Lindgren wrote: Here are the timing changes with and without this patch from my n800. You can just diff the two files to see some differences. Hmm.. that was pretty close, OneNAND async,sync as well as tusb sync values were same. But some of

RE: [PATCH] mtd: nand: omap2: fix error path

2012-09-11 Thread Mohammed, Afzal
+Tony On Tue, Sep 11, 2012 at 11:58:54, Mohammed, Afzal wrote: Let probe return error value if gpmc terminal count interrupt could not be obtained Signed-off-by: Afzal Mohammed af...@ti.com --- Hi, My commit (now in l-o/devel-gpmc), bd4156f mtd: nand: omap2: use gpmc provided irqs

RE: [PATCH v3 10/10] mtd: nand: omap2: use gpmc provided irqs

2012-09-11 Thread Mohammed, Afzal
Hi Tony, On Tue, Sep 11, 2012 at 11:12:27, Tony Lindgren wrote: * Mohammed, Afzal af...@ti.com [120910 22:36]: I was not careful enough, sorry. Thanks for fixing it. Another hunk as follows would also be required for error path even though compiler didn't complain. Not sure

RE: [PATCH v8 2/3] ARM: OMAP2+: gpmc: Adapt to HWMOD

2012-09-11 Thread Mohammed, Afzal
Hi Jon, On Thu, Sep 06, 2012 at 01:25:23, Hunter, Jon wrote: Nit-pick, I see some devices writing the above as ... WARN(IS_ERR(pdev), could not build omap_device for %s\n, oh_name); return IS_ERR(pdev) ? PTR_ERR(pdev) : 0; Otherwise ... Reviewed-by: Jon Hunter

RE: [PATCH v8 0/3] GPMC driver conversion

2012-09-11 Thread Mohammed, Afzal
Hi Tony, On Sat, Sep 08, 2012 at 03:40:34, Tony Lindgren wrote: Great, this all looks good to me. I suggest that on top of this we add minimal devicetree binding that does not even attempt to deal with the timings yet. Then once the minimal devicetree binding is in place, we can call the

RE: [PATCH v3 10/10] mtd: nand: omap2: use gpmc provided irqs

2012-09-10 Thread Mohammed, Afzal
Hi Tony, On Tue, Sep 11, 2012 at 05:47:10, Tony Lindgren wrote: FYI, looks like a new warning got introduced, so I've committed the following trivial patch on top of this series. I was not careful enough, sorry. Thanks for fixing it. Another hunk as follows would also be required for error

RE: [PATCH v6 10/10] ARM: OMAP2+: tusb6010: generic timing calculation

2012-09-06 Thread Mohammed, Afzal
Hi Tony, On Mon, Sep 03, 2012 at 11:04:10, Mohammed, Afzal wrote: On Mon, Aug 27, 2012 at 14:04:44, Mohammed, Afzal wrote: On Sat, Aug 25, 2012 at 01:16:30, Tony Lindgren wrote: This hangs n800 during the boot. Paul reported that n800 stopped booting on OMAP baseline [1] due to an mmc

RE: [PATCH 7/9] ARM: OMAP2+: Prepare for irqs.h removal

2012-09-05 Thread Mohammed, Afzal
Hi Tony, On Wed, Sep 05, 2012 at 06:39:22, Tony Lindgren wrote: * Mohammed, Afzal af...@ti.com [120904 01:47]: *I am not sending the patches now to avoid confusion by way of having too many patch series* In case you like this, let me know, I will post. Yes please post the patches

RE: [PATCH v7 3/3] ARM: OMAP2+: gpmc: minimal driver support

2012-09-05 Thread Mohammed, Afzal
Hi, On Wed, Sep 05, 2012 at 14:20:09, Mohammed, Afzal wrote: Create a minimal driver out of gpmc code. Responsibilities handled by earlier gpmc initialization is now achieved in probe. + if (GPMC_REVISION_MAJOR(l) 0x4) + gpmc_capability = GPMC_HAS_WR_ACCESS

RE: [PATCH 7/9] ARM: OMAP2+: Prepare for irqs.h removal

2012-09-05 Thread Mohammed, Afzal
Hi Tony, On Wed, Sep 05, 2012 at 14:33:58, Mohammed, Afzal wrote: On Wed, Sep 05, 2012 at 06:39:22, Tony Lindgren wrote: * Mohammed, Afzal af...@ti.com [120904 01:47]: *I am not sending the patches now to avoid confusion by way of having too many patch series* In case you like

RE: [PATCH 7/9] ARM: OMAP2+: Prepare for irqs.h removal

2012-09-04 Thread Mohammed, Afzal
Hi Tony, On Fri, Aug 31, 2012 at 06:22:37, Tony Lindgren wrote: As the interrupts should only be defined in the platform_data, and eventually coming from device tree, there's no need to define them in header files. Let's remove the hardcoded references to irqs.h and fix up the includes so

RE: [PATCH 6/9] ARM: OMAP: Move gpio.h to include/linux/platform_data

2012-09-03 Thread Mohammed, Afzal
Hi, On Fri, Aug 31, 2012 at 06:22:34, Tony Lindgren wrote: This way we can remove includes of plat/gpio.h which won't work with the single zImage support. Note that we also remove the cpu_class_is_omap2() check in gpio-omap.c as the drivers should not call it as we need to make it local to

RE: Without MACH_ option Early printk (DEBUG_LL)

2012-09-02 Thread Mohammed, Afzal
Hi, On Fri, Aug 31, 2012 at 23:53:32, Nicolas Pitre wrote: On Fri, 31 Aug 2012, Hiremath, Vaibhav wrote: On Fri, Aug 31, 2012 at 22:43:36, Russell King - ARM Linux wrote: On Fri, Aug 31, 2012 at 08:24:51PM +0530, Vaibhav Hiremath wrote: AM335X EVM (based on AM33XX device) only supports

RE: [PATCH v6 10/10] ARM: OMAP2+: tusb6010: generic timing calculation

2012-09-02 Thread Mohammed, Afzal
Hi Tony, On Mon, Aug 27, 2012 at 14:04:44, Mohammed, Afzal wrote: On Sat, Aug 25, 2012 at 01:16:30, Tony Lindgren wrote: This hangs n800 during the boot. Shall I read the above as n800 boot without patch 10/10, but with the other patches in this series ? As per the board file, n800 has

RE: [PATCH v6 07/10] ARM: OMAP2+: gpmc: generic timing calculation

2012-08-28 Thread Mohammed, Afzal
Hi Jon, On Tue, Aug 28, 2012 at 02:00:13, Hunter, Jon wrote: On 08/27/2012 05:37 AM, Mohammed, Afzal wrote: And at least for initial users, they are expected to have some grasp on how to calculate timings, such a user will not be much worried about your 3 concerns above, anyway

RE: [PATCH v6 10/10] ARM: OMAP2+: tusb6010: generic timing calculation

2012-08-27 Thread Mohammed, Afzal
Hi Tony, On Sat, Aug 25, 2012 at 01:16:30, Tony Lindgren wrote: This hangs n800 during the boot. Shall I read the above as n800 boot without patch 10/10, but with the other patches in this series ? As per the board file, n800 has tusb6010 as well as OneNAND in sync read async write mode, was

RE: [PATCH v6 07/10] ARM: OMAP2+: gpmc: generic timing calculation

2012-08-27 Thread Mohammed, Afzal
Hi Jon, On Thu, Aug 23, 2012 at 08:28:44, Hunter, Jon wrote: On 08/21/2012 05:45 AM, Afzal Mohammed wrote: +/* can the cycles be avoided ? */ What is the above comment referring too? This was added in the initial stages and refers to the usage of cycles in struct gpmc_device_timings. I

RE: [PATCH v6 07/10] ARM: OMAP2+: gpmc: generic timing calculation

2012-08-27 Thread Mohammed, Afzal
Hi Tony, On Sat, Aug 25, 2012 at 01:24:47, Tony Lindgren wrote: Yes agreed. Also as some values make sense only in cycles, converting them back and forth to time is wrong. So at least some values should have an option to specify them in cycles directly, and then ignore any time based values.

RE: [PATCH v6 00/10] OMAP-GPMC: generic time calc, prepare for driver

2012-08-27 Thread Mohammed, Afzal
Hi Daniel, On Mon, Aug 27, 2012 at 17:46:17, Daniel Mack wrote: Such a generic routine would help create a driver out of gpmc platform code, which would be peripheral agnostic and thus lead to DT finally. Input to generic timing calculation routine would be gpmc peripheral timings,

RE: [PATCH v6 00/10] OMAP-GPMC: generic time calc, prepare for driver

2012-08-27 Thread Mohammed, Afzal
Hi Daniel, On Mon, Aug 27, 2012 at 19:00:32, Daniel Mack wrote: So the GPMC driver is the one that is matched from DT, and the NAND driver will the be instanciated from the (generic) GPMC driver? I think you were referring to nand device being instantiated from gpmc driver?, hence resulting

RE: gpmc generic retime function (subject was RE: [PATCH v5 3/3] ARM: OMAP2+: onenand: prepare for gpmc driver migration)

2012-08-21 Thread Mohammed, Afzal
Hi Jon, On Fri, Aug 17, 2012 at 20:32:34, Hunter, Jon wrote: And we have been able to create such a function. Below is an implementation that has been made for handling asynchronous timings. It has been tested for OneNAND SMSC on OMAP3EVM (rev G C) with [1-4]. OneNAND was tested using

RE: [GIT PULL 1/5] omap device tree changes for v3.6 merge window

2012-08-07 Thread Mohammed, Afzal
On Tue, Aug 07, 2012 at 12:43:51, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [120713 01:01]: * Tony Lindgren t...@atomide.com [120712 23:46]: my scripts when applying patches. We'll have to apply this as a fix. Arnd and Olof, let me know if you want me to resubmit a new branch

gpmc generic retime function (subject was RE: [PATCH v5 3/3] ARM: OMAP2+: onenand: prepare for gpmc driver migration)

2012-08-06 Thread Mohammed, Afzal
Hi Tony, Jon, On Wed, Jul 11, 2012 at 12:17:25, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [120710 10:20]: The DT node should simply have the information required by the retime function or gpmc timings themselves if available. In the case of OneNAND These can be stored in the DT

RE: [PATCH v5 3/3] ARM: OMAP2+: onenand: prepare for gpmc driver migration

2012-07-30 Thread Mohammed, Afzal
Hi Tony, On Thu, Jun 28, 2012 at 18:14:30, Mohammed, Afzal wrote: On Thu, Jun 28, 2012 at 18:02:07, Tony Lindgren wrote: * Mohammed, Afzal af...@ti.com [120628 02:36]: diff --git a/arch/arm/mach-omap2/gpmc-onenand.c b/arch/arm/mach-omap2/gpmc-onenand.c index c8a9487..bbae674 100644

  1   2   3   >