Hello!
On Jun 6, 2011, at 5:21 AM, Felipe Balbi wrote:
-static struct regulator_consumer_supply sdp4430_vaux_supply[] = {
-{
-.supply = vmmc,
-.dev_name = omap_hsmmc.1,
-},
-};
+static struct regulator_consumer_supply sdp4430_vaux_supply =
+
Hello!
On Jun 6, 2011, at 1:13 PM, Felipe Balbi wrote:
On Mon, Jun 06, 2011 at 11:45:29AM -0400, Oleg Drokin wrote:
-static struct regulator_consumer_supply sdp4430_vaux_supply[] = {
- {
- .supply = vmmc,
- .dev_name = omap_hsmmc.1,
- },
-};
+static struct
Hello!
On Jun 6, 2011, at 1:28 PM, Felipe Balbi wrote:
Ok, I get the idea. Do you think it would be best to convert every supply
definition to an array then just in case?
I think that while you're doing this big conversion, why not ?
Well, ok then. I'll redo this patch.
Bye,
Oleg
--
To
Hello!
On Apr 29, 2011, at 5:21 AM, Felipe Balbi wrote:
On Apr 28, 2011, at 2:14 AM, Mike Rapoport wrote:
+static struct omap_musb_board_data musb_board_data = {
+.interface_type = MUSB_INTERFACE_ULPI,
+#ifdef CONFIG_USB_MUSB_OTG
+.mode = MUSB_OTG,
Hello!
On May 23, 2011, at 8:48 PM, Theodore Kilgore wrote:
Thank you very much for this work. I am considering the idea of buying one
of these Nook Color things; at least it would get good company from a
couple of other half-finished ARM-type projects lying around. But, most
Hello!
On May 22, 2011, at 6:45 PM, Mark Brown wrote:
Note that it'd be better to split into two patches as it makes review
easier.
If I end-up with a new version of the patch, what do you think would be best as
a divisor
between the patches? Just have ~half of changes split into another
Hello!
On May 9, 2011, at 3:03 AM, Igor Grinberg wrote:
Bare-bones board file, comes with serial console, gpio keys,
MMC/SDCard and USB support.
Signed-off-by: Oleg Drokin gr...@linuxhacker.ru
---
In general, here you should write the version history of your patch...
umm, ok.
Do you
Hello!
On May 4, 2011, at 2:38 AM, Mike Rapoport wrote:
On 05/04/11 07:10, Oleg Drokin wrote:
Ok, so here's a simple patch to save everyone trouble, I guess.
Though on the other hand I can imagine that perhaps including this generic
common-board-devices.c
might not be desirable
Hello!
On May 4, 2011, at 9:27 AM, Mike Rapoport wrote:
Commits 5e6a64b36ce346b7a2d481ef9fa315290eb28e5e (omap: move detection of
NAND CS to common-board-devices) and 96974a249b0cf3537f49115a59be67e2c54f315c
(omap: consolidate touch screen initialization among different boards)
break
Hello!
This patch breaks compile for me.
On Apr 24, 2011, at 6:09 PM, Mike Rapoport wrote:
--- /dev/null
+++ b/arch/arm/mach-omap2/common-board-devices.c
@@ -0,0 +1,85 @@
+void __init omap_ads7846_init(int bus_num, int gpio_pendown, int
gpio_debounce,
+ struct
Hello!
This patch breaks compile for me:
On Apr 24, 2011, at 6:09 PM, Mike Rapoport wrote:
--- a/arch/arm/mach-omap2/common-board-devices.c
+++ b/arch/arm/mach-omap2/common-board-devices.c
@@ -29,6 +29,7 @@
...
+void __init omap_nand_flash_init(int options, struct mtd_partition *parts,
Ok, so here's a simple patch to save everyone trouble, I guess.
Though on the other hand I can imagine that perhaps including this generic
common-board-devices.c
might not be desirable for people that don't use anything from that file.
Would it be a better idea to split it to a file-per-feature?
Hello!
On Apr 28, 2011, at 2:14 AM, Mike Rapoport wrote:
+static struct omap_musb_board_data musb_board_data = {
+ .interface_type = MUSB_INTERFACE_ULPI,
+#ifdef CONFIG_USB_MUSB_OTG
+ .mode = MUSB_OTG,
+#elif defined(CONFIG_USB_MUSB_HDRC_HCD)
+ .mode
Hello!
On Apr 28, 2011, at 10:18 AM, Russell King - ARM Linux wrote:
-void __init usb_musb_init(struct omap_musb_board_data *board_data)
+static struct omap_musb_board_data musb_default_board_data = {
+ .interface_type = MUSB_INTERFACE_ULPI,
+ .mode = MUSB_OTG,
Hello!
On Apr 28, 2011, at 12:28 PM, Russell King - ARM Linux wrote:
mm, it looks to me like we're ending up with two layers on top of
each other, both trying to provide some kind of generic board interface.
I think they should be squashed together. And that:
static struct
Hello!
On Apr 28, 2011, at 1:05 PM, Paul Walmsley wrote:
Ok, this is a second attempt at BN Nook Color board file submission.
USB peripheral mode is fully operational as is serial console and
MMC/SDCard.
It's good that you're sending these patches, but please also:
- Add a
board.
BN is set to release new source code in few days, taking new code as
porting base is also recommended.
Regards,
Abimanyu G
On Thu, Apr 28, 2011 at 9:27 PM, gr...@linuxhacker.ru wrote:
From: Oleg Drokin gr...@linuxhacker.ru
Bare-bones board file, comes with serial console, gpio
Hello!
Thanks for the feedback.
On Apr 27, 2011, at 4:49 AM, Mike Rapoport wrote:
MMC/SD interface, i2c, usb.
You should have added these at the first patch instead of Android devices.
So, basically you want all board file changes to come as a single patch, right?
---
Hello!
On Apr 24, 2011, at 6:09 PM, Mike Rapoport wrote:
-void __init usb_musb_init(struct omap_musb_board_data *board_data)
+static struct omap_musb_board_data musb_default_board_data = {
+ .interface_type = MUSB_INTERFACE_ULPI,
+ .mode = MUSB_OTG,
In fact
19 matches
Mail list logo
