. So I think the loading of that module
(triggered by loading another module that uses one of the exported
symbols, I suppose) taints the kernel. Am I correct?
Paul Bolle
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More
it's just a stylistic nit.
Paul Bolle
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
the
+ * GNU General Public License for more details.
+ */
This states the license is GPL v2 or later.
+MODULE_LICENSE(GPL v2);
So you probably want
MODULE_LICENSE(GPL);
here.
Paul Bolle
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message
.
(Perhaps there are non-modular alternatives to MODULE_DEVICE_TABLE and
module_platform_driver, but I'm not sure how those two macros actually
work.)
Paul Bolle
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More
);
here.
Paul Bolle
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
);
+MODULE_LICENSE(GPL);
And why are these three macros needed?
By the way: there's a mismatch between the header (which is GPL v2) and
the MODULE_LICENSE() string (which means GPL v2 or later).
Paul Bolle
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body
?
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
nothing at all about all
that!
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
:= nokia_core.o nokia_fw.o nokia_uart.o
+
ccflags-y += -D__CHECK_ENDIAN__
Or did I miss some make magic here?
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
that commit did not remove all select statements for that
symbol. These statements are useless. Remove them too.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
Done on top of next-20140912. Tested with git grep only!
arch/arm/mach-omap2/Kconfig| 5 -
arch/arm/mach-shmobile/Kconfig | 1
On Fri, 2014-09-12 at 05:20 -0500, Nishanth Menon wrote:
On Fri, Sep 12, 2014 at 3:38 AM, Paul Bolle pebo...@tiscali.nl wrote:
The Kconfig symbol ARCH_HAS_OPP became redundant in v3.16: commit
049d595a4db3 (PM / OPP: Make OPP invisible to users in Kconfig)
removed the only dependency
On Fri, 2014-09-12 at 13:03 +0200, Geert Uytterhoeven wrote:
Hi Paul, Rafael,
On Fri, Sep 12, 2014 at 12:46 PM, Paul Bolle pebo...@tiscali.nl wrote:
arch/arm/mach-shmobile/Kconfig | 1 -
drivers/devfreq/Kconfig| 1 -
Were patches submitted for these two files too? If so, we
Felipe,
On Thu, 2014-05-15 at 18:12 -0500, Felipe Balbi wrote:
On Thu, May 15, 2014 at 10:55:45PM +0200, Paul Bolle wrote:
diff --git a/arch/arm/mach-omap1/board-h2.c b/arch/arm/mach-omap1/board-h2.c
index 65d2acb31498..57092bc7f4f1 100644
--- a/arch/arm/mach-omap1/board-h2.c
+++ b/arch
since v3.1.
And, since we're touching this code, use the IS_ENABLED() macro, so
things will now (hopefully) also work if USB_OMAP is modular.
Fixes: 193ab2a60700 (usb: gadget: allow multiple gadgets to be built)
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
v2: us IS_ENABLED() as Felipe requested
currently: OMAP_DSS_VENC_TYPE_COMPOSITE equals
zero and connector_type remains zero since both checks currently fail.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
Untested.
arch/arm/mach-omap2/board-omap3stalker.c | 4
1 file changed, 4 deletions(-)
diff --git a/arch/arm/mach-omap2/board
A check for CONFIG_CBUS_TAHVO_USB was added in v2.6.17. The related
Kconfig symbol has never been part of the tree. Remove that check.
Replace the while (...) loop with a simple if (...) statement, while
we're at it.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
Untested, as usual.
A quick
A check for CONFIG_SX1_OLD_FLASH was added in v2.6.24. But the related
Kconfig symbol was never part of the tree. So we can remove some dead
code.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
Also untested.
arch/arm/mach-omap1/board-sx1.c | 26 --
1 file changed, 26
The Kconfig symbol PANEL_SHARP_LQ043T1DG01 was removed in v2.6.38. The
check for CONFIG_PANEL_SHARP_LQ043T1DG01 and its MODULE variant has
evaluated to false ever since. Remove that check.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
Untested, again.
arch/arm/mach-omap2/board-am3517evm.c
since v3.1.
Fixes: 193ab2a60700 (usb: gadget: allow multiple gadgets to be built)
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
Also untested.
It seems efficient to also include the change to phy-isp1301-omap.c in
this patch (ie, not ship that as a separate patch).
arch/arm/mach-omap1/board-h2.c
Hi Igor,
On Mon, 2014-02-17 at 14:33 +0200, Igor Grinberg wrote:
On 02/16/14 19:26, Paul Bolle wrote:
The Kconfig symbol MACH_CM_T3730 was added in v3.1. It has never been
used. Setting it has no effect. There are no calls for
machine_is_cm_t3730(). This symbol can safely be removed
The Kconfig symbol MACH_CM_T3730 was added in v3.1. It has never been
used. Setting it has no effect. There are no calls for
machine_is_cm_t3730(). This symbol can safely be removed.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
Tested only with git grep.
arch/arm/mach-omap2/Kconfig | 4
The Kconfig symbols OMAP_PACKAGE_ZAC and OMAP_PACKAGE_ZAF were added in
v2.6.36. They have never been used. Setting them has no effect. These
symbols can safely be removed.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
Tested with git grep.
A sort of related cleanup would be removing
Commit 97411608fd5f (ARM: OMAP2+: Remove legacy support for zoom
platforms) removed the Kconfig symbols MACH_OMAP_ZOOM2 and
MACH_OMAP_ZOOM3. Remove the last usage of the related macros too.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
Untested, but should have zero impact.
arch/arm/mach
The last caller of machine_is_nokia_n800() was removed in commit
5a87cde490e1 (ARM: OMAP2+: Remove legacy booting support for n8x0).
That means that the Kconfig symbol MACH_NOKIA_N800 is now unused. It can
safely be removed.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
Untested.
arch/arm
On Sun, 2014-02-09 at 19:48 +0100, Richard Weinberger wrote:
The symbol is an orphan, get rid of it.
Signed-off-by: Richard Weinberger rich...@nod.at
Merge with 26/28? Anyhow, my comments are basically identical to those
on that patch. So:
Acked-by: Paul Bolle pebo...@tiscali.nl
Paul
Support for omap2evm was removed in v3.0. But only one of its two
lines in this Makefile was removed. Remove the second line too.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
Eyeball tested only.
sound/soc/omap/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/omap
The OMAP runtime PM implementation was removed in v3.0. But one Makefile
line, which was used to tweak CFLAGS, was overlooked. Remove it too.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
Untested. This cleans up after commit 638080c37a (OMAP2+ / PM: move
runtime PM implementation to use
-omap3encore.c. This line can safely be removed.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
arch/arm/mach-omap2/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
index b068b7f..3d0697c 100644
--- a/arch/arm/mach-omap2/Makefile
. This line can safely be removed.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
Note that MACH_PCM049 was removed from mach-types in v3.5.
arch/arm/mach-omap2/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
index 3d0697c
Commit 90173882ed15a8034d6d162da5f343a2c7d87587 (omap: add dsp platform
device) used CONFIG_BRIDGE_DVFS were it obviously meant
CONFIG_TIDSPBRIDGE_DVFS. Fix that.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
Untested. As this typo has been in the tree since v2.6.37, this really
needs some
The Kconfig symbol MACH_OMAP_HTCWIZARD got added in v2.6.30. It has
never been used. Its entry can safely be removed.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
Untested.
arch/arm/mach-omap1/Kconfig | 6 --
1 file changed, 6 deletions(-)
diff --git a/arch/arm/mach-omap1/Kconfig b
The only user of Kconfig symbol FB_OMAP_CONSISTENT_DMA_SIZE got removed
in v3.8, with commit 6ba54ab4a49bbad736b0254aa6bdf0cb83013815 (ARM:
OMAP: Remove omap_init_consistent_dma_size()). Remove this symbol too.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
Eyeball tested only.
drivers/video
On Mon, 2013-03-11 at 09:33 -0700, Tony Lindgren wrote:
* Paul Bolle pebo...@tiscali.nl [130309 11:52]:
In the meantime, how do you prefer I solve the (trivial) issue of an
useless select for MACH_NOKIA_RM696? Drop that select or add an (equally
useless) config entry for MACH_NOKIA_RM696
? Drop that select or add an (equally
useless) config entry for MACH_NOKIA_RM696? Or should I try to ignore it
for the time being?
Paul Bolle
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
support for that machine piggybacks
on MACH_NOKIA_RM680. So drop that select.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
0) Tested with git grep.
1) Some searching on the web didn't return a config MACH_NOKIA_RM696.
So apparently there's not even a development tree that uses this symbol
There's a (rather subtle) typo in CONFIG_SMC91x_MODULE. Fix it once
and for all by using IS_ENABLED(), which is designed to avoid issues
like this.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
Untested! And this needs build- and runtime testing, especially for the
MODULE case!
arch/arm/mach
On Fri, 2013-03-08 at 18:11 +0200, Aaro Koskinen wrote:
On Fri, Mar 08, 2013 at 11:29:56AM +0100, Paul Bolle wrote:
When support was added for Nokia N9 (RM-696), with commit
63fc5f3bb3d0ca9ab4767a801b518aa6335f87ad (ARM: OMAP: add minimal
support for Nokia RM-696), a select statement
On Fri, 2013-03-08 at 08:35 -0800, Tony Lindgren wrote:
I think the righ fix is to just add
config MACH_NOKIA_RM680
bool
I guess you meant MACH_NOKIA_RM696.
to the mach-omap2/Kconfig like we have for n8x0 also.
Should I draft a patch?
Paul Bolle
--
To unsubscribe from this list
On Fri, 2013-03-08 at 09:55 -0800, Tony Lindgren wrote:
* Paul Bolle pebo...@tiscali.nl [130308 09:24]:
Should I draft a patch?
Sure that would be nice.
One thing I couldn't determine is how the generated mach-types.h header
handles multiple CONFIG_MACH_* macros.
If both CONFIG_MACH_FOO
On Tue, 2012-06-26 at 04:25 -0700, Tony Lindgren wrote:
* Paul Bolle pebo...@tiscali.nl [120618 03:02]:
1) A related cleanup could be to remove cpu_is_omap730 and
cpu_is_omap850, as both macros seem unused.
Yes seems like we could do that. Care to do a patch for that?
Sure, no problem. I
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
I tracked this set of typos back to commit
9ad5897c2659b3c610e0c717e8b3dbfb496d2c74 ([ARM] 3143/1: OMAP 4/5:
Update omap include files). It is just something I noticed while
working on the next patch.
arch/arm/plat-omap/include/plat/cpu.h |4
Now that OMAP730 and OMAP850 support is mostly unified, there's no
need for separate cpu detection macros for these architectures. At
least, currently there isn't, because both macros are unused.
cpu_is_7xx() seems to cover all possible uses.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
0
to omap7xx.h too.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
0) Tested only by using various git commands on the (history of the)
tree.
1) A related cleanup could be to remove cpu_is_omap730 and
cpu_is_omap850, as both macros seem unused.
arch/arm/plat-omap/include/plat/mux.h |2 +-
arch/arm
43 matches
Mail list logo
