Re: Nokia N900: u-SD card in v4.2+

Hi! > On Thursday 07 January 2016 02:16 AM, Pavel Machek wrote: > > Hi! > > > > In v4.1, both internal MMC and u-SD cards work ok. > > > > In v4.2, only the internal MMC is detected. In v4.3, not even internal > > MMC works. In v4.4, only the internal

Nokia N900: u-SD card in v4.2+

Hi! In v4.1, both internal MMC and u-SD cards work ok. In v4.2, only the internal MMC is detected. In v4.3, not even internal MMC works. In v4.4, only the internal MMC is detected. Does it work for you? Any patches? (I do have hack in the dts to disable back cover detection...)

Re: [PATCH] ARM: dts: omap3: Include missing bandgap data for ti-soc-thermal driver

On Sat 2015-12-26 00:32:25, Pali Rohár wrote: > Driver for omap3 with documentation is there since v4.4-rc1. > > Signed-off-by: Pali Rohár <pali.ro...@gmail.com> Acked-by: Pavel Machek <pa...@ucw.cz> Tested-by: Pavel Machek &

Re: [PATCH] ARM: dts: n900: Include adp1653 device

On Sat 2015-12-26 00:40:12, Pali Rohár wrote: > This patch adds adp1653 device into n900 DT structure. DT support in > adp1653 driver is there since v4.2-rc1 version. > > Signed-off-by: Pali Rohár <pali.ro...@gmail.com> Acked-by: Pavel Machek <pa...@ucw.cz

Re: [PATCH 5/5] arm: boot: store ATAGs structure into DT "/chosen/linux,atags" entry

On Wed 2015-11-11 17:10:46, Frank Rowand wrote: > Adding devicetree list. > > Thread starts at > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/354459.html > > On 11/5/2015 8:17 AM, Tony Lindgren wrote: > > * Pali Rohár [151105 03:41]: > >> On Tuesday 13

Re: [Gta04-owner] [PATCH 10/13] twl4030_charger: add software controlled linear charging mode.

Hi! > > > Pavel Machek <pa...@ucw.cz> writes: > > > > On Thu 2015-07-30 10:11:24, NeilBrown wrote: > > > >> > > > >> Add a 'continuous' option for usb charging which enables > > > >> the "linear" charging m

Re: [PATCH 10/13] twl4030_charger: add software controlled linear charging mode.

Hi! > Pavel Machek <pa...@ucw.cz> writes: > > On Thu 2015-07-30 10:11:24, NeilBrown wrote: > >> > >> Add a 'continuous' option for usb charging which enables > >> the "linear" charging mode of the twl4030. > >> > >> Linear

Re: [PATCH 1/3] ARM: OMAP2+: N900: always enable IBE bit

Hi! > The kernel's workaround for Errata 430973 consists of a BTAC/BTB > flush at context switch. This requires the IBE bit being set, which > should normally be done by the bootloader. > > Since the Nokia N900's bootloader is not easily replaceable, > a pdata quirk enables the IBE bit for the

Re: omapdss: Division by zero in kernel

> > if (image->depth == 1) { > > if (p->fix.visual == FB_VISUAL_TRUECOLOR || > > p->fix.visual == FB_VISUAL_DIRECTCOLOR) { > > fgcolor = > > ((u32*)(p->pseudo_palette))[image->fg_color]; > > bgcolor = >

Re: [PATCHv3 1/1] ti-soc-thermal: implement omap3 support

On Wed 2015-09-09 21:58:09, Eduardo Valentin wrote: > From: Pavel Machek <pa...@ucw.cz> > > This adds support for OMAP3 chips to ti-soc-thermal. As requested by > TI people, it is marked unreliable and warning is printed. > > Cc: Zhang Rui <rui.zh...@intel.com>

Re: [PATCH 10/13] twl4030_charger: add software controlled linear charging mode.

On Thu 2015-07-30 10:11:24, NeilBrown wrote: > > Add a 'continuous' option for usb charging which enables > the "linear" charging mode of the twl4030. > > Linear charging does a good job with not-so-reliable power sources. > Auto mode does not work well as it switches off when voltage drops >

Re: [PATCH 01/13] twl4030_charger: use runtime_pm to keep usb phy active while charging.

gt; phy-twl4030-usb, we can simply take a runtime_pm reference to the USB > phy whenever the charger wants to use it as a current source. > > So this patch reverts the above commit, and adds the necessary > runtime_pm calls. > > Acked-by: Lee Jones <lee.jo...@linaro.org>

Re: [PATCH 04/13] twl4030_charger: trust phy to determine when USB power is available.

without double-checking. > > Signed-off-by: NeilBrown <n...@brown.name> Acked-by: Pavel Machek <pa...@ucw.cz> -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list:

Re: Nokia N900 - audio TPA6130A2 problems

Hi! Maybe some power management problem? Something is not always initialized correctly? I remember that there is some problem (maybe in NoLo - Nokia bootloader) that sometimes chainloaded U-Boot (booted via NoLo) is not able to initialize mmc chip (all read operation fails). In U-Boot I

Re: n900 in 4.2-rc0: repeating oopses

Hi! So, Pavel can you re-test? Maybe there can be problem with some driver which Tony did not compiled into zImage? Just speculation... I re-tested with today's git, and it seems to boot. Thanks for help... OK good to hear. Now. echo mem /sys/power/state is broken, as in

Re: n900 in 4.2-rc0: repeating oopses

On Wed 2015-07-01 23:16:21, Tony Lindgren wrote: * Pavel Machek pa...@ucw.cz [150701 06:11]: On Wed 2015-07-01 03:34:22, Tony Lindgren wrote: Works for me after enabling the idle timeouts with the following script and blanking the screen and disconnecting USB: Um. I'm forcing

Re: [PATCH v2] thermal: consistently use int for temperatures

On Fri 2015-07-24 15:49:41, Guenter Roeck wrote: On 07/24/2015 03:11 PM, Pavel Machek wrote: On Fri 2015-07-24 06:59:26, Guenter Roeck wrote: On 07/23/2015 11:29 PM, Sascha Hauer wrote: On Thu, Jul 23, 2015 at 02:07:59PM +0200, Pavel Machek wrote: On Tue 2015-07-21 09:21:32, Sascha Hauer

Re: linux 4.2-rc1 broken Nokia N900

On Fri 2015-07-24 16:18:09, Dave Young wrote: On 07/11/15 at 02:05pm, Pali Rohár wrote: Hello, now I tested 4.2-rc1 release on Nokia N900 and couple of drivers are broken and cause kernel oops... Basically wifi, touchscreen and rtc drivers not working... Pali, could you tell

Re: [PATCH v2] thermal: consistently use int for temperatures

On Fri 2015-07-24 06:59:26, Guenter Roeck wrote: On 07/23/2015 11:29 PM, Sascha Hauer wrote: On Thu, Jul 23, 2015 at 02:07:59PM +0200, Pavel Machek wrote: On Tue 2015-07-21 09:21:32, Sascha Hauer wrote: The thermal code uses int, long and unsigned long for temperatures in different places

Re: [PATCH v2] thermal: consistently use int for temperatures

On Tue 2015-07-21 09:21:32, Sascha Hauer wrote: The thermal code uses int, long and unsigned long for temperatures in different places. Using an unsigned type limits the thermal framework to positive temperatures without need. Also several drivers currently will report temperatures near

Re: linux 4.2-rc1 broken Nokia N900

On Wed 2015-07-22 04:03:07, Sebastian Reichel wrote: Hi, On Tue, Jul 21, 2015 at 07:17:41PM -0500, Michael Welling wrote: On Tue, Jul 21, 2015 at 11:34:41AM +0200, Pavel Machek wrote: This code has my head spinning. I found that the errors do not occur when the driver is built

Re: linux 4.2-rc1 broken Nokia N900

On Tue 2015-07-21 09:31:27, Pavel Machek wrote: On Wed 2015-07-15 15:10:48, Michael Welling wrote: On Wed, Jul 15, 2015 at 09:49:33PM +0200, Pavel Machek wrote: Hi! Ok, so: 4.2-rc1 worked for me, IIRC. This does not make sense. Nothing has changed

Re: linux 4.2-rc1 broken Nokia N900

On Wed 2015-07-15 15:10:48, Michael Welling wrote: On Wed, Jul 15, 2015 at 09:49:33PM +0200, Pavel Machek wrote: Hi! Ok, so: 4.2-rc1 worked for me, IIRC. This does not make sense. Nothing has changed in drivers/spi between these versions. Are you sure that 4.2

Re: linux 4.2-rc1 broken Nokia N900

On Mon 2015-07-20 15:46:47, Michael Welling wrote: On Tue, Jul 14, 2015 at 09:14:12AM +0200, Pali Rohár wrote: On Monday 13 July 2015 17:36:07 Michael Welling wrote: On Tue, Jul 14, 2015 at 12:02:44AM +0200, Pali Rohár wrote: I think nothing special. I just call: export ARCH=arm

Re: linux 4.2-rc1 broken Nokia N900

Hi! Ok, so: 4.2-rc1 worked for me, IIRC. This does not make sense. Nothing has changed in drivers/spi between these versions. Are you sure that 4.2-rc1 worked for you? Tested again: yes, I have 4.2-rc1 booted on the device... based on Linus' 1c4c7159ed2468f3ac4ce5a7f08d79663d381a93

Re: linux 4.2-rc1 broken Nokia N900

On Tue 2015-07-14 11:33:42, Michael Welling wrote: On Tue, Jul 14, 2015 at 09:14:12AM +0200, Pali Rohár wrote: On Monday 13 July 2015 17:36:07 Michael Welling wrote: On Tue, Jul 14, 2015 at 12:02:44AM +0200, Pali Rohár wrote: I think nothing special. I just call: export ARCH=arm

Re: musb-hdrc: Vbus off, timeout 1100 msec message does not belong in sysfs

On Thu 2015-07-09 23:39:22, Pavel Machek wrote: Hi! sysfs should contain one value per file. This one has at least two, with nice english sentence as a bonus. root@n900:/sys/devices/platform/6800.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto# cat vbus Vbus off, timeout 1100 msec

Re: rx51-battery.ko incompatiblity: board code vs DT

On Mon 2015-07-06 21:44:22, Pali Rohár wrote: Hello, now I found out that rx51-battery.ko driver register sysnode /sys/class/power_supply/rx51-battery/ when booting with legacy board code. But when booting DT kernel it register sysnode with different name

Re: n900 in 4.2-rc0: repeating oopses

On Wed 2015-07-01 03:34:22, Tony Lindgren wrote: * Pavel Machek pa...@ucw.cz [150701 03:02]: On Wed 2015-07-01 09:22:55, Pali Rohár wrote: On Tuesday 30 June 2015 23:59:33 Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [150630 02:55]: I will try 4.2 at the end of week

Re: n900 in 4.2-rc0: repeating oopses

On Wed 2015-07-01 03:34:22, Tony Lindgren wrote: * Pavel Machek pa...@ucw.cz [150701 03:02]: On Wed 2015-07-01 09:22:55, Pali Rohár wrote: On Tuesday 30 June 2015 23:59:33 Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [150630 02:55]: I will try 4.2 at the end of week

Re: n900 in 4.2-rc0: repeating oopses

On Wed 2015-07-01 09:22:55, Pali Rohár wrote: On Tuesday 30 June 2015 23:59:33 Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [150630 02:55]: I will try 4.2 at the end of week. At least today's 4.1.0-11549-g05a8256 boots just fine on my n900. Regards, Tony So,

Re: n900 in 4.2-rc0: repeating oopses

Hi! Just tried booting 4.2-rc0 on n900 (commit 4a10a91756ef381bced7b88cfb9232f660b92d93) and it is broken. Previous -rc0 version worked. This time, there's some output on console, but too fast for me to read. It seems oopses happen before mounting root. If you have serial console, they

n900 in 4.2-rc0: repeating oopses

Hi! Just tried booting 4.2-rc0 on n900 (commit 4a10a91756ef381bced7b88cfb9232f660b92d93) and it is broken. Previous -rc0 version worked. This time, there's some output on console, but too fast for me to read. It seems oopses happen before mounting root. If you have serial console, they should be

Re: Please revert 3eea8b5d68c801fec788b411582b803463834752 as it breaks touchscreen on n900.

by the driver and not reset the missing values to zero. Reported-by: Pavel Machek pa...@ucw.cz Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com Tested-by: Pavel Machek pa...@ucw.cz Thanks! Pavel -- (english) http

Re: [PATCH] Show proper respect for Heinrich Hertz by using the correct unit for frequency

Hi! The SI unit of frequency is Hertz, named after Heinrich Hertz, and is given the symbol Hz to denote this. hz is not the unit of frequency, and is in fact meaningless. Fix arch/arm to correctly use Hz, thereby acknowledging Heinrich Hertz contribution to the modern world. ---

Re: [PATCH 5/6] phy: twl4030-usb: add support for reading resistor on ID pin.

On Tue 2015-06-02 07:37:31, NeilBrown wrote: On Mon, 1 Jun 2015 19:06:52 +0530 Kishon Vijay Abraham I kis...@ti.com wrote: Hi, On Thursday 16 April 2015 01:33 PM, NeilBrown wrote: From: NeilBrown ne...@suse.de The twl4030 phy can measure, with low precision, the

Re: Please revert 3eea8b5d68c801fec788b411582b803463834752 as it breaks touchscreen on n900.

On Mon 2015-06-01 14:32:13, Dmitry Torokhov wrote: On Mon, Jun 01, 2015 at 11:22:26PM +0200, Maxime Ripard wrote: Hi Dmitry, On Mon, Jun 01, 2015 at 10:47:30AM -0700, Dmitry Torokhov wrote: On Mon, Jun 01, 2015 at 05:21:11PM +0200, Pavel Machek wrote

Re: [Gta04-owner] [PATCH 5/6] phy: twl4030-usb: add support for reading resistor on ID pin.

On Tue 2015-06-02 16:06:47, Dr. H. Nikolaus Schaller wrote: Hi, Am 02.06.2015 um 15:49 schrieb Kishon Vijay Abraham I kis...@ti.com: Hi, On Tuesday 02 June 2015 03:07 AM, NeilBrown wrote: On Mon, 1 Jun 2015 19:06:52 +0530 Kishon Vijay Abraham I kis...@ti.com wrote: Hi,

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

On Mon 2015-06-01 11:49:19, Maxime Ripard wrote: On Sat, May 30, 2015 at 12:14:30PM +0200, Pavel Machek wrote: Well... the driver was not broken... before you did cleanup that did two functional changes. And yes, the dts should be fixed, but that does not make your cleanup good. Whether

Re: Please revert 3eea8b5d68c801fec788b411582b803463834752 as it breaks touchscreen on n900.

The 3eea8b5d68c801fec788b411582b803463834752 is just bad. You were very welcome to review this patch at the time and/or suggest a fix that pleases everyone. You should be the one that should suggest fixes, as you broke it in the first place. But clearly you don't understand

Please revert 3eea8b5d68c801fec788b411582b803463834752 as it breaks touchscreen on n900.

Hi! But that's not what I'm asking. See a changelog of 3eea8b5d68c801fec788b411582b803463834752 and compare it with what it actually does. It is buggy. If fuzz is specified but maximum is not, it overwites maximum with zero. If maximum is not set, you'll have other issues anyway.

Re: Please revert 3eea8b5d68c801fec788b411582b803463834752 as it breaks touchscreen on n900.

On Mon 2015-06-01 10:47:30, Dmitry Torokhov wrote: On Mon, Jun 01, 2015 at 05:21:11PM +0200, Pavel Machek wrote: The 3eea8b5d68c801fec788b411582b803463834752 is just bad. You were very welcome to review this patch at the time and/or suggest a fix that pleases everyone

Re: [PATCH] Input: of_touchscreen - remove interdependence of max/fuzz values

the previous behaviour, that the drivers default value will be used for the unspecified value. Reported-By: Pavel Machek pa...@ucw.cz Fixes: 3eea8b5d68c8 (Input: of_touchscreen - rework the DT parsing function) Signed-off-by: Sebastian Reichel s...@kernel.org --- drivers/input/touchscreen

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

On Fri 2015-05-29 22:03:06, Maxime Ripard wrote: On Fri, May 29, 2015 at 02:49:55PM -0500, Felipe Balbi wrote: Hi, On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: Fix dts to match what the Linux kernel expects. This works around touchscreen problems in 4.1 linux

[PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

Fix dts to match what the Linux kernel expects. This works around touchscreen problems in 4.1 linux on Nokia n900. Signed-off-by: Pavel Machek pa...@ucw.cz diff --git a/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt b/Documentation/devicetree/bindings/input/touchscreen

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

On Fri 2015-05-29 13:48:47, Dmitry Torokhov wrote: On Fri, May 29, 2015 at 10:34:56PM +0200, Pavel Machek wrote: Hi! single DT, you don't even use that property in your driver, and now that you realise you meant something else, you want the code that not Pali, Sebastian

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

On Fri 2015-05-29 14:49:55, Felipe Balbi wrote: Hi, On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: Fix dts to match what the Linux kernel expects. This works around touchscreen problems in 4.1 linux on Nokia n900. Signed-off-by: Pavel Machek pa...@ucw.cz diff

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

So, because this has been wrongly documented for so long, we should support both bindings. Sure, deprecate touchscreen-max-[xy], but they must still be supported, IMO. This property has never been anything but a typo in a documentation of a single driver. Feel free to fix

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

Hi! single DT, you don't even use that property in your driver, and now that you realise you meant something else, you want the code that not Pali, Sebastian. actually parse the *right* property and does the right thing, that all other DT agree (and depend on) to be reverted?

Re: twl4030_charger: need changes to get probed?

Hi! Ok, but: 1) Why is the twl4030-bci enabled in n900's dts, then maybe it is bug in n900 dts... Grazvydas, is there some runtime check if twl4030/twl5030 chip has charger or not? or do we need to explicitly disable device twl4030-bci in DT? Actually from looking at the

Re: n900 in 4.1-rc0

Hi! Just tried booting 4.1-rc0 on n900 (commit 34c9a0ffc75ad25b6a60f61e27c4a4b1189b8085) and it is broken. Any ideas? Looks like DT and legacy booting are working fine in our labs. [0][1] Interesting web pages, thanks. I noticed that legacy booting indicates broken today, but... Is

Re: n900 in 4.1-rc0

On Thu 2015-04-16 09:35:54, Tony Lindgren wrote: * Marc Zyngier marc.zyng...@arm.com [150416 02:38]: On 16/04/15 10:32, Pavel Machek wrote: Hi! Just tried booting 4.1-rc0 on n900 (commit 34c9a0ffc75ad25b6a60f61e27c4a4b1189b8085) and it is broken. Any ideas

Re: [PATCH 4/6] phy: twl4030-usb: add ABI documentation

On Thu 2015-04-16 18:03:04, NeilBrown wrote: From: NeilBrown ne...@suse.de This driver device one local attribute: vbus. Describe that in Documentation/ABI/testing/sysfs-platform/twl4030-usb. Signed-off-by: NeilBrown n...@brown.name --- .../ABI/testing/sysfs-platform-twl4030-usb

n900 in 4.1-rc0

Hi! Just tried booting 4.1-rc0 on n900 (commit 34c9a0ffc75ad25b6a60f61e27c4a4b1189b8085) and it is broken. Any ideas? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures)

Re: [PATCHv7] media: i2c/adp1653: Devicetree support for adp1653

Hi! #define to_adp1653_flash(sd) container_of(sd, struct adp1653_flash, subdev) Let me know if you're going to send v8 or if I can make the changes. I think we're pretty much done then. You are free to make the changes. Thanks,

[PATCHv7] media: i2c/adp1653: Devicetree support for adp1653

Add device tree support for adp1653 flash LED driver. Signed-off-by: Pavel Machek pa...@ucw.cz --- Second part of a patch after documentation was merged. Please apply, Pavel diff --git a/drivers/media/i2c/adp1653.c b/drivers/media/i2c

[PATCHv7] media: i2c/adp1653: fix includes

Fix includes according to Sebastian. Signed-off-by: Pavel Machek pa...@ucw.cz --- On Thu 2015-04-09 14:19:14, Sebastian Reichel wrote: On Thu, Apr 09, 2015 at 01:29:43PM +0200, Pavel Machek wrote: On Thu 2015-04-09 11:10:17, Sebastian Reichel wrote: On Thu, Apr 09, 2015 at 09:42:38AM

Re: [PATCHv7] media: i2c/adp1653: Devicetree support for adp1653

On Thu 2015-04-09 11:10:17, Sebastian Reichel wrote: Hi, On Thu, Apr 09, 2015 at 09:42:38AM +0200, Pavel Machek wrote: [...] +#include linux/of_gpio.h +#include linux/gpio.h [...] This should probably be #include linux/of.h #include linux/gpio/consumer.h And I thought people

Re: [PATCH 13/14] twl4030_charger: Increase current carefully while watching voltage.

Hi! The USB Battery Charging spec (BC1.2) suggests a dedicated charging port can deliver from 0.5 to 5.0A at between 4.75 and 5.25 volts. To choose the correct current voltage setting requires a trial and error approach: try to draw current and see if the voltage drops too

Re: [PATCHv6] media: i2c/adp1653: Documentation for devicetree support for adp1653

Documentation for adp1653 binding. Signed-off-by: Pavel Machek pa...@ucw.cz --- Please apply. Sorry, wrong version of patch was sent last time. Pavel diff --git a/Documentation/devicetree/bindings/media/i2c/adp1653.txt

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

Hi! Please propose your own code doing that so that we can test if it is better. So, how does this look? It looks to me like you have cca 0.1 Ohm resistance in your system, This is completely unknown. and are using cca 75mA while discharging, and charge by cca 1.4A. Where

Re: [PATCHv6] media: i2c/adp1653: Documentation for devicetree support for adp1653

Hi! enable-gpios: Specifier of the GPIO connected to EN pin I can make the changes if you're ok with that, otherwise please send v7. Then I'll apply that to my tree. I'm ok with that. Thanks, Pavel -- (english)

Re: [PATCHv4] media: i2c/adp1653: devicetree support for adp1653

Hi! Fixed feedback by Sakari. Please apply, There is no need to ask for patches to be applied IMHO. It is expected that people post patches wanting them to be applied unless there is an RFC prefix in the subject or say explicitly that the patch is for testing and should not be picked.

Re: [PATCHv3] media: i2c/adp1653: devicetree support for adp1653

Hi! Hi Pawel, I'm still Pavel. v, not w. Hi Pawel, A corresponding change to the N900 dts would be very nice. Corresponding change to the dts will come in separate patch. Or do you have n900 for testing? Yes, it should be a separate patch, I agree. I do have one but I can't

[PATCHv5] media: i2c/adp1653: devicetree support for adp1653

We are moving to device tree support on OMAP3, but that currently breaks ADP1653 driver. This adds device tree support, plus required documentation. Signed-off-by: Pavel Machek pa...@ucw.cz --- Switched to gpiod_, as requested by Javier. Please apply

Re: ARM errata 430973 on multi platform kernels (was: OMAP3-N900: Add microphone bias voltages)

Hi! Maybe an option would be to provide two cpu_v7_switch_mm implementations (one with the errata and one without). Then the system can start with the simple implementation. Once the boot as progressed far enough to know, that the hardware is affected by the errata, it could switch to the

Re: [PATCHv5] media: i2c/adp1653: devicetree support for adp1653

Hi! + pd-max_flash_intensity = val/1000; + + if (of_property_read_u32(child, max-microamp, val)) + return -EINVAL; + pd-max_torch_intensity = val/1000; I think you need to do of_node_put(child) here and after you're done with indicator below. ...and in most of the

[PATCHv6] media: i2c/adp1653: Documentation for devicetree support for adp1653

Documentation for adp1653 binding. --- Please split this as Javier suggested. I'd think both could go through the media-tree unless someone objects. Please apply. + - power-gpios: Reference to the GPIO that controls the power for the chip. You're using power-gpios in documentation

Re: [PATCHv3] media: i2c/adp1653: devicetree support for adp1653

On Fri 2015-04-03 14:23:56, Sakari Ailus wrote: Hi Pavel, On Fri, Apr 03, 2015 at 10:23:44AM +0200, Pavel Machek wrote: Hi! Hi Pawel, I'm still Pavel. v, not w. I know too many Pawels. Sorry about that. :-) I guess it uses adp1653_id_table. I'd hade to add redundand

Re: [PATCHv3] media: i2c/adp1653: devicetree support for adp1653

Hi! Hi Pawel, My apologies for the very late reply. On Thu, Apr 02, 2015 at 04:38:46PM +0200, Pavel Machek wrote: We are moving to device tree support on OMAP3, but that currently breaks ADP1653 driver. This adds device tree support, plus required documentation. Signed-off

[PATCHv4] media: i2c/adp1653: devicetree support for adp1653

We are moving to device tree support on OMAP3, but that currently breaks ADP1653 driver. This adds device tree support, plus required documentation. Signed-off-by: Pavel Machek pa...@ucw.cz --- Fixed feedback by Sakari. Please apply

[PATCHv3] media: i2c/adp1653: devicetree support for adp1653

We are moving to device tree support on OMAP3, but that currently breaks ADP1653 driver. This adds device tree support, plus required documentation. Signed-off-by: Pavel Machek pa...@ucw.cz --- I'm not sure if it is device tree or media framework, either everyone waits for someone else

Re: [PATCH] ti-soc-thermal: implement omap3 support

+/* Thresholds and limits for OMAP34XX MPU temperature sensor */ +static struct temp_sensor_data omap34xx_mpu_temp_sensor_data = { + .min_freq = 32768, + .max_freq = 32768, + .max_temp = -99000, + .min_temp = 99000, This looks mixed up. Also, perhaps use

[PATCHv2] ti-soc-thermal: implement omap3 support

This adds support for OMAP3 chips to ti-soc-thermal. As requested by TI people, it is marked unreliable and warning is printed. Signed-off-by: Pavel Machek pa...@ucw.cz --- Patch is against thermal linus tree, please apply so that it has chance for 4.1. v2: fixed min/max temp diff --git

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

from your code at low battery temperature (say -10C). Anyway, see above, I think I provide reasonable values even in that range. Signed-off-by: Pavel Machek pa...@ucw.cz Pavel #!/usr/bin/python3 import math def

[PATCH] ti-soc-thermal: implement omap3 support

This adds support for OMAP3 chips to ti-soc-thermal. As requested by TI people, it is marked unreliable and warning is printed. Signed-off-by: Pavel Machek pa...@ucw.cz --- Patch is against thermal linus tree, please apply so that it has chance for 4.1. diff --git a/drivers/thermal/ti-soc

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

Hi! +io-channels = twl_madc 1, + twl_madc 10, + twl_madc 12; +io-channel-names = temp, + ichg, + vbat; +};

4.0-rc1 to -rc4: random sound and speed problems on n900

Hi! 4.0-rc4 (or more specifically 7b09ac704bac2de5bf0362793edc22a0094e381c based kernel boots really really slowly on n900, and there's an ugly backtrace from sound in the dmesg. I re-tested 4.0-rc4 and it worked ok. Weird. I guess we have some random stuff going on during boot

Re: [PATCHv2] ti-soc-thermal: request temperature periodically if hw can't do that itself

On Tue 2015-03-24 12:30:34, Eduardo Valentin wrote: On Sun, Jan 18, 2015 at 09:24:47PM +0100, Pavel Machek wrote: When periodic mode is not enabled, it is neccessary to force reads. Signed-off-by: Pavel Machek pa...@ucw.cz This is a malformed patch. here is patch output (or git am

[PATCHv3] ti-soc-thermal: request temperature periodically if hw can't do that itself

When periodic mode is not enabled, it is neccessary to force reads. Signed-off-by: Pavel Machek pa...@ucw.cz diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c index 62a5d44..ec533e7 100644 --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c

Re: [PATCHv2] thermal: add omap3 support

On Mon 2015-03-23 10:31:51, Eduardo Valentin wrote: On Sun, Jan 18, 2015 at 09:28:24PM +0100, Pavel Machek wrote: Add support for omap3430 sensor. Tested on Nokia N900. Fix help text to be closer to english. Ifdefs in ti-bandgap.h are not neccessary, as users have #ifdefs

Re: [PATCHv2] thermal: add omap3 support

On Sat 2015-03-14 19:02:40, Pavel Machek wrote: On Fri 2015-03-13 12:53:45, Eduardo Valentin wrote: Hey Pavel, On Fri, Mar 13, 2015 at 01:09:35PM +0100, Pavel Machek wrote: Hi! I checked 4.0-rc3 and linux-next as of today, and can not see omap3 thermal support. Can you

Re: [PATCH 02/14] twl4030_charger: use devres for power_supply_register and kzalloc.

On Mon 2015-03-23 10:20:28, NeilBrown wrote: From: NeilBrown ne...@suse.de Final allocations/registrations are now managed by devres. Signed-off-by: NeilBrown ne...@suse.de Patches 1,2: Acked-by: Pavel Machek pa...@ucw.cz -- (english) http://www.livejournal.com/~pavelmachek (cesky

Re: [PATCH 13/14] twl4030_charger: Increase current carefully while watching voltage.

Hi! The USB Battery Charging spec (BC1.2) suggests a dedicated charging port can deliver from 0.5 to 5.0A at between 4.75 and 5.25 volts. To choose the correct current voltage setting requires a trial and error approach: try to draw current and see if the voltage drops too low. Even

Re: [PATCH v3 3/6] Documentation: DT: Document twl4030-madc-battery bindings

Hi! diff --git a/Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt b/Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt new file mode 100644 index 000..bb3580c --- /dev/null +++

Re: [PATCH v3 3/6] Documentation: DT: Document twl4030-madc-battery bindings

Temperature calibration should have already been done in the underlaying twl4030 iio driver. Discharge rate is the real current flow reported in uA. Also reported by iio. Ack, but there's rather severe temperature dependency of the lithium battery, which you should take into account if

Re: [PATCH v3 3/6] Documentation: DT: Document twl4030-madc-battery bindings

Hi! to introduce coefficients for temperature and discharge rate? What do you mean? Nothing like that is used in current driver why do we need to add it? Well, conversion between Li-ion's voltage and state of charge at 0 current is well known: We can’t measure at 0 current since

Re: [PATCH v3 3/6] Documentation: DT: Document twl4030-madc-battery bindings

On Tue 2015-03-17 10:07:12, Dr. H. Nikolaus Schaller wrote: Am 17.03.2015 um 09:47 schrieb Pavel Machek pa...@ucw.cz: Hi! diff --git a/Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt b/Documentation/devicetree/bindings/power_supply

Re: [PATCH v3 3/6] Documentation: DT: Document twl4030-madc-battery bindings

Hi! to introduce coefficients for temperature and discharge rate? What do you mean? Nothing like that is used in current driver why do we need to add it? Well, conversion between Li-ion's voltage and state of charge at 0 current is well known: We can’t measure at 0 current since

Re: [PATCH v3 3/6] Documentation: DT: Document twl4030-madc-battery bindings

On Wed 2015-02-04 23:14:32, Marek Belisko wrote: Signed-off-by: Marek Belisko ma...@goldelico.com --- .../bindings/power_supply/twl4030_madc_battery.txt | 43 ++ 1 file changed, 43 insertions(+) create mode 100644

Re: [PATCHv2] thermal: add omap3 support

On Fri 2015-03-13 12:53:45, Eduardo Valentin wrote: Hey Pavel, On Fri, Mar 13, 2015 at 01:09:35PM +0100, Pavel Machek wrote: Hi! I checked 4.0-rc3 and linux-next as of today, and can not see omap3 thermal support. Can you apply the patches? Yeah, it should be possible. Apologize

Re: [PATCHv2] thermal: add omap3 support

Hi! @@ -384,25 +385,10 @@ int ti_bandgap_set_sensor_data(struct ti_bandgap *bgp, int id, void *data); void *ti_bandgap_get_sensor_data(struct ti_bandgap *bgp, int id); int ti_bandgap_get_trend(struct ti_bandgap *bgp, int id, int *trend); -#ifdef CONFIG_OMAP4_THERMAL +extern

Re: [PATCHv2] thermal: add omap3 support

Hi! I checked 4.0-rc3 and linux-next as of today, and can not see omap3 thermal support. Can you apply the patches? Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures)

Documentation: leds: clarify what 50% brightness means

I played with RGB LED a bit, and we have quite a gap in documentation: what 50% brightness means is non-trivial and very important in case we want to do smooth blinking and color transitions. Signed-off-by: Pavel Machek pa...@ucw.cz diff --git a/Documentation/ABI/testing/sysfs-class-led b

Re: RGB LED control (was Re: advanced LED controllers)

On Mon 2015-03-09 11:50:56, Måns Rullgård wrote: Geert Uytterhoeven ge...@linux-m68k.org writes: Hi Pavel, On Sun, Mar 8, 2015 at 9:57 PM, Pavel Machek pa...@ucw.cz wrote: Ok, so I played with RGB LED a bit, and we have quite a gap in documentation: what 50% brightness means is non

Re: [PATCH v2] crypto: omap-sham: Check for return value from pm_runtime_get_sync

On Sun 2015-03-08 11:01:01, Pali Rohár wrote: Function pm_runtime_get_sync could fail and we need to check return value to prevent kernel crash. Signed-off-by: Pali Rohár pali.ro...@gmail.com Acked-by: Pavel Machek pa...@ucw.cz -- (english) http://www.livejournal.com/~pavelmachek (cesky

Re: RGB LED control (was Re: advanced LED controllers)

On Mon 2015-03-09 09:08:37, Geert Uytterhoeven wrote: Hi Pavel, On Sun, Mar 8, 2015 at 9:57 PM, Pavel Machek pa...@ucw.cz wrote: Ok, so I played with RGB LED a bit, and we have quite a gap in documentation: what 50% brightness means is non-trivial and very important in case we want to do

RGB LED control (was Re: advanced LED controllers)

Ok, so I played with RGB LED a bit, and we have quite a gap in documentation: what 50% brightness means is non-trivial and very important in case we want to do smooth blinking and color transitions. Signed-off-by: Pavel Machek pa...@ucw.cz diff --git a/Documentation/ABI/testing/sysfs-class-led

Re: twl4030_charger: need changes to get probed?

On Sat 2015-03-07 00:12:07, Grazvydas Ignotas wrote: On Fri, Mar 6, 2015 at 11:57 PM, Pali Rohár pali.ro...@gmail.com wrote: On Friday 06 March 2015 22:24:17 Pavel Machek wrote: Hi! According to n900 dts, twl4030-bci (aka charger) should be included. AFAIK it is not present

Right interface for cellphone modem audio (was Re: [PATCHv2 0/2] N900 Modem Speech Support)

Hi! Userland access goes via /dev/cmt_speech. The API is implemented in libcmtspeechdata, which is used by ofono and the freesmartphone.org project. Yes, the ABI is tested for some years, but it is not documented, and it is very wrong ABI. I'm not sure what they do with the read(). I was

  1   2   3   4   5   6   >