Re: [PATCH v2] OMAP2+: UART: Add mechanism to probe uart pins and configure rx wakeup

2012-05-11 Thread Raja, Govindraj
On Fri, May 11, 2012 at 12:41 AM, Tony Lindgren t...@atomide.com wrote: * Govindraj.R govindraj.r...@ti.com [120510 06:09]: From: Govindraj.R govindraj.r...@ti.com The commit (bce492c0  ARM: OMAP2+: UART: Fix incorrect population of default uart pads) removed default uart pads that where

Re: [PATCH v2] OMAP2+: UART: Add mechanism to probe uart pins and configure rx wakeup

2012-05-11 Thread Raja, Govindraj
On Fri, May 11, 2012 at 2:04 PM, Russ Dill russ.d...@gmail.com wrote: On Thu, May 10, 2012 at 6:05 AM, Govindraj.R govindraj.r...@ti.com wrote: From: Govindraj.R govindraj.r...@ti.com The commit (bce492c0  ARM: OMAP2+: UART: Fix incorrect population of default uart pads) removed default uart

Re: [PATCH 0/8] gpio/omap: remaining cleanups and fix

2012-05-10 Thread Raja, Govindraj
Hi Tarun, On Fri, Apr 27, 2012 at 7:43 PM, Tarun Kanti DebBarma tarun.ka...@ti.com wrote: Here are the remaining cleanup patches. There are broadly two categories of cleanups. Cat-1: Those missed while introducing new feature like SPARSE_IRQ       handling and DT support; use edge/level

Re: Broken UART I/O wakeups on v3.4-rc4+

2012-05-08 Thread Raja, Govindraj
On Tue, May 8, 2012 at 10:35 AM, Paul Walmsley p...@pwsan.com wrote: Govindraj, After your commit bce492c04ba8fc66a4ea0a52b181ba255daaaf54 (ARM: OMAP2+: UART: Fix incorrect population of default uart pads), the kernel does not return from static suspend when off-mode is enabled upon an

Re: [PATCH] omap3_beagle: init uart2 for beagle rev AX/BX only

2012-05-07 Thread Raja, Govindraj
On Fri, May 4, 2012 at 11:48 PM, Tony Lindgren t...@atomide.com wrote: Hi, Looking at this again.. * Govindraj.R govindraj.r...@ti.com [120306 00:34]: From: Govindraj.R govindraj.r...@ti.com All beagle boards rev AX/BX have external usb hubs connected to ehci interface, external

Re: [PATCH RESEND] ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue

2012-05-03 Thread Raja, Govindraj
On Thu, May 3, 2012 at 6:55 AM, Russ Dill russ.d...@ti.com wrote: On Wed, May 2, 2012 at 3:38 AM, Raja, Govindraj govindraj.r...@ti.com wrote: On Wed, May 2, 2012 at 2:17 PM, Russ Dill russ.d...@ti.com wrote: On Mon, Mar 19, 2012 at 6:34 AM, Raja, Govindraj govindraj.r...@ti.com wrote

Re: [PATCH RESEND] ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue

2012-05-02 Thread Raja, Govindraj
On Wed, May 2, 2012 at 2:17 PM, Russ Dill russ.d...@ti.com wrote: On Mon, Mar 19, 2012 at 6:34 AM, Raja, Govindraj govindraj.r...@ti.com wrote: On Mon, Mar 19, 2012 at 12:12 PM, Keshava Munegowda keshava_mgo...@ti.com wrote: From: Keshava Munegowda keshava_mgo...@ti.com It is observed

Re: [PATCH RESEND] ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue

2012-05-02 Thread Raja, Govindraj
On Wed, May 2, 2012 at 4:20 PM, Koen Kooi k...@dominion.thruhere.net wrote: Op 2 mei 2012, om 12:38 heeft Raja, Govindraj het volgende geschreven: On Wed, May 2, 2012 at 2:17 PM, Russ Dill russ.d...@ti.com wrote: On Mon, Mar 19, 2012 at 6:34 AM, Raja, Govindraj govindraj.r...@ti.com wrote

Re: [PATCH 1/2] OMAP2+: UART: Fix incorrect population of default uart pads

2012-04-24 Thread Raja, Govindraj
On Tue, Apr 24, 2012 at 5:15 AM, Kevin Hilman khil...@ti.com wrote: Govindraj.R govindraj.r...@ti.com writes: From: Govindraj.R govindraj.r...@ti.com The following commit: (7496ba3  ARM: OMAP2+: UART: Add default mux for all uarts) added default pads for all uarts. But not all boards tend

Re: defconfig for panda

2012-04-24 Thread Raja, Govindraj
On Fri, Apr 20, 2012 at 10:43 PM, Tony Lindgren t...@atomide.com wrote: * Matt Porter mpor...@ti.com [120420 09:04]: On Fri, Mar 30, 2012 at 02:39:32PM -0700, Tony Lindgren wrote: * Kumar Gala ga...@kernel.crashing.org [120330 14:14]: On Mar 30, 2012, at 1:48 PM, Tony Lindgren wrote:

Re: [PATCH] tty: serial_core: Add mechanism to identify port closure.

2012-04-23 Thread Raja, Govindraj
Hi Alan, On Fri, Apr 20, 2012 at 6:57 PM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c index 9c4c05b..0dc246d 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c @@ -1284,6 +1284,8

Re: [PATCH] tty: omap-serial: Keep the wakeup mechanism enabled by default

2012-04-19 Thread Raja, Govindraj
On Thu, Apr 19, 2012 at 12:38 AM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: The point is that wakeups should be enabled whenever driver is in use, and disabled when the driver is not in use. Which is the tty_port methods for initialisation and shutdown, which are mutex protected against each

Re: [PATCH] tty: omap-serial: Keep the wakeup mechanism enabled by default

2012-04-18 Thread Raja, Govindraj
On Wed, Apr 18, 2012 at 4:55 AM, Kevin Hilman khil...@ti.com wrote: Govindraj.R govindraj.r...@ti.com writes: From: Govindraj.R govindraj.r...@ti.com The wakeups can be left enabled by default and should be disabled only when disabled from sysfs and while entering suspend. Left enabled?  

Re: [PATCH 2/2] OMAP2+: UART: Add mechanism to probe uart pins and configure rx wakeup

2012-04-17 Thread Raja, Govindraj
On Tue, Apr 17, 2012 at 7:11 AM, Tony Lindgren t...@atomide.com wrote: Hi, Few more comments below. * Raja, Govindraj govindraj.r...@ti.com [120411 04:53]: ... +static int  __init omap_serial_fill_default_pads(struct omap_board_data *bdata

Re: [GIT PULL]: omap-serial updates for 3.4-rc

2012-04-16 Thread Raja, Govindraj
Hi Tony, On Tue, Apr 10, 2012 at 3:36 PM, Raja, Govindraj govindraj.r...@ti.com wrote: CC'ing Linux-ARM On Tue, Apr 10, 2012 at 3:32 PM, Govindraj.R govindraj.r...@ti.com wrote: Hi Tony, Please Pull the following omap uart changes. Changes basically involves getting rid of cpu checks

Re: [PATCH] ARM: OMAP: serial: Fix the ocp smart idlemode handling bug

2012-04-16 Thread Raja, Govindraj
On Fri, Apr 13, 2012 at 11:25 PM, Santosh Shilimkar santosh.shilim...@ti.com wrote: The current serial UART code, while fidling with ocp idlemode bits, forget about the smart idle wakeup bit even if it is supported by UART IP block. This will lead to missing the module wakeup on OMAP's where

Re: [GIT PULL]: omap-serial updates for 3.4-rc

2012-04-16 Thread Raja, Govindraj
On Mon, Apr 16, 2012 at 12:52 PM, Raja, Govindraj govindraj.r...@ti.com wrote: Hi Tony, On Tue, Apr 10, 2012 at 3:36 PM, Raja, Govindraj govindraj.r...@ti.com wrote: CC'ing Linux-ARM On Tue, Apr 10, 2012 at 3:32 PM, Govindraj.R govindraj.r...@ti.com wrote: Hi Tony, Please Pull

Re: omap-serial: transmission of x-char with DMA (and other issues)

2012-04-16 Thread Raja, Govindraj
On Fri, Apr 13, 2012 at 4:11 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Can someone tell me how this works with the current omap-serial driver please?  It looks to me like this has been broken when DMA support was added to the driver. Yes x-char transmission in dma case is

Re: Suspend broken on 3.3?

2012-04-12 Thread Raja, Govindraj
On Thu, Apr 12, 2012 at 1:04 AM, Paul Walmsley p...@pwsan.com wrote: Hi a few brief comments based on a quick scan: On Wed, 11 Apr 2012, Raja, Govindraj wrote: Here is the patch [1] to do the same. - I don't see where it affects I/O wakeups for the UART.  If I/O wakeups are still set

Re: [PATCH 2/2] OMAP2+: UART: Add mechanism to probe uart pins and configure rx wakeup

2012-04-11 Thread Raja, Govindraj
On Tue, Apr 10, 2012 at 9:41 PM, Tony Lindgren t...@atomide.com wrote: * Govindraj.R govindraj.r...@ti.com [120410 06:44]: --- a/arch/arm/mach-omap2/serial.c +++ b/arch/arm/mach-omap2/serial.c @@ -120,11 +120,63 @@ static void omap_uart_set_smartidle(struct platform_device *pdev) {}  #endif

Re: Suspend broken on 3.3?

2012-04-11 Thread Raja, Govindraj
On Tue, Apr 10, 2012 at 11:33 PM, Kevin Hilman khil...@ti.com wrote: Raja, Govindraj govindraj.r...@ti.com writes: Hi Kevin, On Mon, Apr 9, 2012 at 10:40 PM, Kevin Hilman khil...@ti.com wrote: Paul Walmsley p...@pwsan.com writes: [...] Just to summarize on how the behavior should be IIUC

Re: Suspend broken on 3.3?

2012-04-10 Thread Raja, Govindraj
Hi Kevin, On Mon, Apr 9, 2012 at 10:40 PM, Kevin Hilman khil...@ti.com wrote: Paul Walmsley p...@pwsan.com writes: [...] I don't understand why a user would ever want to disable dynamic wakeups on an in-use serial port via the sysfs power/wakeup file.  (Disabling wakeups from suspend is a

Re: [GIT PULL]: omap-serial updates for 3.4-rc

2012-04-10 Thread Raja, Govindraj
CC'ing Linux-ARM On Tue, Apr 10, 2012 at 3:32 PM, Govindraj.R govindraj.r...@ti.com wrote: Hi Tony, Please Pull the following omap uart changes. Changes basically involves getting rid of cpu checks for populating erratas and features and move the same from serial.c to omap-serial.c, MVR

Re: [RESEND PATCH] ARM :OMAP2+: UART: Remove some of uart default pads

2012-04-09 Thread Raja, Govindraj
Hi Tony, On Fri, Apr 6, 2012 at 11:45 PM, Tony Lindgren t...@atomide.com wrote: * Raja, Govindraj govindraj.r...@ti.com [120405 23:08]: On Thu, Apr 5, 2012 at 10:28 PM, Tony Lindgren t...@atomide.com wrote: Hmm I don't think any muxing was done automatically unless omap_serial_init_port

Re: Suspend broken on 3.3?

2012-04-09 Thread Raja, Govindraj
Hi Kevin / Paul, On Fri, Apr 6, 2012 at 7:51 PM, Kevin Hilman khil...@ti.com wrote: Paul Walmsley p...@pwsan.com writes: On Wed, 4 Apr 2012, Raja, Govindraj wrote: On Wed, Apr 4, 2012 at 8:26 PM, Paul Walmsley p...@pwsan.com wrote: On Mon, 2 Apr 2012, Raja, Govindraj wrote: As of now

Re: [RESEND PATCH] ARM :OMAP2+: UART: Remove some of uart default pads

2012-04-06 Thread Raja, Govindraj
On Thu, Apr 5, 2012 at 10:28 PM, Tony Lindgren t...@atomide.com wrote: * Raja, Govindraj govindraj.r...@ti.com [120403 23:18]: On Tue, Apr 3, 2012 at 11:49 PM, Tony Lindgren t...@atomide.com wrote: * Govindraj.R govindraj.r...@ti.com [120321 03:06]: From: Govindraj.R govindraj.r...@ti.com

Re: OMAP3EVM not booting on l-o master

2012-04-05 Thread Raja, Govindraj
Hi Afzal, On Thu, Apr 5, 2012 at 3:47 PM, Paul Walmsley p...@pwsan.com wrote: cc Tony Hi, On Thu, 5 Apr 2012, Mohammed, Afzal wrote: On Thu, Apr 05, 2012 at 15:03:36, Paul Walmsley wrote: Could you try booting with initcall_debug and posting the boot log? Logs as follows, thanks.

Re: [PATCH 0/3] OMAP2+: UART: Enable tx wakeup + remove cpu checks

2012-04-05 Thread Raja, Govindraj
On Wed, Mar 21, 2012 at 3:54 PM, Govindraj.R govindraj.r...@ti.com wrote: From: Govindraj.R govindraj.r...@ti.com Based on Linux-OMAP tree uart branch. (git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git remotes/origin/uart) * Removes the cpu checks wherever possible and

Re: [RESEND PATCH] ARM :OMAP2+: UART: Remove some of uart default pads

2012-04-04 Thread Raja, Govindraj
On Tue, Apr 3, 2012 at 11:49 PM, Tony Lindgren t...@atomide.com wrote: * Govindraj.R govindraj.r...@ti.com [120321 03:06]: From: Govindraj.R govindraj.r...@ti.com The following commit: (7496ba3  ARM: OMAP2+: UART: Add default mux for all uarts) added default pads for all uarts. But not all

Re: Suspend broken on 3.3?

2012-04-04 Thread Raja, Govindraj
On Wed, Apr 4, 2012 at 8:26 PM, Paul Walmsley p...@pwsan.com wrote: Hello Govindraj On Mon, 2 Apr 2012, Raja, Govindraj wrote: As of now what I can think of is to update qos reqest to prevent MPU from transitioning in case of port activity if wakeup capability for port is disabled

Re: Suspend broken on 3.3?

2012-03-30 Thread Raja, Govindraj
On Fri, Mar 30, 2012 at 1:23 PM, Joe Woodward j...@terrafix.co.uk wrote: -Original Message- From: Raja, Govindraj govindraj.r...@ti.com To: Joe Woodward j...@terrafix.co.uk Cc: Paul Walmsley p...@pwsan.com, Kevin Hilman khil...@ti.com, linux-omap@vger.kernel.org, Felipe Balbi ba

Re: Suspend broken on 3.3?

2012-03-30 Thread Raja, Govindraj
On Fri, Mar 30, 2012 at 2:56 PM, Joe Woodward j...@terrafix.co.uk wrote: ...[snip]... Could you please try attached patch and let me know if this solves the rx issue as well, without using dma mode. Right, I think we've getting closer, but still not quite there... Firstly, the patch

Re: Suspend broken on 3.3?

2012-03-30 Thread Raja, Govindraj
On Fri, Mar 30, 2012 at 4:34 PM, Joe Woodward j...@terrafix.co.uk wrote: -Original Message- From: Raja, Govindraj govindraj.r...@ti.com To: Joe Woodward j...@terrafix.co.uk Cc: Paul Walmsley p...@pwsan.com, Kevin Hilman khil...@ti.com, linux-omap@vger.kernel.org, Felipe Balbi ba

Re: [PATCH 1/3] OMAP2+: UART: Remove cpu checks for populating errata flags

2012-03-29 Thread Raja, Govindraj
On Wed, Mar 28, 2012 at 10:13 PM, Jon Hunter jon-hun...@ti.com wrote: Hi Govindraj, On 3/28/2012 6:09, Raja, Govindraj wrote: On Wed, Mar 28, 2012 at 2:38 AM, Jon Hunterjon-hun...@ti.com  wrote: Hi Govindraj, [...] +       u32 mvr, scheme; +       u16 revision, major, minor

Re: Suspend broken on 3.3?

2012-03-29 Thread Raja, Govindraj
On Thu, Mar 29, 2012 at 5:10 PM, Joe Woodward j...@terrafix.co.uk wrote: -Original Message- From: Joe Woodward j...@terrafix.co.uk To: Paul Walmsley p...@pwsan.com Cc: Kevin Hilman khil...@ti.com, Raja\\, Govindraj govindraj.r...@ti.com, linux-omap@vger.kernel.org, Felipe Balbi

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-03-28 Thread Raja, Govindraj
On Wed, Mar 28, 2012 at 2:22 PM, Felipe Balbi ba...@ti.com wrote: On Tue, Mar 27, 2012 at 04:08:55PM +0200, Igor Grinberg wrote: When PHY reset pin is connected to a GPIO on external GPIO chip (e.g. I2C), we should not call the gpio_set_value() function, but gpio_set_value_cansleep().

Re: Suspend broken on 3.3?

2012-03-28 Thread Raja, Govindraj
On Wed, Mar 28, 2012 at 3:07 AM, Kevin Hilman khil...@ti.com wrote: Raja, Govindraj govindraj.r...@ti.com writes: Hi Kevin, On Tue, Mar 27, 2012 at 6:04 AM, Kevin Hilman khil...@ti.com wrote: +Govindraj, Joe Woodward j...@terrafix.co.uk writes: Right, I've stepped back a bit and dug out

Re: [PATCH 1/3] OMAP2+: UART: Remove cpu checks for populating errata flags

2012-03-28 Thread Raja, Govindraj
On Wed, Mar 28, 2012 at 2:38 AM, Jon Hunter jon-hun...@ti.com wrote: Hi Govindraj, On 3/21/2012 5:24, Govindraj.R wrote: From: Govindraj.Rgovindraj.r...@ti.com Currently the errata is populated based on cpu checks this can be removed and replaced with module version check of uart ip

Re: Suspend broken on 3.3?

2012-03-27 Thread Raja, Govindraj
Hi Kevin, On Tue, Mar 27, 2012 at 6:04 AM, Kevin Hilman khil...@ti.com wrote: +Govindraj, Joe Woodward j...@terrafix.co.uk writes: Right, I've stepped back a bit and dug out a GUSMTIX Palo43 carrier board on which to test the Overo OMAP3530 COM and I've found:  - Running a stock 3.3 (with

Re: [PATCH 0/3] OMAP2+: UART: Enable tx wakeup + remove cpu checks

2012-03-23 Thread Raja, Govindraj
Hi Paul, On Fri, Mar 23, 2012 at 5:10 AM, Paul Walmsley p...@pwsan.com wrote: Hi On Thu, 22 Mar 2012, Raja, Govindraj wrote: Sorry I for got to add that, here are details on what was tested. 1.) OMAP2430 SDP : Boot tested with uart1 as console. 2.) OMAP3430 SDP: Boot test, suspend/resume

Re: [PATCH 0/3] OMAP2+: UART: Enable tx wakeup + remove cpu checks

2012-03-22 Thread Raja, Govindraj
On Wed, Mar 21, 2012 at 7:58 PM, Kevin Hilman khil...@ti.com wrote: Govindraj.R govindraj.r...@ti.com writes: From: Govindraj.R govindraj.r...@ti.com Based on Linux-OMAP tree uart branch. (git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git remotes/origin/uart) * Removes

Re: [PATCH RESEND] ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue

2012-03-19 Thread Raja, Govindraj
On Mon, Mar 19, 2012 at 12:12 PM, Keshava Munegowda keshava_mgo...@ti.com wrote: From: Keshava Munegowda keshava_mgo...@ti.com It is observed that the echi ports of 3430 sdp board are not working due to the random timing of programming the associated GPIOs of the ULPI PHYs of the EHCI for

Re: [PATCH] omap_hwmod: Allow io_ring wakeup configuration for all modules.

2012-03-12 Thread Raja, Govindraj
On Wed, Mar 7, 2012 at 7:40 PM, Raja, Govindraj govindraj.r...@ti.com wrote: On Wed, Mar 7, 2012 at 5:49 PM, Govindraj.R govindraj.r...@ti.com wrote: [...] From b3aa1dac5909cad1b959f5b97bbf408b2f974060 Mon Sep 17 00:00:00 2001 From: Govindraj.R govindraj.r...@ti.com Date: Wed, 7 Mar 2012

Re: [RFC PATCH] OMAP: UART: Enable tx wakeup bit in wer

2012-03-08 Thread Raja, Govindraj
On Wed, Mar 7, 2012 at 11:27 AM, Paul Walmsley p...@pwsan.com wrote: Hi On Tue, 6 Mar 2012, Raja, Govindraj wrote: I see two ways of adding this tx wake-up flag. 1.) passing a feature flag from pdata and populating the feature value to wer. 2.) Duplicating the uart1/2/3 hwmod

Re: [PATCH] omap_hwmod: Allow io_ring wakeup configuration for all modules.

2012-03-07 Thread Raja, Govindraj
On Wed, Mar 7, 2012 at 5:49 PM, Govindraj.R govindraj.r...@ti.com wrote: From: Govindraj.R govindraj.r...@ti.com Some modules doesn't have SYSC_HAS_ENAWAKEUP bit available (ex: usb host uhh module) in absence of this flag omap_hwmod_enable/disable_wakeup avoids configuring pad mux wakeup

Re: [PATCH] omap3_beagle: Init only uart3 used for console

2012-03-06 Thread Raja, Govindraj
On Mon, Mar 5, 2012 at 7:36 PM, Koen Kooi k...@dominion.thruhere.net wrote: Op 5 mrt. 2012, om 12:12 heeft Govindraj.R het volgende geschreven: From: Govindraj.R govindraj.r...@ti.com On beagle some of uart mux lines are used for other purpose so init only uart3. Uart2 rx line clashes

Re: [PATCH] omap3_beagle: Init only uart3 used for console

2012-03-06 Thread Raja, Govindraj
On Tue, Mar 6, 2012 at 1:30 AM, Kevin Hilman khil...@ti.com wrote: Govindraj.R govindraj.r...@ti.com writes: From: Govindraj.R govindraj.r...@ti.com On beagle some of uart mux lines are used for other purpose so init only uart3. OK, but you should also be clear that this patch is

Re: [PATCH] omap3_beagle: Init only uart3 used for console

2012-03-06 Thread Raja, Govindraj
On Tue, Mar 6, 2012 at 2:21 AM, Tony Lindgren t...@atomide.com wrote: * Kevin Hilman khil...@ti.com [120305 11:28]: Govindraj.R govindraj.r...@ti.com writes: From: Govindraj.R govindraj.r...@ti.com On beagle some of uart mux lines are used for other purpose so init only uart3. OK, but

Re: [RFC PATCH] OMAP: UART: Enable tx wakeup bit in wer

2012-03-06 Thread Raja, Govindraj
On Tue, Mar 6, 2012 at 1:53 AM, Paul Walmsley p...@pwsan.com wrote: Hello Govindraj Do you intend to update and repost this serial patch?  Or should someone else deal with it?  It would be good to get support for this additional wakeup bit. Thanks for reminding. (I had got preempted with