Hi Sebastien,
On 01/25/2013 08:44 AM, Sebastien Guiriec wrote:
Hi Ricardo,
You need to rebase this patch as the code has been moved to dss-common.c
file now. So it would not apply.
Thanks! I will send a new rebased version.
Ricardo
Sebastien
On 01/05/2013 12:26 AM, Ricardo Neri wrote
to an integer CTS value for such use case.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi.c | 142
1 file changed, 70 insertions(+), 72 deletions(-)
diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c
index 769d082
HDMI driver to
create the platform driver with the required resources.
Signed-off-by: Ricardo Neri
---
arch/arm/mach-omap2/devices.c | 24
drivers/video/omap2/dss/hdmi.c | 59
2 files changed, 59 insertions(+), 24 deletions(-)
diff
implemented.
Signed-off-by: Ricardo Neri
---
arch/arm/mach-omap2/board-4430sdp.c|6 --
arch/arm/mach-omap2/board-omap4panda.c |6 --
arch/arm/mach-omap2/devices.c |7 ---
arch/arm/mach-omap2/display.c | 31 +++
4 files
resource.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi.c |9 ++---
sound/soc/omap/omap-hdmi.c |3 +--
sound/soc/omap/omap-hdmi.h |2 --
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss
also updated accordingly.
Signed-off-by: Ricardo Neri
---
arch/arm/mach-omap2/devices.c |4 ++--
sound/soc/omap/omap-hdmi-card.c |4 ++--
sound/soc/omap/omap-hdmi.c |2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm
.
Signed-off-by: Ricardo Neri
---
arch/arm/mach-omap2/board-4430sdp.c|3 +++
arch/arm/mach-omap2/board-omap4panda.c |3 +++
2 files changed, 6 insertions(+)
diff --git a/arch/arm/mach-omap2/board-4430sdp.c
b/arch/arm/mach-omap2/board-4430sdp.c
index 3669c12..5a486d9 100644
--- a/arch
functionality in any patch.
Also, the names of the platform devices are changed to give them more logical
and more descriptive names.
As the commit
commit 14840b9a83c6a56629db2ba0ec247503e975f143
Author: Ricardo Neri
Date: Tue Nov 6 00:19:17 2012 -0600
OMAPDSS: HDMI: Create platform device
Hi Mark,
On 01/04/2013 04:42 AM, Mark Brown wrote:
On Thu, Jan 03, 2013 at 11:33:12AM -0600, Ricardo Neri wrote:
Just wondering if you had a chance to take a look at these patches.
Don't top post.
Sorry, my bad. Won't do it again.
Whatever patches you're talking about I
Hi Mark, Tomi,
Just wondering if you had a chance to take a look at these patches.
Thanks!
Ricardo
On 12/17/2012 07:30 PM, Ricardo Neri wrote:
Hi Mark, Tomi, Liam, Tony,
This set aims to be the version 3 of my previous submission[1] and aims to
address the comments that Mark and Tomi kindly
HDMI driver to
create the platform driver with the required resources.
Signed-off-by: Ricardo Neri
---
arch/arm/mach-omap2/devices.c | 24
drivers/video/omap2/dss/hdmi.c | 59
2 files changed, 59 insertions(+), 24 deletions(-)
diff
resource.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi.c |9 ++---
sound/soc/omap/omap-hdmi.c |3 +--
sound/soc/omap/omap-hdmi.h |2 --
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss
changed to give them more logical
and more descriptive names.
As the commit
commit 14840b9a83c6a56629db2ba0ec247503e975f143
Author: Ricardo Neri
Date: Tue Nov 6 00:19:17 2012 -0600
OMAPDSS: HDMI: Create platform device for audio support
is reverted in Tomi's git://gitorious.org/linux
implemented.
Signed-off-by: Ricardo Neri
---
arch/arm/mach-omap2/board-4430sdp.c|6 --
arch/arm/mach-omap2/board-omap4panda.c |6 --
arch/arm/mach-omap2/devices.c |7 ---
arch/arm/mach-omap2/display.c | 31 +++
4 files
also updated accordingly.
Signed-off-by: Ricardo Neri
---
arch/arm/mach-omap2/devices.c |4 ++--
sound/soc/omap/omap-hdmi-card.c |4 ++--
sound/soc/omap/omap-hdmi.c |2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm
.
Signed-off-by: Ricardo Neri
---
arch/arm/mach-omap2/board-4430sdp.c|3 +++
arch/arm/mach-omap2/board-omap4panda.c |3 +++
2 files changed, 6 insertions(+)
diff --git a/arch/arm/mach-omap2/board-4430sdp.c
b/arch/arm/mach-omap2/board-4430sdp.c
index 3669c12..5a486d9 100644
--- a/arch
On 11/22/2012 08:12 PM, Mark Brown wrote:
On Thu, Nov 22, 2012 at 08:03:53PM -0600, Ricardo Neri wrote:
On 11/21/2012 07:03 PM, Mark Brown wrote:
instantiation infrastructure in there which is rather Linux specific.
But the board files are only for Linux, right? The ASoC drivers will
On 11/22/2012 06:52 AM, Tomi Valkeinen wrote:
On 2012-11-22 02:20, Ricardo Neri wrote:
Hi Tomi, Mark,
On 11/19/2012 07:15 PM, Mark Brown wrote:
On Mon, Nov 19, 2012 at 02:58:41PM +0200, Tomi Valkeinen wrote:
I still don't understand why the codec and machine drivers need to be
creat
Hi Mark,
On 11/21/2012 07:03 PM, Mark Brown wrote:
On Wed, Nov 21, 2012 at 06:20:00PM -0600, Ricardo Neri wrote:
On 11/19/2012 07:15 PM, Mark Brown wrote:
Yes, this would be more sensible if there's no board specifics involved.
I think they are truly board-specific. For instance,
Hi Tomi,
Sorry for the delayed response.
On 11/19/2012 06:58 AM, Tomi Valkeinen wrote:
On 2012-11-16 20:05, Ricardo Neri wrote:
I hope the explanation above provides more clarity to you. I think HDMI
does not fit seamlessly into the ASoC driver model, as we don't have a
real codec a
Hi Tomi, Mark,
On 11/19/2012 07:15 PM, Mark Brown wrote:
On Mon, Nov 19, 2012 at 02:58:41PM +0200, Tomi Valkeinen wrote:
I still don't understand why the codec and machine drivers need to be
created in the board file. That just forces us to replicate the same
code for all OMAP boards that have
On 11/16/2012 01:52 AM, Tomi Valkeinen wrote:
On 2012-11-16 03:36, Ricardo Neri wrote:
This relocates and renames the platform devices for ASoC HDMI drivers
to give them a more logical structure.
The previous omap-hdmi-audio device is renamed as omap-hdmi-audio-card
and is relocated to the
Hi Tomi,
On 11/16/2012 01:38 AM, Tomi Valkeinen wrote:
Hi,
On 2012-11-16 03:36, Ricardo Neri wrote:
Creating the accessory devices (such as audio) from the HDMI driver,
allows to regard HDMI as a single entity with audio an display
functionality. This intends to follow the design of drivers
Hi Tomi,
On 11/15/2012 06:36 AM, Tomi Valkeinen wrote:
On 2012-11-15 11:45, Tomi Valkeinen wrote:
On 2012-11-15 04:33, Ricardo Neri wrote:
Hi Mark,
On 11/14/2012 05:08 PM, Mark Brown wrote:
On Wed, Nov 14, 2012 at 11:07:09AM -0600, Ricardo Neri wrote:
On 11/13/2012 09:27 PM, Mark Brown
name refers only to OMAP HDMI audio functionality, irrespective of the
board.
The names of the ASoC drivers are also updated accordingly.
Signed-off-by: Ricardo Neri
---
arch/arm/mach-omap2/board-4430sdp.c|6 ++
arch/arm/mach-omap2/board-omap4panda.c |6 ++
arch/arm/mach
.
Signed-off-by: Ricardo Neri
---
arch/arm/mach-omap2/devices.c | 14 -
drivers/video/omap2/dss/hdmi.c | 62
sound/soc/omap/omap-hdmi.c |3 +-
sound/soc/omap/omap-hdmi.h |2 -
4 files changed, 63 insertions(+), 18 deletions(-)
diff
. This intends to give to the platform devices more
descriptive names and create them from more relevant locations.
This set of patches requires that
commit 14840b9a83c6a56629db2ba0ec247503e975f143
Author: Ricardo Neri
Date: Tue Nov 6 00:19:17 2012 -0600
OMAPDSS: HDMI: Create platform device
Hi Mark,
On 11/14/2012 10:10 PM, Mark Brown wrote:
On Wed, Nov 14, 2012 at 08:33:11PM -0600, Ricardo Neri wrote:
On 11/14/2012 05:08 PM, Mark Brown wrote:
Don't do this. With a change like this which must be made at the same
time over multiple subsystems it is very important that you
Hi Mark,
On 11/14/2012 05:08 PM, Mark Brown wrote:
On Wed, Nov 14, 2012 at 11:07:09AM -0600, Ricardo Neri wrote:
On 11/13/2012 09:27 PM, Mark Brown wrote:
Presumably this needs some other corresponding change in the resource
setup to go in simultaneously...
Yes, the change in the
Hi Mark,
Thanks for reviewing!
On 11/13/2012 09:27 PM, Mark Brown wrote:
On Tue, Nov 13, 2012 at 08:30:49PM -0600, Ricardo Neri wrote:
Instead of defining the address offset of the DMA port for transfers of
audio samples, obtain this information from the resources
Hi Liam,
Thanks for reviewing!
On 11/14/2012 04:16 AM, Liam Girdwood wrote:
On 14/11/12 02:30, Ricardo Neri wrote:
Being the name of a machine driver, it aims to describe the
connection between the HDMI IP of the processor and the companion
chip it uses to connect to the outside world. This
Instead of defining the address offset of the DMA port for transfers of
audio samples, obtain this information from the resources of the device.
This device and its resources are created by the OMAPDSS HDMI driver.
Signed-off-by: Ricardo Neri
---
sound/soc/omap/omap-hdmi.c |3 +--
sound/soc
companion chip for DC-DC step-up, I2C level shifter and
low-capacitance ESD protection. This chip is used on all OMAP4 Pandaboards an
SDPs as well as in OMAP5 EVMs.
Signed-off-by: Ricardo Neri
---
sound/soc/omap/omap-hdmi-card.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a
.
Signed-off-by: Ricardo Neri
---
sound/soc/omap/omap-hdmi-card.c |2 +-
sound/soc/omap/omap-hdmi.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/omap/omap-hdmi-card.c b/sound/soc/omap/omap-hdmi-card.c
index 184180e..d6f4dba 100644
--- a/sound/soc/omap
[1]. http://www.mail-archive.com/linux-omap@vger.kernel.org/msg79795.html
Ricardo Neri (3):
ASoC: OMAP: HDMI: Update machine driver name
ASoC: OMAP: HDMI: Update CPU DAI driver name
ASoC: OMAP: HDMI: Obtain DMA port from resources
sound/soc/omap/omap-hdmi-card.c |4 ++--
sound/soc
Hi Tomi,
On 11/05/2012 07:14 AM, Tomi Valkeinen wrote:
From: Ricardo Neri
Add the pinmux configuration for HDMI and TPD12S015A. Configure the
gpios for the TPD12S015A and SDA, SCL and CEC for HDMI.
Do you plan to upstream the complete DT-boot support for DSS
(specifically, HDMI) for 3.8? I
This function is now used in the driver init path to handle
probe errors properly. Thus, it may be possible to use this function
outside the exit path.
Reported-by: Fengguang Wu
Reported-by: Yuanhan Liu
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi.c |2 +-
1 files changed
Do not blindly assume that the panel could be initialized.
While there, group mutex initialization at a single place.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi.c | 14 +++---
1 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/video/omap2/dss
used by domain-specific drivers; audio in
this case.
Also, this is in line with the DT implementation of HDMI, in which we will
have a single node to describe this feature of the OMAP SoC.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi.c | 62
The display must be uninitialized in order to free the requested GPIOs.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c
index 696386c..4adf830
Do not assume blindly that the DSS driver was registered successfully.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi_panel.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/video/omap2/dss/hdmi_panel.c
b/drivers/video/omap2/dss/hdmi_panel.c
It could be possible that the DMA port differs accross diferent HDMI IPs. Thus,
add an IP-specific function to obtain the address offset and size of the DMA
data port.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/dss_features.c|1 +
drivers/video/omap2/dss/ti_hdmi.h
Using devm_request_and_ioremap provides better memory handling and
improves readability.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c
,
Ricardo
Ricardo Neri (7):
OMAPDSS: HDMI: Rename resource variable at probe.
OMAPDSS: HDMI: Convert to devm_request_and_ioremap
OMAPDSS: HDMI: Make panel return dssdev register errors
OMAPDSS: HDMI: Handle panel init error at probe
OMAPDSS: HDMI: Uninit display on device add error
OMAPDSS
Minor cleanup to give to the resource variable a more proper name.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi.c |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c
index adcc906
Hi Tomi,
Thanks for reviewing.
On 11/05/2012 02:46 AM, Tomi Valkeinen wrote:
On 2012-11-03 02:31, Ricardo Neri wrote:
Creating the accessory devices, such as audio, from the HDMI driver
allows to regard HDMI as a single entity with audio an display
functionality. This intends to follow the
Hi Tomi,
On 11/05/2012 07:17 AM, Tomi Valkeinen wrote:
Hi Ricardo,
On 2012-11-05 15:14, Tomi Valkeinen wrote:
From: Ricardo Neri
Add the pinmux configuration for HDMI and TPD12S015A. Configure the
gpios for the TPD12S015A and SDA, SCL and CEC for HDMI.
Signed-off-by: Ricardo Neri
Signed
It could be possible that the DMA port differs accross diferent HDMI IPs. Thus,
add an IP-specific function to obtain the address offset and size of the DMA
data port.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/dss_features.c|1 +
drivers/video/omap2/dss/ti_hdmi.h
Do not blindly assume that the panel could be initialized.
While there, group mutex initialization at a single place.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi.c | 14 +++---
1 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/video/omap2/dss
Do not assume blindly that the DSS driver was registered successfully.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi_panel.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/video/omap2/dss/hdmi_panel.c
b/drivers/video/omap2/dss/hdmi_panel.c
The display must be uninitialized in order to free the requested GPIOs.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c
index 696386c..4adf830
used by domain-specific drivers; audio in
this case.
Also, this is in line with the DT implementation of HDMI, in which we will
have a single node to describe this feature of the OMAP SoC.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi.c | 62
Using devm_request_and_ioremap provides better memory handling and
improves readability.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c
.
*Obtain the DMA port address offset and size from the HDMI IP-specific library.
v1 is accessible here:
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg77861.html
BR,
Ricardo
Ricardo Neri (7):
OMAPDSS: HDMI: Rename resource variable at probe.
OMAPDSS: HDMI: Convert to
Minor cleanup to give to the resource variable a more proper name.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi.c |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c
index adcc906
On 10/25/2012 09:54 AM, Tomi Valkeinen wrote:
On 2012-10-25 17:31, Ricardo Neri wrote:
On 10/23/2012 11:29 PM, Tomi Valkeinen wrote:
On 2012-10-23 20:21, Ricardo Neri wrote:
If so, you could pass only that one address, instead of the whole HDMI
register space?
Yes, that could work. I
On 10/23/2012 11:29 PM, Tomi Valkeinen wrote:
On 2012-10-23 20:21, Ricardo Neri wrote:
If so, you could pass only that one address, instead of the whole HDMI
register space?
Yes, that could work. I thought about that but the common HDMI driver
would have to know the the IP-specific register
On 10/23/2012 11:17 AM, Tomi Valkeinen wrote:
On 2012-10-23 18:42, Ricardo Neri wrote:
What registers does the audio side need to access?
It only needs access to the DMA audio data port. All other operations
that the audio driver needs are done through the omapdss audio interface.
Hmm
On 10/23/2012 04:37 AM, Tomi Valkeinen wrote:
On 2012-10-23 03:48, Ricardo Neri wrote:
+#if defined(CONFIG_OMAP4_DSS_HDMI_AUDIO)
+#define HDMI_AUDIO_MEM_RESOURCE 0
+#define HDMI_AUDIO_DMA_RESOURCE 1
I don't see much point with these definitions. They are hdmi.c internal,
so the
Hi Tomi,
Thanks for reviewing!
On 10/22/2012 02:40 AM, Tomi Valkeinen wrote:
On 2012-10-16 04:27, Ricardo Neri wrote:
Creating the accessory devices, such as audio, from the HDMI driver
allows to regard HDMI as a single entity with audio an display
functionality. This intends to follow the
Hi Tomi,
On 10/22/2012 02:22 AM, Tomi Valkeinen wrote:
On 2012-10-16 04:27, Ricardo Neri wrote:
Using devm_ioremap provides better memory handling and improves
readability.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi.c | 11 +++
1 files changed, 7 insertions
Hi Peter,
Thanks for reviewing!
On 10/16/2012 04:30 AM, Péter Ujfalusi wrote:
On 10/16/2012 03:27 AM, Ricardo Neri wrote:
Creating the accessory devices, such as audio, from the HDMI driver
allows to regard HDMI as a single entity with audio an display
functionality. This intends to follow
The display must be uninit'ed in order to free the requested GPIOs.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c
index 6773e2c..be
Do not assume blindly that the DSS driver was registered successfully.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi_panel.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/video/omap2/dss/hdmi_panel.c
b/drivers/video/omap2/dss/hdmi_panel.c
used by domain-specific drivers; audio in
this case.
Also, this is in line with the DT implementation of HDMI, in which we will
have a single node to describe this feature of the OMAP SoC.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi.c | 68
Using devm_ioremap provides better memory handling and improves
readability.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi.c | 11 +++
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c
index
Do not blindly assume that the panel could be init'ed.
While there, put mutex initialization in the same place.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi.c | 14 +++---
1 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/video/omap2/dss/hdm
audio, I also did minor cleanup to the
OMAPDSS HDMI driver probe.
BR,
Ricardo
Ricardo Neri (6):
OMAPDSS: HDMI: Rename resource variable at probe.
OMAPDSS: Convert to devm_ioremap
OMAPDSS: HDMI: Make panel return error if cannot register driver
OMAPDSS: HDMI: Uninit display if unable to
Minor cleanup to give to the resource variable a more proper name.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi.c |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c
index a48a7dd
Hi Benoit,
Thanks for reviewing!
On 10/11/2012 05:29 AM, Benoit Cousson wrote:
Hi Ricardo,
On 10/09/2012 04:15 PM, Ricardo Neri wrote:
Hi Benoit,
Have you had a chance to look at this patch? Maybe you want me to submit
it differently or to a different list?
Sorry, I missed it. It looks
Hi Benoit,
Have you had a chance to look at this patch? Maybe you want me to submit
it differently or to a different list?
Thanks!
Ricardo
On 09/27/2012 11:33 AM, Ricardo Neri wrote:
McASP has a configuration port and a data port. This patch adds the address
space entry for the data port
McASP has a configuration port and a data port. This patch adds the address
space entry for the data port as described in the OMAP4 TRM.
Also, add names to the address spaces.
Signed-off-by: Ricardo Neri
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c |6 ++
1 files changed, 6
k's branch and
this causes a build break with omap2plus_defconfig. Not sure if this is
expected, Most likely not.
Tested-by: Ricardo Neri
Ricardo
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
Mor
Hi Takashi,
On 08/22/2012 02:55 AM, Takashi Iwai wrote:
At Tue, 21 Aug 2012 19:58:02 -0500,
Ricardo Neri wrote:
On 08/21/2012 07:39 AM, Clark, Rob wrote:
On Tue, Aug 21, 2012 at 1:01 AM, Tomi Valkeinen wrote:
On Mon, 2012-08-20 at 20:47 -0500, Ricardo Neri wrote:
Hello!
I have been
On 08/21/2012 08:16 AM, Mark Brown wrote:
On Tue, Aug 21, 2012 at 02:30:51PM +0200, David Henningsson wrote:
On 08/21/2012 02:05 PM, Mark Brown wrote:
- sound/core/ctljack.c which was added later and provides separate
in-kernel and userspace APIs and is currently only used by HDA.
On 08/21/2012 07:39 AM, Clark, Rob wrote:
On Tue, Aug 21, 2012 at 1:01 AM, Tomi Valkeinen wrote:
On Mon, 2012-08-20 at 20:47 -0500, Ricardo Neri wrote:
Hello!
I have been working on prototypes for the ASoC OMAP HDMI audio driver to
propagate events from the HDMI output (e.g., display
Hello!
I have been working on prototypes for the ASoC OMAP HDMI audio driver to
propagate events from the HDMI output (e.g., display getting
enabled/disabled/suspended). This for the users of the driver to react
to such events. For instance, if the display is disabled or disconected,
audio co
Hi Peter,
On 08/09/2012 02:05 AM, Peter Ujfalusi wrote:
Hi Ricardo,
On 08/09/2012 01:12 AM, Ricardo Neri wrote:
Is this another case in which it is required to change the idle-mode on a
per-use-case basis? In the past I was trying to do the same with HDMI [1]. In
that case it was decided to
On 08/08/2012 04:11 AM, Peter Ujfalusi wrote:
Instead of the callback (which modifies control module register) use the
McBSP module's SYSCONFIG register to disable smart-idle mode when the
sidetone is enabled.
Store the original SIDLEMODE configuration and restore it when the sidetone
has been di
-off-by: Ricardo Neri
---
v4: add WARN_ONs to signal invalid selections.
v3: instead of BUG_ON calls, select only if both VENC and HDMI are available.
v2: use BUG_ON() to simplify handling of invalid cases.
drivers/video/omap2/dss/dss.c | 16 ++--
1 files changed, 14 insertions(+), 2
On 08/01/2012 01:28 AM, Tomi Valkeinen wrote:
On Tue, 2012-07-31 at 18:56 -0500, Ricardo Neri wrote:
DSS code wrongly assumes that VENC is always available as source for the
external
sync signal for the display controller DIGIT channel. One cannot blindly
write/read
the value of DSS_CONTROL
On 07/31/2012 06:52 PM, Ricardo Neri wrote:
From 8b0f9153d078b7182efd604ef8525d50899ce1a3 Mon Sep 17 00:00:00 2001
From: Ricardo Neri
Date: Mon, 30 Jul 2012 17:54:59 -0500
Subject: [PATCH v3] OMAPDSS: DISPC: Improvements to DIGIT sync signal selection
A small issue while sending the patch. I
-off-by: Ricardo Neri
---
v3: instead of BUG_ON calls, select only if both VENC and HDMI are available.
v2: use BUG_ON() to simplify handling of invalid cases.
drivers/video/omap2/dss/dss.c | 12 ++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/video/omap2/dss
>From 8b0f9153d078b7182efd604ef8525d50899ce1a3 Mon Sep 17 00:00:00 2001
From: Ricardo Neri
Date: Mon, 30 Jul 2012 17:54:59 -0500
Subject: [PATCH v3] OMAPDSS: DISPC: Improvements to DIGIT sync signal selection
DSS code wrongly assumes that VENC is always available as source for the
external
s
On 07/31/2012 12:46 AM, Tomi Valkeinen wrote:
On Mon, 2012-07-30 at 19:11 -0500, Ricardo Neri wrote:
DSS code wrongly assumes that VENC is always available as source for the
external
sync signal for the display controller DIGIT channel. One cannot blindly
rely only on the value of DSS_CONTROL
Small patch to disable the PLL appropriately before runtime_put in case
an error occurs while enabling the PHY.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers
selected.
Signed-off-by: Ricardo Neri
---
v2: use BUG_ON() to simplify handling of invalid cases.
drivers/video/omap2/dss/dss.c | 13 +++--
1 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/video/omap2/dss/dss.c b/drivers/video/omap2/dss/dss.c
index 04b4586..2f8e4b6
Hi Tomi, Archit,
Thanks for your feedback.
On 07/30/2012 06:48 AM, Archit Taneja wrote:
On Monday 30 July 2012 04:41 PM, Tomi Valkeinen wrote:
On Fri, 2012-07-27 at 19:21 -0500, Ricardo Neri wrote:
Hello,
DSS code wrongly assumes that VENC is always available as source for
the external
sync
Handle the errors that may occur when selecting the source of the
sync signal for the DIGIT channel of the display controller and
when enabling the PHY.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/hdmi.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git
/setting
the source.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/dss.c | 19 +--
drivers/video/omap2/dss/dss.h |2 +-
2 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/drivers/video/omap2/dss/dss.c b/drivers/video/omap2/dss/dss.c
index 04b4586..e399b4f
correctly set/get the sync signal based on the
available displays in the DIGIT channel.
For the HDMI driver, handle the error in the selection of the source.
BR,
Ricardo
Ricardo Neri (2):
OMAPDSS: DISPC: Improve logic of selection of external sync signal
OMAPDSS:HDMI: Improve error handling at
wrapper audio FIFO. If no-idle mode is not used, audio could
be choppy, have bad quality or not be audible at all.
Signed-off-by: Ricardo Neri
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2
On 06/18/2012 04:22 PM, Paul Walmsley wrote:
Hi
On Sat, 16 Jun 2012, Ricardo Neri wrote:
I would like to revive an old discussion regarding how to use a particular
idle mode for a specific use-case[1].
As per the OMAP4 documentation, audio over HDMI should be transmitted in
no-idle mode
e.com/linux-omap@vger.kernel.org/msg60226.html
[2].http://www.mail-archive.com/linux-omap@vger.kernel.org/msg60236.html
[3].http://www.mail-archive.com/linux-omap@vger.kernel.org/msg60316.html
[4].http://www.mail-archive.com/linux-omap@vger.kernel.org/msg60252.html
Signed-off-by: Ricardo Neri
---
Hi Xiao,
On 06/04/2012 11:15 PM, Xiao Jiang wrote:
Ricardo Neri wrote:
Hi Xiao, Tomi, Jarkko,
On 05/30/2012 11:27 PM, Xiao Jiang wrote:
Ricardo Neri wrote:
+Tomi
Hi Xiao,
On 05/30/2012 02:14 AM, Xiao Jiang wrote:
Hello,
After enable SND_OMAP_SOC_OMAP_HDMI with omap2plus_defconfig, I got
Hi Xiao, Tomi, Jarkko,
On 05/30/2012 11:27 PM, Xiao Jiang wrote:
Ricardo Neri wrote:
+Tomi
Hi Xiao,
On 05/30/2012 02:14 AM, Xiao Jiang wrote:
Hello,
After enable SND_OMAP_SOC_OMAP_HDMI with omap2plus_defconfig, I got some
err infos with latest
Linus's tree, does somebody also has the
+Tomi
Hi Xiao,
On 05/30/2012 02:14 AM, Xiao Jiang wrote:
Hello,
After enable SND_OMAP_SOC_OMAP_HDMI with omap2plus_defconfig, I got some
err infos with latest
Linus's tree, does somebody also has the same issue?
sound/soc/omap/omap-hdmi.c:45:24: error: field 'dss_audio' has
incomplete type
so
fail.
Also, while there, I removed the IRQF_DISABLED flag as it is now deprecated.
If you are OK with the change, I hope it could be merged for K3.5 otherwise
HDMI will fail.
[1].http://www.spinics.net/lists/linux-tip-commits/msg14974.html
Ricardo Neri (1):
OMAPDSS: HDMI: OMAP4: Update IRQ
IRQF_ONESHOT.
Also, remove the IRQF_DISABLED as the flag is now a NOOP and has been
deprecated.
Signed-off-by: Ricardo Neri
---
drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c
b/drivers
On 05/18/2012 11:32 AM, Mark Brown wrote:
On Fri, May 18, 2012 at 01:42:33AM -0500, Ricardo Neri wrote:
Introduce codec for HDMI. At the moment, this is a dummy codec. In the
future it will parse the EDID to modify the supported parameters, such
as the number of channels and the sample rates
1 - 100 of 202 matches
Mail list logo