Re: [PATCH 2/2] ARM: dts: doc: Document missing binding for ti-sdma controller

2013-11-11 Thread Rob Herring
On Sat, Nov 9, 2013 at 5:53 AM, Sricharan R wrote: > Hi Rob, > > On Saturday 09 November 2013 03:24 AM, Rob Herring wrote: >> On Fri, Nov 8, 2013 at 4:38 AM, Sricharan R wrote: >>> The binding and support for system DMA module present in OMAP2+ Socs >>> an

Re: [PATCH 2/2] ARM: dts: doc: Document missing binding for ti-sdma controller

2013-11-08 Thread Rob Herring
On Fri, Nov 8, 2013 at 4:38 AM, Sricharan R wrote: > The binding and support for system DMA module present in OMAP2+ Socs > and DRA7 with dma-engine is already present. So adding the missing > documentation for the same. > > Cc: Benoit Cousson > Signed-off-by: Sricharan R > --- > Documentation/

Re: [RFC PATCH v2] ARM: OMAP4/highbank: Flush L2 cache before disabling

2013-10-04 Thread Rob Herring
ore outer_disable(). > > Signed-off-by: Taras Kondratiuk Acked-by: Rob Herring > --- > v2: Make the fix specific to platforms that don't use l2x0_disable(). > v1: https://patchwork.kernel.org/patch/2974431/ > --- > Cc: Will Deacon > Cc: Russell King > Cc

Re: [RFC 00/15] Device Tree schemas and validation

2013-10-01 Thread Rob Herring
On Tue, Oct 1, 2013 at 10:06 AM, Benoit Cousson wrote: > Hi Rob, > > > On 01/10/2013 15:17, Rob Herring wrote: >> >> On 10/01/2013 03:06 AM, Benoit Cousson wrote: >>> >>> + more DT maintainers folks >>> >>> Hi all, >>> &g

Re: [RFC PATCH 0/6] DRIVERS: IRQCHIP: Add support for crossbar IP

2013-10-01 Thread Rob Herring
On 10/01/2013 08:57 AM, Santosh Shilimkar wrote: > On Tuesday 01 October 2013 09:48 AM, Rob Herring wrote: >> On 10/01/2013 06:13 AM, Sricharan R wrote: >>> Hi, >>> >>> On Monday 30 September 2013 08:39 PM, Rob Herring wrote: >>>> On 09/30/2013 08:

Re: [RFC PATCH 0/6] DRIVERS: IRQCHIP: Add support for crossbar IP

2013-10-01 Thread Rob Herring
On 10/01/2013 06:13 AM, Sricharan R wrote: > Hi, > > On Monday 30 September 2013 08:39 PM, Rob Herring wrote: >> On 09/30/2013 08:59 AM, Sricharan R wrote: >>> Some socs have a large number of interrupts requests to service >>> the needs of its many perip

Re: [RFC 00/15] Device Tree schemas and validation

2013-10-01 Thread Rob Herring
On 10/01/2013 03:06 AM, Benoit Cousson wrote: > + more DT maintainers folks > > Hi all, > > I know this is mostly boring user space code, but I was expecting a > little bit of comments about at least the bindings syntax:-( > > I'd like to know if this is the right direction and if it worth pursu

Re: [RFC PATCH 0/6] DRIVERS: IRQCHIP: Add support for crossbar IP

2013-09-30 Thread Rob Herring
On 09/30/2013 08:59 AM, Sricharan R wrote: > Some socs have a large number of interrupts requests to service > the needs of its many peripherals and subsystems. All of the interrupt > requests lines from the subsystems are not needed at the same > time, so they have to be muxed to the controllers a

Re: [PATCH v6 1/4] ARM: OMAP2+: cleaned-up DT support of various ECC schemes

2013-09-25 Thread Rob Herring
On Thu, Sep 12, 2013 at 6:50 AM, Pekon Gupta wrote: > OMAP NAND driver support multiple ECC scheme, which can used in following > different flavours, depending on in-build Hardware engines supported by SoC. > > +---+---+---+ > | ECC schem

Re: [PATCH RESEND] i2c: move of helpers into the core

2013-08-19 Thread Rob Herring
nodes in the core instead of doing this manually > in each driver. So, fix the drivers and documentation, too. > > Signed-off-by: Wolfram Sang > --- Glad to see this. Acked-by: Rob Herring > > Sigh, hitting the CC threshold on vger again. So resending to the lists only. >

Re: [PATCH] of: provide of_platform_unpopulate()

2013-07-31 Thread Rob Herring
On 07/29/2013 04:33 AM, Benjamin Herrenschmidt wrote: > On Mon, 2013-07-22 at 00:44 +0100, Grant Likely wrote: >>> BTW, it looks like Grant has attempted this already: >> >> Yup, things broke badly. Unfortunately the of_platform_device and >> platform_device history doesn't treat resources in the s

Re: [PATCH] of: provide of_platform_unpopulate()

2013-07-22 Thread Rob Herring
On 07/21/2013 06:44 PM, Grant Likely wrote: > On Sun, Jul 21, 2013 at 9:48 PM, Rob Herring wrote: >> On 07/21/2013 09:42 AM, Rob Herring wrote: >>> On 07/19/2013 01:14 PM, Sebastian Andrzej Siewior wrote: >>>> So I called of_platform_populate() on a device to get eac

Re: [PATCH] of: provide of_platform_unpopulate()

2013-07-21 Thread Rob Herring
On 07/21/2013 09:42 AM, Rob Herring wrote: > On 07/19/2013 01:14 PM, Sebastian Andrzej Siewior wrote: >> So I called of_platform_populate() on a device to get each child device >> probed and on rmmod and I need to reverse its doing. After a quick grep >> I did what others

Re: [PATCH] of: provide of_platform_unpopulate()

2013-07-21 Thread Rob Herring
On 07/19/2013 01:14 PM, Sebastian Andrzej Siewior wrote: > So I called of_platform_populate() on a device to get each child device > probed and on rmmod and I need to reverse its doing. After a quick grep > I did what others did as well and rmmod ended in: > > | Unable to handle kernel NULL pointe

Re: [PATCH] ARM: omap2: remove CONFIG_ARCH_OMAP2PLUS_TYPICAL

2013-05-16 Thread Rob Herring
On Thu, May 16, 2013 at 10:11 AM, Tony Lindgren wrote: > * Rob Herring [130516 06:34]: >> From: Rob Herring >> >> CONFIG_ARCH_OMAP2PLUS_TYPICAL is selecting user defined features, not h/w >> required options. This does not play well with multi-platform kernels an

[PATCH] ARM: omap2: remove CONFIG_ARCH_OMAP2PLUS_TYPICAL

2013-05-16 Thread Rob Herring
From: Rob Herring CONFIG_ARCH_OMAP2PLUS_TYPICAL is selecting user defined features, not h/w required options. This does not play well with multi-platform kernels and belongs in a defconfig. Signed-off-by: Rob Herring Cc: Tony Lindgren Cc: linux-omap@vger.kernel.org --- arch/arm/mach-omap2

Re: [PATCH] USB: set device dma_mask without reference to global data

2013-05-08 Thread Rob Herring
ck for DTs that were created before any such property was defined. > It seems there has already been a patch to implement this. For > reference, this seems to be the most recent version: > > https://lkml.org/lkml/2012/12/4/54 > > And here's the previous attempt, to which Ro

Re: [PATCH v2 02/13] ARM: convert arm/arm64 arch timer to use CLKSRC_OF init

2013-04-10 Thread Rob Herring
On 04/04/2013 12:56 AM, Simon Horman wrote: > On Mon, Apr 01, 2013 at 05:21:12PM -0500, Rob Herring wrote: >> From: Rob Herring >> >> This converts arm and arm64 to use CLKSRC_OF DT based initialization for >> the arch timer. A new function arch_timer_arch_init is

Re: [PATCH 1/1] of/irq: store IRQ trigger/level in struct resource flags

2013-04-08 Thread Rob Herring
On 04/08/2013 05:56 PM, Javier Martinez Canillas wrote: > On 04/09/2013 12:16 AM, Stephen Warren wrote: >> On 04/08/2013 04:05 PM, Rob Herring wrote: >>> On 04/05/2013 02:48 AM, Javier Martinez Canillas wrote: >>>> According to >>>> Documentatio

Re: [PATCH 1/1] of/irq: store IRQ trigger/level in struct resource flags

2013-04-08 Thread Rob Herring
On 04/05/2013 02:48 AM, Javier Martinez Canillas wrote: > According to > Documentation/devicetree/bindings/interrupt-controller/interrupts.txt > the "#interrupt-cells" property of an "interrupt-controller" is used > to define the number of cells needed to specify a single interrupt. > > A commonl

[PATCH v2 02/13] ARM: convert arm/arm64 arch timer to use CLKSRC_OF init

2013-04-01 Thread Rob Herring
From: Rob Herring This converts arm and arm64 to use CLKSRC_OF DT based initialization for the arch timer. A new function arch_timer_arch_init is added to allow for arch specific setup. This has a side effect of enabling sched_clock on omap5 and exynos5. There should not be any reason not to

Re: [PATCH] ARM: convert arm/arm64 arch timer to use CLKSRC_OF init

2013-03-25 Thread Rob Herring
On 03/25/2013 05:53 PM, John Stultz wrote: > On 03/25/2013 03:36 PM, Arnd Bergmann wrote: >> On Monday 25 March 2013, Rob Herring wrote: >>> I count integrator-cp, realview, versatile and non-DT VExpress that do >>> this (not surprisingly) and 25 platforms or timer imp

Re: [PATCH] ARM: convert arm/arm64 arch timer to use CLKSRC_OF init

2013-03-25 Thread Rob Herring
On 03/25/2013 12:26 PM, Russell King - ARM Linux wrote: > On Thu, Mar 21, 2013 at 11:06:47AM +, Mark Rutland wrote: >> On TC2 this series leads to using the vexpress 24MHz clock as the sched clock >> in preference to the architected timer: >> >> Architected local timer running at 24.00MHz (vi

Re: [PATCH] ARM: convert arm/arm64 arch timer to use CLKSRC_OF init

2013-03-21 Thread Rob Herring
On 03/21/2013 06:06 AM, Mark Rutland wrote: > Hi Rob, > > (adding Marc to Cc as he may have comments). > > On Wed, Mar 20, 2013 at 10:34:35PM +0000, Rob Herring wrote: >> From: Rob Herring >> >> This converts arm and arm64 to use CLKSRC_OF DT based initializa

[PATCH] ARM: convert arm/arm64 arch timer to use CLKSRC_OF init

2013-03-20 Thread Rob Herring
From: Rob Herring This converts arm and arm64 to use CLKSRC_OF DT based initialization for the arch timer. A new function arch_timer_arch_init is added to allow for arch specific setup. This has a side effect of enabling sched_clock on omap5 and exynos5. There should not be any reason not to

Re: [PATCH V3 12/18] ARM: OMAP2+: Add additional GPMC timing parameters

2013-03-18 Thread Rob Herring
On 03/15/2013 10:21 AM, Jon Hunter wrote: > Some of the GPMC timings parameters are currently missing from the GPMC > device-tree binding. Add these parameters to the binding documentation > as well as code to read them. > > The existing code in gpmc_read_timings_dt() is checking the value of > of

Re: [U-Boot] [RFC] Kbuild support for ARM FIT images

2013-02-21 Thread Rob Herring
On 02/21/2013 08:22 PM, Jason Gunthorpe wrote: > On Thu, Feb 21, 2013 at 06:19:05PM -0600, Rob Herring wrote: > >> The desired FPGA use case is DT updates after booting the kernel. This >> has nothing to do with FIT images. And if the FPGA tools generate the >> DTB, then

Re: [U-Boot] [RFC] Kbuild support for ARM FIT images

2013-02-21 Thread Rob Herring
On 02/21/2013 05:28 PM, Jason Gunthorpe wrote: > On Fri, Feb 22, 2013 at 12:18:48AM +0100, Wolfgang Denk wrote: > >>> The DT is meant to describe hardware. As far as I know, the hardware I >>> own seems to be rather static and stable, and unlike software there is >>> no way I can change it (sol

Re: [RFC 2/8] ARM: twd: register clock event for 1 core SMP

2013-02-18 Thread Rob Herring
On 02/18/2013 12:30 AM, Afzal Mohammed wrote: > Register percpu local timer for scheduler tick in the case of one core > SMP configuration. In other cases - secondary cpu's as well as boot > cpu's having more than one core, this is being registered as per > existing boot flow, with a difference tha

[PATCH] ARM: smp_twd: convert to use CLKSRC_OF init

2013-02-07 Thread Rob Herring
From: Rob Herring Now that we have OF based init with CLKSRC_OF, convert smp_twd init function to use it and covert all callers of twd_local_timer_of_register. Signed-off-by: Rob Herring Cc: Shawn Guo Cc: Sascha Hauer Cc: Russell King Cc: Tony Lindgren Cc: Viresh Kumar Cc: Shiraz Hashim

Re: [PATCH, RFC] default machine descriptor for multiplatform

2013-02-05 Thread Rob Herring
On 01/31/2013 11:51 AM, Arnd Bergmann wrote: > This is what I think it would look like to do a default platform > with an empty machine descriptor on ARM. It makes the few required > entries in the descriptor optional by using the new irqchip_init() > and clocksource_of_init() functions as defaults

Re: [RFC PATCH 0/2] ARM: update cpuinfo to print CPU model name

2013-01-29 Thread Rob Herring
On 01/29/2013 09:54 AM, Ruslan Bilovol wrote: > Hi, > > The following patches update cpuinfo to print CPU > model name for ARM. First patch exactly makes needed > changes for ARM architecture. > Second patch adds this ability to OMAP4 SoCs. > > This adds a common approach to show SoC name. > > L

Re: [RFC 2/5] ARM: dts: Add Cross Trigger Interface binding

2012-12-14 Thread Rob Herring
On 12/12/2012 05:23 PM, Jon Hunter wrote: > > On 12/12/2012 04:12 PM, Rob Herring wrote: >> On 12/12/2012 03:43 PM, Jon Hunter wrote: >>> Adds a device-tree binding for the ARM Cross Trigger Interface (CTI). >>> The ARM Cross Trigger Interface provides a way to rout

Re: [RFC 2/5] ARM: dts: Add Cross Trigger Interface binding

2012-12-12 Thread Rob Herring
On 12/12/2012 03:43 PM, Jon Hunter wrote: > Adds a device-tree binding for the ARM Cross Trigger Interface (CTI). > The ARM Cross Trigger Interface provides a way to route events between > processor modules. For example, on OMAP4430 we use the CTI module to > route PMU events to the GIC interrupt m

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-15 Thread Rob Herring
On 11/15/2012 08:37 AM, Catalin Marinas wrote: > On Thu, Nov 15, 2012 at 02:31:33PM +0000, Rob Herring wrote: >> On 11/15/2012 05:01 AM, Catalin Marinas wrote: >>> On Thu, Nov 15, 2012 at 12:54:48AM +, Rob Herring wrote: >>>> On 11/14/2012 04:21 PM, Tony Lindg

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-15 Thread Rob Herring
On 11/15/2012 05:01 AM, Catalin Marinas wrote: > On Thu, Nov 15, 2012 at 12:54:48AM +0000, Rob Herring wrote: >> On 11/14/2012 04:21 PM, Tony Lindgren wrote: >>> * Rob Herring [121114 13:59]: >>>> On 11/14/2012 02:32 PM, Tony Lindgren wrote: >>>>>

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-14 Thread Rob Herring
On 11/14/2012 04:21 PM, Tony Lindgren wrote: > * Rob Herring [121114 13:59]: >> On 11/14/2012 02:32 PM, Tony Lindgren wrote: >>> >>> Checking for the bit already set should work in this case, I'll post >>> a patch for that shortly. >> >> Can y

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-14 Thread Rob Herring
On 11/14/2012 02:32 PM, Tony Lindgren wrote: > * Russell King - ARM Linux [121114 12:24]: >> On Wed, Nov 14, 2012 at 01:06:53PM -0600, Jon Hunter wrote: >>> >>> On 11/14/2012 12:53 PM, Tony Lindgren wrote: Looks like enabling CONFIG_ARM_ERRATA_751472 causes omap4 blaze to not boot when e

Re: [PATCH 0/3] capebus moving omap_devices to mach-omap2

2012-11-05 Thread Rob Herring
On 11/05/2012 08:34 AM, Grant Likely wrote: > On Mon, Nov 5, 2012 at 1:25 PM, Pantelis Antoniou > wrote: >> >> On Nov 5, 2012, at 1:22 AM, Grant Likely wrote: >> >>> On Fri, Nov 2, 2012 at 8:43 AM, Pantelis Antoniou >>> wrote: Assuming that we do work on a DT object format, and that the runt

Re: [PATCH] arm-dt: Enable DT proc updates.

2012-10-31 Thread Rob Herring
On 10/31/2012 10:57 AM, Pantelis Antoniou wrote: > This simple patch enables dynamic changes of the DT tree on runtime > to be visible to the device-tree proc interface. > > Signed-off-by: Pantelis Antoniou Acked-by: Rob Herring > --- > arch/arm/include/asm/prom.h | 2 ++ &g

Re: [PATCH V4 1/5] ARM: dts: OMAP: Add timer nodes

2012-10-19 Thread Rob Herring
s specific to OMAP. > > Thanks to Vaibhav Hiremath for creating the AM33xx timer nodes. I have > modified > Vaibhav's original nodes adding information on which timers support a PWM > output. > > Cc: Benoit Cousson > Signed-off-by: Jon Hunter > --- The binding looks go

Re: [PATCH 4/4] MMC: omap_hsmmc: add DT property for max bus frequency

2012-10-12 Thread Rob Herring
On 10/12/2012 05:58 AM, Daniel Mack wrote: > Maximum bus frequency can be limited by external circuitry like level > shifters etc. Allow passing this value from DT. > > Signed-off-by: Daniel Mack > Cc: Venkatraman S > Cc: Chris Ball > Cc: Grant Likely > Cc: Rob H

Re: [PATCH 1/5] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-27 Thread Rob Herring
On 09/25/2012 05:06 AM, ABRAHAM, KISHON VIJAY wrote: > Hi, > > On Mon, Sep 24, 2012 at 6:45 PM, Rob Herring wrote: >> On 09/06/2012 09:57 AM, Kishon Vijay Abraham I wrote: >>> All phy related programming like enabling/disabling the clocks, powering >>> on/off

Re: [PATCH V2 7/7] ARM: OMAP: Add DT support for timer driver

2012-09-26 Thread Rob Herring
On 09/26/2012 10:51 AM, Jon Hunter wrote: > Hi Rob, >> #define OMAP3_32K_SOURCE"omap_32k_fck" >> #define OMAP4_32K_SOURCE"sys_32k_ck" >> >> +#define TIMER_PROP_ALWON"ti,timer-alwon" >> + > > I see you made the following comment [1] here ... > > "It would be easier to follow the

Re: [PATCH 1/5] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-24 Thread Rob Herring
On 09/06/2012 09:57 AM, Kishon Vijay Abraham I wrote: > All phy related programming like enabling/disabling the clocks, powering > on/off the phy is taken care of by this driver. It is also used for OTG > related functionality like srp. > > This also includes device tree support for usb2 phy drive

Re: [PATCH V2 7/7] ARM: OMAP: Add DT support for timer driver

2012-09-19 Thread Rob Herring
On 09/13/2012 06:31 PM, Jon Hunter wrote: > In order to add device-tree support to the timer driver the following changes > were made ... > > 1. Allocate system timers (used for clock-events and clock-source) based upon >timer properties rather than using an hard-coded timer instance ID. To

Re: [PATCH V6 1/2] of: Add generic device tree DMA helpers

2012-09-19 Thread Rob Herring
On 09/19/2012 09:24 AM, Arnd Bergmann wrote: > On Wednesday 19 September 2012, Matt Porter wrote: >>> +Optional properties: >>> +- #dma-channels: Number of DMA channels supported by the controller. >>> +- #dma-requests: Number of DMA requests signals supported by the >>> +

Re: [PATCH V6 1/2] of: Add generic device tree DMA helpers

2012-09-19 Thread Rob Herring
moving in the direction of not putting subsystem related code under drivers/of, but rather with the subsystem. Although in some cases (i2c), the maintainers didn't want the OF code there. In any case, I guess this will go thru Vinod's tree, so: Acked-by: Rob Herring -- To unsubscribe from

Re: [RFC RESEND 1/4] arm/dts: OMAP: Add timer nodes

2012-09-06 Thread Rob Herring
On 07/23/2012 10:24 AM, Jon Hunter wrote: > Hi Rob, > > On 07/16/2012 10:56 AM, Jon Hunter wrote: >> Hi Rob, >> >> On 07/13/2012 09:15 PM, Rob Herring wrote: >>> On 07/13/2012 05:26 PM, Jon Hunter wrote: >>>> Add the 12 GP timers nodes present in O

Re: [PATCH 0/9] Clean up hardcoded IRQs for mach-omap2, enable SPARSE_IRQ, plaform_data/gpio-omap.h

2012-08-30 Thread Rob Herring
On 08/30/2012 07:52 PM, Tony Lindgren wrote: > Hi all, > > Here's the first set of omap header clean-up patches needed for single > zImage support. This series is based v3.6-rc3 and the following patches > to avoid merge conflicts with the includes: > > - Arnd's patch "ARM: omap: move platform_da

Re: [PATCH] ARM: AM33XX: board-generic: Add of_dev_auxdata to fix dev_id for CAN module

2012-08-07 Thread Rob Herring
On 08/07/2012 10:53 AM, Hiremath, Vaibhav wrote: > On Tue, Aug 07, 2012 at 20:49:48, Rob Herring wrote: >> On 08/07/2012 08:37 AM, Vaibhav Hiremath wrote: >>> If the module requires only one clocksource to function, then >>> driver can very well call clk_ge

Re: [PATCH] ARM: AM33XX: board-generic: Add of_dev_auxdata to fix dev_id for CAN module

2012-08-07 Thread Rob Herring
On 08/07/2012 08:37 AM, Vaibhav Hiremath wrote: > If the module requires only one clocksource to function, then > driver can very well call clk_get() api with "con_id = NULL", > >clk = clk_get(dev, NULL); > > And platform code should respect this and return valid clk handle. > That means,

Re: [PATCH] clk: fix compile for OF && !COMMON_CLK

2012-07-17 Thread Rob Herring
On 07/17/2012 08:19 AM, Rajendra Nayak wrote: > Rob, Mike, > > On Tuesday 17 July 2012 07:38 AM, Rob Herring wrote: >> On 07/16/2012 07:12 PM, Mike Turquette wrote: >>> On 20120716-16:46, Rob Herring wrote: >>>> From: Rob Herring >>>> >>>&g

Re: [RFC RESEND 1/4] arm/dts: OMAP: Add timer nodes

2012-07-14 Thread Rob Herring
On 07/14/2012 01:56 AM, Paul Walmsley wrote: > Hi > > On Fri, 13 Jul 2012, Rob Herring wrote: > >> I'm not sure this is really a good use of aliases. UARTs use aliases >> because it is important that the UART number to tty number is known and >> fixed.

Re: [RFC RESEND 1/4] arm/dts: OMAP: Add timer nodes

2012-07-13 Thread Rob Herring
On 07/13/2012 05:26 PM, Jon Hunter wrote: > Add the 12 GP timers nodes present in OMAP3. > Add the 11 GP timers nodes present in OMAP4. > > Add documentation for timer properties specific to OMAP. > > For each timer an alias is being added. The purpose for doing this is because > the OMAP dmtimer

Re: [PATCH 1/1] ARM: add PROC_DEVICETREE support in Kconfig

2012-07-06 Thread Rob Herring
On 07/06/2012 05:38 AM, jgq...@gmail.com wrote: > From: Xiao Jiang > > Since more and more arm chips support device tree, it'd be better add > PROC_DEVICETREE > in arch/arm/Kconfig to avoid duplicate code. I think this should remain user choice. If its going to be selected, then you might as we

Re: [RFC] ARM: OMAP: Remove nodes dynamically at runtime

2012-07-01 Thread Rob Herring
On 06/21/2012 06:50 PM, Jon Hunter wrote: > > On 06/21/2012 02:15 PM, Jon Hunter wrote: >> Hi all, >> >> I am in the process of adding a device-tree binding for OMAP timers and >> I have encountered a scenario where ideally it would be useful to remove >> a device-tree node at runtime. >> >> The s

Re: [PATCH] mmc: omap_hsmmc: Get rid of of_have_populated_dt() usage

2012-04-11 Thread Rob Herring
_populated_dt() usage in omap_hsmmc driver and > instead use dev->of_node to make the same dicisions as earlier. > > Signed-off-by: Rajendra Nayak > Reported-by: Benoit Cousson > Cc: Balaji TK > Cc: Rob Herring Ack Rob > Cc: Sebastian Andrzej Siewior > --- > driv

Re: [RFC] dt: export of_have_populated_dt

2012-04-10 Thread Rob Herring
On 04/10/2012 11:29 AM, Cousson, Benoit wrote: > Hi Chris, > > On 4/10/2012 6:21 PM, Chris Ball wrote: >> Hi, >> >> On Tue, Apr 10 2012, Cousson, Benoit wrote: >>> Hi Balaji, >>> >>> On 4/10/2012 5:11 PM, Balaji T K wrote: If of_have_populated_dt is called from module, build fails with "

Re: [PATCH v7 1/3] Documentation: common clk API

2012-03-16 Thread Rob Herring
On 03/16/2012 06:47 PM, Sascha Hauer wrote: > Hi Paul, > > On Fri, Mar 16, 2012 at 04:21:17PM -0600, Paul Walmsley wrote: >> Hi >> >> On Fri, 16 Mar 2012, Arnd Bergmann wrote: >> >> >> If the common clock code is to go upstream now, it should be marked as >> experimental. > > No, please don't do

Re: [PATCH v2 1/4] mmc: omap_hsmmc: Convert hsmmc driver to use device tree

2012-03-08 Thread Rob Herring
tree. > > Any comments on these bindings for omap hsmmc? All the dependent > patches/series on which this series was based have now made it to > the respective -next of Mark and Chris. > Acked-by: Rob Herring > >> >> Signed-off-by: Rajendra Nayak >> ---

Re: [PATCH 7/8] ARM: OMAP: Remove plat/io.h by moving it into mach/io.h

2012-02-29 Thread Rob Herring
On 02/29/2012 09:46 PM, Tony Lindgren wrote: > * Rob Herring [120229 19:02]: >> On 02/29/2012 07:03 PM, Tony Lindgren wrote: >>> >>> Rob, I assume you'll apply this into your branch? >>> >> >> Yes > > OK > >>> --- a/arch

Re: [PATCH 7/8] ARM: OMAP: Remove plat/io.h by moving it into mach/io.h

2012-02-29 Thread Rob Herring
On 02/29/2012 07:03 PM, Tony Lindgren wrote: > * Tony Lindgren [120229 16:08]: >> * Russell King - ARM Linux [120229 15:40]: >>> On Wed, Feb 29, 2012 at 05:59:27PM -0600, Rob Herring wrote: >>>> BTW, all these includes need to get removed. I'll add a fix to my

Re: [PATCH 7/8] ARM: OMAP: Remove plat/io.h by moving it into mach/io.h

2012-02-29 Thread Rob Herring
On 02/28/2012 07:47 PM, Tony Lindgren wrote: > * Rob Herring [120226 19:15]: >> On 02/24/2012 12:22 PM, Tony Lindgren wrote: >>> * Tony Lindgren [120223 15:36]: >>>> * Rob Herring [120221 17:53]: >>>>> On 02/21/2012 05:40 PM, Tony Lindgren wrote: &g

Re: [PATCH 7/8] ARM: OMAP: Remove plat/io.h by moving it into mach/io.h

2012-02-26 Thread Rob Herring
On 02/24/2012 12:22 PM, Tony Lindgren wrote: > * Tony Lindgren [120223 15:36]: >> * Rob Herring [120221 17:53]: >>> On 02/21/2012 05:40 PM, Tony Lindgren wrote: >>>> + >>>> +/* >>>> + * NOTE: Please use ioremap +

Re: [RFC PATCH] gpio/omap: Fix IRQ handling for SPARSE_IRQ

2012-02-24 Thread Rob Herring
On 02/23/2012 04:46 PM, Cousson, Benoit wrote: > The GPIO driver is still relying on internal OMAP IRQ defines that > are not relevant anymore if OMAP is built with SPARSE_IRQ. > > Replace the defines with the proper IRQ base number. > Clean some comment style issue. > Remove some hidden and ugly

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2012-02-22 Thread Rob Herring
On 02/22/2012 08:31 AM, Cousson, Benoit wrote: > On 2/22/2012 3:23 PM, Rob Herring wrote: >> On 02/15/2012 10:04 AM, Benoit Cousson wrote: >>> Adapt the GPIO driver to retrieve information from a DT file. >>> >>> Allocate the irq_base dynamically and rename

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2012-02-22 Thread Rob Herring
cs > output. > > Add documentation for GPIO properties specific to OMAP. > > Signed-off-by: Benoit Cousson > Cc: Tarun Kanti DebBarma One comment below, but otherwise: Acked-by: Rob Herring > --- > .../devicetree/bindings/gpio/gpio-omap.txt

Re: [PATCH 7/8] ARM: OMAP: Remove plat/io.h by moving it into mach/io.h

2012-02-21 Thread Rob Herring
On 02/21/2012 05:40 PM, Tony Lindgren wrote: > This is needed so we can eventually remove mach/io.h > for omap2+. > > Signed-off-by: Tony Lindgren > --- > arch/arm/mach-omap1/include/mach/io.h | 78 ++- > arch/arm/mach-omap2/common.h | 10 > arch/arm

Re: [PATCH 1/4] spi/omap: Add DT support to McSPI driver

2012-02-15 Thread Rob Herring
gt; + > + > +Example: > + > +mcspi1: mcspi@1 { I don't recall if there's a generic name defined but just "spi" would probably be better. Also, shouldn't this be the base address? Otherwise, for the series: Acked-by: Rob Herring > +#address-cells = <1

Re: [PATCH v3 2/4] ARM: OMAP2/3: intc: Add DT support for TI interrupt controller

2012-02-14 Thread Rob Herring
t; Signed-off-by: Benoit Cousson > Cc: Tony Lindgren > Cc: Rob Herring > Cc: Grant Likely Given that you plan to do gen irqchip: Acked-by: Rob Herring Rob > --- > .../devicetree/bindings/arm/omap/intc.txt | 27 + > arch/arm/mach-omap2/common.h

Re: [PATCH 3/3] ARM: OMAP: I2C: fix compilation when !CONFIG_OF

2012-01-22 Thread Rob Herring
On 01/22/2012 09:45 AM, Grant Likely wrote: > On Sun, Jan 22, 2012 at 04:02:33AM -0700, Paul Walmsley wrote: >> Commit 6145197be6cc0583fa1a2f4ec1079d366137061e ("i2c: OMAP: Add DT >> support for i2c controller") breaks compilation when CONFIG_OF is not >> defined: >> >> CC drivers/i2c/busses

Re: [PATCH 3/3] ARM: OMAP: I2C: fix compilation when !CONFIG_OF

2012-01-22 Thread Rob Herring
t appears in > > Fix this by avoiding of_*() functions when !CONFIG_OF. > > Signed-off-by: Paul Walmsley > Cc: Benoit Cousson > Cc: Rob Herring > Cc: Grant Likely > Cc: Kevin Hilman > Cc: Tony Lindgren > --- > drivers/i2c/busses/i2c-omap.c |4 +++- > 1

Re: [PATCH 02/31] ARM: amba: of: convert to use amba_device_alloc

2012-01-20 Thread Rob Herring
On 01/20/2012 03:23 AM, Russell King - ARM Linux wrote: > Convert DT code to use the new amba_device_alloc APIs. > > Signed-off-by: Russell King Acked-by: Rob Herring > --- > drivers/of/platform.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > >

Re: [PATCH v4 3/6] clk: introduce the common clock framework

2012-01-12 Thread Rob Herring
On 01/12/2012 06:04 PM, Saravana Kannan wrote: > On 01/04/2012 08:07 PM, Turquette, Mike wrote: >> On Wed, Jan 4, 2012 at 6:11 PM, Rob Herring >> wrote: >>> On 01/04/2012 07:01 PM, Turquette, Mike wrote: >>>> On Wed, Jan 4, 2012 at 6:32 AM, Rob Herring >

Re: [PATCH v2 1/5] arm/dts: OMAP4: Update DTS file with new GIC bindings

2012-01-06 Thread Rob Herring
l GIC > > Hmmm... it shouldn't be. If it is then it is a bug. > I think this is an old comment which I fixed in 3.2, so interrupt-parent can be removed. Rob > g. > >> >> Signed-off-by: Benoit Cousson >> Cc: Rob Herring >> --- >> arch/arm

Re: [PATCH v2 0/5] ARM: OMAP2+: Interrupt controllers adaptation to DT

2012-01-06 Thread Rob Herring
On 01/06/2012 10:38 AM, Cousson, Benoit wrote: > Hi Rob/Grant, > > Gentle ping on that series too. This should the last one:-) > Sorry about that. For the series: Acked-by: Rob Herring Rob > Thanks, > Benoit > > On 12/23/2011 10:46 AM, Cousson, Benoit wrote: >>

Re: [PATCH v4 3/6] clk: introduce the common clock framework

2012-01-04 Thread Rob Herring
On 01/04/2012 07:01 PM, Turquette, Mike wrote: > On Wed, Jan 4, 2012 at 6:32 AM, Rob Herring wrote: >> On 01/03/2012 08:15 PM, Richard Zhao wrote: >>> On Fri, Dec 16, 2011 at 04:45:48PM -0800, Turquette, Mike wrote: >>>> On Wed, Dec 14, 2011 at 5:18 AM, Thomas Gleix

Re: [PATCH v4 3/6] clk: introduce the common clock framework

2012-01-04 Thread Rob Herring
On 01/03/2012 08:15 PM, Richard Zhao wrote: > On Fri, Dec 16, 2011 at 04:45:48PM -0800, Turquette, Mike wrote: >> On Wed, Dec 14, 2011 at 5:18 AM, Thomas Gleixner wrote: >>> On Tue, 13 Dec 2011, Mike Turquette wrote: snip +/** + * clk_init - initialize the data structures in a struct c

Re: [PATCH v3 00/11] OMAP4: Add DT support for i2c and twl6030

2011-12-22 Thread Rob Herring
usses/i2c-omap.c | 101 > +--- > drivers/rtc/rtc-twl.c | 10 ++- > 13 files changed, 334 insertions(+), 83 deletions(-) > create mode 100644 Documentation/devicetree/bindings/i2c/omap-i2c.txt > create mode 100

Re: [PATCH v3 07/11] arm/dts: twl4030: Add DTS file for twl4030 PM + Audio IC

2011-12-20 Thread Rob Herring
On 12/20/2011 10:47 AM, Rob Herring wrote: > On 12/20/2011 10:27 AM, Benoit Cousson wrote: >> Add a dedicated DTS file for the twl4030/5030 Power + Audio IC. >> This chip is a big SoC that will be reused in a lot of various >> OMAP3 boards. >> >> Signed-off

Re: [PATCH v3 07/11] arm/dts: twl4030: Add DTS file for twl4030 PM + Audio IC

2011-12-20 Thread Rob Herring
On 12/20/2011 10:27 AM, Benoit Cousson wrote: > Add a dedicated DTS file for the twl4030/5030 Power + Audio IC. > This chip is a big SoC that will be reused in a lot of various > OMAP3 boards. > > Signed-off-by: Benoit Cousson > Cc: Grant Likely > Cc: Rob Herring >

Re: [PATCH v3 02/11] i2c: OMAP: Add DT support for i2c controller

2011-12-20 Thread Rob Herring
> > Signed-off-by: Benoit Cousson > Cc: Ben Dooks > Cc: Kevin Hilman One issue below, otherwise: Reviewed-by: Rob Herring > @@ -1001,15 +1019,24 @@ omap_i2c_probe(struct platform_device *pdev) > goto err_release_region; > } > > - if (p

Re: [RFC v2 PATCH 0/3] dt: device tree bindings and data for EMIF and DDR

2011-12-19 Thread Rob Herring
On 12/19/2011 08:05 AM, Aneesh V wrote: > This is an RFC to add new device tree bindings for DDR memories and > EMIF - TI's DDR SDRAM controller. > > The first patch adds bindings for DDR memories. Currently, > we have added properties for only DDR3 and LPDDR2 memories. > However, the binding can

Re: [PATCH 1/3] of/base: Take NULL string into account for property with multiple strings

2011-12-19 Thread Rob Herring
pinmux modes. > > prop = "uart_rx", "uart_tx", "", "", "safe_mode"; > > Do no skip NULL string and take them into account in > of_property_read_string_index and of_property_count_strings. > > Reported-by: Tony Lindgren > Sign

Re: [PATCH v3 0/4] OMAP serial device tree support

2011-12-16 Thread Rob Herring
Tony, On 12/16/2011 03:57 PM, Tony Lindgren wrote: > Rob, > > * Rob Herring [111214 05:16]: >> On 12/14/2011 05:55 AM, Rajendra Nayak wrote: >>> v3 is rebased on top of the latest serial runtime >>> patches[1] and boot tested with/without DT on OMA

Re: [PATCH 2/4] ARM: OMAP2/3: intc: Add DT support for TI interrupt controller

2011-12-15 Thread Rob Herring
On 12/15/2011 11:49 AM, Cousson, Benoit wrote: > On 12/9/2011 5:12 PM, Rob Herring wrote: >> On 12/09/2011 10:06 AM, Cousson, Benoit wrote: > > [...] > >>> My point is that even in the DT case I do have some devices that are >>> initialized without DT for the

Re: [PATCH v2 02/10] i2c: OMAP: Add DT support for i2c controller

2011-12-15 Thread Rob Herring
On 12/15/2011 09:05 AM, Cousson, Benoit wrote: > Hi Rob, > > On 12/14/2011 5:58 PM, Rob Herring wrote: >> Benoit, >> >> On 12/09/2011 08:02 AM, Benoit Cousson wrote: >>> Add initial DT support to retrieve the frequency using a >>> DT attribute

Re: [PATCH v4 REPOST 3/5] omap4: Unconditionally require l2x0 L2 cache controller support

2011-12-14 Thread Rob Herring
t;>> Sounds like devicetree is the only safe way to deal with the L2 >>> control options. >>> >>> Regards, >>> >>> Tony >>> >>> >>>> This patch unconditionally enables l2x0 support for the OMAP4 SoCs. >>>

Re: [PATCH v2 02/10] i2c: OMAP: Add DT support for i2c controller

2011-12-14 Thread Rob Herring
Benoit, On 12/09/2011 08:02 AM, Benoit Cousson wrote: > Add initial DT support to retrieve the frequency using a > DT attribute instead of the pdata pointer if of_node exist. > > Add documentation for omap i2c controller binding. > > Based on original patches from Manju and Grant. > > Signed-of

Re: [PATCH v3 0/4] OMAP serial device tree support

2011-12-14 Thread Rob Herring
map2/board-generic.c|1 - > drivers/tty/serial/omap-serial.c | 80 +++ > 5 files changed, 132 insertions(+), 18 deletions(-) > create mode 100644 Documentation/devicetree/bindings/serial/omap_serial.txt Looks good. For the series: Reviewed-by: Rob Her

Re: [PATCH v4 REPOST 4/5] highbank: Unconditionally require l2x0 L2 cache controller support

2011-12-14 Thread Rob Herring
n. > > This patch unconditionally enables l2x0 support for the Highbank > SoC. > > Thanks to Rob Herring for this suggestion. [1] > > Signed-off-by: Dave Martin > > [1] > http://lists.infradead.org/pipermail/linux-arm-kernel/2011-November/074495.html Doesn&

Re: [PATCH 2/4] ARM: OMAP2/3: intc: Add DT support for TI interrupt controller

2011-12-09 Thread Rob Herring
On 12/09/2011 10:06 AM, Cousson, Benoit wrote: > On 12/9/2011 4:22 PM, Rob Herring wrote: >> On 12/09/2011 08:52 AM, Cousson, Benoit wrote: >>> On 12/9/2011 2:20 PM, Rob Herring wrote: >>>> On 12/08/2011 08:59 AM, Cousson, Benoit wrote: >>>>> On 12/7/2

Re: [PATCH 2/4] ARM: OMAP2/3: intc: Add DT support for TI interrupt controller

2011-12-09 Thread Rob Herring
On 12/09/2011 08:52 AM, Cousson, Benoit wrote: > On 12/9/2011 2:20 PM, Rob Herring wrote: >> On 12/08/2011 08:59 AM, Cousson, Benoit wrote: >>> On 12/7/2011 10:20 PM, Rob Herring wrote: >>>> On 12/07/2011 02:50 PM, Benoit Cousson wrote: >>> >>> [..

Re: [PATCH 2/4] ARM: OMAP2/3: intc: Add DT support for TI interrupt controller

2011-12-09 Thread Rob Herring
On 12/08/2011 08:59 AM, Cousson, Benoit wrote: > On 12/7/2011 10:20 PM, Rob Herring wrote: >> On 12/07/2011 02:50 PM, Benoit Cousson wrote: > > [...] > >>> +#ifdef CONFIG_OF >>> +int __init intc_of_init(struct device_node *node, struct device_node >>>

Re: [PATCH 2/4] ARM: OMAP2/3: intc: Add DT support for TI interrupt controller

2011-12-07 Thread Rob Herring
On 12/07/2011 02:50 PM, Benoit Cousson wrote: > Add a function to initialize the OMAP2/3 interrupt controller (INTC) > using a device tree node. > > Replace some printk() with the proper pr_ macro. > > Signed-off-by: Benoit Cousson > Cc: Tony Lindgren > --- > .../devicetree/bindings/arm/omap/

Re: [PATCH 2/3] arm/dts: OMAP: Remove bootargs node from board files

2011-12-06 Thread Rob Herring
Benoit, On 12/06/2011 10:49 AM, Benoit Cousson wrote: > Since 3.2, the CONFIG_ARM_ATAG_DTB_COMPAT config allows > an old bootloader to still use ATAG to provide cmdline. > > Remove chosen/bootargs from the DTS board files. > > Signed-off-by: Benoit Cousson > Cc: Grant Like

Re: [PATCH v2 0/4] OMAP serial device tree support

2011-11-28 Thread Rob Herring
On 11/28/2011 12:31 AM, Greg KH wrote: > On Mon, Nov 28, 2011 at 11:36:56AM +0530, Rajendra Nayak wrote: >> On Sunday 27 November 2011 09:06 AM, Greg KH wrote: >>> On Tue, Nov 22, 2011 at 07:14:12PM +0530, Rajendra Nayak wrote: v2 is based on the latest omap-serial runtime patches, which

Re: [PATCH v2 4/4] ARM: omap: pass minimal SoC/board data for UART from dt

2011-11-28 Thread Rob Herring
On 11/22/2011 07:44 AM, Rajendra Nayak wrote: > Pass minimal data needed for console boot, from dt, for > OMAP4 panda/sdp and OMAP3 beagle boards, and get rid of the > static initialization from generic board file. > > Signed-off-by: Rajendra Nayak Acked-by: Rob Herring Rob &g

Re: [PATCH v2 3/4] omap-serial: Add minimal device tree support

2011-11-28 Thread Rob Herring
orceidle/noidle/smaridle bits and handling typo: smartidle > remote wakeup and dynamic muxing. > > Signed-off-by: Rajendra Nayak Acked-by: Rob Herring Rob > --- > .../devicetree/bindings/serial/omap_serial.txt | 10 > drivers/tty/serial/omap-serial.c

<    1   2   3   >