On Mon, Dec 10, 2012 at 8:49 PM, Jack Mitchell m...@communistcode.co.uk wrote:
On 10/12/12 14:59, Felipe Balbi wrote:
Hi,
On Mon, Dec 10, 2012 at 02:50:16PM +, Jack Mitchell wrote:
On Mon, Dec 10, 2012 at 01:23:09PM +, Jack Mitchell wrote:
Hi,
I am currently having issues with
The OMAP_I2C_FLAG_RESET_REGS_POSTIDLE is not used anymore
in the i2c driver. Remove the flag.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
Has dependency on the below patch
http://git.pengutronix.de/?p=wsa/linux.git;a=commitdiff;h=554c96744afd169886bd6fc2736fb0d9aaf634e8
arch/arm/mach
The OMAP_I2C_FLAG_RESET_REGS_POSTIDLE is not used anymore
in the i2c driver. Remove the flag.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
Has dependency on the below patch
http://git.pengutronix.de/?p=wsa/linux.git;a=commitdiff;h=554c96744afd169886bd6fc2736fb0d9aaf634e8
arch/arm/mach
The OMAP_I2C_FLAG_RESET_REGS_POSTIDLE is not used anymore
in the i2c driver. Remove the flag.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
Has dependency on the below patch
http://git.pengutronix.de/?p=wsa/linux.git;a=commitdiff;h=554c96744afd169886bd6fc2736fb0d9aaf634e8
arch/arm/mach
On Mon, Nov 26, 2012 at 2:44 PM, Felipe Balbi ba...@ti.com wrote:
- OMAP_I2C_FLAG_BUS_SHIFT_2,
+ .flags = OMAP_I2C_FLAG_BUS_SHIFT_2,
if it's not used anymore, how about removing its definition too ?
Just updated the patch , thanks.
--
To unsubscribe from
The macros OMAP4_KBD_SYSSTATUS and OMAP4_KBD_SYSSTATUS are not used
so remove them.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
drivers/input/keyboard/omap4-keypad.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/input/keyboard/omap4-keypad.c
b
of the common defines to i2c-omap.h to avoid duplication.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
arch/arm/mach-omap2/i2c.c | 16 +++-
arch/arm/mach-omap2/omap_hwmod_2420_data.c |1 -
arch/arm/mach-omap2/omap_hwmod_2430_data.c |1 -
arch/arm/mach
On Mon, Nov 26, 2012 at 5:22 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Mon, Nov 26, 2012 at 05:09:42PM +0530, Shubhrajyoti D wrote:
The OMAP_I2C_IP_VERSION_1 and OMAP_I2C_IP_VERSION_2 was needed
as on VER2 we were not reading all the 32-bits. Since now that
we read the hi register we do
On Mon, Nov 26, 2012 at 11:31 PM, Dmitry Torokhov
dmitry.torok...@gmail.com wrote:
On Mon, Nov 26, 2012 at 04:21:19PM +0530, Shubhrajyoti D wrote:
The macros OMAP4_KBD_SYSSTATUS and OMAP4_KBD_SYSSTATUS are not used
so remove them.
They document the existing registers and do not add bloat
Fix the below warning
drivers/spi/spi-omap2-mcspi.c:336:34: warning: symbol 'tx' shadows an earlier
one
drivers/spi/spi-omap2-mcspi.c:327:12: originally declared here
So delete the u8 tx as it is assigned and not used(resigned afterwards).
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
On Fri, Nov 16, 2012 at 7:50 PM, Wolfram Sang w.s...@pengutronix.de wrote:
On Thu, Nov 15, 2012 at 02:19:21PM +0530, Shubhrajyoti D wrote:
Currently we just queue the transfer and release the
qos constraints, however we do not wait for the transfer
to complete to release the constraint. Move
-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
v2: rebase to the for-next branch
v3: Fix a typo
drivers/i2c/busses/i2c-omap.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 482c63d..fabcbe1 100644
On Thu, Nov 15, 2012 at 1:46 PM, Jean Pihet jean.pi...@newoldbits.com wrote:
Hi Shubhrajyoti,
On Thu, Nov 15, 2012 at 8:34 AM, Shubhrajyoti D shubhrajy...@ti.com wrote:
Currently we just queue the transfer and release the
qos constraints, however we donot wait for the transfer
Typo: donot
On Thu, Nov 15, 2012 at 12:20 AM, Wolfram Sang w.s...@pengutronix.de wrote:
This makes one of my code analyzers happy and makes me a part of the
anything open source which we could all be using ? :-)
'my' as in 'one of those I am using'. It was cppcheck which found that
flaw. Its use for
On Wednesday 14 November 2012 04:33 PM, Jean Pihet wrote:
Acked-by: Jean Pihet j-pi...@ti.com
Since I just reverted the QoS patch, I suppose this gets merged into the
original patch when resent?
The best for now is to re-submit a new patch that moves the constraint
release in the original
On Wednesday 14 November 2012 05:34 PM, Wolfram Sang wrote:
On Mon, Nov 05, 2012 at 05:53:35PM +0530, Shubhrajyoti D wrote:
Shubhrajyoti D (8):
i2c: omap: Fix the revision register read
i2c: omap: use revision check for OMAP_I2C_FLAG_APPLY_ERRATA_I207
i2c: omap: remove
Currently we just queue the transfer and release the
qos constraints, however we donot wait for the transfer
to complete to release the constraint. Move the remove
constraint after the bus busy as we are sure that the
transfers are completed by then.
Signed-off-by: Shubhrajyoti D shubhrajy
On Mon, Nov 5, 2012 at 5:53 PM, Shubhrajyoti D shubhrajy...@ti.com wrote:
Does the followiing
- Make the revision a 32- bit consisting of rev_lo amd rev_hi each
of 16 bits.
- Also use the revision register for the erratum i207.
- Refactor the i2c_omap_init code.
Adds a patch to remove
The commit d7b4394e[Cleanup the omap2_mcspi_txrx_dma function]
changed the wait_for_completion order. Move the wait so that the
rx doesnot wait for the tx to complete.
Reported-and-tested-by: Sørensen, Stefan soren...@polycom.com
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
drivers/spi
The commit d7b4394e[Cleanup the omap2_mcspi_txrx_dma function]
changed the wait_for_completion order. Move the wait so that the
rx doesnot wait for the tx to complete.
Reported-and-tested-by: Sørensen, Stefan soren...@polycom.com
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
drivers/spi
On Tue, Nov 6, 2012 at 2:33 PM, Mark Brown
broo...@opensource.wolfsonmicro.com wrote:
On Tue, Nov 06, 2012 at 02:30:19PM +0530, Shubhrajyoti D wrote:
The commit d7b4394e[Cleanup the omap2_mcspi_txrx_dma function]
changed the wait_for_completion order. Move the wait so that the
rx doesnot wait
Currently we just queue the transfer and release the
qos constraints, however we donot wait for the transfer
to complete to release the constraint. Move the remove
constraint after the bus busy as we are sure that the
transfers are completed by then.
Signed-off-by: Shubhrajyoti D shubhrajy
On Tue, Nov 6, 2012 at 5:31 AM, Kevin Hilman
khil...@deeprootsystems.com wrote:
Jean Pihet jean.pi...@newoldbits.com writes:
[...]
I ran some intensive stress tests on the I2C and ... unfortunately I
could not trigger the problem. It looks like the issue is caused by
some transient
On Tue, Nov 6, 2012 at 2:52 PM, Mark Brown
broo...@opensource.wolfsonmicro.com wrote:
On Tue, Nov 06, 2012 at 02:47:27PM +0530, Shubhrajyoti D wrote:
The commit d7b4394e[Cleanup the omap2_mcspi_txrx_dma function]
changed the wait_for_completion order. Move the wait so that the
rx doesnot wait
On Tue, Nov 6, 2012 at 10:01 PM, Paul Walmsley p...@pwsan.com wrote:
This reverts commit 3db11feffc1ad2ab9dea27789e6b5b3032827adc.
This commit causes I2C timeouts to appear on several OMAP3430/3530-based
boards:
http://marc.info/?l=linux-arm-kernelm=135071372426971w=2
On Monday 05 November 2012 01:16 PM, Felipe Balbi wrote:
include/linux/i2c-omap.h |1 -
4 files changed, 104 insertions(+), 75 deletions(-)
since I have reviewed your previous version, it would be nice to Cc me
so I don't loose your series ;-)
OK will do that. thanks
On Monday 05 November 2012 01:20 PM, Felipe Balbi wrote:
Hi,
On Sun, Nov 04, 2012 at 04:14:27PM +0530, Shubhrajyoti D wrote:
The revision register on OMAP4 is a 16-bit lo and a 16-bit
hi. Currently the driver reads only the lower 8-bits.
Fix the same by preventing the truncating of the rev
On Monday 05 November 2012 01:23 PM, Felipe Balbi wrote:
Hi,
On Sun, Nov 04, 2012 at 04:14:29PM +0530, Shubhrajyoti D wrote:
The dtrev is used only for the comments. Remove the same and use
the scheme instead to know if it is version2.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
I
On Monday 05 November 2012 02:35 PM, Felipe Balbi wrote:
egister map is different.
So the scheme may still be required.
fair enough, but drop it from debugging messages.
OK thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to
On Mon, Nov 5, 2012 at 2:34 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Mon, Nov 05, 2012 at 02:04:56PM +0530, Shubhrajyoti wrote:
@@ -1155,7 +1187,7 @@ omap_i2c_probe(struct platform_device *pdev)
dev-fifo_size = (dev-fifo_size / 2);
- if (dev-rev
The errata i207 is enabled for 2430 and 3xxx. Use the revision check
to enable the erratum instead.
Reviewed-by: Felipe Balbi ba...@ti.com
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
drivers/i2c/busses/i2c-omap.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git
:
Linux 3.7-rc4 (2012-11-04 11:07:39 -0800)
are available in the git repository at:
git://gitorious.org/linus-tree/linus-tree.git i2c_omap/for_3.8
Shubhrajyoti D (8):
i2c: omap: Fix the revision register read
i2c: omap: use revision check for OMAP_I2C_FLAG_APPLY_ERRATA_I207
of the cases the minor values of the 2430 register
is different(0x37) in that case the autoidle setting may be missed.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
drivers/i2c/busses/i2c-omap.c | 20 +---
1 files changed, 5 insertions(+), 15 deletions(-)
diff --git
-by: Shubhrajyoti D shubhrajy...@ti.com
---
Todo: the flag could be deleted if the patch is accepted.
drivers/i2c/busses/i2c-omap.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 7393017..25f1564 100644
Implement reset as a separate function.
This will enable us to make sure that we don't do the
calculation again on every transfer.
Also at probe the reset is not added as the hwmod is doing that
for us.
Reviewed-by: Felipe Balbi ba...@ti.com
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
The commit [i2c: omap: use revision check for OMAP_I2C_FLAG_APPLY_ERRATA_I207]
uses the revision id instead of the flag. So the flag can be safely removed.
Reviewed-by: Felipe Balbi ba...@ti.com
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_2430_data.c
added in the resume handler to prevent the access before
the setting of the regs.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
v3: Fix the comments.
drivers/i2c/busses/i2c-omap.c | 61 -
1 files changed, 48 insertions(+), 13 deletions(-)
diff --git
re-factor omap_i2c_init() so that we can re-use it for resume.
While at it also remove the bufstate variable as we write it
in omap_i2c_resize_fifo for every transfer.
Reviewed-by: Felipe Balbi ba...@ti.com
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
drivers/i2c/busses/i2c-omap.c
The dtrev is used only for the comments. Remove the same and use
the scheme instead to know if it is version2.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
v3: remove the scheme from the commments.
todo: remove the dtrev from hwmod etc.
drivers/i2c/busses/i2c-omap.c | 12
On Monday 05 November 2012 07:44 PM, Felipe Balbi wrote:
-dev-syscstate);
- }
not sure if this will work. What about the first time you call reset() ?
won't SYSC just contain the reset values ?
No actually the hwmod sets the value.
On 11/5/12, Cousson, Benoit b-cous...@ti.com wrote:
On 11/5/2012 3:25 PM, Felipe Balbi wrote:
Hi,
On Mon, Nov 05, 2012 at 07:53:45PM +0530, Shubhrajyoti wrote:
On Monday 05 November 2012 07:44 PM, Felipe Balbi wrote:
- dev-syscstate
) a reset is done. However the restore
never happens as it is dependent on the POSTIDLE flag.
The other option would be to call a restore in the reset
case. As there are only a few registers to be restored
the penalty in the idle case should not be much.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
after enabling hwmod
Also available through
git://gitorious.org/linus-tree/linus-tree.git i2c_omap/for_3.8
Shubhrajyoti D (7):
i2c: omap: Fix the revision register read
i2c: omap: use revision check for OMAP_I2C_FLAG_APPLY_ERRATA_I207
i2c: omap: remove the dtrev
ARM: i2c: omap: Remove
re-factor omap_i2c_init() so that we can re-use it for resume.
While at it also remove the bufstate variable as we write it
in omap_i2c_resize_fifo for every transfer.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
drivers/i2c/busses/i2c-omap.c | 75
The commit [i2c: omap: use revision check for OMAP_I2C_FLAG_APPLY_ERRATA_I207]
uses the revision id instead of the flag. So the flag can be safely removed.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_2430_data.c |3 +--
arch/arm/mach-omap2
added in the resume handler to prevent the access before
the setting of the regs.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
drivers/i2c/busses/i2c-omap.c | 61 -
1 files changed, 48 insertions(+), 13 deletions(-)
diff --git a/drivers/i2c/busses
The errata i207 is enabled for 2430 and 3xxx. Use the revision check
to enable the erratum instead.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
drivers/i2c/busses/i2c-omap.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b
Implement reset as a separate function.
This will enable us to make sure that we don't do the
calculation again on every transfer.
Also at probe the reset is not added as the hwmod is doing that
for us.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
todo: reprodue the errors and optimise
The dtrev is used only for the comments. Remove the same and use
the scheme instead to know if it is version2.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
drivers/i2c/busses/i2c-omap.c | 10 --
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/i2c/busses
The errata i207 is enabled for 2430 and 3xxx. Use the revision check
to enable the erratum instead.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
drivers/i2c/busses/i2c-omap.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b
.
Shubhrajyoti D (2):
i2c: omap: use revision check for OMAP_I2C_FLAG_APPLY_ERRATA_I207
i2c: omap: Fix the revision register read
drivers/i2c/busses/i2c-omap.c | 62 +++-
1 files changed, 48 insertions(+), 14 deletions(-)
--
1.7.5.4
--
To unsubscribe from
added in the resume handler to prevent the access before
the setting of the regs.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
drivers/i2c/busses/i2c-omap.c | 59 -
1 files changed, 46 insertions(+), 13 deletions(-)
diff --git a/drivers/i2c/busses
On Fri, Nov 2, 2012 at 4:37 PM, Felipe Balbi ba...@ti.com wrote:
On Fri, Nov 02, 2012 at 04:09:45PM +0530, Shubhrajyoti D wrote:
The errata i207 is enabled for 2430 and 3xxx. Use the revision check
to enable the erratum instead.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
very good. I
On Fri, Nov 2, 2012 at 4:36 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Fri, Nov 02, 2012 at 04:09:44PM +0530, Shubhrajyoti D wrote:
The revision register on OMAP4 is a 16-bit lo and a 16-bit
hi. Currently the driver reads only the lower 8-bits.
Fix the same by preventing the truncating
-by: Shubhrajyoti D shubhrajy...@ti.com
---
todo: some of the flag checks can be removed in favour of revision check.
drivers/i2c/busses/i2c-omap.c | 35 +--
1 files changed, 25 insertions(+), 10 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c
On Wed, Oct 31, 2012 at 2:29 PM, Shubhrajyoti D shubhrajy...@ti.com wrote:
The revision register on OMAP4 is a 16-bit lo and a 16-bit
hi. Currently the driver reads only the lower 8-bits.
Fix the same by preventing the truncating of the rev register
for OMAP4.
Also use the scheme bit ie bit
On Wednesday 31 October 2012 03:42 PM, Felipe Balbi wrote:
Hi,
On Wed, Oct 31, 2012 at 02:29:19PM +0530, Shubhrajyoti D wrote:
The revision register on OMAP4 is a 16-bit lo and a 16-bit
hi. Currently the driver reads only the lower 8-bits.
Fix the same by preventing the truncating of the rev
On Wednesday 31 October 2012 03:42 PM, Felipe Balbi wrote:
+ if (!_dev-regs)
+ return 0;
this is wrong, you need to make sure dev-regs is set early enough.
to set the dev-regs I use the value read from revision register.
to read the revision register I do a get_sync first.
re-factor omap_i2c_init() so that we can re-use it for resume.
While at it also remove the bufstate variable as we write it
in omap_i2c_resize_fifo for every transfer.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
v2 - add the iestate 0 check back.
- Remove a stray change.
- Applies
On Thu, Oct 25, 2012 at 12:06 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Thu, Oct 25, 2012 at 12:06:51PM +0530, Shubhrajyoti D wrote:
re-factor omap_i2c_init() so that we can re-use it for resume.
While at it also remove the bufstate variable as we write it
in omap_i2c_resize_fifo for every
omap_i2c_transmit_data() and omap_i2c_receive_data()
will act until dev-buf_len reaches zero, rendering the
other write in omap_i2c_xfer_msg() redundant.
This patch has been tested with pandaboard for a few
iterations of the script mentioned above.
looks good to me
Acked-by: Shubhrajyoti D shubhrajy
On Thu, Oct 25, 2012 at 12:06 PM, Felipe Balbi ba...@ti.com wrote:
[...]
+ * Don't write to this register if the IE state is 0 as it can
+ * cause deadlock.
+ */
+ if (dev-iestate)
+ omap_i2c_write_reg(dev, OMAP_I2C_IE_REG, dev-iestate);
+}
+
static int
Applies on Felipe's series
http://www.spinics.net/lists/linux-omap/msg79995.html
Tested with Terro sys fix + Felipe's stop sched_clock() during suspend
on omap3630 beagle both idle and suspend.
Functional testing on omap4sdp.
Shubhrajyoti D (2):
i2c: omap: re-factor omap_i2c_init function
Implement reset as a seperate function.
This will enable us to make sure that we don't do the
calculation again on every transfer.
Also at probe the reset is not added as the hwmod is doing that
for us.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
drivers/i2c/busses/i2c-omap.c | 28
re-factor omap_i2c_init() so that we can re-use it for resume.
While at it also remove the bufstate variable as we write it
in omap_i2c_resize_fifo for every transfer.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
drivers/i2c/busses/i2c-omap.c | 71
On Mon, Oct 22, 2012 at 3:16 PM, Felipe Balbi ba...@ti.com wrote:
just a cleanup patch trying to make exit path
more straightforward. No changes otherwise.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/i2c/busses/i2c-omap.c | 26 +-
1 file changed, 17
On Thursday 25 October 2012 04:25 PM, Felipe Balbi wrote:
overflow, underflow
these are data errors personally feel may be removed.
and arbitration lost)
will investigate.
and try to make sure if
actually need to reset the controller all the time. I find it really odd
that we're always
Applies on Felipe's series
http://www.spinics.net/lists/linux-omap/msg79995.html
Tested with Terro sys fix + Felipe's stop sched_clock() during suspend
on omap3630 beagle both idle and suspend.
Functional testing on omap4sdp.
Todo: all the error cases may not need a reset.
Shubhrajyoti D (2
Implement reset as a separate function.
This will enable us to make sure that we don't do the
calculation again on every transfer.
Also at probe the reset is not added as the hwmod is doing that
for us.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
some of the errors may not need a reset
re-factor omap_i2c_init() so that we can re-use it for resume.
While at it also remove the bufstate variable as we write it
in omap_i2c_resize_fifo for every transfer.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
v4: add spaces for readability
drivers/i2c/busses/i2c-omap.c | 74
Implement reset as a separate function.
This will enable us to make sure that we don't do the
calculation again on every transfer.
Also at probe the reset is not added as the hwmod is doing that
for us.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
some of the errors may not need a reset
Applies on Felipe's series
http://www.spinics.net/lists/linux-omap/msg79995.html
Tested with Terro sys fix + Felipe's stop sched_clock() during suspend
on omap3630 beagle both idle and suspend.
Functional testing on omap4sdp.
Todo: all the error cases may not need a reset.
Shubhrajyoti D (2
re-factor omap_i2c_init() so that we can re-use it for resume.
While at it also remove the bufstate variable as we write it
in omap_i2c_resize_fifo for every transfer.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
v4: add spaces for readability
drivers/i2c/busses/i2c-omap.c | 74
On 10/24/2012 12:41 AM, Felipe Balbi wrote:
return 0;
}
another thing, the few places in omap_i2c_xfer_msg() which are currently
calling omap_i2c_init() should also be converted to call the newly added
__omap_i2c_init(). We don't need to recalculate any of those clock
dividers
On Tue, Oct 23, 2012 at 11:27 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Tue, Oct 23, 2012 at 11:26:15PM +0530, Shubhrajyoti Datta wrote:
@@ -1268,23 +1271,8 @@ static int omap_i2c_runtime_resume(struct device
*dev)
{
struct omap_i2c_dev *_dev = dev_get_drvdata(dev
re-factor omap_i2c_init() so that we can re-use it for resume.
While at it also remove the bufstate variable as we write it
in omap_i2c_resize_fifo for every transfer.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
Applies on Felipe's series
http://www.spinics.net/lists/linux-omap/msg79995
On Tue, Oct 23, 2012 at 3:16 AM, Kevin Hilman
khil...@deeprootsystems.com wrote:
Tero Kristo t-kri...@ti.com writes:
When waking up from off-mode, some IP blocks are reset automatically by
hardware. For this reason, software must wait until the reset has
completed before attempting to access
On Tue, Oct 23, 2012 at 9:39 PM, Kevin Hilman
khil...@deeprootsystems.com wrote:
Shubhrajyoti Datta omaplinuxker...@gmail.com writes:
[...]
Could you please explain what worked and didn't work on each platforms?
Also, which 3430 did you test on? If it's SDP, then it has a UART1
console
On Tue, Oct 23, 2012 at 10:48 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Tue, Oct 23, 2012 at 08:57:19PM +0530, Shubhrajyoti D wrote:
re-factor omap_i2c_init() so that we can re-use it for resume.
While at it also remove the bufstate variable as we write it
in omap_i2c_resize_fifo for every
On Tue, Oct 23, 2012 at 11:27 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Tue, Oct 23, 2012 at 11:26:15PM +0530, Shubhrajyoti Datta wrote:
@@ -1268,23 +1271,8 @@ static int omap_i2c_runtime_resume(struct device
*dev)
{
struct omap_i2c_dev *_dev = dev_get_drvdata(dev
On Mon, Oct 22, 2012 at 3:52 PM, Sebastien Guiriec s-guir...@ti.com wrote:
Add base address and interrupt line inside Device Tree data for
OMAP5
Looks good to me.
Thanks ,
Reviewed-by: Shubhrajyoti D shubhrajy...@ti.com
Signed-off-by: Sebastien Guiriec s-guir...@ti.com
---
arch/arm/boot
A3 (4430), will send boot-logs if anyone wants to see.
tested the below branch on omap4430sdp , panda , omap3430sdp.
Doing simple i2ctools
.
Tested-by : Shubhrajyoti D shubhrajy...@ti.com
All patches are available at [1] if anyone wants an easy way to
test the patches.
[1] git
On Monday 22 October 2012 07:36 PM, Felipe Balbi wrote:
can you also check if echo mem /sys/power/state works ? Don't forget
to enable UART wakeups with:
echo enabled /sys/devices/platform/omap_uart.2/power/wakeup
echo enabled /sys/devices/platform/omap_uart.2/tty/ttyO2/power/wakeup
probe deferral
[0.484466] Advanced Linux Sound Architecture Driver Initialized.
[4.746917] omap_i2c i2c.15: bus 4 rev2.4.0 at 100 kHz
[4.755279] gpiochip_find_base: found new base at 477
[4.761169] gpiochip_add: registered GPIOs 477 to 500 on device: tca6424a
Thanks,
Acked-by: Shubhrajyoti D
On Mon, Oct 15, 2012 at 7:21 AM, Paul Walmsley p...@pwsan.com wrote:
Commit 3b2f8f82dad7d1f79cdc8fc05bd1c94baf109bde (i2c: omap: switch to
threaded IRQ support) causes communication with I2C devices to fail
after system suspend/resume on all OMAP3 devices:
Could you tell me which omap3
On Mon, Oct 15, 2012 at 2:46 PM, Kalle Jokiniemi
kalle.jokini...@jollamobile.com wrote:
ma, 2012-10-15 kello 09:21 +0300, Kalle Jokiniemi kirjoitti:
Hi,
pe, 2012-10-12 kello 14:46 +, Strashko, Grygorii kirjoitti:
Hi Kevin,
yep, [1] is the same fix - thanks.
Hi Kalle,
i've
On Friday 12 October 2012 03:48 PM, Strashko, Grygorii wrote:
Hi All,
Sorry, for the late reply.
+ CC Huzefa Kankroliwala - who is I2C driver owner on Android Kernel 3.4.
Regarding this patch
hmm I had similar ideas however my idea was to pacify the arm interrupts
when the ip is used by
will be lost, which basically
nullifies the use of autosuspend.
so I do not expect any interrupts between completion/error - autosuspend.
Since Shubhrajyoti didn't respond to my runtime PM comments on the
original patch,
my apologies for the delay.
I'll respin this patch by moving the INTC
this, also disable interrupts at
the MPU INTC when idling the device in -runtime_suspend() (and
re-enable them in -runtime_resume().) This part based on an original
patch from Shubhrajyoti Datta. NOTE: for proper sharing the I2C with
a coprocessor, this driver still needs hwspinlock support
On Wed, Oct 10, 2012 at 5:48 PM, Kalle Jokiniemi
kalle.jokini...@jollamobile.com wrote:
The resume_noirq enables interrupts one-by-one starting from
first one. Now if the wake up event for suspend came from i2c
device, the i2c bus irq gets enabled before the threaded
i2c device irq, causing a
controller, we can
now remove the old device related macros.
Reviewed-by: Shubhrajyoti D shubhrajy...@ti.com
Signed-off-by: Tony Lindgren t...@atomide.com
---
arch/arm/mach-omap1/common.h |3 +
arch/arm/mach-omap1/i2c.c | 59 +++
arch/arm/mach-omap2
value.
Since not all want the XOFF2 support lets not enable it by
default.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
drivers/tty/serial/omap-serial.c |6 +-
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial
Currently the array serial_omap_console_ports is hard coded to 4.
Make it depend on the maximum uart count.
Post to [cfc55bc ARM: OMAP2+: serial: Change MAX_HSUART_PORTS to 6]
the max ports is 6.
Cc: AnilKumar Ch anilku...@ti.com
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
drivers/tty
by
get_context_loss_count print a warning and do a restore.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
drivers/tty/serial/omap-serial.c | 12
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index
On Monday 01 October 2012 04:31 PM, Sourav Poddar wrote:
+smsc_probe(struct platform_device *pdev)
+{
+ struct device *dev = pdev-dev;
+ struct smsc *smsc = dev_get_drvdata(pdev-dev.parent);
+ struct input_dev *input;
+ struct smsc_keypad *kp;
+ int ret = 0, error;
+
://git.pengutronix.de/git/wsa/linux.git, branch
i2c-embedded/for-next
thanks ,
tested with i2c tools on omap4sdp and omap3sdp
Acked-by: Shubhrajyoti D shubhrajy...@ti.com
---
arch/arm/plat-omap/i2c.c | 21 -
drivers/i2c/busses/i2c-omap.c | 32
On Friday 21 September 2012 02:58 PM, Felipe Balbi wrote:
Hi,
On Thu, Sep 20, 2012 at 04:03:50PM -0700, Kevin Hilman wrote:
Kevin Hilman khil...@deeprootsystems.com writes:
Hi Felipe,
I just noticed today that one of my boards (3530/Overo) was not making
it to the console when using an
Overrun also causes an internal flag to be set, which disables further
reception. Before the next frame can
be received, the MPU must:
• Reset the RX FIFO.
• clear the internal flag.
In the uart mode a dummy read is needed. Add the same.
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
On Friday 21 September 2012 04:30 PM, Felipe Balbi wrote:
On Fri, Sep 21, 2012 at 03:52:56PM +0530, Shubhrajyoti D wrote:
Overrun also causes an internal flag to be set, which disables further
reception. Before the next frame can
be received, the MPU must:
• Reset the RX FIFO.
• clear
On Fri, Sep 21, 2012 at 5:05 PM, Felipe Balbi ba...@ti.com wrote:
On Fri, Sep 21, 2012 at 04:46:52PM +0530, Shubhrajyoti wrote:
On Friday 21 September 2012 04:30 PM, Felipe Balbi wrote:
On Fri, Sep 21, 2012 at 03:52:56PM +0530, Shubhrajyoti D wrote:
[...]
it it is ! BRK_ERROR_BITS I return
1 - 100 of 880 matches
Mail list logo
