Re: [PATCH] clk: ti: omap5+: dpll: implement errata i810

to <t-kri...@ti.com> > --- Acked-by: Stephen Boyd <sb...@codeaurora.org> -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of

Re: [GIT PULL] clk: ti: fixes for 4.4-rc

On 11/24, Tero Kristo wrote: > Hi Michael, Stephen, > > Here are some TI clock driver fixes for 4.4-rc. > > -Tero > > > > The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: > > Linux 4.4-rc1

Re: [PATCH] clk: ti: dra7: constify clk_hw_omap_ops structure

On 11/15, Julia Lawall wrote: > The clk_hw_omap_ops structures are never modified, so declare this one as > const, like the others. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is

Re: [PATCH] clk: gpio: Get parent clk names already in of_gpio_clk_setup()

On 11/17, Jyri Sarha wrote: > Get parent clk names already in of_gpio_clk_setup() and store the > names in struct clk_gpio_delayed_register_data. of_clk_get_parent_name() > can not be called in struct of_clk_provider's get() callback since it > may make a recursive call to

[PATCH/RESEND] ARM: Remove __ref on hotplug cpu die path

arm-...@vger.kernel.org> Cc: <spear-de...@list.st.com> Cc: <linux-te...@vger.kernel.org> Signed-off-by: Stephen Boyd <sb...@codeaurora.org> --- Collected the acks and resent. arch/arm/kernel/psci_smp.c | 4 ++-- arch/arm/mach-omap2/omap-hotplug.c | 2 +- arch/arm/m

Re: [GIT PULL] clock: ti: fixes for 4.3-rc

On 10/02, Tero Kristo wrote: > Hi Stephen, Mike, > > A few TI clock driver fixes to pull against 4.3-rc. > > -Tero > > > > The following changes since commit 9ffecb10283508260936b96022d4ee43a7798b4c: > > Linux 4.3-rc3 (2015-09-27 07:50:08 -0400) > > are available in the

Re: [PATCH] clk: ti: dflt: fix enable_reg validity check

On 09/29, Suman Anna wrote: > diff --git a/drivers/clk/ti/clkt_dflt.c b/drivers/clk/ti/clkt_dflt.c > index 90d7d8a21c49..1ddc288fce4e 100644 > --- a/drivers/clk/ti/clkt_dflt.c > +++ b/drivers/clk/ti/clkt_dflt.c > @@ -222,7 +222,7 @@ int omap2_dflt_clk_enable(struct clk_hw *hw) > } >

Re: [PATCH v2] clk: ti: fix dual-registration of uart4_ick

On 09/29, Ben Dooks wrote: > On the OMAP AM3517 platform the uart4_ick gets registered > twice, causing any power managment to /dev/ttyO3 to fail > when trying to wake the device up. > > This solves the following oops: > > [] Unhandled fault: external abort on non-linefetch (0x1028) at

[PATCH] ARM: Remove __ref on hotplug cpu die path

aro.org> Cc: Sudeep Holla <sudeep.ho...@arm.com> Cc: Lorenzo Pieralisi <lorenzo.pieral...@arm.com> Cc: Will Deacon <will.dea...@arm.com> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: <linux-omap@vger.kernel.org> Cc: <linux-arm-...@vger.kernel.org> Cc: &

[PATCH 2/2] clk: Convert __clk_get_name(hw-clk) to clk_hw_get_name(hw)

geert+rene...@glider.be Cc: Ulrich Hecht ulrich.hecht+rene...@gmail.com Cc: linux-arm-ker...@lists.infradead.org Cc: linux-rockc...@lists.infradead.org Cc: linux-samsung-...@vger.kernel.org Cc: linux-te...@vger.kernel.org Cc: linux-omap@vger.kernel.org Signed-off-by: Stephen Boyd sb...@codeaurora.org

Re: [PATCH 05/12] ARM: OMAP2+: Add support for initializing dm814x clocks

matthijsvand...@gmail.com Cc: Mike Turquette mturque...@linaro.org Cc: Paul Walmsley p...@pwsan.com Cc: Stephen Boyd sb...@codeaurora.org Cc: Tero Kristo t-kri...@ti.com Signed-off-by: Tony Lindgren t...@atomide.com Acked-by: Stephen Boyd sb...@codeaurora.org --- a/arch/arm/mach-omap2/io.c +++ b/arch

Re: [GIT PULL]

On 07/15, Tero Kristo wrote: Hi Stephen, Mike, Here is the updated pull-request based on Stephen's request. This is on top of 4.1-rc2. The branch is force updated version of the one Stephen tried yesterday, the old one contained the minor build issues present on v3 of the patch set. I

Re: [GIT PULL] clk: ti: clock driver code migration to drivers

On 07/14/2015 01:54 AM, Tero Kristo wrote: The following changes since commit bc0195aad0daa2ad5b0d76cce22b167bc3435590: Linux 4.2-rc2 (2015-07-12 15:10:30 -0700) Why did this get rebased onto v4.2-rc2? I thought it was all ready to go based on v4.1-rc2? If possible leave it on v4.1-rc2

Re: [GIT PULL] clk: ti: clock driver code migration to drivers

On 07/14/2015 01:09 PM, Tero Kristo wrote: On 07/14/2015 10:29 PM, Stephen Boyd wrote: On 07/14/2015 01:54 AM, Tero Kristo wrote: The following changes since commit bc0195aad0daa2ad5b0d76cce22b167bc3435590: Linux 4.2-rc2 (2015-07-12 15:10:30 -0700) Why did this get rebased onto v4.2-rc2

Re: [PATCHv3 00/27] ARM: OMAP2+: clock code move under clk driver

On 07/13/2015 02:48 AM, Tero Kristo wrote: On 06/04/2015 02:11 AM, Michael Turquette wrote: Hi Tero, I'd like more time for any regressions this introduces to be fixed, so lets push back to next merge window. The always-wrong-but-never-by-much crystal ball[0] predicts June 14. This is less

Re: [PATCH v5] clk: change clk_ops' -determine_rate() prototype

On 07/09, Boris Brezillon wrote: Hi Stephen, On Wed, 08 Jul 2015 11:07:42 -0700 Stephen Boyd sb...@codeaurora.org wrote: On 07/08/2015 02:00 AM, Boris Brezillon wrote: Hi Stephen, On Tue, 7 Jul 2015 17:57:48 -0700 Stephen Boyd sb...@codeaurora.org wrote: On 07/07, Boris

Re: [PATCH v5] clk: change clk_ops' -determine_rate() prototype

On 07/08/2015 02:00 AM, Boris Brezillon wrote: Hi Stephen, On Tue, 7 Jul 2015 17:57:48 -0700 Stephen Boyd sb...@codeaurora.org wrote: On 07/07, Boris Brezillon wrote: } else { pr_err(clk: clk_composite_determine_rate function called, but no mux or rate callback set!\n

Re: [PATCH v5] clk: change clk_ops' -determine_rate() prototype

On 07/07, Boris Brezillon wrote: Clock rates are stored in an unsigned long field, but -determine_rate() (which returns a rounded rate from a requested one) returns a long value (errors are reported using negative error codes), which can lead to long overflow if the clock rate exceed 2Ghz.

Re: [PATCH v4] clk: change clk_ops' -determine_rate() prototype

On 07/06, Boris Brezillon wrote: Clock rates are stored in an unsigned long field, but -determine_rate() (which returns a rounded rate from a requested one) returns a long value (errors are reported using negative error codes), which can lead to long overflow if the clock rate exceed 2Ghz.

Re: [PATCH 3/5] clk: ti: Use of_clk_get_parent_count() instead of open coding

On 05/29, Geert Uytterhoeven wrote: Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 1/5] clk: at91: Use of_clk_get_parent_count() instead of open coding

On 05/29, Geert Uytterhoeven wrote: Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 2/5] clk: st: Use of_clk_get_parent_count() instead of open coding

On 05/29, Geert Uytterhoeven wrote: Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line unsubscribe

Re: [RFC/NOT FOR MERGING] HACK: add global/private timers for A9

On 06/04, Felipe Balbi wrote: On Thu, Jun 04, 2015 at 03:18:25PM -0500, Felipe Balbi wrote: On Thu, Jun 04, 2015 at 03:08:50PM -0500, Felipe Balbi wrote: Hi, On Thu, Jun 04, 2015 at 11:46:59AM +0200, Mason wrote: Also, check /proc/timer_list for a Broadcast device. If you don't

Re: [PATCH 5/5] [RFC] ARM: timer-sp: Use of_clk_get_parent_count() instead of open coding

On 06/04, Geert Uytterhoeven wrote: Hi Stephen, On Thu, Jun 4, 2015 at 1:44 AM, Stephen Boyd sb...@codeaurora.org wrote: On 05/29, Geert Uytterhoeven wrote: Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be #include linux/err.h #include linux/interrupt.h #include linux

Re: [PATCH 05/12] ARM: OMAP2+: Add support for initializing dm814x clocks

On 06/03, Tony Lindgren wrote: diff --git a/drivers/clk/ti/clk-814x.c b/drivers/clk/ti/clk-814x.c new file mode 100644 index 000..bd2353c --- /dev/null +++ b/drivers/clk/ti/clk-814x.c @@ -0,0 +1,36 @@ +/* + * This program is free software; you can redistribute it and/or + * modify it

Re: [RFC/NOT FOR MERGING] HACK: add global/private timers for A9

On 06/03/2015 02:28 PM, Felipe Balbi wrote: On Wed, Jun 03, 2015 at 04:04:55PM -0500, Felipe Balbi wrote: On Wed, Jun 03, 2015 at 10:55:27PM +0200, Arnd Bergmann wrote: On Wednesday 03 June 2015 15:32:45 Felipe Balbi wrote: Hi Tony and Russell, AM43xx, even though it's a single processor A9,

Re: [PATCH v3] clk: change clk_ops' -determine_rate() prototype

On 05/20, Boris Brezillon wrote: Clock rates are stored in an unsigned long field, but -determine_rate() (which returns a rounded rate from a requested one) returns a long value (errors are reported using negative error codes), which can lead to long overflow if the clock rate exceed 2Ghz.

Re: [PATCH 5/5] [RFC] ARM: timer-sp: Use of_clk_get_parent_count() instead of open coding

On 05/29, Geert Uytterhoeven wrote: Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- This is an RFC, as it depends on [RFC] clk: Provide dummy of_clk_get_parent_count() for !OF/!CCF. --- arch/arm/common/timer-sp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [PATCHv3 10/10] CLK: TI: always enable DESHDCP clock

On 05/28, Tero Kristo wrote: On 05/28/2015 07:22 AM, Michael Turquette wrote: Just chiming in on the critical clock discussion. I'm not planning to merge something that lets Devicetree nodes call clk_enable on a clock. That's what drivers are for. The assigned-rate and assigned-parent stuff

Re: [PATCHv3 02/27] clk: ti: move generic OMAP DPLL implementation under drivers/clk

On 05/25, Tero Kristo wrote: @@ -281,7 +282,7 @@ unsigned long omap2_get_dpll_rate(struct clk_hw_omap *clk) * be rounded, or the rounded rate upon success. */ long omap2_dpll_round_rate(struct clk_hw *hw, unsigned long target_rate, - unsigned long *parent_rate) +

Re: [PATCHv3 01/27] ARM: OMAP2+: clock: export driver API to setup/get clock features

On 05/25, Tero Kristo wrote: + +/** + * ti_clk_get_features - get clock driver features flags + * + * Get TI clock driver features description. Returns a pointer + * to the current feature setup. + */ +struct ti_clk_features *ti_clk_get_features(void) const? +{ + return

Re: [PATCHv2 02/27] clk: ti: move generic OMAP DPLL implementation under drivers/clk

On 05/20, Tero Kristo wrote: On 05/20/2015 04:20 AM, Stephen Boyd wrote: On 05/11, Tero Kristo wrote: With the legacy clock data now gone, we can start moving OMAP clock type implementations under clock driver. Start this with moving the generic OMAP DPLL clock type under TI clock driver

Re: [PATCHv3 10/10] CLK: TI: always enable DESHDCP clock

On 05/20/15 04:50, Tero Kristo wrote: @@ -348,5 +348,10 @@ int __init dra7xx_dt_clk_init(void) if (rc) pr_err(%s: failed to set USB_DPLL M2 OUT\n, __func__); +hdcp_ck = clk_get_sys(NULL, dss_deshdcp_clk); +rc = clk_prepare_enable(hdcp_ck); +if (rc) +

Re: [PATCH 06/14] clkdev: add clkdev_create() helper

On 04/07/15 05:43, Russell King - ARM Linux wrote: On Mon, Apr 06, 2015 at 01:19:33PM -0700, Stephen Boyd wrote: On 04/03/15 10:12, Russell King wrote: @@ -316,6 +329,29 @@ clkdev_alloc(struct clk *clk, const char *con_id, const char *dev_fmt, ...) } EXPORT_SYMBOL(clkdev_alloc

Re: [PATCH 03/14] clkdev: get rid of redundant clk_add_alias() prototype in linux/clk.h

On 04/04/15 05:43, Robert Jarzmik wrote: Russell King rmk+ker...@arm.linux.org.uk writes: clk_add_alias() is provided by clkdev, and is not part of the clk API. Howver, it is prototyped in two locations: linux/clkdev.h and linux/clk.h. This is a mess. Get rid of the redundant and

Re: [PATCH 06/14] clkdev: add clkdev_create() helper

On 04/03/15 10:12, Russell King wrote: @@ -316,6 +329,29 @@ clkdev_alloc(struct clk *clk, const char *con_id, const char *dev_fmt, ...) } EXPORT_SYMBOL(clkdev_alloc); +/** + * clkdev_create - allocate and add a clkdev lookup structure + * @clk: struct clk to associate with all

Re: [PATCH 05/14] clkdev: use clk_hw internally

On 04/03/15 10:12, Russell King wrote: Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk Some commit text would be nice for us 5 years from now when we wonder why this patch was applied. I suspect the commit text would go like this: clk_add_alias() calls clk_get() followed by clk_put()

Re: [PATCH V2 linux-next] clk: constify of_device_id array

On 03/31/15 11:50, Fabian Frederick wrote: of_device_id is always used as const. (See driver.of_match_table and open firmware functions) __initdata updated to __initconst for static const struct of_device_id ti_clkdm_match_table[] Signed-off-by: Fabian Frederick f...@skynet.be Thanks.

Re: [PATCH 32/35 linux-next] clk: constify of_device_id array

On 03/22, Fabian Frederick wrote: On 18 March 2015 at 15:15 Michael Turquette mturque...@linaro.org wrote: Quoting Fabian Frederick (2015-03-16 12:59:06) of_device_id is always used as const. (See driver.of_match_table and open firmware functions) Signed-off-by: Fabian

Re: [Cocci] [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

On 03/12/15 20:29, Shawn Guo wrote: On Thu, Mar 12, 2015 at 12:43:40PM -0700, Stephen Boyd wrote: On 03/12/15 10:20, Sebastian Andrzej Siewior wrote: On 2015-02-17 14:01:04 [-0800], Stephen Boyd wrote: diff = --- arch/arm/mach-imx/mach-imx6q.c +++ /tmp/cocci-output-11792-b62223-mach-imx6q.c

Re: [Cocci] [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

On 03/12/15 10:20, Sebastian Andrzej Siewior wrote: On 2015-02-17 14:01:04 [-0800], Stephen Boyd wrote: diff = --- arch/arm/mach-imx/mach-imx6q.c +++ /tmp/cocci-output-11792-b62223-mach-imx6q.c @@ -211,7 +211,6 @@ static void __init imx6q_1588_init(void) * set bit IOMUXC_GPR1[21

Re: [PATCH 05/10] clkdev: add clkdev_create() helper

On 03/02/15 13:01, Russell King - ARM Linux wrote: On Mon, Mar 02, 2015 at 11:07:58AM -0800, Stephen Boyd wrote: On 03/02/15 09:06, Russell King wrote: Add a helper to allocate and add a clk_lookup structure. This can not only be used in several places in clkdev.c to simplify the code

Re: [PATCH 00/10] initial clkdev cleanups

On 03/02/15 09:05, Russell King - ARM Linux wrote: Here's some initial clkdev cleanups. These are targetted for the next merge window, and while the initial patches can be merged independently, I'd prefer to keep the series together as further work on solving the problems which unique struct

Re: [PATCH 05/10] clkdev: add clkdev_create() helper

On 03/02/15 09:06, Russell King wrote: Add a helper to allocate and add a clk_lookup structure. This can not only be used in several places in clkdev.c to simplify the code, but more importantly, can be used by callers of the clkdev code to simplify their clkdev creation and registration.

Re: [Cocci] [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

On 02/05/15 18:15, Stephen Boyd wrote: On 02/05/15 07:45, Quentin Lambert wrote: On 05/02/2015 00:26, Stephen Boyd wrote: If you want me to I can enlarge the search to other directories. Yes please do. And if you could share the coccinelle patch that would be great. Thanks. structclk.cocci

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

On 02/06/15 05:39, Russell King - ARM Linux wrote: On Thu, Feb 05, 2015 at 05:35:28PM -0800, Stephen Boyd wrote: From what I can tell this code is now broken because we made all clk getting functions (there's quite a few...) return unique pointers every time they're called. It seems

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

On 02/06/15 11:37, Russell King - ARM Linux wrote: On Fri, Feb 06, 2015 at 11:30:18AM -0800, Stephen Boyd wrote: Why don't we make the legacy lookup more specific and actually indicate internal for the con_id? Then the external clock would fail to be found, but we can detect that case

Re: [Cocci] [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

On 02/06/15 01:12, Julia Lawall wrote: On Fri, 6 Feb 2015, Quentin Lambert wrote: On 06/02/2015 03:15, Stephen Boyd wrote: Thanks for the coccinelle patch. Thinking more about it, I don't think we care if the pointer is dereferenced because that would require a definition of struct clk

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

On 02/05/15 12:07, Stephen Boyd wrote: On 02/05/15 11:44, Sylwester Nawrocki wrote: Hi Tomeu, On 23/01/15 12:03, Tomeu Vizoso wrote: int __clk_get(struct clk *clk) { - if (clk) { - if (!try_module_get(clk-owner)) + struct clk_core *core = !clk ? NULL : clk-core

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

On 02/05/15 16:42, Russell King - ARM Linux wrote: On Thu, Feb 05, 2015 at 02:14:01PM -0800, Stephen Boyd wrote: Actually we can bury the __clk_create_clk() inside __of_clk_get_from_provider(). We should also move __clk_get() into there because right now we have a hole where whoever calls

Re: [Cocci] [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

On 02/05/15 08:02, Quentin Lambert wrote: Sorry let me do that properly. On 05/02/2015 16:45, Quentin Lambert wrote: On 05/02/2015 00:26, Stephen Boyd wrote: If you want me to I can enlarge the search to other directories. Yes please do. And if you could share the coccinelle patch

Re: [Cocci] [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

On 02/05/15 07:45, Quentin Lambert wrote: On 05/02/2015 00:26, Stephen Boyd wrote: If you want me to I can enlarge the search to other directories. Yes please do. And if you could share the coccinelle patch that would be great. Thanks. structclk.cocci is the coccinelle patch structclk

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

() is commented out. Ah now I get it. You meant to say that of_clk_get_by_clkspec() doesn't return an allocated clk pointer. Let's fix that. 8 From: Stephen Boyd sb...@codeaurora.org Subject: [PATCH] clkdev: Always allocate a struct clk in OF functions of_clk_get_by_clkspec() returns a struct clk

Re: [Cocci] [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

On 02/03/15 08:04, Quentin Lambert wrote: Hello, Julia asked me to have a look and see if I can help. I have found these three cases using Coccinnelle in the mach-omap2 directory. ./arch/arm/mach-omap2/clkt_clksel.c @@ -67,7 +67,6 @@ static const struct clksel *_get_clksel_

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

On 02/01/15 13:24, Mike Turquette wrote: Quoting Tomeu Vizoso (2015-01-23 03:03:30) Moves clock state to struct clk_core, but takes care to change as little API as possible. struct clk_hw still has a pointer to a struct clk, which is the implementation's per-user clk instance, for

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

On 02/02/15 14:41, Mike Turquette wrote: Quoting Tero Kristo (2015-02-02 11:32:01) On 02/01/2015 11:24 PM, Mike Turquette wrote: AFAICT this doesn't break anything, but booting on OMAP3+ results in noisy WARNs. I think the correct fix is to replace clk_bypass and clk_ref pointers with a

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

On 02/02/15 13:31, Julia Lawall wrote: On Mon, 2 Feb 2015, Stephen Boyd wrote: Julia, Is there a way we can write a coccinelle script to check for this? The goal being to find all drivers that are comparing struct clk pointers or attempting to dereference them. There are probably other

Re: [PATCH v13 4/6] clk: Add rate constraints to clocks

On 01/29, Stephen Boyd wrote: On 01/29/15 05:31, Geert Uytterhoeven wrote: Hi Tomeu, Mike, On Fri, Jan 23, 2015 at 12:03 PM, Tomeu Vizoso tomeu.viz...@collabora.com wrote: --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -2391,25 +2543,24 @@ int __clk_get(struct clk *clk

Re: [PATCH v13 4/6] clk: Add rate constraints to clocks

On 01/29/15 05:31, Geert Uytterhoeven wrote: Hi Tomeu, Mike, On Fri, Jan 23, 2015 at 12:03 PM, Tomeu Vizoso tomeu.viz...@collabora.com wrote: --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -2391,25 +2543,24 @@ int __clk_get(struct clk *clk) return 1; } -static void

Re: [PATCH v11 2/4] clk: Make clk API return per-user struct clk instances

On 01/22, Tomeu Vizoso wrote: On 01/22/2015 02:01 AM, Stephen Boyd wrote: BTW, please try and fixup checkpatch warnings. What were you thinking of specifically? I'm running it with --max-line-length=106 and the other warnings are in clk-test.c that I still have to polish when I get some

Re: [PATCH v12 4/6] clk: Add rate constraints to clocks

by adding the parameters min_rate and max_rate. Signed-off-by: Tomeu Vizoso tomeu.viz...@collabora.com Reviewed-by: Stephen Boyd sb...@codeaurora.org -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list

Re: [PATCH v12 3/6] clk: Make clk API return per-user struct clk instances

in struct clk_core now. Signed-off-by: Tomeu Vizoso tomeu.viz...@collabora.com --- My comment on v11 still stands about __clk_create_clk() in clkdev.c, but otherwise I don't see problems. You can have my reviewed-by anyway. Reviewed-by: Stephen Boyd sb...@codeaurora.org -- Qualcomm Innovation

Re: [PATCH v11 2/4] clk: Make clk API return per-user struct clk instances

On 01/21, Tomeu Vizoso wrote: @@ -2075,10 +2210,12 @@ struct clk *clk_register(struct device *dev, struct clk_hw *hw) } } - ret = __clk_init(dev, clk); + hw-clk = __clk_create_clk(hw, NULL, NULL); + ret = __clk_init(dev, hw-clk); if (!ret) -

Re: [PATCH v11 3/4] clk: Add rate constraints to clocks

On 01/21, Tomeu Vizoso wrote: Adds a way for clock consumers to set maximum and minimum rates. This can be used for thermal drivers to set minimum rates, or by misc. drivers to set maximum rates to assure a minimum performance level. Changes the signature of the determine_rate callback by

Re: [PATCH v10 2/3] clk: Make clk API return per-user struct clk instances

On 01/20, Tomeu Vizoso wrote: diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 97f3425..e867d6a 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -1719,6 +1817,31 @@ out: return ret; } + +/** + * clk_set_parent - switch the parent of a mux clk + * @clk: the mux

Re: [PATCH v10 3/3] clk: Add rate constraints to clocks

It's looking fairly close. Thanks for keeping up with the review comments. On 01/20, Tomeu Vizoso wrote: diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index e867d6a..f241e27 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -2143,6 +2280,10 @@ struct clk *__clk_register(struct

Re: [PATCH v9 3/3] clk: Add floor and ceiling constraints to clock rates

On 01/19, Tomeu Vizoso wrote: Adds a way for clock consumers to set maximum and minimum rates. This can be used for thermal drivers to set ceiling rates, or by misc. drivers to set floor rates to assure a minimum performance level. Changes the signature of the determine_rate callback by

Re: [PATCH RESEND v8 1/2] clk: Make clk API return per-user struct clk instances

On 01/19/2015 01:55 AM, Tomeu Vizoso wrote: On 17 January 2015 at 02:02, Stephen Boyd sb...@codeaurora.org wrote: On 01/12, Tomeu Vizoso wrote: +} EXPORT_SYMBOL_GPL(__clk_get_rate); @@ -630,7 +656,12 @@ out: return !!ret; } -bool __clk_is_enabled(struct clk *clk) +bool

Re: [PATCH v9 2/3] clk: Make clk API return per-user struct clk instances

On 01/19, Tomeu Vizoso wrote: diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 97f3425..f2a1ff3 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -694,32 +751,32 @@ long __clk_mux_determine_rate(struct clk_hw *hw, unsigned long rate, unsigned

Re: [PATCH RESEND v8 1/2] clk: Make clk API return per-user struct clk instances

On 01/12, Tomeu Vizoso wrote: Moves clock state to struct clk_core, but takes care to change as little API as possible. struct clk_hw still has a pointer to a struct clk, which is the implementation's per-user clk instance, for backwards compatibility. The struct clk that

Re: [PATCH RESEND v8 2/2] clk: Add floor and ceiling constraints to clock rates

On 01/12, Tomeu Vizoso wrote: diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 7eddfd8..2793bd7 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -1013,8 +1015,8 @@ static unsigned long clk_core_round_rate_nolock(struct clk_core *clk, if (clk-ops-determine_rate) {

Re: regression: Clock changes in next-20141205 break at least omap4

On 12/15/2014 05:31 PM, Paul Walmsley wrote: I just took a quick glance at Tero's second patch, and it looks like a hack to me. Better to fix the problem in the core CCF code if possible. I don't think there's any reason why a PLL couldn't have just one parent clock. But I'm fine with

Re: regression: Clock changes in next-20141205 break at least omap4

On 12/05/2014 08:55 AM, Tony Lindgren wrote: Hi, Looks like commit 646cafc6aa4d (clk: Change clk_ops-determine_rate to return a clk_hw as the best parent) breaks booting at least for omap4. Do you get a compilation warning in arch/arm/mach-omap2/dpll3xxx.c ? From what I can tell

Re: [PATCH v5 6/7] clk: Make clk API return per-user struct clk instances

in struct clk_core now. Signed-off-by: Tomeu Vizoso tomeu.viz...@collabora.com It would be good to have Russell at least ack the clkdev bits. There's still more work to do in the future here, but Reviewed-by: Stephen Boyd sb...@codeaurora.org -- Qualcomm Innovation Center, Inc. is a member of Code

Re: [PATCH v3 7/8] clk: Make clk API return per-user struct clk instances

On 10/09, Tomeu Vizoso wrote: arch/arm/mach-omap2/cclock3xxx_data.c | 108 -- arch/arm/mach-omap2/clock.h | 11 +- arch/arm/mach-omap2/clock_common_data.c | 5 +- drivers/clk/clk.c | 630 drivers/clk/clk.h

Re: [PATCH v2 0/8] Per-user clock constraints

On 10/07/2014 08:21 AM, Tomeu Vizoso wrote: Hello, this second version of the series adds several cleanups that were suggested by Stephen Boyd and contains several improvements to the seventh patch (clk: Make clk API return per-user struct clk instances) that were suggested by him during

Re: [PATCH 1/2] clk: Make clk API return per-user struct clk instances

On 10/07/2014 08:28 AM, Tomeu Vizoso wrote: On 4 October 2014 01:15, Stephen Boyd sb...@codeaurora.org wrote: On 10/02, Tomeu Vizoso wrote: + #if defined(CONFIG_OF) defined(CONFIG_COMMON_CLK) These ifdefs look useless. struct clk *of_clk_get_by_clkspec(struct of_phandle_args *clkspec

Re: [PATCH 1/2] clk: Make clk API return per-user struct clk instances

On 10/06/2014 10:14 AM, Tomeu Vizoso wrote: This is the end goal. I understand that the provider API is sort of a mess with us allowing drivers to use the underscore and non-underscore functions and the mixture of struct clk and struct ckl_hw throughout. struct clk_hw -- struct clk_core

Re: [PATCH 1/2] clk: Make clk API return per-user struct clk instances

On 10/02, Tomeu Vizoso wrote: Moves clock state to struct clk_core, but takes care to change as little API as possible. struct clk_hw still has a pointer to a struct clk, which is the implementation's per-user clk instance, for backwards compatibility. The struct clk that

Re: [PATCH] clk: prevent erronous parsing of children during rate change

On 09/23/14 06:38, Tero Kristo wrote: On 09/22/2014 10:18 PM, Stephen Boyd wrote: On 08/21, Tero Kristo wrote: /* Skip children who will be reparented to another clock */ if (child-new_parent child-new_parent != clk) continue; Are we not hitting

Re: [PATCH] clk: prevent erronous parsing of children during rate change

On 08/21, Tero Kristo wrote: In some cases, clocks can switch their parent with clk_set_rate, for example clk_mux can do this in some cases. Current implementation of clk_change_rate uses un-safe list iteration on the clock children, which will cause wrong clocks to be parsed in case any of

Re: [PATCH v2 01/26] genirq: add irq_domain-aware core IRQ handler

On 08/26/14 03:03, Marc Zyngier wrote: Calling irq_find_mapping from outside a irq_{enter,exit} section is unsafe and produces ugly messages if CONFIG_PROVE_RCU is enabled: If coming from the idle state, the rcu_read_lock call in irq_find_mapping will generate an unpleasant warning: quote

Re: [PATCH v2 01/26] genirq: add irq_domain-aware core IRQ handler

On 08/26/14 11:07, Marc Zyngier wrote: Digging into my email, one of the traces looked like this: stack backtrace: CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.16.0-rc1+ #135 Call trace: [ffc882cc] dump_backtrace+0x0/0x12c [ffc88408] show_stack+0x10/0x1c [ffc0004ee5f0]

Re: [PATCH v2 01/26] genirq: add irq_domain-aware core IRQ handler

On 08/26/14 11:46, Stephen Boyd wrote: On 08/26/14 11:07, Marc Zyngier wrote: Digging into my email, one of the traces looked like this: stack backtrace: CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.16.0-rc1+ #135 Call trace: [ffc882cc] dump_backtrace+0x0/0x12c [ffc88408

Re: [PATCHv12 06/49] clk: add support for low level register ops

On 01/03/14 01:13, Tero Kristo wrote: On 12/22/2013 07:39 PM, Gerhard Sittig wrote: Further I'd suggest to split this register access aspect out of the TI clock series, and to prepare it already for regmap style access to the hardware registers. See the next comment below. This sounds

Re: [PATCH] ARM: drop explicit selection of HAVE_CLK and CLKDEV_LOOKUP

Kleine-K??nig u.kleine-koe...@pengutronix.de For MSM: Acked-by: Stephen Boyd sb...@codeaurora.org -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH v3 1/3] usb: dwc3: msm: Add device tree binding information

On 08/19/13 05:27, Ivan T. Ivanov wrote: Hi, On Fri, 2013-08-16 at 16:44 -0600, Stephen Warren wrote: On 08/14/2013 06:59 AM, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys (SNPS) and HS, SS PHY's control and

Re: [PATCH v3 3/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

On 08/14/13 05:59, Ivan T. Ivanov wrote: +} + +static const struct of_device_id of_dwc3_matach[] = { match? Maybe you can make it all one line too { .compatible = qcom,dwc3 } + { + .compatible = qcom,dwc3, + }, + { }, +}; +MODULE_DEVICE_TABLE(of, of_dwc3_matach);

Re: [FAILURE] omap4430-sdp allnoconfig

On 08/01, Olof Johansson wrote: On Thu, Aug 01, 2013 at 11:59:56AM -0700, Stephen Boyd wrote: On 08/01, Santosh Shilimkar wrote: This one looks fine for me. Can you send above in a proper patch ? Let me know if you want me to send it. Here's a proper patch. Olof, can you

Re: [FAILURE] omap4430-sdp allnoconfig

On 08/02, Olof Johansson wrote: On Fri, Aug 2, 2013 at 1:44 PM, Stephen Boyd sb...@codeaurora.org wrote: On 08/01, Olof Johansson wrote: On Thu, Aug 01, 2013 at 11:59:56AM -0700, Stephen Boyd wrote: On 08/01, Santosh Shilimkar wrote: This one looks fine for me. Can you send above

Re: [FAILURE] omap4430-sdp allnoconfig

ef3160cd2f0a400751f2cf6fd2811225fee1d5a7 Author: Stephen Boyd sb...@codeaurora.org Date: Mon Mar 4 19:24:35 2013 -0800 ARM: OMAP2+: Divorce from local timer API Now that the TWD doesn't rely on the local timer API, OMAP can stop selecting it in Kconfig and relying on the config

Re: [FAILURE] omap4430-sdp allnoconfig

On 08/01/13 11:34, Stephen Boyd wrote: On 08/01/13 11:31, Santosh Shilimkar wrote: On Thursday 01 August 2013 02:27 PM, Russell King - ARM Linux wrote: On Thu, Aug 01, 2013 at 02:11:18PM -0400, Santosh Shilimkar wrote: On Thursday 01 August 2013 01:52 PM, Russell King - ARM Linux wrote: My

Re: [FAILURE] omap4430-sdp allnoconfig

santosh.shilim...@ti.com Signed-off-by: Stephen Boyd sb...@codeaurora.org --- arch/arm/mach-omap2/timer.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c index 3b7caba..00dc53e 100644 --- a/arch/arm/mach-omap2/timer.c +++ b/arch/arm

Re: [PATCHv2 10/11] ARM: dts: omap4 clock data

On 06/19/13 06:19, Tero Kristo wrote: diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi index 2a56428..70608db 100644 --- a/arch/arm/boot/dts/omap4.dtsi +++ b/arch/arm/boot/dts/omap4.dtsi @@ -106,6 +106,8 @@ ti,hwmods = counter_32k;

Re: [PATCH] ARM: smp: Allow real broadcast device selection instead of always dummy

On 03/14/13 03:28, Mark Rutland wrote: On Thu, Mar 14, 2013 at 07:45:14AM +, Santosh Shilimkar wrote: On Wednesday 13 March 2013 09:48 PM, Mark Rutland wrote: On Wed, Mar 13, 2013 at 03:44:03PM +, Santosh Shilimkar wrote: On Wednesday 13 March 2013 05:55 PM, Mark Rutland wrote: I do

Re: [PATCH 1/2] clk: divider: prepare for minimum divider

On 01/22/13 08:39, Afzal Mohammed wrote: diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c index a9204c6..0b34992 100644 --- a/drivers/clk/clk-divider.c +++ b/drivers/clk/clk-divider.c @@ -236,7 +236,7 @@ EXPORT_SYMBOL_GPL(clk_divider_ops); static struct clk

Re: BUG: spinlock bad magic on CPU#0 on BeagleBone

On 12/19/12 08:53, Paul Walmsley wrote: On Wed, 19 Dec 2012, Bedia, Vaibhav wrote: Current mainline on Beaglebone using the omap2plus_defconfig + 3 build fixes is triggering a BUG() ... [0.109688] Security Framework initialized [0.109889] Mount-cache hash table entries: 512 [

Re: BUG: spinlock bad magic on CPU#0 on BeagleBone

On 12/19/2012 8:48 PM, Bedia, Vaibhav wrote: I tried out 3 variants of AM335x boards - 2 of these (BeagleBone and EVM) have DDR2 and 1 has DDR3 (EVM-SK). The BUG is triggered on all of these at the same point. With Stephen's change I don't see this on any of the board variants :) New

Re: BUG: spinlock bad magic on CPU#0 on BeagleBone

On 12/19/2012 10:44 PM, Bedia, Vaibhav wrote: On Thu, Dec 20, 2012 at 11:55:24, Stephen Boyd wrote: On 12/19/2012 8:48 PM, Bedia, Vaibhav wrote: I tried out 3 variants of AM335x boards - 2 of these (BeagleBone and EVM) have DDR2 and 1 has DDR3 (EVM-SK). The BUG is triggered on all

[PATCH] lib: atomic64: Initialize locks statically to fix early users

-by: Vaibhav Bedia vaibhav.be...@ti.com Tested-by: Vaibhav Bedia vaibhav.be...@ti.com Cc: Eric W. Biederman ebied...@xmission.com Signed-off-by: Stephen Boyd sb...@codeaurora.org --- Sorry Andrew, I couldn't find a maintainer of this file so I am picking on you. lib/atomic64.c | 17

  1   2   >