Re: [PATCH 09/19] ARM: dts: am335x: replace gpio-key,wakeup with wakeup-source property

2015-12-15 Thread Sudeep Holla
On 21/10/15 11:10, Sudeep Holla wrote: Though the keyboard driver for GPIO buttons(gpio-keys) will continue to check for/support the legacy "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup source, "wakeup-source" is the new standard binding. This patch

Re: [PATCH 15/19] ARM: dts: omap: replace legacy *,wakeup property with wakeup-source

2015-12-15 Thread Sudeep Holla
On 21/10/15 11:10, Sudeep Holla wrote: Though the keyboard and other driver will continue to support the legacy "gpio-key,wakeup", "linux,wakeup" boolean property to enable the wakeup source, "wakeup-source" is the new standard binding. This patch replaces al

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

2015-12-04 Thread Sudeep Holla
On 04/12/15 16:19, Grygorii Strashko wrote: On 12/04/2015 05:44 PM, Sudeep Holla wrote: On 04/12/15 15:40, Tony Lindgren wrote: * Tony Lindgren [151203 13:41]: * Sudeep Holla [151203 11:00]: I have added irq_set_irq_wake(pcs_soc->irq, state) in pcs_irq_set_wake which ensures i

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

2015-12-04 Thread Sudeep Holla
Hi Tony, On 04/12/15 15:40, Tony Lindgren wrote: * Tony Lindgren [151203 13:41]: * Sudeep Holla [151203 11:00]: I have added irq_set_irq_wake(pcs_soc->irq, state) in pcs_irq_set_wake which ensures it's marked for wakeup. Hmm well see the error I pasted in this thread, maybe that

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

2015-12-04 Thread Sudeep Holla
On 04/12/15 15:59, Grygorii Strashko wrote: Sorry, I can't test it right now :( Potential fix below: I had posted similar patch a while ago which Tony rejected. I might have made a mistake of not putting them together, though they were part of the same series[1], patch 12 and 16 diff --git

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

2015-12-04 Thread Sudeep Holla
On 04/12/15 15:40, Tony Lindgren wrote: * Tony Lindgren [151203 13:41]: * Sudeep Holla [151203 11:00]: I have added irq_set_irq_wake(pcs_soc->irq, state) in pcs_irq_set_wake which ensures it's marked for wakeup. Hmm well see the error I pasted in this thread, maybe that provi

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

2015-12-04 Thread Sudeep Holla
On 04/12/15 11:18, Grygorii Strashko wrote: On 12/04/2015 12:54 PM, Sudeep Holla wrote: Hi Grygorii, On 04/12/15 10:44, Grygorii Strashko wrote: On 12/03/2015 11:37 PM, Tony Lindgren wrote: [...] And these both need to be applied together when we have a fix for the above as otherwise

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

2015-12-04 Thread Sudeep Holla
Hi Grygorii, On 04/12/15 10:44, Grygorii Strashko wrote: On 12/03/2015 11:37 PM, Tony Lindgren wrote: [...] And these both need to be applied together when we have a fix for the above as otherwise we'll get the lock recursion Sudeep mentioned in patch 2/2. Most probably below diff will fi

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

2015-12-03 Thread Sudeep Holla
On 03/12/15 18:13, Tony Lindgren wrote: * Linus Walleij [151201 06:07]: On Fri, Nov 27, 2015 at 6:21 PM, Sudeep Holla wrote: From: Sudeep Holla The IRQF_NO_SUSPEND flag is used to identify the interrupts that should be left enabled so as to allow them to work as expected during the

[PATCH 15/19] ARM: dts: omap: replace legacy *,wakeup property with wakeup-source

2015-10-21 Thread Sudeep Holla
ed "wakeup-source" property in order to avoid any futher copy-paste duplication. Cc: "Benoît Cousson" Cc: Tony Lindgren Cc: linux-omap@vger.kernel.org Signed-off-by: Sudeep Holla --- arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts | 8 ++--- arch/arm/boot/dts/omap3-bea

[PATCH 09/19] ARM: dts: am335x: replace gpio-key,wakeup with wakeup-source property

2015-10-21 Thread Sudeep Holla
quot; with the unified "wakeup-source" property in order to avoid any futher copy-paste duplication. Cc: "Benoît Cousson" Cc: Tony Lindgren Cc: linux-omap@vger.kernel.org Signed-off-by: Sudeep Holla --- arch/arm/boot/dts/am335x-evm.dts| 4 ++-- arch/arm/boot/dts/

Re: [PATCH 12/17] ARM: OMAP2+: remove misuse of IRQF_NO_SUSPEND flag

2015-10-13 Thread Sudeep Holla
On 13/10/15 15:53, Tony Lindgren wrote: * Sudeep Holla [151013 03:46]: On 12/10/15 21:28, Tony Lindgren wrote: * Tony Lindgren [151012 13:27]: * Sudeep Holla [150921 08:52]: The IRQF_NO_SUSPEND flag is used to identify the interrupts that should be left enabled so as to allow them to

Re: [PATCH 12/17] ARM: OMAP2+: remove misuse of IRQF_NO_SUSPEND flag

2015-10-13 Thread Sudeep Holla
On 12/10/15 21:28, Tony Lindgren wrote: * Tony Lindgren [151012 13:27]: * Sudeep Holla [150921 08:52]: The IRQF_NO_SUSPEND flag is used to identify the interrupts that should be left enabled so as to allow them to work as expected during the suspend-resume cycle, but doesn't guarantee

[PATCH 12/17] ARM: OMAP2+: remove misuse of IRQF_NO_SUSPEND flag

2015-09-21 Thread Sudeep Holla
akeup. This patch removes the use of IRQF_NO_SUSPEND flags replacing it with enable_irq_wake instead. Cc: Tony Lindgren Cc: Kevin Hilman Cc: linux-omap@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Sudeep Holla --- arch/arm/mach-omap2/mux.c| 4 ++-- arch/arm/mach-

Re: [PATCH] ARM: Remove __ref on hotplug cpu die path

2015-09-15 Thread Sudeep Holla
Kumar Cc: Shiraz Hashim Cc: Stephen Warren Cc: Thierry Reding Cc: Alexandre Courbot Cc: Linus Walleij Cc: Sudeep Holla Cc: Lorenzo Pieralisi Cc: Will Deacon Cc: Mark Rutland Cc: Cc: Cc: Cc: Signed-off-by: Stephen Boyd --- This patch can be broken up into per-SoC if desired. [...]

Re: [PATCH v2 6/6] irqchip: crossbar: fix irq masking at suspend

2015-08-13 Thread Sudeep Holla
On 13/08/15 11:17, Grygorii Strashko wrote: On 08/13/2015 12:30 PM, Sudeep Holla wrote: On 12/08/15 18:46, Grygorii Strashko wrote: All ARM GIC IRQs have to masked during suspend if they are not wakeup source. Now this is not happen, since switching to use IRQ domain hierarchy, because

Re: [PATCH v2 2/6] genirq: fix irqchip_set_wake_parent if IRQCHIP_SKIP_SET_WAKE

2015-08-13 Thread Sudeep Holla
On 13/08/15 10:51, Grygorii Strashko wrote: On 08/13/2015 11:54 AM, Sudeep Holla wrote: On 12/08/15 18:45, Grygorii Strashko wrote: [...] diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c index 6de638b..bdb1b9d 100644 --- a/kernel/irq/chip.c +++ b/kernel/irq/chip.c @@ -1024,6 +1024,10

Re: [PATCH v2 6/6] irqchip: crossbar: fix irq masking at suspend

2015-08-13 Thread Sudeep Holla
On 12/08/15 18:46, Grygorii Strashko wrote: All ARM GIC IRQs have to masked during suspend if they are not wakeup source. Now this is not happen, since switching to use IRQ domain hierarchy, because suspend_device_irq() only checks flags in the last IRQ chip in hierarchy for IRQCHIP_MASK_ON_SUS

Re: [PATCH v2 3/6] genirq: introduce irq_chip_set_type_parent() helper

2015-08-13 Thread Sudeep Holla
On 12/08/15 18:45, Grygorii Strashko wrote: It's expected to use this helper when the current domain doesn't implement .irq_set_type(), but expect the parent to do so. Signed-off-by: Grygorii Strashko --- include/linux/irq.h | 1 + kernel/irq/chip.c | 20 2 files

Re: [PATCH v2 2/6] genirq: fix irqchip_set_wake_parent if IRQCHIP_SKIP_SET_WAKE

2015-08-13 Thread Sudeep Holla
On 12/08/15 18:45, Grygorii Strashko wrote: The irqchip_set_wake_parent should not fail if IRQ chip specifies IRQCHIP_SKIP_SET_WAKE. Otherwise, IRQ wakeup configuration can't be propagated properly through IRQ domains hierarchy. In case of TI OMAP DRA7 the issue reproduced with following confi