Re: [RFC PATCH] ARM: OMAP2+: clockdomain: Reintroduce SW_SLEEP Support (fwd)

2014-02-19 Thread Vaibhav Bedia
On Wed, Feb 19, 2014 at 2:22 PM, Paul Walmsley wrote: > On Wed, 19 Feb 2014, Vaibhav Bedia wrote: > >> On Wed, Feb 19, 2014 at 1:25 PM, Paul Walmsley wrote: >> > >> > Just FYI. Queued for v3.15 unless someone complains. >> > >> >> No complains

Re: [RFC PATCH] ARM: OMAP2+: clockdomain: Reintroduce SW_SLEEP Support (fwd)

2014-02-19 Thread Vaibhav Bedia
On Wed, Feb 19, 2014 at 1:25 PM, Paul Walmsley wrote: > > Just FYI. Queued for v3.15 unless someone complains. > No complains but i wanted to point out that with some additional changes it's possible to consolidate AM335x (and AM437x) very nicely with the rest of OMAP4+ PRM/CM code. I had poste

CONFIG_PREEMPT in omap2plus_defconfig

2014-02-16 Thread Vaibhav Bedia
Hello, Is there a specific reason why CONFIG_PREEMPT is not enabled in omap2plus_defconfig? Regards, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info

[PATCH 1/1] ARM: OMAP5: Fix reboot handling

2014-02-16 Thread Vaibhav Bedia
Use the correct register offset for issuing the reset command in OMAP5. Since dev_inst is set dynamically OMAP4 should not be affected by this change. Signed-off-by: Vaibhav Bedia --- Applies on top of v3.14-rc3 arch/arm/mach-omap2/prminst44xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [rtc-linux] Re: [PATCH v4 0/4] pm: Add power off control

2013-11-23 Thread Vaibhav Bedia
On Fri, Nov 22, 2013 at 2:50 PM, Ezequiel Garcia wrote: [...] > > And why specifically *2* seconds, instead of *1* or *33* ? > > Sounds a bit like voodoo magic on this side :-) Consider the scenario where the actual time is 00:00:01.95 secs. Due to the 1 second resolution of the RTC, reading the

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Vaibhav Bedia
Hi Grygorii :) On Thu, Nov 7, 2013 at 11:27 AM, Grygorii Strashko wrote: > On 11/07/2013 05:34 PM, Nishanth Menon wrote: >> >> On 10/30/2013 03:21 PM, Daniel Mack wrote: >> [...] >>> >>> diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c >>> index 8e1a024..f15cdb9 100644 >>> --- a/arch/

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Vaibhav Bedia
Hi Nishanth :) On Thu, Nov 7, 2013 at 10:48 AM, Nishanth Menon wrote: > On 11/07/2013 09:36 AM, Daniel Mack wrote: >> On 11/07/2013 04:18 PM, Nishanth Menon wrote: >>> Tested this on a vendor V3.12 tag based kernel: >>> >>> Test patch: http://pastebin.com/AmnktQ7B >>> test: echo -n "1">/sys/power/

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Vaibhav Bedia
Hi Joel, On Wed, Nov 6, 2013 at 12:36 PM, Joel Fernandes wrote: > Hi Vaibhav, > > On 10/31/2013 05:25 PM, Vaibhav Bedia wrote: >> Hi Daniel, >> >> On Wed, Oct 30, 2013 at 4:21 PM, Daniel Mack wrote: >> [...] >>> + >>> +static SIMPLE_DEV_

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-10-31 Thread Vaibhav Bedia
Hi Daniel, On Wed, Oct 30, 2013 at 4:21 PM, Daniel Mack wrote: [...] > + > +static SIMPLE_DEV_PM_OPS(edma_pm_ops, edma_pm_suspend, edma_pm_resume); > + > static struct platform_driver edma_driver = { > .driver = { > .name = "edma", > + .pm = &edma_pm_o

Re: [PATCH V6 02/15] ARM: OMAP2+: AM33XX: add lateinit hook for calling pm late init

2013-10-10 Thread Vaibhav Bedia
Hi Joel. On Thu, Oct 10, 2013 at 1:32 AM, Joel Fernandes wrote: > On 10/09/2013 06:24 PM, Nishanth Menon wrote: >> Call OMAP2+ generic lateinit hook from AM specific late init hook. >> This allows the generic late initializations such as cpufreq hooks >> to be active. >> >> Cc: Benoit Cousson >>

Re: [PATCH v2 01/13] ARM: OMAP2+: CM: reintroduce SW_SLEEP for OMAP4

2013-08-30 Thread Vaibhav Bedia
On Wed, Aug 21, 2013 at 3:13 AM, Rajendra Nayak wrote: [...] >> +/** >> + * omap4_cminst_clkdm_force_sleep - try to put a clockdomain to idle >> + * @part: PRCM partition ID that the clockdomain registers exist in >> + * @inst: CM instance register offset (*_INST macro) >> + * @cdoffs: Clockdomain

Re: [PATCH v4 0/4] ARM: OMAP2+: AM33XX: VDD CORE OPP50 support

2013-08-30 Thread Vaibhav Bedia
On Thu, Aug 29, 2013 at 5:33 PM, Kevin Hilman wrote: [...] >>> >>> Maybe I'm getting confused, but the more you talk about the linux and >>> the firmware doing the same code, the more I think the firmware is >>> (trying) to do too much. If this is going to be understandable (and >>> maintainable)

Re: [PATCHv3 8/9] ARM: OMAP2+: AM33XX: Basic suspend resume support

2013-08-30 Thread Vaibhav Bedia
On Tue, Aug 27, 2013 at 5:45 PM, Kevin Hilman wrote: [...] > > Looking closer at this code as I'm trying to fully get my head around > all the IPC, I have some more comments. > > I think the split between pm33xx.c and the M3 driver is still confusing > here. For example, am33xx_ping_wkup_m3(), >

Re: [PATCHv3 8/9] ARM: OMAP2+: AM33XX: Basic suspend resume support

2013-08-30 Thread Vaibhav Bedia
(picking up an old thread, again) On Thu, Aug 8, 2013 at 7:04 PM, Kevin Hilman wrote: > > I disagree here. I'm a firmware minimalist, and hiding bugs like this > in the firmware is wrong when Linux is otherwise managing these devices. > It also imposes criteria on the firmware of future SoCs tha

Re: [PATCH v4 0/4] ARM: OMAP2+: AM33XX: VDD CORE OPP50 support

2013-08-29 Thread Vaibhav Bedia
MPU >>>>> side. But also, because the M3 is reset every suspend sequence, this >>>>> becomes rather heavy to do from the M3. >>>> >>>> After the feedback Vaibhav Bedia received on v2 of his suspend/resume >>>> patchset for am33

[RFC 4/9] ARM: OMAP4: PRM: Get rid of hardcoded offsets

2013-07-02 Thread Vaibhav Bedia
Instead of hardcoded offsets of PWRSTCTRL and PWRSTST use the offsets from the pwrdomain data. This helps us in reusing the same code across OMAP4 and AM335x. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/prm44xx.c | 30 -- 1 file changed, 16 insertions(+), 14

[RFC 3/9] ARM: OMAP2+: AM335X: Add a constant PRCM_PARITION for the pwrdomains

2013-07-02 Thread Vaibhav Bedia
OMAP4 style PRM, CM APIs expect the pwrdomains to specify a prcm_partition. Introduce a PRCM_PARTITION for the AM335x pwrdomains so that we can eventually consolidate the code. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/powerdomains33xx_data.c | 6 ++ arch/arm/mach-omap2/prm33xx.h

[RFC 1/9] ARM: OMAP2+: AM335X: Add a constant CM_INST for all the clkdomains

2013-07-02 Thread Vaibhav Bedia
OMAP4 style PRM, CM APIs expect the clkdomains to specify a cm_inst. Introduce a CM_INST for the AM335x clkdomains so that we can eventually consolidate the code. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/clockdomains33xx_data.c | 18 ++ arch/arm/mach-omap2/cm33xx.h

[RFC 5/9] ARM: OMAP4: Add offsets for pwrstctrl and pwrstst

2013-07-02 Thread Vaibhav Bedia
k two additional fields pwrstctrl_offs and pwrstst_offs were introduced in the pwrdomain data structure. To enable consolidation of AM335x and OMAP4 lowlevel APIs add in the appropriate offsets to the OMAP4 pwrdomains. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/powerdomains44xx_data.c

[RFC 6/9] ARM: OMAP4: CM code: Remove the check for non-zero clkctrl_offs

2013-07-02 Thread Vaibhav Bedia
the OMAP4 API to avoid any regressions on AM335x when it switches over to these APIs. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/cminst44xx.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/arch/arm/mach-omap2/cminst44xx.c b/arch/arm/mach-omap2/cminst44xx.c index 2d1d4ef..4ec9

[RFC 8/9] ARM: OMAP2+: AM335x: Migrate to OMAP4 PRM/CM APIs

2013-07-02 Thread Vaibhav Bedia
With all the minor issues addressed in previous patches we can now safely migrate over AM335x to OMAP4 APIs and get rid of the AM335x version of the same. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/cminst44xx.c | 7 ++ arch/arm/mach-omap2/io.c | 3 + arch/arm/mach-omap2

[RFC 0/9] Consolidate AM335x and OMAP4 PRM/CM APIs

2013-07-02 Thread Vaibhav Bedia
be reworked since the OMAP4 code is moving to a different file. Vaibhav Bedia (9): ARM: OMAP2+: AM335X: Add a constant CM_INST for all the clkdomains ARM: OMAP2+: CM code: Reintroduce SW_SLEEP for OMAP4 class of devices ARM: OMAP2+: AM335X: Add a constant PRCM_PARITION for the pwrdomains

[RFC 2/9] ARM: OMAP2+: CM code: Reintroduce SW_SLEEP for OMAP4 class of devices

2013-07-02 Thread Vaibhav Bedia
API consistent with what the comments states. While here also fixup a trivial typo in the comment. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/cminst44xx.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/cminst44xx.c b/arch/arm

[RFC 7/9] ARM: OMAP4: Generalize reset handling API

2013-07-02 Thread Vaibhav Bedia
Reset status bits on AM335x have different masks and register is not consistent across powerdomains. Generalize the OMAP4 reset handling code to take care of these. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/omap_hwmod.c | 7 +++ arch/arm/mach-omap2/prminst44xx.c | 27

[RFC 9/9] ARM: OMAP2+: AM33XX: Get rid of custom PRM, CM APIs

2013-07-02 Thread Vaibhav Bedia
Now that we have migrated AM335x over to use OMAP4 style PRM, CM APIs we can delete the custom APIs To avoid build breakage the reset function is reimplemented in the same patch. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/Makefile | 3 +- arch/arm/mach-omap2/am33xx

[PATCH v3 5/9] ARM: OMAP2+: AM33XX: hwmod: Fixup cpgmac0 hwmod entry

2013-01-29 Thread Vaibhav Bedia
code accessing the wrong memory address for idle and standby operations. Fix this by removing the ADDR_TYPE_RT flag from the 1st memory region in CPGMAC0 hwmod entry. Signed-off-by: Vaibhav Bedia Acked-by: Peter Korsgaard --- v3: Add Peter's Acked-by v2: No change arch/arm/

[PATCH v3 2/9] ARM: OMAP2+: AM33XX: CM/PRM: Use __ASSEMBLER__ macros in header files

2013-01-29 Thread Vaibhav Bedia
This is necessary to ensure that macros declared here can be reused from assembly files. Signed-off-by: Vaibhav Bedia Acked-by: Santosh Shilimkar Acked-by: Peter Korsgaard --- v3: Add Peter's Acked-by v2: No change arch/arm/mach-omap2/cm33xx.h | 2 ++ arch/arm/mach-omap2/prm33xx.h | 2

[PATCH v3 7/9] ARM: OMAP2+: AM33XX: Update the hardreset API

2013-01-29 Thread Vaibhav Bedia
WKUP-M3 has a reset status bit (RM_WKUP_STST.WKUP_M3_LRST) Update the hardreset API to ensure that the reset line properly deasserted. Signed-off-by: Vaibhav Bedia Acked-by: Santosh Shilimkar Acked-by: Peter Korsgaard --- v3: Add Peter's Acked-by v2: No change arch/arm/mach-

[PATCH v3 4/9] ARM: OMAP2+: AM33XX: hwmod: Update TPTC0 hwmod with the right flags

2013-01-29 Thread Vaibhav Bedia
Third Party Transfer Controller (TPTC0) needs to be idled and put to standby under SW control. Add the appropriate flags in the TPTC0 hwmod entry. Signed-off-by: Vaibhav Bedia Acked-by: Santosh Shilimkar Acked-by: Peter Korsgaard --- v3: Add Peter's Acked-by v2: Drop unnecessary parens

[PATCH v3 8/9] ARM: DTS: AM33XX: Add nodes for OCMC RAM and WKUP-M3

2013-01-29 Thread Vaibhav Bedia
the clock to OCMC RAM as part of the suspend process add the no_idle_on_suspend flag. Signed-off-by: Vaibhav Bedia Acked-by: Santosh Shilimkar Acked-by: Peter Korsgaard --- v3: Update the compatible field as mentioned by Peter and his Acked-by v2: Add reg property arch/arm/boot/dts/am33xx.dtsi

[PATCH v3 3/9] ARM: OMAP2+: AM33XX: hwmod: Register OCMC RAM hwmod

2013-01-29 Thread Vaibhav Bedia
OCMC RAM lies in the PER power domain and this memory support retention. Signed-off-by: Vaibhav Bedia Acked-by: Santosh Shilimkar Acked-by: Peter Korsgaard --- v3: Add Peter's Acked-by v2: No change arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 47 +- 1

[PATCH v3 9/9] ARM: OMAP2+: AM33XX: control: Add some control module registers and APIs

2013-01-29 Thread Vaibhav Bedia
Add minimal APIs for writing to the IPC and the M3_TXEV registers in the Control module. These will be used in a subsequent patch which adds suspend-resume support for AM33XX. Signed-off-by: Vaibhav Bedia Acked-by: Santosh Shilimkar Acked-by: Peter Korsgaard --- v3: Add Peter's Acked-by v

[PATCH v3 6/9] ARM: OMAP2+: AM33XX: hwmod: Update the WKUP-M3 hwmod with reset status bit

2013-01-29 Thread Vaibhav Bedia
WKUP-M3 has a reset status bit (RM_WKUP_STST.WKUP_M3_LRST) Update the WKUP-M3 hwmod data to reflect the same. Signed-off-by: Vaibhav Bedia Acked-by: Peter Korsgaard --- v3: Add Peter's Acked-by v2: No change arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 1 + 1 file changed, 1 inse

[PATCH v3 1/9] ARM: OMAP2+: AM33XX: CM: Get rid of unnecessary header inclusions

2013-01-29 Thread Vaibhav Bedia
cm33xx.h unnecessarily includes a lot of header files. Get rid of these and directly include "iomap.h" which is needed to keep things compiling. Signed-off-by: Vaibhav Bedia Acked-by: Santosh Shilimkar Acked-by: Peter Korsgaard --- v3: Add Peter's Acked-by v2: Reword the chang

[PATCH v3 0/9] ARM: OMAP2+: AM33XX: Misc fixes/updates

2013-01-29 Thread Vaibhav Bedia
ess the comments received from Sergei Shtylyov and Peter Korsgaard. v2->v3: Address an additional comment from Peter Korgaard and add his Acked-by to the patches Regards, Vaibhav [1] http://marc.info/?l=linux-arm-kernel&m=135698501821074&w=2 Vaibhav Bedia (9): ARM: OMAP2+: AM33XX:

[PATCH v2 9/9] ARM: OMAP2+: AM33XX: control: Add some control module registers and APIs

2013-01-28 Thread Vaibhav Bedia
Add minimal APIs for writing to the IPC and the M3_TXEV registers in the Control module. These will be used in a subsequent patch which adds suspend-resume support for AM33XX. Signed-off-by: Vaibhav Bedia Acked-by: Santosh Shilimkar --- v2: No change arch/arm/mach-omap2/control.c | 20

[PATCH v2 3/9] ARM: OMAP2+: AM33XX: hwmod: Register OCMC RAM hwmod

2013-01-28 Thread Vaibhav Bedia
OCMC RAM lies in the PER power domain and this memory support retention. Signed-off-by: Vaibhav Bedia Acked-by: Santosh Shilimkar --- v2: No change arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 47 +- 1 file changed, 27 insertions(+), 20 deletions(-) diff --git a

[PATCH v2 7/9] ARM: OMAP2+: AM33XX: Update the hardreset API

2013-01-28 Thread Vaibhav Bedia
WKUP-M3 has a reset status bit (RM_WKUP_STST.WKUP_M3_LRST) Update the hardreset API to ensure that the reset line properly deasserted. Signed-off-by: Vaibhav Bedia Acked-by: Santosh Shilimkar --- v2: No change arch/arm/mach-omap2/omap_hwmod.c | 5 + arch/arm/mach-omap2/prm33xx.c| 11

[PATCH v2 8/9] ARM: DTS: AM33XX: Add nodes for OCMC RAM and WKUP-M3

2013-01-28 Thread Vaibhav Bedia
the clock to OCMC RAM as part of the suspend process add the no_idle_on_suspend flag. Signed-off-by: Vaibhav Bedia Acked-by: Santosh Shilimkar --- v2: Add reg property arch/arm/boot/dts/am33xx.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts/am33xx.dtsi

[PATCH v2 5/9] ARM: OMAP2+: AM33XX: hwmod: Fixup cpgmac0 hwmod entry

2013-01-28 Thread Vaibhav Bedia
code accessing the wrong memory address for idle and standby operations. Fix this by removing the ADDR_TYPE_RT flag from the 1st memory region in CPGMAC0 hwmod entry. Signed-off-by: Vaibhav Bedia --- v2: No change arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 1 - 1 file changed, 1 deletion(-)

[PATCH v2 4/9] ARM: OMAP2+: AM33XX: hwmod: Update TPTC0 hwmod with the right flags

2013-01-28 Thread Vaibhav Bedia
Third Party Transfer Controller (TPTC0) needs to be idled and put to standby under SW control. Add the appropriate flags in the TPTC0 hwmod entry. Signed-off-by: Vaibhav Bedia Acked-by: Santosh Shilimkar --- v2: Drop unnecessary parens arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 1 + 1 file

[PATCH v2 1/9] ARM: OMAP2+: AM33XX: CM: Get rid of unnecessary header inclusions

2013-01-28 Thread Vaibhav Bedia
cm33xx.h unnecessarily includes a lot of header files. Get rid of these and directly include "iomap.h" which is needed to keep things compiling. Signed-off-by: Vaibhav Bedia Acked-by: Santosh Shilimkar --- v2: Reword the changelog arch/arm/mach-omap2/cm33xx.h | 7 +-- 1 file

[PATCH v2 2/9] ARM: OMAP2+: AM33XX: CM/PRM: Use __ASSEMBLER__ macros in header files

2013-01-28 Thread Vaibhav Bedia
This is necessary to ensure that macros declared here can be reused from assembly files. Signed-off-by: Vaibhav Bedia Acked-by: Santosh Shilimkar --- v2: No change arch/arm/mach-omap2/cm33xx.h | 2 ++ arch/arm/mach-omap2/prm33xx.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/arch

[PATCH v2 0/9] ARM: OMAP2+: AM33XX: Misc fixes/updates

2013-01-28 Thread Vaibhav Bedia
Shtylyov and Peter Korsgaard on the earlier patchset [2]. These patches apply on top of v3.8-rc5 Regards, Vaibhav [1] http://marc.info/?l=linux-arm-kernel&m=135698501821074&w=2 [2] http://marc.info/?l=linux-omap&m=135849360005657&w=2 Vaibhav Bedia (9): ARM: OMAP2+: AM33XX

[PATCH v2 6/9] ARM: OMAP2+: AM33XX: hwmod: Update the WKUP-M3 hwmod with reset status bit

2013-01-28 Thread Vaibhav Bedia
WKUP-M3 has a reset status bit (RM_WKUP_STST.WKUP_M3_LRST) Update the WKUP-M3 hwmod data to reflect the same. Signed-off-by: Vaibhav Bedia --- v2: No change arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c

[PATCH 5/9] ARM: OMAP2+: AM33XX: hwmod: Fixup cpgmac0 hwmod entry

2013-01-17 Thread Vaibhav Bedia
code accessing the wrong memory address for idle and standby operations. Fix this by removing the ADDR_TYPE_RT flag from the 1st memory region in CPGMAC0 hwmod entry. Signed-off-by: Vaibhav Bedia --- Change from RFC version: No change arch/arm/mach-omap2/omap_hwmod_33xx_data.c |1

[PATCH 9/9] ARM: OMAP2+: AM33XX: control: Add some control module registers and APIs

2013-01-17 Thread Vaibhav Bedia
Add minimal APIs for writing to the IPC and the M3_TXEV registers in the Control module. These will be used in a subsequent patch which adds suspend-resume support for AM33XX. Signed-off-by: Vaibhav Bedia Acked-by: Santosh Shilimkar --- Change from RFC version: No change arch/arm/mach

[PATCH 7/9] ARM: OMAP2+: AM33XX: Update the hardreset API

2013-01-17 Thread Vaibhav Bedia
WKUP-M3 has a reset status bit (RM_WKUP_STST.WKUP_M3_LRST) Update the hardreset API to ensure that the reset line properly deasserted. Signed-off-by: Vaibhav Bedia Acked-by: Santosh Shilimkar --- Change from RFC version: No change arch/arm/mach-omap2/omap_hwmod.c |5 + arch

[PATCH 0/9] ARM: OMAP2+: AM33XX: Misc fixes/updates

2013-01-17 Thread Vaibhav Bedia
[1] http://marc.info/?l=linux-arm-kernel&m=135698501821074&w=2 Vaibhav Bedia (9): ARM: OMAP2+: AM33XX: CM: Get rid of unncessary header inclusions ARM: OMAP2+: AM33XX: CM/PRM: Use __ASSEMBLER__ macros in header files ARM: OMAP2+: AM33XX: hwmod: Register OCMC RAM hwmod ARM: OMAP2+

[PATCH 1/9] ARM: OMAP2+: AM33XX: CM: Get rid of unncessary header inclusions

2013-01-17 Thread Vaibhav Bedia
Some of the included header files are not needed so remove them. Signed-off-by: Vaibhav Bedia Acked-by: Santosh Shilimkar --- Change from RFC version: No change arch/arm/mach-omap2/cm33xx.h |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach

[PATCH 8/9] ARM: DTS: AM33XX: Add nodes for OCMC RAM and WKUP-M3

2013-01-17 Thread Vaibhav Bedia
the clock to OCMC RAM as part of the suspend process add the no_idle_on_suspend flag. Signed-off-by: Vaibhav Bedia Acked-by: Santosh Shilimkar --- Change from RFC version: No change arch/arm/boot/dts/am33xx.dtsi | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff

[PATCH 6/9] ARM: OMAP2+: AM33XX: hwmod: Update the WKUP-M3 hwmod with reset status bit

2013-01-17 Thread Vaibhav Bedia
WKUP-M3 has a reset status bit (RM_WKUP_STST.WKUP_M3_LRST) Update the WKUP-M3 hwmod data to reflect the same. Signed-off-by: Vaibhav Bedia --- Change from RFC version: No change arch/arm/mach-omap2/omap_hwmod_33xx_data.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff

[PATCH 2/9] ARM: OMAP2+: AM33XX: CM/PRM: Use __ASSEMBLER__ macros in header files

2013-01-17 Thread Vaibhav Bedia
This is necessary to ensure that macros declared here can be reused from assembly files. Signed-off-by: Vaibhav Bedia Acked-by: Santosh Shilimkar --- Change from RFC version: Get rid of extra lines arch/arm/mach-omap2/cm33xx.h |2 ++ arch/arm/mach-omap2/prm33xx.h |2 ++ 2

[PATCH 4/9] ARM: OMAP2+: AM33XX: hwmod: Update TPTC0 hwmod with the right flags

2013-01-17 Thread Vaibhav Bedia
Third Party Transfer Controller (TPTC0) needs to be idled and put to standby under SW control. Add the appropriate flags in the TPTC0 hwmod entry. Signed-off-by: Vaibhav Bedia Acked-by: Santosh Shilimkar --- Change from RFC version: Clarify TPTC in the changelog arch/arm/mach-omap2

[PATCH 3/9] ARM: OMAP2+: AM33XX: hwmod: Register OCMC RAM hwmod

2013-01-17 Thread Vaibhav Bedia
OCMC RAM lies in the PER power domain and this memory support retention. Signed-off-by: Vaibhav Bedia Acked-by: Santosh Shilimkar --- Change from RFC version: No change arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 47 1 files changed, 27 insertions

[RFC v2 03/18] memory: emif: Move EMIF related header file to include/linux/

2012-12-31 Thread Vaibhav Bedia
rrent OMAP PM framework the PM code resides under arch/arm/mach-omap2/. To enable reuse of the register defines move the emif header file to include/linux so that both the EMIF driver and the AM33XX PM code can benefit. Signed-off-by: Vaibhav Bedia Cc: Santosh Shilimkar Cc: Benoit Cousson Cc: A

[RFC v2 15/18] ARM: OMAP2+: AM33XX: Add assembly code for PM operations

2012-12-31 Thread Vaibhav Bedia
state of the IOs to LVCMOS mode and enabling pull downs on the IOs to reduce leakage in low power state. Signed-off-by: Vaibhav Bedia Cc: Santosh Shilimkar Cc: Kevin Hilman --- v1->v2: This is a new patch in the series to keep the assembly code additionl separate as me

[RFC v2 16/18] ARM: OMAP2+: AM33XX: Basic suspend resume support

2012-12-31 Thread Vaibhav Bedia
d sequence. The low level code in OCMC relocks the PLLs, enables access to external RAM and then jumps to the cpu_resume code of the kernel to finish the resume process. Signed-off-by: Vaibhav Bedia Cc: Tony Lingren Cc: Santosh Shilimkar Cc: Benoit Cousson Cc: Paul Walmsley Cc: Kevin Hilman

[RFC v2 17/18] ARM: OMAP2+: AM33XX: Select Mailbox when PM is enabled

2012-12-31 Thread Vaibhav Bedia
-resume support. Signed-off-by: Vaibhav Bedia Cc: Tony Lingren Cc: Santosh Shilimkar Cc: Benoit Cousson Cc: Paul Walmsley Cc: Kevin Hilman --- v1->v2: Update the Kconfig instead of the defconfig arch/arm/mach-omap2/Kconfig |4 +++- 1 files changed, 3 insertions(+), 1 deleti

[RFC v2 18/18] ARM: OMAP2+: AM33XX: Hookup AM33XX PM code into OMAP builds

2012-12-31 Thread Vaibhav Bedia
With all the requisite changes in place we can now enable basic PM support on AM33XX. This patch updates the various OMAP files to enable suspend-resume on AM33XX. Signed-off-by: Vaibhav Bedia Cc: Tony Lingren Cc: Santosh Shilimkar Cc: Benoit Cousson Cc: Paul Walmsley Cc: Kevin Hilman

[RFC v2 14/18] ARM: OMAP2+: AM33XX: control: Add some control module registers and APIs

2012-12-31 Thread Vaibhav Bedia
Add minimal APIs for writing to the IPC and the M3_TXEV registers in the Control module. These will be used in a subsequent patch which adds suspend-resume support for AM33XX. Signed-off-by: Vaibhav Bedia Cc: Tony Lingren Cc: Santosh Shilimkar Cc: Benoit Cousson Cc: Paul Walmsley Cc: Kevin

[RFC v2 13/18] ARM: OMAP2+: AM33XX: timer: Interchance clkevt and clksrc timers

2012-12-31 Thread Vaibhav Bedia
AM33XX so for now we go ahead with the interchange of the the timers. If at a later point of time we do come up with an approach which makes soc-idle possible on AM33XX, this can be revisited. Signed-off-by: Vaibhav Bedia Signed-off-by: Vaibhav Hiremath Cc: Tony Lingren Cc: Santosh Shilimkar Cc

[RFC v2 12/18] ARM: OMAP2+: timer: Add suspend-resume callbacks for clockevent device

2012-12-31 Thread Vaibhav Bedia
of clock event devices) introduced .suspend and .resume callbacks for clock event devices. Leverages these callbacks to have AM33XX clockevent timer which is in not in WKUP domain to behave properly across system suspend. Signed-off-by: Vaibhav Bedia Cc: Santosh Shilimkar Cc: Benoit Cousson Cc

[RFC v2 11/18] ARM: DTS: AM33XX: Add nodes for OCMC RAM and WKUP-M3

2012-12-31 Thread Vaibhav Bedia
the clock to OCMC RAM as part of the suspend process add the no_idle_on_suspend flag. Signed-off-by: Vaibhav Bedia Cc: Tony Lindgren Cc: Santosh Shilimkar Cc: Benoit Cousson Cc: Paul Walmsley Cc: Kevin Hilman Cc: Vaibhav Hiremath --- v1->v2: Add a proper changelog arch/arm/boot/

[RFC v2 10/18] ARM: OMAP2+: AM33XX: Update the hardreset API

2012-12-31 Thread Vaibhav Bedia
WKUP-M3 has a reset status bit (RM_WKUP_STST.WKUP_M3_LRST) Update the hardreset API to ensure that the reset line properly deasserted. Signed-off-by: Vaibhav Bedia Cc: Santosh Shilimkar Cc: Benoit Cousson Cc: Paul Walmsley Cc: Kevin Hilman Cc: Vaibhav Hiremath --- v1->v2: Addr

[RFC v2 08/18] ARM: OMAP2+: AM33XX: hwmod: Fixup cpgmac0 hwmod entry

2012-12-31 Thread Vaibhav Bedia
code accessing the wrong memory address for idle and standby operations. Fix this by removing the ADDR_TYPE_RT flag from the 1st memory region in CPGMAC0 hwmod entry. Signed-off-by: Vaibhav Bedia Cc: Santosh Shilimkar Cc: Benoit Cousson Cc: Paul Walmsley Cc: Kevin Hilman Cc: Vaibhav Hiremath -

[RFC v2 09/18] ARM: OMAP2+: AM33XX: hwmod: Update the WKUP-M3 hwmod with reset status bit

2012-12-31 Thread Vaibhav Bedia
WKUP-M3 has a reset status bit (RM_WKUP_STST.WKUP_M3_LRST) Update the WKUP-M3 hwmod data to reflect the same. Signed-off-by: Vaibhav Bedia Cc: Santosh Shilimkar Cc: Benoit Cousson Cc: Paul Walmsley Cc: Kevin Hilman Cc: Vaibhav Hiremath --- v1->v2: Change the patch order to keep

[RFC v2 07/18] ARM: OMAP2+: AM33XX: hwmod: Update TPTC0 hwmod with the right flags

2012-12-31 Thread Vaibhav Bedia
TPTC0 needs to be idled and put to standby under SW control. Add the appropriate flags in the TPTC0 hwmod entry. Signed-off-by: Vaibhav Bedia Cc: Santosh Shilimkar Cc: Benoit Cousson Cc: Paul Walmsley Cc: Kevin Hilman Cc: Vaibhav Hiremath --- v1->v2: No change arch/arm/mach-om

[RFC v2 05/18] ARM: OMAP2+: AM33XX: CM/PRM: Use __ASSEMBLER__ macros in header files

2012-12-31 Thread Vaibhav Bedia
This is necessary to ensure that macros declared here can be reused from assembly files. Signed-off-by: Vaibhav Bedia Cc: Santosh Shilimkar Cc: Paul Walmsley Cc: Benoit Cousson Cc: Kevin Hilman Cc: Vaibhav Hiremath --- v1->v2: Split out the header file changes in a separate pa

[RFC v2 06/18] ARM: OMAP2+: AM33XX: hwmod: Register OCMC RAM hwmod

2012-12-31 Thread Vaibhav Bedia
OCMC RAM lies in the PER power domain and this memory support retention. Signed-off-by: Vaibhav Bedia Cc: Santosh Shilimkar Cc: Benoit Cousson Cc: Paul Walmsley Cc: Kevin Hilman Cc: Vaibhav Hiremath --- v1->v2: Move out the OCMC hwmod code from #if 0 block based on Vaib

[RFC v2 04/18] ARM: OMAP2+: AM33XX: CM: Get rid of unncessary header inclusions

2012-12-31 Thread Vaibhav Bedia
Some of the included header files are not needed so remove them. Signed-off-by: Vaibhav Bedia Cc: Santosh Shilimkar Cc: Benoit Cousson Cc: Paul Walmsley Cc: Kevin Hilman Cc: Vaibhav Hiremath --- v1->v2: This is a new patch in the series based on Santosh's fee

[RFC v2 01/18] mailbox: OMAP2+: Add support for AM33XX

2012-12-31 Thread Vaibhav Bedia
Mailbox IP on AM33XX is the same as that present in OMAP4. The single instance of Mailbox IP on AM33XX contains 8 sub-modules and facilitates communication between MPU, PRUs and WKUP_M3. The first mailbox sub-module is assigned for communication between MPU and WKUP-M3. Signed-off-by: Vaibhav

[RFC v2 02/18] mailbox: Add an API for flushing the FIFO

2012-12-31 Thread Vaibhav Bedia
the mailbox code which the MPU can use to empty the FIFO by issuing a readback command. Signed-off-by: Vaibhav Bedia Cc: Santosh Shilimkar --- Note: This patch which will be slightly reworked once the mailbox driver changes are finalized. drivers/mailbox/mailbox-omap2.c | 19

[RFC v2 00/18] ARM: OMAP2+: AM33XX: Add suspend-resume support

2012-12-31 Thread Vaibhav Bedia
089&w=4 [3] http://arago-project.org/git/projects/?p=am33x-cm3.git;a=shortlog;h=refs/heads/next Vaibhav Bedia (18): mailbox: OMAP2+: Add support for AM33XX mailbox: Add an API for flushing the FIFO memory: emif: Move EMIF related header file to include/linux/ ARM: OMAP2+: AM33XX: CM

[PATCH 1/1] ARM: OMAP: Fix build breakage due to missing include in i2c.c

2012-12-18 Thread Vaibhav Bedia
laration of function 'omap_pm_set_max_mpu_wakeup_lat' make[1]: *** [arch/arm/mach-omap2/i2c.o] Error 1 ... Fix this by including the appropriate header file with the function prototype Reported-by: Fengguang Wu Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/i2c.c |1 +

[PATCH 1/1] ARM: OMAP: Fix build breakage due to missing include in i2c.c

2012-12-18 Thread Vaibhav Bedia
laration of function 'omap_pm_set_max_mpu_wakeup_lat' make[1]: *** [arch/arm/mach-omap2/i2c.o] Error 1 ... Fix this by including the appropriate header file with the function prototype Reported-by: Fengguang Wu Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/i2c.c |1 +

[PATCH 02/15] ARM: OMAP2+: mailbox: Add support for AM33XX

2012-11-02 Thread Vaibhav Bedia
Mailbox IP on AM33XX, is the same as that present in OMAP4. The single instance of Mailbox module contains 8 sub-modules and facilitates communication between MPU, PRUs and WKUP_M3. The first mailbox sub-module is assigned for communication between MPU and WKUP-M3. Signed-off-by: Vaibhav Bedia

[PATCH 11/15] ARM: OMAP: timer: Interchange clksrc and clkevt for AM33XX

2012-11-02 Thread Vaibhav Bedia
this, interchange the timers used as clocksource and clockevent for AM33XX. A subsequent patch will add suspend-resume support for the clockevent to ensure that there are no issues with timekeeping. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/timer.c |2 +- 1 files changed, 1

[PATCH 15/15] ARM: OMAP2+: AM33XX: Basic suspend resume support

2012-11-02 Thread Vaibhav Bedia
s, enables access to external RAM and then jumps to the cpu_resume code of the kernel to finish the resume process. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/Makefile|2 + arch/arm/mach-omap2/board-generic.c |1 + arch/arm/mach-omap2/common.h| 10 + arch/arm/

[PATCH 12/15] ARM: OMAP: timer: Add suspend-resume callbacks for clockevent device

2012-11-02 Thread Vaibhav Bedia
: Vaibhav Bedia --- arch/arm/mach-omap2/timer.c | 31 +++ 1 files changed, 31 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c index 6584ee0..e8781fd 100644 --- a/arch/arm/mach-omap2/timer.c +++ b/arch/arm/mach-omap2

[PATCH 04/15] ARM: OMAP2+: hwmod: Update the reset API for AM33XX

2012-11-02 Thread Vaibhav Bedia
WKUP-M3 has a reset status bit (RM_WKUP_STST.WKUP_M3_LRST) Update the hardreset API to take care of the same to ensure that the reset line properly deasserted. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/omap_hwmod.c |5 + arch/arm/mach-omap2/prm33xx.c| 15

[PATCH 06/15] ARM: OMAP2+: hwmod: Enable OCMCRAM registration in AM33XX

2012-11-02 Thread Vaibhav Bedia
The hwmod data for OCMCRAM in AM33XX was commented out. This data is needed by the power management code, hence uncomment the same and register the OCP interface for it. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 11 ++- 1 files changed, 10

[PATCH 14/15] ARM: OMAP2+: omap2plus_defconfig: Enable Mailbox

2012-11-02 Thread Vaibhav Bedia
AM33XX PM code depends on Mailbox module for IPC between MPU and WKUP_M3. Signed-off-by: Vaibhav Bedia --- arch/arm/configs/omap2plus_defconfig |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig

[PATCH 09/15] ARM: OMAP: AM33XX: Remove unnecessary include and use __ASSEMBLER__ macros

2012-11-02 Thread Vaibhav Bedia
Get rid of some unnecessary header file inclusions and also use __ASSEMBLER__ macros to allow the various register offsets from PM assembly code which be added in a subsequent patch. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/clock33xx_data.c |1 + arch/arm/mach-omap2/cm33xx.h

[PATCH 03/15] ARM: OMAP: mailbox: Convert to device_initcall

2012-11-02 Thread Vaibhav Bedia
The power management code for AM33XX is a late_initcall and the PM features depend on the mailbox for IPC. In preparation for this, convert the mailbox init to a device_initcall. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/mailbox.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 08/15] ARM: OMAP2+: hwmod: Fix the omap_hwmod_addr_space for CPGMAC0

2012-11-02 Thread Vaibhav Bedia
The first entry for CPGMAC0 should be ADDR_MAP_ON_INIT instead of ADDR_TYPE_RT to ensure the omap hwmod code maps the memory space at init and writes to the SYSCONFIG registers. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/omap_hwmod_33xx_data.c |2 +- 1 files changed, 1 insertions

[PATCH 13/15] ARM: DTS: AM33XX: Add nodes for OCMCRAM and Mailbox

2012-11-02 Thread Vaibhav Bedia
Signed-off-by: Vaibhav Bedia --- arch/arm/boot/dts/am33xx.dtsi | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index bb31bff..e2cbf24 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot

[PATCH 07/15] ARM: OMAP2+: hwmod: Update the hwmod data for TPTCs in AM33XX

2012-11-02 Thread Vaibhav Bedia
Update the TPTC hwmod entry to reflect the fact that the idle and standby transitions are s/w controlled. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/omap_hwmod_33xx_data.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2

[PATCH 10/15] ARM: OMAP2+: control: Add some AM33XX Control module registers

2012-11-02 Thread Vaibhav Bedia
These registers will be required in a subsequent patch which adds basic suspend-resume support for AM33XX. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/control.h | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2

[RFC 00/15] Add basic suspend-resume support for AM33XX

2012-11-02 Thread Vaibhav Bedia
[1] http://www.ti.com/litv/pdf/spruh73f [2] http://arago-project.org/git/projects/?p=am33x-cm3.git;a=summary [3] https://patchwork.kernel.org/patch/1661771/ Vaibhav Bedia (15): ARM: OMAP2+: mailbox: Add an API for flushing the FIFO ARM: OMAP2+: mailbox: Add support for AM33XX ARM: OMA

[PATCH 05/15] ARM: OMAP2+: AM33XX: Update WKUP_M3 hwmod entry for reset status

2012-11-02 Thread Vaibhav Bedia
Add the reset status offset for WKUP_M3 in the hwmod data Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/omap_hwmod_33xx_data.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c

[PATCH 01/15] ARM: OMAP2+: mailbox: Add an API for flushing the FIFO

2012-11-02 Thread Vaibhav Bedia
mailbox code which the MPU can use to empty the FIFO by issuing a readback command. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/mailbox.c | 42 - arch/arm/plat-omap/include/plat/mailbox.h |3 ++ arch/arm/plat-omap/mailbox.c

[PATCH 1/1] ARM: OMAP2+: hwmod: Print an error message if no match exists for a hwmod class

2012-08-08 Thread Vaibhav Bedia
-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/omap_hwmod.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c index 6ca8e51..90e2306 100644 --- a/arch/arm/mach-omap2/omap_hwmod.c +++ b/arch/arm/mach

[RFC][PATCH v2 1/1] ARM: OMAP2+: PM: Register suspend ops even in the presence of DT blob

2012-07-19 Thread Vaibhav Bedia
check for DT blob. Since the suspend-resume operation should not really be dependent on the usage of DT remove this dependency by wrapping the PMIC and SR init under the DT check. Signed-off-by: Vaibhav Bedia --- v2->v1 - As suggested by Paul, Instead of moving around the suspend

[RFC][PATCH 1/1] ARM: OMAP2+: PM: Register suspend ops even in the presence of DT blob

2012-07-18 Thread Vaibhav Bedia
check for DT blob. Since the suspend-resume operation should not really be dependent on the usage of DT, move the suspend ops registration before the check for DT. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/pm.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff

[PATCH 1/1] [RESEND] ARM: OMAP3+: dpll: Configure autoidle mode only if it's supported

2012-04-30 Thread Vaibhav Bedia
skipping the autoidle_reg entry in the DPLL data is sufficient. Signed-off-by: Vaibhav Bedia --- This change is needed for AM33xx, which does not support autoidle mode for the DPLLs. arch/arm/mach-omap2/dpll3xxx.c | 23 ++- 1 files changed, 18 insertions(+), 5 deletions(-) diff

[PATCH 1/1] ARM: OMAP3+: dpll: Configure autoidle mode only if its supported

2012-02-03 Thread Vaibhav Bedia
skipping the autoidle_reg entry in the DPLL data is sufficient. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/dpll3xxx.c | 23 ++- 1 files changed, 18 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c index 57c4c7c

[PATCH] OMAP: clockdomain: Remove redundant call to pwrdm_wait_transition()

2011-05-26 Thread Vaibhav Bedia
The call to pwrdm_wait_transition() in clkdm_clk_enable() is redundant since the function pwrdm_clkdm_state_switch() which is called next also does the same thing. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/clockdomain.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff