Re: [PATCH] ARM: Remove __ref on hotplug cpu die path

2015-09-14 Thread Viresh Kumar
Lindgren <t...@atomide.com> > Cc: Barry Song <bao...@kernel.org> > Cc: Andy Gross <agr...@codeaurora.org> > Cc: Viresh Kumar <vire...@kernel.org> > Cc: Shiraz Hashim <shiraz.linux.ker...@gmail.com> > Cc: Stephen Warren <swar...@wwwdotorg.org> >

[PATCH 14/18] ARM/omap2/timer: Migrate to new 'set-state' interface

2015-07-16 Thread Viresh Kumar
...@kernel.org Acked-by: Tony Lindgren t...@atomide.com Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- arch/arm/mach-omap2/timer.c | 48 ++--- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2

[PATCH 12/18] ARM/omap1/time: Migrate to new 'set-state' interface

2015-07-16 Thread Viresh Kumar
...@kernel.org Acked-by: Tony Lindgren t...@atomide.com Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- arch/arm/mach-omap1/time.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/arch/arm/mach-omap1/time.c b/arch/arm/mach-omap1/time.c index

[PATCH 13/18] ARM/omap1/timer32: Migrate to new 'set-state' interface

2015-07-16 Thread Viresh Kumar
...@kernel.org Acked-by: Tony Lindgren t...@atomide.com Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- arch/arm/mach-omap1/timer32k.c | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/arch/arm/mach-omap1/timer32k.c b/arch/arm/mach-omap1

Re: Fwd: next boot: 101 boots: 89 pass, 12 fail (next-20141216)

2014-12-17 Thread Viresh Kumar
On 17 December 2014 at 20:58, Nishanth Menon n...@ti.com wrote: I still do not see the need to crash the entire system - OK, fine cpufreq is broke, but the remaining part of the system can easily function. That BUG does look like a ugly point and lack of proper cleanup logic - cpufreq should

Re: Fwd: next boot: 101 boots: 89 pass, 12 fail (next-20141216)

2014-12-17 Thread Viresh Kumar
On 17 December 2014 at 22:13, Nishanth Menon n...@ti.com wrote: I do realize that i did have different opinion given bootloader screw ups. Given that we have discovered a potentially bad configuration (in this case for some reason almost ALL TI platforms have bad configuration - could be due

Re: Fwd: next boot: 101 boots: 89 pass, 12 fail (next-20141216)

2014-12-17 Thread Viresh Kumar
On 17 December 2014 at 22:46, Kevin Hilman khil...@kernel.org wrote: So this looks like a bug that has been hiding, but just exposed because cpufreq-cpu0 (now cpufreq-dt) was not getting built-in since before v3.18. On omap4-panda-es, v3.18 with multi_v7_defconfig + CPUFREQ_DT enabled, I see

Re: Fwd: next boot: 101 boots: 89 pass, 12 fail (next-20141216)

2014-12-16 Thread Viresh Kumar
On 17 December 2014 at 02:33, Nishanth Menon n...@ti.com wrote: http://storage.armcloud.us/kernel-ci/next/next-20141216/arm-multi_v7_defconfig/lab-khilman/boot-omap5-uevm.html [2.071996] [ cut here ] [2.076831] kernel BUG at ../drivers/cpufreq/cpufreq.c:1258! [

Re: [PATCH] ARM: omap2plus_defconfig: use CONFIG_CPUFREQ_DT

2014-12-14 Thread Viresh Kumar
-CONFIG_GENERIC_CPUFREQ_CPU0=y +CONFIG_CPUFREQ_DT=y # CONFIG_ARM_OMAP2PLUS_CPUFREQ is not set CONFIG_CPU_IDLE=y CONFIG_BINFMT_MISC=y Acked-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: FIX ME in omap-cpufreq.c

2014-12-04 Thread Viresh Kumar
On 4 December 2014 at 23:13, nick xerofo...@gmail.com wrote: Greetings Kevin and the other maintainers of this file, Hi, I am wondering why the below code still has a fix me? It seems rather trivial to fix, as all we need is the transition time of the CPU. Due to this and I don't have the

Re: [PATCH 07/14] cpufreq: cpu0: OPPs can be populated at runtime

2014-07-10 Thread Viresh Kumar
On 10 July 2014 19:01, Santosh Shilimkar santosh.shilim...@ti.com wrote: Yep. Last time I blocked the series because all the DT conversions were not done. Considering now the cpufreq-generic can work on non DT platforms, I am ok to remove the omap-cpufreq. Great. -- To unsubscribe from this

Re: [PATCH] PM / OPP: Remove ARCH_HAS_OPP

2014-06-08 Thread Viresh Kumar
-omap2/Kconfig| 1 - arch/arm/mach-shmobile/Kconfig | 2 -- arch/arm/mach-vexpress/Kconfig | 1 - arch/arm/mach-zynq/Kconfig | 1 - drivers/devfreq/Kconfig| 1 - kernel/power/Kconfig | 3 --- 10 files changed, 15 deletions(-) Reviewed-by: Viresh Kumar viresh.ku

Re: [PATCH 1/2] PM / OPP: Remove cpufreq wrapper dependency on internal data organization

2014-05-05 Thread Viresh Kumar
On 5 May 2014 19:03, Nishanth Menon n...@ti.com wrote: diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c int dev_pm_opp_init_cpufreq_table(struct device *dev, struct cpufreq_frequency_table **table) { - struct device_opp *dev_opp;

Re: [PATCH 2/2] PM / OPP: Move cpufreq specific OPP functions out of generic OPP library

2014-05-05 Thread Viresh Kumar
as needed isolated to just CPUFreq framework alone. Here, we just move relevant code and documentation to make this part of CPUFreq infrastructure. Cc: Rafael J. Wysocki r...@rjwysocki.net Cc: Viresh Kumar viresh.ku...@linaro.org Cc: Kevin Hilman khil...@deeprootsystems.com Cc: cpuf

Re: [PATCH 1/2] PM / OPP: Remove cpufreq wrapper dependency on internal data organization

2014-05-05 Thread Viresh Kumar
On 5 May 2014 19:55, Nishanth Menon n...@ti.com wrote: On Mon, May 5, 2014 at 9:23 AM, Viresh Kumar viresh.ku...@linaro.org wrote: What if opp is being added for some reason at the same time? I hope we can surely see some awkward results, maybe some NULL pointers invocations as well.. we

Re: [RFC PATCH] PM / OPP: move cpufreq specific OPP functions out of generic OPP library

2014-05-01 Thread Viresh Kumar
On 2 May 2014 06:36, Nishanth Menon n...@ti.com wrote: diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig index 1fbe11f..281ccfb 100644 --- a/drivers/cpufreq/Kconfig +++ b/drivers/cpufreq/Kconfig @@ -17,6 +17,11 @@ config CPU_FREQ if CPU_FREQ +config CPU_FREQ_PM_OPP +

Re: [RFC PATCH] PM / OPP: move cpufreq specific OPP functions out of generic OPP library

2014-05-01 Thread Viresh Kumar
On 2 May 2014 10:48, Nishanth Menon n...@ti.com wrote: On Thu, May 1, 2014 at 11:30 PM, Viresh Kumar viresh.ku...@linaro.org wrote: diff --git a/drivers/cpufreq/cpufreq_opp.c b/drivers/cpufreq/cpufreq_opp.c new file mode 100644 index 000..2602ff8 --- /dev/null +++ b/drivers/cpufreq

Re: [PATCH V7 0/8] ARM: OMAP3+: support cpufreq-cpu0 for device tree boot

2013-12-23 Thread Viresh Kumar
On Wed, Oct 16, 2013 at 9:09 PM, Nishanth Menon n...@ti.com wrote: PandaBoard-ES (OMAP4460): http://pastebin.com/qQCmA2ng Hi Nishanth, A colleague of mine (Sanjay), was trying mainline on panda board. And wasn't able to get cpufreq-cpu0 working with it. Even your log also reports its broken as

Re: [PATCH] cpufreq: omap: clk_round_rate() can return a zero upon error

2013-12-16 Thread Viresh Kumar
in the meantime. This patch also removes a bogus usage of IS_ERR_VALUE(), which is intended to be used only on combination pointer/error code return values; a side-benefit. Signed-off-by: Paul Walmsley pwalms...@nvidia.com Cc: Santosh Shilimkar santosh.shilim...@ti.com Cc: Viresh Kumar viresh.ku

Re: [PATCH 1/3] PM / OPP: rename functions to dev_pm_opp*

2013-09-20 Thread Viresh Kumar
(*new_opp),+} GFP_KERNEL); It is almost impossible to catch these with naked eyes for such long patches.. I took help of --word-diff though :) If no one else sees these as problems then feel free to add my: Acked-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send

Re: [PATCH 1/3] PM / OPP: rename functions to dev_pm_opp*

2013-09-20 Thread Viresh Kumar
On 20 September 2013 18:08, Nishanth Menon n...@ti.com wrote: I am open to suggestions if any one feels we can improve this better. I didn't really had one.. I thought of pm_opp** instead of dev_pm_opp** though.. I believe that change was from Patch #2[1] Yeah.. I just replied on a single

Re: [PATCH 02/10] cpufreq: OMAP: Add SMP support for OMAP4+

2013-08-29 Thread Viresh Kumar
On Fri, Sep 23, 2011 at 2:37 AM, Kevin Hilman khil...@ti.com wrote: From: Russell King rmk+ker...@arm.linux.org.uk On OMAP SMP configuartion, both processors share the voltage and clock. So both CPUs needs to be scaled together and hence needs software co-ordination. Also, update lpj with

Re: [PATCH 02/10] cpufreq: OMAP: Add SMP support for OMAP4+

2013-08-29 Thread Viresh Kumar
On 29 August 2013 19:07, Santosh Shilimkar santosh.shilim...@ti.com wrote: On Thursday 29 August 2013 06:02 AM, Viresh Kumar wrote: cpumask_setall(policy-cpus); Thats should work I guess. Infact I changed this i downstream kernel a while back but forgot to send a patch. Just see if for some

Re: [PATCH 02/10] cpufreq: OMAP: Add SMP support for OMAP4+

2013-08-29 Thread Viresh Kumar
On 30 August 2013 11:13, Viresh Kumar viresh.ku...@linaro.org wrote: On 29 August 2013 19:12, Santosh Shilimkar santosh.shilim...@ti.com wrote: On Thursday 29 August 2013 09:39 AM, Viresh Kumar wrote: On 29 August 2013 19:07, Santosh Shilimkar santosh.shilim...@ti.com wrote: On Thursday

Re: [PATCH 02/19] drivers/usb/host: add missing platform_driver owner

2013-05-20 Thread Viresh Kumar
On Tue, May 21, 2013 at 8:12 AM, Libo Chen libo.c...@huawei.com wrote: set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/usb/host/ehci-spear.c |1 + Acked-by: Viresh Kumar viresh.ku

Re: [PATCH V3 2/2] cpufreq: OMAP: instantiate omap-cpufreq as a platform_driver

2013-03-28 Thread Viresh Kumar
: https://patchwork.kernel.org/patch/2303491/ V1: https://patchwork.kernel.org/patch/2273681/ arch/arm/mach-omap2/pm.c |9 + drivers/cpufreq/omap-cpufreq.c | 19 ++- 2 files changed, 23 insertions(+), 5 deletions(-) For cpufreq core: Acked-by: Viresh Kumar

Re: [PATCH 2/2] cpufreq: drivers: Remove unnecessary assignments of policy- members

2013-03-25 Thread Viresh Kumar
On 25 March 2013 14:06, Sekhar Nori nsek...@ti.com wrote: There is a line in the code a little above the ones you deleted that also sets these same variables. I guess you were relying on that line to set policy-cur, but that also sets policy-{min, max} which can be cleaned up. This code is

Re: [PATCH 2/2] cpufreq: drivers: Remove unnecessary assignments of policy- members

2013-03-25 Thread Viresh Kumar
On 25 March 2013 15:11, Sekhar Nori nsek...@ti.com wrote: So down in the cpufreq driver probe below, we bail out if freq_table is not provided. So all this checking for freq_table in the code you pasted above is superfluous. If you can clean that part up and add checking for

[PATCH 2/2] cpufreq: drivers: Remove unnecessary assignments of policy- members

2013-03-24 Thread Viresh Kumar
Mundt let...@linux-sh.org Cc: linux...@vger.kernel.org Cc: linux-omap@vger.kernel.org Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- Documentation/cpu-freq/cpu-drivers.txt | 5 +++-- arch/arm/mach-davinci/cpufreq.c| 4 arch/arm/mach-imx/cpufreq.c| 3 --- arch/sh

Re: [PATCH 8/8] cpufreq: omap: remove omap-cpufreq

2013-03-14 Thread Viresh Kumar
(-) delete mode 100644 drivers/cpufreq/omap-cpufreq.c Acked-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 077/493] mmc: remove use of __devexit_p

2012-11-19 Thread viresh kumar
Lavinen jarkko.lavi...@nokia.com Cc: Venkatraman S svenk...@ti.com Cc: Viresh Kumar viresh.li...@gmail.com Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Ian Molton i...@mnementh.co.uk Cc: Bruce Chang brucech...@via.com.tw Cc: Harald Welte haraldwe...@viatech.com Cc: Pierre Ossman pie

Re: [PATCH 237/493] mmc: remove use of __devinit

2012-11-19 Thread viresh kumar
Lauss manuel.la...@gmail.com Cc: Michał Mirosław mirq-li...@rere.qmqm.pl Cc: Jarkko Lavinen jarkko.lavi...@nokia.com Cc: Venkatraman S svenk...@ti.com Cc: Viresh Kumar viresh.li...@gmail.com Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Ian Molton i...@mnementh.co.uk Cc: Bruce Chang

OMAP: Compilation error: omapzoom kernel tree

2012-09-04 Thread Viresh Kumar
Hello, Which branch should i use from TI[1] tree? I need to boot linux with linaro-nano. I tried: p-linux-omap-3.4 branch but i am getting compilation error for omap4plus_pm_min_defconfig and omap2plus_defconfig: /home/arm/work/kernel/mywork/linux.git/arch/arm/mm/proc-v7.S: Assembler messages:

Re: [PATCH 15/31] ARM: amba: spear: get rid of NO_IRQ initializers

2012-01-20 Thread Viresh Kumar
, .flags = IORESOURCE_MEM, }, - .irq = {IRQ_APPL_GPIO, NO_IRQ}, + .irq = {IRQ_APPL_GPIO}, } }; Acked-by: Viresh Kumar viresh.ku...@st.com -- viresh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH 30/31] ARM: amba: spear: use common amba device initializers

2012-01-20 Thread Viresh Kumar
}, -}; +AMBA_APB_DEVICE(spear3xx_uart, uart, 0, SPEAR3XX_ICM1_UART_BASE, + {SPEAR3XX_IRQ_UART}, NULL); /* Do spear3xx familiy common initialization part here */ void __init spear3xx_init(void) Acked-by: Viresh Kumar viresh.ku...@st.com -- viresh -- To unsubscribe from this list: send

Re: [PATCH 06/13] clocksource: add common mmio clocksource

2011-05-11 Thread viresh kumar
...@wantstofly.org Cc: Linus Walleij linus.wall...@stericsson.com Cc: linux-omap@vger.kernel.org Cc: Nicolas Pitre n...@fluxnic.net Cc: Olof Johansson o...@lixom.net Cc: Sascha Hauer ker...@pengutronix.de Cc: Tony Lindgren t...@atomide.com Cc: Viresh Kumar viresh.ku...@st.com Cc: Wan ZongShun mcuos