[3.10] [AM335x-EVMSK] BUG: spinlock bad magic on CPU#0

2013-07-02 Thread Ambresh K
, Ambresh U-Boot 2012.10 (Jul 02 2013 - 10:41:19) I2C: ready DRAM: 256 MiB WARNING: Caches not enabled NAND: No NAND device found!!! 0 MiB MMC: OMAP SD/MMC: 0, OMAP SD/MMC: 1 *** Warning - readenv() failed, using default environment musb-hdrc: ConfigData=0xde (UTMI-8, dyn FIFOs, bulk combine

Re: [PATCH V2 3/3] ARM: OMAP2+: clk: Fix return type of callbacks

2013-06-23 Thread Ambresh K
On Friday 21 June 2013 11:43 PM, Mike Turquette wrote: Quoting Ambresh K (2013-06-17 01:39:44) From: Ambresh K ambr...@ti.com clk_ops's .get_parent member data return's signed value. Signed-off-by: Ambresh K ambr...@ti.com Unsurprisingly I get the following errors when building

[PATCH V2 0/3] Fix to clk framework while handling orphan clks

2013-06-17 Thread Ambresh K
From: Ambresh K ambr...@ti.com On a possible HW bug or in-correct configuration of MUX register's in bootloader; might return a value greater than available parent clocks for a MUX clk. Sensing invalid parent index, clk_mux_get_parent returns -EINVALID. Due to function's u8 return type

[PATCH V2 2/3] clk: skip re-parenting orphan clk

2013-06-17 Thread Ambresh K
From: Ambresh K ambr...@ti.com If clk is same as orphan clk then skip the iteration, there by avoiding unnecessary look-up. Signed-off-by: Ambresh K ambr...@ti.com --- drivers/clk/clk.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk

[PATCH V2 1/3] clk: fix clk_mux_get_parent return's signed value

2013-06-17 Thread Ambresh K
From: Ambresh K ambr...@ti.com clk_mux_get_parent should return an error if the value read from the register is erroneous. Currently if the value read is greater than the number of available parents clk_mux_get_parent return's signed error which will result in NULL pointer dereferencing

[PATCH V2 3/3] ARM: OMAP2+: clk: Fix return type of callbacks

2013-06-17 Thread Ambresh K
From: Ambresh K ambr...@ti.com clk_ops's .get_parent member data return's signed value. Signed-off-by: Ambresh K ambr...@ti.com --- arch/arm/mach-omap2/clkt_clksel.c |2 +- arch/arm/mach-omap2/clkt_dpll.c |2 +- arch/arm/mach-omap2/clock.h |4 ++-- 3 files changed, 4

Re: [Patch 3/3] clk: Avoid re-parenting orphan clk's having invalid parent index.

2013-06-13 Thread Ambresh K
, but unless I am misunderstanding this patch I feel that it can be dropped entirely. Thanks for your time! Will drop this patch and send V2 for first 2 patches. Regards, Ambresh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [Patch 1/3] clk: fix clk_mux_get_parent return's signed value

2013-06-04 Thread Ambresh K
clk_mux_get_parent return's signed error which will result in NULL pointer dereferencing in the calling functions. Signed-off-by: Ambresh K ambr...@ti.com --- drivers/clk/clk-mux.c|2 +- drivers/clk/clk.c| 12 +++- include/linux/clk-provider.h |4 ++-- 3 files

Re: [Patch 3/3] clk: Avoid re-parenting orphan clk's having invalid parent index.

2013-06-04 Thread Ambresh K
On Wednesday 29 May 2013 12:48 PM, Mike Turquette wrote: Quoting Ambresh K (2013-05-01 23:25:29) From: Ambresh K ambr...@ti.com Add orhan clk nodes having invalid parent index to list and use the list to skip re-parenting orphan clk having invalid parents. Signed-off-by: Ambresh K ambr

[Patch 0/3] Fix to clk framework while handling orphan clks

2013-05-02 Thread Ambresh K
From: Ambresh K ambr...@ti.com On a possible HW bug or in-correct configuration of clk_sel bits in bootloaders, there are high probablity of returning a value greater than available parent clocks for a MUX clk. Sensing invalid parent index, clk_mux_get_parent returns -EINVALID. Due

[Patch 1/3] clk: fix clk_mux_get_parent return's signed value

2013-05-02 Thread Ambresh K
From: Ambresh K ambr...@ti.com If for some reason, the value read from clksel field return erroneous due to HW bug or improper configuration, then clk_mux_get_parent should return appropriate error's. Currently if the value read is greater than the number of available parents clk_mux_get_parent

[Patch 2/3] clk: skip re-parenting orphan clk

2013-05-02 Thread Ambresh K
From: Ambresh K ambr...@ti.com If clk is same as orphan clk than skip the iteration, there by avoiding unnecessary look-up. Signed-off-by: Ambresh K ambr...@ti.com --- drivers/clk/clk.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk

[Patch 3/3] clk: Avoid re-parenting orphan clk's having invalid parent index.

2013-05-02 Thread Ambresh K
From: Ambresh K ambr...@ti.com Add orhan clk nodes having invalid parent index to list and use the list to skip re-parenting orphan clk having invalid parents. Signed-off-by: Ambresh K ambr...@ti.com --- drivers/clk/clk.c | 21 +++-- 1 files changed, 19 insertions(+), 2

[PATCH] OMAP4: GPIO: Fix missing interrupts during device wakeup due to IOPAD.

2011-06-15 Thread Ambresh K
From: Ambresh K ambr...@ti.com If gpio pins from bank[2-5] are marked as wakeup enable and if the wake is through gpio IO pad wakeup, then that wakeup gpio interrupt is lost. In the current implementation, GPIO driver stores the context of DATAIN of all the gpio in the bank. During GPIO resuming

[PATCH] OMAP4: DMTIMER: enable autoidle mode

2011-06-15 Thread Ambresh K
From: Ambresh K ambr...@ti.com Currently autoidle is only enabled for OMAP2/3; by enabling autoidle, the automatic L4 clock gating strategy is applied based on L4 activity, otherwise L4 clock to module will be a free running. Signed-off-by: Ambresh K ambr...@ti.com --- arch/arm/plat-omap

[PATCH] OMAP3: CLK: FIX: warning SR fclk clk domain not found

2010-04-22 Thread Ambresh K
Added clock domain name to sr[1,2] clk structure to fix warning while initialising sr hwmod during boot-up. Signed-off-by: Ambresh K ambr...@ti.com --- arch/arm/mach-omap2/clock3xxx_data.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2

Re: [PATCH v2 2/2] OMAP3630 SDRC: Change in DVFS Latency Formula for OMAP3630

2010-03-22 Thread ambresh
. And moreover the formula used to calculate clkoutx2 in this case looks like the one used for computing clkout_M2X2 :) Thanks, Ambresh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v4 1/2] OMAP3: SDRC: Dynamic Calculation of SDRC stall latency during DVFS

2010-03-21 Thread ambresh
; delay_sram = (error_gain * diff) / (loop); delay_sram += error_gain; Why *2 is missing in your code? 2 is needed since the loop takes 2 arm cycles. its a typo, it should be (loop * 2). BR, Ambresh Regards Vishwa Thanks, Ambresh + + return delay_sram; +} +#endif + int __init

Re: [PATCH v4 1/2] OMAP3: SDRC: Dynamic Calculation of SDRC stall latency during DVFS

2010-03-18 Thread ambresh
); delay_sram += error_gain; Thanks, Ambresh + + return delay_sram; +} +#endif + int __init omap_sram_init(void) { omap_detect_sram(); omap_map_sram(); +#ifdef CONFIG_ARCH_OMAP3 + _omap3_sram_delay = omap_sram_push(__sram_wait_delay

Re: [PATCH v2 2/2] OMAP3630 SDRC: Change in DVFS Latency Formula for OMAP3630

2010-03-18 Thread ambresh
, Ambresh pr_debug(m = %d, n = %d, m2 =%d\n, core_dpll_mul_m, core_dpll_div_n, core_dpll_clkoutdiv_m2); diff --git a/arch/arm/mach-omap2/clock34xx.c b/arch/arm/mach-omap2/clock34xx.c index 02ab136..83125a1 100644 --- a/arch/arm/mach-omap2

Re: [PATCH RFC]OMAP3:PM:Dynamic Calculation of SDRC stall latency during DVFS

2010-03-09 Thread ambresh
Gurav , Pramod wrote: Hi Ambresh, + clk_sel_regval = cm_read_mod_reg(PLL_MOD, CM_CLKSEL); *clk already as reference to CM_CLKSEL: static struct clk dpll3_m2_ck = { [...] .clksel_reg = OMAP_CM_REGADDR(PLL_MOD, CM_CLKSEL1), .clksel_mask

Re: [PATCH RFC]OMAP3:PM:Dynamic Calculation of SDRC stall latency during DVFS

2010-03-08 Thread ambresh
instead of core_dpll_xxx_xx, to make code more readable. Regards, Ambresh + sdrc_clk_stab = nr / dr; + + /* Adding 2us to sdrc clk stab */ + sdrc_clk_stab = sdrc_clk_stab + 2; + + delay_sram = delay_sram_val(); + + /* Calculate the number of MPU cycles to wait for SDRC

Re: [PATCH 02/16] OMAP3: PM: Create list to keep track of various smartreflex instances.

2010-02-24 Thread ambresh
structure? return 0; } Regards, Ambresh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 03/16] OMAP3: PM: Convert smartreflex driver into a platform driver using hwmods and omap-device layer

2010-02-24 Thread ambresh
Gopinath, Thara wrote: This patch converts the exisitng smartreflex library into a platform driver with device , driver registrations using hardware mods. As part of this Ntarget values are passed as platform data. Signed-off-by: Thara Gopinath th...@ti.com ---