Re: [PATCH/RFC 00/19] OMAP: voltage layer cleanup and restructure

2011-03-25 Thread Jean Pihet
On Thu, Mar 24, 2011 at 1:00 AM, Kevin Hilman khil...@ti.com wrote: This series is the begining of a voltage layer cleanup and restruture with the primary goal of splitting up voltage domain, voltage processor (VP) and voltage controller (VC) code. It would be nice to give a bit more detail on

Re: [PATCH/RFC 00/19] OMAP: voltage layer cleanup and restructure

2011-03-25 Thread Cousson, Benoit
On 3/25/2011 1:02 AM, Hilman, Kevin wrote: Kevin Hilmankhil...@ti.com writes: This series is the begining of a voltage layer cleanup and restruture with the primary goal of splitting up voltage domain, voltage processor (VP) and voltage controller (VC) code. The RFC part is for the last 3

Re: [PATCH/RFC 00/19] OMAP: voltage layer cleanup and restructure

2011-03-25 Thread Paul Walmsley
Hi Kevin you might want to consider renaming OMAP3_PRM_VC_VDD_MPU_ID etc. to something like: OMAP3_VC_VDD_MPU_ID and to define those in some vc.h header file. Also, I'd suggest moving the struct omap_prm_vc_ops assignments out of the prm*.c code into the vc_data.c files, ideally into

Re: [PATCH/RFC 00/19] OMAP: voltage layer cleanup and restructure

2011-03-25 Thread Kevin Hilman
Paul Walmsley p...@pwsan.com writes: Hi Kevin you might want to consider renaming OMAP3_PRM_VC_VDD_MPU_ID etc. to something like: OMAP3_VC_VDD_MPU_ID and to define those in some vc.h header file. OK Also, I'd suggest moving the struct omap_prm_vc_ops assignments out of the prm*.c

Re: [PATCH/RFC 00/19] OMAP: voltage layer cleanup and restructure

2011-03-24 Thread Kevin Hilman
Kevin Hilman khil...@ti.com writes: This series is the begining of a voltage layer cleanup and restruture with the primary goal of splitting up voltage domain, voltage processor (VP) and voltage controller (VC) code. The RFC part is for the last 3 patches in the series, and for discussion

[PATCH/RFC 00/19] OMAP: voltage layer cleanup and restructure

2011-03-23 Thread Kevin Hilman
This series is the begining of a voltage layer cleanup and restruture with the primary goal of splitting up voltage domain, voltage processor (VP) and voltage controller (VC) code. The RFC part is for the last 3 patches in the series, and for discussion of how/if to split out the SoC specifics.