Re: [PATCH] ARM: OMAP: fix return value check in omap_device_build_from_dt()

2013-09-17 Thread Tony Lindgren
* Kevin Hilman khil...@linaro.org [130826 17:17]: Tony Lindgren t...@atomide.com writes: Kevin, * Wei Yongjun weiyj...@gmail.com [130704 06:48]: From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function omap_device_alloc() returns ERR_PTR() and never returns

Re: [PATCH] ARM: OMAP: fix return value check in omap_device_build_from_dt()

2013-08-26 Thread Kevin Hilman
Tony Lindgren t...@atomide.com writes: Kevin, * Wei Yongjun weiyj...@gmail.com [130704 06:48]: From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function omap_device_alloc() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be

Re: [PATCH] ARM: OMAP: fix return value check in omap_device_build_from_dt()

2013-08-21 Thread Tony Lindgren
Kevin, * Wei Yongjun weiyj...@gmail.com [130704 06:48]: From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function omap_device_alloc() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Looks like this is

[PATCH] ARM: OMAP: fix return value check in omap_device_build_from_dt()

2013-07-04 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function omap_device_alloc() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn ---