Re: [PATCH] Add OMAP Support for Generic PWM Devices using Dual-mode Timers

2010-11-17 Thread Hemanth V
- Original Message - From: Grant Erickson maratho...@gmail.com To: Hemanth V heman...@ti.com Cc: Tony Lindgren t...@atomide.com; linux-omap@vger.kernel.org Sent: Tuesday, November 16, 2010 11:15 PM Subject: Re: [PATCH] Add OMAP Support for Generic PWM Devices using Dual-mode Timers

Re: [PATCH] Add OMAP Support for Generic PWM Devices using Dual-mode Timers

2010-11-16 Thread Hemanth V
- Original Message - From: Grant Erickson maratho...@gmail.com To: linux-omap@vger.kernel.org Cc: Tony Lindgren t...@atomide.com Sent: Monday, November 15, 2010 12:58 AM Subject: [PATCH] Add OMAP Support for Generic PWM Devices using Dual-mode Timers This patch adds support

Re: [PATCH] Add OMAP Support for Generic PWM Devices using Dual-mode Timers

2010-11-16 Thread Felipe Balbi
On Sun, Nov 14, 2010 at 01:28:49PM -0600, Grant Erickson wrote: +MODULE_LICENSE(GPLv2); module license should be GPL v2 just read the comment above MODULE_LICENSE definition: /* * The following license idents are currently accepted as indicating free * software modules * * GPL

Re: [PATCH] Add OMAP Support for Generic PWM Devices using Dual-mode Timers

2010-11-16 Thread Kevin Hilman
Grant Erickson maratho...@gmail.com writes: This patch adds support to request and use one or more of the OMAP dual-mode timers as a generic PWM device compatible with other generic PWM drivers such as the PWM backlight or PWM beeper driver. How will this co-exist with the PWM on the twl6030

Re: [PATCH] Add OMAP Support for Generic PWM Devices using Dual-mode Timers

2010-11-16 Thread Grant Erickson
On 11/16/10 4:37 AM, Hemanth V wrote: - Original Message - From: Grant Erickson maratho...@gmail.com Sent: Monday, November 15, 2010 12:58 AM This patch adds support to request and use one or more of the OMAP dual-mode timers as a generic PWM device compatible with other generic

Re: [PATCH] Add OMAP Support for Generic PWM Devices using Dual-mode Timers

2010-11-16 Thread Grant Erickson
On 11/16/10 4:42 AM, Felipe Balbi wrote: On Sun, Nov 14, 2010 at 01:28:49PM -0600, Grant Erickson wrote: +MODULE_LICENSE(GPLv2); module license should be GPL v2 Thanks for the feedback. I'll make that adjustment. Best, Grant -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] Add OMAP Support for Generic PWM Devices using Dual-mode Timers

2010-11-16 Thread Grant Erickson
On 11/16/10 9:01 AM, Kevin Hilman wrote: Grant Erickson maratho...@gmail.com writes: This patch adds support to request and use one or more of the OMAP dual-mode timers as a generic PWM device compatible with other generic PWM drivers such as the PWM backlight or PWM beeper driver. How will

Re: [PATCH] Add OMAP Support for Generic PWM Devices using Dual-mode Timers

2010-11-16 Thread Kevin Hilman
Grant Erickson maratho...@gmail.com writes: On 11/16/10 9:01 AM, Kevin Hilman wrote: Grant Erickson maratho...@gmail.com writes: This patch adds support to request and use one or more of the OMAP dual-mode timers as a generic PWM device compatible with other generic PWM drivers such as the

RE: [PATCH] Add OMAP Support for Generic PWM Devices using Dual-mode Timers

2010-11-16 Thread Premi, Sanjeev
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Grant Erickson Sent: Monday, November 15, 2010 12:59 AM To: linux-omap@vger.kernel.org Cc: Tony Lindgren Subject: [PATCH] Add OMAP Support for Generic PWM Devices

Re: [PATCH] Add OMAP Support for Generic PWM Devices using Dual-mode Timers

2010-11-16 Thread Grant Erickson
On 11/16/10 10:54 AM, Premi, Sanjeev wrote: [sp] pr_info(), dev_info() are already macros - conditional to DEBUG. We should use them instead of defining another layer. The macros pr_devel, pr_dbg, and dev_dbg are so conditionalized; however, *_info are straight pass-throughs to printk and

Re: [PATCH] Add OMAP Support for Generic PWM Devices using Dual-mode Timers

2010-11-16 Thread Grant Erickson
On 11/16/10 10:43 AM, Kevin Hilman wrote: Grant Erickson maratho...@gmail.com writes: On 11/16/10 9:01 AM, Kevin Hilman wrote: Grant Erickson maratho...@gmail.com writes: This patch adds support to request and use one or more of the OMAP dual-mode timers as a generic PWM device compatible

Re: [PATCH] Add OMAP Support for Generic PWM Devices using Dual-mode Timers

2010-11-16 Thread Kevin Hilman
Grant Erickson maratho...@gmail.com writes: [...] Before something like this can merge, I would rather see 1) generic PWM framework pushed along and merged 2) the dmtimer hwmod conversion finished Yes, I know it's a lot more work to fix the core/framework code before having a feature

Re: [PATCH] Add OMAP Support for Generic PWM Devices using Dual-mode Timers

2010-11-16 Thread Tony Lindgren
* Kevin Hilman khil...@deeprootsystems.com [101116 11:43]: Grant Erickson maratho...@gmail.com writes: [...] Before something like this can merge, I would rather see 1) generic PWM framework pushed along and merged 2) the dmtimer hwmod conversion finished Yes, I know it's a lot

[PATCH] Add OMAP Support for Generic PWM Devices using Dual-mode Timers

2010-11-14 Thread Grant Erickson
This patch adds support to request and use one or more of the OMAP dual-mode timers as a generic PWM device compatible with other generic PWM drivers such as the PWM backlight or PWM beeper driver. Boards can register such devices using platform data such as in the following example: