Re: [PATCH] Add support for packet synchronised sDMA transfers.

2010-05-11 Thread Tony Lindgren
* Goucem, Fabrice [100309 05:11]: > Hi Hari, > > Thanks for your comment. > What you're saying is perfectly true, however I find current way is a bit > awkward and potentially dangerous if for any reason value of > OMAP_DMA_SYNC_PACKET changes in the future, or if more constants are defined >

RE: [PATCH] Add support for packet synchronised sDMA transfers.

2010-03-09 Thread Goucem, Fabrice
ari n [mailto:hari.z...@gmail.com] Sent: 03 March 2010 14:03 To: Goucem, Fabrice Cc: linux-omap@vger.kernel.org Subject: Re: [PATCH] Add support for packet synchronised sDMA transfers. I believe, packet mode is already supported in the current DMA driver. Both the FS and BS bits of the CCR are set when p

Re: [PATCH] Add support for packet synchronised sDMA transfers.

2010-03-03 Thread hari n
I believe, packet mode is already supported in the current DMA driver. Both the FS and BS bits of the CCR are set when packet mode is selected. This is because, enum for OMAP_DMA_SYNC_PACKET is '0x03' (i.e OMAP_DMA_SYNC_FRAME | OMAP_DMA_SYNC_BLOCK). On Wed, Mar 3, 2010 at 4:20 AM, Fabrice Goucem

[PATCH] Add support for packet synchronised sDMA transfers.

2010-03-03 Thread Fabrice Goucem
System DMA packet synchronisation is currently not supported in the Linux Kernel. This patch provides necessary modifications to support packet synchronisation: Function omap_set_dma_transfer_params() handles value OMAP_DMA_SYNC_PACKET to program FS and BS bits of register CCR. Users can give the p