RE: [PATCH] I2C: OMAP: Include OMAP_I2C_SYSC_REG in save and restore

2009-02-02 Thread Pakaravoor, Jagadeesh
Hi, omap_i2c_write_reg(dev, OMAP_I2C_IE_REG, dev-iestate); @@ -300,14 +302,15 @@ static int omap_i2c_init(struct omap_i2c } else if (dev-rev = OMAP_I2C_REV_ON_3430) { u32 v; This local variable is left unused, so you will get a compiler

Re: [PATCH] I2C: OMAP: Include OMAP_I2C_SYSC_REG in save and restore

2009-02-02 Thread Aaro Koskinen
Hello, ext Pakaravoor, Jagadeesh wrote: From: Jagadeesh Bhaskar Pakaravoor j-pakarav...@ti.com Save and restore should include OMAP_I2C_SYSC_REG. Signed-off-by: Jagadeesh Bhaskar Pakaravoor j-pakarav...@ti.com CC: Jouni Hogander jouni.hogan...@nokia.com --- Index:

RE: [PATCH] I2C: OMAP: Include OMAP_I2C_SYSC_REG in save and restore

2009-02-02 Thread Pakaravoor, Jagadeesh
Ben, is this necessary for inclusion as a bugfix, or can it wait for a merge window? This patch applies to Linux Omap tree only. It is a bug fix, and preferably taken ASAP. I'd like to incorporate your review comments, if you have any. -Jagadeesh -- To unsubscribe from this list: send the

[PATCH] I2C: OMAP: Include OMAP_I2C_SYSC_REG in save and restore

2009-01-22 Thread Pakaravoor, Jagadeesh
From: Jagadeesh Bhaskar Pakaravoor j-pakarav...@ti.com Save and restore should include OMAP_I2C_SYSC_REG. Signed-off-by: Jagadeesh Bhaskar Pakaravoor j-pakarav...@ti.com CC: Jouni Hogander jouni.hogan...@nokia.com --- Index: linux-omap-2.6/drivers/i2c/busses/i2c-omap.c

RE: [PATCH] I2C: OMAP: Include OMAP_I2C_SYSC_REG in save and restore

2009-01-22 Thread Pakaravoor, Jagadeesh
] On Behalf Of Pakaravoor, Jagadeesh Sent: Friday, January 23, 2009 12:25 PM To: linux-...@vger.kernel.org; linux-omap@vger.kernel.org Cc: Jean Delvare Subject: [PATCH] I2C: OMAP: Include OMAP_I2C_SYSC_REG in save and restore From: Jagadeesh Bhaskar Pakaravoor j-pakarav...@ti.com Save and restore should

Re: [PATCH] I2C: OMAP: Include OMAP_I2C_SYSC_REG in save and restore

2009-01-22 Thread Jean Delvare
Hi Jagadeesh, On Fri, 23 Jan 2009 12:51:23 +0530, Pakaravoor, Jagadeesh wrote: Sorry. I forgot to mention that this patch does not apply on mainline. It is meant for Linux Omap tree only. Please review/ACK the patch, if you have time. You should Cc Ben Dooks rather than me on i2c-omap