Re: [PATCH] Input: gpio-keys: Support for one-directional interrupts

2010-01-09 Thread Cory Maccarrone
On Thu, Dec 10, 2009 at 8:03 PM, Cory Maccarrone wrote: > I've just submitted a patch to linux-omap for this against the > gpio/irq handling code. It implements the ICR flip in there > automatically whenever both RISING and FALLING edge are requested of > one of these gpios.  With it, the patch I'

Re: [PATCH] Input: gpio-keys: Support for one-directional interrupts

2009-12-10 Thread Cory Maccarrone
On Wed, Dec 9, 2009 at 2:03 PM, Cory Maccarrone wrote: > I'll take a look and see how possible that would be to do.  Looking > through the code for OMAP1's GPIO IRQ handlers, there's a note that > OMAP1 only supports edge triggering, so if gpio-keys were to move > exclusively to that, itwould stop

Re: [PATCH] Input: gpio-keys: Support for one-directional interrupts

2009-12-09 Thread Cory Maccarrone
On Wed, Dec 9, 2009 at 9:58 AM, Dmitry Torokhov wrote: > On Wed, Dec 09, 2009 at 08:15:26AM -0800, Cory Maccarrone wrote: >> On Wed, Dec 9, 2009 at 3:32 AM, Ferenc Wagner wrote: >> >> I'm fairly certain it wouldn't.  Each of the interrupts on my hardware >> has a corresponding bit in a control re

Re: [PATCH] Input: gpio-keys: Support for one-directional interrupts

2009-12-09 Thread Dmitry Torokhov
On Wed, Dec 09, 2009 at 08:15:26AM -0800, Cory Maccarrone wrote: > On Wed, Dec 9, 2009 at 3:32 AM, Ferenc Wagner wrote: > > Cory Maccarrone writes: > > > > Interesting.  Btw. I'd like to convert gpio-keys from edge-triggered to > > level-triggered interrupts.  Would that work for your hardware? >

Re: [PATCH] Input: gpio-keys: Support for one-directional interrupts

2009-12-09 Thread Cory Maccarrone
On Wed, Dec 9, 2009 at 3:32 AM, Ferenc Wagner wrote: > Cory Maccarrone writes: > > Interesting.  Btw. I'd like to convert gpio-keys from edge-triggered to > level-triggered interrupts.  Would that work for your hardware? I'm fairly certain it wouldn't. Each of the interrupts on my hardware has

Re: [PATCH] Input: gpio-keys: Support for one-directional interrupts

2009-12-09 Thread Ferenc Wagner
Cory Maccarrone writes: > The current gpio-keys driver assumes that each given GPIO has > the ability to respond to both rising and falling interrupts > at the same time. For some GPIOs on certain devices, the interrupt > is only one-directional -- either rising or falling, depending on > what's

[PATCH] Input: gpio-keys: Support for one-directional interrupts

2009-12-05 Thread Cory Maccarrone
The current gpio-keys driver assumes that each given GPIO has the ability to respond to both rising and falling interrupts at the same time. For some GPIOs on certain devices, the interrupt is only one-directional -- either rising or falling, depending on what's being listened for. In particular,