Re: [PATCH] MMC/omap_hsmmc: handle failure of regulator_get better.

2012-08-07 Thread Chris Ball
Hi, On Sun, Jul 29 2012, NeilBrown wrote: > 1/ if regulator_get fails, return an error. This is important >if it failed with EPROBE_DEFER, as the probe needs to be >deferred. > > 2/ Don't set .set_power until the regulator has been found, or >the deferred probe will not bother calling

Re: [PATCH] MMC/omap_hsmmc: handle failure of regulator_get better.

2012-07-29 Thread NeilBrown
On Mon, 30 Jul 2012 12:07:09 +0530 Rajendra Nayak wrote: > On Monday 30 July 2012 11:54 AM, NeilBrown wrote: > > On Mon, 30 Jul 2012 10:50:36 +0530 Rajendra Nayak wrote: > > > >> On Monday 30 July 2012 05:42 AM, NeilBrown wrote: > >>> > >>> 1/ if regulator_get fails, return an error. This is im

Re: [PATCH] MMC/omap_hsmmc: handle failure of regulator_get better.

2012-07-29 Thread Rajendra Nayak
On Monday 30 July 2012 11:54 AM, NeilBrown wrote: On Mon, 30 Jul 2012 10:50:36 +0530 Rajendra Nayak wrote: On Monday 30 July 2012 05:42 AM, NeilBrown wrote: 1/ if regulator_get fails, return an error. This is important if it failed with EPROBE_DEFER, as the probe needs to be defer

Re: [PATCH] MMC/omap_hsmmc: handle failure of regulator_get better.

2012-07-29 Thread NeilBrown
On Mon, 30 Jul 2012 10:50:36 +0530 Rajendra Nayak wrote: > On Monday 30 July 2012 05:42 AM, NeilBrown wrote: > > > > 1/ if regulator_get fails, return an error. This is important > > if it failed with EPROBE_DEFER, as the probe needs to be > > deferred. > > > > 2/ Don't set .set_power un

Re: [PATCH] MMC/omap_hsmmc: handle failure of regulator_get better.

2012-07-29 Thread Rajendra Nayak
On Monday 30 July 2012 05:42 AM, NeilBrown wrote: 1/ if regulator_get fails, return an error. This is important if it failed with EPROBE_DEFER, as the probe needs to be deferred. 2/ Don't set .set_power until the regulator has been found, or the deferred probe will not bother calli

[PATCH] MMC/omap_hsmmc: handle failure of regulator_get better.

2012-07-29 Thread NeilBrown
1/ if regulator_get fails, return an error. This is important if it failed with EPROBE_DEFER, as the probe needs to be deferred. 2/ Don't set .set_power until the regulator has been found, or the deferred probe will not bother calling omap_hsmmc_reg_get(). Signed-off-by: NeilBrown di