RE: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-10-01 Thread Varadarajan, Charulatha
Tony, Benoit, Kevin, I think that disabling it should be done only if the CONFIG_OMAP_WDT is not set. How about disabling is done always unless CONFIG_WATCHDOG_NOWAYOUT is set? As given in the patch description, this patch does a disable of watchdog timer,

Re: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-10-01 Thread Kevin Hilman
Varadarajan, Charulatha ch...@ti.com writes: Tony, Benoit, Kevin, I think that disabling it should be done only if the CONFIG_OMAP_WDT is not set. How about disabling is done always unless CONFIG_WATCHDOG_NOWAYOUT is set? As given in the patch description,

Re: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-10-01 Thread Cousson, Benoit
On 10/1/2010 4:43 PM, Kevin Hilman wrote: Varadarajan, Charulathach...@ti.com writes: Tony, Benoit, Kevin, I think that disabling it should be done only if the CONFIG_OMAP_WDT is not set. How about disabling is done always unless CONFIG_WATCHDOG_NOWAYOUT is set? As given in the patch

[PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-09-30 Thread Varadarajan, Charulatha
With OMAP2PLUS watchdog implemented in hwmod fw way, the module is reset during init. After a watchdog timer module reset, the WDTs are enabled. The default time for a system reset after a watchdog module reset is ~10s as per the default value of the WDT registers. Hence the system would be reset

Re: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-09-30 Thread Kevin Hilman
Cousson, Benoit b-cous...@ti.com writes: Hi Charu, On 9/30/2010 10:11 AM, Varadarajan, Charulatha wrote: With OMAP2PLUS watchdog implemented in hwmod fw way, the module is reset during init. In that case hwmod fw just highlighted the real behavior that was hidden so far by the X-loader.

Re: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-09-30 Thread Kevin Hilman
Varadarajan, Charulatha ch...@ti.com writes: With OMAP2PLUS watchdog implemented in hwmod fw way, the module is reset during init. Please drop this sentence, as it's not directly related to hwmod, but related to hardware reset, and was previously masked by most bootloaders. After a watchdog

Re: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-09-30 Thread Cousson, Benoit
On 9/30/2010 3:55 PM, Kevin Hilman wrote: Cousson, Benoitb-cous...@ti.com writes: Hi Charu, On 9/30/2010 10:11 AM, Varadarajan, Charulatha wrote: With OMAP2PLUS watchdog implemented in hwmod fw way, the module is reset during init. In that case hwmod fw just highlighted the real behavior

Re: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-09-30 Thread Kevin Hilman
Cousson, Benoit b-cous...@ti.com writes: On 9/30/2010 3:55 PM, Kevin Hilman wrote: Cousson, Benoitb-cous...@ti.com writes: Hi Charu, On 9/30/2010 10:11 AM, Varadarajan, Charulatha wrote: With OMAP2PLUS watchdog implemented in hwmod fw way, the module is reset during init. In that case

Re: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-09-30 Thread Tony Lindgren
* Cousson, Benoit b-cous...@ti.com [100930 07:04]: I think that disabling it should be done only if the CONFIG_OMAP_WDT is not set. How about disabling is done always unless CONFIG_WATCHDOG_NOWAYOUT is set? That way product kernels can set CONFIG_WATCHDOG_NOWAYOUT and for the rest of us we

RE: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-09-30 Thread Varadarajan, Charulatha
Tony/ Benoit, I think that disabling it should be done only if the CONFIG_OMAP_WDT is not set. How about disabling is done always unless CONFIG_WATCHDOG_NOWAYOUT is set? As given in the patch description, this patch does a disable of watchdog timer, during init, to avoid the system

RE: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-09-30 Thread Varadarajan, Charulatha
Benoit, snip With OMAP2PLUS watchdog implemented in hwmod fw way, the module is reset during init. In that case hwmod fw just highlighted the real behavior that was hidden so far by the X-loader. Yes. You should as well add a link to the email thread with Kevin that raised the

RE: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-09-30 Thread Varadarajan, Charulatha
Kevin, Varadarajan, Charulatha ch...@ti.com writes: snip With OMAP2PLUS watchdog implemented in hwmod fw way, the module is reset during init. Please drop this sentence, as it's not directly related to hwmod, but related to hardware reset, and was previously masked by most

RE: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-09-30 Thread Paul Walmsley
Hello Charu, On Thu, 30 Sep 2010, Varadarajan, Charulatha wrote: diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c index 8e2f0aa..9f44fc6 100644 --- a/arch/arm/mach-omap2/devices.c +++ b/arch/arm/mach-omap2/devices.c + +static void __init

Re: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-09-30 Thread Cousson, Benoit
On 9/30/2010 6:32 PM, Varadarajan, Charulatha wrote: Benoit, snip With OMAP2PLUS watchdog implemented in hwmod fw way, the module is reset during init. In that case hwmod fw just highlighted the real behavior that was hidden so far by the X-loader. Yes. You should as well add a link to

Re: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-09-30 Thread Tony Lindgren
* Paul Walmsley p...@pwsan.com [100930 09:34]: Hello Charu, On Thu, 30 Sep 2010, Varadarajan, Charulatha wrote: diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c index 8e2f0aa..9f44fc6 100644 --- a/arch/arm/mach-omap2/devices.c +++

Re: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-09-30 Thread Cousson, Benoit
On 9/30/2010 5:55 PM, Varadarajan, Charulatha wrote: Tony/ Benoit, I think that disabling it should be done only if the CONFIG_OMAP_WDT is not set. How about disabling is done always unless CONFIG_WATCHDOG_NOWAYOUT is set? As given in the patch description, this patch does a disable of

RE: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-09-30 Thread Shilimkar, Santosh
...@vger.kernel.org; linux-watch...@vger.kernel.org; linux-arm- ker...@lists.infradead.org; p...@pwsan.com; Nayak, Rajendra; Basak, Partha Subject: RE: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init Tony/ Benoit, I think that disabling it should be done only

RE: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-09-30 Thread Varadarajan, Charulatha
Tony/ Benoit, I think that disabling it should be done only if the CONFIG_OMAP_WDT is not set. How about disabling is done always unless CONFIG_WATCHDOG_NOWAYOUT is set? As given in the patch description, this patch does a disable of watchdog timer, during init, to avoid the system

Re: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-09-30 Thread Kevin Hilman
Hilman; Menon, Nishanth; w...@iguana.be; linux- o...@vger.kernel.org; linux-watch...@vger.kernel.org; linux-arm- ker...@lists.infradead.org; p...@pwsan.com; Nayak, Rajendra; Basak, Partha Subject: RE: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init Tony/ Benoit, I think