Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

2008-09-24 Thread Felipe Balbi
On Tue, Sep 23, 2008 at 12:45:42PM -0700, David Brownell wrote: On Tuesday 23 September 2008, Koen Kooi wrote: The clean fix requires twl4030 to be a new style driver. Fix not yet available. :( Pushing until we have a better fix. But twl4030 now is a new style driver, so we

Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

2008-09-24 Thread Tony Lindgren
* Felipe Balbi [EMAIL PROTECTED] [080924 13:45]: On Tue, Sep 23, 2008 at 12:45:42PM -0700, David Brownell wrote: On Tuesday 23 September 2008, Koen Kooi wrote: The clean fix requires twl4030 to be a new style driver. Fix not yet available. :( Pushing until we have a better

Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

2008-09-24 Thread David Brownell
On Wednesday 24 September 2008, Felipe Balbi wrote: I'll do the GPIO code, which will be a slightly more interesting example than the RTC. I can do the keypad since I'm already working on the usb as well. OK. Good to know folk are actively working on getting this in shape for upstream!

Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

2008-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2008 at 08:34:16AM -0700, David Brownell wrote: On Wednesday 24 September 2008, Felipe Balbi wrote: I'll do the GPIO code, which will be a slightly more interesting example than the RTC. I can do the keypad since I'm already working on the usb as well. OK. Good

Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

2008-09-23 Thread Tony Lindgren
* David Brownell [EMAIL PROTECTED] [080920 20:23]: On Friday 19 September 2008, arun c wrote: without this the below error messages were coming continuously TWL4030 module irq 369 is disabled but can't be masked! I can see how it would fix that. :) But this is also a good

Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

2008-09-23 Thread Koen Kooi
Op 23 sep 2008, om 13:00 heeft Tony Lindgren het volgende geschreven: * David Brownell [EMAIL PROTECTED] [080920 20:23]: On Friday 19 September 2008, arun c wrote: without this the below error messages were coming continuously TWL4030 module irq 369 is disabled but can't be masked! I can

Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

2008-09-23 Thread David Brownell
On Tuesday 23 September 2008, Koen Kooi wrote: The clean fix requires twl4030 to be a new style driver. Fix not yet available. :( Pushing until we have a better fix. But twl4030 now is a new style driver, so we have a start :) But who's working on it? :) Sketch of solution: -

[PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

2008-09-20 Thread arun c
without this the below error messages were coming continuously TWL4030 module irq 369 is disabled but can't be masked! 2TWL4030 module irq 369 is disabled but can't be masked! Signed-off-by: Arun C [EMAIL PROTECTED] --- arch/arm/mach-omap2/board-omap3evm.c |2 ++ 1 files changed, 2

Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

2008-09-20 Thread Felipe Balbi
On Sat, Sep 20, 2008 at 02:51:40AM -0400, arun c wrote: without this the below error messages were coming continuously TWL4030 module irq 369 is disabled but can't be masked! 2TWL4030 module irq 369 is disabled but can't be masked! Signed-off-by: Arun C [EMAIL PROTECTED] Acked-by: Felipe

Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

2008-09-20 Thread David Brownell
On Friday 19 September 2008, arun c wrote: without this the below error messages were coming continuously TWL4030 module irq 369 is disabled but can't be masked! I can see how it would fix that. :) But this is also a good illustration of why this keypad device should be initialized