Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

2010-09-10 Thread Felipe Balbi
Hi, On Thu, Sep 09, 2010 at 12:28:27PM -0500, venki kaps wrote: one thing i have not understood, why it requires to power down when the device is booted without a USB cable? why would the phy be powered up for no use ? After booting, just attach/detach the usb cable, then i have not seen

Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

2010-09-09 Thread Felipe Balbi
On Wed, Sep 08, 2010 at 08:49:08PM -0500, Ming Lei wrote: 2010/9/8 venki kaps venkiece2...@gmail.com:  To resolve the above issue, we have made PHY power on in battery adc on function  and PHY power down in battery adc off function. Good news, the temperature is bad value from battery adc if

Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

2010-09-09 Thread venki kaps
Venkii, On Thu, Sep 9, 2010 at 3:01 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Sep 08, 2010 at 08:49:08PM -0500, Ming Lei wrote: 2010/9/8 venki kaps venkiece2...@gmail.com:  To resolve the above issue, we have made PHY power on in battery adc on function  and PHY power down in battery

Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

2010-09-08 Thread venki kaps
applied  patch but still the same issue. Are you applying the patch below?         http://marc.info/?l=linux-omapm=128378686221264w=2 The patch(USB: otg: twl4030: fix phy initialization(v1)) above is against 2.6.36-rc3, I don't think you can apply it directly on 2.6.32. And the patch

Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

2010-09-08 Thread Ming Lei
2010/9/8 venki kaps venkiece2...@gmail.com:  To resolve the above issue, we have made PHY power on in battery adc on function  and PHY power down in battery adc off function. Good news, the temperature is bad value from battery adc if otg phy is power down. Maybe you only need to power on otg

Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

2010-09-07 Thread Felipe Balbi
Hi, On Tue, 7 Sep 2010 11:49:38 +0900, venki kaps venkiece2...@gmail.com wrote: let me see if I understand you right. The consumption is higher when the cable is kept plugged or the consumption is higher if you boot with usb cable pugged and remove it afterwards ? The consumption is higher

Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

2010-09-07 Thread venki kaps
Venkii, On Tue, Sep 7, 2010 at 6:16 PM, Felipe Balbi m...@felipebalbi.com wrote: Hi, On Tue, 7 Sep 2010 11:49:38 +0900, venki kaps venkiece2...@gmail.com wrote: let me see if I understand you right. The consumption is higher when the cable is kept plugged or the consumption is higher if you

Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

2010-09-07 Thread Ming Lei
       HSOTGUSB_STANDBY - Active  Even i have applied  patch but still the same issue. Are you applying the patch below? http://marc.info/?l=linux-omapm=128378686221264w=2 The patch(USB: otg: twl4030: fix phy initialization(v1)) above is against 2.6.36-rc3, I don't think you can apply it directly

Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

2010-09-07 Thread venki kaps
: otg: twl4030: fix phy initialization(v1)) above is against 2.6.36-rc3, I don't think you can apply it directly on 2.6.32. And the patch is introduced to fix the problems caused by          commit 461c317705eca5cac09a360f488715927fd0a927. which change is committed into mainline 2.6.36-rc3

Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

2010-09-07 Thread Ming Lei
=linux-omapm=128378686221264w=2 The patch(USB: otg: twl4030: fix phy initialization(v1)) above is against 2.6.36-rc3, I don't think you can apply it directly on 2.6.32. And the patch is introduced to fix the problems caused by          commit 461c317705eca5cac09a360f488715927fd0a927. which

Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

2010-09-07 Thread venki kaps
the same issue. Are you applying the patch below?         http://marc.info/?l=linux-omapm=128378686221264w=2 The patch(USB: otg: twl4030: fix phy initialization(v1)) above is against 2.6.36-rc3, I don't think you can apply it directly on 2.6.32. And the patch is introduced to fix the problems

Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

2010-09-07 Thread venki kaps
idle        HSOTGUSB_STANDBY - Active  Even i have applied  patch but still the same issue. Are you applying the patch below?         http://marc.info/?l=linux-omapm=128378686221264w=2 The patch(USB: otg: twl4030: fix phy initialization(v1)) above is against 2.6.36-rc3, I don't think you

Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

2010-09-07 Thread venki kaps
: twl4030: fix phy initialization(v1)) above is against 2.6.36-rc3, I don't think you can apply it directly on 2.6.32. And the patch is introduced to fix the problems caused by          commit 461c317705eca5cac09a360f488715927fd0a927. which change is committed into mainline 2.6.36-rc3.   Yes

[PATCH] USB: otg: twl4030: fix phy initialization(v1)

2010-09-06 Thread tom . leiming
From: Ming Lei tom.leim...@gmail.com Commit 461c317705eca5cac09a360f488715927fd0a927(into 2.6.36-v3) is put forward to power down phy if no usb cable is connected, but does introduce the two issues below: 1), phy is not into work state if usb cable is connected with PC during poweron, so musb

[PATCH] USB: otg: twl4030: fix phy initialization(v1)

2010-09-06 Thread venki kaps
Dear USB experts, Is the same fix valid for omap3430 + 2.6.32 Kernel? I have been facing mp3 playback idle current consumption 20mA more after booting without USB cable connected but If USB cable detach and attach happen, then able to hit proper values otherwise irrespective of cold/warm

Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

2010-09-06 Thread Felipe Balbi
Hi, On Tue, 7 Sep 2010 03:10:30 +0900, venki kaps venkiece2...@gmail.com wrote: Dear USB experts, Is the same fix valid for omap3430 + 2.6.32 Kernel? 3.6.32 ?? difficult to say. Why such an old kernel ? Although I doubt musb or twl4030-usb driver has changed that much, it's difficult to

Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

2010-09-06 Thread venki kaps
Venkii. On Tue, Sep 7, 2010 at 5:22 AM, Felipe Balbi m...@felipebalbi.com wrote: Hi, On Tue, 7 Sep 2010 03:10:30 +0900, venki kaps venkiece2...@gmail.com wrote: Dear USB experts,   Is the same fix valid for omap3430 + 2.6.32 Kernel? 3.6.32 ?? difficult to say. Why such an old kernel ?

Re: [PATCH] USB: otg: twl4030: fix phy initialization

2010-09-05 Thread Ming Lei
2010/9/5 Felipe Balbi m...@felipebalbi.com: Hi, On Sat, 4 Sep 2010 23:36:39 +0800, Ming Lei tom.leim...@gmail.com wrote: Considered bit PHYPWD of PHY_PWR_CTRL is zero at default, say, OTG phy is not put into power down after system poweron, so 2.6.36-rc3 will make musb device mode broken if

Re: [PATCH] USB: otg: twl4030: fix phy initialization

2010-09-05 Thread Felipe Balbi
Hi, On Sun, 5 Sep 2010 14:42:51 +0800, Ming Lei tom.leim...@gmail.com wrote: issue #1:(musb device not work with cable connected with PC) -twl-asleep is set as zero in .probe since bootloader has not powerdown phy -EVENT_VBUS returned from twl4030_usb_linkstat since usb cable

Re: [PATCH] USB: otg: twl4030: fix phy initialization

2010-09-05 Thread Ming Lei
2010/9/5 Felipe Balbi m...@felipebalbi.com: Hi, On Sun, 5 Sep 2010 14:42:51 +0800, Ming Lei tom.leim...@gmail.com wrote: issue #1:(musb device not work with cable connected with PC)         -twl-asleep is set as zero in .probe since bootloader has not powerdown phy         -EVENT_VBUS

Re: [PATCH] USB: otg: twl4030: fix phy initialization

2010-09-04 Thread Ming Lei
Felipe, Considered bit PHYPWD of PHY_PWR_CTRL is zero at default, say, OTG phy is not put into power down after system poweron, so 2.6.36-rc3 will make musb device mode broken if bootloader doesn't touch PHYPWD of PHY_PWR_CTRL. Could you ack the patch if no further objections or give other

Re: [PATCH] USB: otg: twl4030: fix phy initialization

2010-09-04 Thread Felipe Balbi
Hi, On Sat, 4 Sep 2010 23:36:39 +0800, Ming Lei tom.leim...@gmail.com wrote: Considered bit PHYPWD of PHY_PWR_CTRL is zero at default, say, OTG phy is not put into power down after system poweron, so 2.6.36-rc3 will make musb device mode broken if bootloader doesn't touch PHYPWD of

[PATCH] USB: otg: twl4030: fix phy initialization

2010-09-02 Thread tom . leiming
From: Ming Lei tom.leim...@gmail.com Commit 461c317705eca5cac09a360f488715927fd0a927(into 2.6.36-v3) is put forward to power down phy if no usb cable is connected, but does introduce the two issues below: 1), phy is not into work state if usb cable is connected with PC during poweron, so musb

Re: [PATCH] USB: otg: twl4030: fix phy initialization

2010-09-02 Thread Felipe Balbi
Hi, On Thu, 2 Sep 2010 23:58:18 +0800, tom.leim...@gmail.com wrote: From: Ming Lei tom.leim...@gmail.com Commit 461c317705eca5cac09a360f488715927fd0a927(into 2.6.36-v3) is put forward to power down phy if no usb cable is connected, but does introduce the two issues below: 1), phy is not

Re: [PATCH] USB: otg: twl4030: fix phy initialization

2010-09-02 Thread Ming Lei
2010/9/3 Felipe Balbi m...@felipebalbi.com: Hi, thanks for your comments. On Thu,  2 Sep 2010 23:58:18 +0800, tom.leim...@gmail.com wrote: From: Ming Lei tom.leim...@gmail.com Commit 461c317705eca5cac09a360f488715927fd0a927(into 2.6.36-v3) is put forward to power down phy if no usb cable