Re: [PATCH] arch/arm/plat-omap: initializing dma_lch_count, before judging omap_dma_reserve_channels

2013-01-11 Thread Chen Gang
于 2013年01月11日 15:26, Santosh Shilimkar 写道: On Friday 11 January 2013 10:33 AM, Chen Gang wrote: �� 2013��01��10�� 18:48, Santosh Shilimkar д��: 'omap_dma_reserve_channels' when used is suppose to be from command line. Hence the proposed fix in the review is the right one. ok, thank you

[PATCH] arch/arm/plat-omap: initializing dma_lch_count, before judging omap_dma_reserve_channels

2013-01-10 Thread Chen Gang
dma_lch_count is zero before 1st call of omap_system_dma_probe. omap_dma_reserve_channels has value before 1st call of omap_system_dma_probe when 1st call of omap_system_dma_probe we need set dma_lch_count before use it for judging or which will be failed for

Re: [PATCH] arch/arm/plat-omap: initializing dma_lch_count, before judging omap_dma_reserve_channels

2013-01-10 Thread Santosh Shilimkar
On Thursday 10 January 2013 03:59 PM, Chen Gang wrote: dma_lch_count is zero before 1st call of omap_system_dma_probe. omap_dma_reserve_channels has value before 1st call of omap_system_dma_probe when 1st call of omap_system_dma_probe we need set dma_lch_count before use it for

Re: [PATCH] arch/arm/plat-omap: initializing dma_lch_count, before judging omap_dma_reserve_channels

2013-01-10 Thread Santosh Shilimkar
On Thursday 10 January 2013 04:18 PM, Santosh Shilimkar wrote: On Thursday 10 January 2013 03:59 PM, Chen Gang wrote: dma_lch_count is zero before 1st call of omap_system_dma_probe. omap_dma_reserve_channels has value before 1st call of omap_system_dma_probe when 1st call of

Re: [PATCH] arch/arm/plat-omap: initializing dma_lch_count, before judging omap_dma_reserve_channels

2013-01-10 Thread Chen Gang
于 2013年01月10日 18:48, Santosh Shilimkar 写道: 'omap_dma_reserve_channels' when used is suppose to be from command line. Hence the proposed fix in the review is the right one. ok, thank you for your suggestion. I will send patch v2, also mark you as Signed-of-by. :-) -- Chen Gang Asianux

Re: [PATCH] arch/arm/plat-omap: initializing dma_lch_count, before judging omap_dma_reserve_channels

2013-01-10 Thread Chen Gang
于 2013年01月10日 18:51, Santosh Shilimkar 写道: Another thing. please fix the subject line. It should be something like below. ARM: OMAP: Fix the use of uninitialized dma_lch_count ok, thank you for your suggestion I will use it as subject for patch v2. :-) -- Chen Gang Asianux

Re: [PATCH] arch/arm/plat-omap: initializing dma_lch_count, before judging omap_dma_reserve_channels

2013-01-10 Thread Santosh Shilimkar
On Friday 11 January 2013 10:33 AM, Chen Gang wrote: 于 2013年01月10日 18:48, Santosh Shilimkar 写道: 'omap_dma_reserve_channels' when used is suppose to be from command line. Hence the proposed fix in the review is the right one. ok, thank you for your suggestion. I will send patch v2,