Re: [PATCH] clk: add flags to distinguish xtal clocks

2013-11-13 Thread Maxime Ripard
On Tue, Nov 12, 2013 at 10:05:49AM +0200, Luca Coelho wrote: What I'm not really convinced about is *how* you carry that metadata in the DT, that's all, nothing more. Okay, I get you. My point is that being a crystal or not *is* a characteristic of the clock, so I think it could be part

Re: [PATCH] clk: add flags to distinguish xtal clocks

2013-11-12 Thread Luca Coelho
On Mon, 2013-11-11 at 21:59 +0100, Maxime Ripard wrote: Hi Luca, On Mon, Nov 11, 2013 at 09:50:56PM +0200, Luca Coelho wrote: On Mon, 2013-11-11 at 13:42 -0600, Felipe Balbi wrote: + if (of_property_read_bool(node, clock-xtal)) + flags |= CLK_IS_TYPE_XTAL; +

Re: [PATCH] clk: add flags to distinguish xtal clocks

2013-11-11 Thread Stephen Warren
On 11/08/2013 11:00 AM, Felipe Balbi wrote: From: Luciano Coelho l...@coelho.fi Add a flag that indicate whether the clock is a crystal or not. Additionally, parse a new device tree binding in clk-fixed-rate to set this flag. If clock-xtal isn't set, the clock framework will assume

Re: [PATCH] clk: add flags to distinguish xtal clocks

2013-11-11 Thread Felipe Balbi
Hi, On Sun, Nov 10, 2013 at 12:37:16PM +0100, Maxime Ripard wrote: Hi Felipe, On Fri, Nov 08, 2013 at 12:00:48PM -0600, Felipe Balbi wrote: From: Luciano Coelho l...@coelho.fi Add a flag that indicate whether the clock is a crystal or not. Additionally, parse a new device tree

Re: [PATCH] clk: add flags to distinguish xtal clocks

2013-11-11 Thread Felipe Balbi
Hi, On Mon, Nov 11, 2013 at 09:27:58AM -0700, Stephen Warren wrote: On 11/08/2013 11:00 AM, Felipe Balbi wrote: From: Luciano Coelho l...@coelho.fi Add a flag that indicate whether the clock is a crystal or not. Additionally, parse a new device tree binding in clk-fixed-rate to set

Re: [PATCH] clk: add flags to distinguish xtal clocks

2013-11-11 Thread Luca Coelho
On Mon, 2013-11-11 at 13:42 -0600, Felipe Balbi wrote: Hi, On Sun, Nov 10, 2013 at 12:37:16PM +0100, Maxime Ripard wrote: Hi Felipe, On Fri, Nov 08, 2013 at 12:00:48PM -0600, Felipe Balbi wrote: From: Luciano Coelho l...@coelho.fi Add a flag that indicate whether the clock is

Re: [PATCH] clk: add flags to distinguish xtal clocks

2013-11-11 Thread Maxime Ripard
On Mon, Nov 11, 2013 at 01:42:47PM -0600, Felipe Balbi wrote: + if (of_property_read_bool(node, clock-xtal)) + flags |= CLK_IS_TYPE_XTAL; + Introducing a new compatible instead of a property would make more sense here I think. Do you have a reason not to do so? As

Re: [PATCH] clk: add flags to distinguish xtal clocks

2013-11-11 Thread Maxime Ripard
Hi Luca, On Mon, Nov 11, 2013 at 09:50:56PM +0200, Luca Coelho wrote: On Mon, 2013-11-11 at 13:42 -0600, Felipe Balbi wrote: + if (of_property_read_bool(node, clock-xtal)) + flags |= CLK_IS_TYPE_XTAL; + Introducing a new compatible instead of a property

Re: [PATCH] clk: add flags to distinguish xtal clocks

2013-11-10 Thread Maxime Ripard
Hi Felipe, On Fri, Nov 08, 2013 at 12:00:48PM -0600, Felipe Balbi wrote: From: Luciano Coelho l...@coelho.fi Add a flag that indicate whether the clock is a crystal or not. Additionally, parse a new device tree binding in clk-fixed-rate to set this flag. If clock-xtal isn't set, the

[PATCH] clk: add flags to distinguish xtal clocks

2013-11-08 Thread Felipe Balbi
From: Luciano Coelho l...@coelho.fi Add a flag that indicate whether the clock is a crystal or not. Additionally, parse a new device tree binding in clk-fixed-rate to set this flag. If clock-xtal isn't set, the clock framework will assume clock to be generated by an oscillator. There's only

Re: [PATCH] clk: add flags to distinguish xtal clocks

2013-11-08 Thread Luca Coelho
Hi Felipe, On Fri, 2013-11-08 at 12:00 -0600, Felipe Balbi wrote: From: Luciano Coelho l...@coelho.fi Add a flag that indicate whether the clock is a crystal or not. Additionally, parse a new device tree binding in clk-fixed-rate to set this flag. If clock-xtal isn't set, the clock