Re: [PATCH] hwmon: (tmp102) Force wait for conversion time for the first valid data

2015-12-01 Thread Guenter Roeck
On 12/01/2015 06:21 AM, Nishanth Menon wrote: [ ... ] Hint about how the patch will look like: Looks ok (and better). Guenter diff --git a/drivers/hwmon/tmp102.c b/drivers/hwmon/tmp102.c index 65482624ea2c..5289aa0980a8 100644 --- a/drivers/hwmon/tmp102.c +++ b/drivers/hwmon/tmp102.c @@

Re: [PATCH] hwmon: (tmp102) Force wait for conversion time for the first valid data

2015-12-01 Thread Nishanth Menon
On 12/01/2015 09:09 AM, Guenter Roeck wrote: > On 12/01/2015 06:21 AM, Nishanth Menon wrote: > [ ... ] > >> >> Hint about how the patch will look like: > > Looks ok (and better). Thanks for the feedback. Will post the same. -- Regards, Nishanth Menon -- To unsubscribe from this list: send the

Re: [PATCH] hwmon: (tmp102) Force wait for conversion time for the first valid data

2015-12-01 Thread Nishanth Menon
Hi Guenter, Thanks for the detailed review.. On 11/30/2015 11:50 PM, Guenter Roeck wrote: > On 11/30/2015 08:25 PM, Nishanth Menon wrote: [...] >> >> A simpler alternative approach could be to sleep in the probe for the >> duration required, but that will result in latency that is undesirable

Re: [PATCH] hwmon: (tmp102) Force wait for conversion time for the first valid data

2015-12-01 Thread Nishanth Menon
On 07:47-20151201, Nishanth Menon wrote: > Hi Guenter, > > Thanks for the detailed review.. > > On 11/30/2015 11:50 PM, Guenter Roeck wrote: > > On 11/30/2015 08:25 PM, Nishanth Menon wrote: > [...] > > >> > >> A simpler alternative approach could be to sleep in the probe for the > >> duration

[PATCH] hwmon: (tmp102) Force wait for conversion time for the first valid data

2015-11-30 Thread Nishanth Menon
TMP102 works based on conversions done periodically. However, as per the TMP102 data sheet[1] the first conversion is triggered immediately after we program the configuration register. The temperature data registers do not reflect proper data until the first conversion is complete (in our case

Re: [PATCH] hwmon: (tmp102) Force wait for conversion time for the first valid data

2015-11-30 Thread Guenter Roeck
On 11/30/2015 08:25 PM, Nishanth Menon wrote: TMP102 works based on conversions done periodically. However, as per the TMP102 data sheet[1] the first conversion is triggered immediately after we program the configuration register. The temperature data registers do not reflect proper data until